[Freeciv-Dev] [bug #17496] configure failing for trunk
Follow-up Comment #11, bug #17496 (project freeciv): After latest patches my qt client compiles flawless ___ Reply to this item at: http://gna.org/bugs/?17496 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16989] freeciv doesn't run when it's compiled with ipv6 support on system without ipv6 support
Follow-up Comment #2, bug #16989 (project freeciv): Freeciv-2.2.4 working fine. You can close this bug. ___ Reply to this item at: http://gna.org/bugs/?16989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17495] Configure printing no twice for mysql_config
Follow-up Comment #3, bug #17495 (project freeciv): else part should be removed too The else part does set the variable to 'no'. The following test do onyl check if the variable is set to 'yes'. Thus, you get the same result if it exists (='no') or if it is not defined. I think that setting it to 'no' (no mysql/postgres) helps the reader to understand the code. ___ Reply to this item at: http://gna.org/bugs/?17495 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] AIs still hate my guts
As I let the AI play against the AI (= autogames) I do not see this problem. Perhaps it would help to add some debugging messages at the time the love for the human player is decreased / increased to check _why_ it is done and also why the patch for bug #16813 does not solve the problem? Am Sonntag, 16. Januar 2011, 04:14:12 schrieb Daniel Markstedt: Even after fixing bug #16813, I sense AIs hate my guts for no good reason whatsoever. In a current game (using trunk code) seven out of eight AIs I've made contact with have a constantly worsening attitude - only one of them seems to like me (currently: Respectful). They don't accept any 'bribes' to get them into a cease-fire. My score is among the lowest of the known world so they should hardly see me as a threat. My player was isolated on a small island with no international contact for the first few dozen turns, if that makes any difference. Ideas? :) Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt at mapfa.de ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17496] configure failing for trunk
Follow-up Comment #12, bug #17496 (project freeciv): It is working out of the box with the patch! ___ Reply to this item at: http://gna.org/bugs/?17496 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2185] Muscovite nation
Update of patch #2185 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2185 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2185] Muscovite nation
Follow-up Comment #2, patch #2185 (project freeciv): r18959 breaks the trunk build due to a typo. Patch attached; committing immediately. (file #11914) ___ Additional Item Attachment: File name: trunk-muskovite.diff Size:0 KB ___ Reply to this item at: http://gna.org/patch/?2185 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2185] Muscovite nation
Follow-up Comment #3, patch #2185 (project freeciv): Committed as r18960 (unfortunately it doesn't show up here as I mistakenly said gna bug #2185 instead of gna patch #2185 in the change description). ___ Reply to this item at: http://gna.org/patch/?2185 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17504] Translator comments needed
URL: http://gna.org/bugs/?17504 Summary: Translator comments needed Project: Freeciv Submitted by: jcreus Submitted on: Sun Jan 16 16:46:29 2011 Category: None Severity: 2 - Minor Priority: 3 - Low Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: I have a doubt on the translation of a couple of strings in helpdlg.c (both for gtk and xaw). I have tried to display the help text where these strings show up, to see the context, but it's been impossible. Can you help me? The strings are in client/gui-gtk-2.0/helpdlg.c:116: Build: client/gui-xaw/helpdlg.c:1078 :Build: %d MP\n I suspect this Build is meant for a city, but it could also be an improvement. ___ Reply to this item at: http://gna.org/bugs/?17504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17504] Translator comments needed for base help
Update of bug #17504 (project freeciv): Assigned to:None = jtn Summary: Translator comments needed = Translator comments needed for base help ___ Follow-up Comment #1: These are in the help for bases I added in patch #2049. You should be able to see them in the help for bases like fortress, airbase, and so on (Terrain Terrain Alterations Fortress, etc, in the help). They are the build cost for the base in settler-turns (that is, movement points), similar to the costs in the tables in the Terrain Terrain Alterations help topic. I'll add some TRANS comments to try to clarify this. ___ Reply to this item at: http://gna.org/bugs/?17504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2355] Tech upkeep not documented
Update of patch #2355 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_3-techupkeep-help.diff Size:1 KB ___ Reply to this item at: http://gna.org/patch/?2355 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1893] [metaticket] Help updates for 2.3.0
Update of patch #1893 (project freeciv): Depends on: = patch #2355 ___ Reply to this item at: http://gna.org/patch/?1893 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1893] [metaticket] Help updates for 2.3.0
Update of patch #1893 (project freeciv): Status:Done = In Progress Assigned to:None = jtn Open/Closed: Closed = Open ___ Reply to this item at: http://gna.org/patch/?1893 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17504] Translator comments needed for base help
Update of bug #17504 (project freeciv): Status:None = Ready For Test Planned Release: = 2.3.0-beta2 ___ Additional Item Attachment: File name: trunk-S2_3-trans-basehelp.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?17504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17301] Experimental ruleset enables 'foggedborders' without borders=SEE_INSIDE
Update of bug #17301 (project freeciv): Status: Ready For Test = Need Info Planned Release: 2.3.0 = ___ Reply to this item at: http://gna.org/bugs/?17301 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17504] Translator comments needed for base help
Update of bug #17504 (project freeciv): Status: Ready For Test = None Planned Release: 2.3.0-beta2 = ___ Follow-up Comment #2: I can see it now, thank you. Isn't MP for movement points a bit ambiguous for users, though? This is clear in the translator comments, but users don't see that. This is what we usually call worker-turns, isn't it? ___ Reply to this item at: http://gna.org/bugs/?17504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
Follow-up Comment #3, bug #17334 (project freeciv): Attached a slightly tweaked version of the patch whose strings are aligned with the default ruleset as much as possible, to reduce the number of translations required. (file #11918) ___ Additional Item Attachment: File name: ApolloGreatWonder_17334_bis.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?17334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16989] freeciv doesn't run when it's compiled with ipv6 support on system without ipv6 support
Update of bug #16989 (project freeciv): Status:None = Works For Me Open/Closed:Open = Closed ___ Follow-up Comment #3: Perhaps the fix for bug #15559 fixed this too, although I haven't thought about it terribly hard. Closing as suggested. ___ Reply to this item at: http://gna.org/bugs/?16989 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2356] Abyssinian nation
URL: http://gna.org/patch/?2356 Summary: Abyssinian nation Project: Freeciv Submitted by: dmarks Submitted on: Sun 16 Jan 2011 11:07:05 AM PST Category: rulesets Priority: 5 - Normal Status: None Privacy: Public Assigned to: mixcoatl Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Abyssinians - Ethiopians and Eritreans of old. Flag adapted from PD image by Wikimedia Commons user 'Oren neu dag' http://commons.wikimedia.org/wiki/File:Flag_of_Ethiopia_(1897).svg ___ File Attachments: --- Date: Sun 16 Jan 2011 11:07:05 AM PST Name: ethiopia_old.svg Size: 162kB By: dmarks http://gna.org/patch/download.php?file_id=11919 --- Date: Sun 16 Jan 2011 11:07:05 AM PST Name: abyssinian.ruleset Size: 1kB By: dmarks http://gna.org/patch/download.php?file_id=11920 ___ Reply to this item at: http://gna.org/patch/?2356 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2349] Chinookan nation
Follow-up Comment #2, patch #2349 (project freeciv): While the language is referred to Chinookan, i thought the people were simply referred to as Chinook? ___ Reply to this item at: http://gna.org/patch/?2349 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2349] Chinook nation
Update of patch #2349 (project freeciv): Summary:Chinookan nation = Chinook nation ___ Follow-up Comment #3: Good point - I believe you are correct. Corrected ruleset attached. (file #11921) ___ Additional Item Attachment: File name: chinook.rulesetSize:1 KB ___ Reply to this item at: http://gna.org/patch/?2349 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17506] Server segfault in map_change_own_seen() when loading savegame
URL: http://gna.org/bugs/?17506 Summary: Server segfault in map_change_own_seen() when loading savegame Project: Freeciv Submitted by: jtn Submitted on: Sun Jan 16 20:40:41 2011 Category: None Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_3 r18960 Discussion Lock: Any Operating System: GNU/Linux Planned Release: 2.3.0 ___ Details: Reproducible for me with S2_3 r18960 and attached savegame. This savegame was saved with an earlier version of S2_3 svn (circa 2010-12-16), using the experimental ruleset. The backtrace looks very similar to bug #17459, but I haven't investigated enough, so separate bug for now. Running on Ubuntu Lucid on amd64. Backtrace from GDB: #0 map_change_own_seen (pplayer=0x2a88780, ptile=0x297db70, change=0x7fffb0282050, can_reveal_tiles=value optimized out) at maphand.c:879 #1 shared_vision_change_seen (pplayer=0x2a88780, ptile=0x297db70, change=0x7fffb0282050, can_reveal_tiles=value optimized out) at maphand.c:496 #2 0x0047d0a6 in map_claim_ownership_full (ptile=0x297db70, powner=0x2a88780, psource=value optimized out, ignore_loss=0x0) at maphand.c:1590 #3 0x0049c610 in sg_load_map_owner (loading=value optimized out) at savegame2.c:2530 #4 sg_load_map (loading=value optimized out) at savegame2.c:2111 #5 0x004a4289 in savegame2_load_real (file=value optimized out) at savegame2.c:598 #6 savegame2_load (file=value optimized out) at savegame2.c:528 #7 0x0041403a in load_command (caller=value optimized out, filename=value optimized out, check=value optimized out) at stdinhand.c:3545 #8 0x0040c3e6 in srv_prepare () at srv_main.c:2251 #9 0x0040c504 in srv_main () at srv_main.c:2518 #10 0x00404137 in main (argc=value optimized out, argv=0x7fffb0284678) at civserver.c:375 ___ File Attachments: --- Date: Sun Jan 16 20:40:41 2011 Name: freeciv-T0211-Y01555-manual.sav.bz2 Size: 66kB By: jtn Savegame which segfaults with S2_3 r18960 http://gna.org/bugs/download.php?file_id=11923 ___ Reply to this item at: http://gna.org/bugs/?17506 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17459] Server segfaults in shared_vision_change_seen () when loading savegame.
Follow-up Comment #3, bug #17459 (project freeciv): See also bug #17506, which looks very similar (may be the same root cause). ___ Reply to this item at: http://gna.org/bugs/?17459 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17506] Server segfault in map_change_own_seen() when loading savegame
Follow-up Comment #1, bug #17506 (project freeciv): As for bug #17459, this savegame has borders=SEE_INSIDE. ___ Reply to this item at: http://gna.org/bugs/?17506 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17504] Translator comments needed for base help
Follow-up Comment #3, bug #17504 (project freeciv): I guess Joan's point is true for most abbreviations used throughout the game (HP = hit point, FP = firepower, A = attack, W = worker, etc.). They're handy in many contexts and usually it's possible to guess the meaning, but maybe an additions help section explaining the abbreviations would make it 100% clear? ___ Reply to this item at: http://gna.org/bugs/?17504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2355] Tech upkeep not documented
Follow-up Comment #1, patch #2355 (project freeciv): Thanks for doing the documentation work. The patch looks good! ___ Reply to this item at: http://gna.org/patch/?2355 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17496] configure failing for trunk
Follow-up Comment #14, bug #17496 (project freeciv): Thanks for all the comments. This makes it easier to make additional fixes on top of my patch. I don't think I'll use Matthias's patch. From the commet #13 alone (not reading the patch itself) it seems to make things wrong way: - fix variable name (GUI_qt_CPPFLAGS = GUI_qt_CXXFLAGS) It should be CPPFLAGS, not CXXFLAGS. I assume proper fix is needed elsewhere. - add LIBSADD= -lQtGui if nothing is set (needed?) That was already the case. You seem to be adding -IQtGui to CPPFLAGS though when testing if all needed include dirs are set already. Doesn't seem like correct behavior for me. ___ Reply to this item at: http://gna.org/bugs/?17496 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17507] Oceanic terrain class name not localized
URL: http://gna.org/bugs/?17507 Summary: Oceanic terrain class name not localized Project: Freeciv Submitted by: jcreus Submitted on: Sun Jan 16 21:15:35 2011 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3 Discussion Lock: Any Operating System: None Planned Release: ___ Details: The Oceanic string for the terrain class name doesn't appear in freeciv.pot (it was there in 2.2). And since we are at it, would it be possible to have a qualified string for Land? I would like to use different words to translate Land unit and Land terrain class. ___ Reply to this item at: http://gna.org/bugs/?17507 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17506] Server segfault in map_change_own_seen() when loading savegame
Update of bug #17506 (project freeciv): Status:None = Ready For Test Assigned to:None = syntron Planned Release: 2.3.0 = 2.3.0, 2.4.0 ___ Follow-up Comment #2: Could you please test the attached patch? For me it fixed the segfault ... fix server segfault in shared_vision_change_seen() * move loading of map knowledge before loading of map owner / worked map as it is needed there * add an assert in map_get_player_tile() to check if the map was initialised (file #11924) ___ Additional Item Attachment: File name: 20110116-fix-server-segfault-in-shared_vision_change_seen.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?17506 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17465] genlist.c::358]: assertion '((void *)0) != pgenlist' failed.
Follow-up Comment #1, bug #17465 (project freeciv): could you check if patch #2344 does fixes this bug? ___ Reply to this item at: http://gna.org/bugs/?17465 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17506] Server segfault in map_change_own_seen() when loading savegame
Follow-up Comment #3, bug #17506 (project freeciv): I'll try your patch. In the meantime: 2.3.0-beta1 (and S2_3 at the branch point) don't show the problem. A git bisect run on S2_3 suggests that r18812 (bug #17372) is when the segfaults started. I haven't looked at the changes at all; does that sound plausible? ___ Reply to this item at: http://gna.org/bugs/?17506 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17502] No unit classes?!? with fantasy modpack
Update of bug #17502 (project freeciv): Status:None = Invalid Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17502 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17507] Oceanic terrain class name not localized
Follow-up Comment #1, bug #17507 (project freeciv): I think terrain class names are never shown to users, but are only used in rulesets. So no translation needed. ___ Reply to this item at: http://gna.org/bugs/?17507 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17465] genlist.c::358]: assertion '((void *)0) != pgenlist' failed.
Follow-up Comment #2, bug #17465 (project freeciv): Seems so. I downgraded to r18889 and applied patch #2344 on top of that and error message did not appear. ___ Reply to this item at: http://gna.org/bugs/?17465 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2311] Move could_unit_move_to_tile() from ai/ to advisors/
Follow-up Comment #1, patch #2311 (project freeciv): This patch seems to cause autogames to differ. I'm not 100% sure autogames are currently totally reproducible (there has been some problems with that in past couple of years, and I don't know if reason has ever been found and fixed). Anyway, I continue investigation and postpone committing this (and following patches in the series) ___ Reply to this item at: http://gna.org/patch/?2311 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17496] configure failing for trunk
Follow-up Comment #15, bug #17496 (project freeciv): - fix variable name (GUI_qt_CPPFLAGS = GUI_qt_CXXFLAGS) It should be CPPFLAGS, not CXXFLAGS. I assume proper fix is needed elsewhere. At the moment one (GUI_qt_CPPFLAGS) is used in qt-client.m4 while the other (GUI_qt_CXXFLAGS) is used in the makefile and configure.ac - so I selected the wrong point to change it ... - add LIBSADD= -lQtGui if nothing is set (needed?) That was already the case. You seem to be adding -IQtGui to CPPFLAGS though when testing if all needed include dirs are set already. Doesn't seem like correct behavior for me. Sorry, I did not test this on separately but it seems to be a good idea to add this header search path in the 'default' case ... ___ Reply to this item at: http://gna.org/bugs/?17496 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2306] Add modpack version information to modpack.list
Update of patch #2306 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2306 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17496] configure failing for trunk
Follow-up Comment #16, bug #17496 (project freeciv): At the moment one ... This is trunk with file #11910 ___ Reply to this item at: http://gna.org/bugs/?17496 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17506] Server segfault in map_change_own_seen() when loading savegame
Follow-up Comment #4, bug #17506 (project freeciv): 2.3.0-beta1 (and S2_3 at the branch point) don't show the problem. A git bisect run on S2_3 suggests that r18812 (bug #17372) is when the segfaults started. I haven't looked at the changes at all; does that sound plausible? Sounds possible (not tested). The handling of the map knowledge is tricky due to the fact that there are so much different possibilities to define this setting in savegames / scenarios ___ Reply to this item at: http://gna.org/bugs/?17506 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17496] configure failing for trunk
Follow-up Comment #17, bug #17496 (project freeciv): GUI_qt_CXXFLAGS) is used in the makefile and configure.ac - so I selected the wrong point to change it ... There is actually long (probably from the very beginning of Freeciv project 15 years ago) standing bug in how CPPFLAGS, CFLAGS (and now CXXFLAGS) are used. I'm going to fix it eventually, but in the meanwhile I just don't want to add more similarly wrong usage. ___ Reply to this item at: http://gna.org/bugs/?17496 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17506] Server segfault in map_change_own_seen() when loading savegame
Follow-up Comment #5, bug #17506 (project freeciv): Sounds possible (not tested). Some background: at the moment there are two types of savegames which use a different order of loading the data. A previous patch (bug #17158) fixed new savegames but broke loading of old savegames. In bug #17372 loading was fixed for both by moving the loading of map knowledge. The problem here is, that in this case the map knowledge is needed before it is loaded. Because there is no error check, the code did try to use a NULL pointer ... segfault ... ___ Reply to this item at: http://gna.org/bugs/?17506 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17507] Oceanic terrain class name not localized
Follow-up Comment #2, bug #17507 (project freeciv): I've seen it in client/helpdata.c:532, the help for bases mentioned in bug #17504. The string is Requires %s terrain class on the tile.n. For the Buoy, this terrain class is Oceanic. There's also Requires %s terrain class on an adjacent tile.n as the next string, and %s can't build %s from the worklist; %s terrain class is required. in cityturn.c ___ Reply to this item at: http://gna.org/bugs/?17507 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17508] Loading savegames for Britain/Europe scenarios gives many errors and server segfault
URL: http://gna.org/bugs/?17508 Summary: Loading savegames for Britain/Europe scenarios gives many errors and server segfault Project: Freeciv Submitted by: jtn Submitted on: Sun Jan 16 22:43:19 2011 Category: None Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: Split out from bug #17459, where roywephy originally reported it: Trunk and S2_3 (r18960), and reportedly trunk r18867, give lots of errors and crash when loading savegames created from the bundled british-isles-85x80-v2.80 (73x81) and europe-200x100-v2 (177x100) scenarios. roywephy suggests https://gna.org/bugs/?17459#comment2 that this is correlated with an odd width (and/or possibly height). I notice that I not allowed to manually set odd width or height via xsize/ysize server settings (The map width must be an even value), but I don't know why that is. If the map width/height is required to be even for some reason, do we need to tweak the bundled scenarios, and possibly add assertions/errors on scenario and savefile load to catch odd widths/heights? Are there any valid savegames/scenarios that we'd refuse to load as a result? (I note that the relevant scenarios have the same proportions on S2_2, so the answer is probably yes.) Here are the errors and backtrace I get for S2_3 r18958 on the attached europe.sav.bz2. Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8 This is the server for Freeciv version 2.3.0-beta1+ (beta version) You can learn a lot about Freeciv at http://www.freeciv.org/ THIS IS A BETA VERSION Freeciv 2.3.0 will be released in March, at http://www.freeciv.org/ 2: Loading rulesets. 2: AI*1 has been added as Easy level AI-controlled player. 2: AI*2 has been added as Easy level AI-controlled player. 2: AI*3 has been added as Easy level AI-controlled player. 2: AI*4 has been added as Easy level AI-controlled player. 2: AI*5 has been added as Easy level AI-controlled player. 1: Error restoring 'xsize': The map width must be an even value. 1: Error restoring 'generator': You cannot disable the map generator. 1: Error restoring 'onsetbarbs': Value out of range: -2000 (min: 0; max: 32767). 2: Removing player AI*1. 2: Removing player AI*2. 2: Removing player AI*3. 2: Removing player AI*4. 2: Removing player AI*5. 1: Saved game contains incomplete map data. This can happen with old saved games, or it may indicate an invalid saved game file. Proceed at your own risk. 1: Start position native coordinates (66, 29) do not exist in this map. Skipping ... 1: Start position native coordinates (78, 55) do not exist in this map. Skipping... 1: Start position native coordinates (88, 33) do not exist in this map. Skipping... 1: Start position native coordinates (72, 54) do not exist in this map. Skipping... 1: Start position native coordinates (120, 24) do not exist in this map. Skipping... 1: Start position native coordinates (76, 50) do not exist in this map. Skipping... 1: Start position native coordinates (88, 67) do not exist in this map. Skipping... 1: Start position native coordinates (113, 44) do not exist in this map. Skipping... 1: Start position native coordinates (81, 70) do not exist in this map. Skipping... 1: Start position native coordinates (73, 40) do not exist in this map. Skipping... 1: Start position native coordinates (109, 59) do not exist in this map. Skipping... 1: Start position native coordinates (97, 65) do not exist in this map. Skipping... 1: Start position native coordinates (134, 95) do not exist in this map. Skipping... 1: Start position native coordinates (97, 20) do not exist in this map. Skipping... 1: Start position native coordinates (77, 62) do not exist in this map. Skipping... 1: Start position native coordinates (101, 87) do not exist in this map. Skipping... 1: Start position native coordinates (155, 84) do not exist in this map. Skipping... 1: Start position native coordinates (121, 80) do not exist in this map. Skipping... 1: Start position native coordinates (89, 42) do not exist in this map. Skipping... 1: Start position native coordinates (94, 26) do not exist in this map. Skipping... 1: Start position native coordinates (85, 53) do not exist in this map. Skipping... 1: Start position native coordinates (86, 58) do not exist in this map. Skipping... 1: Start position native coordinates (80, 67) do not exist in this map. Skipping... 1: Start position native coordinates (71, 76) do not exist in this map. Skipping... 1: Start position native coordinates (92, 13) do not exist in this map. Skipping... 1: Start position native coordinates (78, 20) do not exist in this map. Skipping...
[Freeciv-Dev] [bug #17459] Server segfaults in shared_vision_change_seen () when loading savegame.
Update of bug #17459 (project freeciv): Status:None = Duplicate Open/Closed:Open = Closed ___ Follow-up Comment #5: I could reproduce the segfault when loading file #11775 with trunk r18960, and the patch for bug #17506 fixed it for me. I can also reproduce the issues with scenarios mentioned in comment #2 -- just load scenario, save a game straight away, and try to load it. However, the patch for bug #17506 makes no difference to this crash. I think it's a separate bug, so I've raised bug #17508. On the strength of this, since the patch is in bug #17506, I'm closing this as a duplicate (even though this one was first). ___ Reply to this item at: http://gna.org/bugs/?17459 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17506] Server segfault in map_change_own_seen() when loading savegame
Follow-up Comment #6, bug #17506 (project freeciv): I confirm that your patch fixes the segfault for me, thanks. ___ Reply to this item at: http://gna.org/bugs/?17506 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17507] Oceanic terrain class name not localized
Update of bug #17507 (project freeciv): Status:None = In Progress Assigned to:None = jtn ___ Reply to this item at: http://gna.org/bugs/?17507 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17509] Qualify string Land for i18n (unit vs terrain class)
URL: http://gna.org/bugs/?17509 Summary: Qualify string Land for i18n (unit vs terrain class) Project: Freeciv Submitted by: jtn Submitted on: Sun Jan 16 23:54:48 2011 Category: None Severity: 2 - Minor Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.2.5,2.3.0-beta2 ___ Details: Requested by Joan Creus in bug #17507: And since we are at it, would it be possible to have a qualified string for Land? I would like to use different words to translate Land unit and Land terrain class. Unfortunately it's not practical to add a qualifier to the terrain class (since it's done with specenum on S2_3/trunk, the rule name and translated name aren't sufficiently distinguished), but we can add one to the unit class. ___ Reply to this item at: http://gna.org/bugs/?17509 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17507] Oceanic terrain class name not localized
Update of bug #17507 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.3.0-beta2 ___ Follow-up Comment #3: Looks like common/terrain.h wasn't added to POTFILES.in when terrain classes were specenumified. In passing I've also removed i18n marking from the TerrainAlter flags (CanRoad, CanIrrigate, CanMine), as they're never actually presented to the user (this applies to S2_2 as well). I've raised a new bug for qualifying Land (bug #17509). (file #11927, file #11928) ___ Additional Item Attachment: File name: trunk-S2_3-oceanic-i18n.diff Size:1 KB File name: S2_2-terrainalter-noi18n.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?17507 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17509] Qualify string Land for i18n (unit vs terrain class)
Additional Item Attachment, bug #17509 (project freeciv): File name: trunk-S2_3-land-unitclass-qual.diff Size:9 KB File name: S2_2-land-unitclass-qual.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?17509 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17509] Qualify string Land for i18n (unit vs terrain class)
Follow-up Comment #1, bug #17509 (project freeciv): That's just fine, thanks. ___ Reply to this item at: http://gna.org/bugs/?17509 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17504] Translator comments needed for base help
Follow-up Comment #4, bug #17504 (project freeciv): Isn't MP for movement points a bit ambiguous for users, though? This is clear in the translator comments, but users don't see that. This is what we usually call worker-turns, isn't it? It is the settler-turns or worker-turns concept, but I don't think that term is used elsewhere in the built-in help (the Terrain Alterations topic comes closest with the number of turns required for one unit of Settlers or Workers to complete an activity). I'm trying to avoid referring to specific unit names to allow for exotic rulesets which may not have Settlers, Workers, or Engineers units (yes, the Terrain Alterations topic currently fails this test miserably), which leaves movement points as the only description left. It sort-of ties into the text in the Units help, although that could be more explicit. Re abbreviations: hm. Not sure about an abbreviations section of the docs; perhaps tooltips for places like this when they're mentioned? ___ Reply to this item at: http://gna.org/bugs/?17504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17504] Translator comments needed for base help
Update of bug #17504 (project freeciv): Status:None = Ready For Test Planned Release: = 2.3.0-beta2 ___ Reply to this item at: http://gna.org/bugs/?17504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17504] Translator comments needed for base help
Follow-up Comment #5, bug #17504 (project freeciv): Re: abbreviations. Tooltip seems even better. Anything that would expand the abbreviation to the user, I guess. ___ Reply to this item at: http://gna.org/bugs/?17504 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17510] Invalid lightning bolt expression in the help system
URL: http://gna.org/bugs/?17510 Summary: Invalid lightning bolt expression in the help system Project: Freeciv Submitted by: hubkow Submitted on: Mon Jan 17 01:48:36 2011 Category: None Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.2.4, 2.3.0b1 Discussion Lock: Any Operating System: None Planned Release: ___ Details: The help system says that unhappy cities are marked with a lightning bolt, which is true for trident and hex tilesets, but not for amplio (here the label is a raised fist). A minor thing, but since amplio is the default tileset, it can cause some confusion. ___ Reply to this item at: http://gna.org/bugs/?17510 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
