[Freeciv-Dev] [patch #5090] Minimum gtk3 version to 3.8

2014-08-25 Thread Jacob Nevins
Follow-up Comment #1, patch #5090 (project freeciv):

Just checked and this doesn't make things any worse for Debian-based distros.
libgtk-3-0 versions:
* Debian: stable (wheezy) 3.4.2-7, jessie (testing, will be next stable)
currently 3.12.2-3
* Ubuntu: precise (old LTS, 12.04) 3.4.2-0ubuntu0.7, trusty (14.04LTS)
3.10.8-0ubuntu1. Last version with 3.6 was raring (13.04) which is already
unsupported.

___

Reply to this item at:

  http://gna.org/patch/?5090

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22510] The SDL clients use client side knowledge to evaluate action enablers

2014-08-25 Thread Sveinung Kvilhaugsvik
Update of bug #22510 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22510

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22282] convert_string() / iconv() error reporting could be more specific

2014-08-25 Thread Jacob Nevins
Follow-up Comment #1, bug #22282 (project freeciv):

I wondered about just adding fc_strerror(fc_get_errno()) to the string.

However, on Windows, that turns into FormatMessage(GetLastError()),
effectively. This isn't appropriate for errors returned by iconv, which I
think sets the real errno (which is separate from GetLastError()) and thus
should have the real system strerror() called on it. (I think Windows has an
EILSEQ/EINVAL etc so should be able to provide useful strings for it.)

Nearby we have


/* TRANS: Could not convert text from encoding a to encoding b: 
 *externally translated error string.*/
fprintf(stderr, _(Could not convert text from %s to %s: %s),
from, to, fc_strerror(fc_get_errno()));


which I think will currently do the Wrong Thing on Windows (should it ever
occur), so should be fixed at the same time.

However, I can't test Windows builds, so I'm not confident making these
changes.

(I guess we probably get away with calling fc_strerror() after fopen() etc
because that probably also sets the error code retrieved from GetLastError()
as well as the POSIX-y errno? But I don't think the third-party iconv library
will do so, or at least I've found no evidence in the source code.)

___

Reply to this item at:

  http://gna.org/bugs/?22282

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4722] City production discount effect

2014-08-25 Thread Jacob Nevins
Follow-up Comment #4, patch #4722 (project freeciv):

Patch #4470 was a less developed version of this idea (that I forgot I raised,
sigh). The description there may be more digestible than this one...

The only point raised there not yet mentioned here:
 Things that need thinking about [...] contribution of caravans 
 to boosted wonders (undiscounted, I assume)

___

Reply to this item at:

  http://gna.org/patch/?4722

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4470] Target-specific city production boost effect

2014-08-25 Thread Jacob Nevins
Update of patch #4470 (project freeciv):

  Status:None = Duplicate  
 Open/Closed:Open = Closed 

___

Follow-up Comment #4:

Patch #4722 is a more developed version of this idea, so closing this one in
favour of that one.

___

Reply to this item at:

  http://gna.org/patch/?4470

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4390] Map latitude requirement for effects

2014-08-25 Thread Jacob Nevins
Follow-up Comment #2, patch #4390 (project freeciv):

 This does mean that scenario authors can't specify how latitude 
 is to be evaluated for their scenarios. A fully general
 solution would be to allow latitude to be specified per-tile, 
 but that's probably not worth the hassle.
A simple solution would be to have a scenario property 'latitude', which
defaults to the sentinel value used by map generation without latitude, but
can be manually set to a single value by scenario authors (so a Scandinavian
scenario might be devoid of Solar Plants).

Might want some UI for latitude if ruleset effects depend on it, maybe in the
middle-click popup (plus perhaps a way to hide it for rulesets where it
doesn't matter, to avoid clutter).

(I'm ignoring the possibility of a longitude requirement. About the only use
for it I can think of would be a Ragged Astronauts
http://en.wikipedia.org/wiki/Land_and_Overland scenario.)

___

Reply to this item at:

  http://gna.org/patch/?4390

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5011] civ2civ3: default to team_pooled_research=FALSE

2014-08-25 Thread pepeto
Follow-up Comment #5, patch #5011 (project freeciv):

 So maybe this ticket's redundant?

I don't think so. But I am currently thinking that there is maybe a way to fix
random tech issues in S2_4 and S2_5.


___

Reply to this item at:

  http://gna.org/patch/?5011

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Client guidelines

2014-08-25 Thread Pepeto
You probably noticed that I didn't touch to the gui development for a
long time. Actually, I disagree with the current policy about gui. We
don't have the required manpower to keep compiling, up-to-date and fix
bugs on every gui.

I would be happy if we would limit the specific-gui code to very
low-level operations (such as handling key events, mouse events, and
drawing into an area). It would allow to focus on an unique client
(probably based on SDL or freeciv-web design) and concentrate more
energy on implementing new features, and fixing the huge number of known
bugs.

Pepeto



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22473] Technology step number for a goal not updated

2014-08-25 Thread pepeto
Update of bug #22473 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22473

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5094] Allow Veteran_Combat effect to depend on unit properties (not just unit type)

2014-08-25 Thread Jacob Nevins
URL:
  http://gna.org/patch/?5094

 Summary: Allow Veteran_Combat effect to depend on unit
properties (not just unit type)
 Project: Freeciv
Submitted by: jtn
Submitted on: Mon 25 Aug 2014 16:35:47 BST
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Currently, the EFT_VETERAN_COMBAT check in maybe_become_veteran_real() calls
get_unittype_bonus(), so can't depend on a particular unit's properties. Use
get_unit_bonus() instead.

This is necessary to allow the construction described in patch #3402.




___

Reply to this item at:

  http://gna.org/patch/?5094

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5044] research_player_iter cleanup

2014-08-25 Thread pepeto
Update of patch #5044 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5044

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22474] tech_researched script signal and team_pooled_research enabled

2014-08-25 Thread pepeto
Update of bug #22474 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22474

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4943] Single-veteran-level level name

2014-08-25 Thread Jacob Nevins
Follow-up Comment #3, patch #4943 (project freeciv):

I think this can be closed?

___

Reply to this item at:

  http://gna.org/patch/?4943

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5045] and-list strings and internationalization

2014-08-25 Thread pepeto
Update of patch #5045 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5045

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5015] Replace tech flag Population_Pollution_Inc with new effect Pollu_Pop_Pct_2

2014-08-25 Thread Jacob Nevins
Update of patch #5015 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn

___

Follow-up Comment #1:

Fix.

In civ2civ3, Industrialization is no longer a requirement for population-based
pollution (so contriving to forget that tech will no longer magically clean up
your buildings).

Other rulesets are unchanged. To retain old behaviour, add a new base effect:


[effect_pollu_pop_base]
type= Pollu_Pop_Pct_2
value   = -100


and for every tech that had the 'Population_Pollution_Inc' flag, add an effect
with value 25:


[effect_pollu_pop_automobile]
type= Pollu_Pop_Pct_2
value   = 25
reqs=
{ type, name, range
  Tech, Automobile, Player
}


(Also you probably want to add a helptext to these texts, since the
automatically generated one has gone away.)

(file #21835)
___

Additional Item Attachment:

File name: trunk-pollu_pop_pct_2.patchSize:40 KB


___

Reply to this item at:

  http://gna.org/patch/?5015

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5094] Allow Veteran_Combat effect to depend on unit properties (not just unit type)

2014-08-25 Thread Jacob Nevins
Update of patch #5094 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-unit-specific-veteran-combat.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/patch/?5094

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4902] Unit veteran level requirement type

2014-08-25 Thread Jacob Nevins
Update of patch #4902 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn
 Planned Release: = 2.6.0  

___

Follow-up Comment #2:

Patch adds MinVeteran requirement, taking a numeric veteran level.
I haven't pursued any of the other ideas in comment #0.

(The autogenerated help is a bit weak since it has to talk about numeric
veteran levels. I can't really see that it can talk about named ones given
their unit type dependence. It might be cosmetically nicer to talk in
ordinals, but that requires i18n infrastructure that we don't have.)

(file #21837)
___

Additional Item Attachment:

File name: trunk-req-minveteran.patch Size:8 KB


___

Reply to this item at:

  http://gna.org/patch/?4902

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3402] Effect to limit veteran level

2014-08-25 Thread Jacob Nevins
Update of patch #3402 (project freeciv):

  Status:None = Duplicate  
 Open/Closed:Open = Closed 

___

Follow-up Comment #2:

This can be implemented with patch #4902 + patch #5094, so closing.

___

Reply to this item at:

  http://gna.org/patch/?3402

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21386] fit_nationset_to_players(): 'least_misfits' may be used uninitialized in this function

2014-08-25 Thread Jacob Nevins
Update of bug #21386 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn
 Planned Release:2.5.0, 2.6.0 = 2.5.0-beta2, 2.6.0 

___

Follow-up Comment #7:

Untested patch for the specific issue of the title.
I don't have a compiler that complains about this, so I haven't confirmed that
it actually makes the warning go away; testing welcome.

(file #21838)
___

Additional Item Attachment:

File name: trunk-S2_5-warning-least_misfits.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?21386

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22498] Second Investigate City by spy gets stale info

2014-08-25 Thread pepeto
Update of bug #22498 (project freeciv):

  Status:None = Confirmed  

___

Follow-up Comment #1:

Reproduced. The problem is that the present and supported unit lists are
cleared only when receiving the first unit info. But in case there is no unit
info at all, the bug occurs.

___

Reply to this item at:

  http://gna.org/bugs/?22498

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22518] Crash loading game in FreeCiv 2.4.x after a few close/re-load cycles

2014-08-25 Thread Matthiasbasler
URL:
  http://gna.org/bugs/?22518

 Summary: Crash loading game in FreeCiv 2.4.x after a few
close/re-load cycles
 Project: Freeciv
Submitted by: matthiasbasler
Submitted on: Mo 25 Aug 2014 16:55:02 UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.3
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

This is  bug which I encountered in FreeCiv 2.4 beta and 2.4.3 alike und
Windows 7, 64 bit, German, in single-player mode (local server):
 
This bug is 100% reproducable:
1. Start or load and start a saved game.
2. Quit the game (but not the application)
3. Load and start a saved game
4. Quit the game (but not the application)
5. Load and start a saved game
6. Quit the game (but not the application)
7. Load and start a saved game (for the fourth time)
Freeciv will now crash. See attached screenshot.

(Not sure if this is a client or server issue. Therefore no category chosen.)



___

File Attachments:


---
Date: Mo 25 Aug 2014 16:55:02 UTC  Name: FreeCiv 2.4.4 load crash.PNG  Size:
362kB   By: matthiasbasler

http://gna.org/bugs/download.php?file_id=21841

___

Reply to this item at:

  http://gna.org/bugs/?22518

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22518] Crash loading game in FreeCiv 2.4.x after a few close/re-load cycles

2014-08-25 Thread pepeto
Update of bug #22518 (project freeciv):

Category:None = client-gtk-2.0 


___

Reply to this item at:

  http://gna.org/bugs/?22518

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22519] Save game function unable to cope with special characters (e.g. umlauts)

2014-08-25 Thread Matthiasbasler
URL:
  http://gna.org/bugs/?22519

 Summary: Save game function unable to cope with special
characters (e.g. umlauts)
 Project: Freeciv
Submitted by: matthiasbasler
Submitted on: Mo 25 Aug 2014 17:02:17 UTC
Category: client-gtk-2.0
Severity: 4 - Important
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.3
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

Whenever I try to save a game with special characters in them, such as Umlauts
(ä,ö,ü) or question mark, the game will quietly not be saved. Instead
Freeciv seems to continue normally, but at the end of the round (when
pressing  Done!) the game crashes. 
After a restart the saved game is not in the list for loading.

This is 100% reproducable for me.






___

Reply to this item at:

  http://gna.org/bugs/?22519

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5095] List selected modpack installer in configure end report

2014-08-25 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5095

 Summary: List selected modpack installer in configure end
report
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 25 Aug 2014 08:07:41 PM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0-beta2, 2.6.0

___

Details:





___

File Attachments:


---
Date: Mon 25 Aug 2014 08:07:41 PM EEST  Name: ConfigureReportMP.patch  Size:
2kB   By: cazfi

http://gna.org/patch/download.php?file_id=21842
---
Date: Mon 25 Aug 2014 08:07:41 PM EEST  Name: ConfigureReportMP-S2_5.patch 
Size: 2kB   By: cazfi

http://gna.org/patch/download.php?file_id=21843

___

Reply to this item at:

  http://gna.org/patch/?5095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14904] gtk-client city dlg production time updates to previous value

2014-08-25 Thread Matthiasbasler
Follow-up Comment #3, bug #14904 (project freeciv):

Just wanted to report this, but obviously this bug is already known:

In the city window, on the Production tab, if I change the order of two
different items selected for production, which results in a different item
being produced *right now*, the production progress bar doesn't update. It
still shows the progress for the previously ordered item. See screenshot.

Sometimes is phenomenon of the production progress bar not updating also
happens in other use cases, such as when clicking on Change production, but
this is not reproducable.

Win7 64 bit, on version 2.4.3 (already found in 2.4 beta)

___

Reply to this item at:

  http://gna.org/bugs/?14904

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5072] Cant_Fortify unit type flag

2014-08-25 Thread Marko Lindqvist
Update of patch #5072 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5072

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22509] Sdl-client hardcoded prevention of base building to city tile

2014-08-25 Thread Marko Lindqvist
Update of bug #22509 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22509

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5096] --enable-ruledit=experimental

2014-08-25 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5096

 Summary: --enable-ruledit=experimental
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 25 Aug 2014 09:03:59 PM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add special value experimental for configure option --enable-ruledit. While
freeciv-ruledit is experimental as a whole, this further disables features
that are experimental even in that context. The idea for this came when trying
to figure out what to do for freeciv-ruledit in respect to 2.6. I don't want
to keep general development on hold while trying to get some kind of stable
featureset for 2.6, and even remove some already existing stuff that won't
make it to 2.6.

Initially not having experimental mode on disables Add Tech and Remove
Tech buttons as those work only under special circumstances, and there's no
way for user to affect those circumstances.



___

File Attachments:


---
Date: Mon 25 Aug 2014 09:03:59 PM EEST  Name: RuleditExperimental.patch  Size:
2kB   By: cazfi

http://gna.org/patch/download.php?file_id=21844

___

Reply to this item at:

  http://gna.org/patch/?5096

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21543] scripts/potfiles not updated for new translation arrangements

2014-08-25 Thread Marko Lindqvist
Update of bug #21543 (project freeciv):

Category:None = general
  Status:   Need Info = Ready For Test 
 Planned Release: = 2.5.0, 2.6.0   

___

Follow-up Comment #3:

Updated potfiles to work with multiple domains setup. Fixed also some other
issues that prevented me from getting any sensible results from it (mainly
stemming from the fact that dot in ./ or ../ gets translated to any
character in regexp and not to literal dot)

(file #21845, file #21846)
___

Additional Item Attachment:

File name: PotfilesDomains.patch  Size:1 KB
File name: PotfilesDomains-S2_5.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?21543

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22519] Save game function unable to cope with special characters (e.g. umlauts)

2014-08-25 Thread pepeto
Follow-up Comment #1, bug #22519 (project freeciv):

 Whenever I try to save a game with special characters in them

How do you do that? Do you:
* save the game using the Game menu;
* set the save game name from the option window;
* type in the chat line /save;
* type in the chat line /set savename?


___

Reply to this item at:

  http://gna.org/bugs/?22519

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5097] Prevent the division by zero in research_total_bulbs_required()

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5097

 Summary: Prevent the division by zero in
research_total_bulbs_required()
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 25 août 2014 21:31:45 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

It might happen in unknown circumstances with tech_leakage enabled.




___

File Attachments:


---
Date: lun. 25 août 2014 21:31:45 CEST  Name:
tech_leakage_prevent_division_by_zero.patch  Size: 3 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21847

___

Reply to this item at:

  http://gna.org/patch/?5097

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22521] tech_upkeep is applied negatively

2014-08-25 Thread pepeto
URL:
  http://gna.org/bugs/?22521

 Summary: tech_upkeep is applied negatively
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 25 août 2014 21:35:10 CEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.6.0

___

Details:

Due a type in bug #22058. Fix attached.




___

File Attachments:


---
Date: lun. 25 août 2014 21:35:10 CEST  Name:
fix_tech_upkeep_application.patch  Size: 681 o   By: pepeto

http://gna.org/bugs/download.php?file_id=21848

___

Reply to this item at:

  http://gna.org/bugs/?22521

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5098] Fix technology cost with team_pooled_research is enabled

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5098

 Summary: Fix technology cost with team_pooled_research is
enabled
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 25 août 2014 21:39:15 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.4, 2.5.0

___

Details:

Backported patch for bug #22059.




___

File Attachments:


---
Date: lun. 25 août 2014 21:39:15 CEST  Name:
S2_5_base_total_bulbs_required.patch  Size: 6 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21849
---
Date: lun. 25 août 2014 21:39:15 CEST  Name:
S2_4_base_total_bulbs_required.patch  Size: 6 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21850

___

Reply to this item at:

  http://gna.org/patch/?5098

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5099] Make tech_upkeep a per-player property

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5099

 Summary: Make tech_upkeep a per-player property
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 25 août 2014 21:41:41 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.4, 2.5.0

___

Details:

Backported patch for bug #22058.




___

File Attachments:


---
Date: lun. 25 août 2014 21:41:41 CEST  Name: S2_5_player_tech_upkeep.patch 
Size: 13 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21851
---
Date: lun. 25 août 2014 21:41:41 CEST  Name:
S2_4_base_total_bulbs_required.patch  Size: 6 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21852

___

Reply to this item at:

  http://gna.org/patch/?5099

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5100] Send player tech_upkeep and real researching_cost to the client

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5100

 Summary: Send player tech_upkeep and real researching_cost to
the client
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 25 août 2014 21:44:17 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.4, 2.5.0

___

Details:

Mostly a backport of the patch I made for bug #22062.




___

File Attachments:


---
Date: lun. 25 août 2014 21:44:17 CEST  Name:
S2_5_network_capability_tech_cost.patch  Size: 11 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21853
---
Date: lun. 25 août 2014 21:44:17 CEST  Name: S2_4_player_tech_upkeep.patch 
Size: 12 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21854

___

Reply to this item at:

  http://gna.org/patch/?5100

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-08-25 Thread pepeto
Update of patch #4726 (project freeciv):

  Depends on: = patch #5097


___

Reply to this item at:

  http://gna.org/patch/?4726

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-08-25 Thread pepeto
Update of patch #4726 (project freeciv):

  Depends on: = patch #5099


___

Reply to this item at:

  http://gna.org/patch/?4726

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-08-25 Thread pepeto
Update of patch #4726 (project freeciv):

  Depends on: = patch #5098


___

Reply to this item at:

  http://gna.org/patch/?4726

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-08-25 Thread pepeto
Update of patch #4726 (project freeciv):

  Depends on: = patch #5100


___

Reply to this item at:

  http://gna.org/patch/?4726

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5101] Write freeciv-ruledit version information to ruleset

2014-08-25 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5101

 Summary: Write freeciv-ruledit version information to ruleset
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 26 Aug 2014 12:00:49 AM EEST
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: Tue 26 Aug 2014 12:00:49 AM EEST  Name:
0001-Write-freeciv-ruledit-version-information-to-ruleset.patch  Size: 5kB  
By: cazfi

http://gna.org/patch/download.php?file_id=21855

___

Reply to this item at:

  http://gna.org/patch/?5101

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5102] Infer if a unit type is an actor based on action enablers

2014-08-25 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5102

 Summary: Infer if a unit type is an actor based on action
enablers
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 25 Aug 2014 09:20:46 PM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Up until now a unit have been seen as a potential actor if it has the Diplomat
unit type flag. It is possible to have a unit with the Diplomat unit type that
can't perform any actions. In the future it should be possible to have actors
without the Diplomat unit type flag.

Stop relying on the Diplomat unit flag to determine if the unit type can
perform generalized actions. Check if at least one action controlled by
generalized (ruleset) action enablers is possible in stead.



___

File Attachments:


---
Date: Mon 25 Aug 2014 09:20:46 PM UTC  Name:
0001-Infer-if-a-unit-type-is-an-actor-from-the-action-ena.patch  Size: 3kB  
By: sveinung

http://gna.org/patch/download.php?file_id=21856

___

Reply to this item at:

  http://gna.org/patch/?5102

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4997] [Metaticket] Get rid of action_enabler_append_hard()

2014-08-25 Thread Sveinung Kvilhaugsvik
Update of patch #4997 (project freeciv):

  Depends on: = patch #5102

___

Follow-up Comment #3:

patch #5102 is a step towards removing the hard coding of the Diplomat unit
type flag requirement.

___

Reply to this item at:

  http://gna.org/patch/?4997

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5103] Refactor do_dipl_cost(), do_free_cost(), and do_conquer_cost()

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5103

 Summary: Refactor do_dipl_cost(), do_free_cost(), and
do_conquer_cost()
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:31:11 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: mar. 26 août 2014 00:31:11 CEST  Name: research_apply_penalty.patch 
Size: 6 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21857

___

Reply to this item at:

  http://gna.org/patch/?5103

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5104] do_tech_parasite_effect() cleanup

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5104

 Summary: do_tech_parasite_effect() cleanup
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:32:39 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

+ pick random technology.




___

File Attachments:


---
Date: mar. 26 août 2014 00:32:39 CEST  Name: do_tech_parasite_effect.patch 
Size: 6 ko   By: pepeto

http://gna.org/patch/download.php?file_id=21858

___

Reply to this item at:

  http://gna.org/patch/?5104

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5105] tech_researched() cleanup

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5105

 Summary: tech_researched() cleanup
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:33:27 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: mar. 26 août 2014 00:33:28 CEST  Name: tech_researched.patch  Size: 3
ko   By: pepeto

http://gna.org/patch/download.php?file_id=21859

___

Reply to this item at:

  http://gna.org/patch/?5105

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5106] choose_tech(), choose_tech_goal(), and choose_random_tech() cleanup

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5106

 Summary: choose_tech(), choose_tech_goal(), and
choose_random_tech() cleanup
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:34:54 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: mar. 26 août 2014 00:34:54 CEST  Name: choose_tech.patch  Size: 9 ko  
By: pepeto

http://gna.org/patch/download.php?file_id=21860

___

Reply to this item at:

  http://gna.org/patch/?5106

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5107] pick_random_tech() and pick_cheapest_tech() cleanup

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5107

 Summary: pick_random_tech() and pick_cheapest_tech() cleanup
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:35:46 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: mar. 26 août 2014 00:35:46 CEST  Name: pick_tech.patch  Size: 8 ko  
By: pepeto

http://gna.org/patch/download.php?file_id=21861

___

Reply to this item at:

  http://gna.org/patch/?5107

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5108] give_XXX_free_tech(), and give_XXX_initial_techs() cleanup

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5108

 Summary: give_XXX_free_tech(), and give_XXX_initial_techs()
cleanup
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:36:56 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: mar. 26 août 2014 00:36:56 CEST  Name: give_tech.patch  Size: 12 ko  
By: pepeto

http://gna.org/patch/download.php?file_id=21862

___

Reply to this item at:

  http://gna.org/patch/?5108

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5109] init_tech() cleanup

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5109

 Summary: init_tech() cleanup
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:37:34 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: mar. 26 août 2014 00:37:34 CEST  Name: init_tech.patch  Size: 7 ko  
By: pepeto

http://gna.org/patch/download.php?file_id=21863

___

Reply to this item at:

  http://gna.org/patch/?5109

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-08-25 Thread pepeto
Update of patch #4726 (project freeciv):

  Depends on: = patch #5103


___

Reply to this item at:

  http://gna.org/patch/?4726

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5110] update_bulbs() cleanup

2014-08-25 Thread pepeto
URL:
  http://gna.org/patch/?5110

 Summary: update_bulbs() cleanup
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:38:08 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: mar. 26 août 2014 00:38:08 CEST  Name: update_bulbs.patch  Size: 6 ko  
By: pepeto

http://gna.org/patch/download.php?file_id=21864

___

Reply to this item at:

  http://gna.org/patch/?5110

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-08-25 Thread pepeto
Update of patch #4726 (project freeciv):

  Depends on: = patch #5104


___

Reply to this item at:

  http://gna.org/patch/?4726

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-08-25 Thread pepeto
Update of patch #4726 (project freeciv):

  Depends on: = patch #5105


___

Reply to this item at:

  http://gna.org/patch/?4726

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-08-25 Thread pepeto
Update of patch #4726 (project freeciv):

  Depends on: = patch #5110


___

Reply to this item at:

  http://gna.org/patch/?4726

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22522] Global techs techlevel and disabled team_pooled_research

2014-08-25 Thread pepeto
URL:
  http://gna.org/bugs/?22522

 Summary: Global techs  techlevel and disabled
team_pooled_research
 Project: Freeciv
Submitted by: pepeto
Submitted on: mar. 26 août 2014 00:46:05 CEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Release: S2_4, S2_5, trunk
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.4, 2.5.0, 2.6.0

___

Details:

When team_pooled_research setting is disabled, only the first player of the
team will get the global techs and the free random technologies. This looks
like the rest of an old bug fix.

Fix attached for S2_4 and S2_5. trunk would be fixed by applying patch #5108.




___

File Attachments:


---
Date: mar. 26 août 2014 00:46:05 CEST  Name: S2_4_S2_5_techlevel.patch  Size:
2 ko   By: pepeto

http://gna.org/bugs/download.php?file_id=21865

___

Reply to this item at:

  http://gna.org/bugs/?22522

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev