[Freeciv-Dev] [patch #5103] Refactor do_dipl_cost(), do_free_cost(), and do_conquer_cost()
Follow-up Comment #1, patch #5103 (project freeciv): @@ -182,7 +155,7 @@ void do_tech_parasite_effect(struct player *pplayer) research_advance_name_translation(presearch, i), astr_str(effects)); -do_free_cost(pplayer, i); + do_free_cost(presearch, i, game.server.freecost); Still do_free_cost()? ___ Reply to this item at: http://gna.org/patch/?5103 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5103] Refactor do_dipl_cost(), do_free_cost(), and do_conquer_cost()
Follow-up Comment #2, patch #5103 (project freeciv): Well caught! Patch updated. (file #21866) ___ Additional Item Attachment: File name: research_apply_penalty2.patch Size:5 KB ___ Reply to this item at: http://gna.org/patch/?5103 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22439] ( 33, 26) 2 citizens not equal [size], repairing Sollentuna[1]
Follow-up Comment #1, bug #22439 (project freeciv): Specialists are not loaded correctly, because loading-specialist.size is set for compatibility before the ruleset is loaded (so always set to zero). ___ Reply to this item at: http://gna.org/bugs/?22439 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22523] Risk of use of uninitialized values when loading a savegame
URL: http://gna.org/bugs/?22523 Summary: Risk of use of uninitialized values when loading a savegame Project: Freeciv Submitted by: pepeto Submitted on: mar. 26 août 2014 11:43:15 CEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: pepeto Originator Email: Open/Closed: Open Release: S2_4, S2_5, trunk Discussion Lock: Any Operating System: Any Planned Release: 2.4.4, 2.5.0-beta2, 2.6.0 ___ Details: At many locations, the code ignores secfile_lookup_XXX() returned values, and then assumes that something has been read. Attached patch correct these parts and add warn_unused_result attribute for all secfile_lookup_XXX() functions. ___ File Attachments: --- Date: mar. 26 août 2014 11:43:15 CEST Name: trunk_secfile_lookup_warn_unused_result.patch Size: 27 ko By: pepeto http://gna.org/bugs/download.php?file_id=21870 --- Date: mar. 26 août 2014 11:43:15 CEST Name: S2_5_secfile_lookup_warn_unused_result.patch Size: 18 ko By: pepeto http://gna.org/bugs/download.php?file_id=21871 --- Date: mar. 26 août 2014 11:43:15 CEST Name: S2_4_secfile_lookup_warn_unused_result.patch Size: 15 ko By: pepeto http://gna.org/bugs/download.php?file_id=21872 ___ Reply to this item at: http://gna.org/bugs/?22523 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22513] Change to Forest [pollution]
Update of bug #22513 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Release: = S2_4, S2_5, trunk Operating System:None = Any Planned Release: = 2.4.4, 2.5.0, 2.6.0 ___ Follow-up Comment #1: It affects gtk2, gtk3, qt and win32 clients. Is it even correct always (the extra could disappear in transformation and I don't think the code considers that) It does. But I don't think it is really expected here. Patch attached to remove [Pollution] and/or [Fallout] strings from menus. (file #21873, file #21874, file #21875) ___ Additional Item Attachment: File name: trunk_tile_get_info_text.patch Size:6 KB File name: S2_5_tile_get_info_text.patch Size:6 KB File name: S2_4_tile_get_info_text.patch Size:6 KB ___ Reply to this item at: http://gna.org/bugs/?22513 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22499] Strange spaceship updates
Update of bug #22499 (project freeciv): Category: client = general Status:None = Need Info ___ Follow-up Comment #1: Just right after connecting to server, client is forced to update spaceship report many times (in early game its 5 times, later it could be 12). Actually, the server sends the spaceship info for every players to the connecting user. I presume in the first case, you were playing with aifill 5, and the second time with aifill 12 (maybe with civ2civ3 ruleset). So I think this is correct. (Note it is not an unique spaceship report but the spaceship reports of different players.) However, I attach a patch applicable to trunk only to give the is-game-info flag to the SPACESHIP_INFO packet. Need network capability update. (file #21876) ___ Additional Item Attachment: File name: packet_spaceship_info.patchSize:0 KB ___ Reply to this item at: http://gna.org/bugs/?22499 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5111] Remove line duplicate in handle_spaceship_info()
URL: http://gna.org/patch/?5111 Summary: Remove line duplicate in handle_spaceship_info() Project: Freeciv Submitted by: pepeto Submitted on: mar. 26 août 2014 13:09:57 CEST Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.4, 2.5.0, 2.6.0 ___ Details: ___ File Attachments: --- Date: mar. 26 août 2014 13:09:57 CEST Name: handle_spaceship_info_duplicate.patch Size: 477 o By: pepeto http://gna.org/patch/download.php?file_id=21877 ___ Reply to this item at: http://gna.org/patch/?5111 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22051] Missing route for a city on river
Update of bug #22051 (project freeciv): Category:None = rulesets Status:None = Invalid Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22051 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20543] lua error: Execution time limit exceeded in script
Update of bug #20543 (project freeciv): Status:None = Fixed Assigned to:None = cazfi Operating System:None = Any ___ Follow-up Comment #8: I am not able to reproduce anymore. I think I got this error running very deep valgrind introspection. I doubt something more could be done. ___ Reply to this item at: http://gna.org/bugs/?20543 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20543] lua error: Execution time limit exceeded in script
Update of bug #20543 (project freeciv): Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20543 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22499] Strange spaceship updates
Follow-up Comment #2, bug #22499 (project freeciv): Right. So it means client might show spaceships of other players. ___ Reply to this item at: http://gna.org/bugs/?22499 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22524] Spelling mistake in comment in diplrel_by_rule_name()
URL: http://gna.org/bugs/?22524 Summary: Spelling mistake in comment in diplrel_by_rule_name() Project: Freeciv Submitted by: sveinung Submitted on: Tue 26 Aug 2014 12:11:19 PM UTC Category: None Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: sveinung Originator Email: Open/Closed: Open Release: TRUNK Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: happend should be happen ___ File Attachments: --- Date: Tue 26 Aug 2014 12:11:19 PM UTC Name: Fix-spelling-mistake-in-comment-in-diplrel_by_rule_n.patch Size: 874B By: sveinung http://gna.org/bugs/download.php?file_id=21878 ___ Reply to this item at: http://gna.org/bugs/?22524 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21552] game.plr_bg_color not freed properly
Update of bug #21552 (project freeciv): Category:None = general Status:None = Ready For Test Assigned to:None = pepeto Operating System:None = Any Planned Release: = 2.4.4, 2.5.0, 2.6.0 ___ Follow-up Comment #1: Fix attached. (file #21879, file #21880) ___ Additional Item Attachment: File name: trunk_S2_5_plr_bg_color.patch Size:1 KB File name: S2_4_plr_bg_color.patchSize:1 KB ___ Reply to this item at: http://gna.org/bugs/?21552 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22514] Some enums used in universal aren't marked as a part of the network protocol
Update of bug #22514 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22514 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5112] Remove player color hack in Qt client
URL: http://gna.org/patch/?5112 Summary: Remove player color hack in Qt client Project: Freeciv Submitted by: pepeto Submitted on: mar. 26 août 2014 14:15:36 CEST Category: client-qt Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: Mir3x, feel free to take item if you want. ___ File Attachments: --- Date: mar. 26 août 2014 14:15:37 CEST Name: S2_5_qt_reread_tilespec.patch Size: 1 ko By: pepeto http://gna.org/patch/download.php?file_id=21882 --- Date: mar. 26 août 2014 14:15:36 CEST Name: trunk_qt_reread_tilespec.patch Size: 1 ko By: pepeto http://gna.org/patch/download.php?file_id=21881 ___ Reply to this item at: http://gna.org/patch/?5112 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22499] Add is-game-info to the SPACESHIP_INFO packet
Update of bug #22499 (project freeciv): Status: Need Info = Ready For Test Assigned to:None = pepeto Planned Release: = 2.6.0 Summary: Strange spaceship updates = Add is-game-info to the SPACESHIP_INFO packet ___ Reply to this item at: http://gna.org/bugs/?22499 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5113] Define bv_terrain_flags in terrain_flag_id using SPECENUM_BITVECTOR
URL: http://gna.org/patch/?5113 Summary: Define bv_terrain_flags in terrain_flag_id using SPECENUM_BITVECTOR Project: Freeciv Submitted by: sveinung Submitted on: Tue 26 Aug 2014 12:52:39 PM UTC Category: None Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Makes its size expand as the enum expands. Makes the association between the bitvector and the enum machine readable. ___ File Attachments: --- Date: Tue 26 Aug 2014 12:52:39 PM UTC Name: Define-bv_terrain_flags-in-terrain_flag_id-using-SPE.patch Size: 1kB By: sveinung http://gna.org/patch/download.php?file_id=21883 ___ Reply to this item at: http://gna.org/patch/?5113 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5114] Define bv_unit_type_flags in unit_type_flag_id using SPECENUM_BITVECTOR
URL: http://gna.org/patch/?5114 Summary: Define bv_unit_type_flags in unit_type_flag_id using SPECENUM_BITVECTOR Project: Freeciv Submitted by: sveinung Submitted on: Tue 26 Aug 2014 02:01:42 PM UTC Category: None Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: ___ File Attachments: --- Date: Tue 26 Aug 2014 02:01:42 PM UTC Name: Define-bv_unit_type_flags-in-unit_type_flag_id-using.patch Size: 1kB By: sveinung http://gna.org/patch/download.php?file_id=21884 ___ Reply to this item at: http://gna.org/patch/?5114 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5100] Send player tech_upkeep and real researching_cost to the client
Follow-up Comment #1, patch #5100 (project freeciv): Fixed A_UNSET research cost. (file #21885, file #21886) ___ Additional Item Attachment: File name: S2_5_network_capability_tech_cost2.patch Size:11 KB File name: S2_4_base_total_bulbs_required.patch Size:5 KB ___ Reply to this item at: http://gna.org/patch/?5100 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5100] Send player tech_upkeep and real researching_cost to the client
Additional Item Attachment, patch #5100 (project freeciv): File name: S2_4_network_capability_tech_cost2.patch Size:10 KB ___ Reply to this item at: http://gna.org/patch/?5100 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5115] Remove unnecessary TECH_GAIN packet
URL: http://gna.org/patch/?5115 Summary: Remove unnecessary TECH_GAIN packet Project: Freeciv Submitted by: pepeto Submitted on: mar. 26 août 2014 17:02:25 CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: ___ File Attachments: --- Date: mar. 26 août 2014 17:02:25 CEST Name: remove_tech_gained_packet.patch Size: 4 ko By: pepeto http://gna.org/patch/download.php?file_id=21888 ___ Reply to this item at: http://gna.org/patch/?5115 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5116] Improve technology events
URL: http://gna.org/patch/?5116 Summary: Improve technology events Project: Freeciv Submitted by: pepeto Submitted on: mar. 26 août 2014 17:03:52 CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Notably add E_TECH_LOST and E_TECH_EMBASSY. ___ File Attachments: --- Date: mar. 26 août 2014 17:03:52 CEST Name: improve_tech_events.patch Size: 8 ko By: pepeto http://gna.org/patch/download.php?file_id=21889 ___ Reply to this item at: http://gna.org/patch/?5116 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5117] Update event addition documentation
URL: http://gna.org/patch/?5117 Summary: Update event addition documentation Project: Freeciv Submitted by: pepeto Submitted on: mar. 26 août 2014 17:05:37 CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Noticed in patch #5116 that I needed to modify data/misc/small.spec, which is undocumented in common/events.h. ___ File Attachments: --- Date: mar. 26 août 2014 17:05:37 CEST Name: update_event_documentation.patch Size: 803 o By: pepeto http://gna.org/patch/download.php?file_id=21890 ___ Reply to this item at: http://gna.org/patch/?5117 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5118] send_research_info() calls cleanup
URL: http://gna.org/patch/?5118 Summary: send_research_info() calls cleanup Project: Freeciv Submitted by: pepeto Submitted on: mar. 26 août 2014 17:07:31 CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: pepeto Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add some calls, remove some others, and remove send_research_info_to_owners() function... ___ File Attachments: --- Date: mar. 26 août 2014 17:07:31 CEST Name: review_send_research_info.patch Size: 6 ko By: pepeto http://gna.org/patch/download.php?file_id=21891 ___ Reply to this item at: http://gna.org/patch/?5118 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22525] Failed assertions when loading a savegame
URL: http://gna.org/bugs/?22525 Summary: Failed assertions when loading a savegame Project: Freeciv Submitted by: pepeto Submitted on: mar. 26 août 2014 17:10:05 CEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: pepeto Originator Email: Open/Closed: Open Release: trunk Discussion Lock: Any Operating System: Any Planned Release: 2.6.0 ___ Details: Due to an handling error for bug #22455. The A_UNSET variant is not handled. Fix attached. ___ File Attachments: --- Date: mar. 26 août 2014 17:10:05 CEST Name: load_savegame_A_UNSET.patch Size: 2 ko By: pepeto http://gna.org/bugs/download.php?file_id=21892 ___ Reply to this item at: http://gna.org/bugs/?22525 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up
Update of patch #4726 (project freeciv): Depends on: = patch #5115 ___ Reply to this item at: http://gna.org/patch/?4726 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5025] Extra/Terrain pillage_time
Follow-up Comment #3, patch #5025 (project freeciv): Committed at r25989 http://svn.gna.org/viewcvs/freeciv?view=revisionrevision=25989. Since, I get lot of LOG_NORMAL message which looks test ones (common/terrain.c, line 832). ___ Reply to this item at: http://gna.org/patch/?5025 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5117] Update event addition documentation
Follow-up Comment #1, patch #5117 (project freeciv): data/misc/small.spec Better to make it events.spec. Icons from small.png are now (temporarily) used only because we don't have real gfx yet. ___ Reply to this item at: http://gna.org/patch/?5117 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22519] Save game function unable to cope with special characters (e.g. umlauts)
Follow-up Comment #2, bug #22519 (project freeciv): I save the game using the Game menu. (I wasn't even aware of the the other options.) ___ Reply to this item at: http://gna.org/bugs/?22519 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5119] Make SDL2-mixer the default
URL: http://gna.org/patch/?5119 Summary: Make SDL2-mixer the default Project: Freeciv Submitted by: cazfi Submitted on: Tue 26 Aug 2014 07:57:33 PM EEST Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: This means that to build sdl-client one have to explicitly request SDL1.2-mixer (--enable-sdlmixer=sdl1.2) but at the same time need to specify SDL2-mixer for sdl2-client is removed. ___ File Attachments: --- Date: Tue 26 Aug 2014 07:57:33 PM EEST Name: Mixer2Default.patch Size: 7kB By: cazfi http://gna.org/patch/download.php?file_id=21893 ___ Reply to this item at: http://gna.org/patch/?5119 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5120] Write freeciv-manual version to comment in generated files
URL: http://gna.org/patch/?5120 Summary: Write freeciv-manual version to comment in generated files Project: Freeciv Submitted by: cazfi Submitted on: Tue 26 Aug 2014 08:25:29 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: ___ File Attachments: --- Date: Tue 26 Aug 2014 08:25:29 PM EEST Name: 0002-Write-comment-containing-freeciv-manual-version-to-g.patch Size: 707B By: cazfi http://gna.org/patch/download.php?file_id=21895 ___ Reply to this item at: http://gna.org/patch/?5120 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5121] Replace PACKET_UNIT_DIPLOMAT_QUERY with PACKET_UNIT_ACTION_QUERY
URL: http://gna.org/patch/?5121 Summary: Replace PACKET_UNIT_DIPLOMAT_QUERY with PACKET_UNIT_ACTION_QUERY Project: Freeciv Submitted by: sveinung Submitted on: Tue 26 Aug 2014 05:55:25 PM UTC Category: None Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: There is no need for a value field here. Remove it. Use gen_action in stead of diplomat_actions to name the action. ___ File Attachments: --- Date: Tue 26 Aug 2014 05:55:25 PM UTC Name: 0001-Unit-Action-Query.patch Size: 19kB By: sveinung http://gna.org/patch/download.php?file_id=21896 ___ Reply to this item at: http://gna.org/patch/?5121 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5113] Define bv_terrain_flags in terrain_flag_id using SPECENUM_BITVECTOR
Follow-up Comment #1, patch #5113 (project freeciv): Remember: update network protocol string. ___ Reply to this item at: http://gna.org/patch/?5113 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5114] Define bv_unit_type_flags in unit_type_flag_id using SPECENUM_BITVECTOR
Follow-up Comment #1, patch #5114 (project freeciv): Remember: update network protocol string. ___ Reply to this item at: http://gna.org/patch/?5114 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5073] Cant_Fortify for settlers
Follow-up Comment #1, patch #5073 (project freeciv): - Also multiplayer ruleset (file #21903) ___ Additional Item Attachment: File name: SettlersCantFortify-2.patchSize:7 KB ___ Reply to this item at: http://gna.org/patch/?5073 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5075] NoFortify terrain flag
Update of patch #5075 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5075 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22519] Save game function unable to cope with special characters (e.g. umlauts)
Follow-up Comment #4, bug #22519 (project freeciv): First let me apologize. I did the bug report out of my mind after having the problem specifically with question mark again. I did several tests now and have to correct me as follows: - The game does not crash, it just quits the current game and returns to the start window (with Start new game, load game etc.) - A ? or / in a savegame name causes the game to quit, and this does not necessarily happen only after pressing Done!. It just happened to me when moving a worker around after saving. - Umlauts like äöüÄÖÜ do NOT cause a crash or quit but rather cause a box like [X] in the savegame name, so this is a lower severity. Maybe the font used there cannot show these characters? Probably should be a separate issue. - Special characters !, # and work just fine. I didn't test any further special characters yet. To your question. The chat console shows: Matthias: 'save testä' resp. Matthias: 'save test?' That's all. No failure notice in the latter case. P.S. Can someone please update the issue title to reflect these test results? ___ Reply to this item at: http://gna.org/bugs/?22519 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22511] Sdl-clients use color that's no longer in scope
Update of bug #22511 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22511 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22499] Add is-game-info to the SPACESHIP_INFO packet
Follow-up Comment #3, bug #22499 (project freeciv): So it means client might show spaceships of other players. I think that's normal -- spaceship progress is public information, isn't it? ___ Reply to this item at: http://gna.org/bugs/?22499 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5122] Cleanup ai.h includes
URL: http://gna.org/patch/?5122 Summary: Cleanup ai.h includes Project: Freeciv Submitted by: cazfi Submitted on: Tue 26 Aug 2014 10:38:43 PM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: FC_AI_LAST is not defined in fc_types.h so there's no need for common/*.h to include ai.h. Drop those includes and include ai.h just to those .c files that need it. ___ File Attachments: --- Date: Tue 26 Aug 2014 10:38:43 PM EEST Name: 0001-Cleanup-ai.h-includes.patch Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=21904 ___ Reply to this item at: http://gna.org/patch/?5122 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22519] Save game command crashes with invalid filenames
Update of bug #22519 (project freeciv): Summary: Save game function unable to cope with special characters (e.g. umlauts) = Save game command crashes with invalid filenames ___ Follow-up Comment #5: The game does not crash, it just quits the current game and returns to the start window (with Start new game, load game etc.) This looks like a server crash. A ? or / in a savegame name causes the game to quit After fast checking, when issuing the /save command, no check is done on the filename. It seems that the characters :/\|?* are reserved on windows, this may explain why the server crashes. See http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx#naming_conventions Umlauts like äöüÄÖÜ do NOT cause a crash or quit but rather cause a box like [X] in the savegame name That's sound another kind of missed charset conversion. Special characters !, # and work just fine. These character are not listed above. ___ Reply to this item at: http://gna.org/bugs/?22519 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5123] Determine max number of ai types configure time
URL: http://gna.org/patch/?5123 Summary: Determine max number of ai types configure time Project: Freeciv Submitted by: cazfi Submitted on: Tue 26 Aug 2014 11:00:17 PM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.4, 2.5.0-beta2, 2.6.0 ___ Details: Replace hardcoded max ai types count with configure time checking. If dynamic modules are not enabled, make the count exactly the number of static modules being built in. If dynamic modules are enabled, add 3 slots for them. This saves some memory in typical case of one or two static modules as no never-used pointers to ai type specific data gets added to all units and cities. This leaves space for future improvements on dynamic modules case. As AI modules are loaded in the beginning of the game, we do know their number by the time units and cities are being created and could adjust to that runtime (not easily doable in C99, but we could conditionally make it better when newer compiler is being used) ___ File Attachments: --- Date: Tue 26 Aug 2014 11:00:17 PM EEST Name: 0002-Determine-max-number-of-ai-types-configure-time.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=21905 --- Date: Tue 26 Aug 2014 11:00:17 PM EEST Name: AiTypeCountConfigureTime-S2_4.patch Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=21906 ___ Reply to this item at: http://gna.org/patch/?5123 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22529] Static threaded ai cannot be built without classic ai
URL: http://gna.org/bugs/?22529 Summary: Static threaded ai cannot be built without classic ai Project: Freeciv Submitted by: cazfi Submitted on: Tue 26 Aug 2014 11:28:52 PM EEST Category: bootstrap Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0, 2.6.0 ___ Details: It should be possible nowadays, but obsolete configure check prevents it. Fix attached. ___ File Attachments: --- Date: Tue 26 Aug 2014 11:28:52 PM EEST Name: 0003-Allow-threaded-ai-module-without-classic-module.patch Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=21907 ___ Reply to this item at: http://gna.org/bugs/?22529 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5080] Helptext as extra property
Update of patch #5080 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5080 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22519] Save game command crashes with invalid filenames
Follow-up Comment #6, bug #22519 (project freeciv): It seems that the characters :/|?* are reserved on windows, this may explain why the server crashes. Indeed they are. It didn't occur to me that what I write as savegame titles results 1:1 as filenames. Since obviously this is the case then using the above characters is a no-go under windows and should ideally be rejected by FreeCiv under windows. (Not sure if other OS's dislike such characters as well...) Alternative idea is to escape such characters and have a transparent encoding/decoding the way modern browsers handle it for URLs in the address bar. Thanks for the hint, pepeto! ___ Reply to this item at: http://gna.org/bugs/?22519 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5124] Culture to city dialog
URL: http://gna.org/patch/?5124 Summary: Culture to city dialog Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 12:27:41 AM EEST Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add culture display to city dialog of gtk2, gtk3, and Qt clients. ___ File Attachments: --- Date: Wed 27 Aug 2014 12:27:41 AM EEST Name: ClientCityCulture.patch Size: 12kB By: cazfi http://gna.org/patch/download.php?file_id=21908 ___ Reply to this item at: http://gna.org/patch/?5124 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22530] Editing the city forgets the history value
URL: http://gna.org/bugs/?22530 Summary: Editing the city forgets the history value Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 12:36:23 AM EEST Category: client-gtk-3.0 Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Fix attached ___ File Attachments: --- Date: Wed 27 Aug 2014 12:36:23 AM EEST Name: RememberHistory.patch Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=21909 ___ Reply to this item at: http://gna.org/bugs/?22530 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5086] Culture effect on migration score
Update of patch #5086 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5086 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22531] goto for sea units
URL: http://gna.org/bugs/?22531 Summary: goto for sea units Project: Freeciv Submitted by: mir3x Submitted on: Tue 26 Aug 2014 11:52:33 PM CEST Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.5.0, 2.6.0 Discussion Lock: Any Operating System: None Planned Release: ___ Details: Goto order doesnt allow to attack land units (icon is changing to red, dissallowing action, but num keypad works) ___ Reply to this item at: http://gna.org/bugs/?22531 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5095] List selected modpack installer in configure end report
Follow-up Comment #1, patch #5095 (project freeciv): - Fixed configure syntax error (file #21910, file #21911) ___ Additional Item Attachment: File name: ConfigureReportMP-2.patch Size:1 KB File name: ConfigureReportMP-S2_5-2.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?5095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5125] Show whether freeciv-ruledit will be built in configure end report
URL: http://gna.org/patch/?5125 Summary: Show whether freeciv-ruledit will be built in configure end report Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 01:01:46 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: ___ File Attachments: --- Date: Wed 27 Aug 2014 01:01:46 AM EEST Name: ConfigureReportRE.patch Size: 327B By: cazfi http://gna.org/patch/download.php?file_id=21912 ___ Reply to this item at: http://gna.org/patch/?5125 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22532] Ruledit compilation failure due to extras helptexts
URL: http://gna.org/bugs/?22532 Summary: Ruledit compilation failure due to extras helptexts Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 01:11:58 AM EEST Category: freeciv-ruledit Severity: 3 - Normal Priority: 9 - Immediate Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: patch #5080 didn't do necessary changes to rulesave.c, breaking compilation. Fix attached, to be committed immediately (though ruledit is only experimental feature which build is disabled by default, neither does the fix touch anything outside it) ___ File Attachments: --- Date: Wed 27 Aug 2014 01:11:58 AM EEST Name: RuleditExtraHelptext.patch Size: 960B By: cazfi http://gna.org/bugs/download.php?file_id=21913 ___ Reply to this item at: http://gna.org/bugs/?22532 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22532] Ruledit compilation failure due to extras helptexts
Update of bug #22532 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22532 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5126] Check freeciv-ruledit for missinglist
URL: http://gna.org/patch/?5126 Summary: Check freeciv-ruledit for missinglist Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 01:20:07 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: If configured with --enable-ruledit=test --with-missinglist, and ruledit cannot be built, list that fact in the produced missinglist. This is not important at the moment as user has to knowingly set --enable-ruledit=test, but presumably that becomes the default in some point in the future. ___ File Attachments: --- Date: Wed 27 Aug 2014 01:20:07 AM EEST Name: MissinglistRuledit.patch Size: 977B By: cazfi http://gna.org/patch/download.php?file_id=21914 ___ Reply to this item at: http://gna.org/patch/?5126 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20556] No way to disable hack access of new clients of local server with same user
Update of bug #20556 (project freeciv): Category: general = client Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20556 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5127] Add check for C++11 nullptr and provide fallback if it's missing
URL: http://gna.org/patch/?5127 Summary: Add check for C++11 nullptr and provide fallback if it's missing Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 01:55:04 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: After this it should be safe to use 'nullptr' in our C++ code. ___ File Attachments: --- Date: Wed 27 Aug 2014 01:55:04 AM EEST Name: 0001-Add-check-for-C-11-nullptr-and-provide-fallback-if-i.patch Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=21917 ___ Reply to this item at: http://gna.org/patch/?5127 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5128] CodingStyle to require use of nullptr in C++ code
URL: http://gna.org/patch/?5128 Summary: CodingStyle to require use of nullptr in C++ code Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 02:08:03 AM EEST Category: docs Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: This is separate patch from patch #5127 as we may decide to postpone this one a bit. This makes it a CodingStyle policy that C++ code should use 'nullptr'. The problem with this is that patch #5127 is not in S2_5 and I don't think it will be ported there. As Qt-client is currently in active development for both TRUNK and S2_5, requiring use of nullptr in TRUNK but prohibiting it in S2_5 would hinder patch porting between branches too much. I think the effective policy should be something like require 'nullptr' in new freeciv-ruledit code, allow '0' in new Qt-client code for now. ___ File Attachments: --- Date: Wed 27 Aug 2014 02:08:03 AM EEST Name: 0002-Instruct-use-of-nullptr-in-CodingStyle.patch Size: 825B By: cazfi http://gna.org/patch/download.php?file_id=21918 ___ Reply to this item at: http://gna.org/patch/?5128 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5127] Add check for C++11 nullptr and provide fallback if it's missing
Follow-up Comment #1, patch #5127 (project freeciv): - Add call to the new macro (file #21919) ___ Additional Item Attachment: File name: 0001-Add-check-for-C-11-nullptr-and-provide-fallback-if-i.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?5127 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4485] Server type to metaserver
Update of patch #4485 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4485 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5129] Reserve packet number range 256:511 for freeciv-web
URL: http://gna.org/patch/?5129 Summary: Reserve packet number range 256:511 for freeciv-web Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 05:31:10 AM EEST Category: freeciv-web Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Numbers of packets added for freeciv-web regularly clash with main freeciv development. Lets ease that situation in the future by reserving 0x100-0x1ff range for freeciv-web specific packets. Attached patch documents that in packets.def ___ File Attachments: --- Date: Wed 27 Aug 2014 05:31:10 AM EEST Name: WebRange.patch Size: 394B By: cazfi http://gna.org/patch/download.php?file_id=21920 ___ Reply to this item at: http://gna.org/patch/?5129 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5130] DIO_PUT() and DIO_GET() macros
URL: http://gna.org/patch/?5130 Summary: DIO_PUT() and DIO_GET() macros Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Aug 2014 06:40:08 AM EEST Category: freeciv-web Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Reduce diff (and complicated part in that) between freeciv and freeciv-web. freeciv-web requires additional key parameter for dio_put_xxx() and dio_get_xxx() functions. We don't want the overhead of passing such an parameter to regular freeciv functions, but keep the function signatures intact. Instead this patch introduces set of macros that take the additional parameter, but does nothing with it in case of non-freeciv-web build, macro translates to exaclty same function call as we had before. freeciv-web implementation will take advantage of the new parameter. All this allows us to unify the caller side to use the macro. ___ File Attachments: --- Date: Wed 27 Aug 2014 06:40:08 AM EEST Name: DioKeys.patch Size: 9kB By: cazfi http://gna.org/patch/download.php?file_id=21921 ___ Reply to this item at: http://gna.org/patch/?5130 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
