[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #15, bug #18087 (project freeciv): Attached my version of file #12960, split into three separate patches and tweaked a little. The three patches: * *trunk-S2_3-hugemap-stack-overflow.diff*: The stack overflow fixes. This is what I propose we apply to S2_3 pre RC1, to deal with

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #14, bug #18087 (project freeciv): >> Oh there is so much stack abuse in freeciv. > ...question: is allocating huge arrays on the stack instead of > allocating the same arrays on the heap (in the absence of > recursion etc) really an abuse? Having read around a bit more, I'm n

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Update of bug #18087 (project freeciv): Assigned to: syntron => jtn Planned Release: 2.4.0 => 2.3.0,2.4.0 ___ Follow-up Comment #13: Stealing ticket,

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #12, bug #18087 (project freeciv): So we probably want to steal at least some of this patch for 2.3.0 to deal with bug #17962. We'll want at least the recursion fix for assign_continent_flood(). Question is, do we want to be selective about the rest? As far as I can tell on a q

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #11, bug #18087 (project freeciv): > the recursive loop in assign_continent_flood() is a problem See also bug #17962 for a case where it causes a problem in unmodified Freeciv. ___ Reply to this item at:

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #10, bug #18087 (project freeciv): updated patch which keeps savegame compatibility (file #12960) ___ Additional Item Attachment: File name: 0005-allow-map-sizes-up-to-2000x1000.patch Size:20 KB ___

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #9, bug #18087 (project freeciv): Please discard the format changes to savegame.c (%04d => %05d). It is only a cosmetic change but also creates an incompatible savegame format. I will post an updated patch without it as soon as possible.

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #8, bug #18087 (project freeciv): The attached patch should work. Could you please test it and post your results? Bellow the patch describtion is listed: allow map sizes up to 2000x1000 see gna bug #18087 patch by akfaew and myself * remove old comments * redo assign_counti

Re: [Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Quoting Goswin von Brederlow : Matthias Pfafferodt writes: Follow-up Comment #7, bug #18087 (project freeciv): +#define MAP_MAX_SIZE 4048 Why such a strange number? Shouldn't this be 4096? You are right; it was 2048 in an earlier test +#define MAX_DBV_LENGTH (4 * 1024 * 1024) Perhaps 40

Re: [Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Matthias Pfafferodt writes: > Follow-up Comment #7, bug #18087 (project freeciv): > >>+#define MAP_MAX_SIZE 4048 >>Why such a strange number? Shouldn't this be 4096? > > You are right; it was 2048 in an earlier test > >>+#define MAX_DBV_LENGTH (4 * 1024 * 1024) >>Perhaps 4096 * 1000? > > Also OK;

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #7, bug #18087 (project freeciv): >+#define MAP_MAX_SIZE 4048 >Why such a strange number? Shouldn't this be 4096? You are right; it was 2048 in an earlier test >+#define MAX_DBV_LENGTH (4 * 1024 * 1024) >Perhaps 4096 * 1000? Also OK; at the moment the temperature map is quit

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #6, bug #18087 (project freeciv): +#define MAP_MAX_SIZE 4048 Why such a strange number? Shouldn't this be 4096? +#define MAX_DBV_LENGTH (4 * 1024 * 1024) Perhaps 4096 * 1000? ___ Reply to this item at:

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #5, bug #18087 (project freeciv): and the next try ... could you test it with the scenario? A 32000x16 map can be created but for larger y sizes as well as for maps >> 400.000 the map generator seems to have problems. (file #12947) __

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Update of bug #18087 (project freeciv): Category:None => general Assigned to:None => syntron Planned Release: => 2.4.0 _

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #3, bug #18087 (project freeciv): The attached patch manages to get me thru the segfaults. (It's a cat of small diffs, gna only allows max 4 uploads) Now there are problems with assertions: 1: in dbv_init() [bitvector.c::57]: assertion 'bits > 0 && bits < 512 * 1024' failed. 1:

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #2, bug #18087 (project freeciv): The problem with my previous patch is that it will take up that space forever, which is also wrong. I think this needs to be done with malloc and free. I won't continue with this today and will wait for some feedback. Disregard startpos.c.diff p

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

Follow-up Comment #1, bug #18087 (project freeciv): Oh there is so much stack abuse in freeciv. Is it OK if I post patch to each file as a separate diff and message? (file #12933) ___ Additional Item Attachment: File name: startpos.c.diff

[Freeciv-Dev] [bug #18087] server segfault on a map with 1.3M tiles

URL: Summary: server segfault on a map with 1.3M tiles Project: Freeciv Submitted by: akfaew Submitted on: Sat 30 Apr 2011 01:29:31 PM GMT Category: None Severity: 3 - Normal