[Freeciv-Dev] [bug #15305] memory leak in map_allocate

Follow-up Comment #1, bug #15305 (project freeciv): good catch! It's best to free allocated memory within the code. As I'm not so familiar with pointers and allocation of memory a question to the functions used: For both pointers (city_map_index and map.iterate_outwards_indices) fc_realloc (fre

Re: [Freeciv-Dev] [Freeciv-i18n] Making default ruler names translateable?

It's really noticeable in Arabic and Hebrew, where writing order it right to left. Having a left to right name in a middle of a right-to-left sentence makes things a bit difficult to read, so it seems like a good idea to me. On Mon, Feb 8, 2010 at 11:31 AM, Sini Ruohomaa wrote: > Hi, > > It appea

[Freeciv-Dev] Making default ruler names translateable?

Hi, It appears that there might be a point in making default ruler names translateable, since their spelling actually differs from one language to the other. I haven't glimpsed at an up-to-date po file in quite a few months so I assume they haven't become translateable just now. O:) For example:

[Freeciv-Dev] [bug #15104] S2_2: gui-xaw never shows connection dialog

Follow-up Comment #3, bug #15104 (project freeciv): Yes, and both patches were ready. Though I'm not sure I will be able to commit before late February. ___ Reply to this item at: __

[Freeciv-Dev] [bug #15104] S2_2: gui-xaw never shows connection dialog

Follow-up Comment #4, bug #15104 (project freeciv): > Though I'm not sure I will be able to commit before late > February. So I will probably commit it for you to have it included in 2.2.0... ___ Reply to this item at:

[Freeciv-Dev] [bug #15309] fix tmap_y2str(); mixed up ysize and xsize

URL: Summary: fix tmap_y2str(); mixed up ysize and xsize Project: Freeciv Submitted by: syntron Submitted on: Montag 08.02.2010 um 15:48 Category: general Severity: 3 - Normal

[Freeciv-Dev] [bug #15310] fix creation of tropical temperature range

URL: Summary: fix creation of tropical temperature range Project: Freeciv Submitted by: syntron Submitted on: Montag 08.02.2010 um 15:49 Category: general Severity: 3 - Normal

[Freeciv-Dev] [bug #15311] update definition of ice_base_colatitude

URL: Summary: update definition of ice_base_colatitude Project: Freeciv Submitted by: syntron Submitted on: Montag 08.02.2010 um 15:51 Category: general Severity: 3 - Normal

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

URL: Summary: add check for ptile == NULL within map_colatitude() Project: Freeciv Submitted by: syntron Submitted on: Montag 08.02.2010 um 15:52 Category: general Severity: 3

[Freeciv-Dev] [bug #14944] fogged borders are not restored from a savegame

Update of bug #14944 (project freeciv): Status:None => Ready For Test Assigned to:None => syntron Planned Release: 2.3.0 => 2.2.0

[Freeciv-Dev] [bug #14944] fogged borders are not restored from a savegame

Follow-up Comment #7, bug #14944 (project freeciv): > It seems to be that I'm not able to change the settings for > this patch. worked now ... ___ Reply to this item at: ___

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

Follow-up Comment #2, patch #1444 (project freeciv): > I doubt the user need so much details about where the setting > stuff has failed (e.g. file and line). Don't forget that most > of those messages are returned to normal users. The additional information about the file and line could be remo

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

Follow-up Comment #3, patch #1444 (project freeciv): > Is it really such a slowdown to save a message in a string? I > don't know how often the settings code is called and how much > time one call needs ... It is not that slow. But the code is called tons of times. Every time someone connects,

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

Follow-up Comment #1, bug #15312 (project freeciv): assert() should be depreciated in newer version. Prefer the log_assert_ret() macro or RETURN_IF_FAIL() in S2_2. (I'm currently working on a patch to remove all assert() calls). ___ Rep

[Freeciv-Dev] [bug #15286] error message within registry.c:secfile_from_input_file()

Update of bug #15286 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15290] Units can be airlifted from an allied city to an other allied city

Update of bug #15290 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15313] No way to airlift unit to/from allied cities

URL: Summary: No way to airlift unit to/from allied cities Project: Freeciv Submitted by: pepeto Submitted on: lundi 08.02.2010 à 15:54 Category: client Severity: 2 - Minor

[Freeciv-Dev] [bug #15313] No way to airlift unit to/from allied cities

Update of bug #15313 (project freeciv): Depends on: => patch #1189 ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [patch #1189] [Patch] Allow airlifts to allied cities

Update of patch #1189 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1200] game settings can be locked by the ruleset

Follow-up Comment #9, patch #1200 (project freeciv): > Some comments: Thanks for the comments. They are included in the attached patch. (file #8000) ___ Additional Item Attachment: File name: 20100208-trunk-game-settings-can-be-loc

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

Follow-up Comment #2, bug #15312 (project freeciv): > assert() should be depreciated in newer version. Prefer the > log_assert_ret() macro or RETURN_IF_FAIL() in S2_2. I thought about this but did not know that to safely return? map_colatitude() should return the colatitude. Should I use 0, MAX

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

Follow-up Comment #4, patch #1444 (project freeciv): OK; next try ... ;-) replace char '**reject_msg' by 'char *reject_msg, size_t reject_msg_len' use a new macro to check if reject_msg is NULL (file #8002) ___ Additional Item Attachment

[Freeciv-Dev] [bug #15305] memory leak in map_allocate

Follow-up Comment #2, bug #15305 (project freeciv): You are right about the reallocs. Instead of calling this a "leak" I should have said "map_allocate() relies on process exit to free some of its memory" or something like that. I admit I don't understand why realloc is used in the index arrays

[Freeciv-Dev] [bug #15294] Auto Explore feature does not work (and some suggestions)

Follow-up Comment #2, bug #15294 (project freeciv): savegame attached (file #8003) ___ Additional Item Attachment: File name: AutoExplore.sav.gz Size:101 KB ___ Reply

[Freeciv-Dev] [bug #15314] Client crashes after setting worklist to cities

URL: Summary: Client crashes after setting worklist to cities Project: Freeciv Submitted by: None Submitted on: Monday 02/08/2010 at 21:09 CET Category: client Severity: 3 - No

[Freeciv-Dev] [bug #15291] Incorrect helpdata in tutorial

Update of bug #15291 (project freeciv): Assigned to:None => jtn ___ Follow-up Comment #2: Jacob, could you comment on this since you're heading up the documentation effort? ___

[Freeciv-Dev] [bug #15305] memory leak in map_allocate

Follow-up Comment #3, bug #15305 (project freeciv): > I guess it wasn't a very good patch. I would not say that. It is good to know that here a call to free() is missing! > The original code was written by jdorje and glip back in 2004. > Hopefully they can tell us what is the right thing to do.

[Freeciv-Dev] [bug #15315] memory leak in server/ruleset.c : load_ruleset_units()

URL: Summary: memory leak in server/ruleset.c : load_ruleset_units() Project: Freeciv Submitted by: None Submitted on: Monday 02/08/2010 at 21:41 CET Category: general Severity

Re: [Freeciv-Dev] [Freeciv-i18n] Making default ruler names translateable?

Yes, it's correct that no leader names are currently marked for translation. If we want to go down this path and internationalize leader names, I can see at least one major technical and one major practical obstacle: First, we must make sure all server commands that interact with leaders/players

[Freeciv-Dev] [bug #15291] Incorrect helpdata in tutorial

Follow-up Comment #3, bug #15291 (project freeciv): I haven't actually looked at the tutorial scenario yet. Probably it wasn't updated after the command key revamp (patch #1188). I'll commit your patch soon, and add reviewing the tutorial for other issues to my list (although I don't know if I'll

[Freeciv-Dev] [bug #15292] Help data claims irrigation doesn't need water source

Update of bug #15292 (project freeciv): Status: Ready For Test => In Progress ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #15292] Help data claims irrigation doesn't need water source

Update of bug #15292 (project freeciv): Status: In Progress => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15291] Incorrect helpdata in tutorial

Update of bug #15291 (project freeciv): Status: Ready For Test => In Progress ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #15291] Incorrect helpdata in tutorial

Update of bug #15291 (project freeciv): Status: In Progress => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15316] Refresh tutorial scenario for 2.2

URL: Summary: Refresh tutorial scenario for 2.2 Project: Freeciv Submitted by: jtn Submitted on: Monday 08/02/10 at 21:36 Category: docs Severity: 3 - Normal Pr

[Freeciv-Dev] [patch #1401] [Metaticket] Improve in-game help

Update of patch #1401 (project freeciv): Depends on: => bugs #15316 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #1200] game settings can be locked by the ruleset

Follow-up Comment #10, patch #1200 (project freeciv): Typo in civ2 ruleset: >; freeciv game settings for the civ1 ruleset ___ Reply to this item at: ___ Messag

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

Follow-up Comment #3, bug #15312 (project freeciv): > Perhaps 'MAX_COLATITUDE / 2' Seems a good compromise. Unfortunately, file #8001 appears to compile on trunk only, not S2_2. ___ Reply to this item at:

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

Follow-up Comment #5, patch #1444 (project freeciv): Very big improvement! One tip about the code: you can use _("string") as a c-format, no need to set "%s", (yes, it's not logical because it is also a value returned by a function, but gcc allow it). Maybe some message could be improved, notabl

[Freeciv-Dev] [bug #15314] Client crashes after setting worklist to cities

Update of bug #15314 (project freeciv): Priority: 5 - Normal => 7 - High ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [bug #15305] memory leak in map_allocate

Follow-up Comment #4, bug #15305 (project freeciv): In current branches like S2_2 and trunk, I can affirm you that now the game and the map are freed in client side when the client is disconnected; so using malloc would be correct nowadays. (I'm not sure about S2_1). __

[Freeciv-Dev] [bug #15315] memory leak in server/ruleset.c : load_ruleset_units()

Update of bug #15315 (project freeciv): Status:None => Ready For Test Release: => trunk Planned Release: => 2.3.0 _

[Freeciv-Dev] [bug #15316] Refresh tutorial scenario for 2.2

Follow-up Comment #1, bug #15316 (project freeciv): Yes, I found it too when working on the French translation. ___ Reply to this item at: ___ Message posté via

[Freeciv-Dev] [bug #15305] memory leak in map_allocate

Follow-up Comment #5, bug #15305 (project freeciv): Unfortunately, it seems it doesn't in server side... ___ Reply to this item at: ___ Message posté via/par G

[Freeciv-Dev] [bug #15315] memory leak in server/ruleset.c : load_ruleset_units()

Update of bug #15315 (project freeciv): Status:None => Ready For Test ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [bug #15314] Client crashes after setting worklist to cities

Update of bug #15314 (project freeciv): Category: client => client-gtk-2.0 Status:None => Ready For Test Assigned to:None => pepeto Planned Release:

[Freeciv-Dev] [bug #15317] Confusing to refer to corruption as "Waste" in city dialog popup

URL: Summary: Confusing to refer to corruption as "Waste" in city dialog popup Project: Freeciv Submitted by: jtn Submitted on: Monday 08/02/10 at 23:09 Category: None Severity

[Freeciv-Dev] [bug #15315] memory leak in server/ruleset.c : load_ruleset_units()

Update of bug #15315 (project freeciv): Assigned to:None => pepeto Planned Release: => 2.3.0 ___ Reply to this item at:

[Freeciv-Dev] [bug #15317] Confusing to refer to corruption as "Waste" in city dialog popup

Update of bug #15317 (project freeciv): Status:None => Ready For Test Planned Release: => 2.2.0 ___ Additional Item Attachment: File name: S

[Freeciv-Dev] [bug #15317] Confusing to refer to corruption as "Waste" in city dialog popup

Follow-up Comment #1, bug #15317 (project freeciv): > It's theoretically possible to create food loss through the effects system ...and, I think, other output types like science/luxury. Same comment. ___ Reply to this item at:

Re: [Freeciv-Dev] [Freeciv-i18n] Release update

Daniel Markstedt writes: > We have very nearly resolved all bugs targeted for 2.2.0 final > release. As a result, a Release Candidate for 2.2.0 scheduled is > planned to be released on February 14. Is the creation of this release candidate intended to start a string freeze? __

[Freeciv-Dev] [bug #15305] memory leak in map_allocate

Follow-up Comment #6, bug #15305 (project freeciv): Here is my second attempt at a patch. This time around, the idea is to make memory management for city.c : city_map_index and map.c : map.iterate_outwards_indices work exactly the same way as it does for map.tiles. This time calls to realloc a

[Freeciv-Dev] [bug #15318] Confusion in UI between "celebrating"/"rapture", "disorder"/"revolt"/"revolution"

URL: Summary: Confusion in UI between "celebrating"/"rapture", "disorder"/"revolt"/"revolution" Project: Freeciv Submitted by: jtn Submitted on: Tuesday 09/02/10 at 00:38 Category: None

[Freeciv-Dev] [bug #15319] Military units don't make citizens quite unhappy enough

URL: Summary: Military units don't make citizens quite unhappy enough Project: Freeciv Submitted by: jtn Submitted on: Tuesday 09/02/10 at 01:16 Category: None Severity: 3 - No

[Freeciv-Dev] [patch #1459] Help: clarify which buildings/wonders help with military unhappiness

URL: Summary: Help: clarify which buildings/wonders help with military unhappiness Project: Freeciv Submitted by: jtn Submitted on: Tuesday 09/02/10 at 02:50 Category: docs Pri

[Freeciv-Dev] [patch #1401] [Metaticket] Improve in-game help

Update of patch #1401 (project freeciv): Depends on: => patch #1459 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #15317] Confusing to refer to non-shield loss (e.g. corruption) as "Waste"

Update of bug #15317 (project freeciv): Status: Ready For Test => None Summary: Confusing to refer to corruption as "Waste" in city dialog popup => Confusing to refer to non-shield loss (e.g. corruption) as "Waste" __

[Freeciv-Dev] [bug #15317] Confusing to refer to non-shield loss (e.g. corruption) as "Waste"

Update of bug #15317 (project freeciv): Status:None => Ready For Test Depends on: => patch #1459 ___ Reply to this item at: