[Freeciv-Dev] [patch #2908] FC_CANVAS_INIT

2013-03-23 Thread Jacob Nevins
Update of patch #2908 (project freeciv): Planned Release: 2.5.0 => 2.4.0,2.5.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3382] simplify buttons based on stock images

2013-03-23 Thread Jacob Nevins
Update of patch #3382 (project freeciv): Planned Release: 2.5.0 => 2.4.0,2.5.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3348] move unit popups in citydlg slightly

2013-03-23 Thread Jacob Nevins
Update of patch #3348 (project freeciv): Planned Release: => 2.4.0,2.5.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3543] Switch from GdkColor to GdkRGBA

2013-03-23 Thread Jacob Nevins
Update of patch #3543 (project freeciv): Planned Release: 2.5.0 => 2.4.0,2.5.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3564] Use grids in helpdlg (patch 28/60)

2013-03-23 Thread Jacob Nevins
Update of patch #3564 (project freeciv): Planned Release: 2.5.0 => 2.4.0,2.5.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3561] Use grids for supported/present units (patch 27/60)

2013-03-23 Thread Jacob Nevins
Update of patch #3561 (project freeciv): Planned Release: 2.5.0 => 2.4.0,2.5.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3565] Use grids in citydlg overview page (patch 29/60)

2013-03-23 Thread Jacob Nevins
Update of patch #3565 (project freeciv): Planned Release: 2.5.0 => 2.4.0,2.5.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3566] Use grids for worklists (patch 31/60)

2013-03-23 Thread Jacob Nevins
Update of patch #3566 (project freeciv): Planned Release: 2.5.0 => 2.4.0,2.5.0 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2013-03-23 Thread Jacob Nevins
Update of patch #3469 (project freeciv): Planned Release: 2.5.0 => 2.4.0,2.5.0 ___ Follow-up Comment #139: No-one screamed... ___ Reply to thi

[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile->units) failed

2013-03-23 Thread Jacob Nevins
Update of bug #19989 (project freeciv): Planned Release: => 2.5.0 ___ Follow-up Comment #2: Still reproducible with latest trunk (r22533) -- hit Turn Done, and the relevant Warriors (id 22

[Freeciv-Dev] [bug #16079] Update docs to reflect file name changes

2013-03-23 Thread Marko Lindqvist
Update of bug #16079 (project freeciv): Status: In Progress => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20541] in auto_arrange_workers() [cityturn.c::397]: assertion 'city_size_get(pcity) - spe == sum' failed

2013-03-23 Thread Jacob Nevins
Update of bug #20541 (project freeciv): Status:None => Ready For Test Assigned to:None => jtn Planned Release: => 2.5.0 __

[Freeciv-Dev] [patch #3793] [metaticket] Help updates for 2.5.0

2013-03-23 Thread Jacob Nevins
URL: Summary: [metaticket] Help updates for 2.5.0 Project: Freeciv Submitted by: jtn Submitted on: Sat Mar 23 17:55:46 2013 Category: docs Priority: 5 - Normal

[Freeciv-Dev] [patch #3794] Help needs updating for nationality-related happiness

2013-03-23 Thread Jacob Nevins
URL: Summary: Help needs updating for nationality-related happiness Project: Freeciv Submitted by: jtn Submitted on: Sat Mar 23 17:58:21 2013 Category: docs Priority: 5 - Normal

[Freeciv-Dev] [patch #3793] [metaticket] Help updates for 2.5.0

2013-03-23 Thread Jacob Nevins
Update of patch #3793 (project freeciv): Depends on: => patch #3794 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] Threads

2013-03-23 Thread Jacob Nevins
I haven't really been closely following the introduction of threads and concurrency into Freeciv, although I've been dimly aware that it's happening. However, it seems likely that there are some basics that I (and every other developer) ought to know, such as functions and data structures in commo

Re: [Freeciv-Dev] Threads

2013-03-23 Thread Marko Lindqvist
On 23 March 2013 21:02, Jacob Nevins <0jacobnk.fc...@chiark.greenend.org.uk> wrote: > I haven't really been closely following the introduction of threads and > concurrency into Freeciv, although I've been dimly aware that it's > happening. Slowly, but unreliably. > However, it seems likely that

[Freeciv-Dev] [patch #3715] Threaded AI cities generating Worker task requests

2013-03-23 Thread Jacob Nevins
Follow-up Comment #4, patch #3715 (project freeciv): Unfortunately this is giving warnings for me (GCC 4.4.3-4ubuntu5.1 on Ubuntu 10.04): taicity.c: In function ‘tai_city_worker_requests_create’: taicity.c:56: error: ‘task.tgt.type’ may be used uninitialized in this function taicity.c:56: error:

[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile->units) failed

2013-03-23 Thread Marko Lindqvist
Follow-up Comment #3, bug #19989 (project freeciv): Yes, unit_move() calls unit_move_consequences(), which eventually handles city changing hands and old owner losing vision, before send_unit_info_to_onlookers() to update client knowledge about unit location. _

Re: [Freeciv-Dev] Threads

2013-03-23 Thread Jacob Nevins
Marko Lindqvist writes: > That's quite a moving target. At the moment almost nothing in game > logic is thread safe. The only shared resource between metaserver > thread and other threads is logging, which is protected by mutex. The > little functionality that threaded AI currently has in separete

[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile->units) failed

2013-03-23 Thread Marko Lindqvist
Follow-up Comment #4, bug #19989 (project freeciv): Comments above send_unit_info_to_onlookers() make it clear that it should be called before unit_move_consequences() but the regardless the order of the calls was schanged in r20388, patch #2547 ___

[Freeciv-Dev] [bug #19989] client assertion unit_list_size(ptile->units) failed

2013-03-23 Thread Marko Lindqvist
Update of bug #19989 (project freeciv): Planned Release: 2.5.0 => 2.4.0, 2.5.0 ___ Follow-up Comment #5: Faulty commit was made to trunk only, but just before S2_4 branching. _

[Freeciv-Dev] [bug #20495] punit->activity_count overflow

2013-03-23 Thread Jacob Nevins
Follow-up Comment #3, bug #20495 (project freeciv): The patch attached seems like a fine thing to apply. The consequences of the bug for ACTIVITY_SENTRY seem entirely harmless: the client uses activity_count to display how many turns are left on an activity, but of course not for ACTIVITY_SENTRY.

[Freeciv-Dev] [bug #20641] punit->activity_count incremented needlessly for sentried units

2013-03-23 Thread Jacob Nevins
URL: Summary: punit->activity_count incremented needlessly for sentried units Project: Freeciv Submitted by: jtn Submitted on: Sat Mar 23 22:20:34 2013 Category: None Severity:

[Freeciv-Dev] [bug #20495] punit->activity_count overflow

2013-03-23 Thread Jacob Nevins
Update of bug #20495 (project freeciv): Status: Need Info => In Progress Assigned to:None => jtn Release: => 2.3.4,2.4.0-beta1 Operating System:

[Freeciv-Dev] [bug #20641] punit->activity_count incremented needlessly for sentried units

2013-03-23 Thread Jacob Nevins
Update of bug #20641 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #1: In addition to pepeto's patch (file #17263), this one zeroes activity_count in savefiles for ACT

[Freeciv-Dev] [bug #20495] punit->activity_count overflow

2013-03-23 Thread Jacob Nevins
Update of bug #20495 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #5: Attached patches for all branches which increase the size of the network field to UINT16. The t

[Freeciv-Dev] [patch #3787] Disable river specials

2013-03-23 Thread Marko Lindqvist
Update of patch #3787 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #3795] Remove river special related definitions from rulesets

2013-03-23 Thread Marko Lindqvist
URL: Summary: Remove river special related definitions from rulesets Project: Freeciv Submitted by: cazfi Submitted on: Sun 24 Mar 2013 07:45:34 AM EET Category: general Priorit

[Freeciv-Dev] [bug #20567] Lua random() not really random

2013-03-23 Thread Marko Lindqvist
Follow-up Comment #5, bug #20567 (project freeciv): My patch has reproducibility problem in my own regression testing use-case. I use random seeds to get different games, but log those seeds carefully for using in reproduction of the problems encountered. But with my patch main random state goes o

[Freeciv-Dev] [bug #20567] Lua random() not really random

2013-03-23 Thread Marko Lindqvist
Update of bug #20567 (project freeciv): Category:None => general ___ Follow-up Comment #6: - Game random state proceeds the same way for same map seed regradless if it the map seed was ex