[Freeciv-Dev] [patch #4819] Allow imposition of a pythoagorean movement cost penalty for diagonal moves in rect

Follow-up Comment #1, patch #4819 (project freeciv): Are you sure the following line is correct? (int) (cost * 1.41421356f) I thought in this case the multiplication would be done in integer (due to the type of 'cost'), which would result as multiply cost by 1 (so effect). I would have wrote:

[Freeciv-Dev] [bug #22216] trunk server crashes in execute_orders()

URL: Summary: trunk server crashes in execute_orders() Project: Freeciv Submitted by: pepeto Submitted on: mer. 18 juin 2014 11:44:32 CEST Category: None Severity: 5 - Blocker

[Freeciv-Dev] [bug #22136] Units working in teams building roads can get left behind

Update of bug #22136 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4819] Allow imposition of a pythoagorean movement cost penalty for diagonal moves in rect

Follow-up Comment #2, patch #4819 (project freeciv): I checked it several ways, confirming both in-game and with various language references. I also wrote a simple test program to confirm syntax (although I've deleted it). From memory: #include int main (void) { int i, q; for(i=0;i++;i<37

[Freeciv-Dev] [patch #4807] Make unit activity updating more predicable

Update of patch #4807 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22138] Server wants us to remove unit id 109, but we don't know about this unit!

Update of bug #22138 (project freeciv): Assigned to:None => pepeto ___ Reply to this item at: ___ Message post

[Freeciv-Dev] [bug #22217] Autoexplore and some other AI features broken

URL: Summary: Autoexplore and some other AI features broken Project: Freeciv Submitted by: pepeto Submitted on: mer. 18 juin 2014 12:40:13 CEST Category: ai Severity: 4 - Import

[Freeciv-Dev] [patch #4820] Use parameter-based hash table instead of unittype-based array for pf_reserve_map

URL: Summary: Use parameter-based hash table instead of unittype-based array for pf_reserve_map Project: Freeciv Submitted by: pepeto Submitted on: mer. 18 juin 2014 12:50:49 CEST Category: ai

[Freeciv-Dev] [patch #4821] Do not consider harmless units in assess_danger()

URL: Summary: Do not consider harmless units in assess_danger() Project: Freeciv Submitted by: pepeto Submitted on: mer. 18 juin 2014 12:52:29 CEST Category: ai Priority: 5 - No

[Freeciv-Dev] [patch #4821] Do not consider harmless units in assess_danger()

Follow-up Comment #1, patch #4821 (project freeciv): It probably makes sense to consider UTYF_DIPLOMAT units threatening, even if they are UTYF_CIVILIAN, as otherwise the AI will happily ignore swarms of spies and diplomats, probably even after they proceed to incite revolts (as long as no actual

[Freeciv-Dev] [patch #4739] Make civ2civ3 ruleset the default

Follow-up Comment #6, patch #4739 (project freeciv): I'm liking the way civ2civ3 is being managed here by cazfi. When I send a new patch, I feel safer because I know that someone who knows the code, and the compatibility rules, is going to check the patch. If cazfi agree to continue this way, I'm

[Freeciv-Dev] [patch #4739] Make civ2civ3 ruleset the default

Follow-up Comment #7, patch #4739 (project freeciv): >While setting this system up, one thing to consider is savegame compatibility... From now on, I'll try to take into acount these compatibility issues. I'll also use as guide for new patches the idea that a game started with a freeciv version sh

[Freeciv-Dev] [patch #4739] Make civ2civ3 ruleset the default

Follow-up Comment #8, patch #4739 (project freeciv): On the notification: not every change to the civ2civ3 ruleset is going to be ruleset-specific, so one needs a broader catch (e.g. patch #4819 includes a change to the civ2civ3 ruleset (to preserve current behaviour)). On a separate SVN: does su

[Freeciv-Dev] [patch #4822] Use requirements_vector for effects

URL: Summary: Use requirements_vector for effects Project: Freeciv Submitted by: persia Submitted on: Thu 19 Jun 2014 04:57:17 AM JST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #4821] Do not consider harmless units in assess_danger()

Update of patch #4821 (project freeciv): Status: Ready For Test => In Progress ___ Reply to this item at: ___ Message pos

[Freeciv-Dev] [patch #4362] Stub-ruleset

Follow-up Comment #3, patch #4362 (project freeciv): I've been providing stub ruleset as separate download for all freeciv branches since 2.1. http://www.cazfi.net/freeciv/rulesets.html#stub In any case, leaving possible inclusion to tarball to another ticket. Now I want this in to be maintained

[Freeciv-Dev] [patch #4362] Stub-ruleset

Update of patch #4362 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #4823] Update stub.ruleset to match other rulesets

URL: Summary: Update stub.ruleset to match other rulesets Project: Freeciv Submitted by: cazfi Submitted on: Thu 19 Jun 2014 12:34:13 AM EEST Category: rulesets Priority: 5 - No

[Freeciv-Dev] [patch #4739] Make civ2civ3 ruleset the default

Follow-up Comment #9, patch #4739 (project freeciv): > If not, I worry maintaining synchronisation may be a burden. I've been keeping a couple of rulesets synchronized with freeciv TRUNK. I also have updated some rulesets from freeciv release to freeciv release. I can tell that latter is *much* e

[Freeciv-Dev] [patch #4810] Dummy create_icon_theme_surf()

Update of patch #4810 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #4821] Do not consider harmless units in assess_danger()

Follow-up Comment #2, patch #4821 (project freeciv): > is_square_threatened() It would be nice to have these two similar functions sharing the code. I bet that if we ever add special units that are not UTYF_DIPLOMAT (which in fact is not telling so much any more as most actions are controlled by

[Freeciv-Dev] [bug #22058] tech_upkeep doesn't handle team pooled research

Follow-up Comment #1, bug #22058 (project freeciv): Looked at this in the context of bug #22158. So player_research_update() is called for every player and calculates tech_upkeep, which is stored in the possibly-shared research structure but was calculated using player-specific information -- eff

[Freeciv-Dev] [bug #22158] tech_upkeep_style 'Cities' vs team_pooled_research

Update of bug #22158 (project freeciv): Depends on: => bugs #22058 ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [bug #22158] tech_upkeep_style 'Cities' vs team_pooled_research

Follow-up Comment #2, bug #22158 (project freeciv): > The way I see it, I think the upkeep should take into acount > all the cities from all the players on the same team, as you > point. Thanks for the ruling. > If the tech upkeep is shared and paid only once per team [...] There's the rub. Lo

[Freeciv-Dev] [patch #4824] Pass real boolean to create_unit_surface()

URL: Summary: Pass real boolean to create_unit_surface() Project: Freeciv Submitted by: cazfi Submitted on: Thu 19 Jun 2014 02:12:23 AM EEST Category: client-sdl Priority: 5 - N

[Freeciv-Dev] [patch #4825] Ruledit automake variables _XXXFLAGS -> _xxxflags

URL: Summary: Ruledit automake variables _XXXFLAGS -> _xxxflags Project: Freeciv Submitted by: cazfi Submitted on: Thu 19 Jun 2014 02:21:40 AM EEST Category: bootstrap Priority:

[Freeciv-Dev] [patch #4809] Remove empty civserver.h

Follow-up Comment #1, patch #4809 (project freeciv): There had been an error in patch creation (it was partly reversed) Fixed version attached. (file #21082) ___ Additional Item Attachment: File name: CivserverHRm-2.patch Size:0

[Freeciv-Dev] [patch #4813] Ai effects evaluation module

Update of patch #4813 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #22217] Autoexplore and some other AI features broken

Follow-up Comment #1, bug #22217 (project freeciv): > Fix attached. Can't see. ___ Reply to this item at: ___ Message sent via/by Gna! http://gna.org/ _

[Freeciv-Dev] [bug #22216] trunk server crashes in execute_orders()

Update of bug #22216 (project freeciv): Category:None => general Assigned to:None => cazfi ___ Follow-up Comment #1: The savegame in que

[Freeciv-Dev] [bug #22170] SDL clients don't display veteran levels

Update of bug #22170 (project freeciv): Status:None => Ready For Test Planned Release: => 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #1: Patch There *is* s

[Freeciv-Dev] [bug #22125] "Nationality" happiness row has no tooltip at all

Update of bug #22125 (project freeciv): Status:None => Ready For Test Planned Release: => 2.5.0, 2.6.0 ___ Follow-up Comment #1: Only gtk3-client af

[Freeciv-Dev] [patch #4739] Make civ2civ3 ruleset the default

Follow-up Comment #10, patch #4739 (project freeciv): Getting further off-topic, but I suspect that we can avoid a lot of the pain involved with freeciv-ruledit if we are careful to make ruleset format changes backwards-compatible (so freeciv-ruledit can read the old format, and write the new one)

[Freeciv-Dev] [bug #22217] Autoexplore and some other AI features broken

Follow-up Comment #2, bug #22217 (project freeciv): > Can't see. Oops, sorry... (file #21086) ___ Additional Item Attachment: File name: fix_pf_node_init.patch Size:2 KB _

[Freeciv-Dev] [bug #22074] Vision not updated when city disbanded

Update of bug #22074 (project freeciv): Assigned to:None => pepeto ___ Reply to this item at: ___ Message post