Update of bug #15422 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #16, bug #15422 (project freeciv):
Again some comments:
updated patch for S2_2
(file #8275)
___
Additional Item Attachment:
File name: 20100225-S2_2-fix-illness-due-to-trade-S2_2.patch Size:14 KB
Follow-up Comment #4, bug #15422 (project freeciv):
* changed network definitions
This means that you need to modify the capability string defined in
version.in.
___
Reply to this item at:
http://gna.org/bugs/?15422
Follow-up Comment #5, bug #15422 (project freeciv):
=== S2_2 patch ===
* no changes to the network definitions
Actually, I forgot to mention that it is possible to perform such changes in
a stable branch. You must then to add in the capability string (in
version.in) a non-mandatory (named
Follow-up Comment #7, bug #15422 (project freeciv):
One small problem remains: the illness due to trade is only
updated at the start of the turn ...
You can add a send_city_info(city_owner(pcity), pcity) after it is
recalculated.
___
Follow-up Comment #8, bug #15422 (project freeciv):
if server and client have the 'illness_trade' capability,
illness due to trade will be displayed.
I dunno what capability are you talking about... As you said, you just
renamed a field of the packet, so it's not a 'change', because neither
Follow-up Comment #9, bug #15422 (project freeciv):
I did forgot to commit some important changes into git (capability changes);
version 3 attached
(file #8199)
___
Additional Item Attachment:
File name:
Follow-up Comment #10, bug #15422 (project freeciv):
You just renamed a field, so it is useless to change the capabilities. It
would be useful to add a field like:
UINT16 illness_trade; add-cap(illness_trade)
Anyway, it doesn't require such changes, it is useless. In a other hand,
because
Follow-up Comment #11, bug #15422 (project freeciv):
I dunno what capability are you talking about... As you said,
you just renamed a field of the packet, so it's not
a 'change', because neither the size, neither the order of the
fields has been changed.
Yes there are no changes in the
Follow-up Comment #12, bug #15422 (project freeciv):
I dunno what capability are you talking about... As you said,
you just renamed a field of the packet, so it's not
a 'change', because neither the size, neither the order of the
fields has been changed.
Yes there are no changes in the
Update of bug #15422 (project freeciv):
Depends on: = bugs #15373
___
Reply to this item at:
http://gna.org/bugs/?15422
___
Nachricht
Follow-up Comment #14, bug #15422 (project freeciv):
I am not sure to understand but if the value reflects the same
behaviour that the old one, it doesn't require a capability
change.
Both variables contain different values; I used the definitions of 'add-cap'
and 'remove-cap'.
=== patch
Follow-up Comment #15, bug #15422 (project freeciv):
Again some comments:
* We should avoid the changes of translatable strings in a stable branch,
especially when just modifying the format.
* in packhand.c there should the test to know what is the real value to read
from the packet, not
Update of bug #15422 (project freeciv):
Status:None = Ready For Test
Planned Release: = 2.2.1
___
Follow-up Comment #3:
=== S2_2 patch ===
Update of bug #15422 (project freeciv):
Assigned to:None = syntron
___
Follow-up Comment #2:
Thanks for looking into the illness configuration! I think the correct patch
for S2_2 (2.2.1)
Follow-up Comment #1, bug #15422 (project freeciv):
The other fix would be to calculate the breakdown on the server and send it
to the client -- I think this is what happens with happiness? Recalculating
it on the client feels fragile, and if we've got to change the packet format
anyway we may
16 matches
Mail list logo
