Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

On 11/09/2016 04:37 PM, Milan Kubík wrote: On 11/09/2016 04:34 PM, Milan Kubík wrote: On 11/03/2016 04:56 PM, Oleg Fayans wrote: Hi Martin, The commit message was updated with the correct ticket link Thanks for review! On 11/03/2016 04:22 PM, Martin Basti wrote: almost ACK, but the ticket

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

On 10/25/2016 10:24 AM, Oleg Fayans wrote: Integration part of the tests is ready. 2 tests: 1. Adds a cert to idoverride of a windows user 2. sssd part - looks up user by his certificate using dbus-sssd Second and third dbus call are executed as a string insted of as array of strings because

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

On 11/03/2016 04:56 PM, Oleg Fayans wrote: Hi Martin, The commit message was updated with the correct ticket link Thanks for review! On 11/03/2016 04:22 PM, Martin Basti wrote: almost ACK, but the ticket in commit message is closed as invalid. So I'm quite puzzled now what to do. On

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

On 11/09/2016 04:34 PM, Milan Kubík wrote: On 11/03/2016 04:56 PM, Oleg Fayans wrote: Hi Martin, The commit message was updated with the correct ticket link Thanks for review! On 11/03/2016 04:22 PM, Martin Basti wrote: almost ACK, but the ticket in commit message is closed as invalid. So

Re: [Freeipa-devel] [PATCH 0035][Tests] Fix failing tests in test_ipalib/test_frontend

On 08/17/2016 05:08 PM, Lenka Doudova wrote: On 08/17/2016 04:57 PM, Milan Kubík wrote: On 08/17/2016 04:45 PM, Lenka Doudova wrote: Hi, attached patch provides fix for 2 out of three failing tests in ipatests/test_ipalib/test_frontend.py. Failures were caused by changes related to thin

Re: [Freeipa-devel] [PATCH 0035][Tests] Fix failing tests in test_ipalib/test_frontend

On 08/17/2016 04:45 PM, Lenka Doudova wrote: Hi, attached patch provides fix for 2 out of three failing tests in ipatests/test_ipalib/test_frontend.py. Failures were caused by changes related to thin client implementation. Fix for the third failure will be provided later (after my PTO), as

Re: [Freeipa-devel] [PATCH 0034][Tests] Fix failing tests in test_ipalib/test_parameters

On 08/17/2016 04:31 PM, Lenka Doudova wrote: Hi, attached patch fixes part of failing tests in ipatests/test_ipalib/test_parameters.py. Failures were caused mainly by thin client feature, sometimes by usage of unicode, which tests did not reflect. Issues were discussed with Honza.

[Freeipa-devel] [patch 0052] ipatests: Fix wrong fixture in kerberos principal alias test

Fixes issue in ticket https://fedorahosted.org/freeipa/ticket/6197 -- Milan Kubik From b0a731c2b655c331001c9cb217f66045c9c2fdb7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Mon, 15 Aug 2016 14:31:48 +0200 Subject: [PATCH] ipatests: Fix wrong fixture

Re: [Freeipa-devel] [PATCH 42-44, 48-51][tests] RFE: Allow users to authenticate with alternative names

On 07/28/2016 12:51 PM, Martin Babinsky wrote: On 07/27/2016 11:54 AM, Milan Kubík wrote: Hi Milan, the tests seem to work as expected except `test_enterprise_principal_UPN_overlap_without_additional_suffix` which crashes on #6099. I have a few comments, however: This is a test

Re: [Freeipa-devel] [PATCH 42-47][tests] RFE: Allow users to authenticate with alternative names

Hi Milan, the tests seem to work as expected except `test_enterprise_principal_UPN_overlap_without_additional_suffix` which crashes on #6099. I have a few comments, however: This is a test that hits a known bug. I have added an expected fail marker for it. Patch 42: 1.) +class

Re: [Freeipa-devel] [PATCH 42-47][tests] RFE: Allow users to authenticate with alternative names

On 07/25/2016 01:53 PM, Milan Kubík wrote: Hi, I'm sending the tests for kerberos principal aliases rfe. The tests are implemented according to test plan [1] sent earlier. Some of the patches implement modifications and extensions to previous code to allow implement the tests themselves

[Freeipa-devel] [PATCH 42-47][tests] RFE: Allow users to authenticate with alternative names

Hi, I'm sending the tests for kerberos principal aliases rfe. The tests are implemented according to test plan [1] sent earlier. Some of the patches implement modifications and extensions to previous code to allow implement the tests themselves. The patches can be cloned also from github

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

On 07/14/2016 11:43 AM, Lenka Doudova wrote: On 07/14/2016 11:25 AM, Lenka Doudova wrote: On 07/14/2016 09:20 AM, Lenka Doudova wrote: On 07/13/2016 04:48 PM, Milan Kubík wrote: On 07/11/2016 01:34 PM, Lenka Doudova wrote: On 07/08/2016 02:24 PM, Milan Kubík wrote: On 07/01/2016

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

On 07/11/2016 01:34 PM, Lenka Doudova wrote: On 07/08/2016 02:24 PM, Milan Kubík wrote: On 07/01/2016 05:13 PM, Lenka Doudova wrote: On 07/01/2016 02:42 PM, Milan Kubík wrote: On 06/16/2016 03:23 PM, Lenka Doudova wrote: Hi, attached are tests for authentication indicators. Please

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

On 07/01/2016 05:13 PM, Lenka Doudova wrote: On 07/01/2016 02:42 PM, Milan Kubík wrote: On 06/16/2016 03:23 PM, Lenka Doudova wrote: Hi, attached are tests for authentication indicators. Please note: 1. newly created service tracker is not exactly complete, list of unimplemented methods

Re: [Freeipa-devel] [patch 0038-0040] Sub CA test patches

On 07/04/2016 08:57 AM, Fraser Tweedale wrote: Hi Milan, Yes, we can :) Two issues, outlined below. 1) Running the tests, I get error in test_create_subca_with_subject_conflict cleanup:: ERROR at teardown of TestCAbasicCRUD.test_create_subca_with_subject_conflict

Re: [Freeipa-devel] [patch 0038-0040] Sub CA test patches

On 06/27/2016 01:31 PM, Milan Kubík wrote: On 06/27/2016 02:57 AM, Fraser Tweedale wrote: On Fri, Jun 24, 2016 at 12:08:24PM +0200, Milan Kubík wrote: On 06/24/2016 03:42 AM, Fraser Tweedale wrote: On Tue, Jun 21, 2016 at 05:01:35PM +0200, Milan Kubík wrote: Hi Fraser and list, I have made

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

On 06/16/2016 03:23 PM, Lenka Doudova wrote: Hi, attached are tests for authentication indicators. Please note: 1. newly created service tracker is not exactly complete, list of unimplemented methods is in doc. These methods can be filled in when existing declarative tests are refactored.

Re: [Freeipa-devel] [PATCH 661] backup: use in-server API in ipa-backup and ipa-restore

On 06/29/2016 02:54 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza The restore works with the patch. ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0537] CA replica promotion: add proper CA DNS records

On 06/28/2016 04:59 PM, Martin Basti wrote: On 28.06.2016 16:46, Petr Spacek wrote: On 23.6.2016 12:44, Martin Basti wrote: patch attached. https://fedorahosted.org/freeipa/ticket/5966 ACK Pushed to master: 5693d195501611c6abe9dbdf1370b898ffa6b3c7 Pushed to ipa-4-3:

Re: [Freeipa-devel] Broken pki 10.3.3-1 packages in freeipa-master COPR

On 06/28/2016 01:20 PM, Alexander Bokovoy wrote: On Tue, 28 Jun 2016, Lukas Slebodnik wrote: On (28/06/16 10:57), Alexander Bokovoy wrote: On Tue, 28 Jun 2016, Petr Vobornik wrote: On 06/27/2016 08:11 PM, Lukas Slebodnik wrote: > On (27/06/16 17:55), Milan Kubík wrote: > &g

Re: [Freeipa-devel] Broken pki 10.3.3-1 packages in freeipa-master COPR

On 06/28/2016 01:03 PM, Lukas Slebodnik wrote: On (28/06/16 10:57), Alexander Bokovoy wrote: On Tue, 28 Jun 2016, Petr Vobornik wrote: On 06/27/2016 08:11 PM, Lukas Slebodnik wrote: On (27/06/16 17:55), Milan Kubík wrote: Hi all, the pki packages that are currently in the COPR repo [1

[Freeipa-devel] Broken pki 10.3.3-1 packages in freeipa-master COPR

Hi all, the pki packages that are currently in the COPR repo [1] are broken. There is a conflict between pki-server and pki-base: Error: Transaction check error: file /usr/lib/python2.7/site-packages/pki/server/deployment/pkiparser.pyc from install of pki-server-10.3.3-1.fc24.noarch

Re: [Freeipa-devel] [patch 0038-0040] Sub CA test patches

On 06/27/2016 02:57 AM, Fraser Tweedale wrote: On Fri, Jun 24, 2016 at 12:08:24PM +0200, Milan Kubík wrote: On 06/24/2016 03:42 AM, Fraser Tweedale wrote: On Tue, Jun 21, 2016 at 05:01:35PM +0200, Milan Kubík wrote: Hi Fraser and list, I have made changes to the test plan on the wiki [1

Re: [Freeipa-devel] [patch 0038-0040] Sub CA test patches

On 06/24/2016 03:42 AM, Fraser Tweedale wrote: On Tue, Jun 21, 2016 at 05:01:35PM +0200, Milan Kubík wrote: Hi Fraser and list, I have made changes to the test plan on the wiki [1] according to the information in "[Testplan review] Sub CAs" thread. I also implemented the tests i

Re: [Freeipa-devel] [PATCH] 0077 Check for CA subject name collision before attempting creation

On 06/24/2016 09:34 AM, Fraser Tweedale wrote: Hi, Attached patch fixes https://fedorahosted.org/freeipa/ticket/5981. Cheers, Fraser Thanks for the patch, ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [patch 0038-0040] Sub CA test patches

Hi Fraser and list, I have made changes to the test plan on the wiki [1] according to the information in "[Testplan review] Sub CAs" thread. I also implemented the tests in the test plan: patch 0038 - CATracker and CA CRUD test patch 0039 - extension to CA ACL test patch 0040 - functional test

[Freeipa-devel] [Testplan review] Sub CAs

Hi Fraser and list, I've wrote a (minimal) draft [1] of the test plan for the Sub CAs feature and I also have several questions. Could you please take a look at it? Questions: As described in the last (currently) test case, should it be possible to specify both the CA and certificate

Re: [Freeipa-devel] [DESIGN] Kerberos principal alias handling

On 04/08/2016 05:10 PM, Martin Babinsky wrote: Hi list, I have put together a draft [1] outlining the effort to reimplement the handling of Kerberos principals in both backend and frontend layers of FreeIPA so that we may have multiple aliases per user, host or service and thus implement

Re: [Freeipa-devel] [patch 0037] spec: Add python-sssdconfig dependency for python-ipatests package

On 04/25/2016 09:36 AM, Martin Babinsky wrote: On 04/23/2016 12:13 AM, Milan Kubík wrote: https://fedorahosted.org/freeipa/ticket/5843 Applies to ipa-4-3, master -- Milan Kubik Hi Milan, the dependency on python-sssdconfig was introduced by my fix to https://fedorahosted.org/freeipa

[Freeipa-devel] [patch 0037] spec: Add python-sssdconfig dependency for python-ipatests package

https://fedorahosted.org/freeipa/ticket/5843 Applies to ipa-4-3, master -- Milan Kubik From cb26da230ae358c1d1768d82c3be8e75bb2159d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Fri, 22 Apr 2016 23:43:47 +0200 Subject: [PATCH] spec: Add

Re: [Freeipa-devel] [patch 0035] ipatests: Add test case for requesting a certificate with full principal.

On 04/21/2016 03:29 PM, Martin Babinsky wrote: On 04/21/2016 03:25 PM, Martin Babinsky wrote: On 04/21/2016 11:24 AM, Milan Kubík wrote: On 04/05/2016 12:07 PM, Martin Babinsky wrote: On 04/05/2016 10:24 AM, Milan Kubík wrote: On 04/05/2016 10:17 AM, Milan Kubík wrote: On 04/05/2016 09:31

Re: [Freeipa-devel] [patch 0035] ipatests: Add test case for requesting a certificate with full principal.

On 04/05/2016 12:07 PM, Martin Babinsky wrote: On 04/05/2016 10:24 AM, Milan Kubík wrote: On 04/05/2016 10:17 AM, Milan Kubík wrote: On 04/05/2016 09:31 AM, Martin Babinsky wrote: On 04/01/2016 12:02 PM, Milan Kubík wrote: Patches attached. https://fedorahosted.org/freeipa/ticket/5733

Re: [Freeipa-devel] [patch 0035] ipatests: Add test case for requesting a certificate with full principal.

On 04/05/2016 10:17 AM, Milan Kubík wrote: On 04/05/2016 09:31 AM, Martin Babinsky wrote: On 04/01/2016 12:02 PM, Milan Kubík wrote: Patches attached. https://fedorahosted.org/freeipa/ticket/5733 Hi Milan, I would be more happy if you could send a separate patch for the context

Re: [Freeipa-devel] [patch 0035] ipatests: Add test case for requesting a certificate with full principal.

On 04/05/2016 09:31 AM, Martin Babinsky wrote: On 04/01/2016 12:02 PM, Milan Kubík wrote: Patches attached. https://fedorahosted.org/freeipa/ticket/5733 Hi Milan, I would be more happy if you could send a separate patch for the context manager fix, since the issue is orthogonal

[Freeipa-devel] [patch 0035] ipatests: Add test case for requesting a certificate with full principal.

Patches attached. https://fedorahosted.org/freeipa/ticket/5733 -- Milan Kubik From 985814ef076a828ac59aeafd0598d87983edc809 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Fri, 1 Apr 2016 11:11:54 +0200 Subject: [PATCH] ipatests: Add test case for

Re: [Freeipa-devel] [PATCH 0006] Refactor test_hostgroup_plugin

On 03/07/2016 02:53 PM, Filip Škola wrote: Sorry, forgot to cc you, Milan. F. On Tue, 22 Dec 2015 05:57:50 -0500 (EST) Filip Skola wrote: And also sending refactored hostgroup plugin test. F Sorry for long delay. ACK. -- Milan Kubik -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

On 03/11/2016 03:42 PM, Filip Skola wrote: - Original Message - On 01/28/2016 10:45 AM, Filip Skola wrote: The same as with patch 0002: * Module ipatests.test_xmlrpc.tracker.hostgroup_plugin W:142,26: Calling a dict.iter*() method (dict-iter-method) Please use dict.items

Re: [Freeipa-devel] [PATCH 0143-0144] different errors/warnings for different LDAP limit type exceeded

On 03/18/2016 10:28 AM, Martin Babinsky wrote: These patches implement behavior agreed upon during discussion of https://fedorahosted.org/freeipa/ticket/5677 However I'm not sure if we want to push them into 4-3 branch (the ticket is triaged into 4.3.2 milestone) since they modify the

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 02/22/2016 11:09 AM, Filip Skola wrote: - Original Message - On 02/10/2016 09:17 AM, Milan Kubík wrote: On 02/09/2016 04:19 PM, Milan Kubík wrote: On 01/28/2016 10:42 AM, Filip Skola wrote: - Original Message - On 01/25/2016 11:11 AM, Filip Skola wrote: - Original

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

On 01/28/2016 10:45 AM, Filip Skola wrote: The same as with patch 0002: * Module ipatests.test_xmlrpc.tracker.hostgroup_plugin W:142,26: Calling a dict.iter*() method (dict-iter-method) Please use dict.items method. -- Milan Kubik Hi, attaching a fixed patch. This patch is

Re: [Freeipa-devel] [PATCH 0422] CI: allow customized DS install test to run under different domain levels

On 03/02/2016 04:50 PM, Martin Basti wrote: On 24.02.2016 19:01, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5606 Patch attached. Bump for review Works for me, ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

On 02/19/2016 02:11 PM, Oleg Fayans wrote: Hi Milan, On 02/12/2016 04:03 PM, Milan Kubík wrote: Agreed. The latest patch gets rid of all resolv.conf related manipulations. The tests work (where not affected by https://fedorahosted.org/bind-dyndb-ldap/ticket/160) -- Milan Kubik Works

Re: [Freeipa-devel] [patch 0033] spec file: update the python-polib dependency name to python2-polib

On 02/25/2016 11:07 AM, Jan Cholasta wrote: On 25.2.2016 11:03, Milan Kubík wrote: On 02/15/2016 05:39 PM, Lukas Slebodnik wrote: On (15/02/16 17:00), Petr Vobornik wrote: On 02/15/2016 04:37 PM, Milan Kubík wrote: Reflect the updated name of the package. Seems to me as a packaging bug

Re: [Freeipa-devel] [patch 0033] spec file: update the python-polib dependency name to python2-polib

On 02/15/2016 05:39 PM, Lukas Slebodnik wrote: On (15/02/16 17:00), Petr Vobornik wrote: On 02/15/2016 04:37 PM, Milan Kubík wrote: Reflect the updated name of the package. Seems to me as a packaging bug in python-polib. It should use python_provide macro to handle the transition

Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

On 02/24/2016 07:05 PM, Martin Basti wrote: On 24.02.2016 08:34, Milan Kubík wrote: On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well

Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik Review bump. -- Milan Kubik -- Manage your subscription for the Freeipa

Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik From 518f85240a14f256b5cc8542f66d3766a66b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= <

Re: [Freeipa-devel] [patch 0033] spec file: update the python-polib dependency name to python2-polib

On 02/15/2016 05:00 PM, Petr Vobornik wrote: On 02/15/2016 04:37 PM, Milan Kubík wrote: Reflect the updated name of the package. Seems to me as a packaging bug in python-polib. It should use python_provide macro to handle the transition. I will open a bug against it, then. -- Milan Kubik

[Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

Patch attached. Applies on ipa-4-3 as well. -- Milan Kubik From 0f0433b360f65ffd4431948d1efed4428c39feae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Mon, 15 Feb 2016 16:54:34 +0100 Subject: [PATCH] ipatests: extend permission plugin test with new

[Freeipa-devel] [patch 0033] spec file: update the python-polib dependency name to python2-polib

Reflect the updated name of the package. -- Milan Kubik From 43d532107a150538246591b1999afc41bd43315e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Mon, 15 Feb 2016 15:54:40 +0100 Subject: [PATCH] spec file: update the python-polib dependency name to

Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology

On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group

Re: [Freeipa-devel] [PATCH] CI: Add simple replication test in 2-connected topology.

On 02/12/2016 10:50 AM, David Kupka wrote: On 10/02/16 08:51, David Kupka wrote: This topology should be closer to the ones in real world than our current ones. But it is still impractical and (hopefully) no one has such deployment. If some user could share his/her deployment topology I will be

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

On 02/04/2016 08:49 AM, Oleg Fayans wrote: Hi Petr, On 02/03/2016 02:19 PM, Petr Spacek wrote: On 3.2.2016 10:22, Oleg Fayans wrote: Guys, can anyone take a look at this? The commit message does not explain why you are setting search path. Fixed. I have to say that I do not like touching

Re: [Freeipa-devel] [patch 0032] ipatests: add missing certprofile fixture

On 02/11/2016 10:00 AM, Martin Babinsky wrote: On 02/09/2016 04:06 PM, Milan Kubík wrote: On 02/09/2016 02:37 PM, Milan Kubík wrote: Fixes the CA ACL tests broken by removed import. This patch doesn't rely on undocumented behavior of pytest. The patch invalidates patch 133 by Martin Babinsky

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 02/09/2016 04:19 PM, Milan Kubík wrote: On 01/28/2016 10:42 AM, Filip Skola wrote: - Original Message - On 01/25/2016 11:11 AM, Filip Skola wrote: - Original Message - On 01/15/2016 03:38 PM, Filip Skola wrote: Hi, sending rebased patch. F. - Original Message

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 02/10/2016 09:17 AM, Milan Kubík wrote: On 02/09/2016 04:19 PM, Milan Kubík wrote: On 01/28/2016 10:42 AM, Filip Skola wrote: - Original Message - On 01/25/2016 11:11 AM, Filip Skola wrote: - Original Message - On 01/15/2016 03:38 PM, Filip Skola wrote: Hi, sending

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

no longer applies to master. Rebase it, please. Milan - Original Message - From: "Filip Škola" <fsk...@redhat.com> To: "Milan Kubík" <mku...@redhat.com> Cc: freeipa-devel@redhat.com Sent: Wednesday, 9 December, 2015 7:01:02 PM Subject: Re: [Freeipa-devel] [PATCH

Re: [Freeipa-devel] [patch 0032] ipatests: add missing certprofile fixture

On 02/09/2016 02:37 PM, Milan Kubík wrote: Fixes the CA ACL tests broken by removed import. This patch doesn't rely on undocumented behavior of pytest. The patch invalidates patch 133 by Martin Babinsky. Patch updated with trac link -- Milan Kubik From

[Freeipa-devel] [patch 0032] ipatests: add missing certprofile fixture

Fixes the CA ACL tests broken by removed import. This patch doesn't rely on undocumented behavior of pytest. The patch invalidates patch 133 by Martin Babinsky. -- Milan Kubik From 73dc9e91605c9299e48cdf62ddc0eb4927471a57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?=

Re: [Freeipa-devel] [PATCH 0133] re-add missing fixture import to the CA ACL plugin test

On 02/02/2016 03:36 PM, Martin Babinsky wrote: This was causing some of the CA ACL plugin tests to fail/error. Possible NACK. This is not an officially supported way how to reuse fixtures. [1] I was working on a fix, that would contain all of the needed fixtures in the module that requires

Re: [Freeipa-devel] [PATCH 0003] Refactor test_replace

On 01/12/2016 03:04 PM, Milan Kubík wrote: On 12/04/2015 11:29 AM, Filip Škola wrote: On Fri, 4 Dec 2015 10:08:40 +0100 Milan Kubík <mku...@redhat.com> wrote: On 12/04/2015 10:04 AM, Filip Škola wrote: Hi, sending rather short one this time. F. NACK, UserTracker is imple

Re: [Freeipa-devel] [PATCH 0004] Refactor test_attr

On 01/12/2016 03:03 PM, Milan Kubík wrote: On 12/07/2015 01:25 PM, Filip Škola wrote: Now the tier marker have lost somewhere on the way... which is corrected in this patch. /me apologizes for the noise F. On Mon, 7 Dec 2015 13:00:41 +0100 Filip Škola <fsk...@redhat.com> wrote: Sel

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

- From: "Filip Škola" <fsk...@redhat.com> To: "Milan Kubík" <mku...@redhat.com> Cc: freeipa-devel@redhat.com Sent: Wednesday, 9 December, 2015 7:01:02 PM Subject: Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin On Mon, 7 Dec 2015 17:49:18 +0100 Milan

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

, Milan - Original Message - From: "Filip Skola" <fsk...@redhat.com> To: freeipa-devel@redhat.com Cc: "Milan Kubík" <mku...@redhat.com>, "Aleš Mareček" <amare...@redhat.com> Sent: Tuesday, 22 December, 2015 11:56:15 AM Subject: [PATCH 0005] Re

Re: [Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

On 01/22/2016 02:22 PM, Martin Babinsky wrote: On 01/19/2016 05:56 PM, Milan Kubík wrote: On 01/19/2016 05:31 PM, Milan Kubík wrote: Patch attached. This actually has a ticket opened. Patch with fixed commit message. ;) -- Milan Kubik Hi Milan, for the step 1 installation I would

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

why test mentions 32 characters without any other modified setup. NACK for now. - alich - This has been changed. This test still fails, though. Filip - Original Message - From: "Aleš Mareček" <amare...@redhat.com> To: "Filip Škola" <fsk...@redhat.com&

[Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

Patch attached. -- Milan Kubik From 8f343a755dfdf9feb1ab9a3b7c91797f80b0261e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Tue, 19 Jan 2016 15:06:38 +0100 Subject: [PATCH] ipatests: fix the install of external ca Fixes the install invocation in the

Re: [Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

On 01/19/2016 05:31 PM, Milan Kubík wrote: Patch attached. This actually has a ticket opened. Patch with fixed commit message. ;) -- Milan Kubik From d3e43f982d246a9d82807aeff1320e8c1af58e0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= <mku...@redhat.com> Date: Tue,

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

On 01/15/2016 03:37 PM, Filip Skola wrote: Hi, sending rebased patch. F. - Original Message - Hi, the patch no longer applies to master. Please rebase it. Thanks, Milan - Original Message - From: "Filip Skola" <fsk...@redhat.com> To: freeipa-devel@redha

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 01/15/2016 03:38 PM, Filip Skola wrote: Hi, sending rebased patch. F. - Original Message - Hello, sorry for delays. The patch no longer applies to master. Rebase it, please. Milan - Original Message - From: "Filip Škola" <fsk...@redhat.com> To: &q

Re: [Freeipa-devel] [PATCH 0003] Refactor test_replace

On 12/04/2015 11:29 AM, Filip Škola wrote: On Fri, 4 Dec 2015 10:08:40 +0100 Milan Kubík <mku...@redhat.com> wrote: On 12/04/2015 10:04 AM, Filip Škola wrote: Hi, sending rather short one this time. F. NACK, UserTracker is implemented in ipatests.test_xmlrpc.tracker.user_plugin

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

On 01/07/2016 09:36 AM, Milan Kubík wrote: 0029: Add 10.in-addr.arpa. zone to ipa 0030: If the IP addresses in the topology are resolvable, do not add them to master. Hi. I'm dropping 0029 for now. 0030 gets an update. -- Milan Kubik From df95013b33fa1954cc92425fb7e6ea8dc6ac7e15 Mon Sep

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

. I'll use this one then. On 01/07/2016 09:36 AM, Milan Kubík wrote: 0029: Add 10.in-addr.arpa. zone to ipa 0030: If the IP addresses in the topology are resolvable, do not add them to master. How about other private subnets? What if I run test under 172.16.1.0/24 range, or 192.168.1.0/24

[Freeipa-devel] [patch 0027] ipatests: Roll back the forwarder config after a test case

Patch attached. -- Milan Kubik From 66db35cf2a315f0a58e002b06f0fcc5bd915a5c5 Mon Sep 17 00:00:00 2001 From: Milan Kubik Date: Thu, 17 Dec 2015 14:17:22 +0100 Subject: [PATCH] ipatests: Roll back the forwarder config after a test case ---

[Freeipa-devel] [patch 0026] ipatests: replace the test-example.com domain in tests

Applies to ipa-4-3 and master. Reason in commit message. -- Milan Kubik From 912ecd6c48149696eb8ca3c60644e5b24af6e534 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Wed, 16 Dec 2015 16:27:34 +0100 Subject: [PATCH] ipatests: replace the

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

On 12/15/2015 05:04 PM, Aleš Mareček wrote: - Original Message - From: "Milan Kubík" <mku...@redhat.com> To: "Petr Vobornik" <pvobo...@redhat.com> Cc: "freeipa-devel" <freeipa-devel@redhat.com>, "Ales Marecek" <amare...@re

Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA

On 12/15/2015 04:35 PM, Petr Vobornik wrote: On 12/15/2015 01:05 AM, Petr Vobornik wrote: Blocking patches for FreeIPA 4.3 were pushed, ipa-4-3 branch was created. Master branch is ready for 4.4 development. A build is available for testing in my pvoborni/freeipa-4-3 COPR repo [1] until the

Re: [Freeipa-devel] [PATCH 0116] CI tests: remove '-p' option from ipa-dns-install calls

On 12/10/2015 04:35 PM, Martin Babinsky wrote: See commit message. Works for me. ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 12/03/2015 08:15 PM, Filip Škola wrote: On Mon, 30 Nov 2015 17:18:30 +0100 Milan Kubík <mku...@redhat.com> wrote: On 11/23/2015 04:42 PM, Filip Škola wrote: Sending updated patch. F. On Mon, 23 Nov 2015 14:59:34 +0100 Filip Škola <fsk...@redhat.com> wrote: Found couple of i

Re: [Freeipa-devel] [PATCH 0003] Refactor test_replace

On 12/04/2015 10:04 AM, Filip Škola wrote: Hi, sending rather short one this time. F. NACK, UserTracker is implemented in ipatests.test_xmlrpc.tracker.user_plugin. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 11/23/2015 04:42 PM, Filip Škola wrote: Sending updated patch. F. On Mon, 23 Nov 2015 14:59:34 +0100 Filip Škola wrote: Found couple of issues (broke some dependencies). NACK F. On Fri, 20 Nov 2015 13:56:36 +0100 Filip Škola wrote: Another one.

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

On 11/27/2015 03:31 PM, Milan Kubík wrote: On 11/23/2015 10:43 AM, Lenka Doudova wrote: NACK - there's a "typo" in /tracker/user_plugin.py, line 17-18: def get_user_dn(cn): return DN(('cn', cn), api.env.container_user, api.env.basedn) should be def get_user_dn(uid):

Re: [Freeipa-devel] [PATCH 0102] update idrange tests to reflect disabled modification of local ID ranges

On 11/20/2015 04:06 PM, Martin Babinsky wrote: When I fixed https://fedorahosted.org/freeipa/ticket/4826 I forgot to fix the corresponding xmlrpc tests. This oversight bit me today when I ran in-tree tests on my VM. Here is the patch that makes idrange tests green and shiny again. Tests are

[Freeipa-devel] [patch 0024] Fix missed module import in ipaserver tests

-- Milan Kubik From 7dabe3f38005e1553b28b98a32578390f2bc629b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Thu, 12 Nov 2015 10:39:48 +0100 Subject: [PATCH] ipatests: Fix missed module import in ipaserver tests --- ipatests/test_ipaserver/test_ldap.py

Re: [Freeipa-devel] ipa-4-2 branch is broken !!!

On 11/12/2015 10:35 AM, Martin Basti wrote: Lint failed in current ipa-4-2 branch. === Errors were found during the static code check. If you are certain that any of the reported errors are false positives, please

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

On 11/10/2015 12:13 PM, Filip Škola wrote: Hi, fixed. F. On Tue, 10 Nov 2015 10:52:45 +0100 Milan Kubík <mku...@redhat.com> wrote: On 11/09/2015 04:35 PM, Filip Škola wrote: Another patch was applied in the meantime. Attaching an updated version. F. On Mon, 9 Nov 2015 13:35:02

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

On 11/09/2015 04:35 PM, Filip Škola wrote: Another patch was applied in the meantime. Attaching an updated version. F. On Mon, 9 Nov 2015 13:35:02 +0100 Milan Kubík <mku...@redhat.com> wrote: On 11/06/2015 11:32 AM, Filip Škola wrote: Hi, the patch doesn't apply. Plea

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

On 10/20/2015 02:19 PM, Martin Basti wrote: NACK 1) I still see many hardcoded passwords in the code with change_principal(smime_user, "Secret123"): For now changed to module variable. 2) Also the 'alice' username can be extracted to module variable instead hardcoding The fixture

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

On 10/19/2015 01:38 PM, Martin Basti wrote: On 16.10.2015 15:43, Milan Kubík wrote: On 09/30/2015 02:47 PM, Martin Basti wrote: On 09/24/2015 02:49 PM, Milan Kubík wrote: Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how

Re: [Freeipa-devel] [PATCHES 0321 - 0322] CI: vault CI test

On 10/08/2015 06:53 PM, Martin Basti wrote: Patches attached. Tests for https://fedorahosted.org/freeipa/ticket/5302 LGTM, ACK. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH] Workaround for trac N 5348

On 10/08/2015 02:50 PM, Martin Basti wrote: On 10/08/2015 02:39 PM, Martin Kosek wrote: On 10/08/2015 02:08 PM, Oleg Fayans wrote: Hi, On 10/08/2015 11:18 AM, Jan Pazdziora wrote: On Thu, Oct 08, 2015 at 11:12:37AM +0200, Oleg Fayans wrote: When the ticket is addressed and these

Re: [Freeipa-devel] [PATCH] Workaround for trac N 5348

On 10/09/2015 09:01 AM, Milan Kubík wrote: On 10/08/2015 02:50 PM, Martin Basti wrote: On 10/08/2015 02:39 PM, Martin Kosek wrote: On 10/08/2015 02:08 PM, Oleg Fayans wrote: Hi, On 10/08/2015 11:18 AM, Jan Pazdziora wrote: On Thu, Oct 08, 2015 at 11:12:37AM +0200, Oleg Fayans wrote: When

[Freeipa-devel] [patch 0022] ipatests: remove the ipatests specific config from ipaplatform

To keep the test specific configuration in the ipatest package. Patch attached. -- Milan Kubik From 49701f9775e59bd19bc62295af6ed332f1aa054b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Tue, 6 Oct 2015 14:55:49 +0200 Subject: [PATCH] ipatests: remove

Re: [Freeipa-devel] [patch 0022] ipatests: remove the ipatests specific config from ipaplatform

On 10/06/2015 03:01 PM, Milan Kubík wrote: To keep the test specific configuration in the ipatest package. Patch attached. Self NACK. This is not necessary in upstream. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo

[Freeipa-devel] [patch 0021] Include ipatests/test_xmlrpc/data directory into distribution

Adds ipatests/test_xmlrpc/data directory and its content into package. The files are needed for certprofile (and CA ACL) tests. Patch attached. -- Milan Kubik From 2e7e84f27590efd7b5097551104f723e018c722f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date:

Re: [Freeipa-devel] [PATCH] Proper fix for ticket 5306

On 10/02/2015 04:11 PM, Martin Basti wrote: On 10/01/2015 02:48 PM, Martin Basti wrote: On 10/01/2015 02:43 PM, Oleg Fayans wrote: Hi Martin, On 10/01/2015 11:18 AM, Martin Basti wrote: On 09/30/2015 01:24 PM, Martin Basti wrote: On 09/30/2015 12:19 PM, Oleg Fayans wrote: On

[Freeipa-devel] [patch 0020] ipatests: configure Network Manager not to manage resolv.conf

Fixes https://fedorahosted.org/freeipa/ticket/5331 Patch attached. From 4200b386058489f8ad73ee2d2f7eed582dea70b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Fri, 25 Sep 2015 21:09:24 +0200 Subject: [PATCH] ipatests: configure Network Manager not to

Re: [Freeipa-devel] [patch 0020] ipatests: configure Network Manager not to manage resolv.conf

On 10/01/2015 10:06 AM, Milan Kubík wrote: Fixes https://fedorahosted.org/freeipa/ticket/5331 Patch attached. Patch for ipa-4-2 branch. Milan From 5d19b29474b577688910a60fbc5efdf38ff6c455 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= <mku...@redhat.com> Date: Fri,

Re: [Freeipa-devel] [patch 0020] ipatests: configure Network Manager not to manage resolv.conf

On 10/01/2015 12:39 PM, Alexander Bokovoy wrote: On Thu, 01 Oct 2015, Milan Kubík wrote: On 10/01/2015 11:23 AM, Martin Basti wrote: On 10/01/2015 10:18 AM, Milan Kubík wrote: On 10/01/2015 10:06 AM, Milan Kubík wrote: Fixes https://fedorahosted.org/freeipa/ticket/5331 Patch attached

  1   2   >