Re: [Freeipa-devel] [PATCH] 138 Entitlement import.

2011-04-18 Thread Adam Young
On 04/15/2011 04:05 PM, Endi Sukma Dewata wrote: On 4/14/2011 4:13 PM, Adam Young wrote: The entitlement facet will invoke entitle_status to check the entitlement status and show the appropriate buttons. If it's unregistered it will show Register and Import button. If it's register

Re: [Freeipa-devel] [PATCH] 139 Entitlement download.

2011-04-18 Thread Adam Young
On 04/15/2011 04:21 PM, Endi Sukma Dewata wrote: A Download link has been added to download entitlement certificates. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK. Pushed to master

Re: [Freeipa-devel] [PATCH] 140 Moved adder dialog box into entity.

2011-04-18 Thread Adam Young
On 04/18/2011 06:47 PM, Endi Sukma Dewata wrote: The adder dialog box definition has been moved from search facet into entity to make it available to other facets. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/

Re: [Freeipa-devel] [PATCH] admiyo-0221-action-panel-to-top-tabs

2011-04-19 Thread Adam Young
Good points all. Only one minoir quibble, in-line. On 04/19/2011 05:31 PM, Endi Sukma Dewata wrote: On 4/19/2011 3:07 PM, Adam Young wrote: going to post this, but with a request to hold on pushing to the repo. I have not yet tested against selenium, and suspect that it will break all

Re: [Freeipa-devel] [PATCH] 142 Moved entity builder registration into webui.js.

2011-04-20 Thread Adam Young
On 04/19/2011 06:50 PM, Endi Sukma Dewata wrote: The entity builder registration have been moved into webui.js. This allows the WebUI to control which entities will be loaded. For instance, the entitlement should be loaded only if the plugin is enabled. This is done by checking the metadata. __

Re: [Freeipa-devel] [PATCH] 142 Moved entity builder registration into webui.js.

2011-04-20 Thread Adam Young
On 04/20/2011 12:28 PM, Endi Sukma Dewata wrote: On 4/20/2011 9:43 AM, Adam Young wrote: On 04/19/2011 06:50 PM, Endi Sukma Dewata wrote: The entity builder registration have been moved into webui.js. This allows the WebUI to control which entities will be loaded. For instance, the

Re: [Freeipa-devel] [PATCH] 140 Moved adder dialog box into entity.

2011-04-21 Thread Adam Young
On 04/19/2011 11:19 AM, Endi Sukma Dewata wrote: On 4/18/2011 6:06 PM, Adam Young wrote: The adder dialog box definition has been moved from search facet into entity to make it available to other facets. Shouldn't it move into add.js, or should add.js go away? This patch only modifie

Re: [Freeipa-devel] [PATCH] 142 Moved entity builder registration into webui.js.

2011-04-21 Thread Adam Young
On 04/20/2011 10:41 PM, Endi Sukma Dewata wrote: On 4/20/2011 4:32 PM, Endi Sukma Dewata wrote: On 4/20/2011 11:50 AM, Adam Young wrote: Leave the factories as the top level object. For the factory name, say 'entitle' check that the object is in the metadata. If not, don't cr

Re: [Freeipa-devel] [PATCH] 141 Standardized action panel buttons creation.

2011-04-21 Thread Adam Young
On 04/19/2011 02:07 PM, Endi Sukma Dewata wrote: Action panel buttons are now created in facet's create_action_panel(). This is to allow a subclass to override and customize the buttons. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://

[Freeipa-devel] [PATCH] admiyo-0222-Removed-entities-that-are-for-some-reason-invalid

2011-04-22 Thread Adam Young
This might be my favorite patch name yet. This patch depends on admiyo-0221-2 From 12cb82c6cfa037d90c2caf61d902f0bd21d264b4 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 22 Apr 2011 14:31:12 -0400 Subject: [PATCH] Removed entities that are, for some reason, invalid. --- install/ui

[Freeipa-devel] [PATCH] admiyo-0223-make-use-of-new-user-find-columns

2011-04-22 Thread Adam Young
required rcrit-0777 From 8b0c126c6b86674ae4a8df4660220bbf4bd48040 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 22 Apr 2011 15:22:31 -0400 Subject: [PATCH] make use of new user-find columns. --- install/ui/user.js |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

Re: [Freeipa-devel] [PATCH] 776 handle manager properly

2011-04-22 Thread Adam Young
On 04/22/2011 09:45 AM, Rob Crittenden wrote: manager should be a dn string so convert back and forth when adding/viewing entries. ticket 1151 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freei

Re: [Freeipa-devel] [PATCH] 777 adjust output of user-find

2011-04-22 Thread Adam Young
On 04/22/2011 01:47 PM, Rob Crittenden wrote: Modify the default attributes shown in user-find to match the UI design. This change means the UI can stop using the --all option and have to retrieve significantly less information from the server. It also speeds up user-find as it doesn't have to

Re: [Freeipa-devel] [PATCH] admiyo-0223-make-use-of-new-user-find-columns

2011-04-22 Thread Adam Young
On 04/22/2011 03:24 PM, Adam Young wrote: required rcrit-0777 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed in IRC and pushed to master

Re: [Freeipa-devel] [PATCH] admiyo-0223-make-use-of-new-user-find-columns

2011-04-22 Thread Adam Young
On 04/22/2011 04:07 PM, Adam Young wrote: On 04/22/2011 03:24 PM, Adam Young wrote: required rcrit-0777 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed in IRC and pushed to master

Re: [Freeipa-devel] [PATCH] 777 adjust output of user-find

2011-04-25 Thread Adam Young
On 04/25/2011 09:49 AM, Dmitri Pal wrote: On 04/22/2011 01:47 PM, Rob Crittenden wrote: Modify the default attributes shown in user-find to match the UI design. This change means the UI can stop using the --all option and have to retrieve significantly less information from the server. It also

Re: [Freeipa-devel] [PATCH] admiyo-0222-Removed-entities-that-are-for-some-reason-invalid

2011-04-26 Thread Adam Young
On 04/22/2011 02:34 PM, Adam Young wrote: This might be my favorite patch name yet. This patch depends on admiyo-0221-2 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Rebased on top of

Re: [Freeipa-devel] [PATCH] admiyo-0222-Removed-entities-that-are-for-some-reason-invalid

2011-04-26 Thread Adam Young
On 04/26/2011 12:18 PM, Adam Young wrote: On 04/22/2011 02:34 PM, Adam Young wrote: This might be my favorite patch name yet. This patch depends on admiyo-0221-2 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman

Re: [Freeipa-devel] [PATCH] admiyo-0221-action-panel-to-top-tabs

2011-04-26 Thread Adam Young
On 04/26/2011 03:12 PM, Endi Sukma Dewata wrote: On 4/26/2011 12:42 PM, Adam Young wrote: 20. The facet groups needs to be customizable. Currently it's stored in unordered set in entity's facet_group and the order is hard- coded in get_facet() and facet_tabs(). It would be di

[Freeipa-devel] [PATCH] admiyo-0225-remove-jquery-cookie-library

2011-04-26 Thread Adam Young
From d9da2a8fd7ef66429d1e7f0d4b4e31015a273b4c Mon Sep 17 00:00:00 2001 From: Adam Young Date: Tue, 26 Apr 2011 20:04:13 -0400 Subject: [PATCH] remove jquery-cookie library https://fedorahosted.org/freeipa/ticket/989 --- install/ui/Makefile.am |1 - install/ui/index.html

Re: [Freeipa-devel] [PATCH] 143 Entitlement quantity validation.

2011-04-26 Thread Adam Young
On 04/26/2011 05:48 PM, Endi Sukma Dewata wrote: The widget base class has been modified to validate integer value if the type is specified in the metadata. This is used to validate entitlement quantity. ___ Freeipa-devel mailing list Freeipa-devel@re

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Adam Young
On 04/27/2011 09:34 AM, Dmitri Pal wrote: On 04/27/2011 08:13 AM, Jan Cholasta wrote: On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically ru

Re: [Freeipa-devel] [PATCH] 143 Entitlement quantity validation.

2011-04-27 Thread Adam Young
On 04/27/2011 10:34 AM, Endi Sukma Dewata wrote: On 4/26/2011 8:23 PM, Adam Young wrote: The widget base class has been modified to validate integer value if the type is specified in the metadata. This is used to validate entitlement quantity. Logic looks good. I'd like to make the vali

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Adam Young
On 04/27/2011 10:24 AM, Martin Kosek wrote: On Wed, 2011-04-27 at 09:56 -0400, Adam Young wrote: On 04/27/2011 09:34 AM, Dmitri Pal wrote: On 04/27/2011 08:13 AM, Jan Cholasta wrote: On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011

[Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

2011-04-27 Thread Adam Young
From f4f5a644ffcc31c417c6d81998b52e2b17c8f0e3 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Wed, 27 Apr 2011 13:32:14 -0400 Subject: [PATCH] Added a container for the facet --- install/ui/details.js |2 +- install/ui/entity.js | 24 ++-- 2 files changed, 19

Re: [Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

2011-04-27 Thread Adam Young
On 04/27/2011 04:39 PM, Endi Sukma Dewata wrote: On 4/27/2011 12:56 PM, Adam Young wrote: Currently we have this DOM structure: 1. The nested entity-container is confusing and probably will make CSS adjustment harder. The entity content should be in the same level as

Re: [Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

2011-04-27 Thread Adam Young
On 04/27/2011 09:09 PM, Adam Young wrote: On 04/27/2011 04:39 PM, Endi Sukma Dewata wrote: On 4/27/2011 12:56 PM, Adam Young wrote: Currently we have this DOM structure: 1. The nested entity-container is confusing and probably will make CSS adjustment harder. The entity

Re: [Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

2011-05-02 Thread Adam Young
On 05/02/2011 09:28 PM, Endi Sukma Dewata wrote: On 4/27/2011 9:39 PM, Endi Sukma Dewata wrote: On 4/27/2011 8:47 PM, Adam Young wrote: The more I think about it, the more I think that this structure can be created by the navigation code, and then passed to the entity to populate. The entity

Re: [Freeipa-devel] [PATCH] 144 Refactored navigation.

2011-05-05 Thread Adam Young
On 05/04/2011 04:38 PM, Endi Sukma Dewata wrote: The singular object IPA.nav has been converted into an IPA.navigation class. The admin and self-service navigation tabs have been converted into subclasses of IPA.navigation and will be instantiated according to user authorization. __

Re: [Freeipa-devel] [PATCH] 145 Use entity names for tab state.

2011-05-05 Thread Adam Young
On 05/04/2011 04:39 PM, Endi Sukma Dewata wrote: Previously the tab state is represented using numeric index such as navigation=0&identity=1 which is not very user friendly. Now the code has been modified to use entity names such as navigation=identity&identity=group. __

Re: [Freeipa-devel] [PATCH] 146 Moved entity contents outside navigation.

2011-05-05 Thread Adam Young
On 05/04/2011 04:41 PM, Endi Sukma Dewata wrote: Previously the entities and navigation are entangled inside a common DOM structure which limits code reuse. Now they have been moved into separate structures. ___ Freeipa-devel mailing list Freeipa-deve

Re: [Freeipa-devel] [PATCH] 147 Added facet container.

2011-05-05 Thread Adam Young
On 05/04/2011 04:46 PM, Endi Sukma Dewata wrote: Facet container has been added to hold facet header (i.e. title, search fields, buttons, links) and facet content. Each facet now occupies separate container, so it can be shown/hidden without having to redraw the content. ___

Re: [Freeipa-devel] [PATCH] 149 Fixed self-service UI.

2011-05-06 Thread Adam Young
On 05/06/2011 03:43 PM, Endi Sukma Dewata wrote: The Identity tab for self-service UI was missing a label and there was a bug in navigation.js that was exposed because of that. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat

Re: [Freeipa-devel] [PATCH] 150 Updated Selenium tests.

2011-05-08 Thread Adam Young
On 05/06/2011 04:25 PM, Endi Sukma Dewata wrote: The following test suites have been updated to use the new DOM structure: user, group, host, hostgroup, netgroup, service, HBAC. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redha

[Freeipa-devel] ipa-server-install --uninstall not stopping services

2011-05-08 Thread Adam Young
Simo, Something has changed in the init scrip manipulation recently. Now, when I run ipa-server-install --uninstall -U and then ipa-server-install -U -r ` hostname | tr '[:lower:]' '[:upper:]'` -p freeipa4all -a freeipa4all I get IPA requires ports 389 and 636 for the Directory Server. T

Re: [Freeipa-devel] [Freeipa-users] FreeIPA questions

2011-05-09 Thread Adam Young
f F15 beta for testing as well. --Steve Adam Young wrote: On 05/09/2011 03:36 PM, SR wrote: I'm new to FreeIPA and this list so please forgive me for the n00b questions. I have what I think is a pretty straight-forward use for FreeIPA. We have an Active Directory environment with a few hu

Re: [Freeipa-devel] [PATCH] 150 Updated Selenium tests.

2011-05-10 Thread Adam Young
On 05/08/2011 07:48 PM, Adam Young wrote: On 05/06/2011 04:25 PM, Endi Sukma Dewata wrote: The following test suites have been updated to use the new DOM structure: user, group, host, hostgroup, netgroup, service, HBAC. ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] 24 Add sudorule and hbacrule to memberof AND indirectmemberof attributes

2011-05-10 Thread Adam Young
On 05/10/2011 04:38 PM, JR Aquino wrote: On Apr 22, 2011, at 12:53 PM, Rob Crittenden wrote: JR Aquino wrote: On Apr 12, 2011, at 9:45 AM, JR Aquino wrote: Add HBAC Rule and Sudo Rule to users as indirect member attributes to simplify the auditing of users for their indirect membership to t

Re: [Freeipa-devel] [PATCH] 24 Add sudorule and hbacrule to memberof AND indirectmemberof attributes

2011-05-10 Thread Adam Young
On 05/10/2011 11:07 PM, Adam Young wrote: On 05/10/2011 04:38 PM, JR Aquino wrote: On Apr 22, 2011, at 12:53 PM, Rob Crittenden wrote: JR Aquino wrote: On Apr 12, 2011, at 9:45 AM, JR Aquino wrote: Add HBAC Rule and Sudo Rule to users as indirect member attributes to simplify the auditing

Re: [Freeipa-devel] [PATCH] 155 Added Self-Service and Delegation tests.

2011-05-11 Thread Adam Young
On 05/10/2011 08:49 PM, Endi Sukma Dewata wrote: Added Self-Service and Delegation tests. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK. Pushed to master ___

Re: [Freeipa-devel] [PATCH] 154 Added UUID field for entitlement registration.

2011-05-11 Thread Adam Young
On 05/10/2011 06:54 PM, Endi Sukma Dewata wrote: The dialog box for entitlement registration has been modified to accept an optional enrollment UUID. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freei

Re: [Freeipa-devel] [PATCH] 153 Added Selenium tests for DNS.

2011-05-11 Thread Adam Young
On 05/10/2011 05:13 PM, Endi Sukma Dewata wrote: Added Selenium tests for DNS. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK. Pushed to master __

Re: [Freeipa-devel] [PATCH] 151 Updated Selenium tests.

2011-05-11 Thread Adam Young
On 05/10/2011 02:37 PM, Endi Sukma Dewata wrote: The following test suites have been updated to use the new DOM structure: SUDO, password policy, Kerberos Ticket policy, ACI. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.c

Re: [Freeipa-devel] [PATCH] 152 Updated DNS interface.

2011-05-11 Thread Adam Young
On 05/10/2011 05:12 PM, Endi Sukma Dewata wrote: The IPA.records_facet has been converted into a subclass of IPA.search_facet. This helps remove duplicate table code and provide consistent DOM element attributes for Selenium tests. ___ Freeipa-devel m

Re: [Freeipa-devel] [PATCH] 0013 Background images and tab hover

2011-05-11 Thread Adam Young
On 05/11/2011 02:10 PM, Kyle Baker wrote: Modified the background images and added a tab hover. Please ack. Kyle Baker Visual Designer Desk - 978 392 3116 IRC - kylebaker ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

[Freeipa-devel] Automount API consistancy and WebUI searchs

2011-05-11 Thread Adam Young
The general pattern for finding something is _find FILTER And for nested entities is _find PARENTKEY FILTER So for Automount it is automountlocation_find FILTER automountmap_find LOC FILTER So Key should be automountkey_find LOC MAP FILTER The show command should then be _show PKEY _sh

Re: [Freeipa-devel] [PATCH] admiyo-0220-update-ipa-init

2011-05-12 Thread Adam Young
On 05/12/2011 11:20 AM, Endi Sukma Dewata wrote: On 4/1/2011 10:58 AM, Adam Young wrote: ACK. This can be pushed after removing the -x from the script header. removed -x and whitespace, and pushed to master ___ Freeipa-devel mailing list Freeipa

[Freeipa-devel] Move DNS to the Identity Tab?

2011-05-13 Thread Adam Young
One minor piece of Feedback I got from people at the Summit was surprise that DNS was on the Policy tab and not on the Identity tab. Moving this is trivial. Does anyone object to me making that change? ___ Freeipa-devel mailing list Freeipa-devel@r

Re: [Freeipa-devel] [PATCH] 783 get group info when showing user

2011-05-13 Thread Adam Young
On 05/13/2011 04:10 PM, Rob Crittenden wrote: The UI team had asked that we provide some group info (GID, description) when showing users. This ads a special call to group_find to get this information. It is returned as a list of dicts. ticket 107 rob ___

[Freeipa-devel] Ticket #293

2011-05-13 Thread Adam Young
I'm tripping over the solution to this ticket: https://fedorahosted.org/freeipa/ticket/293 I don't understand the statement: "The key for a direct map is /- so only one can be in auto.master" auto.master is the map. Do you mean that there cannot be more than one direct map in a location? Th

[Freeipa-devel] Fwd: Re: [Freeipa-users] FreeIPA for Linux desktop deployment

2011-05-13 Thread Adam Young
Beyond my knowledge. Any help here? Original Message Subject:Re: [Freeipa-users] FreeIPA for Linux desktop deployment Date: Fri, 13 May 2011 18:38:07 -0700 (PDT) From: nasir nasir To: Adam Young I did this. Now my ipa automountlocation-tofiles default

Re: [Freeipa-devel] Ticket #293

2011-05-16 Thread Adam Young
On 05/16/2011 04:01 AM, Jakub Hrozek wrote: On 05/14/2011 03:27 AM, Adam Young wrote: I'm tripping over the solution to this ticket: https://fedorahosted.org/freeipa/ticket/293 I don't understand the statement: "The key for a direct map is /- so only one can be in auto.master&

Re: [Freeipa-devel] [PATCH] 156 Customizable facet groups.

2011-05-16 Thread Adam Young
On 05/16/2011 12:56 PM, Endi Sukma Dewata wrote: On 5/16/2011 11:23 AM, Endi Sukma Dewata wrote: The IPA.entity has been modified to support customizable facet groups. The default list of facet groups is defined in IPA.entity_header and can be overridden in the entity definition. The patch has

Re: [Freeipa-devel] [PATCH] 157 Read-only association facet.

2011-05-16 Thread Adam Young
On 05/16/2011 04:47 PM, Endi Sukma Dewata wrote: The IPA.association_facet has been modified to take a read_only parameters. If the parameter is set to true, the Enroll and Delete buttons will not be shown. All facets under the memberindirect and memberofindirect facet groups are marked as read

[Freeipa-devel] Streamline client use cases

2011-05-17 Thread Adam Young
There are a wide variety of install scenarios, so we don't get too specific on some scenarios. One that is pretty common in the test and acceptance phase that might not be a real issue in a live deployment deals with DHCP values for nameservers. For example, when coding on my laptop, the DHCP

Re: [Freeipa-devel] Streamline client use cases

2011-05-18 Thread Adam Young
On 05/18/2011 11:03 AM, Simo Sorce wrote: On Tue, 2011-05-17 at 13:56 -0400, Adam Young wrote: There are a wide variety of install scenarios, so we don't get too specific on some scenarios. One that is pretty common in the test and acceptance phase that might not be a real issue in a

Re: [Freeipa-devel] [PATCH] 158 JavaScript ordered map.

2011-05-19 Thread Adam Young
On 05/18/2011 10:21 AM, Endi Sukma Dewata wrote: A utility class has been added to store objects which can be accessed both as an ordered list and as a map. This class is used to store various objects including entities, fields, columns, and dialogs. The class needs to be defined in a new file

Re: [Freeipa-devel] [PATCH] 0014 Search Box Style

2011-05-20 Thread Adam Young
On 05/17/2011 01:22 PM, Kyle Baker wrote: Please review and ACK. Kyle Baker Visual Designer Desk - 978 392 3116 IRC - kylebaker ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel NACK. Nee

Re: [Freeipa-devel] [PATCH] 160 Development page for DataTables.

2011-05-20 Thread Adam Young
Works well on a liver server, but didn't work with my static checkout. The keystroke filtering is very nice, and would be useful. The number of results returned can be changed with the additional parameter. Sorting can be done on the client side if needs be. array.sort(/sortfunction/) wher

Re: [Freeipa-devel] [PATCH] 158 JavaScript ordered map.

2011-05-20 Thread Adam Young
On 05/19/2011 03:18 PM, Endi Sukma Dewata wrote: On 5/19/2011 11:28 AM, Adam Young wrote: On 05/18/2011 10:21 AM, Endi Sukma Dewata wrote: A utility class has been added to store objects which can be accessed both as an ordered list and as a map. This class is used to store various objects

Re: [Freeipa-devel] [PATCH] 159 Fixed problem disabling HBAC and SUDO rules.

2011-05-20 Thread Adam Young
On 05/18/2011 01:51 PM, Endi Sukma Dewata wrote: The method names for disabling HBAC and SUDO rules have been fixed. Ticket #1237. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK. Pu

Re: [Freeipa-devel] [PATCH] 161 Fixed Ajax error handling.

2011-05-20 Thread Adam Young
On 05/20/2011 01:12 PM, Endi Sukma Dewata wrote: The IPA.command has been modified not to insert a title into the error object thrown by Ajax operation because the object could be immutable. Ticket #1240 ___ Freeipa-devel mailing list Freeipa-devel@r

[Freeipa-devel] [PATCH] 0228-create-entities-on-demand

2011-05-23 Thread Adam Young
Patch 227 is the automount patch that I still am not ready to submit. This patch stands alone. From 248323e1ce81b67598067baebc1918c3a15f20e7 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 23 May 2011 10:39:09 -0400 Subject: [PATCH] create entities on demand. --- install/ui/ipa.js

Re: [Freeipa-devel] [PATCH] 0228-create-entities-on-demand

2011-05-23 Thread Adam Young
On 05/23/2011 12:06 PM, Endi Sukma Dewata wrote: On 5/23/2011 9:42 AM, Adam Young wrote: Patch 227 is the automount patch that I still am not ready to submit. This patch stands alone. A few issues in IPA.get_entity(): 1. It executes that.entities.get() twice. The result of the first

Re: [Freeipa-devel] [PATCH] 0228-create-entities-on-demand

2011-05-23 Thread Adam Young
On 05/23/2011 12:38 PM, Adam Young wrote: On 05/23/2011 12:06 PM, Endi Sukma Dewata wrote: On 5/23/2011 9:42 AM, Adam Young wrote: Patch 227 is the automount patch that I still am not ready to submit. This patch stands alone. A few issues in IPA.get_entity(): 1. It executes

Re: [Freeipa-devel] [PATCH] 0228-create-entities-on-demand

2011-05-23 Thread Adam Young
On 05/23/2011 01:13 PM, Adam Young wrote: On 05/23/2011 12:38 PM, Adam Young wrote: On 05/23/2011 12:06 PM, Endi Sukma Dewata wrote: On 5/23/2011 9:42 AM, Adam Young wrote: Patch 227 is the automount patch that I still am not ready to submit. This patch stands alone. A few issues in

Re: [Freeipa-devel] [PATCH] 0228-create-entities-on-demand

2011-05-23 Thread Adam Young
On 05/23/2011 01:31 PM, Adam Young wrote: On 05/23/2011 01:13 PM, Adam Young wrote: On 05/23/2011 12:38 PM, Adam Young wrote: On 05/23/2011 12:06 PM, Endi Sukma Dewata wrote: On 5/23/2011 9:42 AM, Adam Young wrote: Patch 227 is the automount patch that I still am not ready to submit. This

Re: [Freeipa-devel] [PATCH] 163 Fixed adder dialog title.

2011-05-24 Thread Adam Young
On 05/23/2011 05:32 PM, Endi Sukma Dewata wrote: The IPA.entity_builder has been fixed to use the correct title for the entity's adder dialog. Ticket #1239 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinf

Re: [Freeipa-devel] [PATCH] 163 Fixed adder dialog title.

2011-05-24 Thread Adam Young
On 05/24/2011 11:17 AM, Endi Sukma Dewata wrote: On 5/24/2011 9:43 AM, Adam Young wrote: On 05/23/2011 05:32 PM, Endi Sukma Dewata wrote: The IPA.entity_builder has been fixed to use the correct title for the entity's adder dialog. Ticket #1239 Seems like a lot of duplication i

Re: [Freeipa-devel] [PATCH] 164 Fixed Add and Edit without primary key.

2011-05-24 Thread Adam Young
On 05/23/2011 05:41 PM, Endi Sukma Dewata wrote: The IPA.add_dialog has been modified such that if the user clicks the Add and Edit button it will read the primary key returned by the add operation and use it to open the details page. Ticket #1108 __

Re: [Freeipa-devel] [PATCH] 165 Fixed Selenium tests.

2011-05-24 Thread Adam Young
On 05/24/2011 02:11 PM, Endi Sukma Dewata wrote: Fixed some validation and synchronization problems in Selenium tests. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK. Pushed to maste

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-25 Thread Adam Young
On 05/25/2011 12:28 AM, Endi Sukma Dewata wrote: On 5/24/2011 5:32 PM, Adam Young wrote: On 05/24/2011 05:06 PM, Endi Sukma Dewata wrote: On 5/24/2011 1:11 PM, Adam Young wrote: Known issues: the back to list links are broken. Add and delete for keys not working due to API issues discussed

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-25 Thread Adam Young
On 05/25/2011 12:28 AM, Endi Sukma Dewata wrote: 10. The code assumes that the primary keys will be specified as command arguments, which we know doesn't match the API for automount keys. Suppose we decide not to change the API, there should be a way to invoke the current API without

[Freeipa-devel] Summary of Session discussion

2011-05-26 Thread Adam Young
There are four cases where we've discussed using sessions for optimizations. During today's phone discussion we analysed them. 1. Avoiding the negotiate round trip. Requesting a page protected by Kerberos requires two round trips to the server: 1 for the initializ request, which gets deni

Re: [Freeipa-devel] Summary of Session discussion

2011-05-26 Thread Adam Young
On 05/26/2011 02:01 PM, Simo Sorce wrote: On Thu, 2011-05-26 at 12:53 -0400, Adam Young wrote: There are four cases where we've discussed using sessions for optimizations. During today's phone discussion we analysed them. 1. Avoiding the negotiate round trip. Requesting a page pr

Re: [Freeipa-devel] Summary of Session discussion

2011-05-26 Thread Adam Young
On 05/26/2011 02:19 PM, Dmitri Pal wrote: On 05/26/2011 02:01 PM, Simo Sorce wrote: On Thu, 2011-05-26 at 12:53 -0400, Adam Young wrote: There are four cases where we've discussed using sessions for optimizations. During today's phone discussion we analysed them. 1. Avoiding the

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-26 Thread Adam Young
On 05/26/2011 09:30 AM, Endi Sukma Dewata wrote: On 5/25/2011 7:58 PM, Adam Young wrote: 17. The adder dialog boxes for map and key don't have a title. The titles should be defined in internal.py and the ipa_init.json needs to be regenerated. Fixed The ipa_init.json doesn't

Re: [Freeipa-devel] [PATCH] 788 remove automountinformation from automount dns

2011-05-26 Thread Adam Young
On 05/23/2011 02:38 PM, Rob Crittenden wrote: In an attempt to support multiple direct maps we always included the automountinformation in the key dn. This makes showing keys impossible a bit of a catch-22. You want to get the mount info but to get it you need the mount info. This patch drops

Re: [Freeipa-devel] [PATCH] 788 remove automountinformation from automount dns

2011-05-26 Thread Adam Young
On 05/26/2011 05:01 PM, Dmitri Pal wrote: On 05/26/2011 04:51 PM, Adam Young wrote: On 05/23/2011 02:38 PM, Rob Crittenden wrote: In an attempt to support multiple direct maps we always included the automountinformation in the key dn. This makes showing keys impossible a bit of a catch-22

Re: [Freeipa-devel] Summary of Session discussion

2011-05-26 Thread Adam Young
On 05/26/2011 04:56 PM, Dmitri Pal wrote: On 05/26/2011 02:43 PM, Simo Sorce wrote: You can limit it to have one cursor open per session at a time so you can use it as session global. Dangerous. I have seen Adam's response. This functionality is easily extensible. You can start with one and

Re: [Freeipa-devel] Summary of Session discussion

2011-05-26 Thread Adam Young
On 05/26/2011 05:23 PM, Dmitri Pal wrote: On 05/26/2011 05:19 PM, Adam Young wrote: The term "Session global" is a little weird. If you mean that multiple requests in the same session can talk to the same cursor, then yes. Global implies multiple people can talk to it at once, an

Re: [Freeipa-devel] [PATCH] 166 Fixed URL parameter parsing.

2011-05-26 Thread Adam Young
On 05/26/2011 06:24 PM, Endi Sukma Dewata wrote: The $.bbq.getState() invocations have been modified not to coerce URL parameter values to avoid parsing error. Ticket #1208 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.co

Re: [Freeipa-devel] [PATCH] 166 Fixed URL parameter parsing.

2011-05-26 Thread Adam Young
On 05/26/2011 08:30 PM, Adam Young wrote: On 05/26/2011 06:24 PM, Endi Sukma Dewata wrote: The $.bbq.getState() invocations have been modified not to coerce URL parameter values to avoid parsing error. Ticket #1208 ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 166 Fixed URL parameter parsing.

2011-05-26 Thread Adam Young
On 05/26/2011 08:30 PM, Adam Young wrote: On 05/26/2011 06:24 PM, Endi Sukma Dewata wrote: The $.bbq.getState() invocations have been modified not to coerce URL parameter values to avoid parsing error. Ticket #1208 ___ Freeipa-devel mailing list

[Freeipa-devel] See key for indirect map?

2011-05-26 Thread Adam Young
I created an indirect map, but it seems to have no keys associated with it. What am I missing? How do I see the mount point? [root@server15 freeipa]# ipa automountmap-add-indirect BOS auto.media Mount point: /mnt Map: auto.media [root@server15 freeipa]# ipa automountmap-show BOS auto.medi

Re: [Freeipa-devel] [PATCH] 167 Added Update and Reset buttons into Dirty dialog.

2011-05-27 Thread Adam Young
On 05/27/2011 12:43 PM, Endi Sukma Dewata wrote: The Dirty dialogs have been combined into IPA.dirty_dialog. It provides the Update and Reset buttons with customizable callback. Previously the widget's dirty status is computed by comparing the old values with the new values. This method is somet

Re: [Freeipa-devel] [PATCH] 168 Fixed problem deleting value in text field.

2011-05-27 Thread Adam Young
On 05/27/2011 01:44 PM, Endi Sukma Dewata wrote: Previously deleting a value in a text field did not work because the field is not included in the modify operation when the value is empty. The details facet's update() method has been modified to update only dirty fields. The section lists in det

[Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-28 Thread Adam Young
From 6053a8b02a1f868abc6413c60a7f96d9489e9c23 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 27 May 2011 21:37:05 -0400 Subject: [PATCH] automount delete key --- install/ui/automount.js | 19 ++- install/ui/dialog.js| 18 +- install/ui/search.js

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Adam Young
On 05/28/2011 08:54 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel JSL lint cleanup From 7fba335cf391dab621102da43c3a1eae7cfdb74e Mon Sep 17 00:00:00 2001 From

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Adam Young
On 05/31/2011 09:57 AM, Adam Young wrote: On 05/28/2011 08:54 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel JSL lint cleanup

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Adam Young
I thought I had posted my work for indirect maps as a different patch, but it appears not. This patch merged in delete key and indirect maps. On 05/31/2011 10:00 AM, Adam Young wrote: On 05/31/2011 09:57 AM, Adam Young wrote: On 05/28/2011 08:54 PM, Adam Young wrote

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Adam Young
On 05/31/2011 10:00 AM, Adam Young wrote: On 05/31/2011 09:57 AM, Adam Young wrote: On 05/28/2011 08:54 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel JSL lint

Re: [Freeipa-devel] [PATCH] 169 Added pagination for associations.

2011-05-31 Thread Adam Young
On 05/31/2011 05:18 PM, Endi Sukma Dewata wrote: On 5/31/2011 3:38 PM, Endi Sukma Dewata wrote: On 5/31/2011 2:18 PM, Endi Sukma Dewata wrote: The association facet has been modified to support pagination. The UI will show 20 members per page. There are buttons to go to a previous or next page.

[Freeipa-devel] [PATCH] 0230-redirect-on-show-erro

2011-05-31 Thread Adam Young
https://fedorahosted.org/freeipa/ticket/1227 From e0b5c62a22a10629f06484bb2339e927f2e57e6e Mon Sep 17 00:00:00 2001 From: Adam Young Date: Tue, 31 May 2011 17:48:20 -0400 Subject: [PATCH] redirect on show error. --- install/ui/details.js | 17 ++--- 1 files changed, 14 insertions

[Freeipa-devel] [PATCH] 0231-redirect-on-error

2011-06-01 Thread Adam Young
https://fedorahosted.org/freeipa/ticket/1227 From bb079f53efcab3b8216db0e15f9115726afc2b12 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Wed, 1 Jun 2011 09:34:44 -0400 Subject: [PATCH] redirect on error Code for redirecting on error has been moved to IPA.facet so it can be called from both

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-06-01 Thread Adam Young
ap adder dialog could be simplified to "direct" and "indirect". The values used are what is appended to the command's method. Had to leave them as is to keep that working. From f3a313b393a51b2a7e83e35882565ff5601f5ae0 Mon Sep 17 00:00:00 2001 From: Adam Young Date

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-06-01 Thread Adam Young
On 06/01/2011 07:05 PM, Endi Sukma Dewata wrote: On 6/1/2011 10:09 AM, Adam Young wrote: 11. The option values for automount map adder dialog could be simplified to "direct" and "indirect". The values used are what is appended to the command's method. Had to leav

Re: [Freeipa-devel] [PATCH] 0232-scrollable-content-areas.patch

2011-06-02 Thread Adam Young
On 06/02/2011 01:37 PM, Adam Young wrote: On 06/02/2011 12:28 PM, Adam Young wrote: On 06/02/2011 10:22 AM, Adam Young wrote: On 06/02/2011 10:13 AM, Adam Young wrote: On 06/01/2011 10:02 PM, Adam Young wrote: Note that this patch does not yet deal with the add dialog for permissions, or

Re: [Freeipa-devel] [PATCH] 171 Temporary fix for indirect member tabs.

2011-06-02 Thread Adam Young
On 06/02/2011 06:23 PM, Endi Sukma Dewata wrote: Since the group-show command doesn't return indirect members, the tabs for group's indirect members have been reverted to call user-find with the --in-groups parameter to get the entries. However, this is only a temporary solution since the user-f

[Freeipa-devel] [PATCH] 0233-dialog-scrolling-table

2011-06-03 Thread Adam Young
Fixes an artifact created by yesterdays scrolling table patch. From 5c931916c2fbf70b9c4ceb565bb5c56c9fa595ab Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 3 Jun 2011 11:33:32 -0400 Subject: [PATCH] dialog scrolling table TAbles on the dialog page need to have the scrolling set but should

<    1   2   3   4   5   6   7   8   9   10   >