On 2/22/2011 12:22 PM, Adam Young wrote:
ACK and pushed to master.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 2/22/2011 3:48 PM, Adam Young wrote:
ACK and pushed to master.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
The order of the Add and Delete buttons has been reversed to be
consistent with those in other facets.
--
Endi S. Dewata
From 77070192fec42b64697f8456d1303b6bf722d082 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Tue, 22 Feb 2011 17:00:50 -0600
Subject: [PATCH] Fixed
In a details page, usually any changes done to the fields will not be
applied until the user clicks the Update button. However, if the page
contains an association table, any addition/deletion to the table will
be applied immediately.
To avoid any confusion, the user is now required to save or
The correct attribute name for SUDO command group membership is
memberof_sudocmdgroup and it contains the group name instead of dn.
--
Endi S. Dewata
From db1bb27fe8fd3f04ae976e2b0ab6444e033299d5 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Wed, 23 Feb 2011 17:15:42
On 2/23/2011 4:50 PM, Rob Crittenden wrote:
It was a design decision to now allow nesting sudo command groups,
remove it.
ticket 1004
Updated patch attached. This is going to require an API change.
ACK and pushed to master.
--
Endi S. Dewata
___
On 2/28/2011 10:47 AM, Rob Crittenden wrote:
Use Sudo instead of SUDO in labels, descriptions, etc.
ticket 1005
rob
This patch is ACKed. The capitalization is now consistent in the CLI.
However, the UI capitalizes the labels in the action panel and the title
of association facets, so we
On 2/28/2011 12:51 PM, Endi Sukma Dewata wrote:
On 2/28/2011 10:47 AM, Rob Crittenden wrote:
Use Sudo instead of SUDO in labels, descriptions, etc.
ticket 1005
rob
This patch is ACKed. The capitalization is now consistent in the CLI.
However, the UI capitalizes the labels in the action
Association facets based on memberofindirect attribute have been
removed because the attribute is non-assignable.
Ticket 1027
--
Endi S. Dewata
From fc741c0437d0e9358d99a520332f5ead851007e3 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Tue, 1 Mar 2011 12:30:29 -0600
On 3/1/2011 8:30 PM, Adam Young wrote:
On 03/01/2011 09:23 PM, Adam Young wrote:
Not a 100% solution, but keeps the groups-user facet from exploding.
https://fedorahosted.org/freeipa/ticket/1011
Includes fixes for services
Some issues:
1. See these lines in associate.js:
604:
On 3/2/2011 11:52 AM, Adam Young wrote:
ACK.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 3/2/2011 10:56 AM, Adam Young wrote:
This version uses the search widget. A little more intrusive than I
wanted, but if fixes the issue with
https://fedorahosted.org/freeipa/ticket/1011
I tested this with Group's Member User:
The Add button doesn't open a dialog box, but it tries to create
On 3/2/2011 12:48 PM, Adam Young wrote:
No search widget. This will keep the UI from throwing an Error, but
doesn't give a way to get results beyond the first 100
ACK and pushed to master.
--
Endi S. Dewata
___
Freeipa-devel mailing list
On 3/3/2011 10:50 AM, Adam Young wrote:
ACK and pushed to master.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 3/3/2011 11:16 AM, Dmitri Pal wrote:
On 03/03/2011 12:13 PM, Endi Sukma Dewata wrote:
ACK and pushed to master.
Akhm :-)
Sorry, we can fix this again in another patch. So what should be the
correct wording?
While we're at it, is the second sentence grammatically correct?
First
On 3/3/2011 1:16 PM, Adam Young wrote:
Since we are close to GA, I'll submit these for review instead of
pushing under the one line rule.
ACK and pushed both to master.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
The month in krblastpwdchange (LDAP Generalized Time) is 1-based
but the month in JavaScript Date.setUTCFullYear() is 0-based so it
needs a conversion.
Ticket 1053
--
Endi S. Dewata
From 0e6d2b9a2610267f1d2b6ec3c3453f8855b05130 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
These patches fixed most of the problems. There is still a few more.
Ticket 1054
--
Endi S. Dewata
From cedb865ac489015626d3b1bb2653fb94f5b1bb92 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri, 4 Mar 2011 13:58:21 -0600
Subject: [PATCH] Fixed memory leak caused by
Ticket 1054
--
Endi S. Dewata
From 2a36db924f4b8351fd897949adc5dea13bf95e57 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri, 4 Mar 2011 15:12:41 -0600
Subject: [PATCH] Fixed memory leak caused by DNS record deleter dialog.
Ticket 1054
---
install/ui/policy.js | 138
Ticket 1054
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Ticket 1054
--
Endi S. Dewata
From 1405a36a1669f0493b22f7d7de1192896aabba48 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Mon, 7 Mar 2011 12:35:11 -0600
Subject: [PATCH] Fixed memory leak caused by certificate dialogs.
Ticket 1054
---
install/ui/certificate.js | 451
On 3/8/2011 2:47 PM, Adam Young wrote:
On 03/08/2011 02:57 PM, Endi Sukma Dewata wrote:
On 3/8/2011 1:15 PM, Adam Young wrote:
Now manages to pre-populate the pkey for the user.
It pops up 'invalid uid: must be Unicode text'.
The IPA.whoami is an associative array, not a string
Nested role is not supported in 2.0.x, so the association facet
for it should be removed from the UI. The attribute_members in
role.py needs to be fixed because it is used to generate the
association facet automatically.
Ticket 1092.
--
Endi S. Dewata
From
On 3/17/2011 7:04 PM, Adam Young wrote:
Some issues:
1. There's a jslint warning.
2. Try creating a new password policy, then edit and change the
priority. When you click Update the priority will get updated but the
field will become read only.
On 3/18/2011 8:57 AM, Adam Young wrote:
On 03/17/2011 10:01 PM, Endi Sukma Dewata wrote:
On 3/17/2011 7:04 PM, Adam Young wrote:
Some issues:
1. There's a jslint warning.
2. Try creating a new password policy, then edit and change the
priority. When you click Update the priority will get
On 3/31/2011 8:43 AM, Adam Young wrote:
rebased both patches
I don't see any code change in the rebased patches, only new commit
ID's, I hope this is correct.
Some comments (some of which had been discussed over IRC):
1. I ran my Selenium test cases against 215, 216, and 217 together,
On 4/5/2011 3:35 PM, Adam Young wrote:
On 04/04/2011 12:37 PM, Endi Sukma Dewata wrote:
The functional.sh runs all or select functional test suites.
The selenium-results.js parses and displays the test results.
This is awesome. Minor nit, need to create the results directory.
Thanks. Fixed
On 4/5/2011 5:03 PM, Rob Crittenden wrote:
postalCode should be a string not an integer.
postalCode is defined as an Int. This means you can't define one that
has a leading zero nor can you have dashes, letters, etc.
This changes the data type on the server. It will still accept an int
value
To improve code readability and extensibility the containers for action
panel and client area are now created in IPA.entity.setup(). The 'client
area' has been renamed into 'content'. The IPA.facet.create() has been
renamed to IPA.facet.create_content().
--
Endi S. Dewata
From
The IPA.entity_builder has been modified to take a 'factory' parameter
in custom facet's and custom dialog's spec. The IPA.dialog has been
modified to take an array of fields in the spec. The IPA.search_facet
has been modified to take an array of columns in the spec.
--
Endi S. Dewata
From
To simplify customization, the add(), remove(), and refresh() methods
have been moved from IPA.search_widget into IPA.search_facet.
--
Endi S. Dewata
From b42223b994364d098e21f960cc37490bc95af0d1 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri, 8 Apr 2011 00:14:16
Initial implementation of Entitlements.
--
Endi S. Dewata
From a408bfe3e443341fc639b0d29e4918899dee705a Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri, 8 Apr 2011 01:16:07 -0400
Subject: [PATCH] Entitlements.
Initial implementation of Entitlements.
---
On 4/9/2011 9:05 PM, Adam Young wrote:
On 04/08/2011 03:14 PM, Endi Sukma Dewata wrote:
Initial implementation of Entitlements.
Needs to be added to makefile.am and jsl.conf
Fixed in the new patch.
--
Endi S. Dewata
From b8186363753d5764937f88e2e92ce6b0becd1752 Mon Sep 17 00:00:00 2001
On 4/11/2011 10:03 AM, Adam Young wrote:
On 04/08/2011 03:12 PM, Endi Sukma Dewata wrote:
To improve code readability and extensibility the containers for action
panel and client area are now created in IPA.entity.setup(). The
'client area' has been renamed into 'content'. The IPA.facet.create
On 4/11/2011 10:05 AM, Adam Young wrote:
On 04/08/2011 03:13 PM, Endi Sukma Dewata wrote:
The IPA.entity_builder has been modified to take a 'factory' parameter
in custom facet's and custom dialog's spec. The IPA.dialog has been
modified to take an array of fields in the spec
On 4/11/2011 10:23 AM, Adam Young wrote:
On 04/08/2011 03:14 PM, Endi Sukma Dewata wrote:
To simplify customization, the add(), remove(), and refresh() methods
have been moved from IPA.search_widget into IPA.search_facet.
ACK. Follow on work required to make add and delte avaialbel from
On 4/11/2011 10:23 AM, Endi Sukma Dewata wrote:
On 4/9/2011 9:05 PM, Adam Young wrote:
On 04/08/2011 03:14 PM, Endi Sukma Dewata wrote:
Initial implementation of Entitlements.
Needs to be added to makefile.am and jsl.conf
Fixed in the new patch.
ACKed on IRC and pushed to master
On 4/8/2011 2:15 PM, Endi Sukma Dewata wrote:
The Selenium tests have been updated to improve robustness.
ACKed on IRC and pushed to master. This still requires further improvements.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel
The IPA.cmd() has been merged into IPA.command(). All invocations
and test cases have been converted.
Ticket #988
Passed JSLint, QUnit and Selenium tests.
--
Endi S. Dewata
From ca75672586456842115c4c0faf7f63374f0e5b67 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Tue,
The entitlement facet will show the appropriate buttons depending on
the entitlement status. If it's not registered, the facet will show
a Register button. If it's registered, the facet will show a Consume
button.
--
Endi S. Dewata
From 16ce91b4c55ec8ca00421a818532a8ff8560ed6f Mon Sep 17
On 4/13/2011 9:12 AM, Adam Young wrote:
Please make sure all String literals come from the interal.py messages
plugin. New button labels are defined in entitle.js for Consume and
Register.
I'm thinking to do that once we have all the entitlement functionalities
implemented. There are also
On 4/13/2011 10:13 AM, Adam Young wrote:
There's no pattern defined in the metadata for the quantity. There is
an 'int' type though. I think we can add a general purpose type
checking in addition to pattern validation. This can be done in a
separate patch.
We can add a validation rule
On 4/13/2011 10:33 PM, Adam Young wrote:
BTW, are you planning on updating this patch, or do the validation work
in a follow on patch?
Attached is an updated version. There are a few more patches in the
pipeline. After that I'll address the I18n labels, integer validation
and builder
The entitlement facet will invoke entitle_status to check the
entitlement status and show the appropriate buttons. If it's
unregistered it will show Register and Import button. If it's registered
it will show the Consume button only. If it's imported it will show the
Import button only. The
On 4/14/2011 12:17 AM, Endi Sukma Dewata wrote:
Attached is an updated version. There are a few more patches in the
pipeline. After that I'll address the I18n labels, integer validation
and builder cleanup.
ACKed on IRC. Replaced integer constants with string. Pushed to master.
--
Endi S
On 4/14/2011 4:13 PM, Adam Young wrote:
The entitlement facet will invoke entitle_status to check the
entitlement status and show the appropriate buttons. If it's
unregistered it will show Register and Import button. If it's
registered it will show the Consume button only. If it's imported it
The adder dialog box definition has been moved from search facet
into entity to make it available to other facets.
--
Endi S. Dewata
From 5e5bbe7b4607d8f3900e76363fe5cac15e0b0d97 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Mon, 18 Apr 2011 10:59:50 -0500
Subject:
On 4/18/2011 6:06 PM, Adam Young wrote:
The adder dialog box definition has been moved from search facet
into entity to make it available to other facets.
Shouldn't it move into add.js, or should add.js go away?
This patch only modifies the entity builder interface which is stored in
Action panel buttons are now created in facet's create_action_panel().
This is to allow a subclass to override and customize the buttons.
--
Endi S. Dewata
From b3befcf304680388b8de9eaec6abcebbf6426c5b Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Tue, 19 Apr 2011
On 4/19/2011 3:07 PM, Adam Young wrote:
going to post this, but with a request to hold on pushing to the repo. I
have not yet tested against selenium, and suspect that it will break all
selenium test navigation.
I've tested this patch with static data. There are some issues:
1. Incorrect data
The entity builder registration have been moved into webui.js. This
allows the WebUI to control which entities will be loaded. For instance,
the entitlement should be loaded only if the plugin is enabled. This
is done by checking the metadata.
--
Endi S. Dewata
From
On 4/20/2011 11:50 AM, Adam Young wrote:
Leave the factories as the top level object. For the factory name, say
'entitle' check that the object is in the metadata. If not, don't create
the entity. Then, when processing the tabs, if the entity does not
exist, drop the tab from the tab set. The
On 4/20/2011 4:32 PM, Endi Sukma Dewata wrote:
On 4/20/2011 11:50 AM, Adam Young wrote:
Leave the factories as the top level object. For the factory name, say
'entitle' check that the object is in the metadata. If not, don't
create
the entity. Then, when processing the tabs, if the entity does
On 3/29/2011 6:31 AM, Martin Kosek wrote:
UI trims whitespace at the beginning or at the end when user data
are being saved. This confuses is_dirty function which incorrectly
recognizes given field as modified.
This patch fixes this issue for both general text fields and
ACI filter field.
On 4/1/2011 10:12 AM, Martin Kosek wrote:
When adding a new DNS zone in the WebUI, IPA server will verify
whether the nameserver is in DNS. Sometimes it is necessary to
skip the verification.
This patch adds a --force option already available in CLI which
can skip this the verification.
On 4/21/2011 1:59 PM, Adam Young wrote:
On 04/19/2011 11:19 AM, Endi Sukma Dewata wrote:
On 4/18/2011 6:06 PM, Adam Young wrote:
The adder dialog box definition has been moved from search facet
into entity to make it available to other facets.
Shouldn't it move into add.js, or should add.js
On 4/21/2011 2:01 PM, Adam Young wrote:
On 04/19/2011 02:07 PM, Endi Sukma Dewata wrote:
Action panel buttons are now created in facet's create_action_panel().
This is to allow a subclass to override and customize the buttons.
ACK
I'll have to re-do these changes in my next verison of 0221
There are still some issues. Some of them have been discussed over IRC:
On 4/25/2011 3:24 PM, Adam Young wrote:
11. Navigation error.
Open User Groups tab, click one of the groups. Under Member Users,
click one of the users. It will show an error dialog box (it has
some typos too).
Still a
On 4/26/2011 12:42 PM, Adam Young wrote:
20. The facet groups needs to be customizable. Currently it's stored
in unordered set in entity's facet_group and the order is hard-
coded in get_facet() and facet_tabs(). It would be difficult
to workaround this limitations in custom facets.
See how
The widget base class has been modified to validate integer value
if the type is specified in the metadata. This is used to validate
entitlement quantity.
--
Endi S. Dewata
From 0ff8501614b78f5ccff3908f459fdbc5e58e8241 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Tue,
On 4/26/2011 8:23 PM, Adam Young wrote:
The widget base class has been modified to validate integer value
if the type is specified in the metadata. This is used to validate
entitlement quantity.
Logic looks good. I'd like to make the validator an external object, and
have the builder select
On 4/26/2011 7:33 PM, Adam Young wrote:
ACK and pushed to master.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 4/27/2011 10:43 AM, Adam Young wrote:
The widget base class has been modified to validate integer value
if the type is specified in the metadata. This is used to validate
entitlement quantity.
Logic looks good. I'd like to make the validator an external object, and
have the builder select
On 4/27/2011 12:56 PM, Adam Young wrote:
Currently we have this DOM structure:
div id='user' class='entity-container'
div class='entity-header'
div class='entity-title'/
span class='action-controls'/
div class='entity-title'/
input id='pkey' type='hidden'/
span
On 4/27/2011 8:09 PM, Adam Young wrote:
div name='user' class='entity'
div class='entity-header'
div class='entity-title'/
div class='entity-controls'/
div class='entity-search'/
div class='entity-tabs'/
/div
div class='entity-content'
div name='search' class='facet'
div class='facet-header'/
On 4/27/2011 9:39 PM, Endi Sukma Dewata wrote:
On 4/27/2011 8:47 PM, Adam Young wrote:
The more I think about it, the more I think that this structure can be
created by the navigation code, and then passed to the entity to
populate. The entity-header function moves to navigation.js, but does
The singular object IPA.nav has been converted into an IPA.navigation
class. The admin and self-service navigation tabs have been converted
into subclasses of IPA.navigation and will be instantiated according
to user authorization.
--
Endi S. Dewata
From 2b97f55bb13fbf82b1343e2434f95c989204e680
Previously the tab state is represented using numeric index such
as navigation=0identity=1 which is not very user friendly. Now the
code has been modified to use entity names such as
navigation=identityidentity=group.
--
Endi S. Dewata
From a5a69fd56c0a42a0f9d715e6636171562a6d4729 Mon Sep 17
Previously the entities and navigation are entangled inside a common
DOM structure which limits code reuse. Now they have been moved
into separate structures.
--
Endi S. Dewata
From 278ffcc104840841278bfb028dd5ac1550fac9cb Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date:
On 5/5/2011 11:16 AM, Adam Young wrote:
On 05/04/2011 04:38 PM, Endi Sukma Dewata wrote:
The singular object IPA.nav has been converted into an IPA.navigation
class. The admin and self-service navigation tabs have been converted
into subclasses of IPA.navigation and will be instantiated
On 5/5/2011 11:17 AM, Adam Young wrote:
On 05/04/2011 04:39 PM, Endi Sukma Dewata wrote:
Previously the tab state is represented using numeric index such
as navigation=0identity=1 which is not very user friendly. Now the
code has been modified to use entity names such as
navigation
On 5/5/2011 11:19 AM, Adam Young wrote:
On 05/04/2011 04:41 PM, Endi Sukma Dewata wrote:
Previously the entities and navigation are entangled inside a common
DOM structure which limits code reuse. Now they have been moved
into separate structures.
ACK
Pushed to master.
--
Endi S. Dewata
On 5/5/2011 12:58 PM, Adam Young wrote:
On 05/04/2011 04:46 PM, Endi Sukma Dewata wrote:
Facet container has been added to hold facet header (i.e. title,
search fields, buttons, links) and facet content. Each facet now
occupies separate container, so it can be shown/hidden without
having
The Identity tab for self-service UI was missing a label and there
was a bug in navigation.js that was exposed because of that.
--
Endi S. Dewata
From e39a173828449aa0f73cddd49e8d3f4d6c26415d Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri, 6 May 2011 15:32:51 -0400
The IPA.records_facet has been converted into a subclass of
IPA.search_facet. This helps remove duplicate table code and provide
consistent DOM element attributes for Selenium tests.
--
Endi S. Dewata
From 0982fd17fa0f5052c3249f5fd0f464dc19bafc5f Mon Sep 17 00:00:00 2001
From: Endi S. Dewata
Added Selenium tests for DNS.
--
Endi S. Dewata
From e8956af80c0382a833f96f9d53aab3f1ec575b51 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Mon, 9 May 2011 19:22:51 -0400
Subject: [PATCH] Added Selenium tests for DNS.
---
install/ui/test/functional/dnsrecord-add.html
The dialog box for entitlement registration has been modified to
accept an optional enrollment UUID.
--
Endi S. Dewata
From f47afac3019ab3f6e6f5145e2274e14103ea7ce4 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Tue, 10 May 2011 16:38:10 -0500
Subject: [PATCH] Added UUID
Added Self-Service and Delegation tests.
--
Endi S. Dewata
From c775fd1e0b81e7a49a650aa93eafd7eb39989a26 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Tue, 10 May 2011 20:48:16 -0400
Subject: [PATCH] Added Self-Service and Delegation tests.
---
On 4/1/2011 10:58 AM, Adam Young wrote:
ACK. This can be pushed after removing the -x from the script header.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 5/16/2011 11:23 AM, Endi Sukma Dewata wrote:
The IPA.entity has been modified to support customizable facet groups.
The default list of facet groups is defined in IPA.entity_header and can
be overridden in the entity definition.
The patch has been fixed to handle missing relationships
The IPA.association_facet has been modified to take a read_only
parameters. If the parameter is set to true, the Enroll and Delete
buttons will not be shown. All facets under the memberindirect and
memberofindirect facet groups are marked as read-only.
Ticket #1030
--
Endi S. Dewata
From
The method names for disabling HBAC and SUDO rules have been fixed.
Ticket #1237.
--
Endi S. Dewata
From e469d9f4e71ba6d78821afd28983dbf364c6baea Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Wed, 18 May 2011 12:38:18 -0500
Subject: [PATCH] Fixed problem disabling HBAC
The IPA.command has been modified not to insert a title into the error
object thrown by Ajax operation because the object could be immutable.
Ticket #1240
--
Endi S. Dewata
From 316c242aef50468002fce0659d2bae584ba12519 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri,
On 5/20/2011 11:10 AM, Adam Young wrote:
Works well on a liver server, but didn't work with my static checkout.
The filter wouldn't work with static checkout because it expects the
server to return filtered data, but you should still be able to view the
contents for different entities.
On 5/23/2011 9:42 AM, Adam Young wrote:
Patch 227 is the automount patch that I still am not ready to submit.
This patch stands alone.
A few issues in IPA.get_entity():
1. It executes that.entities.get() twice. The result of the first
invocation can be stored in a variable and reused
Pushed under one-liner rule.
--
Endi S. Dewata
From 57e9da2a638a7b9ea7fd6396da681085388afb71 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Mon, 23 May 2011 14:48:31 -0500
Subject: [PATCH] Fixed details tests.
---
install/ui/test/details_tests.js |2 +-
1 files
The IPA.entity_builder has been fixed to use the correct title
for the entity's adder dialog.
Ticket #1239
--
Endi S. Dewata
From b28c0b343175981f259d24b71efa1a8d62669797 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri, 20 May 2011 23:29:38 -0500
Subject: [PATCH]
The IPA.add_dialog has been modified such that if the user clicks the
Add and Edit button it will read the primary key returned by the add
operation and use it to open the details page.
Ticket #1108
--
Endi S. Dewata
From f426b0502f27a2d149a1e2d51ec887aefaffd6bf Mon Sep 17 00:00:00 2001
From:
On 5/24/2011 9:43 AM, Adam Young wrote:
On 05/23/2011 05:32 PM, Endi Sukma Dewata wrote:
The IPA.entity_builder has been fixed to use the correct title
for the entity's adder dialog.
Ticket #1239
Seems like a lot of duplication in the messages. Shouldn't it be more
along the lines
Fixed some validation and synchronization problems in Selenium tests.
--
Endi S. Dewata
From a944a440bc42948a2037675118eff20d0c480c7f Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Tue, 24 May 2011 01:17:37 -0400
Subject: [PATCH] Fixed Selenium tests.
Fixed some
On 5/24/2011 1:11 PM, Adam Young wrote:
Known issues: the back to list links are broken. Add and delete for keys
not working due to API issues discussed elsewhere.
Some issues:
1. The 3rd level tabs (Location, Maps, Keys) can be removed because
there's already a breadcrumb which provides
On 5/24/2011 5:32 PM, Adam Young wrote:
On 05/24/2011 05:06 PM, Endi Sukma Dewata wrote:
On 5/24/2011 1:11 PM, Adam Young wrote:
Known issues: the back to list links are broken. Add and delete for keys
not working due to API issues discussed elsewhere.
1. The 3rd level tabs (Location, Maps
On 5/25/2011 11:31 AM, Adam Young wrote:
8. The column in the maps search facet doesn't have a title.
Done. This actually was an indication of a deeper problem, that the
columns were pointing to the wrong entity for param info.
This is because the nested_search_facet is defined in the
A few more minor problems:
On 5/25/2011 2:54 PM, Adam Young wrote:
12. The automount map has a description field which can be specified
during add modify. The UI doesn't have this.
Fixed
It's still missing from the map's adder dialog box.
17. The adder dialog boxes for map and key don't
On 5/25/2011 7:58 PM, Adam Young wrote:
17. The adder dialog boxes for map and key don't have a title. The
titles should be defined in internal.py and the ipa_init.json needs
to be regenerated.
Fixed
The ipa_init.json doesn't seem to be updated yet.
More changes in this patch. I combined
The $.bbq.getState() invocations have been modified not to coerce
URL parameter values to avoid parsing error.
Ticket #1208
--
Endi S. Dewata
From 0543036b5d59cb8769ee1857737fddf582613a13 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Mon, 23 May 2011 17:48:37 -0500
The Dirty dialogs have been combined into IPA.dirty_dialog. It
provides the Update and Reset buttons with customizable callback.
Previously the widget's dirty status is computed by comparing the
old values with the new values. This method is sometimes inaccurate,
so the is_dirty() method has
Previously deleting a value in a text field did not work because
the field is not included in the modify operation when the value
is empty. The details facet's update() method has been modified
to update only dirty fields.
The section lists in details facet and dialog have been converted
into
On 5/31/2011 11:59 AM, Adam Young wrote:
Some issues:
1. The labels for mount and parentmap fields in automount map are
missing.
2. The mount and parentmap fields in automount map adder dialog shows
undo button. This can be fixed by adding undo: false parameter.
3. The Delete button
The association facet has been modified to support pagination. The
UI will show 20 members per page. There are buttons to go to a
previous or next page. There is also an input text to jump directly
to a certain page.
Ticket #1011
--
Endi S. Dewata
From fb05d4c5f5bfbf082da8a104aa93bdbe08368577
201 - 300 of 972 matches
Mail list logo
