Re: [Freeipa-devel] [TEST][Patch-0027] Fixed test failure during in-tree session, ticket N 5736

On 16.03.2016 14:59, Oleg Fayans wrote: Hi Martin On 03/16/2016 02:39 PM, Martin Basti wrote: On 16.03.2016 10:59, Oleg Fayans wrote: With this patch applied integration tests pass and in-tree tests are gracefully skipped. @mkubik, It is not possible to put the decorator to util.py as per

[Freeipa-devel] [PATCH 0441] Configure httpd service from installer

https://fedorahosted.org/freeipa/ticket/5681 Patch attached. From 9cce757cbdb19e71d314339cd2b822792dde3210 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 16 Mar 2016 09:04:42 +0100 Subject: [PATCH] Configure httpd service from installer instead of directly fr

Re: [Freeipa-devel] [TEST][Patch-0027] Fixed test failure during in-tree session, ticket N 5736

On 16.03.2016 10:59, Oleg Fayans wrote: With this patch applied integration tests pass and in-tree tests are gracefully skipped. @mkubik, It is not possible to put the decorator to util.py as per our discussion, because it uses tasks, so tasks must be imported. But tasks already import util,

Re: [Freeipa-devel] [TEST][Patch-0027] Fixed test failure during in-tree session, ticket N 5736

On 16.03.2016 15:13, Martin Basti wrote: On 16.03.2016 14:59, Oleg Fayans wrote: Hi Martin On 03/16/2016 02:39 PM, Martin Basti wrote: On 16.03.2016 10:59, Oleg Fayans wrote: With this patch applied integration tests pass and in-tree tests are gracefully skipped. @mkubik

Re: [Freeipa-devel] [PATCH 0440] Fix broken trust warnings

On 15.03.2016 16:40, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5737 Patch attached. Sekf NACK, fix should be just oneliner, I found out that domain are stored hierarchically so extra finding of parents zone is needed. -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 550] certdb: never use the -r option of certutil

On 15.03.2016 07:26, David Kupka wrote: On 14/03/16 09:29, Jan Cholasta wrote: Hi, the attached patch fixes and . Honza Hi, thanks for the patch. I haven't found any distortion of affected use

Re: [Freeipa-devel] [PATCH 0432] use platform path for SSSD log directory

On 15.03.2016 07:43, David Kupka wrote: On 08/03/16 16:29, Martin Basti wrote: /var/log/SSSD is platform specific, thus should be added to ipaplatform module Patch attached. Works for me, ACK. Pushed to master: fb3a5d5a9cad4355c3d7db5a789d1f6342cccaa0 -- Manage your subscription

Re: [Freeipa-devel] [PATCH 0437] dogtag: remove redundant parameters from CS.cfg

On 10.03.2016 08:08, Jan Cholasta wrote: On 10.3.2016 07:57, Fraser Tweedale wrote: On Thu, Mar 10, 2016 at 07:15:59AM +0100, Jan Cholasta wrote: On 10.3.2016 03:35, Fraser Tweedale wrote: On Wed, Mar 09, 2016 at 01:30:01PM +0100, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCH 0432] stageuser-activate: noralize manager value

On 15.03.2016 10:46, David Kupka wrote: On 08/03/16 12:02, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5481 Patch attached. Works for me, ACK. Pushed to master: 4871cb5b549042f383ee883e527e773c0abe9d87 Pushed to ipa-4-3: 03743ba1d9191bf0d786116808dba4d7a3522b1f

[Freeipa-devel] [PATCH 0440] Fix broken trust warnings

https://fedorahosted.org/freeipa/ticket/5737 Patch attached. From 952a43a2ef272a61916125040852bc6f5b5de079 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Tue, 15 Mar 2016 16:18:57 +0100 Subject: [PATCH] Fix broken trust warnings Warning should be shown only for

[Freeipa-devel] [PATCH 0439] Do not do extra search for ipasshpubkey

https://fedorahosted.org/freeipa/ticket/3376 Patch attached. From 04429fc3a1f136b4391efa5822fef7f6b52364c9 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Mon, 14 Mar 2016 17:42:56 +0100 Subject: [PATCH] Do not do extra search for ipasshpubkey to generate finger

Re: [Freeipa-devel] [PATCH 0141] ipa-replica-manage: print traceback on unexpected error when in verbose mode

On 10.03.2016 15:59, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5380 NACK 1) Maybe we should print traceback in verbose mode for RuntimeError as well. 2) IMO would be better to print traceback first and then, print error Martin^2 -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH 0095-0098] NTP: use augeas, configure chronyd, do not overwrite config

On 14.03.2016 13:46, Martin Babinsky wrote: On 03/11/2016 09:16 AM, David Kupka wrote: Current version (0.5.0) of python-augeas is missing copy() method. Use dkupka/python-augeas copr repo before new version it's build and available in the official repos. Hi David, TLDR: NACK :D. Here

Re: [Freeipa-devel] [PATCH 0138] only search for Kerberos SRV records when autodiscovery was requested

On 07.03.2016 18:02, Martin Babinsky wrote: A quick fix for https://fedorahosted.org/freeipa/ticket/4305 I'm aware that we were talking about putting realmd discovery into IPADiscovery class and stuff, but that is a bit beyond the scope of this ticket. I will open ticket(s) tracking: 1.)

Re: [Freeipa-devel] [PATCH 0024] ipa-replica-manage: added --suffix option for certain commands

On 14.03.2016 12:05, Jan Cholasta wrote: Hi, On 11.3.2016 10:39, Stanislav Laznicka wrote: Hi, Please see the patch attached. Contrary to the discussion at https://fedorahosted.org/freeipa/ticket/4987 I also added the suffix option for clean_ruv command. If this command is available for

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 10.03.2016 23:09, Oleg Fayans wrote: Hi Martin, On 03/08/2016 08:18 PM, Martin Basti wrote: On 08.03.2016 18:24, Martin Basti wrote: On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: * old

Re: [Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views

On 11.03.2016 10:12, Pavel Vomacka wrote: On 03/08/2016 02:34 PM, Lenka Doudova wrote: On 03/08/2016 12:43 PM, Pavel Vomacka wrote: On 02/23/2016 03:20 PM, Lenka Doudova wrote: Hi, attached is patch providing missing test coverage for ID views in webUI. Lenka Hi, Thank you for

Re: [Freeipa-devel] [PATCH] 0193 fix Coverity issue in extdom plugin

On 20.07.2015 15:34, Christian Heimes wrote: On 2015-07-20 15:23, Alexander Bokovoy wrote: Hi, this patch fixes Coverity CID 13130. The bug turned out to be impossible to cause crash in 389-ds externally because all conditions that could cause not to properly allocate req could not be

[Freeipa-devel] [PATCH 0435] client: enable ChallengeResponseAuthentication in sshd_config

https://fedorahosted.org/freeipa/ticket/5703 Patch attached. From 647a8b1ae11e6bd65cdaf2be2062d10d0e0b92cc Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Thu, 10 Mar 2016 19:01:33 +0100 Subject: [PATCH] client: enable ChallengeResponseAuthentication in sshd_

Re: [Freeipa-devel] [PATCH 0067-0069] Various IPA log fixes

On 10.03.2016 15:44, Rob Crittenden wrote: Gabe Alford wrote: Hello, Attached patches fix the following tickets related to IPA log files: https://fedorahosted.org/freeipa/ticket/5724 https://fedorahosted.org/freeipa/ticket/5726 https://fedorahosted.org/freeipa/ticket/5727 Patch 0067 should

Re: [Freeipa-devel] [PATCH 0436] krb5.conf: use 'true' instead of 'yes'

On 09.03.2016 13:33, Martin Babinsky wrote: On 03/08/2016 08:34 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5518 Patch attached. ACK Pushed to: ipa-4-3: d5ff7bf76adcf6229bb1884c73c4aefac4e9eb25 master: e0b9afded5baab4e6e0cca5dda5554924a59317a -- Manage your

Re: [Freeipa-devel] [PATCH] SPEC: Remove unused build dependency on libwbclient

On 09.03.2016 11:57, Sumit Bose wrote: On Wed, Mar 09, 2016 at 09:59:06AM +0100, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS >From 3fe91e54c11245c3a773bc2cff5504b7a5f6ad16 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 9 Mar 2016 09:53:07 +0100

Re: [Freeipa-devel] [PATCH 560] Allow to set allowed krb authz data type per user

On 09.03.2016 13:44, Martin Basti wrote: On 09.03.2016 13:40, Alexander Bokovoy wrote: On Wed, 09 Mar 2016, Martin Basti wrote: On 09.03.2016 13:19, Alexander Bokovoy wrote: On Wed, 09 Dec 2015, Simo Sorce wrote: From f21c88b9f74453c6d6e16fb17d94efa469eed564 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

On 09.03.2016 18:16, Alexander Bokovoy wrote: On Wed, 09 Mar 2016, Lukas Slebodnik wrote: On (09/03/16 13:33), Alexander Bokovoy wrote: On Wed, 09 Mar 2016, Lukas Slebodnik wrote: On (03/02/16 14:30), Lukas Slebodnik wrote: On (29/01/16 19:59), Alexander Bokovoy wrote: On Fri, 29 Jan

Re: [Freeipa-devel] [WIP] Time-Based HBAC Policies

On 04.03.2016 14:53, Stanislav Laznicka wrote: Hello, So in the previous month and a bit I was reworking the time-based policies according to the changes we agreed on (http://pad.engineering.redhat.com/ipa-time-based-HBAC-design, line 83). Let me briefly walk you through what was done (no

Re: [Freeipa-devel] [PATCH 560] Allow to set allowed krb authz data type per user

On 09.03.2016 13:40, Alexander Bokovoy wrote: On Wed, 09 Mar 2016, Martin Basti wrote: On 09.03.2016 13:19, Alexander Bokovoy wrote: On Wed, 09 Dec 2015, Simo Sorce wrote: From f21c88b9f74453c6d6e16fb17d94efa469eed564 Mon Sep 17 00:00:00 2001 From: Simo Sorce <s...@redhat.com> Dat

Re: [Freeipa-devel] [PATCH 560] Allow to set allowed krb authz data type per user

On 09.03.2016 13:19, Alexander Bokovoy wrote: On Wed, 09 Dec 2015, Simo Sorce wrote: From f21c88b9f74453c6d6e16fb17d94efa469eed564 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Tue, 24 Nov 2015 18:01:52 -0500 Subject: [PATCH] Allow to specify Kerberos authz data type per

[Freeipa-devel] [PATCH 0437] dogtag: remove redundant parameters from CS.cfg

https://fedorahosted.org/freeipa/ticket/5298 Patch attached. From 4e36c933932e36fd86a87ab51a2ffe61880cb25b Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Tue, 8 Mar 2016 19:12:00 +0100 Subject: [PATCH] Remove redundant parameters from CS.cfg in dogtaginstance B

Re: [Freeipa-devel] [PATCH 0329] Tests: fix user tracker

On 09.03.2016 13:13, Martin Basti wrote: On 26.10.2015 18:05, Martin Basti wrote: On 26.10.2015 09:01, Lenka Doudova wrote: On 10/21/2015 06:53 AM, Lenka Doudova wrote: On 10/20/2015 06:21 PM, Martin Basti wrote: On 20.10.2015 15:53, Martin Basti wrote: On 19.10.2015 14:16

Re: [Freeipa-devel] [PATCH 0329] Tests: fix user tracker

On 26.10.2015 18:05, Martin Basti wrote: On 26.10.2015 09:01, Lenka Doudova wrote: On 10/21/2015 06:53 AM, Lenka Doudova wrote: On 10/20/2015 06:21 PM, Martin Basti wrote: On 20.10.2015 15:53, Martin Basti wrote: On 19.10.2015 14:16, Martin Basti wrote: On 19.10.2015 12:30

Re: [Freeipa-devel] [PATCH 560] Allow to set allowed krb authz data type per user

bump for review On 09.12.2015 21:00, Simo Sorce wrote: Sent the wrong patch, attached the one that actually compiles. - Original Message - From: "Simo Sorce" To: "Alexander Bokovoy" Cc: "Simo Sorce" , "Jan Cholasta"

Re: [Freeipa-devel] [PATCH 431] Configure 389ds with default cipher suite

On 09.03.2016 10:04, Fraser Tweedale wrote: On Wed, Mar 09, 2016 at 09:53:35AM +0100, Martin Basti wrote: On 09.03.2016 04:47, Fraser Tweedale wrote: On Tue, Mar 08, 2016 at 11:43:49AM +0100, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5684 patch attached I think

Re: [Freeipa-devel] [PATCH 431] Configure 389ds with default cipher suite

On 09.03.2016 04:47, Fraser Tweedale wrote: On Tue, Mar 08, 2016 at 11:43:49AM +0100, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5684 patch attached I think the comment in install/updates/20-sslciphers.update should be updated. Apart from that, ACK. Cheers, Fraser Thanks

[Freeipa-devel] [PATCH 0436] krb5.conf: use 'true' instead of 'yes'

https://fedorahosted.org/freeipa/ticket/5518 Patch attached. From d8bdb84de46923182b9d5b67e8ee6eba80aab396 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Tue, 8 Mar 2016 18:29:47 +0100 Subject: [PATCH] krb5conf: use 'true' instead of 'yes' for forwardable option

Re: [Freeipa-devel] [PATCH 0140] test_cert_plugin: use only first part of the hostname to construct short name

On 08.03.2016 20:24, Martin Basti wrote: On 08.03.2016 17:08, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5688 Pushed to: master: abe3abb46699428038cd77f13b814de69fd7d0a2 ipa-4-3: bbad720138575f7655154dd3ed52c590970d9961 ACK :-) -- Manage your subscription

Re: [Freeipa-devel] [PATCH 0140] test_cert_plugin: use only first part of the hostname to construct short name

On 08.03.2016 17:08, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5688 Pushed to: master: abe3abb46699428038cd77f13b814de69fd7d0a2 ipa-4-3: bbad720138575f7655154dd3ed52c590970d9961 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 08.03.2016 18:24, Martin Basti wrote: On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: * old messages have been removed * 1) this method is unused please remove it def test_kra_install_master

Re: [Freeipa-devel] [PATCH] CONFIGURE: Replace obsolete macros

On 02.02.2016 09:36, Lukas Slebodnik wrote: ehlo, The AC_PROG_LIBTOOL macro is obsoleted by since libtool-2.0 which is already in rhel6+ https://fedorahosted.org/FedoraReview/wiki/AutoTools simple patch is attached LS ACK Pushed to master: ebbb2eba5bdf3eee9eca3e3db2b8964db5d8131f

Re: [Freeipa-devel] [PATCH 0434] log: add timestamp to filename of logs

On 08.03.2016 16:37, Martin Basti wrote: On 08.03.2016 16:31, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4501 Patch attached. Rebased patch attached. self-NACK Scripts print to CLI unformatted strings, it should not be so easy. See /var/log/ipaupgrade-{timestamp

Re: [Freeipa-devel] [PATCH 558] Allow disabling requireing preauth by default for Service Principal Names

On 08.03.2016 18:02, Martin Babinsky wrote: On 03/08/2016 05:50 PM, Simo Sorce wrote: On Tue, 2016-03-08 at 17:20 +0100, Martin Babinsky wrote: On 03/08/2016 05:00 PM, Simo Sorce wrote: On Tue, 2016-03-08 at 16:51 +0100, Martin Babinsky wrote: On 03/08/2016 04:49 PM, Simo Sorce wrote: On

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: * old messages have been removed * 1) this method is unused please remove it def test_kra_install_master(self): Well, in fact it is used twice

Re: [Freeipa-devel] [PATCH 0434] log: add timestamp to filename of logs

On 08.03.2016 16:31, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4501 Patch attached. Rebased patch attached. From 6539b6e438a391c24ed5b4f920ff825973537b0f Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Fri, 4 Mar 2016 16:57:20 +0100 Subject:

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 08.03.2016 10:52, Milan Kubík wrote: On 02/22/2016 11:09 AM, Filip Skola wrote: - Original Message - On 02/10/2016 09:17 AM, Milan Kubík wrote: On 02/09/2016 04:19 PM, Milan Kubík wrote: On 01/28/2016 10:42 AM, Filip Skola wrote: - Original Message - On 01/25/2016

[Freeipa-devel] [PATCH 0434] log: add timestamp to filename of logs

https://fedorahosted.org/freeipa/ticket/4501 Patch attached. From ca3a3bd01e6990a42e2d7c809b1f698da53b04a4 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Fri, 4 Mar 2016 16:57:20 +0100 Subject: [PATCH] logging: add timestamps to log filenames Originally installatio

[Freeipa-devel] [PATCH 0432] use platform path for SSSD log directory

/var/log/SSSD is platform specific, thus should be added to ipaplatform module Patch attached. From 5873f755428903b9300f260221b5417a3697f279 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Tue, 8 Mar 2016 16:26:23 +0100 Subject: [PATCH] Use platform path constant fo

[Freeipa-devel] [PATCH 0432] stageuser-activate: noralize manager value

https://fedorahosted.org/freeipa/ticket/5481 Patch attached. From 4ba6a6daf58d751fbb95e23f785e6b4861e21079 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Mon, 7 Mar 2016 12:15:58 +0100 Subject: [PATCH] stageuser-activate: Normalize manager value Manager(s) were re

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

* old messages have been removed * 1) this method is unused please remove it def test_kra_install_master(self): Well, in fact it is used twice: in both domain levels, so I'd better keep it: -bash-4.3$ ipa-run-tests test_integration/test_replica_promotion.py --collect-only

Re: [Freeipa-devel] [PATCH 0430] remove unused argument from function update_ssh_keys

On 04.03.2016 09:48, David Kupka wrote: This patch is going to master branch only. Works for me, ACK. - Original Message - From: "Martin Basti" <mba...@redhat.com> To: "freeipa-devel" <freeipa-devel@redhat.com> Sent: Wednesday, March 2, 2016 5:33:18 PM

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 04.03.2016 08:37, Martin Basti wrote: On 03.03.2016 18:38, Martin Basti wrote: On 02.03.2016 13:47, Oleg Fayans wrote: Hi Martin, I've made the requested changes. The full set of necessary patches is attached. On 03/02/2016 10:05 AM, Martin Basti wrote: On 02.03.2016 00:12, Oleg

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 03.03.2016 18:38, Martin Basti wrote: On 02.03.2016 13:47, Oleg Fayans wrote: Hi Martin, I've made the requested changes. The full set of necessary patches is attached. On 03/02/2016 10:05 AM, Martin Basti wrote: On 02.03.2016 00:12, Oleg Fayans wrote: Hi Martin, On 03/01/2016 07

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 02.03.2016 13:47, Oleg Fayans wrote: Hi Martin, I've made the requested changes. The full set of necessary patches is attached. On 03/02/2016 10:05 AM, Martin Basti wrote: On 02.03.2016 00:12, Oleg Fayans wrote: Hi Martin, On 03/01/2016 07:04 PM, Martin Basti wrote: On 01.03.2016

Re: [Freeipa-devel] [PATCH 0426] spec: add missing requires to python*-ipalib package

On 26.02.2016 07:25, Jan Cholasta wrote: Hi, On 25.2.2016 18:05, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5680 Patch attached. NACK. For python 3, the ldap module is provided by python3-pyldap. Any reason for the random ordering? The requires are not alphabetically

Re: [Freeipa-devel] [patch 0033] spec file: update the python-polib dependency name to python2-polib

On 25.02.2016 11:07, Milan Kubík wrote: On 02/25/2016 11:07 AM, Jan Cholasta wrote: On 25.2.2016 11:03, Milan Kubík wrote: On 02/15/2016 05:39 PM, Lukas Slebodnik wrote: On (15/02/16 17:00), Petr Vobornik wrote: On 02/15/2016 04:37 PM, Milan Kubík wrote: Reflect the updated name of the

Re: [Freeipa-devel] host-del & client uninstall: additional discussion related to DNS needed

On 03.03.2016 17:36, Petr Vobornik wrote: On 03/03/2016 03:52 PM, Martin Basti wrote: Hello all, related tickets: https://fedorahosted.org/freeipa/ticket/5676 https://fedorahosted.org/freeipa/ticket/5675 https://fedorahosted.org/freeipa/ticket/5715 I'm trying to implement both tickets

Re: [Freeipa-devel] [PATCH 0422] CI: allow customized DS install test to run under different domain levels

On 03.03.2016 17:26, Milan Kubík wrote: On 03/02/2016 04:50 PM, Martin Basti wrote: On 24.02.2016 19:01, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5606 Patch attached. Bump for review Works for me, ACK. -- Milan Kubik Pushed to: master

Re: [Freeipa-devel] [PATCH 0400] l10n: Remove Transifex configuration

On 25.02.2016 11:40, Tomas Babej wrote: Hi, We're not using Transifex to manage our translations anymore. Tomas ACK Pushed to master: 61e627b4b3b9a9547128f128410d24b3cbe81b13 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0400] l10n: Remove Transifex configuration

On 25.02.2016 11:40, Tomas Babej wrote: Hi, We're not using Transifex to manage our translations anymore. Tomas ACK Pushed to master: 61e627b4b3b9a9547128f128410d24b3cbe81b13 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0403] adtrustinstance: Make sure smb.conf exists

On 26.02.2016 14:32, Tomas Babej wrote: Hi, The 'net' command fails unless smb.conf exists. Touch the file prior to any 'net' call to make sure we do not crash for this very reason. I couldn't find the aforementioned Samba bug either in the RH/Samba bugzilla, despite spending non-trivial

[Freeipa-devel] host-del & client uninstall: additional discussion related to DNS needed

Hello all, related tickets: https://fedorahosted.org/freeipa/ticket/5676 https://fedorahosted.org/freeipa/ticket/5675 https://fedorahosted.org/freeipa/ticket/5715 I'm trying to implement both tickets, but I don't like the way we decided on devel meeting anymore.

Re: [Freeipa-devel] [PATCHES 548-549] ipalib: add convenient Command method for adding messages

On 02.03.2016 15:35, Jan Cholasta wrote: Hi, these patches are for master only, see commit messages for details. Honza I love these patches. ACK, it works! Pushed to master: 3c57c305add17b95d4fb962efd9e5dfc9bd35efe -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0429] fix suspicious except statement

On 02.03.2016 17:17, Martin Basti wrote: Patch attached, read commit message for more info. https://fedorahosted.org/freeipa/ticket/5718 Updated patch attached. From a4d22716232dd7eaf39fa13df0f857d5d288d5ac Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed,

Re: [Freeipa-devel] [PATCH 0001] Add new parameter --ssh-update to ipa-client-install

is code in my employer's project and they look slightly 'different', mainly for brackets, strings, etc. Please, have a look to that, too, I'm happy for any guidance. Martin On Št, 2016-02-25 at 14:36 +0100, Jan Cholasta wrote: Hi, On 25.2.2016 14:23, Martin Basti wrote: On 22.02.2016 22:13

[Freeipa-devel] [PATCH 0430] remove unused argument from function update_ssh_keys

Patch attached, see commit message for details From 630dee2536106cbda7b49345733f37cfd8834f08 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 2 Mar 2016 17:26:33 +0100 Subject: [PATCH] Remove unused arguments from update_ssh_keys method First argumet has been

[Freeipa-devel] [PATCH 0429] fix suspicious except statement

Patch attached, read commit message for more info. From 2346845810137b7a844747ad75ee6e626d45d84e Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 2 Mar 2016 17:13:27 +0100 Subject: [PATCH] fix suspicious except statement in update_ssh_key The "except

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

On 28.01.2016 10:45, Filip Skola wrote: - Original Message - On 01/18/2016 02:26 PM, Filip Skola wrote: Hi, this should be fixed in this patch. F. - Original Message - On 01/15/2016 03:37 PM, Filip Skola wrote: Hi, sending rebased patch. F. - Original Message

Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled

On 28.01.2016 16:25, Petr Vobornik wrote: On 01/28/2016 04:23 PM, Tomas Babej wrote: On 01/28/2016 04:15 PM, Petr Vobornik wrote: Reworks also sessionStorage test because disablement of cookies might be connected with sessionStorage and localStorage. E.g. Chrome raises exception when

Re: [Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

On 28.01.2016 17:32, Martin Babinsky wrote: On 01/28/2016 05:06 PM, Tomas Babej wrote: On 01/28/2016 04:44 PM, Martin Babinsky wrote: On 01/28/2016 03:20 PM, Tomas Babej wrote: On 01/27/2016 03:58 PM, Martin Babinsky wrote: On 01/18/2016 06:43 PM, Martin Babinsky wrote: A little patch

Re: [Freeipa-devel] [PATCH 0422] CI: allow customized DS install test to run under different domain levels

On 24.02.2016 19:01, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5606 Patch attached. Bump for review -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page

Re: [Freeipa-devel] [PATCH] 0017 configure DNA shared config entry to allow connection with GSSAPI

On 01.03.2016 14:50, Martin Babinsky wrote: On 02/29/2016 05:37 PM, thierry bordaz wrote: On 02/26/2016 05:48 PM, Martin Babinsky wrote: On 02/26/2016 04:24 PM, thierry bordaz wrote: On 02/25/2016 07:17 PM, thierry bordaz wrote: On 02/25/2016 12:03 PM, Martin Babinsky wrote: On 02/24/2016

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

On 01.03.2016 15:22, Milan Kubík wrote: On 02/19/2016 02:11 PM, Oleg Fayans wrote: Hi Milan, On 02/12/2016 04:03 PM, Milan Kubík wrote: Agreed. The latest patch gets rid of all resolv.conf related manipulations. The tests work (where not affected by

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 02.03.2016 00:12, Oleg Fayans wrote: Hi Martin, On 03/01/2016 07:04 PM, Martin Basti wrote: On 01.03.2016 14:56, Martin Basti wrote: On 01.03.2016 12:37, Martin Basti wrote: On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally

[Freeipa-devel] [PATCH 0428] SPEC: do not execute upgrade when ipa server is not installed

https://fedorahosted.org/freeipa/ticket/5704 Patch attached. From 416ce2c0ab50f80d5d976dfa6a2b9a12975e15fb Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Tue, 1 Mar 2016 18:56:28 +0100 Subject: [PATCH] SPEC: do not run upgrade when ipa server is not installed R

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 01.03.2016 14:56, Martin Basti wrote: On 01.03.2016 12:37, Martin Basti wrote: On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also

Re: [Freeipa-devel] [PATCH 0427] fix broken configuration of sidgen and extdom plugins

On 01.03.2016 17:14, Martin Basti wrote: On 01.03.2016 17:13, Petr Vobornik wrote: On 03/01/2016 05:02 PM, Martin Basti wrote: On 01.03.2016 16:39, Petr Vobornik wrote: On 02/23/2016 06:15 PM, Martin Basti wrote: On 23.02.2016 17:31, Tomas Babej wrote: On 02/23/2016 01:25 PM

Re: [Freeipa-devel] [PATCH 0425] pylint: suppress false positive no-member errors

On 25.02.2016 17:50, Martin Basti wrote: On 25.02.2016 15:48, Martin Basti wrote: The last pylint 1.5 patch, \o/ https://fedorahosted.org/freeipa/ticket/5615 self-NACK too broad disables Updated patches attached. From 3e99288583f02661ed4875e90a10491948f42564 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

On 01.03.2016 16:39, Petr Vobornik wrote: On 02/23/2016 06:15 PM, Martin Basti wrote: On 23.02.2016 17:31, Tomas Babej wrote: On 02/23/2016 01:25 PM, Martin Basti wrote: On 23.02.2016 13:02, Alexander Bokovoy wrote: On Tue, 23 Feb 2016, Martin Basti wrote: From

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 01.03.2016 12:37, Martin Basti wrote: On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends

Re: [Freeipa-devel] [PATCH] 952 cookie parser: do not fail on cookie with empty value

On 01.03.2016 10:32, Petr Vobornik wrote: Forgot to attach ticket number. https://fedorahosted.org/freeipa/ticket/5709 ACK -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends on Martin's patch N 0421 All patches pass pylint

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

branch Martin^2 On 12/19/2015 11:56 PM, Martin Basti wrote: On 17.12.2015 10:04, Oleg Fayans wrote: Hi Martin, I am sorry, in my previous email I attached the old version of patch 0016. The correct on is attached. On 12/16/2015 05:47 PM, Martin Basti wrote: On 16.12.2015 15:39, Martin Basti

Re: [Freeipa-devel] Design: Automatic Empty Zone handling in bind-dyndb-ldap

On 19.02.2016 09:11, Petr Spacek wrote: On 12.1.2016 15:10, Martin Basti wrote: On 12.01.2016 15:06, Petr Spacek wrote: On 8.1.2016 18:14, Martin Basti wrote: On 08.01.2016 16:57, Petr Spacek wrote: Hello, recent improvements in FreeIPA 4.3.0 (finally) prevent FreeIPA installer from

[Freeipa-devel] [PATCH 0426] spec: add missing requires to python*-ipalib package

https://fedorahosted.org/freeipa/ticket/5680 Patch attached. From 3f3cfeb7d26f0b775f2ad40650ba085763ebd86f Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Thu, 25 Feb 2016 17:47:10 +0100 Subject: [PATCH] spec: Add missing dependencies to python*-ipalib package Stan

Re: [Freeipa-devel] [PATCH 0425] pylint: suppress false positive no-member errors

On 25.02.2016 15:48, Martin Basti wrote: The last pylint 1.5 patch, \o/ https://fedorahosted.org/freeipa/ticket/5615 self-NACK too broad disables -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA

Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

On 25.02.2016 09:52, Milan Kubík wrote: On 02/24/2016 07:05 PM, Martin Basti wrote: On 24.02.2016 08:34, Milan Kubík wrote: On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes

[Freeipa-devel] [PATCH 0425] pylint: suppress false positive no-member errors

The last pylint 1.5 patch, \o/ https://fedorahosted.org/freeipa/ticket/5615 From 785fb245fbe04b4cc630e6bc1c1ee670d6eca6a8 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Thu, 25 Feb 2016 13:46:33 +0100 Subject: [PATCH] pylint: supress false positive no-member errors

Re: [Freeipa-devel] [PATCH 0001] Add new parameter --ssh-update to ipa-client-install

On 22.02.2016 22:13, Martin Štefany wrote: Hi, please, review the attached patch which adds --ssh-update to ipa-client- install. Ticket: https://fedorahosted.org/freeipa/ticket/2655 Hello, thank you for your patch. Please attach a patch as a file next time. I have doubts that this should

Re: [Freeipa-devel] [PATCH 0424] Pylint: add missing attributes of exceptions to definition in pylint plugin

On 25.02.2016 11:29, David Kupka wrote: On 24/02/16 18:54, Martin Basti wrote: Pylint is not able to handle IPA errors objects, because attributes are added into objects dynamically, and pylint 1.5 reports them as no-member errors. https://fedorahosted.org/freeipa/ticket/5615 Patch attached

Re: [Freeipa-devel] [PATCH 0423] fix duplicated except

On 25.02.2016 12:03, David Kupka wrote: On 25/02/16 11:40, Jan Cholasta wrote: On 25.2.2016 11:25, David Kupka wrote: On 24/02/16 17:56, Martin Basti wrote: During my playing with pylint, I fixed this issue which allows us to enable additional check in pylint (the nice one). Patch attached

Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

On 24.02.2016 08:34, Milan Kubík wrote: On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik Review bump. -- Milan Kubik

[Freeipa-devel] [PATCH 0422] CI: allow customized DS install test to run under different domain levels

https://fedorahosted.org/freeipa/ticket/5606 Patch attached. From 1fe93ac24694dc490ddc497b1cbd493cd38e8117 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 24 Feb 2016 17:45:55 +0100 Subject: [PATCH] CI: allow customized DS install test to work with domain levels

[Freeipa-devel] [PATCH 0424] Pylint: add missing attributes of exceptions to definition in pylint plugin

: Martin Basti <mba...@redhat.com> Date: Wed, 24 Feb 2016 18:48:29 +0100 Subject: [PATCH] Pylint: add missing attributes of errors to definitions Attributes are added to IPA error objects dynamicaly and pylint is not able to handle it itself. Add missing attributes to definitions in pylint

[Freeipa-devel] [PATCH 0423] fix duplicated except

During my playing with pylint, I fixed this issue which allows us to enable additional check in pylint (the nice one). Patch attached, it should go only to master. From 547d41f5835e1dd3a4dcf644948ef104cc50c5dc Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Fri,

[Freeipa-devel] [PATCH] revert temporal changes in the vault CI test

Workaround for #5538 works, tests can be restored to original state https://fedorahosted.org/freeipa/ticket/5538 Pushed to: master: a14d68749397a52537594da890fb23e994dd04e2 ipa-4-3: 390f6342952b63d6d27648096d70bc3fdd81dc78 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0420] Set BuildRequires to pylint 1.4

On 24.02.2016 13:38, Lukas Slebodnik wrote: On (24/02/16 11:06), Petr Vobornik wrote: On 02/24/2016 09:50 AM, Lukas Slebodnik wrote: On (23/02/16 14:23), Rob Crittenden wrote: Lukas Slebodnik wrote: On (23/02/16 17:09), Martin Basti wrote: We cannot guarantee that versions older than 1.4

Re: [Freeipa-devel] [PATCH 0413] fix permission: Read Replication Agreements

On 24.02.2016 13:36, Jan Cholasta wrote: On 24.2.2016 13:07, Martin Basti wrote: On 24.02.2016 10:45, Jan Cholasta wrote: On 23.2.2016 17:20, Martin Basti wrote: On 22.02.2016 09:00, Jan Cholasta wrote: Hi, On 17.2.2016 14:49, Martin Basti wrote: https://fedorahosted.org/freeipa

[Freeipa-devel] [PATCH 0421] Make PTR records check optional for IPA installation

https://fedorahosted.org/freeipa/ticket/5686 Patch attached. From 19a00a076101ff25ba0cd626bab8b5f8a6e6cb68 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 24 Feb 2016 14:33:34 +0100 Subject: [PATCH] Make PTR records check optional for IPA installation PTR r

Re: [Freeipa-devel] [PATCH 0413] fix permission: Read Replication Agreements

On 24.02.2016 10:45, Jan Cholasta wrote: On 23.2.2016 17:20, Martin Basti wrote: On 22.02.2016 09:00, Jan Cholasta wrote: Hi, On 17.2.2016 14:49, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5631 Patch attached (for master, 4.3, 4.2) 1) All the replication agreement

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

On 23.02.2016 17:31, Tomas Babej wrote: On 02/23/2016 01:25 PM, Martin Basti wrote: On 23.02.2016 13:02, Alexander Bokovoy wrote: On Tue, 23 Feb 2016, Martin Basti wrote: From f2ae1bd129a1741500d2f3dcb86a0da553604d15 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com>

Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology

On 23.02.2016 17:33, Martin Basti wrote: On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test

Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology

On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>

<    3   4   5   6   7   8   9   10   11   12   >