Re: [Freeipa-devel] [PATCH][DOC] 432 Add direct bug reporting links to Feedback section

2014-02-14 Thread Petr Viktorin
On 02/14/2014 09:30 AM, Martin Kosek wrote: On 02/14/2014 09:25 AM, Petr Spacek wrote: On 13.2.2014 22:39, Petr Spacek wrote: On 13.2.2014 14:33, Martin Kosek wrote: On 11/08/2013 10:18 AM, Martin Kosek wrote: On 10/17/2013 12:04 PM, Martin Kosek wrote: On 10/17/2013 07:25 AM, Petr Spacek

Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-02-14 Thread Petr Viktorin
On 02/14/2014 12:07 AM, Rob Crittenden wrote: Martin Kosek wrote: On 01/28/2014 09:35 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 01/23/2014 02:17 PM, Petr Viktorin wrote: ... The URL endpoint /ipa/rest suggests that if we implement a complete REST API for IPA it would live here

Re: [Freeipa-devel] [PATCH 0012] tests: Move zone enable/disable tests to end of test_dns_plugin.p

2014-02-14 Thread Petr Viktorin
On 02/14/2014 03:10 PM, Petr Spacek wrote: Hello, This patch prevents the test suite from hitting limitations in bind-dyndb-ldap 4.0. It should go to 3.4 (master branch, right?). Tests still pass, but the commit message is not very informative. Could you explain/link to what kind of

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Petr Viktorin
On 02/14/2014 12:39 PM, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Petr Viktorin
On 02/14/2014 12:37 PM, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Petr Viktorin
On 02/14/2014 01:13 PM, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my

Re: [Freeipa-devel] [PATCH 0012] tests: Move zone enable/disable tests to end of test_dns_plugin.p

2014-02-14 Thread Petr Viktorin
On 02/14/2014 03:52 PM, Petr Spacek wrote: On 14.2.2014 15:29, Petr Viktorin wrote: On 02/14/2014 03:10 PM, Petr Spacek wrote: Hello, This patch prevents the test suite from hitting limitations in bind-dyndb-ldap 4.0. It should go to 3.4 (master branch, right?). Tests still pass

Re: [Freeipa-devel] [PATCH]

2014-02-18 Thread Petr Viktorin
On 02/18/2014 08:40 AM, Alexander Bokovoy wrote: On Mon, 17 Feb 2014, Darth Vader wrote: Hi all, This patch fixes the spelling for hostname in ipa-join instructions. Since it is just a spelling change, I figured the one-liner rule would work and a push to the master would be okay; however, I

Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-02-18 Thread Petr Viktorin
On 02/18/2014 07:52 AM, Martin Kosek wrote: On 02/18/2014 12:11 AM, Dmitri Pal wrote: On 02/17/2014 04:57 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 04:13 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 02:33 PM, Rob Crittenden wrote: Dmitri Pal wrote: On

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-18 Thread Petr Viktorin
On 02/17/2014 06:17 PM, Alexander Bokovoy wrote: On Mon, 17 Feb 2014, Nathaniel McCallum wrote: On Wed, 2014-02-12 at 11:49 -0500, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches

Re: [Freeipa-devel] [Patch] [DOC] documentation patches

2014-02-18 Thread Petr Viktorin
On 02/18/2014 08:41 AM, Alexander Bokovoy wrote: On Mon, 17 Feb 2014, Darth Vader wrote: Hi all, I have a couple of documentation patches that need to be reviewed. Probably the biggest one would be the upgrade procedure as what was in the docs was outdated. I can break these out in separate

Re: [Freeipa-devel] [PATCH 0013-0014] Modify DNS tests to workaround bug in python-dns

2014-02-18 Thread Petr Viktorin
On 02/17/2014 03:42 PM, Petr Spacek wrote: Hello, I have found bug in python-dns and consequently another bug in LOC record parsing in IPA. See commit messages. My next patch for 'wait_for_dns' functionality (required for bind-dyndb-ldap 4.0) depends on these fixes. 0013 - ACK 0014 - ACK

Re: [Freeipa-devel] [PATCH] Permission MOD command fix

2014-02-18 Thread Petr Viktorin
On 02/18/2014 06:46 PM, Jan Cholasta wrote: Hi, On 18.2.2014 18:40, Nathaniel McCallum wrote: On Tue, 2014-02-18 at 12:31 -0500, Adam Misnyovszki wrote: Hi, this patch fixes permission-mod command returning duplicate memberships. https://fedorahosted.org/freeipa/ticket/4175 NACK This

Re: [Freeipa-devel] [PATCH 0025] Add support to ipa-kdb for keyless principals

2014-02-19 Thread Petr Viktorin
On 02/18/2014 09:02 PM, Alexander Bokovoy wrote: On Tue, 12 Nov 2013, Nathaniel McCallum wrote: https://fedorahosted.org/freeipa/ticket/3779 ACK Pushed to master: b769d1c18678b5eede7505dec7938f6836070044 -- Petr³ ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] 0468 permission-mod: Do not copy member attributes to new entry

2014-02-19 Thread Petr Viktorin
Hello, This fixes https://fedorahosted.org/freeipa/ticket/4178 -- Petr³ From 85222e02ce57224ea661c990c69efecbf7907a74 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 19 Feb 2014 14:18:58 +0100 Subject: [PATCH] permission-mod: Do not copy member attributes to new entry

[Freeipa-devel] [PATCH] [WIP] 0469 - Remove the unused ipalib.frontend.Property class

2014-02-20 Thread Petr Viktorin
/freeipa/ticket/3460 BTW, this is the first small step in my framework refactoring master plan (http://www.freeipa.org/page/V3/Refactorings#Mutable_Command_objects). -- Petr³ From 5f19318c3a92a71555282ae6417a5c77c581b269 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed

Re: [Freeipa-devel] [PATCH 0153] ipatests: Fix incorrect order of operations when restoring

2014-02-20 Thread Petr Viktorin
On 02/19/2014 04:54 PM, Jan Pazdziora wrote: On Wed, Feb 19, 2014 at 04:37:05PM +0100, Tomas Babej wrote: Hi, When restoring files from backup, we do use an incorrect order of operations - we first restore SELinux context and then copy the files from backup, when we need to do the exact

Re: [Freeipa-devel] [PATCH] 0468 permission-mod: Do not copy member attributes to new entry

2014-02-20 Thread Petr Viktorin
On 02/19/2014 04:17 PM, Jan Cholasta wrote: On 19.2.2014 14:45, Petr Viktorin wrote: Hello, This fixes https://fedorahosted.org/freeipa/ticket/4178 Thanks, ACK. Thanks, pushed to master: 0824d12c95d840b1787743e8316b0bc0f7ba5284 -- Petr

Re: [Freeipa-devel] [PATCH 0153] ipatests: Fix incorrect order of operations when restoring

2014-02-20 Thread Petr Viktorin
On 02/20/2014 12:58 PM, Jan Pazdziora wrote: On Thu, Feb 20, 2014 at 12:20:12PM +0100, Petr Viktorin wrote: On 02/19/2014 04:54 PM, Jan Pazdziora wrote: However: since this is about restoring a backup, can't the backup contain the extended attributes, so that the SELinux context gets restored

Re: [Freeipa-devel] [PATCHES] 0464-0466 Multivalued targetfilter

2014-02-20 Thread Petr Viktorin
On 02/20/2014 01:06 PM, Martin Kosek wrote: On 02/20/2014 12:57 PM, Petr Viktorin wrote: On 02/19/2014 05:32 PM, Martin Kosek wrote: On 02/19/2014 10:44 AM, Petr Viktorin wrote: On 02/18/2014 08:02 PM, Petr Viktorin wrote: On 02/18/2014 09:42 AM, Martin Kosek wrote: On 02/13/2014 01:12 PM

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Viktorin
On 02/20/2014 01:14 PM, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message, but that is a post-review tag which is not useful for someone who wants to know which patches are

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Viktorin
On 02/20/2014 01:36 PM, Martin Kosek wrote: On 02/20/2014 01:22 PM, Petr Viktorin wrote: On 02/20/2014 01:14 PM, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Viktorin
On 02/20/2014 04:15 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: On 02/20/2014 04:09 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: On 02/20/2014 03:52 PM, Jakub Hrozek wrote: On Thu, Feb 20, 2014 at 01:22:56PM +0100, Petr

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Viktorin
On 02/20/2014 04:55 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 16:34 +0100, Petr Viktorin wrote: On 02/20/2014 04:15 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: On 02/20/2014 04:09 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote

Re: [Freeipa-devel] [freeipa] #4185: Index plugin namespaces by classes

2014-02-20 Thread Petr Viktorin
On 02/20/2014 06:47 PM, Dmitri Pal wrote: On 02/20/2014 12:39 PM, freeipa wrote: #4185: Index plugin namespaces by classes -+- Reporter: pviktori |Owner: pviktori

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-21 Thread Petr Viktorin
On 02/20/2014 07:45 PM, Nathaniel McCallum wrote: On Wed, 2014-02-12 at 11:49 -0500, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered

Re: [Freeipa-devel] [PATCH] [WIP] 0469 - Remove the unused ipalib.frontend.Property class

2014-02-21 Thread Petr Viktorin
On 02/21/2014 11:13 AM, Jan Cholasta wrote: Hi, On 20.2.2014 09:54, Petr Viktorin wrote: Hello, I had this patch sitting around for some time but didn't get around to polishing and submitting it lately. The ticket was now claimed by rga (I assume that's the person who goes by Darth Vader here

Re: [Freeipa-devel] [freeipa] #4185: Index plugin namespaces by classes

2014-02-21 Thread Petr Viktorin
On 02/20/2014 08:00 PM, Dmitri Pal wrote: On 02/20/2014 12:57 PM, Petr Viktorin wrote: On 02/20/2014 06:47 PM, Dmitri Pal wrote: On 02/20/2014 12:39 PM, freeipa wrote: #4185: Index plugin namespaces by classes

Re: [Freeipa-devel] [PATCH 0016] Clarify error message about missing DNS component in ipa-replica-prepare

2014-02-21 Thread Petr Viktorin
On 02/21/2014 02:57 PM, Petr Spacek wrote: Hello, Clarify error message about missing DNS component in ipa-replica-prepare. Use 'dane' on #freeipa channel have spent half an hour finding out what is wrong because the error message was misleading. I think that it is enough to justify this

[Freeipa-devel] [PATCH] 0471 permission_add: Remove permission entry if adding the ACI fails

2014-02-21 Thread Petr Viktorin
: Martin, you reviewed the other ACI patches so I think you should continue. If you don't agree, unset the field in the ticket. -- Petr³ From 5ad2066b71b09248d348a5c4c85ef2ace0c553a4 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 21 Feb 2014 13:58:15 +0100 Subject: [PATCH

Re: [Freeipa-devel] [PATCH 0040] Use super() properly to avoid an exception

2014-02-21 Thread Petr Viktorin
On 02/21/2014 03:51 PM, Alexander Bokovoy wrote: On Fri, 21 Feb 2014, Nathaniel McCallum wrote: https://fedorahosted.org/freeipa/ticket/4099 From b77bf5c7fdacc7b0224033d608d387be282f98bc Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum npmccal...@redhat.com Date: Thu, 20 Feb 2014 13:20:01

Re: [Freeipa-devel] [PATCH 0016] Clarify error message about missing DNS component in ipa-replica-prepare

2014-02-21 Thread Petr Viktorin
On 02/21/2014 03:25 PM, Petr Viktorin wrote: On 02/21/2014 02:57 PM, Petr Spacek wrote: Hello, Clarify error message about missing DNS component in ipa-replica-prepare. Use 'dane' on #freeipa channel have spent half an hour finding out what is wrong because the error message was misleading. I

Re: [Freeipa-devel] [PATCH 0041] Make all ipatokenTOTP attributes mandatory

2014-02-21 Thread Petr Viktorin
On 02/21/2014 04:05 PM, Jan Cholasta wrote: Hi, On 21.2.2014 15:41, Nathaniel McCallum wrote: Originally we made them all optional as a workaround for the lack of SELFDN support in 389DS. However, with the advent of SELFDN, this hack is no longer necessary. This patch updates TOTP to match

Re: [Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-02-21 Thread Petr Viktorin
On 02/21/2014 03:45 PM, Nathaniel McCallum wrote: [...] NOTE: this patch changes an existing API. VERSION says that we should bump the major version in this case. But we haven't actually released this API yet. Please advise. If I understand correctly, there were other VERSION bumps in master

Re: [Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-02-21 Thread Petr Viktorin
On 02/21/2014 04:13 PM, Petr Viktorin wrote: On 02/21/2014 03:45 PM, Nathaniel McCallum wrote: [...] NOTE: this patch changes an existing API. VERSION says that we should bump the major version in this case. But we haven't actually released this API yet. Please advise. If I understand

Re: [Freeipa-devel] [PATCH] 240 Always use real entry DNs for memberOf in ldap2

2014-02-24 Thread Petr Viktorin
On 02/24/2014 10:18 AM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4192. Honza Thanks, ACK, pushed to master: 792c3f9c8c65e24953241247a242490c8fb32492 -- Petr³ ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH 0153] ipatests: Fix incorrect order of operations when restoring

2014-02-25 Thread Petr Viktorin
On 02/25/2014 08:56 AM, Tomas Babej wrote: Given the fact that the patch has been ACKed, can we push the current iteration? On 02/20/2014 01:07 PM, Petr Viktorin wrote: On 02/20/2014 12:58 PM, Jan Pazdziora wrote: On Thu, Feb 20, 2014 at 12:20:12PM +0100, Petr Viktorin wrote: On 02/19/2014

Re: [Freeipa-devel] [PATCH] Certificate search max_serial_number problem fixed

2014-02-25 Thread Petr Viktorin
On 02/25/2014 02:47 PM, Jan Cholasta wrote: On 21.2.2014 12:11, Adam Misnyovszki wrote: - Original Message - From: Jan Cholasta jchol...@redhat.com To: Adam Misnyovszki amisn...@redhat.com, freeipa-devel@redhat.com Sent: Friday, February 21, 2014 11:05:12 AM Subject: Re:

Re: [Freeipa-devel] [PATCH 0043] Remove NULLS from constants.py

2014-02-25 Thread Petr Viktorin
On 02/25/2014 03:07 PM, Jan Pazdziora wrote: On Fri, Feb 21, 2014 at 11:42:45AM -0500, Nathaniel McCallum wrote: In the parameters system, we have been checking for a positive list of values which get converted to None. The problem is that this method can in some cases throw warnings when type

Re: [Freeipa-devel] [PATCH] Certificate search max_serial_number problem fixed

2014-02-25 Thread Petr Viktorin
On 02/25/2014 04:01 PM, Petr Viktorin wrote: On 02/25/2014 02:47 PM, Jan Cholasta wrote: On 21.2.2014 12:11, Adam Misnyovszki wrote: - Original Message - From: Jan Cholasta jchol...@redhat.com To: Adam Misnyovszki amisn...@redhat.com, freeipa-devel@redhat.com Sent: Friday, February

Re: [Freeipa-devel] [PATCH 0155] ipatests: Kill winbindd process after uninstall

2014-02-25 Thread Petr Viktorin
On 02/25/2014 01:21 PM, Tomas Babej wrote: Hi, As a part of a better cleanup procedure in the integration tests, make sure that winbindd is not running after uninstalling the IPA server. -9, what a brutal way to kill. Usually when I stop a service this way, systemd restarts it right away.

[Freeipa-devel] [PATCHES] 0473-0477 Managed permission updater, part 1

2014-02-26 Thread Petr Viktorin
0476: Allow modifying (but not creating) permissions with : in the name 0477: Permission updater sample metadata -- Petr³ (* picked by fair dice roll) From acbca2183b52c3c3f2d3d733aa5a5086c2f24830 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 12 Feb 2014 16:17:39

Re: [Freeipa-devel] [PATCH] 0142: initialize BindInstance.zonemgr for short-circuited instance use in replica setup

2014-02-26 Thread Petr Viktorin
On 02/26/2014 10:13 AM, Alexander Bokovoy wrote: Hi, BindInstance is used in two different ways, with replica setup not calling BindInstance.setup() before adding master records. This causes some properties to be uninitialized and an exception when installing replica.

Re: [Freeipa-devel] [PATCH] 0138, 0141: ipa-kdb fixes

2014-02-26 Thread Petr Viktorin
On 02/26/2014 02:17 PM, Tomas Babej wrote: On 02/26/2014 02:16 PM, Tomas Babej wrote: On 02/26/2014 12:39 PM, Martin Kosek wrote: On 02/26/2014 09:33 AM, Alexander Bokovoy wrote: On Wed, 26 Feb 2014, Martin Kosek wrote: On 02/25/2014 07:59 PM, Simo Sorce wrote: On Tue, 2014-02-25 at 20:58

Re: [Freeipa-devel] FreeIPA 3.4 - 4.0

2014-02-26 Thread Petr Viktorin
On 02/26/2014 12:24 PM, Martin Kosek wrote: Hello all, I would like to discuss a proposal that Simo had on FreeIPA devel meeting. Given permission/ACI refactoring that Petr3 is working on, people may have issues with access to their LDAP if they played too much with the default ACIs or if they

Re: [Freeipa-devel] Is there RPC documentation?

2014-02-26 Thread Petr Viktorin
On 02/26/2014 04:45 PM, Rich Megginson wrote: I'm working on adding support for freeipa DNS to openstack designate (DNSaaS). I am assuming I need to use RPC (XML? JSON? REST?) to communicate with freeipa. Is there documentation about how to construct and send RPC messages? The JSON-RPC and

Re: [Freeipa-devel] [PATCH] 544 webui: Focus expand/collapse link in batch_error dialog

2014-02-27 Thread Petr Viktorin
On 02/26/2014 04:55 PM, Adam Misnyovszki wrote: - Original Message - From: Petr Vobornik pvobo...@redhat.com To: freeipa-devel freeipa-devel@redhat.com Sent: Tuesday, February 25, 2014 2:19:21 PM Subject: [Freeipa-devel] [PATCH] 544 webui: Focus expand/collapse link in

Re: [Freeipa-devel] [PATCH] 0478 ipalib.plugins: Expose LDAPObjects' eligibility for permission --type in JSON metadata

2014-02-27 Thread Petr Viktorin
On 02/27/2014 12:52 PM, Alexander Bokovoy wrote: On Thu, 27 Feb 2014, Petr Viktorin wrote: Hello, This patch exposes object metadata needed for permission WebUI. https://fedorahosted.org/freeipa/ticket/4201 -- Petr³ From cbebd3328715db4ddd4afe9bdbd6c6edf0bf7148 Mon Sep 17 00:00:00 2001

[Freeipa-devel] [PATCH] 0479 permission plugin: Allow multiple values for memberof

2014-02-28 Thread Petr Viktorin
:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Thu, 27 Feb 2014 14:38:16 +0100 Subject: [PATCH] permission plugin: Allow multiple values for memberof Design: http://www.freeipa.org/page/V3/Multivalued_target_filters_in_permissions Additional fix for: https://fedorahosted.org/freeipa

Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-02-28 Thread Petr Viktorin
On 02/27/2014 10:18 PM, Rob Crittenden wrote: Rob Crittenden wrote: [...] Ok, so try to summarize this long-running thread, I'll rename the subpackage to freeipa-server-foreman-smartproxy to make it clearer what it is/does. Right now it requires manual configuration so having the package

Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-02-28 Thread Petr Viktorin
On 02/28/2014 12:41 PM, Martin Kosek wrote: On 02/28/2014 10:47 AM, Petr Viktorin wrote: On 02/27/2014 10:18 PM, Rob Crittenden wrote: Rob Crittenden wrote: [...] Ok, so try to summarize this long-running thread, I'll rename the subpackage to freeipa-server-foreman-smartproxy to make

[Freeipa-devel] [PATCH] 0480

2014-02-28 Thread Petr Viktorin
Hello, This fixes https://fedorahosted.org/freeipa/ticket/4206 Apply on top of my patch 0479, to avoid a conflict in tests. -- Petr³ From 286190d9374290acef301ca92279f3f729827cad Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 28 Feb 2014 12:23:17 +0100 Subject

Re: [Freeipa-devel] [PATCH] 0480 permission plugin: Don't crash with empty targetfilter

2014-02-28 Thread Petr Viktorin
Fixing the subject On 02/28/2014 01:11 PM, Petr Viktorin wrote: Hello, This fixes https://fedorahosted.org/freeipa/ticket/4206 Apply on top of my patch 0479, to avoid a conflict in tests. -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] [PATCHES] 0473-0477 Managed permission updater, part 1

2014-02-28 Thread Petr Viktorin
On 02/28/2014 02:12 PM, Martin Kosek wrote: On 02/26/2014 10:44 AM, Petr Viktorin wrote: Hello, Here are a few fixes/improvements, and the first part of a managed permission updater. The patches should go in this order but don't need to be ACKed/pushed all at once. Design: http

Re: [Freeipa-devel] [PATCH 0007][DOC] Tip on restoring admin account

2014-02-28 Thread Petr Viktorin
On 02/26/2014 04:01 PM, Gabe Alford wrote: Hi all, I added a tip in the deleting users section on restoring admin account. Please review. https://fedorahosted.org/freeipa/ticket/2746 Hello, The new tip is added right under a Note about the same thing (or a very similar thing, from the

[Freeipa-devel] [PATCH] 0481 permission-find: Cache the root entry for legacy permissions

2014-02-28 Thread Petr Viktorin
Hello, This reduces LDAP searches in permission-find when there are legacy permissions. The root entry (which contains all legacy permission ACIs) is only looked up once. -- Petr³ From 34528e3fce17db1e4c2a23f091dc9d7fcd93b97f Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com

Re: [Freeipa-devel] Client-side command in the IPA framework

2014-02-28 Thread Petr Viktorin
On 02/28/2014 04:15 PM, Alexander Bokovoy wrote: On Fri, 28 Feb 2014, Nathaniel McCallum wrote: On Fri, 2014-02-28 at 16:43 +0200, Alexander Bokovoy wrote: On Fri, 28 Feb 2014, Nathaniel McCallum wrote: On Fri, 2014-02-28 at 10:47 +0100, Petr Vobornik wrote: On 28.2.2014 04:02, Rob Crittenden

Re: [Freeipa-devel] Client-side command in the IPA framework

2014-02-28 Thread Petr Viktorin
On 02/28/2014 04:02 PM, Nathaniel McCallum wrote: On Fri, 2014-02-28 at 16:43 +0200, Alexander Bokovoy wrote: [...] Why then to do it as a IPA CLI command at all? This is an administrative task which can be done with a separate ipa-otp-import command, designated to run on IPA masters.

Re: [Freeipa-devel] [PATCH] 238 Fix modlist generation code not to generate empty replace mods

2014-02-28 Thread Petr Viktorin
On 02/04/2014 03:01 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4138. Honza Thanks, ACK. Here are some tests for this, do they look good? -- Petr³ From ca10b6af63727f0ca7a008dccc9edbe594ca5467 Mon Sep 17 00:00:00 2001 From: Petr Viktorin

Re: [Freeipa-devel] [PATCH] 238 Fix modlist generation code not to generate empty replace mods

2014-03-03 Thread Petr Viktorin
On 03/03/2014 11:43 AM, Jan Cholasta wrote: On 28.2.2014 16:29, Petr Viktorin wrote: On 02/04/2014 03:01 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4138. Honza Thanks, ACK. Here are some tests for this, do they look good? They look good

Re: [Freeipa-devel] server install failing in F-20?

2014-03-03 Thread Petr Viktorin
On 02/28/2014 09:48 PM, Rob Crittenden wrote: I'm seeing what looks like https://fedorahosted.org/freeipa/ticket/4084 in new F-20 install I stood up. I finally threw my hands up and configured system to use an environment file to work around it. Not sure if anyone else is seeing this. rob

Re: [Freeipa-devel] [PATCH 0007][DOC] Tip on restoring admin account

2014-03-03 Thread Petr Viktorin
On 03/03/2014 03:16 PM, Gabe Alford wrote: Yes, the attached patch looks good. I see what you are saying how it did look misleading. Thanks, Gabe Thank you for your help! Pushed to docs master: dfb1b16b4b62e87540b34bae8b4454021f17fd71 On Mon, Mar 3, 2014 at 3:13 AM, Petr Viktorin pvikt

[Freeipa-devel] [PATCH] 0486 permission-mod: Remove attributelevelrights before reverting entry

2014-03-03 Thread Petr Viktorin
Hello, This fixes issue #4212 which Petr¹ found in his Web UI work. [#4212] https://fedorahosted.org/freeipa/ticket/4212 -- Petr³ From 3fd6a68161cc267d59731cfb0257cc350acfc36f Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Mon, 3 Mar 2014 14:46:51 +0100 Subject: [PATCH

Re: [Freeipa-devel] [PATCHES] 0473-0477 Managed permission updater, part 1

2014-03-03 Thread Petr Viktorin
On 02/28/2014 02:47 PM, Petr Viktorin wrote: On 02/28/2014 02:12 PM, Martin Kosek wrote: On 02/26/2014 10:44 AM, Petr Viktorin wrote: Hello, Here are a few fixes/improvements, and the first part of a managed permission updater. The patches should go in this order but don't need to be ACKed

Re: [Freeipa-devel] Daily build of the documentation?

2014-03-04 Thread Petr Viktorin
On 03/04/2014 02:28 PM, Martin Kosek wrote: On 03/04/2014 02:26 PM, Lukas Slebodnik wrote: On (04/03/14 13:48), Martin Kosek wrote: On 10/25/2013 05:22 PM, Jérôme Fenal wrote: 2013/10/25 Martin Basti mba...@redhat.com: On Fri, 2013-10-25 at 16:48 +0200, Jérôme Fenal wrote: Hi all, Do we

Re: [Freeipa-devel] [PATCH 0008] Typo in warning message where IPA realm and domain name differ

2014-03-05 Thread Petr Viktorin
On 03/04/2014 01:48 AM, Simo Sorce wrote: On Mon, 2014-03-03 at 17:20 -0700, Gabe Alford wrote: Hi all, Quick one line change to fix. https://fedorahosted.org/freeipa/ticket/4211 ACK Simo. Pushed to master: b50cdd55af8af7fdf30a822dce03af68969ddfe6 -- Petr³

Re: [Freeipa-devel] [PATCH] 545 webui: Don't act on keyboard events which originated in, different dialog

2014-03-05 Thread Petr Viktorin
On 03/04/2014 05:56 PM, Adam Misnyovszki wrote: - Original Message - From: Adam Misnyovszki amisn...@redhat.com To: Petr Vobornik pvobo...@redhat.com Cc: freeipa-devel freeipa-devel@redhat.com Sent: Tuesday, March 4, 2014 5:27:21 PM Subject: Re: [Freeipa-devel] [PATCH] 545 webui:

Re: [Freeipa-devel] [PATCHES] 0337-0343 YAML test configuration

2014-03-05 Thread Petr Viktorin
On 03/04/2014 04:59 PM, Tomas Babej wrote: Thanks, PATCH 341: ACK (this is the last remaining ACK for this patchset) Also pushed to ipa-3-3: 23814f9b57794a5f2f8ae62a3342ee18535df2ea On 03/04/2014 11:58 AM, Petr Viktorin wrote: On 03/03/2014 01:41 PM, Tomas Babej wrote: Finally got

Re: [Freeipa-devel] [PATCHES] 0337-0343 YAML test configuration

2014-03-05 Thread Petr Viktorin
On 03/04/2014 04:59 PM, Tomas Babej wrote: Thanks, PATCH 341: ACK (this is the last remaining ACK for this patchset) Thank you! Pushed to master: 561e57d12169cfa4e1d2c5d9fef42b149c37fca2 On 03/04/2014 11:58 AM, Petr Viktorin wrote: On 03/03/2014 01:41 PM, Tomas Babej wrote: Finally got

Re: [Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-03-05 Thread Petr Viktorin
On 03/03/2014 01:14 PM, Jan Cholasta wrote: On 21.2.2014 17:45, Nathaniel McCallum wrote: On Fri, 2014-02-21 at 16:29 +0100, Jan Cholasta wrote: Hi, On 21.2.2014 16:09, Nathaniel McCallum wrote: On Fri, 2014-02-21 at 09:45 -0500, Nathaniel McCallum wrote: We had originally decided to

Re: [Freeipa-devel] [PATCH 0045] Fix token secret length RFC compliance

2014-03-05 Thread Petr Viktorin
On 03/03/2014 05:19 PM, Jan Cholasta wrote: On 3.3.2014 17:13, Nathaniel McCallum wrote: RFC 4226 states the following in section 4: R6 - The algorithm MUST use a strong shared secret. The length of the shared secret MUST be at least 128 bits. This document RECOMMENDs a shared

Re: [Freeipa-devel] [PATCHES] 0473-0477 Managed permission updater, part 1

2014-03-05 Thread Petr Viktorin
On 03/03/2014 04:10 PM, Petr Viktorin wrote: On 02/28/2014 02:47 PM, Petr Viktorin wrote: On 02/28/2014 02:12 PM, Martin Kosek wrote: On 02/26/2014 10:44 AM, Petr Viktorin wrote: Hello, Here are a few fixes/improvements, and the first part of a managed permission updater. The patches should

[Freeipa-devel] [PATCH] 0487 ipalib.plugable: Always set the parser in bootstrap()

2014-03-05 Thread Petr Viktorin
Hello, This patch fixes a failing test setup where logging was configured before the API was bootstrapped. The __setattr__ is moved before a conditional return. -- Petr³ From d90395f3c7dc54efda49355976155bd56dc2259d Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 5

Re: [Freeipa-devel] [PATCH] 0235 tests: Use ipa-getkeytab from /usr/sbin instead of the in-tree one

2014-03-05 Thread Petr Viktorin
On 09/24/2013 05:34 PM, Petr Viktorin wrote: On 06/04/2013 05:48 PM, Simo Sorce wrote: On Tue, 2013-06-04 at 17:24 +0200, Petr Viktorin wrote: On 06/04/2013 02:53 PM, Simo Sorce wrote: On Tue, 2013-06-04 at 13:48 +0200, Petr Viktorin wrote: Hardcoding the in-tree location for ipa-getkeytab

[Freeipa-devel] [PATCH] 0488 tests: Create the testing service certificate on demand

2014-03-05 Thread Petr Viktorin
` passes. (It logs too much so it doesn't look pretty, but it passes.) -- Petr³ From a82e4b40a8732f3e1a062c21e0cd587af563efc3 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 5 Mar 2014 16:46:21 +0100 Subject: [PATCH] tests: Create the testing service certificate

Re: [Freeipa-devel] [PATCH] 0488 tests: Create the testing service certificate on demand

2014-03-06 Thread Petr Viktorin
On 03/06/2014 09:46 AM, Jan Cholasta wrote: On 5.3.2014 17:38, Petr Viktorin wrote: Hello, This transforms the make-testcert command into a module that creates the certificate when it is first needed. As a result the tests are more self-contained, and can be run from a read-only location

Re: [Freeipa-devel] [PATCH] 0479 permission plugin: Allow multiple values for memberof

2014-03-07 Thread Petr Viktorin
On 03/07/2014 04:30 PM, Martin Kosek wrote: On 02/28/2014 10:42 AM, Petr Viktorin wrote: Hello, Here is an additional part for the multivalued target filters: making --memberof also multivalued. http://www.freeipa.org/page/V3/Multivalued_target_filters_in_permissions https://fedorahosted.org

Re: [Freeipa-devel] [PATCH] 0480 permission plugin: Don't crash with empty targetfilter

2014-03-07 Thread Petr Viktorin
On 03/07/2014 04:34 PM, Martin Kosek wrote: On 02/28/2014 01:13 PM, Petr Viktorin wrote: Fixing the subject On 02/28/2014 01:11 PM, Petr Viktorin wrote: Hello, This fixes https://fedorahosted.org/freeipa/ticket/4206 Apply on top of my patch 0479, to avoid a conflict in tests. Works fine

Re: [Freeipa-devel] [PATCH] 0481 permission-find: Cache the root entry for legacy permissions

2014-03-10 Thread Petr Viktorin
On 03/07/2014 04:45 PM, Martin Kosek wrote: On 02/28/2014 03:51 PM, Petr Viktorin wrote: Hello, This reduces LDAP searches in permission-find when there are legacy permissions. The root entry (which contains all legacy permission ACIs) is only looked up once. There is a conflict on one line

Re: [Freeipa-devel] FreeIPA ConnId connector for usage with Apache Syncope

2014-03-10 Thread Petr Viktorin
On 03/07/2014 04:39 PM, Marco Di Sabatino Di Diodoro wrote: Hi all, Il giorno 03/feb/2014, alle ore 11:41, Francesco Chicchiriccò ilgro...@apache.org mailto:ilgro...@apache.org ha scritto: On 31/01/2014 18:57, Dmitri Pal wrote: On 01/31/2014 08:17 AM, Francesco Chicchiriccò wrote: Are you

Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-03-10 Thread Petr Viktorin
On 02/27/2014 10:18 PM, Rob Crittenden wrote: Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 04:57 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 04:13 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 02:33 PM, Rob Crittenden wrote: Dmitri Pal wrote: On

Re: [Freeipa-devel] [PATCH] 236 Log unhandled exceptions in certificate renewal scripts

2014-03-10 Thread Petr Viktorin
On 03/10/2014 11:23 AM, Jan Cholasta wrote: On 28.1.2014 14:44, Petr Viktorin wrote: On 01/23/2014 03:47 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4093. Honza This needs a rebase for the new LDAP API. Fixed and rebased on top of current

Re: [Freeipa-devel] FreeIPA ConnId connector for usage with Apache Syncope

2014-03-10 Thread Petr Viktorin
On 03/10/2014 07:17 PM, Dmitri Pal wrote: On 03/10/2014 08:24 AM, Petr Viktorin wrote: On 03/07/2014 04:39 PM, Marco Di Sabatino Di Diodoro wrote: Hi all, Il giorno 03/feb/2014, alle ore 11:41, Francesco Chicchiriccò ilgro...@apache.org mailto:ilgro...@apache.org ha scritto: On 31/01/2014

Re: [Freeipa-devel] [PATCH] 0471 permission_add: Remove permission entry if adding the ACI fails

2014-03-11 Thread Petr Viktorin
On 03/11/2014 03:08 PM, Jan Pazdziora wrote: On Fri, Feb 21, 2014 at 03:30:22PM +0100, Petr Viktorin wrote: Hello, A permission object was not removed in permission-add when adding the ACI failed. Here is a fix. https://fedorahosted.org/freeipa/ticket/4187 Earlier we agreed that patch

Re: [Freeipa-devel] [PATCH] 460 ipa-replica-install never checks for 7389 port

2014-03-11 Thread Petr Viktorin
On 03/11/2014 04:33 PM, Martin Kosek wrote: When creating replica from a Dogtag 9 based IPA server, the port 7389 which is required for the installation is never checked by ipa-replica-conncheck even though it knows that it is being installed from the Dogtag 9 based FreeIPA. If the 7389 port

Re: [Freeipa-devel] [PATCH] 0471 permission_add: Remove permission entry if adding the ACI fails

2014-03-12 Thread Petr Viktorin
On 03/12/2014 10:20 AM, Jan Pazdziora wrote: On Tue, Mar 11, 2014 at 04:09:37PM +0100, Petr Viktorin wrote: Unfortunately, yes, these operations are racy. When something fails, or when doing two operations simultaneously, it is possible that the objects are not both added. If that happens

Re: [Freeipa-devel] [PATCH] 0149: ipa-sam: ipa-sam: cache gid to sid and uid to sid requests in idmap cache

2014-03-12 Thread Petr Viktorin
On 03/12/2014 11:02 AM, Sumit Bose wrote: On Tue, Mar 11, 2014 at 11:04:29PM +0200, Alexander Bokovoy wrote: On Tue, 11 Mar 2014, Sumit Bose wrote: On Tue, Mar 11, 2014 at 07:09:42PM +0200, Alexander Bokovoy wrote: Hi, Add idmap_cache calls to ipa-sam to prevent huge numbers of LDAP calls

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-03-12 Thread Petr Viktorin
On 03/12/2014 05:23 PM, Misnyovszki Adam wrote: On Wed, 12 Mar 2014 15:41:31 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 7.3.2014 18:10, Petr Vobornik wrote: Attaching new version of 537 which adds combobox control for owner attribute instead of textbox. All other patches are attached

Re: [Freeipa-devel] [PATCHES] 172-196 Refactor certificate renewal code

2014-03-12 Thread Petr Viktorin
On 03/10/2014 01:03 PM, Jan Cholasta wrote: On 17.10.2013 18:59, Jan Cholasta wrote: On 17.10.2013 18:01, Petr Viktorin wrote: On 10/17/2013 02:21 PM, Jan Cholasta wrote: Hi, this patchset contains refactoring of the certificate renewal code, which will be the base for CA certificate renewal

Re: [Freeipa-devel] [PATCH] 549 webui: use unique ids for checkboxes

2014-03-13 Thread Petr Viktorin
On 03/12/2014 05:51 PM, Misnyovszki Adam wrote: On Tue, 25 Feb 2014 18:12:20 +0100 Petr Vobornik pvobo...@redhat.com wrote: This is a minor fix. Please don't close ticket 3904 yet if committed. Checkboxes have not used unique ids across the whole UI. It broke checking by clicking on label for

[Freeipa-devel] [PATCH] 0496 ipaserver.install.service: Fix estimated time display

2014-03-13 Thread Petr Viktorin
Hello, The time estimate display is broken, so I wrote a test for it. Also the bug should be fixed now. https://fedorahosted.org/freeipa/ticket/4242 -- Petr³ From 4aee528f2f3085157ee9b1c888d4c35db45b694b Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 12 Mar 2014 12

Re: [Freeipa-devel] [PATCHES] 0473-0477+0497 Managed permission updater, part 1

2014-03-13 Thread Petr Viktorin
On 03/07/2014 10:45 AM, Martin Kosek wrote: On 03/05/2014 01:48 PM, Petr Viktorin wrote: On 03/03/2014 04:10 PM, Petr Viktorin wrote: On 02/28/2014 02:47 PM, Petr Viktorin wrote: On 02/28/2014 02:12 PM, Martin Kosek wrote: On 02/26/2014 10:44 AM, Petr Viktorin wrote: Hello, Here are a few

Re: [Freeipa-devel] [PATCH] 546 webui: Datetime parsing and formatting

2014-03-13 Thread Petr Viktorin
On 03/13/2014 03:45 PM, Misnyovszki Adam wrote: On Thu, 06 Mar 2014 13:26:03 +0100 Petr Vobornik pvobo...@redhat.com wrote: On 6.3.2014 13:01, Misnyovszki Adam wrote: On Tue, 25 Feb 2014 18:05:28 +0100 Petr Vobornik pvobo...@redhat.com wrote: prerequisite for patch 547, 548 depends on

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Petr Viktorin
On 03/13/2014 05:11 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Tomas Babej wrote: Tomas, could you please change the code correspondingly? Sure. Here is the updated patch. Slightly improved patch with better control flow. Thanks for the reviews. -- Tomas Babej Associate Software

Re: [Freeipa-devel] [PATCH] 0496 ipaserver.install.service: Fix estimated time display

2014-03-13 Thread Petr Viktorin
On 03/13/2014 02:41 PM, Rob Crittenden wrote: Petr Viktorin wrote: Hello, The time estimate display is broken, so I wrote a test for it. Also the bug should be fixed now. https://fedorahosted.org/freeipa/ticket/4242 ACK Pushed to master: 7c9fa8fad96c039b96939f8df8d740ad6b50eec9 -- Petr

Re: [Freeipa-devel] [PATCH] 461 Update Dogtag 9 database during replica installation

2014-03-14 Thread Petr Viktorin
On 03/14/2014 10:29 AM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 03:15 PM, Martin Kosek wrote: On 03/13/2014 09:09 AM, Martin Kosek wrote: When Dogtag 10 based FreeIPA replica is being installed for a Dogtag 9 based master, the PKI database is not

Re: [Freeipa-devel] [PATCH] 461 Update Dogtag 9 database during replica installation

2014-03-14 Thread Petr Viktorin
On 03/14/2014 12:37 PM, Alexander Bokovoy wrote: On Fri, 14 Mar 2014, Petr Viktorin wrote: On 03/14/2014 10:29 AM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 03:15 PM, Martin Kosek wrote: On 03/13/2014 09:09 AM, Martin Kosek wrote: When Dogtag 10 based

Re: [Freeipa-devel] [PATCH] 461 Update Dogtag 9 database during replica installation

2014-03-14 Thread Petr Viktorin
On 03/14/2014 01:34 PM, Petr Viktorin wrote: On 03/14/2014 12:37 PM, Alexander Bokovoy wrote: On Fri, 14 Mar 2014, Petr Viktorin wrote: On 03/14/2014 10:29 AM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 03:15 PM, Martin Kosek wrote: On 03/13/2014 09:09

Re: [Freeipa-devel] [PATCHES] 0473-0477+0497 Managed permission updater, part 1

2014-03-14 Thread Petr Viktorin
On 03/13/2014 02:01 PM, Petr Viktorin wrote: On 03/07/2014 10:45 AM, Martin Kosek wrote: On 03/05/2014 01:48 PM, Petr Viktorin wrote: On 03/03/2014 04:10 PM, Petr Viktorin wrote: On 02/28/2014 02:47 PM, Petr Viktorin wrote: On 02/28/2014 02:12 PM, Martin Kosek wrote: On 02/26/2014 10:44 AM

Re: [Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

2014-03-14 Thread Petr Viktorin
On 03/14/2014 05:31 PM, Misnyovszki Adam wrote: Hi, automember-rebuild uses asynchronous 389 task, and returned success even if the task didn't run. This patch fixes this issue adding a --nowait parameter to 'ipa automember-rebuild', defaulting to False, thus when the script runs without it, it

<    6   7   8   9   10   11   12   13   14   15   >