Re: [Freeipa-devel] [PATCH 487] ldap: Make ldap2 connection management thread-safe again

2015-09-04 Thread Tomas Babej
On 09/02/2015 04:47 PM, Jan Cholasta wrote: > On 2.9.2015 16:20, thierry bordaz wrote: >> On 09/02/2015 03:16 PM, Jan Cholasta wrote: >>> On 2.9.2015 14:51, Martin Basti wrote: On 09/02/2015 02:32 PM, Jan Cholasta wrote: > Hi, > > the attached patch fixes >

[Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements

2015-09-03 Thread Tomas Babej
Hi, this couple of patches fix https://fedorahosted.org/freeipa/ticket/5278 and improve our handling of realmdomains in general. Tomas From 7298b240843b5a86569b3e99cd793f42fd007acf Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Thu, 3 Sep 2015 12:13:32 +0200 Subject:

Re: [Freeipa-devel] [PATCH 0004] Rewrap errors in get_principal to CCacheError

2015-09-03 Thread Tomas Babej
On 09/03/2015 12:54 PM, Michael Šimáček wrote: > After porting to gssapi, the ipa command prints ugly traceback when > kerberos credentials are not available. Rewrapping to CCacheError when > getting the principal name results in nicer error message. > >

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-03 Thread Tomas Babej
On 09/03/2015 01:40 PM, Lenka Doudova wrote: > Hi, > > I took a look at it at Milan's request. > > patch 0008 - tracker looks ok, ACK > patch 0009 - test cases look ok as well, but can't get it to run, 10 out > of 14 tests fail, starting with internal error, which I haven't been > able to

Re: [Freeipa-devel] [PATCH] Updated no of legacy permission in ipatests

2015-09-03 Thread Tomas Babej
On 09/03/2015 08:16 AM, Abhijeet Kasurde wrote: > Ping > > On 08/27/2015 10:37 AM, Abhijeet Kasurde wrote: >> Hi All, >> >> This patch fixes bug - https://fedorahosted.org/freeipa/ticket/5264 >> >> Thanks, >> Abhijeet Kasurde > ACK, the patch needs a minor rebase on master due to python3

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-08-31 Thread Tomas Babej
On 08/26/2015 11:27 PM, Simo Sorce wrote: > This patchset implements https://fedorahosted.org/freeipa/ticket/2888 > and introduces a number of required changes and dependencies to achieve > this goal. > This work requires the custodia project to securely transfer keys > between ipa servers. >

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-08-31 Thread Tomas Babej
On 08/31/2015 02:56 PM, Simo Sorce wrote: > On Mon, 2015-08-31 at 14:45 +0200, Tomas Babej wrote: >> >> On 08/26/2015 11:27 PM, Simo Sorce wrote: >>> This patchset implements https://fedorahosted.org/freeipa/ticket/2888 >>> and introduces a number of required ch

Re: [Freeipa-devel] [PATCH 0066] ipactl: Do not start/stop/restart single service multiple times

2015-08-26 Thread Tomas Babej
On 08/26/2015 03:16 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/5248 +def deduplicate(lst): +new_lst = [] +s = set(lst) +for i in lst: +if i in s: +s.remove(i) +new_lst.append(i) + +return new_lst + Imho, this method

Re: [Freeipa-devel] [PATCH] 914 webui: add option to establish bidirectional trust

2015-08-26 Thread Tomas Babej
On 08/25/2015 05:19 PM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/5259 ACK. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] First part of integration tests for Topology Plugin

2015-08-26 Thread Tomas Babej
On 08/26/2015 11:44 AM, Oleg Fayans wrote: Hi Martin, On 08/20/2015 11:18 AM, Martin Basti wrote: On 08/20/2015 10:26 AM, Martin Basti wrote: On 08/19/2015 04:17 PM, Martin Basti wrote: I got this: https://paste.fedoraproject.org/256746/43999380/ FYI replica install failure. (I

Re: [Freeipa-devel] [PATCH] 0196 trusts: format Kerberos principal properly when fetching trust topology

2015-08-24 Thread Tomas Babej
On 08/20/2015 02:21 PM, Alexander Bokovoy wrote: Hi, one more fix for the problem with trusts that Scott Poore found when verifying fixes to bug https://bugzilla.redhat.com/show_bug.cgi?id=1250190 Details are in the commit message. ACK, this fixes the issue in case of two-way

Re: [Freeipa-devel] [PATCH 0003] Added PyYAML as a dependency for ipa-tests, fixed a replica preparation in RHEL

2015-08-21 Thread Tomas Babej
On 08/20/2015 12:08 PM, Martin Babinsky wrote: On 08/20/2015 11:48 AM, Oleg Fayans wrote: Fixed two failures of integration tests under RHEL: 1. PyYAML, needed for integration tests is not installed as a dependency 2. ipa-replica-prepare requests a reverse zone info under RHEL. Hi

Re: [Freeipa-devel] Regression in client-install [master]

2015-08-18 Thread Tomas Babej
On 08/18/2015 03:25 AM, Simo Sorce wrote: I see a regression in the client install now that the python-kerberos - python-gssapi patches have landed. Reverting that single patch makes the issue go away, is anyone else seeing this ? Simo. I believe you're talking about

Re: [Freeipa-devel] [PATCH] 0195 harden trust-fetch-domains oddjobd script

2015-08-18 Thread Tomas Babej
On 08/18/2015 11:56 AM, Alexander Bokovoy wrote: On Tue, 18 Aug 2015, Alexander Bokovoy wrote: On Mon, 17 Aug 2015, Tomas Babej wrote: On 08/17/2015 09:03 AM, Alexander Bokovoy wrote: On Mon, 17 Aug 2015, Tomas Babej wrote: On 08/13/2015 04:29 PM, Alexander Bokovoy wrote: Hi, see

[Freeipa-devel] [PATCHES 0360-0361] winsync-migrate: Add PassSync warnings

2015-08-17 Thread Tomas Babej
Hi, the following pair of patches fixes: https://fedorahosted.org/freeipa/ticket/5162 From ab4f6e4ebdd91e9f57540acd11ecf0c13f1f2d81 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Mon, 17 Aug 2015 08:46:52 +0200 Subject: [PATCH] winsync-migrate: Add warning about passsync

Re: [Freeipa-devel] [PATCH] 0195 harden trust-fetch-domains oddjobd script

2015-08-17 Thread Tomas Babej
On 08/13/2015 04:29 PM, Alexander Bokovoy wrote: Hi, see commit message for details. Hi, code-wise this looks good to me. Unfortunately, I have not been able to verify in my setup that it fixes the issue in the linked BZ: $ echo Secret123456 | ipa trust-add --type=ad ad.test

Re: [Freeipa-devel] [PATCH] 0195 harden trust-fetch-domains oddjobd script

2015-08-17 Thread Tomas Babej
On 08/17/2015 09:03 AM, Alexander Bokovoy wrote: On Mon, 17 Aug 2015, Tomas Babej wrote: On 08/13/2015 04:29 PM, Alexander Bokovoy wrote: Hi, see commit message for details. Hi, code-wise this looks good to me. Unfortunately, I have not been able to verify in my setup

Re: [Freeipa-devel] [patch]-pytest-multihost-Return File Attributes to sftp.put

2015-08-13 Thread Tomas Babej
On 08/13/2015 01:55 PM, Niranjan wrote: Greetings, This patch is regarding pytest-multihost plugin. Including a patch to return FileAttributes for sftp.put function used in the function. Current put_file function in transport.py in ParamikoTransport Class doesn't return any value. So

Re: [Freeipa-devel] [PATCH] First part of integration tests for Topology Plugin

2015-08-13 Thread Tomas Babej
On 08/13/2015 05:06 PM, Martin Basti wrote: On 08/11/2015 03:36 PM, Oleg Fayans wrote: Hi Martin, On 08/11/2015 02:02 PM, Martin Basti wrote: NACK, comments inline. On 11/08/15 13:25, Oleg Fayans wrote: Hi Martin, Thanks for the review! On 08/10/2015 07:08 PM, Martin Basti wrote:

Re: [Freeipa-devel] [PATCH] 909 validate mutually exclusive options in vault-add

2015-08-12 Thread Tomas Babej
On 08/12/2015 04:28 PM, Tomas Babej wrote: On 08/12/2015 01:00 PM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/5195 I did a small grammar change could - can in the error message. Otherwise ACK. Pushed to master: 7d7ffb62526595433412633c05af5af7909124c8 Pushed

Re: [Freeipa-devel] [PATCH 0055] raise an exception when user tries to modify a local ID range

2015-08-12 Thread Tomas Babej
On 08/12/2015 04:38 PM, Tomas Babej wrote: On 08/10/2015 10:50 AM, Martin Babinsky wrote: On 08/07/2015 05:25 PM, Tomas Babej wrote: On 08/07/2015 05:09 PM, Martin Babinsky wrote: On 08/07/2015 04:51 PM, Tomas Babej wrote: On 08/07/2015 04:22 PM, Martin Babinsky wrote: Short term

Re: [Freeipa-devel] [PATCH 0359] adtrust-install: Correctly determine 4.2 FreeIPA servers

2015-08-12 Thread Tomas Babej
On 08/11/2015 04:58 PM, Alexander Bokovoy wrote: On Tue, 11 Aug 2015, Tomas Babej wrote: Hi, We need to detect a list of FreeIPA 4.2 (and above) servers, since only there is the required version of SSSD present. Since the maximum domain level for 4.2 is 0 (and not 1), we can filter

Re: [Freeipa-devel] [PATCH] 909 validate mutually exclusive options in vault-add

2015-08-12 Thread Tomas Babej
On 08/12/2015 01:00 PM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/5195 I did a small grammar change could - can in the error message. Otherwise ACK. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0055] raise an exception when user tries to modify a local ID range

2015-08-12 Thread Tomas Babej
On 08/10/2015 10:50 AM, Martin Babinsky wrote: On 08/07/2015 05:25 PM, Tomas Babej wrote: On 08/07/2015 05:09 PM, Martin Babinsky wrote: On 08/07/2015 04:51 PM, Tomas Babej wrote: On 08/07/2015 04:22 PM, Martin Babinsky wrote: Short term fix for https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCH 470] install: Fix server and replica install options

2015-08-12 Thread Tomas Babej
On 08/12/2015 03:42 PM, Martin Babinsky wrote: On 08/12/2015 07:52 AM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/5184. Honza ACK master: a651be3eec2a08bd2865b16b0eed767db69aab0f ipa-4-2: 8e1a9b49397ee9dbef9fce4b61277246ea65ca8d --

Re: [Freeipa-devel] [PATCH] 0031 certprofile: add profile format explanation

2015-08-12 Thread Tomas Babej
On 08/12/2015 06:24 PM, Tomas Babej wrote: On 08/05/2015 06:10 AM, Fraser Tweedale wrote: The attached patch addresses https://fedorahosted.org/freeipa/ticket/5089 Thanks, Fraser ACK, thanks for the explanations. I gather this concludes the https://fedorahosted.org/freeipa

Re: [Freeipa-devel] [PATCHES] 0691-0695 Modernization

2015-08-12 Thread Tomas Babej
On 08/12/2015 06:16 PM, Tomas Babej wrote: On 08/12/2015 06:12 PM, Christian Heimes wrote: On 2015-08-12 18:10, Tomas Babej wrote: On 08/10/2015 05:39 PM, Petr Viktorin wrote: On 08/03/2015 11:07 AM, Christian Heimes wrote: On 2015-07-31 19:14, Petr Viktorin wrote: Hello, Here

Re: [Freeipa-devel] [PATCH] 0031 certprofile: add profile format explanation

2015-08-12 Thread Tomas Babej
On 08/05/2015 06:10 AM, Fraser Tweedale wrote: The attached patch addresses https://fedorahosted.org/freeipa/ticket/5089 Thanks, Fraser ACK, thanks for the explanations. I gather this concludes the https://fedorahosted.org/freeipa/ticket/5089 ticket then? Tomas -- Manage your

Re: [Freeipa-devel] [PATCHES] 0691-0695 Modernization

2015-08-12 Thread Tomas Babej
On 08/12/2015 06:12 PM, Christian Heimes wrote: On 2015-08-12 18:10, Tomas Babej wrote: On 08/10/2015 05:39 PM, Petr Viktorin wrote: On 08/03/2015 11:07 AM, Christian Heimes wrote: On 2015-07-31 19:14, Petr Viktorin wrote: Hello, Here is a batch of mostly mechanical changes: removing

Re: [Freeipa-devel] [PATCH] 908 adjust search so that it works for non-admin users

2015-08-12 Thread Tomas Babej
On 08/12/2015 12:59 PM, Petr Vobornik wrote: Non-admin user can now search for: - hosts - hostgroups - netgroups - servers - services (Fixes ACI issue where search returns nothing when user does't have read rights for an attribute in search_attributes.

Re: [Freeipa-devel] [PATCH] 908 adjust search so that it works for non-admin users

2015-08-12 Thread Tomas Babej
On 08/12/2015 04:13 PM, Tomas Babej wrote: On 08/12/2015 12:59 PM, Petr Vobornik wrote: Non-admin user can now search for: - hosts - hostgroups - netgroups - servers - services (Fixes ACI issue where search returns nothing when user does't have read rights for an attribute

[Freeipa-devel] [PATCH 0359] adtrust-install: Correctly determine 4.2 FreeIPA servers

2015-08-11 Thread Tomas Babej
://fedorahosted.org/freeipa/ticket/5199 From 31bf121e4603bc1287eac88653ff48198c2f69c3 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 11 Aug 2015 16:05:32 +0200 Subject: [PATCH] adtrust-install: Correctly determine 4.2 FreeIPA servers We need to detect a list of FreeIPA 4.2

Re: [Freeipa-devel] [PATCH 0055] raise an exception when user tries to modify a local ID range

2015-08-07 Thread Tomas Babej
On 08/07/2015 05:09 PM, Martin Babinsky wrote: On 08/07/2015 04:51 PM, Tomas Babej wrote: On 08/07/2015 04:22 PM, Martin Babinsky wrote: Short term fix for https://fedorahosted.org/freeipa/ticket/4826 Hi, couple of minor issues: 1.) Please create a separate constant for the WARNING

Re: [Freeipa-devel] [PATCH 0055] raise an exception when user tries to modify a local ID range

2015-08-07 Thread Tomas Babej
On 08/07/2015 04:22 PM, Martin Babinsky wrote: Short term fix for https://fedorahosted.org/freeipa/ticket/4826 Hi, couple of minor issues: 1.) Please create a separate constant for the WARNING section, now this segment is copy-pasted at three different places in the plugin. 2.) It

[Freeipa-devel] [PATCH 0357] trusts: Detect domain clash with IPA domain when adding a AD

2015-08-06 Thread Tomas Babej
17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Thu, 6 Aug 2015 10:54:47 +0200 Subject: [PATCH] trusts: Detect domain clash with IPA domain when adding a AD trust When IPA is deployed in the same domain as AD, trust-add fails since the names of the local domain and trusted domain ranges

[Freeipa-devel] [PATCH 0356] trusts: Detect missing Samba instance

2015-08-06 Thread Tomas Babej
128ee05bbebe17f77272b8f2a6bd5039cfbc26b0 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Thu, 6 Aug 2015 10:10:04 +0200 Subject: [PATCH] trusts: Detect missing Samba instance In the event of invocation of trust related commands, IPA server needs to contact local Samba instance. This is not possible on servers

Re: [Freeipa-devel] [PATCH] 0194 Fix selector of protocol for LSA RPC binding string

2015-08-06 Thread Tomas Babej
On 08/05/2015 08:40 PM, Alexander Bokovoy wrote: Hi, attached patch fixes a bug https://bugzilla.redhat.com/show_bug.cgi?id=1249455 details are in the commit message. Looks good to me, generates bindings strings as described in the BZ. Just a readability nitpick, can we get rid

Re: [Freeipa-devel] [PATCH] 0032 Fix otptoken-remove-managedby command summary

2015-08-05 Thread Tomas Babej
On 08/05/2015 07:51 AM, Fraser Tweedale wrote: Small doc fix. Cheers, Fraser ACK, thanks for catching this. Pushed to: master: e28a45072004d93ced9bf81b3810fbd2652664b5 ipa-4-2: dc0745650a0172bb66350fb453ec4285e31a32ad Tomas -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] Exporting users access formulars

2015-08-05 Thread Tomas Babej
On 08/04/2015 03:13 PM, Florian Crouzat wrote: Hey, For security reason (mostly PCI-DSS) I have to print and sign-off access formular for every users, and also to maintain these formulars in time which means that every time I add a host to a hostgroup for example, I should reprint all

[Freeipa-devel] [PATCH 0355] Fix incorrect type comparison in trust-fetch-domains

2015-08-05 Thread Tomas Babej
Hi, Value needs to be unpacked from the list and converted before comparison. https://fedorahosted.org/freeipa/ticket/5182 From dee59d971acb733c1dee06a61cc0d79ac2f4fdb7 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 5 Aug 2015 17:31:47 +0200 Subject: [PATCH] Fix

Re: [Freeipa-devel] 4.1 branch is broken

2015-08-04 Thread Tomas Babej
On 08/04/2015 03:44 PM, Rob Crittenden wrote: Commit 4d2ef43f broke the 4.1 branch. There is no ipaplatform/paths.py. rob I don't think so, that particular commit is from May 29 2014, which predates the release of FreeIPA 4.0. This file (along with couple of other platform dependant

Re: [Freeipa-devel] New freeipa-tools repo

2015-08-03 Thread Tomas Babej
On 07/30/2015 01:58 PM, Martin Kosek wrote: On 07/30/2015 01:51 PM, Alexander Bokovoy wrote: On Thu, 30 Jul 2015, Martin Kosek wrote: Hello all, Right now, the people pushing patches to FreeIPA use Petr's great ipatool that is part of Petr's (CCed) ipa-tools repo forked from my old

Re: [Freeipa-devel] [PATCH] 0028 add --out option to user-show

2015-07-24 Thread Tomas Babej
On 07/24/2015 05:34 PM, Martin Basti wrote: On 24/07/15 16:52, Tomas Babej wrote: On 07/24/2015 03:40 PM, Fraser Tweedale wrote: The attached patch adds --out option to user-show for saving user's certificate(s) to file. Thanks, Fraser I hate to nitpick here, but is out really

Re: [Freeipa-devel] [PATCH] 0028 add --out option to user-show

2015-07-24 Thread Tomas Babej
On 07/24/2015 03:40 PM, Fraser Tweedale wrote: The attached patch adds --out option to user-show for saving user's certificate(s) to file. Thanks, Fraser I hate to nitpick here, but is out really a descriptive option name here? I'd prefer something more explicit, like

Re: [Freeipa-devel] [PATCHES 0351-0353] Improvements to ID override type validation

2015-07-23 Thread Tomas Babej
On 07/23/2015 03:32 PM, Alexander Bokovoy wrote: On Thu, 23 Jul 2015, Tomas Babej wrote: +def get_trusted_domain_object_type(self, name_or_sid): + +Return the type of the object corresponding to the given name in +the trusted domain, which is either 'user

Re: [Freeipa-devel] [PATCHES 0351-0353] Improvements to ID override type validation

2015-07-23 Thread Tomas Babej
On 07/23/2015 03:08 PM, Alexander Bokovoy wrote: On Thu, 23 Jul 2015, Tomas Babej wrote: Hi, this patchset deals mainly with the ticket: https://fedorahosted.org/freeipa/ticket/5029 Details in the commit messages. Tomas From 83defa7e286b9e65a147598b4056abc47b4647bf Mon Sep 17 00:00

Re: [Freeipa-devel] [PATCH 0049] fix broken search for users by their manager

2015-07-23 Thread Tomas Babej
On 07/23/2015 11:31 AM, Martin Babinsky wrote: On 07/23/2015 11:18 AM, Tomas Babej wrote: On 07/23/2015 10:55 AM, Martin Babinsky wrote: Fixes https://fedorahosted.org/freeipa/ticket/5146 The patch fixes the mentioned issue. However, there is some code made redundant

Re: [Freeipa-devel] [PATCH 0049] fix broken search for users by their manager

2015-07-23 Thread Tomas Babej
On 07/23/2015 10:55 AM, Martin Babinsky wrote: Fixes https://fedorahosted.org/freeipa/ticket/5146 The patch fixes the mentioned issue. However, there is some code made redundant in stageuser_find.execute, which does the same thing, can you please remove it? Tomas -- Manage your

Re: [Freeipa-devel] [PATCH 0342] idviews: Check for the Default Trust View only if applying

2015-07-22 Thread Tomas Babej
On 07/22/2015 09:04 AM, Martin Basti wrote: On 21/07/15 12:47, Tomas Babej wrote: Hi, Currently, the code wrongly validates the idview-unapply command. Move check for the forbidden application of the Default Trust View into the correct logical branch. https://fedorahosted.org/freeipa

Re: [Freeipa-devel] [PATCH 0345] tests: realmdomains_plugin: Add explanatory comment

2015-07-22 Thread Tomas Babej
On 07/22/2015 09:07 AM, Martin Basti wrote: On 21/07/15 18:02, Tomas Babej wrote: Hi, The realmdomains_mod command will fail if the testing environment is configured improperly and the IPA domain's NS/SOA records are not resolvable. This can easily happen if the machine's DNS server

Re: [Freeipa-devel] [PATCH 0344] tests: service_plugin: Make sure the cert is decoded from

2015-07-22 Thread Tomas Babej
On 07/22/2015 08:40 AM, Martin Babinsky wrote: On 07/21/2015 06:01 PM, Tomas Babej wrote: Hi, this patch fixes an issue in tests where the certificate was not decoded from base64 representation. Tomas ACK Pushed to: master: 12395a94f38f4db23e356a6f7d96629155c02532 ipa-4-2

Re: [Freeipa-devel] [PATCH 0347] tests: vault_plugin: Skip tests if KRA not available

2015-07-22 Thread Tomas Babej
On 07/22/2015 08:41 AM, Martin Babinsky wrote: On 07/21/2015 06:03 PM, Tomas Babej wrote: Hi, the vault tests should be skipped in case the KRA is not available on the machine. Tomas ACK Pushed to: master: 8eb26e9230e43eb2683778b8d667c6c7e632ec36 ipa-4-2

Re: [Freeipa-devel] [PATCH 0349] tests: test_cert: Services can have multiple certificates

2015-07-22 Thread Tomas Babej
On 07/22/2015 08:44 AM, Martin Babinsky wrote: On 07/21/2015 06:03 PM, Tomas Babej wrote: Hi, Old certificates of the services are no longer removed and revoked after new ones have been issued. Check that both old and new certificates are present. Tomas ACK Pushed to: master

Re: [Freeipa-devel] [PATCH 0348] tests: test_rpc: Create connection for the current thread

2015-07-22 Thread Tomas Babej
On 07/22/2015 09:09 AM, Martin Basti wrote: On 21/07/15 18:03, Tomas Babej wrote: Hi, Both context.xmlclient and context.xmlclient_id need to be created in order to successfully call the Command.forward method. Tomas ACK -- Martin Basti Pushed to: master

[Freeipa-devel] [PATCH 0346] tests: Version is currently generated during command call

2015-07-21 Thread Tomas Babej
Hi, In the previous versions, version in the response was generated as part of the process_keyword_arguments method. This is no longer true, and so the explicit check for it should be removed. Tomas From 6f3b99589257711cbfa349cc6b21055b430a2d87 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba

[Freeipa-devel] [PATCH 0345] tests: realmdomains_plugin: Add explanatory comment

2015-07-21 Thread Tomas Babej
c5fdaf229b67e4b6f331c3e9c9f42e751853f15b Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 21 Jul 2015 14:12:31 +0200 Subject: [PATCH] tests: realmdomains_plugin: Add explanatory comment The realmdomains_mod command will fail if the testing environment is configured improperly

[Freeipa-devel] [PATCH 0343] tests: user_plugin: Add preserved flag when --all is used

2015-07-21 Thread Tomas Babej
Hi, this patch fixes failing tests for the user plugin where preserved attribute is missing. Tomas From bb209a5679fcebfd5329f3dfd1537d8bb7802c22 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 21 Jul 2015 13:17:56 +0200 Subject: [PATCH] tests: user_plugin: Add preserved

[Freeipa-devel] [PATCH 0344] tests: service_plugin: Make sure the cert is decoded from

2015-07-21 Thread Tomas Babej
Hi, this patch fixes an issue in tests where the certificate was not decoded from base64 representation. Tomas From 4bf69e94984d72d1f52dfb2afd65574c73838ece Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 21 Jul 2015 13:58:13 +0200 Subject: [PATCH] tests: service_plugin

[Freeipa-devel] [PATCH 0347] tests: vault_plugin: Skip tests if KRA not available

2015-07-21 Thread Tomas Babej
Hi, the vault tests should be skipped in case the KRA is not available on the machine. Tomas From dcfc274d400b5cd4bb2bdba6f1774952c63f9a5b Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 21 Jul 2015 15:43:35 +0200 Subject: [PATCH] tests: vault_plugin: Skip tests if KRA

[Freeipa-devel] [PATCH 0349] tests: test_cert: Services can have multiple certificates

2015-07-21 Thread Tomas Babej
Hi, Old certificates of the services are no longer removed and revoked after new ones have been issued. Check that both old and new certificates are present. Tomas From d1445c61bab5d9ee5efc4fe68d7fc8caf7758f75 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 21 Jul 2015

Re: [Freeipa-devel] [PATCH 0343] tests: user_plugin: Add preserved flag when --all is used

2015-07-21 Thread Tomas Babej
On 07/21/2015 06:51 PM, Martin Basti wrote: On 21/07/15 18:01, Tomas Babej wrote: Hi, this patch fixes failing tests for the user plugin where preserved attribute is missing. Tomas ACK -- Martin Basti Pushed to: master: 705603a396bff251a453aec73fc973a5d85c6d44 ipa-4-2

[Freeipa-devel] [PATCH 0342] idviews: Check for the Default Trust View only if applying

2015-07-21 Thread Tomas Babej
From: Tomas Babej tba...@redhat.com Date: Tue, 21 Jul 2015 12:44:37 +0200 Subject: [PATCH] idviews: Check for the Default Trust View only if applying the view Currently, the code wrongly validates the idview-unapply command. Move check for the forbidden application of the Default Trust View

Re: [Freeipa-devel] general error message at the attempt to set domain level to 0

2015-07-20 Thread Tomas Babej
711f4cc96215e9aeb9b5896ce70f71e64e422a6c Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Mon, 20 Jul 2015 13:49:41 +0200 Subject: [PATCH] domainlevel: Fix incorrect initializations of InvalidDomainLevelError exceptions --- ipalib/plugins/domainlevel.py | 4 ++-- ipalib/plugins/topology.py| 4

Re: [Freeipa-devel] [PATCH 0052] Create server-dns sub-package

2015-07-17 Thread Tomas Babej
On 07/17/2015 05:46 AM, Jan Cholasta wrote: Dne 16.7.2015 v 16:50 Alexander Bokovoy napsal(a): On Thu, 16 Jul 2015, Petr Spacek wrote: Third version of the patch is attached, please view. Behavior: - freeipa-server package continues to exist and does not include DNS dependencies -

Re: [Freeipa-devel] [PATCH] 904 do not import memcache on client

2015-07-16 Thread Tomas Babej
On 07/16/2015 10:25 AM, Petr Vobornik wrote: Fixes regression caused by cd3ca94ff2ef738cb3a9eae502193413058f976d. Which caused: * client installation failure (missing memcache) * invalid warning in CLI on server https://fedorahosted.org/freeipa/ticket/5133 Thanks for fixing this

Re: [Freeipa-devel] [PATCH] 0191 Add SELinux boolean for oddjobd-activated services

2015-07-16 Thread Tomas Babej
On 07/14/2015 01:31 PM, Alexander Bokovoy wrote: Hi! An SELinux policy we need for one-way trust is now in Fedora updates-testing repository. Attached patch adds support for 'httpd_run_ipa' SELinux boolean. Below is how one-way trust is using the communication with oddjobd (it is a

[Freeipa-devel] [PATCH 0340] dcerpc: Expand explanation for WERR_ACCESS_DENIED

2015-07-16 Thread Tomas Babej
From: Tomas Babej tba...@redhat.com Date: Wed, 15 Jul 2015 15:38:50 +0200 Subject: [PATCH] dcerpc: Expand explanation for WERR_ACCESS_DENIED It's possible for AD to contact a wrong IPA server in case the DNS SRV records on the AD sides are not properly configured. Mention this case in the error

Re: [Freeipa-devel] [PATCH 012] Fix selinux denial during kdcproxy user creation

2015-07-16 Thread Tomas Babej
On 07/16/2015 12:51 PM, Christian Heimes wrote: Hi, the patch fixes the SELinux denial for kdcproxy's home directory. I have successfully tested a migration from FreeIPA 4.1. The user, group and home directory are successfully created with the correct permissions.

Re: [Freeipa-devel] 4.3 Branch?

2015-07-16 Thread Tomas Babej
On 07/16/2015 01:13 PM, Petr Vobornik wrote: On 07/14/2015 03:23 PM, Nathaniel McCallum wrote: 4.3 is going to be a very narrow feature release. Should we branch 4.3 early so that we can still land new features on master during 4.3? I did not like it at first but we should do it. We

Re: [Freeipa-devel] [PATCH] 0192 oddjob: avoid chown keytab to sssd if sssd user does not exist

2015-07-16 Thread Tomas Babej
On 07/16/2015 01:19 PM, Alexander Bokovoy wrote: Hi, a simple optimisation to allow FreeIPA 4.2 to work with SSSD 1.13 running as root instead of sssd user. Details in the commit message. This also fixes a simple exception in current Fedora 22 + mkosek/freeipa-4.2 repo because user

Re: [Freeipa-devel] [PATCH 012] Fix selinux denial during kdcproxy user creation

2015-07-16 Thread Tomas Babej
On 07/16/2015 01:35 PM, Christian Heimes wrote: On 2015-07-16 12:51, Christian Heimes wrote: Hi, the patch fixes the SELinux denial for kdcproxy's home directory. I have successfully tested a migration from FreeIPA 4.1. The user, group and home directory are successfully created with the

Re: [Freeipa-devel] [PATCH 0339] trusts: Check for AD root domain among our trusted domains

2015-07-15 Thread Tomas Babej
On 07/15/2015 02:31 PM, Alexander Bokovoy wrote: On Wed, 15 Jul 2015, Tomas Babej wrote: Hi, Check for the presence of the forest root DNS domain of the AD realm among the IPA realm domains prior to esablishing the trust. This prevents creation of a failing setup, as trusts would not work

[Freeipa-devel] [PATCH 0339] trusts: Check for AD root domain among our trusted domains

2015-07-15 Thread Tomas Babej
03dabf99d538747051f1c898e6a58162425e7b28 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 15 Jul 2015 14:22:48 +0200 Subject: [PATCH] trusts: Check for AD root domain among our trusted domains Check for the presence of the forest root DNS domain of the AD realm among the IPA realm domains

Re: [Freeipa-devel] [PATCH 011] [py3] Replace file() with open()

2015-07-14 Thread Tomas Babej
On 07/14/2015 01:29 PM, Christian Heimes wrote: On 2015-07-14 13:24, Christian Heimes wrote: The patch replaces file() with open() and a proper with statement. The patch is related to https://fedorahosted.org/freeipa/ticket/5127 Christian The first patch has a typo. Note to self:

Re: [Freeipa-devel] [PATCH 007-010] Remove tuple unpacking from except clause

2015-07-14 Thread Tomas Babej
On 07/14/2015 12:45 PM, Alexander Bokovoy wrote: On Tue, 14 Jul 2015, Christian Heimes wrote: On 2015-07-13 16:29, Alexander Bokovoy wrote: I will pushmark the commit there. Please do not push this specific version of the patch yet. Christian will do the changes with four separate commits

Re: [Freeipa-devel] [PATCH 007] Remove tuple unpacking from except clause

2015-07-13 Thread Tomas Babej
On 07/13/2015 02:59 PM, Rob Crittenden wrote: Christian Heimes wrote: The patch replaces implicit tuple unpacking from except clauses with explicit unpacking of the exception objects' args attribute. Example: e = RuntimeError('num', 'messages') num, message = e num, message ('num',

Re: [Freeipa-devel] [PATCH] 0001 Enhance the DNSNotARecordError message

2015-07-10 Thread Tomas Babej
On 07/09/2015 01:49 PM, Veronika Kabatova wrote: The attached patch solves the https://fedorahosted.org/freeipa/ticket/3959 ticket. Veronika Kabatova Hello, thanks for the patch. Actually, the doctest does not pass: $ ipa-run-tests

Re: [Freeipa-devel] [PATCH 0334] Hide topology and domainlevel features

2015-07-10 Thread Tomas Babej
On 07/10/2015 03:07 PM, Simo Sorce wrote: On Wed, 2015-07-08 at 00:09 +0200, Tomas Babej wrote: On 07/07/2015 07:16 PM, Martin Basti wrote: On 07/07/15 10:33, Tomas Babej wrote: Hi, * Hide topology and domainlevel commands in the CLI * Hide topology and domainlevel in the WebUI * Set

Re: [Freeipa-devel] [patch 0006] ipalib: pass api instance into textui in doctest snippets

2015-07-10 Thread Tomas Babej
On 07/10/2015 02:15 PM, Milan Kubik wrote: On 07/10/2015 01:57 PM, Milan Kubik wrote: Hi, the recent set of patches that modified api broke the tests that are included in ipalib/cli.py This patch fixes the problems by passing api instance to textui() calls. Milan This may not be the

[Freeipa-devel] [PATCH 0337] ipalib: Fix missing format for InvalidDomainLevelError

2015-07-10 Thread Tomas Babej
: Tomas Babej tba...@redhat.com Date: Fri, 10 Jul 2015 14:59:21 +0200 Subject: [PATCH] ipalib: Fix missing format for InvalidDomainLevelError --- ipalib/errors.py | 1 + 1 file changed, 1 insertion(+) diff --git a/ipalib/errors.py b/ipalib/errors.py index d874e68829e1a5491dec402d5976c3adfa556e84

Re: [Freeipa-devel] [PATCH 0338] Revert Hide topology and domainlevel features

2015-07-10 Thread Tomas Babej
On 07/10/2015 03:25 PM, Simo Sorce wrote: On Fri, 2015-07-10 at 15:18 +0200, Tomas Babej wrote: Hi, This reverts commit 62e8002bc43ddd890c3db35a123cb7daf35e3121. Hiding of the topology and domainlevel features was necessary for the 4.2 branch only. Tomas ACK Simo, Pushed

[Freeipa-devel] [PATCH 0338] Revert Hide topology and domainlevel features

2015-07-10 Thread Tomas Babej
Hi, This reverts commit 62e8002bc43ddd890c3db35a123cb7daf35e3121. Hiding of the topology and domainlevel features was necessary for the 4.2 branch only. Tomas From 89e55240b3e3820b42e85b63cd1849816690321a Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Fri, 10 Jul 2015 15:16

Re: [Freeipa-devel] [PATCH] 901 Bump 4.3 development version to 4.2.90

2015-07-09 Thread Tomas Babej
On 07/09/2015 12:36 PM, Petr Vobornik wrote: ACK, pushed to master: 0569910fead3b33a0806b216823738cf17283108 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 463] spec file: Update minimal versions of required packages

2015-07-08 Thread Tomas Babej
On 07/08/2015 01:28 PM, Alexander Bokovoy wrote: On Wed, 08 Jul 2015, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/5103. ACK. Pushed to master: 7c0e7f7e3ca3a971d4db64f80f02d4f79e5f5c4d -- Manage your subscription for the Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] 0026..0027 #5096 enforce caacl for SAN principals

2015-07-08 Thread Tomas Babej
On 07/08/2015 04:30 PM, David Kupka wrote: On 03/07/15 16:26, Fraser Tweedale wrote: The attached patches fix: - a bug that caused caacl false negatives for hosts principals - #5096 cert-request: enforce caacl for subjectAltName principals Thanks, Fraser Works for me, ACK. Pushed

Re: [Freeipa-devel] [PATCH 0278] Fix API logging

2015-07-08 Thread Tomas Babej
On 07/08/2015 02:18 PM, Martin Basti wrote: log must be initilized before first usage in API, otherwise traceback is shown: # ipa -e random-nonexistent-key=1 user-find Traceback (most recent call last): File /bin/ipa, line 32, in module cli.run(api) File

Re: [Freeipa-devel] [PATCHES 0335-0336] adtrustinstance: Enable and start oddjobd

2015-07-08 Thread Tomas Babej
On 07/08/2015 05:12 PM, Alexander Bokovoy wrote: On Wed, 08 Jul 2015, Tomas Babej wrote: From 66d39f12a77d23e8d8ac2c11650258ed9f3eb200 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 8 Jul 2015 15:44:13 +0200 Subject: [PATCH] adtrustinstance: Enable and start oddjobd

[Freeipa-devel] [PATCHES 0335-0336] adtrustinstance: Enable and start oddjobd

2015-07-08 Thread Tomas Babej
Hi, Enable and start the oddjobd service as part of the ipa-adtrust-install for the new IPA installations and upgraded ones. Tomas From 66d39f12a77d23e8d8ac2c11650258ed9f3eb200 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 8 Jul 2015 15:44:13 +0200 Subject: [PATCH

Re: [Freeipa-devel] [PATCH] 894-896 webui: certificate profiles and acls

2015-07-08 Thread Tomas Babej
On 07/08/2015 04:54 PM, Martin Basti wrote: On 08/07/15 15:11, Petr Vobornik wrote: On 07/08/2015 02:24 PM, Petr Vobornik wrote: add Web UI for new certificate objects [PATCH] 894 webui: certificate profiles [PATCH] 895 webui: caacl [PATCH] 896 webui: hide facet tab in certificate details

Re: [Freeipa-devel] [PATCH] 893 move session_logout command to ipalib/plugins directory

2015-07-08 Thread Tomas Babej
On 07/08/2015 02:33 PM, Martin Basti wrote: On 08/07/15 13:46, Petr Vobornik wrote: On 07/08/2015 01:20 PM, Martin Basti wrote: On 08/07/15 12:51, Martin Basti wrote: On 08/07/15 12:20, Petr Vobornik wrote: On 07/08/2015 10:37 AM, Petr Vobornik wrote: API refactoring caused that

Re: [Freeipa-devel] [MAN] [PATCH] 0004 Fix phrasing in man page for stageuser.py

2015-07-07 Thread Tomas Babej
On 07/04/2015 02:03 PM, Jérôme Fenal wrote: Hi all, A quick patch to the man page part of stageuser to avoid ambiguity in the phrasing, spotted while translating the page. Regards, J. Thanks, ACK. I will not push this patch to master until we branch off 4.2 development branch

Re: [Freeipa-devel] [PATCHES 0252-0253, 268, 50 - 51] DNSSEC: allow to move DNSSEC key master to another IPA server

2015-07-07 Thread Tomas Babej
On 07/01/2015 12:47 PM, Petr Spacek wrote: On 1.7.2015 12:35, Martin Basti wrote: On 30/06/15 22:09, Petr Spacek wrote: On 30.6.2015 16:04, Martin Basti wrote: On 30/06/15 10:25, Martin Basti wrote: On 29/06/15 15:16, Martin Basti wrote: On 25/06/15 13:46, Petr Spacek wrote: On 17.6.2015

Re: [Freeipa-devel] [PATCH] 892 webui: add mangedby tab to otptoken

2015-07-07 Thread Tomas Babej
On 07/03/2015 02:49 PM, Martin Babinsky wrote: On 07/01/2015 06:59 PM, Petr Vobornik wrote: Added managedby_user tab to manage users who can manage the token. https://fedorahosted.org/freeipa/ticket/5003 Nathaniel, I could not reproduce the following part of the ticket: Careful

[Freeipa-devel] [PATCH 0334] Hide topology and domainlevel features

2015-07-07 Thread Tomas Babej
:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 7 Jul 2015 09:36:32 +0200 Subject: [PATCH] Hide topology and domainlevel features * Hide topology and domainlevel commands in the CLI * Hide topology and domainlevel in the WebUI * Set maximum allowed domain level to 0 * Do not configure

Re: [Freeipa-devel] [PATCHES 330-331] Update translations and introduce Zanata configuration

2015-07-07 Thread Tomas Babej
On 07/07/2015 09:09 AM, Tomas Babej wrote: On 06/24/2015 04:33 PM, Tomas Babej wrote: On 06/24/2015 04:29 PM, Martin Basti wrote: On 24/06/15 14:39, Tomas Babej wrote: +msgid Automount location name. +msgstr Job Title + in german po file +msgid Automount location name. +msgstr Job

Re: [Freeipa-devel] [PATCH 0276] Fix: ipa-dns-install will add CA records if CA is installed

2015-07-07 Thread Tomas Babej
On 07/07/2015 07:36 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5101 Patch attached. ACK. Pushed to master: 1d9bdb240943527e1e19704acd183eae254267ae -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0046] add option to skip client API version check and proceed at user's own risk

2015-07-07 Thread Tomas Babej
On 07/07/2015 07:49 PM, Martin Basti wrote: On 03/07/15 16:41, Martin Babinsky wrote: On 07/02/2015 01:58 PM, Martin Babinsky wrote: First attempt at https://fedorahosted.org/freeipa/ticket/4768 Attaching reworked patch. ACK -- Martin Basti Pushed to master:

Re: [Freeipa-devel] [PATCH 0334] Hide topology and domainlevel features

2015-07-07 Thread Tomas Babej
On 07/07/2015 07:16 PM, Martin Basti wrote: On 07/07/15 10:33, Tomas Babej wrote: Hi, * Hide topology and domainlevel commands in the CLI * Hide topology and domainlevel in the WebUI * Set maximum allowed domain level to 0 * Do not configure and enable the topology plugin https

Re: [Freeipa-devel] [PATCHES 145-148] ipa-kdb: add unit-test for filter_logon_info()

2015-07-07 Thread Tomas Babej
On 07/07/2015 03:49 PM, Sumit Bose wrote: On Tue, May 26, 2015 at 01:36:35PM +0200, Martin Kosek wrote: On 05/26/2015 01:33 PM, Sumit Bose wrote: Hi, these patches add some unit tests and some additional improvements related to the issues described in

Re: [Freeipa-devel] [PATCH 144] extdom: add unit-test for get_user_grouplist()

2015-07-07 Thread Tomas Babej
On 07/07/2015 03:47 PM, Sumit Bose wrote: On Tue, May 26, 2015 at 02:47:02PM +0300, Alexander Bokovoy wrote: On Tue, 26 May 2015, Sumit Bose wrote: On Tue, May 26, 2015 at 01:24:30PM +0200, Petr Vobornik wrote: On 05/26/2015 01:21 PM, Sumit Bose wrote: Hi, this tests should have gone

<    1   2   3   4   5   6   7   8   9   10   >