Re: [Freeipa-devel] [test][patch-0057] test for ticket N 6146 (installing rules with service principals)

2016-11-10 Thread Oleg Fayans
The patch was added to existing PR: https://github.com/freeipa/freeipa/pull/224 On 11/08/2016 05:24 PM, Oleg Fayans wrote: And this one. On 11/03/2016 09:42 AM, Oleg Fayans wrote: One more ping for review On 10/27/2016 02:21 PM, Oleg Fayans wrote: ping for review On 10/25/2016 11:29 AM

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-11-10 Thread Oleg Fayans
All the patches from this thread were converted into github pull requests: [1]: https://github.com/freeipa/freeipa/pull/224 [2]: https://github.com/freeipa/freeipa/pull/225 On 11/09/2016 04:43 PM, Milan KubĂ­k wrote: On 10/25/2016 10:24 AM, Oleg Fayans wrote: Integration part of the tests

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-11-10 Thread Oleg Fayans
Because patches are scattered over this thread, am I right that those versions should be pushed? freeipa-ofayans-0047.7-Automated-clean-ruv-subcommand-tests.patch freeipa-ofayans-0048.4-Automated-ipa-replica-manage-del-tests.patch Precisely! Martin^2 -- Oleg Fayans Quality Engineer FreeIPA team

Re: [Freeipa-devel] [test][patch-0057] test for ticket N 6146 (installing rules with service principals)

2016-11-08 Thread Oleg Fayans
And this one. On 11/03/2016 09:42 AM, Oleg Fayans wrote: One more ping for review On 10/27/2016 02:21 PM, Oleg Fayans wrote: ping for review On 10/25/2016 11:29 AM, Oleg Fayans wrote: The patch was rebased to be able to apply on top of latest version of certs in idoverrides patch. As before

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-11-08 Thread Oleg Fayans
Never give up pinging :) On 11/03/2016 12:43 PM, Martin Basti wrote: LGTM On 03.11.2016 09:42, Oleg Fayans wrote: One more ping for review On 10/27/2016 02:21 PM, Oleg Fayans wrote: ping for review On 10/25/2016 10:24 AM, Oleg Fayans wrote: Integration part of the tests is ready. 2 tests

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-11-08 Thread Oleg Fayans
another ping for review On 11/08/2016 09:32 AM, Oleg Fayans wrote: Ping for review On 11/03/2016 04:56 PM, Oleg Fayans wrote: Hi Martin, The commit message was updated with the correct ticket link Thanks for review! On 11/03/2016 04:22 PM, Martin Basti wrote: almost ACK, but the ticket

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-11-08 Thread Oleg Fayans
Ping for review On 11/03/2016 04:56 PM, Oleg Fayans wrote: Hi Martin, The commit message was updated with the correct ticket link Thanks for review! On 11/03/2016 04:22 PM, Martin Basti wrote: almost ACK, but the ticket in commit message is closed as invalid. So I'm quite puzzled now what

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-11-03 Thread Oleg Fayans
Hi Martin, The commit message was updated with the correct ticket link Thanks for review! On 11/03/2016 04:22 PM, Martin Basti wrote: almost ACK, but the ticket in commit message is closed as invalid. So I'm quite puzzled now what to do. On 03.11.2016 13:28, Oleg Fayans wrote: ping

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-11-03 Thread Oleg Fayans
ping for review On 10/19/2016 04:54 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. Fixed both issues. $ ipa-run-tests test_integration/test_topology.py -k TestCASpecificRUVs WARNING: Couldn't write lextab module 'pycparser.lextab'. [Errno 13] Permission denied: 'lextab.py' WARNING

Re: [Freeipa-devel] [test][patch-0057] test for ticket N 6146 (installing rules with service principals)

2016-11-03 Thread Oleg Fayans
One more ping for review On 10/27/2016 02:21 PM, Oleg Fayans wrote: ping for review On 10/25/2016 11:29 AM, Oleg Fayans wrote: The patch was rebased to be able to apply on top of latest version of certs in idoverrides patch. As before, it requires patches NN 0049 and 0059 to apply On 08/10

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-11-03 Thread Oleg Fayans
One more ping for review On 10/27/2016 02:21 PM, Oleg Fayans wrote: ping for review On 10/25/2016 10:24 AM, Oleg Fayans wrote: Integration part of the tests is ready. 2 tests: 1. Adds a cert to idoverride of a windows user 2. sssd part - looks up user by his certificate using dbus-sssd

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-30 Thread Oleg Fayans
ping for review On 10/25/2016 10:24 AM, Oleg Fayans wrote: Integration part of the tests is ready. 2 tests: 1. Adds a cert to idoverride of a windows user 2. sssd part - looks up user by his certificate using dbus-sssd Second and third dbus call are executed as a string insted of as array

Re: [Freeipa-devel] [test][patch-0057] test for ticket N 6146 (installing rules with service principals)

2016-10-30 Thread Oleg Fayans
ping for review On 10/25/2016 11:29 AM, Oleg Fayans wrote: The patch was rebased to be able to apply on top of latest version of certs in idoverrides patch. As before, it requires patches NN 0049 and 0059 to apply On 08/10/2016 01:46 PM, Oleg Fayans wrote: Hi Martin, I am sorry, yes

Re: [Freeipa-devel] [test][patch-0057] test for ticket N 6146 (installing rules with service principals)

2016-10-25 Thread Oleg Fayans
The patch was rebased to be able to apply on top of latest version of certs in idoverrides patch. As before, it requires patches NN 0049 and 0059 to apply On 08/10/2016 01:46 PM, Oleg Fayans wrote: Hi Martin, I am sorry, yes it depends on my patches 0049 and 0050. On 08/10/2016 12:27 PM

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-25 Thread Oleg Fayans
2 passed in 948.44 seconds = On 10/21/2016 10:54 AM, Oleg Fayans wrote: Added one more test, resolved the pep8 issues On 10/19/2016 12:32 PM, Oleg Fayans wrote: Hi Martin, As you suggested, I've extended the test_xmlrpc/test_add_remove_cert_cmd.py to con

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-21 Thread Oleg Fayans
Added one more test, resolved the pep8 issues On 10/19/2016 12:32 PM, Oleg Fayans wrote: Hi Martin, As you suggested, I've extended the test_xmlrpc/test_add_remove_cert_cmd.py to contain basic tests for certs in idoverrides. The integration part still needs some polishing in the part related

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-19 Thread Oleg Fayans
;) E TypeError: argument of type 'SSHCommand' is not iterable test_integration/test_topology.py:215: TypeError entering PDB /usr/lib/python2.7/site-packages/ipatests/test_integration/test_topology.py(215)test_delete_ruvs() -> assert(res1.stdout_text.count(replica.hostname) == 2 and

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-19 Thread Oleg Fayans
:48 PM, Oleg Fayans wrote: So, did I understand correctly, that there would be 2 patches: one containing test for basic idoverrides functionality without AD-integration, and the second one - with AD-integration and an sssd check, correct? I guess, the freeipa-ofayans-0050.1-Automated-test-for-certs

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-14 Thread Oleg Fayans
for the "real" part. So, I'll add the cert manipulation tests to the xmlrpc test. On 10/14/2016 03:57 PM, Martin Babinsky wrote: On 10/14/2016 03:48 PM, Oleg Fayans wrote: So, did I understand correctly, that there would be 2 patches: one containing test for basic idoverrides functionality

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-10-14 Thread Oleg Fayans
-feature.patch might be a good candidate for the first one, I only have to change the filename to test_idviews.py, right? On 09/15/2016 10:32 AM, Martin Basti wrote: On 15.09.2016 10:10, Oleg Fayans wrote: Hi Martin, The file was renamed. Did I understand correctly that for now we are leaving

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-14 Thread Oleg Fayans
Right you are! I am sorry. On 10/13/2016 06:10 PM, Martin Basti wrote: I think that you forgot to squash commits. Patch 47 doesn't apply On 13.10.2016 14:01, Oleg Fayans wrote: Hi Martin, Thanks for the review. With disabling directory server it works as well, thanks for the hint. Also I

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-13 Thread Oleg Fayans
on replica instead of doing iptables magic? 2) NACK No more eval() ever in code, use 'getattr', 'get' or whatever in the object that can be used. +evalhost = eval("args[0].%s" % host) Martin^2 On 12.10.2016 14:03, Oleg Fayans wrote: Hi Martin, After extensive

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-12 Thread Oleg Fayans
:_clean-ruv_subcommand On 08/05/2016 06:36 PM, Martin Basti wrote: On 03.08.2016 14:45, Oleg Fayans wrote: Hi Martin, Thanks for the review! Both patches were updated. On 07/28/2016 04:11 PM, Martin Basti wrote: On 08.07.2016 15:41, Oleg Fayans wrote: Hi Martin, Thanks for the review

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-07 Thread Oleg Fayans
Hi Ludwig, Thanks for the clarification! But then why does CSRUV allows to be deleted on a working replica? Shouldn't we keep this behavior somehow consistent? On 10/07/2016 09:29 AM, Ludwig Krispenz wrote: On 09/13/2016 10:10 AM, Oleg Fayans wrote: Hi Ludwig, The ipa-replica-manage

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-07 Thread Oleg Fayans
Ping for review On 10/05/2016 12:02 PM, Oleg Fayans wrote: Hi Ludwig, Could you please take a look at it when you have time? On 09/13/2016 10:10 AM, Oleg Fayans wrote: Hi Ludwig, The ipa-replica-manage clean-ruv sometimes does not quite work. For example: I have a master and 2 replicas

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-10-05 Thread Oleg Fayans
Hi Ludwig, Could you please take a look at it when you have time? On 09/13/2016 10:10 AM, Oleg Fayans wrote: Hi Ludwig, The ipa-replica-manage clean-ruv sometimes does not quite work. For example: I have a master and 2 replicas. Initial output of 'ipa-replica-manage list-ruv' looks like

Re: [Freeipa-devel] [PATCH] ca-less tests updated

2016-09-22 Thread Oleg Fayans
Fixed patch N 41 On 09/21/2016 04:21 PM, Oleg Fayans wrote: Patch-0076 rebased to current master On 09/21/2016 02:41 PM, Oleg Fayans wrote: Hi David, As per your comments the patches were once again refactored. I am attaching the full set of them, please ignore any previous versions

Re: [Freeipa-devel] [PATCH] ca-less tests updated

2016-09-21 Thread Oleg Fayans
Patch-0076 rebased to current master On 09/21/2016 02:41 PM, Oleg Fayans wrote: Hi David, As per your comments the patches were once again refactored. I am attaching the full set of them, please ignore any previous versions The patches apply cleanly on master and pylint swallows the resulting

Re: [Freeipa-devel] [PATCH] ca-less tests updated

2016-09-21 Thread Oleg Fayans
ify_installation called only in DOMAIN_LEVEL_0. - 4 - TestCertinstall.install - 5 - TestCertinstall.certinstall 0072 - 0077 - LGTM On 09/09/16 15:22, Oleg Fayans wrote: Hi David, team According to your suggestions I've splitted my commits so that each commit addresses some particular problem.

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-15 Thread Oleg Fayans
/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 1a0039b64023b0bb3c9289128413b4ccef489ec4 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Tue, 6 Sep 2016 13:55:16 +0200 Subject:

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Oleg Fayans
Ping for review. On 09/06/2016 01:57 PM, Oleg Fayans wrote: The test is updated to clean up after itself On 09/06/2016 12:57 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. The updated patches are attached. Please, see my comments below On 08/30/2016 01:58 PM, Martin Basti wrote

Re: [Freeipa-devel] [Test][patch-0058] Fixed topology tests failures in CI

2016-09-14 Thread Oleg Fayans
Again ping for review, please it completely blocks the whole job. On 09/07/2016 03:27 PM, Oleg Fayans wrote: ping for review On 08/24/2016 01:58 PM, Oleg Fayans wrote: And here is how the run looks like: $ ipa-run-tests test_integration/test_topology.py WARNING: Couldn't write lextab module

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-09-13 Thread Oleg Fayans
, Martin Basti wrote: On 03.08.2016 14:45, Oleg Fayans wrote: Hi Martin, Thanks for the review! Both patches were updated. On 07/28/2016 04:11 PM, Martin Basti wrote: On 08.07.2016 15:41, Oleg Fayans wrote: Hi Martin, Thanks for the review! On 07/08/2016 02:18 PM, Martin Basti wrote

Re: [Freeipa-devel] [PATCH] ca-less tests updated

2016-09-09 Thread Oleg Fayans
like weird workaround to me. It would be better to investigate the root cause and fix it. Or at least describe the cause in commit message and code comment if it can't be fixed. Also "-h is deprecated in favor of -H" says man 1 ldapmodify. On 05/09/16 14:32, Oleg Fayans wrote: Hi guys, Final

Re: [Freeipa-devel] [Test][patch-0058] Fixed topology tests failures in CI

2016-09-07 Thread Oleg Fayans
ping for review On 08/24/2016 01:58 PM, Oleg Fayans wrote: And here is how the run looks like: $ ipa-run-tests test_integration/test_topology.py WARNING: Couldn't write lextab module 'pycparser.lextab'. [Errno 13] Permission denied: 'lextab.py' WARNING: yacc table file version is out of date

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-06 Thread Oleg Fayans
The test is updated to clean up after itself On 09/06/2016 12:57 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. The updated patches are attached. Please, see my comments below On 08/30/2016 01:58 PM, Martin Basti wrote: On 22.08.2016 13:18, Oleg Fayans wrote: ping for review

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-06 Thread Oleg Fayans
in 681.90 seconds = On 09/06/2016 12:57 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. The updated patches are attached. Please, see my comments below On 08/30/2016 01:58 PM, Martin Basti wrote

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-06 Thread Oleg Fayans
Hi Martin, Thanks for the review. The updated patches are attached. Please, see my comments below On 08/30/2016 01:58 PM, Martin Basti wrote: On 22.08.2016 13:18, Oleg Fayans wrote: ping for review On 08/02/2016 01:11 PM, Oleg Fayans wrote: Hi Martin, I did! Thank you! On 08/02/2016

Re: [Freeipa-devel] [PATCH] ca-less tests updated

2016-09-05 Thread Oleg Fayans
Hi guys, Finally the ca-less tests are stable. Here in the attachment is the full set of necessary patches. On 08/09/2016 10:57 AM, Oleg Fayans wrote: Hi all, Bump for the review of the 0013 patch. The script it addresses can be reused in some WebUI tests - one more reason to have

Re: [Freeipa-devel] [Test][patch-0061] Fixed error in teardown method of replica_promotion tests

2016-08-30 Thread Oleg Fayans
Bump for review. Other tests depend on this fix too, like replication_layouts_domainlevel_1 On 08/24/2016 04:26 PM, Oleg Fayans wrote: -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman

Re: [Freeipa-devel] [Test][patch-0058] Fixed topology tests failures in CI

2016-08-24 Thread Oleg Fayans
: On 12.08.2016 15:48, Oleg Fayans wrote: Hi Martin, On 08/11/2016 10:05 AM, Martin Basti wrote: On 10.08.2016 20:32, Oleg Fayans wrote: Hello, before we jump into fixing tests, my question is: Was this planned change and not reflected by test, or switched values are unwanted side effect

Re: [Freeipa-devel] [Test][patch-0058] Fixed topology tests failures in CI

2016-08-24 Thread Oleg Fayans
=== On 08/12/2016 04:05 PM, Martin Basti wrote: On 12.08.2016 15:48, Oleg Fayans wrote: Hi Martin, On 08/11/2016 10:05 AM, Martin Basti wrote: On 10.08.2016 20:32, Oleg Fayans wrote: Hello, before we jump into fixing tests

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-08-22 Thread Oleg Fayans
ping for review On 08/02/2016 01:11 PM, Oleg Fayans wrote: Hi Martin, I did! Thank you! On 08/02/2016 12:31 PM, Martin Basti wrote: On 01.08.2016 22:46, Oleg Fayans wrote: The test was redesigned so that it actually tests against an AD user. cleanly applies, passes lint and passes https

[Freeipa-devel] default debug_level of sssd

2016-08-15 Thread Oleg Fayans
that we probably never gonna need. We'd like to tweak the tests to configure sssd for less logging, but I was unable to find info on default debug_level. The sssd configuration file does not explicitly specify it. Thanks! -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your

Re: [Freeipa-devel] [Test][patch-0058] Fixed topology tests failures in CI

2016-08-12 Thread Oleg Fayans
Hi Martin, On 08/11/2016 10:05 AM, Martin Basti wrote: On 10.08.2016 20:32, Oleg Fayans wrote: Hello, before we jump into fixing tests, my question is: Was this planned change and not reflected by test, or switched values are unwanted side effect and thus bug for us? That's

[Freeipa-devel] [Test][patch-0058] Fixed topology tests failures in CI

2016-08-10 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 3befa8b390e4c5c02c81ad2efee19acc237c9222 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Wed, 10 Aug 2016 20:30:31 +0200 Subject: [PATCH] Fixed expected segment name Lately replica installation results in cr

Re: [Freeipa-devel] [test][patch-0057] test for ticket N 6146 (installing rules with service principals)

2016-08-10 Thread Oleg Fayans
Hi Martin, I am sorry, yes it depends on my patches 0049 and 0050. On 08/10/2016 12:27 PM, Martin Basti wrote: On 10.08.2016 10:38, Oleg Fayans wrote: Hello, I cannot apply this patch error: ipatests/test_integration/test_certs_in_idoverrides.py: does not exist in index It probably

[Freeipa-devel] [test][patch-0057] test for ticket N 6146

2016-08-10 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From a33a5aea0f12f63d53ff773b3d5e615b1f582d7f Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Wed, 10 Aug 2016 10:29:59 +0200 Subject: [PATCH] Test for installing rules with service principals https://fedorahost

Re: [Freeipa-devel] [PATCH] ca-less tests updated

2016-08-09 Thread Oleg Fayans
Hi all, Bump for the review of the 0013 patch. The script it addresses can be reused in some WebUI tests - one more reason to have it reviewed/merged The rest patches should be re-tested, since they were prepared a good while ago On 05/10/2016 05:08 PM, Oleg Fayans wrote: Hi David, After

[Freeipa-devel] [Test][patch-0056] Fixed incorrect returncode assert in test

2016-08-04 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 8b8732c3d86820124c117c88c6f892d9bb41cbc3 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Thu, 4 Aug 2016 12:42:23 +0200 Subject: [PATCH] Fixed incorrect return code assert The assert checked that the retu

[Freeipa-devel] [Tests][patch-0066] Fixed incorrect domainlevel determination in integration tests

2016-08-04 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 2deee8b3baeb091904eb7c2ba61b90e669cc8df2 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Thu, 4 Aug 2016 09:22:31 +0200 Subject: [PATCH] Fixed incorrect domainlevel determination in tests https://fedorahost

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-08-03 Thread Oleg Fayans
Hi Martin, Thanks for the review! Both patches were updated. On 07/28/2016 04:11 PM, Martin Basti wrote: On 08.07.2016 15:41, Oleg Fayans wrote: Hi Martin, Thanks for the review! On 07/08/2016 02:18 PM, Martin Basti wrote: On 27.06.2016 13:53, Oleg Fayans wrote: Hi guys

Re: [Freeipa-devel] [Test][Patch-0051] Fixed import error in replica promotion test

2016-08-03 Thread Oleg Fayans
Hi Martin, The commit message was extended. Thanks for the review! On 08/03/2016 10:36 AM, Martin Basti wrote: On 03.08.2016 09:55, Oleg Fayans wrote: ping for review On 06/28/2016 04:01 PM, Oleg Fayans wrote: ACK, if you improve commit messages -- Oleg Fayans Quality Engineer

Re: [Freeipa-devel] [Test][Patch-0051] Fixed import error in replica promotion test

2016-08-03 Thread Oleg Fayans
ping for review On 06/28/2016 04:01 PM, Oleg Fayans wrote: -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-08-02 Thread Oleg Fayans
Hi Martin, I did! Thank you! On 08/02/2016 12:31 PM, Martin Basti wrote: On 01.08.2016 22:46, Oleg Fayans wrote: The test was redesigned so that it actually tests against an AD user. cleanly applies, passes lint and passes https://paste.fedoraproject.org/399504/00843641/ Okay Did you

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-08-01 Thread Oleg Fayans
The test was redesigned so that it actually tests against an AD user. cleanly applies, passes lint and passes https://paste.fedoraproject.org/399504/00843641/ On 06/28/2016 01:40 PM, Oleg Fayans wrote: Patch-0050 rebased against latest upstream branch On 06/28/2016 10:45 AM, Oleg Fayans

Re: [Freeipa-devel] [PATCH 0024][Tests] Fix integration tests not to produce incorrect /etc/hosts file

2016-08-01 Thread Oleg Fayans
ACK On 07/19/2016 01:19 PM, Lenka Doudova wrote: On 06/29/2016 06:49 PM, Petr Spacek wrote: On 29.6.2016 18:39, Oleg Fayans wrote: In fact, I believe /etc/hosts file should not be touched at all. Hostname resolution is usually governed by the DNS system of the lab in which tests are running

Re: [Freeipa-devel] [Test][patch-0053] Forced-client-reenrollment test fixed.

2016-07-26 Thread Oleg Fayans
Here is the test output: https://paste.fedoraproject.org/395706/69538081/ On 07/26/2016 03:34 PM, Oleg Fayans wrote: Hi Martin, The patch was updated according to your suggestions. A separate patch removing outdated tests is attached. On 07/08/2016 02:10 PM, Martin Basti wrote

Re: [Freeipa-devel] [Test][patch-0053] Forced-client-reenrollment test fixed.

2016-07-26 Thread Oleg Fayans
Hi Martin, The patch was updated according to your suggestions. A separate patch removing outdated tests is attached. On 07/08/2016 02:10 PM, Martin Basti wrote: On 07.07.2016 08:09, Oleg Fayans wrote: Updated version of the patch is attached with the failing tests marked as xfailed

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-07-08 Thread Oleg Fayans
Hi Martin, Thanks for the review! On 07/08/2016 02:18 PM, Martin Basti wrote: On 27.06.2016 13:53, Oleg Fayans wrote: Hi guys, Is there a chance the patches NN 0047.1 and 0048.1 get reviewed before 4.4 release? They cover a good part of the Managed Topology 4.4 feature. On 06/17/2016 11

Re: [Freeipa-devel] [Test][patch-0053] Forced-client-reenrollment test fixed.

2016-07-07 Thread Oleg Fayans
Updated version of the patch is attached with the failing tests marked as xfailed (let's make the jenkins green). On 07/04/2016 10:50 PM, Oleg Fayans wrote: 2 out of 7 tests currently fail due to a known issue [1], others pass. [1] https://fedorahosted.org/freeipa/ticket/6029 -- Oleg

[Freeipa-devel] [Test][patch-0053] Forced-client-reenrollment test fixed.

2016-07-04 Thread Oleg Fayans
2 out of 7 tests currently fail due to a known issue [1], others pass. [1] https://fedorahosted.org/freeipa/ticket/6029 -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From b19ef400462c722976aea5d2eb853315af1e1099 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Dat

Re: [Freeipa-devel] [Test][patch-0052] Test for incorrect client domain

2016-07-01 Thread Oleg Fayans
Hi Martin, Thanks for the review. The updated patch is attached On 07/01/2016 04:09 PM, Martin Basti wrote: > > > On 01.07.2016 14:38, Oleg Fayans wrote: >> Hi Martin. Now I have this client installation thing sorted out. The >> test works as expected >> >> On

Re: [Freeipa-devel] [Test][patch-0052] Test for incorrect client domain

2016-07-01 Thread Oleg Fayans
Hi Martin. Now I have this client installation thing sorted out. The test works as expected On 06/30/2016 02:57 PM, Martin Basti wrote: > > > On 30.06.2016 14:40, Oleg Fayans wrote: >> Hi Martin, >> >> Attached is a new version of the patch with two test cases separa

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-06-30 Thread Oleg Fayans
; forest root domains even for subdomains, I made some changes in > ipatests/test_integration/tasks.py file, so that it would enable me to > reuse existing function without copy-pasting them for one variable change. > > > Lenka > > > -- Oleg Fayans Quality E

Re: [Freeipa-devel] [PATCH 0022][Tests] Prevent trust test failures cause by adding duplicate DNS forward zone

2016-06-30 Thread Oleg Fayans
ardzone-add. >>>>>>>>>> >>>>>>>>> Grr, I meant this: >>>>>>>>> Even more importantly, the forward zone is completely >>>>>>>>> unnecessary when >>>>>>>>> DNS i

Re: [Freeipa-devel] [PATCH 0024][Tests] Fix integration tests not to produce incorrect /etc/hosts file

2016-06-29 Thread Oleg Fayans
hortname > strings. > > > Lenka > > > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [Test][patch-0052] Test for incorrect client domain

2016-06-29 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 6fe2f67807a2cd3d9519c1c919c884dd18867f74 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Wed, 29 Jun 2016 10:53:44 +0200 Subject: [PATCH] Test for incorrect client domain https://fedorahosted.org/freeipa/ticke

[Freeipa-devel] [Test][Patch-0051] Fixed import error in replica promotion test

2016-06-28 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 0268535dcc8426667f5742a05f4554f8ff9bd031 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Tue, 28 Jun 2016 16:00:08 +0200 Subject: [PATCH] Fixed import error --- ipatests/test_integration/test_replica_promot

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-06-28 Thread Oleg Fayans
Patch-0050 rebased against latest upstream branch On 06/28/2016 10:45 AM, Oleg Fayans wrote: > Passing test output: > > https://paste.fedoraproject.org/385774/71035231/ > > > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From f032df3a1d58e200d0f8bf8dbc121e5f03eb041

[Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-06-28 Thread Oleg Fayans
Passing test output: https://paste.fedoraproject.org/385774/71035231/ -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 7bc97eb762c951a8bc3762d8bd23da4ee06a6edb Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Tue, 28 Jun 2016 10:33:13 +0200 Subject: [PATCH]

Re: [Freeipa-devel] [Testplan Review] Certs in ID overrides

2016-06-28 Thread Oleg Fayans
Hi Sumit, The testplan is updated according to your second note. The WebUI part I'll test once Pavel's patch is merged. On 06/27/2016 10:28 AM, Sumit Bose wrote: > On Mon, Jun 27, 2016 at 10:06:23AM +0200, Oleg Fayans wrote: >> Hi Sumit, >> >> I've updated the testplan. (T

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-06-27 Thread Oleg Fayans
Hi guys, Is there a chance the patches NN 0047.1 and 0048.1 get reviewed before 4.4 release? They cover a good part of the Managed Topology 4.4 feature. On 06/17/2016 11:18 AM, Oleg Fayans wrote: > One more test was added to the patch-0048 > > On 06/17/2016 09:43 AM, Oleg Fayans wrote:

Re: [Freeipa-devel] [Testplan Review] Certs in ID overrides

2016-06-27 Thread Oleg Fayans
Jun 09, 2016 at 04:48:57PM +0200, Oleg Fayans wrote: >> Hi guys, >> >> Here is the first somewhat skeletal and pretty short version of the >> testplan. Could you please review it anyone? >> >> http://www.freeipa.org/page/V4/Certs_in_ID_overrides/Test_Plan &g

Re: [Freeipa-devel] [PATCH 0021][Tests] Fix failing ipatests/test_ipaserver/test_rpcserver.py

2016-06-24 Thread Oleg Fayans
ACK On 06/24/2016 10:29 AM, Lenka Doudova wrote: > Hi, > > attaching patch for one of the failing tests. Failure caused by an > assertion that was no longer valid. > > Lenka > > > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscri

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-06-17 Thread Oleg Fayans
One more test was added to the patch-0048 On 06/17/2016 09:43 AM, Oleg Fayans wrote: > Fixed a bug in the previous patch, automated 2 more testcases from > http://www.freeipa.org/page/V4/Manage_replication_topology_4_4/Test_Plan > > On 06/16/2016 04:46 PM, Oleg

Re: [Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-06-17 Thread Oleg Fayans
Fixed a bug in the previous patch, automated 2 more testcases from http://www.freeipa.org/page/V4/Manage_replication_topology_4_4/Test_Plan On 06/16/2016 04:46 PM, Oleg Fayans wrote: > > > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 2b087b1dc64500d58e72296f287aabd82cb

[Freeipa-devel] [Test][Patch-0047] Added a test for Ticket N 5964

2016-06-16 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From debac0cf5cb24e1c2072d10373f4d9f72cb875a7 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Thu, 16 Jun 2016 16:45:03 +0200 Subject: [PATCH] Automated clean-ruv subcommand test https://fedorahosted.org/freeipa/

[Freeipa-devel] [Patch-0046] Increased certmonger timeout to address ticket N 5758

2016-06-16 Thread Oleg Fayans
With this change the certmonger timeout issue is no longer observed in abcd lab. -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 2063d59f3d8303abf056d38a68ac75f9f2d9cd24 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Thu, 16 Jun 2016 10:25:59 +0200 S

[Freeipa-devel] [Test][Patch-0043-0045] DNSSec key rotation test

2016-06-13 Thread Oleg Fayans
tried to decrease default key TTL values with no success. Could anyone take a look into this (after 4.4 is released, of course)? -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From f7f3d8c256fc9de3f8f0d82056be5a6d10f6c9a7 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com>

[Freeipa-devel] [Testplan Review] Certs in ID overrides

2016-06-09 Thread Oleg Fayans
Hi guys, Here is the first somewhat skeletal and pretty short version of the testplan. Could you please review it anyone? http://www.freeipa.org/page/V4/Certs_in_ID_overrides/Test_Plan -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [Testplan Review]

2016-06-06 Thread Oleg Fayans
? On 05/31/2016 06:36 PM, Petr Vobornik wrote: > On 05/23/2016 09:23 AM, Oleg Fayans wrote: >> Hi Petr, >> >> The test plan is updated. > > Thanks, > > is it possible to number test cases? It is hard to refer to them without > copying the full name. > > 1.

[Freeipa-devel] [Test][patch-0042] Automated 2 testcases from Managed Topology testplan

2016-06-03 Thread Oleg Fayans
The patch applies and passes pylint -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 39fd39118a6d6e84a4c8791c17ad54da5cbffd0d Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date: Fri, 3 Jun 2016 13:22:48 +0200 Subject: [PATCH] Automated 2 managed topology 4.4 tes

[Freeipa-devel] [Testplan Review] Server Roles

2016-05-25 Thread Oleg Fayans
Hi guys. Here is a rather schematic (as neither the feature not the design document is not complete) of the server roles testplan. Could you please review it and tell me what is missing? http://www.freeipa.org/page/V4/Server_Roles/Test_Plan -- Oleg Fayans Quality Engineer FreeIPA team RedHat

Re: [Freeipa-devel] [Testplan Review]

2016-05-23 Thread Oleg Fayans
Hi Petr, The test plan is updated. On 05/19/2016 12:54 PM, Petr Vobornik wrote: > On 05/19/2016 12:38 PM, Oleg Fayans wrote: >> Hi all, >> >> I've created the first versio of the testplan for Topology Management >> feature in 4.4 release: >&g

[Freeipa-devel] [Testplan Review]

2016-05-19 Thread Oleg Fayans
Hi all, I've created the first versio of the testplan for Topology Management feature in 4.4 release: http://www.freeipa.org/page/V4/Manage_replication_topology_4_4/Test_Plan Could someone please review it? -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription

Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4

2016-05-19 Thread Oleg Fayans
Hi Martin, I should probably rephrase my question: will the server_del API call be added to 'ipa-server-install --uninstall' within 4.4 or is it a more distant plan? On 05/18/2016 05:18 PM, Martin Babinsky wrote: > On 05/18/2016 05:01 PM, Oleg Fayans wrote: >> Hi guys, >> >

Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4

2016-05-18 Thread Oleg Fayans
' will be deprecated? On 05/16/2016 03:48 PM, Oleg Fayans wrote: > Hi, > > The design is OK, the onlz thing that is missing is a HowToTest section > in track tickets [1] and [2] about clean-dangling-ruvs and > abort-clean-ruv respectively. It would really help if these tickets had > deta

Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4

2016-05-17 Thread Oleg Fayans
Sorry, I forgot to list the tickets themselves On 05/16/2016 03:48 PM, Oleg Fayans wrote: > Hi, > > The design is OK, the onlz thing that is missing is a HowToTest section > in track tickets [1] and [2] about clean-dangling-ruvs and > abort-clean-ruv respectively. It wo

[Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4

2016-05-16 Thread Oleg Fayans
Hi, The design is OK, the onlz thing that is missing is a HowToTest section in track tickets [1] and [2] about clean-dangling-ruvs and abort-clean-ruv respectively. It would really help if these tickets had detailed steps to test (in case of dangling RUV's - steps to generate them) -- Oleg

Re: [Freeipa-devel] [TEST][patch-0037]Fixes of dnssec tests

2016-05-11 Thread Oleg Fayans
PM, Martin Basti wrote: > > > On 06.05.2016 14:58, Oleg Fayans wrote: >> >> On 05/06/2016 11:42 AM, Martin Basti wrote: >>> >>> On 06.05.2016 11:14, Oleg Fayans wrote: >>>> On 05/06/2016 09:48 AM, Martin Basti wrote: >>>>> On 06

Re: [Freeipa-devel] [PATCH] ca-less tests updated

2016-05-10 Thread Oleg Fayans
The full set of necessary patches is attached On 04/20/2016 10:35 AM, David Kupka wrote: > On 19/04/16 11:13, Oleg Fayans wrote: >> OK, that one, though passing lint, did not actually work. I gave up my >> attempts to define method decorators inside the class. Now it passes &g

[Freeipa-devel] [TBD] Automated tests, regressions and workarounds

2016-05-09 Thread Oleg Fayans
team puts the principle "No workarounds, we need to fix the bug no matter what" above any common sense. [1] https://fedorahosted.org/freeipa/ticket/5348 -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.

Re: [Freeipa-devel] [TEST][patch-0037]Fixes of dnssec tests

2016-05-06 Thread Oleg Fayans
On 05/06/2016 03:25 PM, Petr Spacek wrote: > On 6.5.2016 15:03, Oleg Fayans wrote: >> >> >> On 05/06/2016 12:08 PM, Martin Babinsky wrote: >>> On 05/06/2016 11:14 AM, Oleg Fayans wrote: >>>> >>>> >>>> On 05/06/2016 09:48 AM, Mart

Re: [Freeipa-devel] [TEST][patch-0037]Fixes of dnssec tests

2016-05-06 Thread Oleg Fayans
On 05/06/2016 12:08 PM, Martin Babinsky wrote: > On 05/06/2016 11:14 AM, Oleg Fayans wrote: >> >> >> On 05/06/2016 09:48 AM, Martin Basti wrote: >>> >>> >>> On 06.05.2016 09:36, Oleg Fayans wrote: >>>> Tests are finally stable:

Re: [Freeipa-devel] [TEST][patch-0037]Fixes of dnssec tests

2016-05-06 Thread Oleg Fayans
On 05/06/2016 11:42 AM, Martin Basti wrote: > > > On 06.05.2016 11:14, Oleg Fayans wrote: >> >> On 05/06/2016 09:48 AM, Martin Basti wrote: >>> >>> On 06.05.2016 09:36, Oleg Fayans wrote: >>>> Tests are finally stable: >>

Re: [Freeipa-devel] [TEST][patch-0037]Fixes of dnssec tests

2016-05-06 Thread Oleg Fayans
On 05/06/2016 09:48 AM, Martin Basti wrote: > > > On 06.05.2016 09:36, Oleg Fayans wrote: >> Tests are finally stable: >> >> = test session starts >> == >> platform linux2 -- Python 2.7.11 -- py-1.4.

[Freeipa-devel] [TEST][patch-0037]Fixes of dnssec tests

2016-05-06 Thread Oleg Fayans
test_integration/test_dnssec.py = 8 passed in 5561.48 seconds == -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From c716ef162166758795f30f9ee79124ad7cd0f752 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <ofay...@redhat.com> Date:

[Freeipa-devel] [DESIGN REVIEW] V4/Server_Roles

2016-05-05 Thread Oleg Fayans
The document is perfect. No remarks from QE side: ready for testplan design -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org

[Freeipa-devel] [DESIGN REVIEW] V4/Certs_in_ID_overrides

2016-05-05 Thread Oleg Fayans
Hi, The document looks fine. Would be nice if it had some link on a HOWTO page about generation of a user certificate to use for AD-originated users. Apart from that - everything is pretty clear -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa

  1   2   3   4   >