Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0019-associations.patch

2010-09-03 Thread Endi Sukma Dewata
:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Thu, 2 Sep 2010 04:14:57 -0400 Subject: [PATCH] Added Services tab. --- install/static/Makefile.am |1 + install/static/index.xhtml |1 + install/static/navigation.js|7

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0021-local-param-for-this-in-closure

2010-09-07 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: This addresses Endi's comment regarding the 'this' pointer from path admiyo-0019. This patch is required to get the associations working. ACK. Thanks! -- Endi S. Dewata ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] 0001-Added-Services-tab.patch

2010-09-07 Thread Endi Sukma Dewata
Hi, This patch adds the Service tab using Adam's association classes. It also contains the sample data for some service operations. Thanks! -- Endi S. Dewata From 3258e05bd5777e6ca31369491a964d8335452b55 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Thu, 2 Sep 2010

Re: [Freeipa-devel] [PATCH] 0001-Added-Services-tab.patch

2010-09-08 Thread Endi Sukma Dewata
:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Thu, 2 Sep 2010 04:14:57 -0400 Subject: [PATCH] Added Services tab. --- install/static/Makefile.am |1 + install/static/add.js| 10 ++- install/static/index.xhtml

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0022-netgroup-associations.patch

2010-09-09 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Netgroup associations: netgroups - users, groups,hosts,hostgroups https://fedorahosted.org/freeipa/attachment/ticket/96/admiyo-freeipa-0022-netgroup-associations.patch ACK, but there are typos on lines 153, 167, 180 in the patch. Thanks! -- Endi S.

Re: [Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-10 Thread Endi Sukma Dewata
! -- Endi S. Dewata From cee21193e33900c2abaab6a581bc70baacfc1d83 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Thu, 9 Sep 2010 22:21:29 -0400 Subject: [PATCH] Splitting service principal into service name and hostname. The EntityBuilder has been modified to obtain the pkey

Re: [Freeipa-devel] QUnit and unit testing

2010-09-13 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: IPA class: - IPA(path, type): Construct IPA object given a path to server's JSON-RPC or static files. - success(): Default success handler. - error(): Default error handler. - failure(): Default failure handler. -

Re: [Freeipa-devel] QUnit and unit testing

2010-09-13 Thread Endi Sukma Dewata
- Endi Sukma Dewata edew...@redhat.com wrote: var addCmd = ipa.createCommand(user-add); The createCommand() could be implemented like this: ipa.createCommand = function(method) { return new IPACommand(this, method); } The QUnit test could be implemented like this: test(test01, function

Re: [Freeipa-devel] Proposed Javascript coding standards

2010-09-13 Thread Endi Sukma Dewata
Hi Adam, - Adam Young ayo...@redhat.com wrote: https://fedorahosted.org/freeipa/wiki/Javascript_Coding_Standards Whitespace: Do we put a space in function definition between the () and {}? function(){...} vs. function() {...} Or does it matter? Compound statement: This is probably

[Freeipa-devel] [PATCH] Adding quick links in user and group search results.

2010-09-14 Thread Endi Sukma Dewata
for user and group entities. -- Endi S. Dewata From bef6aa95bdfd13d360e4a0420d467915330db833 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Tue, 14 Sep 2010 22:26:15 -0400 Subject: [PATCH] Adding quick links in user and group search results. The render_call() signature

Re: [Freeipa-devel] [PATCH] Adding quick links in user and group search results.

2010-09-15 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: ACK, but change the Column heading to Quick Links first OK, fixed. Thanks. -- Endi S. Dewata From 5b04bc19d2d639da0f7814e901f15814eea7c354 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Tue, 14 Sep 2010 22:26:15 -0400 Subject

[Freeipa-devel] [PATCH] Restoring Services tab

2010-09-17 Thread Endi Sukma Dewata
fields. Callbacks are used to add quick links and generate pkey dynamically. The webui.js has been modified to add the Services tab. Thanks! -- Endi S. Dewata From cf4703e9e62cfddbdfeceb21d811e0ece1c00886 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Fri, 17 Sep 2010

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0025-remove-pagaparams.patch

2010-09-17 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Fixes a minor glitch in pzuna-freeipa-0022-4-BIG which re-introduced the pageparams.js entry into the Makefile.am ACK -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: moved images up Adding an 'images' subdir was proliferating changes throughout the build system this seemed easier Submitted as a separate patch to signify where wea re departing from what is generated by theme-roller

[Freeipa-devel] [PATCH] Rolegroups tab.

2010-09-20 Thread Endi Sukma Dewata
operations have been added. -- Endi S. Dewata From 09cc9d1ceb6259472739afdc767cc502ff9f2484 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Mon, 20 Sep 2010 20:05:03 -0400 Subject: [PATCH] Rolegroups tab. The Makefile.am and index.xhtml has been modified to include rolegroup.js

[Freeipa-devel] [PATCH] Modal dialog for enrollment

2010-09-22 Thread Endi Sukma Dewata
changes were also made to improve code clarity. -- Endi S. Dewata From 2a87079d6940d601c066b5b6259e60ece423532d Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Wed, 22 Sep 2010 21:22:31 -0400 Subject: [PATCH] Modal dialog for enrollment The enroll facet has been converted

Re: [Freeipa-devel] [PATCH]admiyo-freeipa-0041-self-service.patch

2010-09-23 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: self-service Selects the site map based on the presence or absense of rolegroups for the current user. If the user has no rolegroups, UI defaults to the Details page for that user. NACK. The window_hashchange() is expecting 2 levels

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0043-Whoami-link.patch

2010-09-24 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Fixed admiyo-freeipa-0043-3-Whoami-link.patch ACK, sorry didn't see this one before replying. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] Test suite for ipa.js and entity.js.

2010-09-27 Thread Endi Sukma Dewata
- Rob Crittenden rcrit...@redhat.com wrote: Is there any documentation on how to run the tests? You just need to open install/static/test/index.html in the browser and click the test you want to run. -- Endi S. Dewata ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0045-Fix-the-add-button.patch

2010-09-28 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Fix the 'add' button The Add button was located using the Dom, and the scheme used to find it was fragile enough to be broken by the I18N approach. This is a little more robust, using a JQuery selector based on the class of the controls, and

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0046-Corrected-Language-Codes.patch

2010-09-28 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Corrected Language Codes The Gnu document incorrectly listed Japanese as jp and Hebrew as iw. That was why the Plurals line passed through directly from the template. ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH]admiyo-freeipa-0047-tab-objects.patch

2010-09-28 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: tab objects Convert the tab lists to arrays of objects with four potential fields: tab[0] - tab.name tab[1] - tab.label tab[2] - tab.setup or tab.children Added unit tests ACK, but could you add the unit tests into the index.html and

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Endi, can you add in a Unit test for this? If need be, extend the ipa_cmd so that it looks for an optional command line param that makes it try to fetch a .json file that doesn't exist: Something like var suffix = $.bbq.get(cmd_suffix); if

Re: [Freeipa-devel] admiyo-freeipa-0048-Item-Level-Undo.patch

2010-09-29 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Item Level Undo Also adding some unit tests for details. Using JQuery UI buttons for update and reset This has the added benefit of letting the user know when the screen has been submitted, as the undo buttons go away. Rebased on top of Endi's

[Freeipa-devel] [PATCH] Checking empty AJAX response in ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! Some errors (e.g. server down) are reported as AJAX success with empty data and/or HTTP error code != 200. The ipa_cmd() has been modified so that it will detect such errors and invoke the error handler. -- Endi S. Dewata From

Re: [Freeipa-devel] [PATCH] Checking empty AJAX response in ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
- Endi Sukma Dewata edew...@redhat.com wrote: Some errors (e.g. server down) are reported as AJAX success with empty data and/or HTTP error code != 200. The ipa_cmd() has been modified so that it will detect such errors and invoke the error handler. It turns out that pulling local JSON

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Should have remembered this approach, standard JS way to deal with undefined values. admiyo-freeipa-0048-3-Item-Level-Undo.patch A few notes: 1. You're replying to the wrong thread :) 2. The undo button will only appear when the input field loses

[Freeipa-devel] [PATCH] Refactoring navigation.js.

2010-09-30 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The navigation.js has been modified to make it more abstract, i.e. unaware of entity facets. The nav_update_tabs() has been modified such that it activates and updates the tabs based on the current state stored in the URL. The facets are now handled

[Freeipa-devel] [PATCH] Autogenerating Quick Links.

2010-10-01 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! ipa_entity_quick_links() has been added to generate quick links automatically from object's attribute_members, the same logic used for generating facet list. The search definition for each entity has been updated to use the new function. A unit test

[Freeipa-devel] [PATCH] Entity association configuration.

2010-10-01 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The ipa_entity_set_association_definition() has been added to configure the association between 2 entitites. By default the associator is BulkAssociator and the method is add_member. The entities have been updated to use the right configurations.

[Freeipa-devel] [PATCH] Tooltips for quick links.

2010-10-04 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The ipa_entity_quick_links() has been modified to show tooltips when hovering on quick links. -- Endi S. Dewata From 98a75d0b1d72f8d10f1a741aac3b12de71a6f655 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Mon, 4 Oct 2010

Re: [Freeipa-devel] [PATCH] Tooltips for quick links.

2010-10-04 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: ACK Thanks. Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] UI Unit Tests Docs

2010-10-05 Thread Endi Sukma Dewata
Hi, Here are the docs for the UI Unit Tests: http://www.freeipa.org/page/UI_Unit_Tests Any comments are welcome. Thanks! -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] UI Unit Tests Docs

2010-10-05 Thread Endi Sukma Dewata
- Rob Crittenden rcrit...@redhat.com wrote: Endi Sukma Dewata wrote: Hi, Here are the docs for the UI Unit Tests: http://www.freeipa.org/page/UI_Unit_Tests Any comments are welcome. Thanks! Looks good to me. Can you add a link from the Testing page here? rob You mean

Re: [Freeipa-devel] UI Unit Tests Docs

2010-10-05 Thread Endi Sukma Dewata
- Rob Crittenden rcrit...@redhat.com wrote: http://www.freeipa.org/page/UI_Unit_Tests Looks good to me. Can you add a link from the Testing page here? You mean the index.html in install/static/test, right? OK, I will do that after this. Do we need to store the source of this

Re: [Freeipa-devel] [PATCH] Fix attribute callbacks on details pages in the webUI.

2010-10-06 Thread Endi Sukma Dewata
- Pavel Zuna pz...@redhat.com wrote: Fixes bug reported by Adam in internal discussion. Ticket #326 Pavel ACK'd and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] Displaying AJAX URL in error message.

2010-10-06 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The ipa_error_handler() has been modified to display the AJAX URL that is having a problem. The ipa_cmd() error handler is now invoked using call() to pass 'this' object which contains the URL. -- Endi S. Dewata From

Re: [Freeipa-devel] [PATCH] Displaying AJAX URL in error message.

2010-10-06 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: On 10/06/2010 05:00 PM, Endi Sukma Dewata wrote: The ipa_error_handler() has been modified to display the AJAX URL that is having a problem. The ipa_cmd() error handler is now invoked using call() to pass 'this' object which contains the URL

Re: [Freeipa-devel] [PATCH] 564 fix some aci typos

2010-10-06 Thread Endi Sukma Dewata
- Rob Crittenden rcrit...@redhat.com wrote: I mis-spelled the admins group with an extra s which was causing some things to not work as admin. I also noticed a couple of spurious 'aci' in some descriptions, remove those as well. NACK. The spurious 'aci' should have been 'acl'

Re: [Freeipa-devel] [PATCH] 563 use unique names for acis

2010-10-06 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Copy/paste error where I didn't replace Hosts with Hostgroups in aci name. ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0053-policy-and-config-sample-data.patch

2010-10-06 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Sample data for config and policy entities. ACK with note: Rob fixed ACI duplicates in his patch #564 so the aci_find.json will need to be fixed later. -- Endi S. Dewata ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0052-policy-and-config.patch

2010-10-07 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Population of the policy and entities tabs. DNS and ACI are broken due to Plugin issues Fix for entities without search Added new files to Makefile.am used rolegroup.js file as the start point, renamed to serverconfig.js Missed the Makefile.am

Re: [Freeipa-devel] [PATCH] 565 handle both DER and base64 encoded certs in service plugin

2010-10-08 Thread Endi Sukma Dewata
- Rob Crittenden rcrit...@redhat.com wrote: Accept an incoming certificate as either DER or base64 in the service plugin. The plugin required a base64-encoded certificate and always decoded it before processing. This doesn't work with the UI because the json module decodes binary

Re: [Freeipa-devel] [PATCH]admiyo-freeipa-0055-record-limit.patch

2010-10-08 Thread Endi Sukma Dewata
- Rob Crittenden rcrit...@redhat.com wrote: Adam Young wrote: This patch hard codes the record limit for the UI to 100. Next step is to make it configurable. This patch is necessary, as without it, some customers with large records will have problems with default queries. ack

[Freeipa-devel] [PATCH] Certificate management for services.

2010-10-08 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! This is an initial implementation of certificate management for services. It addresses the mechanism required to view and update certificates. The complete UI implementation will be addressed in subsequent patches. On the server side, the service.py

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0056-removing-dead-files

2010-10-15 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: Like the journey song, these should have been gone, long ago. ACKed and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] Service certificate status.

2010-10-15 Thread Endi Sukma Dewata
. Dewata From 23bfa0d6d33cb397e25bd19d319e2c7904fbcc77 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com Date: Fri, 15 Oct 2010 20:51:52 -0400 Subject: [PATCH] Service certificate status. The service details page has been modified to show certificate status using bullets. It will also

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0056-removing-dead-files

2010-10-18 Thread Endi Sukma Dewata
On 10/18/2010 9:38 AM, Adam Young wrote: On 10/15/2010 06:56 PM, Simo Sorce wrote: Endi Sukma Dewataedew...@redhat.com wrote: ACKed and pushed to master. This patch broke the build ... fix coming, but guys, please, verify stuff builds from scratch before pushing patches. Simo, very sorry

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0058-password-dialog.patch

2010-10-18 Thread Endi Sukma Dewata
On 10/18/2010 1:53 PM, Adam Young wrote: Now check the principal prior to calling passwd, and add that as a parameter for non-selfservice case. ACK with note that there's an outstanding bug on password reset: https://fedorahosted.org/freeipa/ticket/390 -- Endi S. Dewata

[Freeipa-devel] [PATCH] Host certificate management

2010-10-19 Thread Endi Sukma Dewata
+/body +/html diff --git a/install/static/test/certificate_tests.js b/install/static/test/certificate_tests.js new file mode 100755 index 000..6ada6e4 --- /dev/null +++ b/install/static/test/certificate_tests.js @@ -0,0 +1,79 @@ +/* Authors: + *Endi Sukma Dewata edew...@redhat.com

[Freeipa-devel] [PATCH] Dialog boxes for AJAX, HTTP, and IPA errors.

2010-10-19 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/95/ The ipa_cmd() has been modified to identity the type of the error it has received and display the error using the right dialog box. The dialog box can be customized further to display the appropriate

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0061-Remove-size-limits.patch

2010-10-19 Thread Endi Sukma Dewata
On 10/19/2010 3:57 PM, Adam Young wrote: Remove size limits. Now use the system wide settings instead of hardcoded size limits. ACKed and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0062-removing-icons.patch

2010-10-19 Thread Endi Sukma Dewata
On 10/19/2010 4:07 PM, Adam Young wrote: Removing icons We'll later replace them with a new scheme. For now, this is the simplest UI The intention is to look unfinished, so people don't comment on how poor it looks. But still, it looks better than with the oddly spaced icons. Already ACKed and

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0063-dns-work.patch

2010-10-25 Thread Endi Sukma Dewata
On 10/25/2010 1:10 PM, Adam Young wrote: On 10/25/2010 11:26 AM, Adam Young wrote: On 10/25/2010 10:52 AM, Rob Crittenden wrote: Adam Young wrote: Implementation of the UI for DNS records. Search uses filters. Much of the code has been cut and pasted from search.js and add.js, but then

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0068-association-header.patch

2010-10-26 Thread Endi Sukma Dewata
On 10/25/2010 8:39 PM, Adam Young wrote: https://fedorahosted.org/freeipa/ticket/338 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed and pushed to master. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0069-Field-Errors.patch

2010-10-27 Thread Endi Sukma Dewata
On 10/27/2010 12:44 PM, Adam Young wrote: Field Errors Uses the pattern field of the metat data to see if the input for a given field is valid. If not, displays a red box with the contents of pattern_msg To test this, I artificially modified the meta data for the Group description ACKed and

Re: [Freeipa-devel] [PATCH] Dialog boxes for AJAX, HTTP, and IPA errors.

2010-10-28 Thread Endi Sukma Dewata
On 10/19/2010 4:28 PM, Endi Sukma Dewata wrote: https://fedorahosted.org/reviewboard/r/95/ The ipa_cmd() has been modified to identity the type of the error it has received and display the error using the right dialog box. The dialog box can be customized further to display the appropriate

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0070-delete-associations.patch

2010-10-29 Thread Endi Sukma Dewata
On 10/29/2010 10:33 AM, Adam Young wrote: On 10/28/2010 05:30 PM, Adam Young wrote: On 10/28/2010 05:22 PM, Adam Young wrote: delete associations Uses code very similar to the search code for deleting associations Only uses the serial means of deletion. While this works for all deletes, it is

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0071-group_remove_memeber.json.patch

2010-10-29 Thread Endi Sukma Dewata
On 10/29/2010 12:43 PM, Adam Young wrote: Metadata for testing ACK. Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-10-29 Thread Endi Sukma Dewata
On 10/29/2010 2:50 PM, Adam Young wrote: Check effective rights. If the right is not explicitly allowed, show the field as read only. It seems to be working, but I think it has to wait until the attributelevelrights is returned in the JSON response because without it the UI would become

[Freeipa-devel] [PATCH] HBAC test data

2010-11-03 Thread Endi Sukma Dewata
Hi, Please review the attached patch. It can be installed independently from my patch #25-2 (HBAC Details Page). Thanks! https://fedorahosted.org/reviewboard/r/100/ -- Endi S. Dewata From 28fbe82de301bc0e2a3166a43e991b403750658e Mon Sep 17 00:00:00 2001 From: Endi S. Dewata

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0073-Clear-fields-after-add.patch

2010-11-03 Thread Endi Sukma Dewata
On 11/1/2010 12:58 PM, Adam Young wrote: For the 'add and add again' useage. NACK. The following for-loop shouldn't be moved into add_win() because it breaks the service add dialog. -for (var i = 0; i that.fields.length; ++i) { -var field = that.fields[i]; -

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-03 Thread Endi Sukma Dewata
On 11/1/2010 9:28 AM, Adam Young wrote: Check effective rights. If the right is not explicitly allowed, show the field as read only. It seems to be working, but I think it has to wait until the attributelevelrights is returned in the JSON response because without it the UI would become

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Endi Sukma Dewata
On 11/2/2010 2:33 PM, Adam Young wrote: While this doesn't fix all of the jslint complaints for ipa.js, it fixes the worst offenders. Nearly ACKed... is there such thing? :) The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var IPA = ( function () { function ipa_cmd(name,

Re: [Freeipa-devel] patches needing review

2010-11-03 Thread Endi Sukma Dewata
These were acked and pushed last week: freeipa-admiyo-freeipa-0070-delete-associations.patch freeipa-admiyo-freeipa-0071-group_remove_memeber.json.patch These still have problems: freeipa-admiyo-freeipa-0072-rights-check.patch freeipa-admiyo-freeipa-0073-Clear-fields-after-add.patch

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 8:53 AM, Adam Young wrote: Still NACK. I have tested this again. It looks like the UI does not send the --rights parameter which is required to get the attributelevelrights. With this patch even the admin can't edit anything. Ah...that was because I did it as two commits, and only

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 9:10 AM, Adam Young wrote: The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var IPA = ( function () { function ipa_cmd(name, args, options, win_callback, fail_callback, objname) Fixed The duplicate IPA declaration is fixed, but the ipa_cmd is still declared

Re: [Freeipa-devel] [PATCH] HBAC Details Page

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 10:09 AM, Adam Young wrote: A few questions (and tweaks). Note that I have just given the code a read through, not applied the patch yet. Are you sure we want to implement our own Theme code? I'd rather try to keep theme stuff as part of JQUery.UI. At a mionimum, we risk name clash

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 1:20 PM, Adam Young wrote: Note the comment about Forward declared jslint complains if there is no forward declaration. I've postponed moving ipa_cmd into the IPA namespace in this patch, as that will cause a ripple effect through the rest of the .js files. I've seen several ways

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 2:50 PM, Adam Young wrote: Now defaulting to rscwo, which means that some fields will show up editable even if the user can't change them, due to effectiverights not being returned on all fields. Could you rebase it against the latest in master? The patch cannot be applied.

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0073-Clear-fields-after-add.patch

2010-11-05 Thread Endi Sukma Dewata
On 11/3/2010 12:03 PM, Endi Sukma Dewata wrote: On 11/3/2010 8:55 AM, Adam Young wrote: I suspect then that the service add dialog is wrong. This behaviour has been spec'ed and working for a long time. What does it break? The field.setup(dialog, IPA_ADD_UPDATE) should be called before the add

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0075-Ticket-Expiration.patch

2010-11-05 Thread Endi Sukma Dewata
On 11/5/2010 4:03 PM, Adam Young wrote: Ticket Expiration This patch handles Kerberos ticket expiration in the UI. Additionally it removes the mod_auth_kerb authorization for elements in the static directory, cutting down on the number of round trips Rebased It still doesn't apply. Could

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0075-Ticket-Expiration.patch

2010-11-05 Thread Endi Sukma Dewata
On 11/5/2010 6:52 PM, Adam Young wrote: Here it is. ACK-ish.. :) The error handling on ticket expiration works, but there are some minor issues: 1. The IPA variable is declared twice. +var IPA; var IPA = ( function () { 2. IPA_DEFAULT_JSON_URL should be deleted. var

[Freeipa-devel] [PATCH] HBAC Access Time

2010-11-05 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/102/ IPA commands now can be defined in these classes: - ipa_command: a single IPA command - ipa_batch_command: a batch command for executing multiple commands on the server side using the new batch

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0073-Clear-fields-after-add.patch

2010-11-08 Thread Endi Sukma Dewata
On 11/8/2010 9:13 AM, Adam Young wrote: On 11/05/2010 05:25 PM, Endi Sukma Dewata wrote: On 11/3/2010 12:03 PM, Endi Sukma Dewata wrote: On 11/3/2010 8:55 AM, Adam Young wrote: I suspect then that the service add dialog is wrong. This behaviour has been spec'ed and working for a long time

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Endi Sukma Dewata
On 11/8/2010 12:01 PM, Adam Young wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using true and False for nsaccountlock value. So it might be safer to use case-insensitive comparison or normalize

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Endi Sukma Dewata
On 11/8/2010 5:44 PM, Endi Sukma Dewata wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using true and False for nsaccountlock value. So it might be safer to use case-insensitive comparison or normalize

Re: [Freeipa-devel] [PATCH] admiyo-0078-link-indications

2010-11-08 Thread Endi Sukma Dewata
On 11/8/2010 12:30 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] admiyo-0079-delete-to-remove

2010-11-08 Thread Endi Sukma Dewata
On 11/8/2010 7:41 PM, Adam Young wrote: ACK and pushed to master. I also fixed 2 issues and pushed them using 1-liner rule. 1. Renamed button.deletes to button.remove in widget.js. 2. Renamed button.delete to button.remove in json_metadata.json. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] admiyo-0080-Label-cleanup

2010-11-10 Thread Endi Sukma Dewata
On 11/9/2010 1:15 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] HBAC Service Service Group test data

2010-11-10 Thread Endi Sukma Dewata
Hi, Please review the attached patch. This can be installed independently from my patch #28 (HBAC Services). Thanks! https://fedorahosted.org/reviewboard/r/105/ -- Endi S. Dewata From 2b082d4e801072f6c9866e77b4ec7b856cdbda71 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata edew...@redhat.com

Re: [Freeipa-devel] [PATCH] HBAC details page enhancement

2010-11-15 Thread Endi Sukma Dewata
On 11/15/2010 11:47 AM, Adam Young wrote: ACK Thanks. Pushed a new rebase to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] admiyo-0088-HBAC-css-cleanup.

2010-11-15 Thread Endi Sukma Dewata
On 11/15/2010 2:17 PM, Adam Young wrote: ACK #90, #87-2, #88-2. Note: the font looks too big on my browser, but this can be addressed later. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-0088-HBAC-css-cleanup.

2010-11-16 Thread Endi Sukma Dewata
On 11/15/2010 3:02 PM, Endi Sukma Dewata wrote: ACK #90, #87-2, #88-2. Note: the font looks too big on my browser, but this can be addressed later. Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [SSSD] Proposed changes to the HBAC grammar

2010-11-17 Thread Endi Sukma Dewata
On 11/17/2010 3:21 PM, Dmitri Pal wrote: In a related note, we also discussed how to handle describing activity windows that cross the midnight boundary. It's my recommendation that we should handle examples like the following by breaking them into two separate accessTime attributes, one that

Re: [Freeipa-devel] admiyo-0097-batch-init

2010-11-18 Thread Endi Sukma Dewata
On 11/17/2010 9:34 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] admiyo-0098-env-init

2010-11-18 Thread Endi Sukma Dewata
On 11/18/2010 4:08 PM, Adam Young wrote: Example: to find the cert server used, you would do: IPA.env.ra_plugin ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-0095-removed-index.

2010-11-18 Thread Endi Sukma Dewata
On 11/18/2010 7:13 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] admiyo-0096-add-button

2010-11-18 Thread Endi Sukma Dewata
On 11/17/2010 8:15 PM, Adam Young wrote: https://fedorahosted.org/freeipa/ticket/471 ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Host Enrollment via OTP

2010-11-18 Thread Endi Sukma Dewata
Hi, Please revie the attached patch. Thanks! The support for host enrollment via one-time-password has been added. When submitted, the OTP will be used to set the host's userpassword. Previously each IPA command can only have one JSON test data file. The ipa_cmd() has been modifies to accept

[Freeipa-devel] [PATCH] Sample data for service provisioning

2010-11-18 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! -- Endi S. Dewata From a7e17a5eafdd3b7d206ffcdd41ddfec4c6a57c45 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Thu, 18 Nov 2010 23:33:51 -0600 Subject: [PATCH] Sample data for service provisioning ---

[Freeipa-devel] [PATCH] Use radio buttons for HBAC rule type

2010-11-18 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! To be consistent with the details page, the rule type in the HBAC add dialog box has been converted into radio buttons. -- Endi S. Dewata From 21545c3e7f8312e83e5398d3244ae9260d39fe54 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com

Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages

2010-11-19 Thread Endi Sukma Dewata
On 11/19/2010 10:22 AM, Adam Young wrote: ACK. However, you will need to rebase, as Rob already made the index.html addition to ipa.spec.in Thanks. Rebased and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] admiyo-0099-tab-width

2010-11-19 Thread Endi Sukma Dewata
On 11/19/2010 10:42 AM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages

2010-11-19 Thread Endi Sukma Dewata
On 11/19/2010 11:18 AM, Dmitri Pal wrote: Endi Sukma Dewata wrote: On 11/19/2010 10:22 AM, Adam Young wrote: ACK. However, you will need to rebase, as Rob already made the index.html addition to ipa.spec.in Thanks. Rebased and pushed to master. I suspect it is the first pass at those since

[Freeipa-devel] [PATCH] Fixed action panel queries

2010-11-19 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! Previously the queries for action panel were done globally. Since each entity container has its own action panel, the queries will return multiple results. This is fixed by qualifying the query to run within the entity container. The query has

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-19 Thread Endi Sukma Dewata
On 11/19/2010 4:09 PM, Adam Young wrote: This will not work with entities that do not have associated tabs, e.g. hbacsvc, hbacsvcgroups, sudocmd, sudocmdgroups. For these entities the IPA.tab_state() will return undefined, so the ipa_column_widget.setup() will fail. To reproduce this

[Freeipa-devel] [PATCH] Multivalued email address

2010-11-19 Thread Endi Sukma Dewata
Pushed under three-liner rule. ;) -- Endi S. Dewata From ca0fbd7329368bb3b30bcbfc772e04cda2544f88 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Fri, 19 Nov 2010 18:30:03 -0600 Subject: [PATCH] Multivalued email address --- install/static/test/data/ipa_init.json |

Re: [Freeipa-devel] [PATCH] admiyo-0102-action-panel-formatting

2010-11-24 Thread Endi Sukma Dewata
On 11/24/2010 10:51 AM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-29 Thread Endi Sukma Dewata
On 11/25/2010 8:24 PM, Adam Young wrote: Updated version that doesn't break SUDO or HBAC. The third level nesting in the tabs set is only used for this kind of navigation now, but should be used for Action panel shortly. Conditional ACK... :) There are some additional changes that need to be

  1   2   3   4   5   6   7   8   9   10   >