Re: Ada testcase CR line endings

2012-04-10 Thread Mike Stump
On Apr 9, 2012, at 11:24 PM, Arnaud Charlet wrote: >> So, I'd like to change all the ada testcases to use normal unix line endings. >> >> testsuite/gnat.dg/taft_type2_pkg.ads >> >> is an example if one such file, any objections? > > No objections. Applied to trunk and 4.7.x. Thanks. Index: gn

Re: [Patch, Fortran, F03] PR52909: Procedure pointers not private to modules

2012-04-10 Thread Tobias Burnus
No patch review - but and answer to a question and a comment. Janus Weil wrote: > I am aware that it will break the ABI, but only for programs involving > procedure pointers (which still is a 'relatively' new feature, > supported since gfortran 4.4). > > Btw, speaking of ABI breaking: What are the

Re: [SMS] Support new loop pattern

2012-04-10 Thread Andrey Belevantsev
Hello Ayal, First of all, thanks for your feedback. Now to your questions: On 31.03.2012 3:20, Ayal Zaks wrote: Roman, Andrey, Sorry for the delayed response. It would indeed be good to have SMS apply to more loop patterns, still within the realm of *countable* loops. SMS was originally desi

Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]

2012-04-10 Thread Arnaud Charlet
> Back on this! It turn out that this breaks the shared Ada runtime. > Indeed, exported variables on Ada packages in a DLLs are only accessible > when linking against DLL (thanks to runtime pseudo reloc). > > With the patch applied it is not possible to build any Ada application > using the shared

Re: [Patch ARM/ configury] Add fall-back check for gnu_unique_object

2012-04-10 Thread Ramana Radhakrishnan
>> The patch with correct configure output is ok. > > Thanks - this is what I committed. Is this something that can be considered for backporting to release branches ? This patch technically doesn't fix a regression but brings in line behaviour of the normal bootstrap for %gnu_unique_object ? htt

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-10 Thread Konstantinos Margaritis
On Tue, 10 Apr 2012 07:36:07 +0200 Jakub Jelinek wrote: > We really want consistency about the dynamic linker names etc. across > different targets and sneaking silently multiarch paths on one architecture > would make it inconsistent with all the others. So, please just use > /libhf/ld-linux.so.

ICE on bootstrap of libstdc++ for mingw-targets in add_bb_to_loop

2012-04-10 Thread Kai Tietz
Hello, recent changes to cfgloop have caused an ICE on bootstrapping libstdc++ for mingw targets. I assume same ICE happens for cygwin hosted gcc bootstrap, too. ICE happens on compiling of gcc/libstdc++-v3/libsupc++/eh_alloc.cc Code which produces seg-fault is in macro: DEF_VEC_P (loop_p

Re: [Libiberty - V2]: Handle VMS as a LLP64 platform in splay-tree.h

2012-04-10 Thread Tristan Gingold
On Apr 6, 2012, at 12:26 AM, Ian Lance Taylor wrote: > Tristan Gingold writes: > >> gcc/ >> 2012-04-05 Tristan Gingold >> >> * gengtype.c (main): Make uintptr_t a known type. >> >> include/ >> 2012-04-05 Tristan Gingold >> >> * splay-tree.h: Conditionnaly includes stdint.h an

Re: Fix partitioning of aliases

2012-04-10 Thread Richard Guenther
On Mon, 9 Apr 2012, Jan Hubicka wrote: > Hi, > this patch fixes several different ICEs related to handling aliases in WHOPR > partitioning. It took me over week debug this, but when variable alias > is added to a boundary and its destination is not added, we get queue of > unforutnate events wher

Re: [patch] Add generic __builtin_bswap16 support

2012-04-10 Thread Richard Guenther
On Mon, Apr 9, 2012 at 11:43 PM, Eric Botcazou wrote: > Hi, > > this adds generic support for __builtin_bswap16 (only PowerPC has it for now). > It is mapped to the bswap optab in HImode, whose implementation is as follows: >  - if a bswaphi2 pattern is present (PowerPC), it is directly used; or e

Re: [PATCH] Fix PR52614

2012-04-10 Thread Dominique Dhumieres
> I don't know enough about Fortran to know whether the same issues arise > there. Perhaps in Fortran a common symbol is always a common symbol and > can never be a defined symbol. If that is the case then for Fortran I > think it would be safe to change the alignment of the common symbol. Of >

Re: [PATCH] Fix PR middle-end/52894

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 2:45 AM, John David Anglin wrote: > The current 4.5, 4.6 and 4.7 branches are now seriously broken for all > PA target due to the fix applied for PR middle-end/52640, an optimization > fix.  This is because the PA backend defers output of function descriptors > and external

Re: ICE on bootstrap of libstdc++ for mingw-targets in add_bb_to_loop

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 12:41 PM, Kai Tietz wrote: > Hello, > > recent changes to cfgloop have caused an ICE on bootstrapping > libstdc++ for mingw targets.  I assume same ICE happens for cygwin > hosted gcc bootstrap, too. ICE happens on compiling of > gcc/libstdc++-v3/libsupc++/eh_alloc.cc > > C

Re: [PATCH] Fix PR52614

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 1:00 PM, Dominique Dhumieres wrote: >> I don't know enough about Fortran to know whether the same issues arise >> there.  Perhaps in Fortran a common symbol is always a common symbol and >> can never be a defined symbol.  If that is the case then for Fortran I >> think it w

[PATCH] Move tree_rest_of_compilation

2012-04-10 Thread Richard Guenther
To cgraphunit.c, where its only caller (should) reside. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-04-10 Richard Guenther * toplev.h (tree_rest_of_compilation): Remove. * tree-optimize.c (tree_rest_of_compilation): Likewise. * cgraph.

[Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread JonY
Hi, Patch OK? ChangeLog: tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings. Index: tree-parloops.c === --- tree-parloops.c (revision 186243) +++ tree-parloops.c (working copy) @@ -723,13 +723,15 @@

Re: Ada testcase CR line endings

2012-04-10 Thread Robert Dewar
On 4/10/2012 1:35 AM, Mike Stump wrote: So, I'd like to change all the ada testcases to use normal unix line endings. testsuite/gnat.dg/taft_type2_pkg.ads is an example if one such file, any objections? As long as the test is not about line endings this seems fine.

Re: [PATCH] Fix PR middle-end/52894

2012-04-10 Thread Dave Anglin
On 10-Apr-12, at 7:06 AM, Richard Guenther wrote: I can't immediately see how your description of "the list of pending externals and the vector" is deleted. pa.c keeps its own vector which references the decls and the only issue I see is that if you call assemble_external after processing

[patch, fortran] Trim spaces on list-directed reads

2012-04-10 Thread Thomas Koenig
Hello world, this patch effectively trims the spaces from the string on list-directed reads. This avoids the large overhead on processing these spaces when reading from long lines. I didn't do this for internal units which are arrays because this would need a separate calculation for each recor

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: > Hi, > > Patch OK? What kind of warning? > ChangeLog: > tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings. > > Index: tree-parloops.c > === > --- tree-parloops

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-04-10 Thread Ilya Enkovich
Ping. On Apr 4, 2012 at 1:02, Ilya Enkovich wrote: >> On Tue, Apr 3, 2012 at 3:49 AM, Ilya Enkovich wrote: On 3/04/2012, at 2:16 AM, Ilya Enkovich wrote: >> >> The point is that one can build a toolchain for i686-linux-gnu that will >> support both 32-bit and 64-bit multil

Re: [PATCH] Fix PR middle-end/52894

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 2:28 PM, Dave Anglin wrote: > On 10-Apr-12, at 7:06 AM, Richard Guenther wrote: > >> I can't immediately see how your description of "the list of pending >> externals >> and the vector" is deleted.  pa.c keeps its own vector which references >> the >> decls and the only iss

Re: ICE on bootstrap of libstdc++ for mingw-targets in add_bb_to_loop

2012-04-10 Thread Kai Tietz
Hi, issue was that TARGET_EXCEPT_UNWIND_INFO wasn't set for i386 architectures. As mingw targets are using SjLj, it is necessary that this hook is present. ChangeLog 2012-04-10 Kai Tietz PR c++/52918 * common/config/i386/i386-common.c (ix86_except_unwind_info): Add t

Re: [RFC ivopts] ARM - Make ivopts take into account whether pre and post increments are actually supported on targets.

2012-04-10 Thread Ramana Radhakrishnan
On 28 March 2012 11:13, Richard Guenther wrote: > On Wed, Mar 28, 2012 at 11:57 AM, Richard Guenther > wrote: >> On Tue, Mar 27, 2012 at 3:17 PM, Ramana Radhakrishnan >> wrote: >>> And the patch is now attached >> >> This does not look like it would compile on any other target. > > Looks li

Re: [PATCH][ARM] NEON DImode immediate constants

2012-04-10 Thread Andrew Stubbs
Ping. On 30/03/12 12:15, Andrew Stubbs wrote: On 28/02/12 16:20, Andrew Stubbs wrote: Hi all, This patch implements 64-bit immediate constant loads in NEON. The current state is that you can load const_vector, but not const_int. This is clearly not ideal. The result is a constant pool entry w

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread JonY
On 4/10/2012 20:37, Richard Guenther wrote: > On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: >> Hi, >> >> Patch OK? > > What kind of warning? > Oops, I forgot to mention gcc was complaining about missing braces. >> ChangeLog: >> tree-parloops.c (eliminate_local_variables): Add braces to suppress

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-10 Thread Richard Sandiford
Richard Guenther writes: > On Fri, Apr 6, 2012 at 10:13 AM, Richard Sandiford > wrote: >> Richard Guenther writes: They can affect shared memory in some ways like a call, but don't have many of the other attributes of call.  They are really more like an assignment or other o

[PATCH] Fix PR52888

2012-04-10 Thread Richard Guenther
This fixes the gimple_check_call_args routine to properly check for compatible aggregate types, something fold_convertible (which is otherwise more forgiving) does not handle. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-04-10 Richard Guenther

Symbol table 1/many: symtab_nodes

2012-04-10 Thread Jan Hubicka
Hi, this is very basis of the symbol table work. The basic idea is: 1) give cgraph node and varpool node common base (symtab node) 2) Move common data there: that is type, declaration, visibility flags, force_output, ipa references and other stuff. 3) Introduce symtab.c for basic symbol table

rfa: vectorize strided loads [1/2] [PR 18437]

2012-04-10 Thread Michael Matz
Hi, as preparation for the real patch in [2/2] this renames most uses of the word "stride" (and combinations thereof) in the vectorizer to something else. I've done this to not introduce even more confusion. The currently supported loads/stores aren't really generally strided, but of very co

RFC reminder: an alternative -fsched-pressure implementation

2012-04-10 Thread Richard Sandiford
Hi Vlad, Back in Decemember, when we were still very much in stage 3, I sent an RFC about an alternative implementation of -fsched-pressure. Just wanted to send a reminder now that we're in the proper stage: http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01684.html Ulrich has benchmarked it on ARM

Re: [PATCH] Fix PR middle-end/52894

2012-04-10 Thread Steven Bosscher
On Tue, Apr 10, 2012 at 2:44 PM, Richard Guenther wrote: > On Tue, Apr 10, 2012 at 2:28 PM, Dave Anglin wrote: >> On 10-Apr-12, at 7:06 AM, Richard Guenther wrote: >> >>> I can't immediately see how your description of "the list of pending >>> externals >>> and the vector" is deleted.  pa.c keeps

Re: [PING] allowing fwprop to propagate subregs

2012-04-10 Thread Richard Sandiford
"Ulrich Weigand" writes: > http://gcc.gnu.org/ml/gcc-patches/2012-03/msg01269.html I don't like approving patches I had a hand in, but since Paolo was happy, and since no-one else seems to care... OK. Thanks for getting this working. Richard

Re: [SH] PR 50751 - add HImode displacement addressing support

2012-04-10 Thread Kaz Kojima
Oleg Endo wrote: > The attached patch adds HImode addressing support. > Tested against rev. 186243 with > sudo make -k check RUNTESTFLAGS="--target_board=sh-sim > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m2a-single/-mb,-m4/-ml,-m4/-mb, > -m4-single/-ml,-m4-single/-mb,-m4a-single/-ml,-m4a-single/-mb}" > > and

rfa: vectorize strided loads [2/2] [PR 18437]

2012-04-10 Thread Michael Matz
Hi, and this implements generally strided loads where the stride is a loop-invariant (constant or ssa-name). We only do so if the load can't be handled by interleaving groups. The implementation is fairly straight forward: for (i = 0; i < n; i += stride) ... = array[i];

Re: Symbol table 2/many: break out partitioning code out of lto.c

2012-04-10 Thread Diego Novillo
On 4/10/12 9:32 AM, Jan Hubicka wrote: Hi, LTO partitioning logic is one of places that are really symmetric accross most types of symbols; also the implementation is convoluted now by split in between lto.c that computes cgraph/varpool node sets specifying partitions and lto-cgraph.c that comp

Re: Symbol table 1/many: symtab_nodes

2012-04-10 Thread Richard Guenther
On Tue, 10 Apr 2012, Jan Hubicka wrote: > Hi, > this is very basis of the symbol table work. The basic idea is: > > 1) give cgraph node and varpool node common base (symtab node) > 2) Move common data there: that is type, declaration, visibility flags, >force_output, ipa references and other

Re: [PATCH] Fix PR middle-end/52894

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 3:36 PM, Steven Bosscher wrote: > On Tue, Apr 10, 2012 at 2:44 PM, Richard Guenther > wrote: >> On Tue, Apr 10, 2012 at 2:28 PM, Dave Anglin wrote: >>> On 10-Apr-12, at 7:06 AM, Richard Guenther wrote: >>> I can't immediately see how your description of "the list of

Re: [SH] PR 50751 - add HImode displacement addressing support

2012-04-10 Thread Oleg Endo
On Tue, 2012-04-10 at 22:42 +0900, Kaz Kojima wrote: > Oleg Endo wrote: > > The attached patch adds HImode addressing support. > > Tested against rev. 186243 with > > sudo make -k check RUNTESTFLAGS="--target_board=sh-sim > > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m2a-single/-mb,-m4/-ml,-m4/-mb, > > -m4-sing

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread Kirill Yukhin
> > Yeah. And you don't need to change the FEs in any way, all that is needed > is to change the middle-end/expansion (builtins.c - e.g. get_memmodel) > and the backend (plus predefine the macros in the backend). > >Jakub Hi Jakub, Attached patch implements HLE support for __atomic_compar

Re: [SH] PR 50751 - add HImode displacement addressing support

2012-04-10 Thread Nathan Froyd
- Original Message - > > BTW, do you have the numbers of CSiBE with this? > > Only for "-m4-single -ml -O2 -mpretend-cmove" so far. > Not so spectacular :T > I'll also do a comparison of more variants to see if something went > really bad. It's a bit difficult to isolate the degradations

Re: RFC reminder: an alternative -fsched-pressure implementation

2012-04-10 Thread Ramana Radhakrishnan
> The condition I orignally set myself was that this patch should only > go in if it becomes the default on at least one architecture, > specifically ARM.  Ulrich tells me that Linaro have now made it > the default for ARM in their GCC 4.7 release, so hopefully Ramana > would be OK with doing the s

Re: [SH] PR 50751 - add HImode displacement addressing support

2012-04-10 Thread Oleg Endo
On Tue, 2012-04-10 at 07:14 -0700, Nathan Froyd wrote: > - Original Message - > > > BTW, do you have the numbers of CSiBE with this? > > > > Only for "-m4-single -ml -O2 -mpretend-cmove" so far. > > Not so spectacular :T > > I'll also do a comparison of more variants to see if something we

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread Jakub Jelinek
On Tue, Apr 10, 2012 at 06:12:08PM +0400, Kirill Yukhin wrote: > Attached patch implements HLE support for __atomic_compare_exchange_n. The target hook is definitely not appropriate, just define it in ix86_target_macros in i386-c.c instead or so. Jakub

Re: rfa: vectorize strided loads [2/2] [PR 18437]

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 3:46 PM, Michael Matz wrote: > Hi, > > and this implements generally strided loads where the stride is a > loop-invariant (constant or ssa-name).  We only do so if the load can't be > handled by interleaving groups.  The implementation is fairly straight > forward: > >    

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-10 Thread Dennis Gilmore
On Tue, 10 Apr 2012 12:18:51 +0300 Konstantinos Margaritis wrote: > On Tue, 10 Apr 2012 07:36:07 +0200 > Jakub Jelinek wrote: > > We really want consistency about the dynamic linker names etc. > > across different targets and sneaking silently multiarch paths on > > one architecture would make i

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 3:06 PM, JonY wrote: > On 4/10/2012 20:37, Richard Guenther wrote: >> On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: >>> Hi, >>> >>> Patch OK? >> >> What kind of warning? >> > > Oops, I forgot to mention gcc was complaining about missing braces. Not for me. And I fail to se

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 3:14 PM, Richard Sandiford wrote: > Richard Guenther writes: >> On Fri, Apr 6, 2012 at 10:13 AM, Richard Sandiford >> wrote: >>> Richard Guenther writes: > They can affect shared memory in some ways like a call, but don't have > many > of the other attribute

Re: PATCH: Define TRY_EMPTY_VM_SPACE for Linux/x32

2012-04-10 Thread H.J. Lu
On Thu, Apr 5, 2012 at 8:57 AM, H.J. Lu wrote: > On Thu, Apr 5, 2012 at 8:36 AM, Uros Bizjak wrote: >> On Thu, Apr 5, 2012 at 3:28 PM, H.J. Lu wrote: >> >> Looking at how other targets implement this check, I don't think that >> this is a problem at all. This issue only shows on a non-bo

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread H.J. Lu
On Tue, Apr 10, 2012 at 7:12 AM, Kirill Yukhin wrote: >> >> Yeah.  And you don't need to change the FEs in any way, all that is needed >> is to change the middle-end/expansion (builtins.c - e.g. get_memmodel) >> and the backend (plus predefine the macros in the backend). >> >>        Jakub > > Hi

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread Jakub Jelinek
On Tue, Apr 10, 2012 at 07:42:53AM -0700, H.J. Lu wrote: > > Attached patch implements HLE support for __atomic_compare_exchange_n. > > > > So, to emit HLE prefix, it is possible to do: > > int > > foo2 (int *p, int oldv, int newv) > > { > >  __atomic_compare_exchange_n (p, &oldv, newv, 0, __ATOMIC

Re: [RFC] Unconditionally clean up CFG before emitting prologue

2012-04-10 Thread Richard Guenther
On Mon, Apr 9, 2012 at 6:11 PM, Eric Botcazou wrote: >> Isn't the gimple cfg-cleanup we run post optimization (right before >> expansion) not enough?  Or the cfg-cleanup we perform right after expansion >> now? At least if the branches are really caused by the gimplification >> process I would exp

Re: RFC: PR rtl-optimization/52876: Sign extend 32 to 64bit then clear upper 32bits fails O1 or higher

2012-04-10 Thread H.J. Lu
On Thu, Apr 5, 2012 at 11:48 AM, H.J. Lu wrote: > Hi, > > CSE turns (reg:DI 64) > > (insn 6 3 7 2 (set (reg:DI 64) >        (sign_extend:DI (subreg/u:SI (reg/v/f:DI 63 [ addr ]) 0))) x.i:6 122 > {*extendsidi2_rex64} (nil)) > > into (reg/f:DI 64 [ addr ]).  But nonzero_bits1 in rtlanal.c has > > #i

[PATCH] Fix PR52912, more loop preserving and jump-threading fallout

2012-04-10 Thread Richard Guenther
This properly tells the CFG manipulation of the case where we thread through a loop exit - the duplicated header block will end up in the outer loop and the original loop structure will be preserved. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2012-04-10 Richard Gue

Patches to enable -ftrack-macro-expansion by default

2012-04-10 Thread Dodji Seketeli
Hello, I am proposing a series of patches which is supposed to address the remaining issues (I am aware of) preventing us from enabling the -ftrack-macro-expansion by default. The idea is to address each issue I notice in the course of trying to bootstrap the compiler and running the tests with -

Guard use of modulo in cshift (speedup protein)

2012-04-10 Thread Michael Matz
Hi, this patch speeds up polyhedrons protein on Bulldozer quite a bit. The things is that in this testcase cshift is called with a very short length (<=3) and that the shift amount always is less than the length. Surprisingly the division instruction takes up considerable amount of time, so m

[PATCH 01/11] Fix cpp_sys_macro_p with -ftrack-macro-expansion

2012-04-10 Thread Dodji Seketeli
Hello, cpp_sys_macro_p crashes when -ftrack-macro-expansion is on. The issue can be reproduced by running the tests: runtest --tool gcc --tool_opts="-ftrack-macro-expansion" cpp.exp=sysmac1.c runtest --tool gcc --tool_opts="-ftrack-macro-expansion" cpp.exp=sysmac2.c This is because it j

[PATCH] Fix PR52881, more loop preserving fallout with RTL optimizers

2012-04-10 Thread Richard Guenther
RTL optimizers perform CFG adjustments themselves rather than relying on cleanup_cfg (as the gimple level does). This makes it necessary to handle things all-over-the-place. This case is if-conversion performing forwarder block removal (well, it calls it "speculation"), removing empty loop latch

[PATCH 02/11] Fix token pasting with -ftrack-macro-expansion

2012-04-10 Thread Dodji Seketeli
This patch makes token pasting work with -ftrack-macro-expansion turned on. It improves some pasting related tests of the gcc.dg/cpp sub-directory. Tested and bootstrapped on x86_64-unknown-linux-gnu against trunk. Note that the bootstrap with -ftrack-macro-expansion exhibits other separate issu

[PATCH 03/11] Fix PCH crash on GTYed pointer-to-scalar field of a

2012-04-10 Thread Dodji Seketeli
Disclaimer: I am sorry for the length of this message. In essence, it's just a one liner fix in gengtype.c. I felt the need to explain extensively what I think I understood because it didn't seem obvious to me. So, when -ftrack-macro-expansion is activated, the PCH generation machinery can crash

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-10 Thread Konstantinos Margaritis
On Tue, 10 Apr 2012 09:32:22 -0500 Dennis Gilmore wrote: > every distro uses a unique triplet, by putting the triplet in there you > then need to get all distros to change to using the same triplets. I > personally prefer /libhfp rather than /libhf but I am ok with using > either. Any change from

Re: Guard use of modulo in cshift (speedup protein)

2012-04-10 Thread Steven Bosscher
On Tue, Apr 10, 2012 at 4:53 PM, Michael Matz wrote: > Hi, > > this patch speeds up polyhedrons protein on Bulldozer quite a bit.  The > things is that in this testcase cshift is called with a very short length > (<=3) and that the shift amount always is less than the length. > Surprisingly the di

Re: ICE on bootstrap of libstdc++ for mingw-targets in add_bb_to_loop

2012-04-10 Thread Kai Tietz
Sorry, for the noise. This patch just activates dw2 and therefore avoids the ICE. Continue on that. Kai

move warning_if_unused_value to c-common.c

2012-04-10 Thread Manuel López-Ibáñez
It is a C-family FE function, not sure how it ended up in stmt.c. OK to commit? Cheers, Manuel. Bootstrapped and regression tested with languages=all,ada,obj-c++ 2012-04-10 Manuel López-Ibáñez * c-family/c-common.c (warn_if_unused_valuer): Move definition to here. * tree.h

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-10 Thread Steve McIntyre
On Tue, Apr 10, 2012 at 09:32:22AM -0500, Dennis Gilmore wrote: >On Tue, 10 Apr 2012 12:18:51 +0300 >Konstantinos Margaritis wrote: > >> On Tue, 10 Apr 2012 07:36:07 +0200 >> Jakub Jelinek wrote: >> > We really want consistency about the dynamic linker names etc. >> > across different targets and

Re: Guard use of modulo in cshift (speedup protein)

2012-04-10 Thread Michael Matz
Hi, On Tue, 10 Apr 2012, Steven Bosscher wrote: > This is OK. r186283. > Do you think it would be worthwhile to do this transformation in the > middle end too, based on profile information for values? I'd think so, but it probably requires a new profiler that counts for how often 0 <= A <= B

Re: [PATCH] Fix PR52881, more loop preserving fallout with RTL optimizers

2012-04-10 Thread Steven Bosscher
On Tue, Apr 10, 2012 at 4:56 PM, Richard Guenther wrote: > I'm sure more RTL optimiziation fallout will pop up - and I wonder > if we should simply avoid modifying the CFG all over the place and > instead do that in cleanup_cfg.  Thus, in the if-conversion case, > simply do the speculation and lea

Re: rfa: vectorize strided loads [2/2] [PR 18437]

2012-04-10 Thread Michael Matz
Hi, On Tue, 10 Apr 2012, Richard Guenther wrote: > > +         vec_inv = build_constructor (vectype, v); > > +         new_temp = vect_init_vector (stmt, vec_inv, vectype, gsi); > > +         new_stmt = SSA_NAME_DEF_STMT (new_temp); > > +         mark_symbols_for_renaming (new_stmt); > > This sh

Re: move warning_if_unused_value to c-common.c

2012-04-10 Thread Gabriel Dos Reis
On Tue, Apr 10, 2012 at 10:25 AM, Manuel López-Ibáñez wrote: > It is a C-family FE function, not sure how it ended up in stmt.c. > > OK to commit? OK.

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread Andi Kleen
"H.J. Lu" writes: >> So, to emit HLE prefix, it is possible to do: >> int >> foo2 (int *p, int oldv, int newv) >> { >>  __atomic_compare_exchange_n (p, &oldv, newv, 0, __ATOMIC_ACQUIRE | >> __ATOMIC_USE_HLE, __ATOMIC_ACQUIRE); >>  return oldv; >> } > > This is wrong since HLE ACQUIRE/RELEASE has

Re: RFC reminder: an alternative -fsched-pressure implementation

2012-04-10 Thread Vladimir Makarov
On 04/10/2012 09:35 AM, Richard Sandiford wrote: Hi Vlad, Back in Decemember, when we were still very much in stage 3, I sent an RFC about an alternative implementation of -fsched-pressure. Just wanted to send a reminder now that we're in the proper stage: http://gcc.gnu.org/ml/gcc-patches/2011

Re: [PATCH] Caret diagnostics

2012-04-10 Thread Manuel López-Ibáñez
et_prefix): New. (pp_base_get_prefix): New. * common.opt (fdiagnostics-show-caret): New option. * doc/invoke.texi (fdiagnostics-show-caret): Document it. testsuite/ * lib/prune.exp: Add -fno-diagnostics-show-caret. caret-diagnostics-20120410.diff Description: Binary data

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-10 Thread Michael Edwards
FWIW, my use case for multiarch is not "sharing the root filesystem among multiple systems". It's "sharing the non-lib namespace (/etc, /bin, data) among multiple instruction sets / ABI variants on the same system". I don't need (/usr)?/s?bin to be decorated with a triplet, because the kernel

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread Uros Bizjak
On Tue, Apr 10, 2012 at 4:20 PM, Jakub Jelinek wrote: > On Tue, Apr 10, 2012 at 06:12:08PM +0400, Kirill Yukhin wrote: >> Attached patch implements HLE support for __atomic_compare_exchange_n. > > The target hook is definitely not appropriate, just define it in > ix86_target_macros in i386-c.c ins

Re: ICE on bootstrap of libstdc++ for mingw-targets in add_bb_to_loop

2012-04-10 Thread Kai Tietz
Hi, issue was caused by the patch for PR middle-end/52772, which just handles dw2. This patch makes sure that for sjlj we add new generated bb's for dispatching table to loop, too. ChangeLog 2012-04-10 Kai Tietz PR c++/52924 * except.c (sjlj_emit_dispatch_table): Add bb to l

Re: [PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-04-10 Thread Peter Bergner
On Mon, 2012-01-30 at 10:46 +0100, Richard Guenther wrote: > On Fri, Jan 27, 2012 at 5:56 PM, Peter Bergner wrote: > > This patch fixes PR16458 by using the type expression attached to a reg > > rtx to detect its signedness and generating unsigned compares when > > appropriate. However, we contin

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread Uros Bizjak
Hello! > > This is wrong since HLE ACQUIRE/RELEASE has nothing to do with > > C++ atomic acquire/release. You can have HLE RELEASE with C++ > > atomic acquire. > > It makes sense to combine the two. On x86 C++ atomic acquire/release > means the compiler cannot move references outside. For HLE > we

Re: Added better handling of outdated profile data. (issue 5989046)

2012-04-10 Thread asharif
On 2012/04/05 18:53:28, asharif wrote: Jan, please take a look and provide some feedback. Thanks, Ping? http://codereview.appspot.com/5989046/

Re: [patch] Fix PR52822 (stable_partition move-assigns object to itself) in trunk, 4.7, and 4.6

2012-04-10 Thread Paolo Carlini
Hi, For the mainline/4.7 version, you want to cast __pred to bool: !bool(__pred(*__first)). Also, isn't clear to me why you have __local_len in __find_if_not_n instead of just working on __len (and in any case please prefer just __local_len as condition instead of the redundant __local_len != 0;

Re: [patch] Fix PR52822 (stable_partition move-assigns object to itself) in trunk, 4.7, and 4.6

2012-04-10 Thread Paolo Carlini
.. ah: remember to add "PR libstdc++/52822" at the beginning of the ChangeLog entry, otherwise Bugzilla will not pick your commit! Thanks, Paolo.

[PATCH] Atom: Enabling unroll at O2 optimization level

2012-04-10 Thread Igor Zamyatin
Hi All! Here is a patch that enables unroll at O2 for Atom. This gives good performance boost on EEMBC 2.0 (~+8% in Geomean for 32 bits) with quite moderate code size increase (~5% for EEMBC2.0, 32 bits). Tested for i386 and x86-64, ok for trunk? Thanks, Igor ChangeLog: 2012-04-10  Yakovlev V

Re: [PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-04-10 Thread David Edelsohn
On Tue, Apr 10, 2012 at 1:36 PM, Peter Bergner wrote: > 2012-mm-dd  Peter Bergner   >            Michael Matz   > > gcc/ >        PR target/16458 >        * rtlanal.c (unsigned_reg_p): New function. >        * rtl.h (unsigned_reg_p): Prototype it. >        * config/rs6000/rs6000.c (rs6000_generat

Re: [PATCH] Caret diagnostics

2012-04-10 Thread Gabriel Dos Reis
On Tue, Apr 10, 2012 at 11:46 AM, Manuel López-Ibáñez wrote: > On 10 April 2012 00:28, Jason Merrill wrote: >> On 04/09/2012 04:01 PM, Manuel López-Ibáńez wrote: >>> >>> * It uses  the default cutoff as max_width, whatever it is (as >>> controlled by -fmessage-length). >>> * It uses the pretty-pr

follow up patch to clean up TODO_dump_func

2012-04-10 Thread Xinliang David Li
Hi Richard, this is a follow up patch for more cleanups. Bootstrap and tested on x86-64/linux. Ok for trunk? thanks, David todo_dump.p Description: Binary data cg Description: Binary data

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread NightStrike
On Tue, Apr 10, 2012 at 10:38 AM, Richard Guenther wrote: > On Tue, Apr 10, 2012 at 3:06 PM, JonY wrote: >> On 4/10/2012 20:37, Richard Guenther wrote: >>> On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: Hi, Patch OK? >>> >>> What kind of warning? >>> >> >> Oops, I forgot to mention g

Re: [PATCH] Caret diagnostics

2012-04-10 Thread Jason Merrill
On 04/10/2012 12:46 PM, Manuel López-Ibáñez wrote: + max_width = context->caret_max_width; + if (max_width<= 0) +max_width = INT_MAX; I don't think we need the test here; diagnostic_set_caret_max_width should make sure caret_max_width is set sensibly. Otherwise, yes, thanks. On 04/10/

Re: [PATCH] Caret diagnostics

2012-04-10 Thread Manuel López-Ibáñez
On 10 April 2012 20:52, Gabriel Dos Reis wrote: > On Tue, Apr 10, 2012 at 11:46 AM, Manuel López-Ibáñez > wrote: >> On 10 April 2012 00:28, Jason Merrill wrote: >>> On 04/09/2012 04:01 PM, Manuel López-Ibáńez wrote: * It uses  the default cutoff as max_width, whatever it is (as co

Re: [PATCH] Caret diagnostics

2012-04-10 Thread Manuel López-Ibáñez
On 10 April 2012 21:31, Jason Merrill wrote: > On 04/10/2012 12:46 PM, Manuel López-Ibáñez wrote: >> >> +  max_width = context->caret_max_width; >> +  if (max_width<= 0) >> +    max_width = INT_MAX; > > > I don't think we need the test here; diagnostic_set_caret_max_width should > make sure caret_

[PATCH 04/11] Fix expansion point loc for macro-like tokens

2012-04-10 Thread Dodji Seketeli
Consider the test case gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-5.c. Its interesting part is: #define A(x) vari x /* line 7. */ #define vari(x) #define B , varj int A(B) ; /* line 10. */ In its initial version, this test was being pre-processed as: # 1 "gcc/testsuite/gcc.

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread Andi Kleen
> In this case, can we reverse this sentence and just emit "lock > xacquire" for MEMMODEL_ACQUIRE and "lock xrelease" for > MEMMODEL_RELEASE ? Do we need separate HLE_* defines or can we somehow > recycle existing C++11 memmodel defines? No you absolutely can't. Transactions are quite different fr

[PATCH 05/11] Make expand_location resolve to locus in main source file

2012-04-10 Thread Dodji Seketeli
Apparently, quite some places in the compiler (like the C/C++ preprocessor, the debug info machinery) expect expand_location to resolve to locations that are in the main source file, even if the token at stake comes from a macro that was defined in a header somewhere. Turning on -ftrack-macro-expa

[PATCH 06/11] Strip "" loc from displayed expansion context

2012-04-10 Thread Dodji Seketeli
Now that diagnostics for tokens coming from macro expansions point to the spelling location of the relevant token (and then displays the context of the expansion), some ugly (not so seldom) corner cases can happen. When the relevant token is a built-in token (which means the location of that token

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread H.J. Lu
On Tue, Apr 10, 2012 at 9:34 AM, Andi Kleen wrote: > "H.J. Lu" writes: > >>> So, to emit HLE prefix, it is possible to do: >>> int >>> foo2 (int *p, int oldv, int newv) >>> { >>>  __atomic_compare_exchange_n (p, &oldv, newv, 0, __ATOMIC_ACQUIRE | >>> __ATOMIC_USE_HLE, __ATOMIC_ACQUIRE); >>>  retu

Re: [i386, patch, RFC] HLE support in GCC

2012-04-10 Thread Andi Kleen
> If it is the case, can we generate HLE RELEASE/ACQUIRE > prefix automatically for C++ atomics via -mhle command line option. > Then you don't need to modify the source codes to enable HLE support. No, for HLE someone needs to decide whether HLE is beneficial for a given lock. There are cases wh

Re: [C++ Patch] for c++/52465

2012-04-10 Thread Fabien Chêne
2012/4/7 Jason Merrill : > On 04/07/2012 11:37 AM, Fabien Chêne wrote: >> >> Perhaps it is more correct like that, in cp_parser_set_decl_spec_type ? > > Even that seems late.  Why not just return the target decl from > cp_parser_class_name? Ah yes, that's slightly better. (I've kept the NULL check

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-10 Thread Carlos O'Donell
On Tue, Apr 3, 2012 at 6:56 PM, Joseph S. Myers wrote: > (e) Existing practice for cases that do use different dynamic linkers is > to use a separate library directory, not just dynamic linker name, as in > lib32 and lib64 for MIPS or libx32 for x32; it's certainly a lot easier to > make two sets

[PATCH 07/11] Fix -Wuninitialized for -ftrack-macro-expansion

2012-04-10 Thread Dodji Seketeli
Besides the warning emitted by warn_uninit, this function wants to hint the user at where the uninitialized variable was declared, for cases where the declaration location is outside the current function. Now that expand_location expands to the location that is in the main source file (even for -f

Re: [PATCH] Caret diagnostics

2012-04-10 Thread Manuel López-Ibáñez
On 10 April 2012 21:41, Manuel López-Ibáñez wrote: > On 10 April 2012 21:31, Jason Merrill wrote: >> On 04/10/2012 12:46 PM, Manuel López-Ibáñez wrote: >>> >>> +  max_width = context->caret_max_width; >>> +  if (max_width<= 0) >>> +    max_width = INT_MAX; >> >> >> I don't think we need the test

Re: Ada testcase CR line endings

2012-04-10 Thread Mike Stump
On Apr 10, 2012, at 5:24 AM, Robert Dewar wrote: > On 4/10/2012 1:35 AM, Mike Stump wrote: >> So, I'd like to change all the ada testcases to use normal unix line endings. >> >> testsuite/gnat.dg/taft_type2_pkg.ads >> >> is an example if one such file, any objections? > > As long as the test is

Re: [PATCH] Caret diagnostics

2012-04-10 Thread Mike Stump
On Apr 10, 2012, at 11:52 AM, Gabriel Dos Reis wrote: > On Tue, Apr 10, 2012 at 11:46 AM, Manuel López-Ibáñez > wrote: >> On 10 April 2012 00:28, Jason Merrill wrote: >>> On 04/09/2012 04:01 PM, Manuel López-Ibáńez wrote: * It uses the default cutoff as max_width, whatever it is (as >

  1   2   >