[gem5-dev] Review Request 3704: style: change NULL to nullptr in syscall files

--- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3701: syscall_emul: [PATCH 20/22] add the tgkill system call

c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3701/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3701: syscall_emul: [PATCH 20/22] add the tgkill system call

c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3701/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

src/arch/arm/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/arch/generic/types.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/arch/arm/linux/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3696/diff/ Testing --- Thanks, Brandon

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/arch/x86/linux/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/sim/Process.py c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3681/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

> On Nov. 8, 2016, 4:56 p.m., Jason Lowe-Power wrote: > > src/sim/system.hh, line 543 > > <http://reviews.gem5.org/r/3681/diff/1/?file=63244#file63244line543> > > > > Can this just be an std::set? This is only used to make sure there > > are no dupli

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3681/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3681/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

, visit: http://reviews.gem5.org/r/3681/#review9027 ------- On Nov. 7, 2016, 9:56 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. T

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

On Nov. 10, 2016, 10:52 p.m., Brandon Potter wrote: > > Minor issue, otherwise it LGTM, assuming you address Jason's comments as > > well. I'm going to create a separate patch that does this after all of my other patches are applied. I don't want to have to go through each one

Re: [gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

/se_signal.hh PRE-CREATION src/sim/SConscript c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3700/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3702/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

needs to be implemented for the other architectures too.) - Brandon Potter On Oct. 27, 2016, 7:45 a.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revie

Re: [gem5-dev] Review Request 3680: syscall_emul: [patch 13/22] add system call retry capability

/arch/arm/faults.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3680/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3703: syscall_emul: [PATCH 22/22] ignore system calls that are unimplemented.

11711:6fd39a6e6db8 --- syscall_emul: [PATCH 22/22] ignore system calls that are unimplemented. Diffs - src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3703/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

://reviews.gem5.org/r/3702/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3701: syscall_emul: [PATCH 20/22] add the tgkill system call

/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3700/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3699: syscall_emul: [PATCH 18/22] refactor and add functionality for dup, dup2, and pipe

/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3699/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3698: syscall_emul: [PATCH 17/22] refactor and add functionality to open syscall family

/linux.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3698/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http

[gem5-dev] Review Request 3697: style: [PATCH 16/22] correct some style issues

: http://reviews.gem5.org/r/3697/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/x86/types.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/cpu/checker/thread_context.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3696/diff/ Testing --- Thanks, Brandon Potter ___ gem5

[gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3681/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman

Re: [gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

nerated e-mail. To reply, visit: http://reviews.gem5.org/r/3674/#review8933 ------- On Oct. 17, 2016, 3:23 p.m., Brandon Potter wrote: > > --- > This is an automatic

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

.org/r/3662/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

.org/r/3662/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

f multiple types of Process classes, but there could have been a good > reason. I haven't run into any problems with this code before. I was just > suggesting a little more housekeeping while you were here. > > Brandon Potter wrote: > Really, I'd rather not alter how this is curr

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

PRE-CREATION src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3671/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

> On Oct. 17, 2016, 10:17 p.m., Michael LeBeane wrote: > > src/sim/fd_entry.hh, line 140 > > <http://reviews.gem5.org/r/3676/diff/1/?file=61681#file61681line140> > > > > Can you rename this to something more descriptive, like > > HostMappedFDEntry? &g

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3676/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3676/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

---- On Oct. 17, 2016, 3:41 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3676/ > --- >

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

be inferred by the context. Many of the fields were left uninitialized so it was bug prone.) Anyways, this is pertinent. Thanks for highlighting it. (I might end up going this route.) - Brandon --- This is an auto

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

n --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8885 --- On Oct. 17, 2016, 3:17 p.m., Brandon Potter

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

t feedback on how to handle them. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review8873 --- On Oct. 17, 2016

Re: [gem5-dev] Review Request 3673: syscall_emul: [patch 7/22] remove numCpus method

ss. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3673/#review8893 --- On Oct. 17, 2016, 3:20 p.m., Brand

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

n automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8885 ----------- On Oct. 17, 2016, 3:17 p.m., Brandon Potter wrote: > > --- > This is

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

Why this change? "size" puts the end of the line past our restriction - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8885 -----------

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8864 ------- On Oct. 17, 2016, 3:17 p.m., Brandon Potter wrote: > > ---

[gem5-dev] Review Request 3682: syscall_emul: remove TGT_MMAP_* flags that break OSX build

/arch/alpha/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3682/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3680: syscall_emul: [patch 13/22] add system call retry capability

/syscall_desc.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3680/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3679: style: [patch 12/22] fix preliminary style issues for subsequent fault patch

://reviews.gem5.org/r/3679/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3677: syscall_emul: [patch 11/22] extend functionality of fcntl

4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/alpha/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3677/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http

[gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

://reviews.gem5.org/r/3676/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3674/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

) - src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3675/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3673: syscall_emul: [patch 7/22] remove numCpus method

/tru64/tru64.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/alpha/tru64/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3673/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev

[gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

code. Diffs - src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3672/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

[gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/sparc/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3671/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3670/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscallreturn.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3662/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

4a86763c0b30cccba0f56c7f48637a46a4663b06 src/cpu/simple/timing.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/cpu/simple_thread.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3660/diff/ Testing --- Thanks, Brandon Potter

Re: [gem5-dev] Review Request 3643: style: [patch 3/22] reduce include dependencies in some headers

://reviews.gem5.org/r/3643/diff/ Testing --- util/regress Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3660: style: [patch 1/~22] use /r/3648/ to reorganize includes

/vtophys.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/base/atomicio.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/base/bigint.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3660/diff/ Testing --- Thanks, Brandon Potter

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

ons of the same thing to make it work. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review8858 -------

[gem5-dev] Review Request 3675: syscall_emul: remove unused global variable (num_processes)

4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3675/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

.org/r/3670/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: move SyscallDesc into its own .hh and .cc files

/3662/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3662: syscall_emul: move SyscallDesc into its own .hh and .cc files

---------- On Oct. 11, 2016, 9:06 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3662/ > -

Re: [gem5-dev] Review Request 3662: syscall_emul: move SyscallDesc into its own .hh and .cc files

/syscall_debug_macros.hh PRE-CREATION src/sim/syscall_desc.hh PRE-CREATION Diff: http://reviews.gem5.org/r/3662/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3643: style: reduce include dependencies in some headers

/diff/ Testing --- util/regress Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3661: style: reduce include dependencies in some headers

220fa4099b9a91526b8a1828f27cf1a9f3c15837 src/base/bitfield.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 src/base/bitunion.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 src/base/time.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 Diff: http://reviews.gem5.org/r/3661/diff/ Testing --- Thanks, Brandon Potter

[gem5-dev] Review Request 3662: syscall_emul: move the SyscallDesc into its own class

/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3660: style: use http://reviews.gem5.org/r/3648/ to reorganize includes

220fa4099b9a91526b8a1828f27cf1a9f3c15837 src/arch/x86/system.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 src/arch/x86/tlb.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 Diff: http://reviews.gem5.org/r/3660/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

Re: [gem5-dev] Review Request 3648: style: Add options to select checkers and apply fixes

> On Oct. 7, 2016, 10:24 p.m., Brandon Potter wrote: > > Do you think it's worthwhile to adopt a more detailed organization for > > headers? > > > > Currently, we have this: > > 1) primary header (foo.hh for foo.cc) > > 2) mix of C/C++ headers alphab

[gem5-dev] Review Request 3650: style: remove err.h to prevent a name collision

like panic and fatal). This reordering may cause further issues for poorly named macros so we should discuss this more generally. Diffs - src/base/loader/dtb_object.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 Diff: http://reviews.gem5.org/r/3650/diff/ Testing --- Tha

Re: [gem5-dev] Review Request 3648: style: Add options to select checkers and apply fixes

easier to identify an include if you happen to glance up at the header sections, but that seems minor and probably isn't their justification. Does anyone else have thoughts on the topic? - Brandon Potter On Oct. 7, 2016, 3:11 p.m., Andreas Sandberg wrote

Re: [gem5-dev] Review Request 3647: ruby: Fix broken regressions

gem5-public-process/src/python/m5/SimObject.py", line 1105, in __getattr__ raise AttributeError, err_string AttributeError: object 'SimpleIntLink' has no attribute 'dst_node' (C++ object is not yet constructed, so wrapped C++ methods are unavailable.) - Brandon Potter On Oct. 7, 2016,

Re: [gem5-dev] Review Request 3643: style: reduce include dependencies in some headers

-- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3643/#review8779 ----------- On Oct. 5, 2016, 4:27 p.m., Brandon Potter wrote: > > --- &g

Re: [gem5-dev] Review Request 3643: style: reduce include dependencies in some headers

fixed, I can try to see if I can pursue this for the remaining directories in "src". Anyways, the patch is going through regressions now. I'll post the update when it finishes. - Brandon --- This is an a

[gem5-dev] Review Request 3643: style: reduce include dependencies in some headers

/ Testing --- util/regress Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3635: gdb: Adds a warning in case gdb is attached multiple times

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3635/#review8756 --- Ship it! Ship It! - Brandon Potter On Sept. 27, 2016, 10:08 p.m

Re: [gem5-dev] Review Request 3583: syscall_emul: Added getdents and getdents64 syscalls

em5.org/r/3583/#comment7523> remove whitespace on lines 305, 307, 311, and 313 src/sim/syscall_emul.cc (line 363) <http://reviews.gem5.org/r/3583/#comment7521> space around '=' src/sim/syscall_emul.cc (line 383) <http://reviews.gem5.org/r/3583/#comment7522> spac

Re: [gem5-dev] Review Request 3583: syscall_emul: Added getdents and getdents64 syscalls

d the code. Otherwise, the errno value might get clobbered before you return it. src/sim/syscall_emul.cc (line 380) <http://reviews.gem5.org/r/3583/#comment7474> space - Brandon Potter On Aug. 8, 2016, 9:18 a.m., Nicolas Derumigny wrote: > > ---

Re: [gem5-dev] Review Request 3580: cpu, mem, sim: Enable KVM support for Ruby

not personally familiar enough with why the shadow memory is needed > to be able to say how much effort it would take to remove, but I believe so. > > Brandon Potter wrote: > Providing background since some might not be familiar with the problem. > > __The following lin

Re: [gem5-dev] Review Request 3580: cpu, mem, sim: Enable KVM support for Ruby

> On Aug. 5, 2016, 7:15 a.m., Andreas Hansson wrote: > > I see how this works as a stop gap, but ultimately I would like to push for > > the removal of the shadow memory as the first option. Is it really that > > much effort? > > David Hashe wrote: > I'm not personally familiar enough

Re: [gem5-dev] Review Request 3582: syscall_emu: Corrected a bug on the syscall "read()" when reading EOF

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3582/#review8556 --- Ship it! Ship It! - Brandon Potter On July 23, 2016, 1:16 p.m

Re: [gem5-dev] Review Request 3451: ruby: change clock periods for requests associated with ruby port

and testing it. We've talked about it here at AMD and it will be solved at some point in the future. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3451/#review826

Re: [gem5-dev] Review Request 3451: ruby: change clock periods for requests associated with ruby port

of the clock period used by the ruby system) when issuing requests through the ruby port object to attached objects. Diffs (updated) - src/mem/ruby/system/RubyPort.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3451/diff/ Testing --- Thanks, Brandon Potter

Re: [gem5-dev] Review Request 3442: ruby: allows multiple instances of ruby to be invoked

/mem/ruby/system/Sequencer.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca src/mem/ruby/system/Sequencer.py cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3442/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

Re: [gem5-dev] Review Request 3442: ruby: allows multiple instances of ruby to be invoked

eview8203 --- On April 4, 2016, 11:45 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3442/ > -

[gem5-dev] Review Request 3451: ruby: change clock periods for requests associated with ruby port

issuing requests through the ruby port object to attached objects. Diffs - src/mem/ruby/system/RubyPort.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3451/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev

Re: [gem5-dev] Review Request 3433: ruby: improved component mapping

and everything correctly). - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3433/#review8222 --- On April

Re: [gem5-dev] Review Request 3433: ruby: improved component mapping

eply, visit: http://reviews.gem5.org/r/3433/#review8222 ------- On April 4, 2016, 11:43 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3433/ > -

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

h that needs to be applied before this? > > Brandon Potter wrote: > This change fixes the L0Cache enumeration problem mentioned above: > http://reviews.gem5.org/r/3440/ > > All of the patches are posted to ReviewBoard. This review request has a > description of th

Re: [gem5-dev] Review Request 3424: ruby: add parameters to functions related to addresses

st functions. > > > > Maybe I'm wrong, and maybe it's actually worse this way. What do you > > think? > > Brandon Potter wrote: > If you make these functions members of the RubySystem object, you run > into the issue where you need to pass the RubySystem

Re: [gem5-dev] Review Request 3428: ruby: pass in block size to ENTRY objects with block size

e bigger picture here? > > Brandon Potter wrote: > __TL;DR: Never uses global variables, static class members, or static > variable declarations in function bodies. If you do, someone will come > knocking on your office door in the future; it might be me.__ > > The bigge

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

nnecting them directly to the L1 caches. Since both are private to the > > connected core, it seems superfluous to run their activity through the > > network; They only communicate with each other through these MessageBuffers. > > > > Is there a bigger need for this t

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

do not think that my other changes affect it (although I am not %100 sure; were quite a few changes in my patches). - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3441/#review8142 --

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

> On April 13, 2016, 6:17 p.m., Jason Lowe-Power wrote: > > Before this patch this protocol was broken? From the changes, it doesn't > > even look like it would have compiled. Is this true? In one way I'm shocked > > this happend. In another I'm not surprised at all... :

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

upported protocols. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3441/#review8209 --- On April 4, 2016, 1

Re: [gem5-dev] Review Request 3421: ruby: add a couple of members to ruby objects to remove statics

. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3421/#review8175 --- On April 4, 2016, 11:40 p.m., Brandon Potter wrote: >

Re: [gem5-dev] Review Request 3422: ruby: change function signature for functional_read/write

y patches, I'm having a hard time following. > > I really don't like the idea of passing around this parameter everywhere. > I'd like to understand better the problem so I can try my hand at a cleaner > solution. > > Brandon Potter wrote: > Right, I broke t

Re: [gem5-dev] Review Request 3422: ruby: change function signature for functional_read/write

lly generated e-mail. To reply, visit: http://reviews.gem5.org/r/3422/#review8178 ----------- On April 4, 2016, 11:40 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.or

Re: [gem5-dev] Review Request 3424: ruby: add parameters to functions related to addresses

st functions. > > > > Maybe I'm wrong, and maybe it's actually worse this way. What do you > > think? > > Brandon Potter wrote: > If you make these functions members of the RubySystem object, you run > into the issue where you need to pass the RubySystem

Re: [gem5-dev] Review Request 3424: ruby: add parameters to functions related to addresses

lable. Let me know if you disagree; I'm open to further suggestions. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3424/#review8180 ----------- On April 4, 2016, 11:40 p.m., Brandon Potter wrote: > >

Re: [gem5-dev] Review Request 3432: base: stats: add function for printing text to output

> On April 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > Could you explain why? > > > > In general, for all of these patches, could you please add a brief > > description of the "why"? > > Brandon Potter wrote: > The diatribe that I just po

Re: [gem5-dev] Review Request 3433: ruby: improved component mapping

h the XBar) already has support for > > interleaving and hashing. > > Brandon Potter wrote: > With these patches that handle routing based on certain ranges of the > address, it seems that this is well aligned for that adoption. I'm not too > familiar with how classic does it's

Re: [gem5-dev] Review Request 3419: ruby: remove the SubBlock class

cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/VIPERCoalescer.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3419/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3149: ruby: Fix block_on behavior

ng depending on how the reader interprets it; one might just glance at this code and think that the mandatory queue gets blocked when in reality it's all of the other message buffers. - Brandon Potter On Oct. 16, 2015, 1:55 p.m., Joel He

<    1   2   3   4   5   6   >