[gem5-dev] Change in gem5/gem5[develop]: arch: Eliminate the unused HasUnalignedMemAcc constant.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32923 ) Change subject: arch: Eliminate the unused HasUnalignedMemAcc constant. .. arch: Eliminate the unused HasUnalignedMemAcc

[gem5-dev] Change in gem5/gem5[develop]: arch: Make ThreadInfo::curThreadInfo virtual, protected.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32921 ) Change subject: arch: Make ThreadInfo::curThreadInfo virtual, protected. .. arch: Make ThreadInfo::curThreadInfo virtual,

[gem5-dev] Change in gem5/gem5[develop]: arch: Eliminate an unused pair of constants from isa_traits.hh.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32922 ) Change subject: arch: Eliminate an unused pair of constants from isa_traits.hh. .. arch: Eliminate an unused pair of

[gem5-dev] Change in gem5/gem5[develop]: x86: Replace getDoubleBits with floatToBits64.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32927 ) Change subject: x86: Replace getDoubleBits with floatToBits64. .. x86: Replace getDoubleBits with floatToBits64. The

[gem5-dev] Change in gem5/gem5[develop]: mem: Use the System object's getGuestByteOrder in AbstractMemory.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32925 ) Change subject: mem: Use the System object's getGuestByteOrder in AbstractMemory. .. mem: Use the System object's

[gem5-dev] Change in gem5/gem5[develop]: arch: Remove the "inline" keyword in ThreadInfo.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32920 ) Change subject: arch: Remove the "inline" keyword in ThreadInfo. .. arch: Remove the "inline" keyword in ThreadInfo.

[gem5-dev] Change in gem5/gem5[develop]: x86: Fix some style issues in the microcode ROM class.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32896 ) Change subject: x86: Fix some style issues in the microcode ROM class. .. x86: Fix some style issues in the microcode ROM

[gem5-dev] Change in gem5/gem5[develop]: arch: Get the byte order from sys and not TheISA::.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32919 ) Change subject: arch: Get the byte order from sys and not TheISA::. .. arch: Get the byte order from sys and not TheISA::.

[gem5-dev] Change in gem5/gem5[develop]: x86: Style fix in the decoder class.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32894 ) Change subject: x86: Style fix in the decoder class. .. x86: Style fix in the decoder class. Change-Id:

[gem5-dev] Re: Remove CP annotation support?

2020-08-19 Thread Gabe Black via gem5-dev
https://gem5-review.googlesource.com/c/public/gem5/+/32954 On Wed, Aug 19, 2020 at 7:57 PM Gabe Black wrote: > Since everybody is in agreement so far, I'll probably put together a CL in > the next day or two to remove this code. I'll add everybody to the review > and wait a little bit just to

[gem5-dev] Re: Remove CP annotation support?

2020-08-19 Thread Gabe Black via gem5-dev
Since everybody is in agreement so far, I'll probably put together a CL in the next day or two to remove this code. I'll add everybody to the review and wait a little bit just to make sure there aren't any last minute objections. Gabe On Wed, Aug 19, 2020 at 11:05 AM Steve Reinhardt wrote: > I

[gem5-dev] Change in gem5/gem5[develop]: kern: Stop using TheISA::GuestByteOrder in Linux::dumpDmesg.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32924 ) Change subject: kern: Stop using TheISA::GuestByteOrder in Linux::dumpDmesg. .. kern: Stop using TheISA::GuestByteOrder in

[gem5-dev] Change in gem5/gem5[develop]: arch: Don't add contents to the TheISA namespace in arch/generic.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32929 ) Change subject: arch: Don't add contents to the TheISA namespace in arch/generic. .. arch: Don't add contents to the

[gem5-dev] Change in gem5/gem5[develop]: dev,arm: Stop using TheISA in ARM specific files.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32928 ) Change subject: dev,arm: Stop using TheISA in ARM specific files. .. dev,arm: Stop using TheISA in ARM specific files.

[gem5-dev] Change in gem5/gem5[develop]: cpu: Don't construct and then copy the decoder in SimpleThread.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32900 ) Change subject: cpu: Don't construct and then copy the decoder in SimpleThread. .. cpu: Don't construct and then copy the

[gem5-dev] Change in gem5/gem5[develop]: arch: Fix a small style issue in Linux::ThreadInfo.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32918 ) Change subject: arch: Fix a small style issue in Linux::ThreadInfo. .. arch: Fix a small style issue in Linux::ThreadInfo.

[gem5-dev] Re: Remove CP annotation support?

2020-08-19 Thread Steve Reinhardt via gem5-dev
I assume this is leftover from Ali's thesis, which sadly did not take the world by storm as it deserved to. So I expect he'd be OK with us getting rid of it, as would I. Steve On Wed, Aug 19, 2020 at 8:57 AM Jason Lowe-Power wrote: > Hi all, > > Generally, I think that any code that doesn't

[gem5-dev] Re: gem5 documentation repo

2020-08-19 Thread Bobby Bruce via gem5-dev
Thanks Andreas! Documentation is still an ongoing process (and probably always will be :)), but we're happy things are in a better place these days. In regards to your idea of moving the website repo (or the documentation within the repo) into the gem5 repo. I have four counter-arguments to this

[gem5-dev] Re: Remove CP annotation support?

2020-08-19 Thread Jason Lowe-Power via gem5-dev
Hi all, Generally, I think that any code that doesn't have tests and we are not actively supporting should be removed. We can always resurrect it with about the same amount of work as getting it up to date today. Plus, we can now say "the code is available in gem5-20." We have an extremely lean

[gem5-dev] gem5 documentation repo

2020-08-19 Thread Andreas Sandberg via gem5-dev
Hi All, I just had a quick look at the excellent new documentation section on the gem5 website. A big thanks to everyone who has worked on making that a reality! One thing that I noticed when browsing the documentation is hosted in the website repo and not the code repo. Would it make sense to

[gem5-dev] Change in gem5/gem5[develop]: misc: Replace scalar TypedBufferArg with VPtr.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/31755 ) Change subject: misc: Replace scalar TypedBufferArg with VPtr. .. misc: Replace scalar TypedBufferArg with VPtr. Change-Id:

[gem5-dev] Remove CP annotation support?

2020-08-19 Thread Gabe Black via gem5-dev
Hi folks. I was doing some spelunking trying to eliminate more ISA related dependencies from common code, and I ran across the CPA (critical path annotation) support in, among maybe a few other places, base/cp_annotate.cc. This code can't actually compile since it depends on there being a

[gem5-dev] Change in gem5/gem5[develop]: dev,arm: Stop using TheISA in ARM specific files.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32928 ) Change subject: dev,arm: Stop using TheISA in ARM specific files. .. dev,arm: Stop using TheISA in ARM specific

[gem5-dev] Change in gem5/gem5[develop]: arch: Make ThreadInfo::curThreadInfo virtual, protected.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32921 ) Change subject: arch: Make ThreadInfo::curThreadInfo virtual, protected. .. arch: Make ThreadInfo::curThreadInfo

[gem5-dev] Change in gem5/gem5[develop]: arch: Don't add contents to the TheISA namespace in arch/generic.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32929 ) Change subject: arch: Don't add contents to the TheISA namespace in arch/generic. .. arch: Don't add contents

[gem5-dev] Change in gem5/gem5[develop]: x86: Replace getDoubleBits with floatToBits64.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32927 ) Change subject: x86: Replace getDoubleBits with floatToBits64. .. x86: Replace getDoubleBits with floatToBits64.

[gem5-dev] Change in gem5/gem5[develop]: kern: Stop using TheISA::GuestByteOrder in Linux::dumpDmesg.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32924 ) Change subject: kern: Stop using TheISA::GuestByteOrder in Linux::dumpDmesg. .. kern: Stop using

[gem5-dev] Change in gem5/gem5[develop]: arch: Fix a small style issue in Linux::ThreadInfo.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32918 ) Change subject: arch: Fix a small style issue in Linux::ThreadInfo. .. arch: Fix a small style issue in

[gem5-dev] Change in gem5/gem5[develop]: arch: Eliminate an unused pair of constants from isa_traits.hh.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32922 ) Change subject: arch: Eliminate an unused pair of constants from isa_traits.hh. .. arch: Eliminate an unused

[gem5-dev] Change in gem5/gem5[develop]: arch: Eliminate the unused HasUnalignedMemAcc constant.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32923 ) Change subject: arch: Eliminate the unused HasUnalignedMemAcc constant. .. arch: Eliminate the unused

[gem5-dev] Change in gem5/gem5[develop]: mem: Use getGuestByteOrder in the indirect memory prefetcher.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32926 ) Change subject: mem: Use getGuestByteOrder in the indirect memory prefetcher. .. mem: Use getGuestByteOrder in

[gem5-dev] Change in gem5/gem5[develop]: arch: Remove the "inline" keyword in ThreadInfo.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32920 ) Change subject: arch: Remove the "inline" keyword in ThreadInfo. .. arch: Remove the "inline" keyword in

[gem5-dev] Change in gem5/gem5[develop]: arch: Get the byte order from sys and not TheISA::.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32919 ) Change subject: arch: Get the byte order from sys and not TheISA::. .. arch: Get the byte order from sys and not

[gem5-dev] Change in gem5/gem5[develop]: mem: Use the System object's getGuestByteOrder in AbstractMemory.

2020-08-19 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32925 ) Change subject: mem: Use the System object's getGuestByteOrder in AbstractMemory. .. mem: Use the System

[gem5-dev] Change in gem5/gem5[develop]: arch-riscv: Add float registers in copyRegs

2020-08-19 Thread Ian Jiang (Gerrit) via gem5-dev
Ian Jiang has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32934 ) Change subject: arch-riscv: Add float registers in copyRegs .. arch-riscv: Add float registers in copyRegs The

[gem5-dev] Change in gem5/gem5[develop]: tests: Removed m5threads tests from .testignore

2020-08-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32916 ) Change subject: tests: Removed m5threads tests from .testignore .. tests: Removed m5threads tests from

[gem5-dev] Change in gem5/gem5[develop]: tests: Removed the hello tests from .testignore

2020-08-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32914 ) Change subject: tests: Removed the hello tests from .testignore .. tests: Removed the hello tests from

[gem5-dev] Change in gem5/gem5[develop]: tests: Added tests/gem5/resources to .gitignore

2020-08-19 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32915 ) Change subject: tests: Added tests/gem5/resources to .gitignore .. tests: Added tests/gem5/resources to