Patch Set 2:
Rebased on top of current master + fixed whitespace with if (one in each commit
actually).
--
To view, visit https://gerrit.osmocom.org/3063
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3063
to look at the new patch set (#2).
tests: osmo-pcap: Fix per packet timer
Before this commit, the gap time between 2 packets {n-1, n} was being
applied to {n, n+1}.
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3064
to look at the new patch set (#2).
tests: osmo-pcap: Allow different l2 pkts
Before this patch, ETH was assumed and other types were not supported.
This patch also adds
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3064
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie62fa0a8e45e1e141edb64b116dad185ad9c7a5f
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3063/1/tests/osmo-pcap-test/pcap.c
File tests/osmo-pcap-test/pcap.c:
Line 112: if(p->deliver_msg) {
if 'if' was a function...
--
To view, visit https://gerrit.osmocom.org/3063
To unsubscribe, visit
Patch Set 1:
Gentle ping for this one. It's been in review process for more than a month now.
Is there something preventing to merge it?
--
To view, visit https://gerrit.osmocom.org/3063
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: add osmo_sccp_addr_set_ssn()
..
add osmo_sccp_addr_set_ssn()
Will be used by e.g. osmo-hnbgw to add an SSN to addresses obtained from the
sccp address
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7_vty_init: ensure a talloc ctx is set by user
..
osmo_ss7_vty_init: ensure a talloc ctx is set by user
Drop the separate
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3367
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a56ec170d4e91ce070f6fa9c9cfe5bbc121186
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3366
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e6d656871f952be8e719573fedf2154832841d7
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3365
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75c67d289693f1c2a049ac61cf2b2097d6e5687d
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3363
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1aedd7894acd69ddc887cd65a8a0df4b38c
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3364
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e0aa706867e7b1de7f7a6071e3c8af89772af0
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3362
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2f31b023b08cba2f2ee8234e6108efcaca41c0
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3361
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6b7188d004033e75e9c41f4a65c418d13a79c5
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 3:
It is likely we will at some point have secondary point codes. Hence, I would
prefer to either have a sub-structure that encapsulates the uint32_t and the
valid flag, so that type and related code/functions can be re-used (e.g.
something like is_pc_valid() inline function that
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3360
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4e7f47979001f7856b0b3665c9e94982e75e490
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3359
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b46269dbe7909e52873ace3f720f6292a4516c
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3448
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36c5ecf943b978d846884a1c4b638dccd89da3b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: rf.adoc: Fix table rendering for path loss models
..
rf.adoc: Fix table rendering for path loss models
Change-Id:
Review at https://gerrit.osmocom.org/3448
rf.adoc: Fix table rendering for path loss models
Change-Id: Ia36c5ecf943b978d846884a1c4b638dccd89da3b
---
M common/chapters/rf.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add .gitreview to support git review plugin
..
add .gitreview to support git review plugin
Change-Id: If8ebdb687f41911f55679472a0c87f9734264e80
---
A
Neels Hofmeyr has submitted this change and it was merged.
Change subject: .gitreview: update repo url to new location
..
.gitreview: update repo url to new location
Old files came from openbsc.
Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/3445
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8b5b0b3c9472e2d25f90f659dcc90aac44d7566
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/3447
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifefb345df6c00aadee0ccc3c59796dba590a9f32
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: .gitreview: update repo url to new location
..
.gitreview: update repo url to new location
Old files was a leftover from split out of openbsc.
Neels Hofmeyr has submitted this change and it was merged.
Change subject: update .gitreview to new repo url
..
update .gitreview to new repo url
Leftover from split out of openbsc
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: .gitreview: update repo url to new location
..
.gitreview: update repo url to new location
Change-Id: Ic08e308e3b6f9dda35c95da4628268ccd2b6cfaa
---
M
Review at https://gerrit.osmocom.org/3446
update .gitreview to new repo url
Leftover from split out of openbsc
Change-Id: I684eedfdeb52a9b018d3798961b29b9e31526cd1
---
M .gitreview
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Review at https://gerrit.osmocom.org/3445
.gitreview: update repo url to new location
Old files came from openbsc.
Change-Id: If8b5b0b3c9472e2d25f90f659dcc90aac44d7566
---
M .gitreview
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/3444
.gitreview: update repo url to new location
Change-Id: Ic08e308e3b6f9dda35c95da4628268ccd2b6cfaa
---
M .gitreview
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/44/3444/1
diff --git
Review at https://gerrit.osmocom.org/3443
Add pcu-socket vty config
osmo-bts already supports configuring a different path for the bts<->pcu
socket by using the 'pcu-socket' config field.
Change-Id: I9b3e1171da467519750b201849ec892a1e318129
---
M src/bts.h
M src/osmobts_sock.cpp
M
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/3434/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 637: if (!sms_report)
> Is there anything the user can do after this error?
if mem is up, the program will likely not do *anything* useful anymore.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3442
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8ebdb687f41911f55679472a0c87f9734264e80
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 1: Code-Review+1
(1 comment)
@hwelte, is there also material copyrighted by you in libasn1c?
https://gerrit.osmocom.org/#/c/3440/1/debian/rules
File debian/rules:
Line 45:dh $@ --with autoreconf
ws
--
To view, visit https://gerrit.osmocom.org/3440
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3439
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia197da1614a8cbec5f177368ca9e25946059c68a
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3398
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6245288b0171eae10aa708403c1ddb584c92f38
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3442
add .gitreview to support git review plugin
Change-Id: If8ebdb687f41911f55679472a0c87f9734264e80
---
A .gitreview
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/42/3442/1
diff --git
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3398/1/src/sccp_user.c
File src/sccp_user.c:
Line 256: /*! \brief check if a given SCCP-Address is consistant.
(at least in libosmocore, we have autobrief, so we'd drop the "\brief". In
libosmo-sccp we don't even have a doxygen make
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3408
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I899d21e52d02e0b8384af29ddd489ff19c8f2cf6
Gerrit-PatchSet: 5
Gerrit-Project: openggsn
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3440
add /debian to build a package
debian files need a release so start with release 0.1.0
Change-Id: I135d975b84027d51cb1dc534e04dd314bbd20289
---
A debian/changelog
A debian/compat
A debian/control
A debian/copyright
A debian/libasn1c-dev.install
A
Review at https://gerrit.osmocom.org/3439
add .gitreview to support git review plugin
Change-Id: Ia197da1614a8cbec5f177368ca9e25946059c68a
---
A .gitreview
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/39/3439/1
diff --git
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3409
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b57eb0654327882044d6862d955f4b32aa6bcd
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Patch Set 4: Code-Review-1
we actually need to allocate /64 prefixes and not individual v6 addresess, this
needs to be re-worked
--
To view, visit https://gerrit.osmocom.org/3403
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3438
to look at the new patch set (#2).
libmsc: support GSM 03.40 status report for nitb
This patch adds support for GSM 03.40 in nitb mode.
MS GSM 03.40 SMSC
Harald Welte has submitted this change and it was merged.
Change subject: Use release helper from libosmocore
..
Use release helper from libosmocore
Change-Id: Ifc88e5c942a8b430b2436d429c86560d82984a95
Related: OS#1861
---
M
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3130
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790ceb958195b9f6cbabfe8c977dc30e2bd7414b
Gerrit-PatchSet: 12
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3394
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33a7ba11eb7c2d9a5dc74d10fb0cf04bf664477b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3435
to look at the new patch set (#2).
libmsc: update database to accomodate SMS status-report fields
SMPP DELIVER_SM messages with esm_class = Delivery Receipt need to send
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3433/1/openbsc/src/utils/smpp_mirror.c
File openbsc/src/utils/smpp_mirror.c:
Line 98: static struct tlv_t *find_tlv(struct tlv_t *head, uint16_t tag)
> this is kind of on its own... could it use libosmocore gsm/tlv.h instead? B
I think
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/3434/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 637: if (!sms_report)
> log error, or maybe OSMO_ASSERT(sms_report)?
Is there anything the user can do after this error?
Why bother?
I mean, you only
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/3433/1/openbsc/src/utils/smpp_mirror.c
File openbsc/src/utils/smpp_mirror.c:
Line 98: static struct tlv_t *find_tlv(struct tlv_t *head, uint16_t tag)
this is kind of on its own... could it use libosmocore gsm/tlv.h instead?
Patch Set 1:
(6 comments)
https://gerrit.osmocom.org/#/c/3434/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 637: if (!sms_report)
log error, or maybe OSMO_ASSERT(sms_report)?
https://gerrit.osmocom.org/#/c/3434/1/openbsc/src/libmsc/smpp_openbsc.c
File
Patch Set 1:
This is DEAD code, just consuming more CPU cycles on something we don't need.
We can restore this once you need it ;-)
Thanks!
--
To view, visit https://gerrit.osmocom.org/3422
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3438/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 692: gsm340_rx_sms_submit(sms_report);
> code cosmetics: I see from the old sms_route_mt_sms() that it looks correct
I'm going to try to address
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/3435/1/openbsc/src/libmsc/db.c
File openbsc/src/libmsc/db.c:
Line 375: /* Just like v4, but there is a new message reference field for
status reports,
"just like v5"?
--
To view, visit https://gerrit.osmocom.org/3435
To
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3436/1/openbsc/src/utils/smpp_mirror.c
File openbsc/src/utils/smpp_mirror.c:
Line 145: LOGP(DSMPP, LOGL_NOTICE, "%s\n", deliver.short_message);
I guess this log statement existed to remind us that delivery receipts were not
Patch Set 1: Code-Review+1
seems like our habit of passing the rx'd msgb around if anyone would like to
query its context, but fair enough
--
To view, visit https://gerrit.osmocom.org/3422
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3438/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 692: gsm340_rx_sms_submit(sms_report);
code cosmetics: I see from the old sms_route_mt_sms() that it looks correct
(besides no switch(sms_mti)
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3427
to look at the new patch set (#2).
libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms()
Move the sms message-type-identifier (mti) handling away from the
routing logic. This patch
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3423
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I474584425d23fb379a9d71b33e29ac0e24f01e61
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3428/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:
Line 607: #define SMPP34_DELIVERY_RECEIPT_REQ 0x1
> (we tend to use enums instead)
OK, I didn't know about this policy.
I have a few more cleanup patches
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3429/1//COMMIT_MSG
Commit Message:
Line 9: Restore the sms status report request flag from SUBMIT_SM.
> what's the difference in behavior before and after this patch?
Without this patch, the status report request flag is not accordingly
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3426
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5f864f9bb963baff95969e306b1b7cff00c1e3
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3425
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68087a850399e22951d2407e4d8a09c671a775c9
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3424
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3502b5b169bc7a73a67fd6ff53d8b6c0dc045c8
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3429/1//COMMIT_MSG
Commit Message:
Line 9: Restore the sms status report request flag from SUBMIT_SM.
what's the difference in behavior before and after this patch?
--
To view, visit https://gerrit.osmocom.org/3429
To unsubscribe,
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/3428/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:
Line 607: #define SMPP34_DELIVERY_RECEIPT_REQ 0x1
(we tend to use enums instead)
--
To view, visit https://gerrit.osmocom.org/3428
To
Neels Hofmeyr has submitted this change and it was merged.
Change subject: vlr: place comments on if (0) cases
..
vlr: place comments on if (0) cases
Change-Id: I56c1e61dedeac01a4e24452feee6616782783d8f
---
M
Neels Hofmeyr has submitted this change and it was merged.
Change subject: vlr: LU FSM: enable Retrieve_IMEISV_If_Required
..
vlr: LU FSM: enable Retrieve_IMEISV_If_Required
Change-Id: I121b95ad6d5ecb7603815eece2b43008de487a8a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3417
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I121b95ad6d5ecb7603815eece2b43008de487a8a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3416
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56c1e61dedeac01a4e24452feee6616782783d8f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3346
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b6e5422987586531a898e0c5b867623dbecb0f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 5: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3350/5/tests/msc_vlr/msc_vlr_tests.c
File tests/msc_vlr/msc_vlr_tests.c:
Line 168: log("MSC <--%s-- MS: %s",
unrelated to the current patch: In general, we have shown the MS always on the
left (like in almost all 3GPP
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3419
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a25f6771ed6e620cb2b315638c622a9a24e530
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3418
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaf4107167c84af8a616f4ee792d5a34495564b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b3c640ddd81927a60ee307c4b0cb90fd83eebe
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3435
libmsc: update database to accomodate SMS status-report fields
SMPP DELIVER_SM messages with esm_class = Delivery Receipt need to send
this message reference (that the mobile phone allocates) to the ESME.
Thus, the ESME propagates it via SUBMIT_SM with
Review at https://gerrit.osmocom.org/3433
utils: smpp_mirror: reflect message reference TLV
Useful to test the delivery receipt support. This TLV contains the
GSM03.40 message reference.
Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f
---
M openbsc/src/utils/smpp_mirror.c
1 file changed,
Review at https://gerrit.osmocom.org/3436
utils: smpp_mirror: bounce Delivery Receipts as Delivery Acknowledgments
Simple patch to test the new status-report support.
Change-Id: I877e228d8e174430f700631edbf9955972da7892
---
M openbsc/src/utils/smpp_mirror.c
1 file changed, 8 insertions(+), 9
Review at https://gerrit.osmocom.org/3438
libmsc: support GSM 03.40 status report for nitb
This patch adds support for GSM 03.40 in nitb mode.
MS GSM 03.40 SMSC
||
| SMS-SUBMIT |
Review at https://gerrit.osmocom.org/3432
utils: smpp_mirror: temporarily munch SMPP delivery receipts
Just munch and log SMPP delivery receipts by now, don't mirror this, it
is going to break things in openbsc.
Follow up patch removes this and mirrors this SMPP message as a
SUBMIT_SM with
Review at https://gerrit.osmocom.org/3437
libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40 status report
This patch adds gsm340_sms_send_status_report_tpdu() to build a
status-report. Moreover, set sms->report field if we see a SMPP
SUBMIT_SM with Delivery Acknowledgment
Review at https://gerrit.osmocom.org/3434
libmsc: add support for SMPP delivery receipts
If the mobile phone requests a status report via SMS, send a DELIVER_SM
with esm_class = Delivery Receipt to ESME to indicate that the SMS has
been already delivered to its destination.
MSGSM
Review at https://gerrit.osmocom.org/3425
libmsc: remove duplicate lines in deliver_to_esme()
This code is accidentally doing the same thing twice, remove it.
Change-Id: I68087a850399e22951d2407e4d8a09c671a775c9
---
M openbsc/src/libmsc/smpp_openbsc.c
1 file changed, 0 insertions(+), 2
Review at https://gerrit.osmocom.org/3427
libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms()
Move the sms message-type-identifier (mti) handling away from the
routing logic. This patch allows us to reuse the sms_route_mt_sms()
function in a follow up patch for sms reports send through
Review at https://gerrit.osmocom.org/3430
libmsc: missing bit shift in status report flag when stored in sms object
So we just store 0 or 1 depending on what the mobile phone requests.
Change-Id: Idb7d5594219c0e458ccb561383a59604bc1a4201
---
M openbsc/src/libmsc/gsm_04_11.c
1 file changed, 1
Review at https://gerrit.osmocom.org/3431
utils: smpp_mirror: set registered_delivery field in SMPP SUBMIT_SM
To test delivery reports using this utility.
Change-Id: I0e477407531fdd4d906e53c9b5a48a79a239966f
---
M openbsc/src/utils/smpp_mirror.c
1 file changed, 1 insertion(+), 0 deletions(-)
Review at https://gerrit.osmocom.org/3426
libmsc: remove 'deferred' parameter in sms_route_mt_sms()
No need to cache the sms object, just cache what we need into the
smpp_cmd structure. This simplifies what that I introduced in
93ffbd0029d1 ("libmsc: send RP-ACK to MS after ESME sends SMPP
Review at https://gerrit.osmocom.org/3422
gsm_04_11: get rid of unused parameter in sms_route_mt_sms()
This parameter is unused, remove it.
Change-Id: I797abce3f91447e8f397c7cf726db7425479fe0e
---
M openbsc/src/libmsc/gsm_04_11.c
1 file changed, 6 insertions(+), 5 deletions(-)
git pull
Review at https://gerrit.osmocom.org/3429
libmsc: report status report request flag from SMPP SUBMIT_SM
Restore the sms status report request flag from SUBMIT_SM.
Change-Id: Iac05252253f8933a3875b4904599b7a225191a4b
---
M openbsc/src/libmsc/smpp_openbsc.c
1 file changed, 1 insertion(+), 0
Review at https://gerrit.osmocom.org/3424
libmsc: remove dead code in sms_route_mt_sms()
The following branch:
if (!rc && !gsms->receiver)
rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED;
at the end of sms_route_mt_sms() always evaluates false.
Just a bit before, in such
Review at https://gerrit.osmocom.org/3423
libmsc: do not leak pending SMPP command object on error path
Make sure the SMPP command object is released on errors.
Change-Id: I474584425d23fb379a9d71b33e29ac0e24f01e61
---
M openbsc/src/libmsc/smpp_openbsc.c
1 file changed, 6 insertions(+), 5
93 matches
Mail list logo
