Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

Max has posted comments on this change. ( https://gerrit.osmocom.org/12266 ) Change subject: vty: show subscriber: put() before printing the use count .. Patch Set 1: (2 comments) Please clarify. https://gerrit.osmocom.org

Change in libosmocore[master]: cleanup: remove unused define

Max has posted comments on this change. ( https://gerrit.osmocom.org/12272 ) Change subject: cleanup: remove unused define .. Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/12272

Change in libosmocore[master]: cleanup: remove unused define

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12272 Change subject: cleanup: remove unused define .. cleanup: remove unused define Change-Id: Ibff603dd581f60b600f2469ad464a0bf77e24bfe --- M tests

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12271 Change subject: Use msgb helper instead of local #define for debug print .. Use msgb helper instead of local #define for debug print This change was

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Patch Set 18: (1 comment) https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808

Change in openbsc[master]: CTRL: remove boilerplate

Max has posted comments on this change. ( https://gerrit.osmocom.org/1576 ) Change subject: CTRL: remove boilerplate .. Patch Set 5: > Easiest to get rid of them is to just "Reply", so bear with me You mean

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 ) Change subject: remove pointless declaration of struct gsm_network .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12242/1/src/gprs

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Patch Set 18: (2 comments) https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

chset Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf Gerrit-Change-Number: 11827 Gerrit-PatchSet: 24 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol G

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

errit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Stefan Sperling

Change in libosmocore[master]: msgb: add test helpers

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. msgb: add test helpers It's often handy to compare certain msgb layer to a given array and

Change in osmo-pcu[master]: cosmetic: move bit counter outside of egprs_window_size()

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12247 Change subject: cosmetic: move bit counter outside of egprs_window_size() .. cosmetic: move bit counter outside of egprs_window_size() As a

Change in osmo-pcu[master]: cosmetic: use const pointer for bts_data

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12246 Change subject: cosmetic: use const pointer for bts_data .. cosmetic: use const pointer for bts_data It's used several time for logging so let&#

Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: add link to related Debian bug in comment

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12239 ) Change subject: regen-makefile.sh: add link to related Debian bug in comment .. regen-makefile.sh: add link to related Debian bug in comment

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 ) Change subject: remove pointless declaration of struct gsm_network .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12242/1

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

Max has posted comments on this change. ( https://gerrit.osmocom.org/11697 ) Change subject: BSC_ConnectionHandler: introduce ctrl interface .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11697 To

Change in osmo-ttcn3-hacks[master]: MSC_Tests: remove unused control interface

Max has posted comments on this change. ( https://gerrit.osmocom.org/11690 ) Change subject: MSC_Tests: remove unused control interface .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11690 To

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

//gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I99948e4b82b5b4bd5b8f7c1a4c60a97fcab3c0eb Gerrit-Change-Number: 12237 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Buil

Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

s Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f11a93634fc50243a7210edcd501bd4b90d6dcd Gerrit-Change-Number: 12238 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels

Change in osmo-ttcn3-hacks[master]: Remove -Wall for autogenerated code

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12241 Change subject: Remove -Wall for autogenerated code .. Remove -Wall for autogenerated code There seems to be no option for ttcn3_makefilegen to

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

Max has posted comments on this change. ( https://gerrit.osmocom.org/12227 ) Change subject: ACL: integrate sanitize check into sgsn_acl_* functions .. Patch Set 5: > Patch Set 5: Code-Review-1 > > -1 since last vers

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12221 ) Change subject: Use explicit parameter for sgsn_auth_init() .. Use explicit parameter for sgsn_auth_init() This is necessary to properly

Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: add link to related Debian bug in comment

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12239 Change subject: regen-makefile.sh: add link to related Debian bug in comment .. regen-makefile.sh: add link to related Debian bug in comment This

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

Max has posted comments on this change. ( https://gerrit.osmocom.org/12226 ) Change subject: Add tests for IMSI ACLs .. Patch Set 5: (1 comment) Please keep comments constructive and actionable - things like "super

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

r for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 Gerrit-Change-Number: 12226 Gerrit-PatchSet: 5 Gerrit-Owner: Max Gerrit-Reviewer: Je

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

errit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Stefan Sperling

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

be, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic3dff108148683b107e9edac430a0475283580e9 Gerrit-Change-Number: 12227 Gerrit-PatchSet: 4 Gerrit-Owner: Max Gerrit-Reviewe

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12237 Change subject: MGCP: fix pattern warning .. MGCP: fix pattern warning Remove implied \r to fix following warnings: "Duplicate character `\r&#x

Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12238 Change subject: MGCP: remove commented variants .. MGCP: remove commented variants It's unclear why those variants were commented - looks

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

Max has posted comments on this change. ( https://gerrit.osmocom.org/12221 ) Change subject: Use explicit parameter for sgsn_auth_init() .. Patch Set 2: > Patch Set 2: Code-Review+1 > > Can you provide some patches t

Change in osmo-sgsn[master]: Drop unused osmo-sgsn.pc

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12231 ) Change subject: Drop unused osmo-sgsn.pc .. Drop unused osmo-sgsn.pc We do not install any libraries so we don't need it: most likely i

Change in osmo-sgsn[master]: Use explicit length check

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12229 ) Change subject: Use explicit length check .. Use explicit length check Use OSMO_MIN macro to check for MSISDN length. This makes the code

Change in osmo-sgsn[master]: Constify sgsn_acl_lookup() parameter

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/1 ) Change subject: Constify sgsn_acl_lookup() parameter .. Constify sgsn_acl_lookup() parameter This requires

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

Max has posted comments on this change. ( https://gerrit.osmocom.org/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 3: (1 comment) I do agree that extra byte is probably unnecessary

Change in osmo-sgsn[master]: Drop unused osmo-sgsn.pc

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12231 Change subject: Drop unused osmo-sgsn.pc .. Drop unused osmo-sgsn.pc We do not install any libraries so we don't need it: most likely it's a

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

Max has posted comments on this change. ( https://gerrit.osmocom.org/12227 ) Change subject: ACL: integrate sanitize check into sgsn_acl_* functions .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12227/2/src/gprs

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

Max has posted comments on this change. ( https://gerrit.osmocom.org/12226 ) Change subject: Add tests for IMSI ACLs .. Patch Set 3: (1 comment) The rest is fixed in next revision. https://gerrit.osmocom.org/#/c/12226/2

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

Max has posted comments on this change. ( https://gerrit.osmocom.org/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12224/2/include

Change in osmo-sgsn[master]: Add sgsn_acl_count()

Max has abandoned this change. ( https://gerrit.osmocom.org/12223 ) Change subject: Add sgsn_acl_count() .. Abandoned -- To view, visit https://gerrit.osmocom.org/12223 To unsubscribe, or for help writing mail filters, visit

Change in osmo-sgsn[master]: ACL: move allocation check forward in sgsn_acl_add()

Max has abandoned this change. ( https://gerrit.osmocom.org/12225 ) Change subject: ACL: move allocation check forward in sgsn_acl_add() .. Abandoned -- To view, visit https://gerrit.osmocom.org/12225 To unsubscribe, or for

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

ge-Id: I138aea409aab0c748c75546e628797fc7498bf40 Gerrit-Change-Number: 12224 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

errit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

be, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic3dff108148683b107e9edac430a0475283580e9 Gerrit-Change-Number: 12227 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewe

Change in osmo-sgsn[master]: Constify sgsn_acl_lookup() parameter

eType: newpatchset Gerrit-Change-Id: Ie92637dd900b0f9eba891d5aad0b4ba0ee69c08c Gerrit-Change-Number: 1 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

errit-MessageType: newpatchset Gerrit-Change-Id: Ibeba371234680f33ad35afbfffce9dca185228c1 Gerrit-Change-Number: 12221 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-sgsn[master]: gtphub: remove code duplication

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12230 Change subject: gtphub: remove code duplication .. gtphub: remove code duplication Use libosmocore struct for GSN address. Change-Id

Change in osmo-sgsn[master]: Use explicit length check

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12229 Change subject: Use explicit length check .. Use explicit length check Use OSMO_MIN macro to check for MSISDN length. This makes the code cleaner and

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

r for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 Gerrit-Change-Number: 12226 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Je

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

iting mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic3dff108148683b107e9edac430a0475283580e9 Gerrit-Change-Number: 12227 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: Constify llist_count() parameter

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12214 ) Change subject: Constify llist_count() parameter .. Constify llist_count() parameter Counting list entires should not alter the list content

Change in osmo-sgsn[master]: Constify sgsn_acl_lookup() parameter

Max has uploaded this change for review. ( https://gerrit.osmocom.org/1 Change subject: Constify sgsn_acl_lookup() parameter .. Constify sgsn_acl_lookup() parameter This requires I414e67a3de733fab407161b3264d3b89070ba537

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12226 Change subject: Add tests for IMSI ACLs .. Add tests for IMSI ACLs Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 --- M tests/sgsn/sgsn_test.c M

Change in osmo-sgsn[master]: Remove misleading comment

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12220 Change subject: Remove misleading comment .. Remove misleading comment The code which has been used for 4 years is hardly temporary. Change-Id

Change in osmo-sgsn[master]: ACL: move allocation check forward in sgsn_acl_add()

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12225 Change subject: ACL: move allocation check forward in sgsn_acl_add() .. ACL: move allocation check forward in sgsn_acl_add() There's no poi

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12224 Change subject: Use libosmocore constant for IMSI length in ACL entry .. Use libosmocore constant for IMSI length in ACL entry Change-Id

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12221 Change subject: Use explicit parameter for sgsn_auth_init() .. Use explicit parameter for sgsn_auth_init() This is necessary to properly test ACLs in

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12227 Change subject: ACL: integrate sanitize check into sgsn_acl_* functions .. ACL: integrate sanitize check into sgsn_acl_* functions Having this check

Change in osmo-sgsn[master]: Add sgsn_acl_count()

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12223 Change subject: Add sgsn_acl_count() .. Add sgsn_acl_count() This is necessary to properly test ACLs in follow-up patches. Change-Id

Change in sandbox[master]: What about -1 vote counting?

Max has posted comments on this change. ( https://gerrit.osmocom.org/12218 ) Change subject: What about -1 vote counting? .. Patch Set 1: Code-Review+1 Changed my mind :-P -- To view, visit https://gerrit.osmocom.org/12218

Change in sandbox[master]: What about -1 vote counting?

Max has posted comments on this change. ( https://gerrit.osmocom.org/12218 ) Change subject: What about -1 vote counting? .. Patch Set 1: Code-Review-1 I hate everything about this patch passionately :-D -- To view, visit

Change in libosmocore[master]: Constify llist_count() parameter

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12214 Change subject: Constify llist_count() parameter .. Constify llist_count() parameter Counting list entires should not alter the list content: let&#

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

chset Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf Gerrit-Change-Number: 11827 Gerrit-PatchSet: 23 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol G

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

errit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: Add osmo_sockaddr_in_to_str_and_uint()

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11842 ) Change subject: Add osmo_sockaddr_in_to_str_and_uint() .. Add osmo_sockaddr_in_to_str_and_uint() It's simil

Change in libosmo-abis[master]: log IPA tags correctly

Max has posted comments on this change. ( https://gerrit.osmocom.org/12175 ) Change subject: log IPA tags correctly .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12175 To unsubscribe, or for help

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Patch Set 16: > it's either all or nothing. That's not the case: we

Change in libosmocore[master]: Add osmo_sockaddr_in_to_str_and_uint()

Max has posted comments on this change. ( https://gerrit.osmocom.org/11842 ) Change subject: Add osmo_sockaddr_in_to_str_and_uint() .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11842 To unsubscribe, or

Change in libosmocore[master]: Allow log_init() with NULL log_info

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12092 ) Change subject: Allow log_init() with NULL log_info .. Allow log_init() with NULL log_info Since we have library-internal categories we

Change in libosmocore[master]: msgb: add test helpers

smocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5 Gerrit-Change-Number: 12017 Gerrit-PatchSet: 12 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (1

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS, TS 29.205: add GCR routines .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11827 To unsubscribe, or for

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Patch Set 14: > If decoding failed (gsm0808_dec_gcr returned <0), it makes no

Change in libosmocore[master]: LCLS: add gsm0808_create_ass2()

https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id89765df3f8c12f55f73f1d7a9d90c8883eb3bba Gerrit-Change-Number: 11826 Gerrit-PatchSet: 26 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Bu

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

errit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: msgb: add test helpers

Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. Patch Set 11: > one slight problem with LOGP could be that in regression tests, we often only >

Change in osmo-msc[master]: Store subscriber's cell identity

Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 ) Change subject: Store subscriber's cell identity .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11746 To unsubscribe, o

Change in python/osmo-python-tests[master]: twisted: remove low-level logging in dispatchers

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12150 ) Change subject: twisted: remove low-level logging in dispatchers .. twisted: remove low-level logging in dispatchers The same messages are

Change in python/osmo-python-tests[master]: Trap handlers: adjust http error log

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12149 ) Change subject: Trap handlers: adjust http error log .. Trap handlers: adjust http error log Log repr() of error because it's

Change in python/osmo-python-tests[master]: twisted: remove low-level logging in dispatchers

/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4a054eec9ef7ab39e15ac0cd64834a251d4fb2d7 Gerrit-Change-Number: 12150 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin P

Change in python/osmo-python-tests[master]: Trap handlers: adjust http error log

32345 Gerrit-Change-Number: 12149 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: daniel

Change in python/osmo-python-tests[master]: twisted: disable low-level logging in dispatchers

/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4a054eec9ef7ab39e15ac0cd64834a251d4fb2d7 Gerrit-Change-Number: 12150 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin P

Change in python/osmo-python-tests[master]: ctrl2cgi: log request time

Max has posted comments on this change. ( https://gerrit.osmocom.org/12147 ) Change subject: ctrl2cgi: log request time .. Patch Set 1: > So maybe add a log statement here with the difference between ts and > datetime.n

Change in osmo-msc[master]: Store subscriber's cell identity

Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 ) Change subject: Store subscriber's cell identity .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11746 To unsubscribe, o

Change in libosmocore[master]: Allow log_init() with NULL log_info

ers, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42159780b57684bff225789f036f28a4b25fc7b8 Gerrit-Change-Number: 12092 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewe

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2dfbf Gerrit-Change-Number: 11827 Gerrit-PatchSet: 20 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

errit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Patch Set 13: (1 comment) I thought I've already answered it but can't f

Change in python/osmo-python-tests[master]: ctrl2cgi: make http request timeout configurable

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12148 Change subject: ctrl2cgi: make http request timeout configurable .. ctrl2cgi: make http request timeout configurable Change-Id

Change in python/osmo-python-tests[master]: Trap handlers: log request/reply as info level

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12146 Change subject: Trap handlers: log request/reply as info level .. Trap handlers: log request/reply as info level Log the basic location-state trap

Change in python/osmo-python-tests[master]: Trap handlers: propagate expected BSC id to command processor

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12145 Change subject: Trap handlers: propagate expected BSC id to command processor .. Trap handlers: propagate expected BSC id to command processor When

Change in python/osmo-python-tests[master]: Trap handlers: adjust http error log

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12149 Change subject: Trap handlers: adjust http error log .. Trap handlers: adjust http error log Log repr() of error because it's more conscience

Change in python/osmo-python-tests[master]: twisted: disable low-level logging in dispatchers

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12150 Change subject: twisted: disable low-level logging in dispatchers .. twisted: disable low-level logging in dispatchers The same messages are better

Change in python/osmo-python-tests[master]: ctrl2cgi: log request time

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12147 Change subject: ctrl2cgi: log request time .. ctrl2cgi: log request time Log http request timestamp and duration on debug loglevel. This is especially

Change in python/osmo-python-tests[master]: ctrl2cgi: properly limit number of requests

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12139 ) Change subject: ctrl2cgi: properly limit number of requests .. ctrl2cgi: properly limit number of requests Manual acquire()/release() of

Change in python/osmo-python-tests[master]: ctrl2cgi: add config file example

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12140 ) Change subject: ctrl2cgi: add config file example .. ctrl2cgi: add config file example Change-Id: I1e5c37a75cf21184d5bd3ef01b452d45c8f6d7ac

Change in python/osmo-python-tests[master]: Trap handlers: always log to stdout

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12135 ) Change subject: Trap handlers: always log to stdout .. Trap handlers: always log to stdout Since the scripts are intended to be used as

Change in python/osmo-python-tests[master]: ctrl2cgi: fix broken config override

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12134 ) Change subject: ctrl2cgi: fix broken config override .. ctrl2cgi: fix broken config override Previously command-line arguments without

Change in python/osmo-python-tests[master]: ctrl2cgi: properly limit number of requests

Max has posted comments on this change. ( https://gerrit.osmocom.org/12139 ) Change subject: ctrl2cgi: properly limit number of requests .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/12139/1//COMMIT_MSG Commit

Change in python/osmo-python-tests[master]: ctrl2cgi: add config file example

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12140 Change subject: ctrl2cgi: add config file example .. ctrl2cgi: add config file example Change-Id: I1e5c37a75cf21184d5bd3ef01b452d45c8f6d7ac --- A doc

Change in python/osmo-python-tests[master]: ctrl2cgi: properly limit number of requests

m.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I47b8b9f5b726ca0905bb7c023d63b325c7f7d85f Gerrit-Change-Number: 12139 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102)

Change in python/osmo-python-tests[master]: ctrl2cgi: fix broken config override

Max has posted comments on this change. ( https://gerrit.osmocom.org/12134 ) Change subject: ctrl2cgi: fix broken config override .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/12134 To unsubscribe, or

<    6   7   8   9   10   11   12   13   14   15   >