Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation .. Patch Set 5: (1 comment)

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE .. Patch Set 3: (1 comment)

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 2: > (1 comment) just confirmed my

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 2: (1 comment)

Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 ) Change subject: Prepare to support MO Call HOLD .. Patch Set 3: (1 comment)

Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT

2019-07-30 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT .. Patch Set 4: Code-Review+2 (3

Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly .. vty/vty.c: the command buffer can be

Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events .. vty/telnet_interface.c: log

Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun .. vty/vty.c: fix vty_read():

Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 ) Change subject: src/db.c: integrate SQLite3 with talloc allocator .. src/db.c: integrate SQLite3 with talloc

Change in ...osmo-hlr[master]: tests/db_test: close the database when test is finished

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14965 ) Change subject: tests/db_test: close the database when test is finished .. tests/db_test: close the database when

Change in ...osmo-hlr[master]: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD'

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14964 ) Change subject: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' .. build: fix mess with 'db_test_SOURCES'

Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 ) Change subject: src/db.c: integrate SQLite3 with talloc allocator .. Patch Set 3: (1 comment)

Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 ) Change subject: src/db.c: integrate SQLite3 with talloc allocator .. Patch Set 3: Code-Review+1 (1 comment)

Change in ...osmo-hlr[master]: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD'

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14964 ) Change subject: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' .. Patch Set 1: Code-Review+2 very interesting -- To

Change in ...libosmocore[master]: vty/vty.c: log received commands from telnet interface

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 ) Change subject: vty/vty.c: log received commands from telnet interface .. Patch Set 3: I think this is a good idea, but causes

Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun .. Patch Set 3: (1 comment)

Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT

2019-07-30 Thread pespin
Hello fixeria, Vadim Yanitskiy, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 to look at the new patch set (#4). Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT

Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT .. Patch Set 3: (1 comment)

Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. master-builds: Publish osmo-hnbgw documentation Requires:

Change in ...osmo-sip-connector[master]: Add further logging.

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 ) Change subject: Add further logging. .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT

2019-07-30 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT .. Patch Set 3: (1 comment)

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE .. Patch Set 3: Code-Review+1 (2 comments)

Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 ) Change subject: Prepare to support MO Call HOLD .. Patch Set 3: Code-Review+1 (2 comments)

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs .. Patch Set 3: Code-Review+1 (3 comments)

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 2: (1 comment)

Change in ...osmo-trx[master]: Move std_inband.rbf under device/usrp1/ dir

2019-07-30 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15002 Change subject: Move std_inband.rbf under device/usrp1/ dir .. Move std_inband.rbf under device/usrp1/ dir This file is only used by

Change in ...osmo-trx[master]: Move README.DFEsymbolspaced to utils/matlab

2019-07-30 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15001 Change subject: Move README.DFEsymbolspaced to utils/matlab .. Move README.DFEsymbolspaced to utils/matlab Change-Id:

Change in ...osmo-trx[master]: Move Transceiver52/README to UserManual

2019-07-30 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15000 Change subject: Move Transceiver52/README to UserManual .. Move Transceiver52/README to UserManual Change-Id:

Change in ...osmo-trx[master]: Move matlab files under utils/matlab

2019-07-30 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14999 Change subject: Move matlab files under utils/matlab .. Move matlab files under utils/matlab Change-Id:

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 2: (1 comment)

Change in ...osmo-trx[master]: Move inband-signaling-usb documentation to UserManual

2019-07-30 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14998 Change subject: Move inband-signaling-usb documentation to UserManual .. Move inband-signaling-usb documentation to UserManual

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File

Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets

2019-07-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 ) Change subject: add vty 'no neighbors' to remove all HO targets .. Patch Set 2: (1 comment)

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 1: (1 comment)

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-07-30 Thread keith
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 to look at the new patch set (#3). Change subject: Handle SIP re-INVITEs .. Handle

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 2: (2 comments)

Change in ...osmo-bsc[master]: WIP: bsc: timeslot_fsm: Set TS state as unused instead of broken on P...

2019-07-30 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/11958 ) Change subject: WIP: bsc: timeslot_fsm: Set TS state as unused instead of broken on PDCH DEACT NACK .. Abandoned inactivity timeout -- To

Change in ...osmo-sip-connector[master]: Add further logging.

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 ) Change subject: Add further logging. .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c File

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread keith
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 to look at the new patch set (#2). Change subject: Add media mode parameter to sdp_create_file()

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE .. Patch Set 1: (2 comments)

Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 ) Change subject: Prepare to support MO Call HOLD .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs .. Patch Set 1: Code-Review-1 (3 comments)

Change in ...osmo-msc[master]: Log protocol for which transaction is allocated

2019-07-30 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13420 ) Change subject: Log protocol for which transaction is allocated .. Abandoned similar functionality implemented in other patch, already merged

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 1: (2 comments)

Change in ...osmo-msc[master]: add BSC/MSC neighbor VTY commands for inter-MSC HO

2019-07-30 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/12446 ) Change subject: add BSC/MSC neighbor VTY commands for inter-MSC HO .. Abandoned absorbed in other patches, already merged -- To view, visit

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() .. Patch Set 1: Code-Review-1 (2 comments)

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-sip-connector[master]: Add further logging.

2019-07-30 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 Change subject: Add further logging. .. Add further logging. Log the IP port, payload type for calls. Also log the SIP

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. Patch Set 2: > Patch Set 1: Code-Review+1 > > We should also set

Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

2019-07-30 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 Change subject: Add support for MNCC HOLD/RETRIEVE .. Add support for MNCC HOLD/RETRIEVE Handle MO hold and retrieve and

Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD

2019-07-30 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 Change subject: Prepare to support MO Call HOLD .. Prepare to support MO Call HOLD Add function pointers to the call_leg

Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

2019-07-30 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 Change subject: Handle SIP re-INVITEs .. Handle SIP re-INVITEs SIP end points can send periodic re-INVITES. Previous to this

Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

2019-07-30 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 Change subject: Add media mode parameter to sdp_create_file() .. Add media mode parameter to sdp_create_file() This enables

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. Patch Set 2: Verified+1 Already updated jenkins and both build run

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread daniel
Hello pespin, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 to look at the new patch set (#2). Change subject: master-builds: Publish osmo-hnbgw documentation

Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building

2019-07-30 Thread daniel
daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 ) Change subject: jenkins: Enable manual publishing and building .. jenkins: Enable manual publishing and building Related:

Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-trx[master]: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr

2019-07-30 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14989 to look at the new patch set (#2). Change subject: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr

Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

2019-07-30 Thread Vadim Yanitskiy
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14972 to look at the new patch set (#3). Change subject: vty/telnet_interface.c: log connection accept() / close() events

Change in ...osmo-mgw[master]: Fix return variable of strtoul()

2019-07-30 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 ) Change subject: Fix return variable of strtoul() .. Fix return variable of strtoul() Return variable specified by strtoul()

Change in ...libosmocore[master]: gsm0808_test: Fix wrong use of memcp

2019-07-30 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14979 ) Change subject: gsm0808_test: Fix wrong use of memcp .. gsm0808_test: Fix wrong use of memcp After recent system upgrade,

Change in ...libosmocore[master]: gsm0808_test: Fix wrong use of memcp

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14979 ) Change subject: gsm0808_test: Fix wrong use of memcp .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT

2019-07-30 Thread pespin
Hello fixeria, Vadim Yanitskiy, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 to look at the new patch set (#3). Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT

Change in ...libosmocore[master]: vty/logging_vty.c: fix writing of 'print category-hex'

2019-07-30 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14976 ) Change subject: vty/logging_vty.c: fix writing of 'print category-hex' .. vty/logging_vty.c: fix writing of 'print

Change in ...libosmocore[master]: vty/logging_vty.c: fix writing of 'print category-hex'

2019-07-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14976 ) Change subject: vty/logging_vty.c: fix writing of 'print category-hex' .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events .. Patch Set 2: (1 comment)

Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r...

2019-07-30 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14968 ) Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server .. add

Change in ...osmo-ttcn3-hacks[master]: pcu: add osmo-pcu.cfg

2019-07-30 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14960 ) Change subject: pcu: add osmo-pcu.cfg .. Patch Set 1: Setting to WIP, I might need to make changes to it while working on

Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r...

2019-07-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14968 ) Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server .. Patch Set 2: Code-Review+2

Change in ...simtrace2[master]: add new board and app for gpio testing on octsimtest board

2019-07-30 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/simtrace2/+/14969 ) Change subject: add new board and app for gpio testing on octsimtest board .. add new board and app for gpio testing on

Change in ...simtrace2[master]: add new board and app for gpio testing on octsimtest board

2019-07-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/14969 ) Change subject: add new board and app for gpio testing on octsimtest board .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building

2019-07-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 ) Change subject: jenkins: Enable manual publishing and building .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread laforge
laforge has removed a vote on this change. Change subject: master-builds: Publish osmo-hnbgw documentation .. Removed Verified+1 by laforge -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. Patch Set 1: Verified+1 -- To view, visit

Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events .. Patch Set 2: (1 comment)

Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun .. Patch Set 2: (1 comment)

Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly

2019-07-30 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly .. Patch Set 2: > Patch Set 2: Code-Review+1 > >

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 ) Change subject: jenkins: Enable manual publishing and building .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly .. Patch Set 2: Code-Review+1 Looks fine for me, no idea

Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun .. Patch Set 2: Code-Review+1 (1 comment)

Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events .. Patch Set 2: (2 comments)

Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

2019-07-30 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events .. Patch Set 2: Code-Review-1 -- To view, visit

Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building

2019-07-30 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 ) Change subject: jenkins: Enable manual publishing and building .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation .. Patch Set 1: Code-Review+1 We should also set WITH_MANUALS=1 for

Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r...

2019-07-30 Thread roh
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/14968 to look at the new patch set (#2). Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server

Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building

2019-07-30 Thread daniel
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/14991 to look at the new patch set (#2). Change subject: jenkins: Enable manual publishing and building ..

Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation

2019-07-30 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 Change subject: master-builds: Publish osmo-hnbgw documentation .. master-builds: Publish osmo-hnbgw documentation Requires:

Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building

2019-07-30 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 Change subject: jenkins: Enable manual publishing and building .. jenkins: Enable manual publishing and building Related: OS#2589

  1   2   >