[MERGED] osmo-gsm-manuals[master]: OsmoBTS: bts-models: Add Lime Microsystems devices as suppor...

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: OsmoBTS: bts-models: Add Lime Microsystems devices as supported osmo-trx .. OsmoBTS: bts-models: Add Lime Microsystems devices as supported osmo-trx

osmo-gsm-manuals[master]: common: port_numbers: Add OsmoTRX and OsmoBTS missing ports

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7138 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc34aa2d4241945e80c07e4e5660451a016f0117 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

[MERGED] osmo-trx[master]: osmo-trx: Re-introduce -l cmd line parameter

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-trx: Re-introduce -l cmd line parameter .. osmo-trx: Re-introduce -l cmd line parameter Parameter -l to set the terminal logging levle was removed

osmo-gsm-manuals[master]: OsmoSGSN: overview: Fix typo and reference OpenGGSN->OsmoGGSN

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7137 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94cc362a4f52e6bd9f93299665e73dc4fd75a2c6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

[MERGED] osmo-gsm-manuals[master]: common: port_numbers: Add OsmoTRX and OsmoBTS missing ports

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: common: port_numbers: Add OsmoTRX and OsmoBTS missing ports .. common: port_numbers: Add OsmoTRX and OsmoBTS missing ports Change-Id:

[MERGED] osmo-gsm-manuals[master]: OsmoSGSN: overview: Fix typo and reference OpenGGSN->OsmoGGSN

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: OsmoSGSN: overview: Fix typo and reference OpenGGSN->OsmoGGSN .. OsmoSGSN: overview: Fix typo and reference OpenGGSN->OsmoGGSN Change-Id:

osmo-gsm-manuals[master]: OsmoBTS: bts-models: Add Lime Microsystems devices as suppor...

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7136 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I739e4dfba7c649a74cf67d6bbe6f74b22e7e24f0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-tester[master]: ms: Create a starter for virtphy and mobile application

2018-03-06 Thread Pau Espin Pedrol
Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py File src/osmo_ms_driver/starter.py: Line 107: def start_mobile(self, loop): > You are the maintainer but I wouldn't do it: * What's the issue with it being generic given that is called from a known

[MERGED] osmo-gsm-tester[master]: jenkins: update poky version 2.3.2

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins: update poky version 2.3.2 .. jenkins: update poky version 2.3.2 The sysmobts 2017 releases are using poky 2.3.2 Change-Id:

[MERGED] osmo-gsm-manuals[master]: OsmoBSC: update VTY reference

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: OsmoBSC: update VTY reference .. OsmoBSC: update VTY reference This is the first update since the libosmocore changes to the 'show online-help'

[MERGED] osmo-gsm-manuals[master]: OsmoSTP: update VTY reference

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: OsmoSTP: update VTY reference .. OsmoSTP: update VTY reference This is the first update since the libosmocore changes to the 'show online-help'

[MERGED] osmo-gsm-manuals[master]: INSTALL.txt: update VTY reference how-to to new osmo_interac...

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: INSTALL.txt: update VTY reference how-to to new osmo_interact_vty.py .. INSTALL.txt: update VTY reference how-to to new osmo_interact_vty.py Change-Id:

[MERGED] osmo-gsm-manuals[master]: OsmoGGSN: update vty reference

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: OsmoGGSN: update vty reference .. OsmoGGSN: update vty reference Add new (generic) logging commands, talloc context print commands. Add the jitter

[MERGED] osmo-gsm-manuals[master]: OsmoHLR: update vty reference

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: OsmoHLR: update vty reference .. OsmoHLR: update vty reference Add new (generic) logging commands, talloc context print commands. Add the jitter buffer

[MERGED] osmo-gsm-tester[master]: jenkins: use env POKY_VERSION POKY_PATH to find poky

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins: use env POKY_VERSION POKY_PATH to find poky .. jenkins: use env POKY_VERSION POKY_PATH to find poky Instead of hardcoded values, use defaults

osmo-trx[master]: osmo-trx: Re-introduce -l cmd line parameter

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7141 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c35ecded177b7976045d9b693855adb9e18f8a Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[MERGED] osmo-trx[master]: osmo-trx: Use VTY cfg structures while still allowing cmd li...

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-trx: Use VTY cfg structures while still allowing cmd line options .. osmo-trx: Use VTY cfg structures while still allowing cmd line options

[MERGED] osmo-trx[master]: doc: Add sample cfg file for LimeSDR

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: doc: Add sample cfg file for LimeSDR .. doc: Add sample cfg file for LimeSDR Change-Id: I16de70eac0fd79107b8317af37201e6da834c169 --- A

[MERGED] osmo-trx[master]: Move enums required by VTY to a separate header

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Move enums required by VTY to a separate header .. Move enums required by VTY to a separate header This patch is a preparation for next patches, which

[MERGED] osmo-trx[master]: vty: Implement VTY cfg parsing for current parameters

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: Implement VTY cfg parsing for current parameters .. vty: Implement VTY cfg parsing for current parameters At this stage, osmo-trx still uses the

[MERGED] osmo-trx[master]: osmo-trx.cpp: Move trx start and stop to helper functions

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-trx.cpp: Move trx start and stop to helper functions .. osmo-trx.cpp: Move trx start and stop to helper functions Make main() smaller, and make it

[MERGED] osmo-gsm-manuals[master]: Introduce OsmoTRX manual

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Introduce OsmoTRX manual .. Introduce OsmoTRX manual Change-Id: I19ee9d6cda02fb7200c96c0ac129e69825b096cd --- M Makefile A OsmoTRX/Makefile A

[MERGED] osmo-gsm-manuals[master]: Introduce chapter trx_if.adoc and add it to OsmoTRX and OsmoBTS

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Introduce chapter trx_if.adoc and add it to OsmoTRX and OsmoBTS .. Introduce chapter trx_if.adoc and add it to OsmoTRX and OsmoBTS This chapter defines

osmo-gsm-manuals[master]: Introduce chapter trx_if.adoc and add it to OsmoTRX and OsmoBTS

2018-03-06 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7140 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c418eef0f826ae1aadbed5b151fbed241c7885 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: Introduce OsmoTRX manual

2018-03-06 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7139 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19ee9d6cda02fb7200c96c0ac129e69825b096cd Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

[MERGED] osmo-msc[master]: VLR: fix potential NULL dereference

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: VLR: fix potential NULL dereference .. VLR: fix potential NULL dereference The vlr_subscr_get() can return NULL if its argument is NULL (which isn't

osmo-bsc[master]: handover_test: explicitly wrap abis_rsl_sendmsg()

2018-03-06 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7121/1//COMMIT_MSG Commit Message: Line 11: magic (aka luck). > but this only works when the other implementation is in a library? Can we b I think it doesn't matter whether library or not. It works as both the function caller and the

osmo-bts[master]: common/vty.c: remove unused variables

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7122 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I289dda64228e81ca4c608121e50146a71e19f1e2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: common/vty.c: remove unused variables

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: common/vty.c: remove unused variables .. common/vty.c: remove unused variables Change-Id: I289dda64228e81ca4c608121e50146a71e19f1e2 --- M

[MERGED] osmo-sgsn[master]: vty: absorb command explanations from osmo-gsm-manuals

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: absorb command explanations from osmo-gsm-manuals .. vty: absorb command explanations from osmo-gsm-manuals The

osmo-sgsn[master]: vty: absorb command explanations from osmo-gsm-manuals

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7128 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35984014424412e91437b7ed71576aef3819cb1e Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

osmo-bsc[master]: libbsc/bsc_vty.c: prevent uninitialized access

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7123 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57635f2f482ff476ab697b1b9e872ce90aafb999 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: libbsc/bsc_vty.c: prevent uninitialized access

2018-03-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libbsc/bsc_vty.c: prevent uninitialized access .. libbsc/bsc_vty.c: prevent uninitialized access If an out of range 'Last Valid Block' value for

osmo-gsm-manuals[master]: OsmoHLR: update vty reference

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7132 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e92c821b26908d4baa37745c57b9e15bda2a373 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: INSTALL.txt: update VTY reference how-to to new osmo_interac...

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7125 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bf1fea83354049f4157ee9ac8b40f673597f908 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: OsmoSTP: update VTY reference

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7135 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98cdfcb6c1c7db49ab106e775be92e4c6adeab17 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: OsmoMGW: update VTY reference

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7133 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79804ec0e61cc19a679f079a083a5ea2ea3ee2de Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: OsmoSGSN: update VTY reference

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7134 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71863e5056ad369d2055e9882a52a00fa999ab04 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: OsmoGGSN: update vty reference

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7131 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdc735df6221bf6e9b6247912f2958974dcfc4f2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: OsmoMSC: update VTY reference

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7130 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f1698dbc205334cf69234f88b124abfce54cc9a Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: OsmoBSC: update VTY reference

2018-03-06 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7129 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d856563eee88527fda4c6940aa6cea779175aaa Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-manuals[master]: INSTALL.txt: update VTY reference how-to to new osmo_interac...

2018-03-06 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7125/1/INSTALL.txt File INSTALL.txt: Line 27: osmo_interact_vty.py -X -p $VTY_PORT > vty/*_vty_reference.xml Is this asterisk expected to be evaluated by the shell? Otherwise better use ${FOO}_vty_reference.xml as example -- To

osmo-gsm-tester[master]: ms: Create a starter for virtphy and mobile application

2018-03-06 Thread Holger Freyther
Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py File src/osmo_ms_driver/starter.py: Line 107: def start_mobile(self, loop): > Can now be called start(), as it's already in the mobile class. You are the maintainer but I wouldn't do it: * start

[PATCH] osmo-trx[master]: osmo-trx: Re-introduce -l cmd line parameter

2018-03-06 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7141 osmo-trx: Re-introduce -l cmd line parameter Parameter -l to set the terminal logging levle was removed in 3da1f8352e337fb032bf7a58c2909d3ba918e237, but afterwards it was decided to keep the cmd line options for a bit more to easy migration to VTY cfg.

osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-03-06 Thread Pau Espin Pedrol
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7019 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-06 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7020 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dcf2a6fa2991cb73b4807f8a10d251f3dca77dd Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

[PATCH] osmo-bsc[master]: libbsc/bsc_vty.c: prevent uninitialized access

2018-03-06 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7123 libbsc/bsc_vty.c: prevent uninitialized access If an out of range 'Last Valid Block' value for 'smscb-command' is passed, a 'last_block' of the 'rsl_ie_cb_cmd_type' struct could be uninitialized. Let's prevent this. Found using Clang Static Analyzer.

osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

2018-03-06 Thread Neels Hofmeyr
Patch Set 10: (2 comments) https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: PS10, Line 1280: ; :lai = (struct osmo_location_area_id) > why not simply have the '=' one line above, no typecast and no need to rest

libasn1c[master]: configure: add --enable-werror

2018-03-06 Thread Pau Espin Pedrol
Patch Set 1: Code-Review-1 I think using: CFLAGS="..." ./configure instead of ./configure CFLAGS="..." should fix the overwritting issue. -- To view, visit https://gerrit.osmocom.org/7096 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] osmo-bts[master]: common/vty.c: remove unused variables

2018-03-06 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7122 common/vty.c: remove unused variables Change-Id: I289dda64228e81ca4c608121e50146a71e19f1e2 --- M src/common/vty.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/22/7122/1 diff --git

osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-06 Thread Pau Espin Pedrol
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7022 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If661675528059bc8a95d39a6489a5a9381f52677 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-06 Thread Pau Espin Pedrol
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/7021/2/jobs/osmo-gsm-tester.yml File jobs/osmo-gsm-tester.yml: Line 105: name: osmo-gsm-tester-repo-clean As discussed, I think we can drop this one completely. -- To view, visit https://gerrit.osmocom.org/7021 To

osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

2018-03-06 Thread Neels Hofmeyr
Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: PS10, Line 1280: ; :lai = (struct osmo_location_area_id) > weird, makes me wonder "what was my motivation" NOW I remember: the lai is

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-06 Thread lynxis lazus
Hello Pau Espin Pedrol, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7021 to look at the new patch set (#4). jenkins: add osmo-gsm-tester_run-{prod,rnd} Both jobs doing the actual test run on the prod or rnd tester. Change-Id:

libasn1c[master]: configure: add --enable-werror

2018-03-06 Thread Pau Espin Pedrol
Patch Set 1: -Code-Review Why do you need each of this? -Wno-error=deprecated -Wno-error=deprecated-declarations -Wno-error=cpp -- To view, visit https://gerrit.osmocom.org/7096 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] osmo-gsm-manuals[master]: OsmoBSC: update VTY reference

2018-03-06 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7129 OsmoBSC: update VTY reference This is the first update since the libosmocore changes to the 'show online-help' generated output. Hence the produced document now benefits from the structural improvements: - not repeating common commands for every node;

[PATCH] osmo-gsm-manuals[master]: OsmoHLR: update vty reference

2018-03-06 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7132 OsmoHLR: update vty reference Add new (generic) logging commands, talloc context print commands. Add the jitter buffer logging category. Remove the common commands from the individual sections. Change-Id: I8e92c821b26908d4baa37745c57b9e15bda2a373 ---

[PATCH] osmo-gsm-manuals[master]: OsmoSTP: update VTY reference

2018-03-06 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7135 OsmoSTP: update VTY reference This is the first update since the libosmocore changes to the 'show online-help' generated output. Hence the produced document now benefits from the structural improvements: - not repeating common commands for every node;

[PATCH] osmo-gsm-manuals[master]: OsmoGGSN: update vty reference

2018-03-06 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7131 OsmoGGSN: update vty reference Add new (generic) logging commands, talloc context print commands. Add the jitter buffer logging category. Change-Id: Ifdc735df6221bf6e9b6247912f2958974dcfc4f2 --- M OsmoGGSN/vty/ggsn_vty_reference.xml 1 file changed,

[PATCH] osmo-sgsn[master]: vty: absorb command explanations from osmo-gsm-manuals

2018-03-06 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7128 vty: absorb command explanations from osmo-gsm-manuals The osmo-gsm-manuals/vty/sgsn_vty_additions.xml contained many command explanations that are redundant with the VTY online doc. Some however are more verbose / easier to understand. Absorb these

libasn1c[master]: configure: add --enable-werror

2018-03-06 Thread Neels Hofmeyr
Patch Set 1: > I would really hope there is another method than to add a > configure.ac flag for every compiler option / CFLAG we ever want to > sue from our continuous integration setup. It's not just one CFLAG here, there is a "fine-tuned" combination of warnings we don't want to see as

osmo-gsm-tester[master]: jenkins: use env POKY_VERSION POKY_PATH to find poky

2018-03-06 Thread lynxis lazus
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7124/1/contrib/jenkins-build-osmo-bts-sysmo.sh File contrib/jenkins-build-osmo-bts-sysmo.sh: Line 7: [ -z "$_poky_version" ] && _poky_version="2.3.2" > Using _ as prefix here looks at bit ugly, specially since this variables ar both are

[PATCH] osmo-gsm-tester[master]: jenkins: update poky version 2.3.2

2018-03-06 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7126 jenkins: update poky version 2.3.2 The sysmobts 2017 releases are using poky 2.3.2 Change-Id: If6e8a5702e4c9b24e758e3aa5f390e786c51c384 --- M contrib/jenkins-build-osmo-bts-sysmo.sh M contrib/jenkins-build-osmo-pcu-sysmo.sh 2 files changed, 2

[PATCH] osmo-gsm-tester[master]: jenkins: use env POKY_VERSION POKY_PATH to find poky

2018-03-06 Thread lynxis lazus
jenkins: use env POKY_VERSION POKY_PATH to find poky Instead of hardcoded values, use defaults and allow jenkins to override the defaults. Change-Id: I1403b32cdf30420f3b02c41c2627b71fcbeae9ab --- M contrib/jenkins-build-osmo-bts-sysmo.sh M contrib/jenkins-build-osmo-pcu-sysmo.sh 2 files

osmo-gsm-tester[master]: jenkins: update poky version 2.3.2

2018-03-06 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7126 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6e8a5702e4c9b24e758e3aa5f390e786c51c384 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: jenkins: use env POKY_VERSION POKY_PATH to find poky

2018-03-06 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/7124/1/contrib/jenkins-build-osmo-bts-sysmo.sh File contrib/jenkins-build-osmo-bts-sysmo.sh: Line 7: [ -z "$_poky_version" ] && _poky_version="1.5.4" > both are not exported. So it's local to this file. By local I mean as in

[PATCH] osmo-gsm-manuals[master]: INSTALL.txt: update VTY reference how-to to new osmo_interac...

2018-03-06 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7125 INSTALL.txt: update VTY reference how-to to new osmo_interact_vty.py Change-Id: I5bf1fea83354049f4157ee9ac8b40f673597f908 --- M INSTALL.txt 1 file changed, 17 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals

[PATCH] osmo-ci[master]: add ansible playbooks

2018-03-06 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7127 add ansible playbooks Introduce playbooks to do: - setup-jenkins-slave - setup a usualy or special jenkins-slave - setup-gsm-tester - setup the gsm-tester Change-Id: I7007a4e6c38f73843390ec2b3b91133aff21e36a --- A ansible/.gitignore A

[PATCH] osmo-gsm-manuals[master]: Introduce OsmoTRX manual

2018-03-06 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7139 Introduce OsmoTRX manual Change-Id: I19ee9d6cda02fb7200c96c0ac129e69825b096cd --- M Makefile A OsmoTRX/Makefile A OsmoTRX/chapters/configuration.adoc A OsmoTRX/chapters/control.adoc A OsmoTRX/chapters/counters.adoc A

[PATCH] osmo-gsm-manuals[master]: OsmoSGSN: overview: Fix typo and reference OpenGGSN->OsmoGGSN

2018-03-06 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7137 OsmoSGSN: overview: Fix typo and reference OpenGGSN->OsmoGGSN Change-Id: I94cc362a4f52e6bd9f93299665e73dc4fd75a2c6 --- M OsmoSGSN/chapters/overview.adoc 1 file changed, 2 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-gsm-manuals[master]: Introduce chapter trx_if.adoc and add it to OsmoTRX and OsmoBTS

2018-03-06 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7140 Introduce chapter trx_if.adoc and add it to OsmoTRX and OsmoBTS This chapter defines the protocol used between osmo-trx and osmo-bts-trx. Most of the text comes originally from osmo-trx.git/README, as it's the only known documentation of the protocol

[PATCH] osmo-gsm-manuals[master]: OsmoBTS: bts-models: Add Lime Microsystems devices as suppor...

2018-03-06 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7136 OsmoBTS: bts-models: Add Lime Microsystems devices as supported osmo-trx Also take the chance to remove uneeded extra whitespace in surrounding text. Change-Id: I739e4dfba7c649a74cf67d6bbe6f74b22e7e24f0 --- M OsmoBTS/chapters/bts-models.adoc 1 file

[PATCH] osmo-gsm-manuals[master]: common: port_numbers: Add OsmoTRX and OsmoBTS missing ports

2018-03-06 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7138 common: port_numbers: Add OsmoTRX and OsmoBTS missing ports Change-Id: Idc34aa2d4241945e80c07e4e5660451a016f0117 --- M common/chapters/port_numbers.adoc 1 file changed, 3 insertions(+), 0 deletions(-) git pull

osmo-trx[master]: osmo-trx: Use VTY cfg structures while still allowing cmd li...

2018-03-06 Thread Pau Espin Pedrol
Patch Set 6: Manual submitted in https://gerrit.osmocom.org/#/c/7139/ -- To view, visit https://gerrit.osmocom.org/6651 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8de1a5da4b3c0b6a49e00033f616e1d66656adf Gerrit-PatchSet: 6

[PATCH] osmo-gsm-manuals[master]: Introduce OsmoTRX manual

2018-03-06 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7139 to look at the new patch set (#2). Introduce OsmoTRX manual Change-Id: I19ee9d6cda02fb7200c96c0ac129e69825b096cd --- M Makefile A OsmoTRX/Makefile A OsmoTRX/chapters/configuration.adoc

osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-06 Thread Pau Espin Pedrol
Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7022 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If661675528059bc8a95d39a6489a5a9381f52677 Gerrit-PatchSet: 5 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-06 Thread Pau Espin Pedrol
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7020 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dcf2a6fa2991cb73b4807f8a10d251f3dca77dd Gerrit-PatchSet: 3 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-06 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7021 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0 Gerrit-PatchSet: 4 Gerrit-Project: osmo-ci Gerrit-Branch: master

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/armv7l

2018-03-06 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

[PATCH] osmo-gsm-tester[master]: jenkins: use env POKY_VERSION POKY_PATH to find poky

2018-03-06 Thread lynxis lazus
Review at https://gerrit.osmocom.org/7124 jenkins: use env POKY_VERSION POKY_PATH to find poky Instead of hardcoded values, use defaults and allow jenkins to override the defaults. Change-Id: I1403b32cdf30420f3b02c41c2627b71fcbeae9ab --- M contrib/jenkins-build-osmo-bts-sysmo.sh M

[PATCH] osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

2018-03-06 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6668 to look at the new patch set (#11). implement support for 3-digit MNC with leading zeros Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout the

osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

2018-03-06 Thread Neels Hofmeyr
Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6668 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa Gerrit-PatchSet: 11 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-06 Thread lynxis lazus
Hello Pau Espin Pedrol, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7022 to look at the new patch set (#4). jenkins: add job osmo-gsm-tester_gerrit The job verifies the gerrit patchset. Change-Id: If661675528059bc8a95d39a6489a5a9381f52677 --- M

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-06 Thread lynxis lazus
Hello Pau Espin Pedrol, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7020 to look at the new patch set (#3). jenkins: add job osmo-gsm-tester_build-trigger-all osmo-gsm-tester_build-trigger-all triggers a new build of all osmo-gsm-tester build jobs.

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-06 Thread lynxis lazus
Hello Pau Espin Pedrol, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7021 to look at the new patch set (#3). jenkins: add osmo-gsm-tester_run-{prod,rnd} Both jobs doing the actual test run on the prod or rnd tester. Change-Id:

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

2018-03-06 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 215s]

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/x86_64

2018-03-06 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/aarch64

2018-03-06 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/aarch64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

2018-03-06 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

2018-03-06 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

osmo-gsm-tester[master]: jenkins: use env POKY_VERSION POKY_PATH to find poky

2018-03-06 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7124/1/contrib/jenkins-build-osmo-bts-sysmo.sh File contrib/jenkins-build-osmo-bts-sysmo.sh: Line 7: [ -z "$_poky_version" ] && _poky_version="2.3.2" Using _ as prefix here looks at bit ugly, specially since this variables are actually