It was 2013-04-24 śro 18:17, when Junio C Hamano wrote:
l.stelm...@samsung.com (Łukasz Stelmach) writes:
It was 2013-04-23 wto 17:02, when Junio C Hamano wrote:
Łukasz Stelmach l.stelm...@samsung.com writes:
Enable sending patches to NNTP servers (Usenet, Gmane).
---
The patch implements
It was 2013-04-25 czw 00:41, when Junio C Hamano wrote:
Thomas Rast tr...@inf.ethz.ch writes:
Łukasz Stelmach l.stelm...@samsung.com writes:
Enable sending patches to NNTP servers (Usenet, Gmane).
I'm surprised Junio didn't mention this: your patch lacks the
Signed-off-by.
Heh, that was
Ramkumar Ramachandra artag...@gmail.com writes:
Thomas Rast wrote:
I personally think we have enough magic revision syntax to last at least
another decade. If you propose to add some, please make a patch that we
can cook in next for a few release cycles and then conduct a straw poll
if
Okay, so the point I was trying to make is:
The range version of $(git merge-base A B) B is B ^$(git merge-base A
B), and not B --not $(git merge-base --all A B) [which is equivalent
to B ^A or A..B].
Junio C Hamano wrote:
I dunno. The description you gave was insufficient for me to answer
Thomas Rast wrote:
I already hate half of the existing syntax, and I cannot remember using
^! (except while investigating what 'git diff C^!' does and why not),
^@, @{-N} (only the related 'git checkout -'), @{date} and @{relative},
^{}, :/foo, and ^{/foo}, *at all*.
I'm actually totally in
Robert Zeh robert.allan@gmail.com writes:
Here is a patch that creates a daemon that tracks file
state with inotify, writes it out to a file upon request,
and changes most of the calls to stat to use said cache.
It has bugs, but I figured it would be smarter to see
if the approach was
Ramkumar Ramachandra artag...@gmail.com writes:
Hi,
So, I have three serious itches that would be nice to address:
1. git reset --hard HEAD~1/ git show HEAD~1 is a very common idiom
that's unnecessarily cumbersome to type out. We can make the rev
part of rev~n optional without being
On Thu, Apr 25, 2013 at 3:22 AM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Ramkumar Ramachandra artag...@gmail.com writes:
Hi,
So, I have three serious itches that would be nice to address:
1. git reset --hard HEAD~1/ git show HEAD~1 is a very common idiom
that's unnecessarily
Ramkumar Ramachandra artag...@gmail.com writes:
you might argue that ~n normally refers to a /home/n, but who uses
numbers in place of usernames?
~n expands to the nth element of the dir stack.
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756
Andreas Schwab wrote:
Ramkumar Ramachandra artag...@gmail.com writes:
you might argue that ~n normally refers to a /home/n, but who uses
numbers in place of usernames?
~n expands to the nth element of the dir stack.
Oh, ouch. And this is bash.
Have to think of something else.
--
To
When a rebase is interrupted by a merge conflict it could be useful to
know how far a rebase has progressed and how many commits in total this
rebase will apply. Teach the __git_ps1() command to display the number
of commits so far applied and the total number of commits to be applied.
Below is a
Ramkumar Ramachandra wrote:
$ git diff rebase.autostash ^$(git merge-base rebase.autostash master)
So, Thomas pointed out on IRC that there is one edge-case: a
criss-cross merge. So, we can define A~B as B ^$(git-merge-base
--closest-to=B A B). If both A and B are equidistant from the
fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) introduced a
test which was meant to skip the test unless the test shell is bash.
Unfortunately, it tests for the availability of bash only. But users can
opt to use a different shell (using SHELL_PATH) for the tests even though
bash is
Today when I push a long run repository, git complains:
$ git push -u github master:doc-tech
Counting objects: 5575, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (2560/2560), done.
remote: error: object
An insane ident line (generated by old version of git or by hands such
as git-hash-object) may cause segfault for `git log` and others commands.
This is because the `split_ident_line` function save the result in
ident_split, and the returned ident_split.date_begin, ident_split.date_end,
Oops, Ignore this patch please, I found they were already fixed by the
following commits
of next branch. Maybe next time I should patch something in next branch.
commit 9dbe7c3d7f4424cf0c27c2d4efabf72e58fa76b9
Author: René Scharfe rene.scha...@lsrfire.ath.cx
Date: Wed Apr 17 20:33:35 2013 +0200
Am 4/25/2013 12:09, schrieb Michael J Gruber:
fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) introduced a
test which was meant to skip the test unless the test shell is bash.
Unfortunately, it tests for the availability of bash only. But users can
opt to use a different shell
Felipe Contreras wrote:
Yeah, probably fine, but I would also like H~1.
You can get that now using `git symbolic ref H HEAD`. I'm wondering
if we can do better than hard-interpreting HEAD as H at the rev-parse
level.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of
Johannes Sixt venit, vidit, dixit 25.04.2013 12:59:
Am 4/25/2013 12:09, schrieb Michael J Gruber:
fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) introduced a
test which was meant to skip the test unless the test shell is bash.
Unfortunately, it tests for the availability of bash
Hi,
Here's a bunch of cleanups mostly to synchronize remote-bzr and remote-hg.
One of these might conflict with a series already in pu, if so, the code here
should be the prefered one.
Felipe Contreras (9):
remote-bzr: trivial cleanups
remote-hg: remove extra check
remote-bzr: fix bad
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/remote-helpers/git-remote-bzr | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/git-remote-bzr
index aa7bc97..82bf7c7 100755
---
Not needed since we use xrange ourselves.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/remote-helpers/git-remote-hg | 4
1 file changed, 4 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-hg
b/contrib/remote-helpers/git-remote-hg
index 5481331..0b7c81f
Carried from remote-hg.
The problem reportedly happened after doing a push that fails, the abort
causes the state of remote-hg to go bad, this happens because
remote-hg's marks are not stored, but 'git fast-export' marks are.
Ensure that the marks are _always_ stored.
Signed-off-by: Felipe
Just like in remote-hg.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/remote-helpers/git-remote-bzr | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/git-remote-bzr
index
To be in sync with remote-bzr.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/remote-helpers/git-remote-hg | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/git-remote-hg
b/contrib/remote-helpers/git-remote-hg
index
Mercurial might convert the URL to something more appropriate, like an
absolute path. Lets store that instead of the original URL, which won't
work from a different working directory if it's relative.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
It's simpler, and we don't need to depend on certain Mercurial versions.
Also, now we don't update the URL if 'file://' is not present.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/remote-helpers/git-remote-hg | 12 ++--
1 file changed, 6 insertions(+), 6
Otherwise we get notification, progress bars, and what not.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/remote-helpers/git-remote-bzr | 3 +++
1 file changed, 3 insertions(+)
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/git-remote-bzr
It's added by fast-export, the user didn't type it.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/remote-helpers/git-remote-bzr | 4
1 file changed, 4 insertions(+)
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/git-remote-bzr
index
Not just randomly synchronize the revisions with no checks at all. This
is the way bazaar's UI does it.
Also, add a non-ff check.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
This patch should probably go to maint, as the results of pushing the way we
currently push are not
Am 4/25/2013 13:21, schrieb Michael J Gruber:
Johannes Sixt venit, vidit, dixit 25.04.2013 12:59:
Am 4/25/2013 12:09, schrieb Michael J Gruber:
fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) introduced a
test which was meant to skip the test unless the test shell is bash.
Also added a missing colon that caused my bash 4.2.45(2)-release to
complain about an empty if.
Signed-off-by: Sebastian Götte ja...@physik-pool.tu-berlin.de
---
templates/hooks--pre-push.sample | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git
On 04/24/2013 09:54 PM, Junio C Hamano wrote:
None of the above is part of a proper commit log message, is it?
Fixed (I hope)
Signed-off-by: Sebastian Götte ja...@physik-pool.tu-berlin.de
diff --git a/templates/hooks--pre-push.sample
b/templates/hooks--pre-push.sample
old mode 100644
new
Martin von Zweigbergk wrote:
Normally one would break if unsuccessful. What would fail if this was
replaced by do_next || break and the above .. return 1 was ..
return. I assume that was your first attempt, but why did it not
work?
Thanks. This was a major thinko on my part, but I don't
Felipe Contreras felipe.contre...@gmail.com writes:
Not just randomly synchronize the revisions with no checks at all. This
is the way bazaar's UI does it.
Also, add a non-ff check.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
This patch should probably go to maint, as
Johannes Sixt j.s...@viscovery.net writes:
From: Johannes Sixt j...@kdbg.org
Bash on Windows does not implement process substitution.
Signed-off-by: Johannes Sixt j...@kdbg.org
---
...
Here is a fix. It assumes that the list of refs after the import is
a superset of the refs before the
Thomas Rast tr...@inf.ethz.ch writes:
Junio C Hamano gits...@pobox.com writes:
Thomas Rast tr...@inf.ethz.ch writes:
+test_extra_arg () {
+ expect=success
+ if test z$1 = z-f; then
+ expect=failure
+ shift
+ fi
+ test_expect_$expect extra args: $*
+
Michael J Gruber g...@drmicha.warpmail.net writes:
fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) introduced a
test which was meant to skip the test unless the test shell is bash.
Unfortunately, it tests for the availability of bash only.
True.
But users can
opt to use a
Johannes Sixt j.s...@viscovery.net writes:
Am 4/25/2013 12:09, schrieb Michael J Gruber:
fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) introduced a
test which was meant to skip the test unless the test shell is bash.
Unfortunately, it tests for the availability of bash only. But
On 25/04/2013 04:59, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
So, given all that, revised patch below:
I tried to squeeze the minimum test I sent $gmane/220919 to the test
suite. I think the do not use --parents option for this test
switch needs to be cleaned up a bit
Torsten Bögershausen tbo...@web.de writes:
Could we use the same logic as in t9903:
...
. ./lib-bash.sh
Please no. The test itself is not about something that checks how
we behave under bash (which is what 9903 wants to see). The use of
construct that is portable in t5801 is a pure and
Thomas Rast tr...@inf.ethz.ch writes:
What's the problem with cooking it for a while? You can start using it
immediately. I'm just somewhat annoyed that the syntax is rapidly
converging to Perl-style line noise.
Not quite, not quite, and a mild agreement.
Adding an obscure feature that may
Sebastian Götte ja...@physik.tu-berlin.de writes:
On 04/24/2013 09:54 PM, Junio C Hamano wrote:
None of the above is part of a proper commit log message, is it?
Fixed (I hope)
Don't hope, instead do. ;-)
The questions I asked were not requests to explain them to _me_ in a
response like
Kevin Bracey ke...@bracey.fi writes:
On 25/04/2013 04:59, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
So, given all that, revised patch below:
I tried to squeeze the minimum test I sent $gmane/220919 to the test
suite. I think the do not use --parents option for this
l.stelm...@samsung.com (Łukasz Stelmach) writes:
OK, I see. Good point. Where would you recommend me to put these modules
and how to name them? I mean I don't want to make to much mess here (;
I would not recommend you to do any of the above now. As I said, the
open-coded if/elsif cascade
Zoltan Klinger zoltan.klin...@gmail.com writes:
When a rebase is interrupted by a merge conflict it could be useful to
The command also stops when told to stop with amend, etc. no? I
would phrase this way When a rebase stops (e.g. interrupted ...),
it could be useful
This information can
Junio C Hamano wrote:
than ^!/^@
which I agree were more-or-less let's add a random cruft on a whim
without thinking things through mistakes.
I thought ^@ was invented for scripting, but can't imagine a usecase for ^!.
--
To unsubscribe from this list: send the line unsubscribe git in
the body
Junio C Hamano gits...@pobox.com writes:
Michael J Gruber g...@drmicha.warpmail.net writes:
fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) introduced a
test which was meant to skip the test unless the test shell is bash.
Unfortunately, it tests for the availability of bash only.
Junio C Hamano gits...@pobox.com writes:
l.stelm...@samsung.com (Łukasz Stelmach) writes:
OK, I see. Good point. Where would you recommend me to put these modules
and how to name them? I mean I don't want to make to much mess here (;
I would not recommend you to do any of the above now. As
On 25/04/2013 19:51, Junio C Hamano wrote:
Kevin Bracey ke...@bracey.fi writes:
Thanks for the test addition. Maybe we will be able to satisfy your
greed in this series. There could be more worth doing here, and I
think getting TREESAME precise is key.
It is perfectly fine to do things one
On Thu, Apr 25, 2013 at 9:57 AM, Junio C Hamano gits...@pobox.com wrote:
Johannes Sixt j.s...@viscovery.net writes:
From: Johannes Sixt j...@kdbg.org
Bash on Windows does not implement process substitution.
Signed-off-by: Johannes Sixt j...@kdbg.org
---
...
Here is a fix. It assumes that
The existing obj_hash is really straightforward: it holds a struct
object * and spills into the subsequent slots (linear probing), which
is good enough because it doesn't need to support deletion.
However, this arrangement has pretty bad cache locality in the case of
collisions. Because the sha1
Earlier we added support for --expire=all (or --expire=now) that
considers all crufts, regardless of their age, as eligible for
garbage collection by turning command argument parsers that use
approxidate() to use parse_expiry_date(), but git prune used a
built-in parse-options facility OPT_DATE()
Kevin Bracey ke...@bracey.fi writes:
On 25/04/2013 19:51, Junio C Hamano wrote:
Kevin Bracey ke...@bracey.fi writes:
Thanks for the test addition. Maybe we will be able to satisfy your
greed in this series. There could be more worth doing here, and I
think getting TREESAME precise is key.
Felipe Contreras wrote:
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/git-remote-bzr
index aa7bc97..82bf7c7 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -94,7 +94,7 @@ class Marks:
return
Felipe Contreras wrote:
diff --git a/contrib/remote-helpers/git-remote-hg
b/contrib/remote-helpers/git-remote-hg
index 5481331..0b7c81f 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -332,10 +332,6 @@ def export_ref(repo, name, kind, head):
Felipe Contreras felipe.contre...@gmail.com writes:
...
+ git for-each-ref --format='%(refname) %(objectname)' |
+ while read ref a
do
- test $a == $b continue
+ case $before in
+ *$ref $a*)
Felipe Contreras wrote:
To be in sync with remote-bzr.
Huh? Why do you have to be in sync with remote-bzr? Are you sharing
code between remote-hg and remote-bzr?
@@ -830,7 +831,7 @@ def main(args):
if alias[4:] == url:
is_tmp = True
-alias =
Depending on the implementation, the echo command may
support options like -n -e -E or no options at all.
The only portable usage of echo is without any options,
which means that no parameter may start with a hyphen.
check-non-portable-shell.pl checks if echo -n is used.
Improve it to reject any
The make test-lint could check for some common non portable
grep usage:
The + as a qualifier is not a basic regular expression.
Some grep understand \+, but in general egrep should be used.
The \t can not be used to find an ASCII TAB, neither
can \s be used to find a whitespace
Signed-off-by:
t/check-non-portable-sh.pl checks for bash only syntax like test $a == $b
This is wrong when bash is used.
Switch to bash mode and skip this test
Signed-off-by: Torsten Bögershausen tbo...@web.de
---
t/check-non-portable-shell.pl | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
The make test-lint could check for lines like
export X=Y
This is bash syntax and should be written in 2 lines:
X=Y
export X
Signed-off-by: Torsten Bögershausen tbo...@web.de
---
t/check-non-portable-shell.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Spilt lines like export X=Y into 2 lines:
X=Y
export X
Signed-off-by: Torsten Bögershausen tbo...@web.de
---
t/t9501-gitweb-standalone-http-status.sh | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/t/t9501-gitweb-standalone-http-status.sh
The prerequisite checker for DATE_PARSER should use
$PERL_PATH instead of perl
Signed-off-by: Torsten Bögershausen tbo...@web.de
---
t/t9501-gitweb-standalone-http-status.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9501-gitweb-standalone-http-status.sh
On Thu, Apr 25, 2013 at 1:07 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
2. git rebase -i master fails unless I've rebased my branch on top of
master. I always wished I could do the equivalent of 'git rebase -i
master..', but I can't.
In what way does it fail? It seems to work ok for
On Thu, Apr 25, 2013 at 1:19 PM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Felipe Contreras wrote:
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/git-remote-bzr
index aa7bc97..82bf7c7 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++
On Thu, Apr 25, 2013 at 1:23 PM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Felipe Contreras wrote:
diff --git a/contrib/remote-helpers/git-remote-hg
b/contrib/remote-helpers/git-remote-hg
index 5481331..0b7c81f 100755
--- a/contrib/remote-helpers/git-remote-hg
+++
On Thu, Apr 25, 2013 at 1:25 PM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
...
+ git for-each-ref --format='%(refname) %(objectname)' |
+ while read ref a
do
- test $a == $b continue
On 04/25/2013 08:19 PM, Ramkumar Ramachandra wrote:
Felipe Contreras wrote:
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/git-remote-bzr
index aa7bc97..82bf7c7 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@
On Thu, Apr 25, 2013 at 1:25 PM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Felipe Contreras wrote:
To be in sync with remote-bzr.
Huh? Why do you have to be in sync with remote-bzr? Are you sharing
code between remote-hg and remote-bzr?
We don't have to.
@@ -830,7 +831,7 @@ def
On Thu, Apr 25, 2013 at 2:29 PM, Stefano Lattarini
stefano.lattar...@gmail.com wrote:
On 04/25/2013 08:19 PM, Ramkumar Ramachandra wrote:
@@ -521,7 +521,7 @@ def c_style_unescape(string):
return string
def parse_commit(parser):
-global marks, blob_marks, bmarks, parsed_refs
+
On Thu, Apr 25, 2013 at 3:18 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Robert Zeh robert.allan@gmail.com writes:
Here is a patch that creates a daemon that tracks file
state with inotify, writes it out to a file upon request,
and changes most of the calls to stat to use said cache.
Instead of searching for LF and NUL with two strchr() calls use a single
strchrnul() call. We don't need to check if the returned pointer is NULL
because either we'll find the NUL at the end of line, or the caller
forgot to NUL-terminate the string and we'll overrun the buffer in any
case. Also
Keep namelen unchanged and don't use it to hold a value that we're not
interested in anyway -- we can use maillen and the constant part
directly instead. This simplifies the code slightly and prepares for
the next patch that makes use of the original value of namelen.
Signed-off-by: Rene Scharfe
Use namebuf/namelen and mailbuf/maillen directly instead of copying
their contents into strbufs first.
Signed-off-by: Rene Scharfe rene.scha...@lsrfire.ath.cx
---
pretty.c | 29 +
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/pretty.c b/pretty.c
index
On Wed, Apr 24, 2013 at 4:32 PM, Duy Nguyen pclo...@gmail.com wrote:
On Thu, Apr 25, 2013 at 3:20 AM, Robert Zeh robert.allan@gmail.com
wrote:
Here is a patch that creates a daemon that tracks file
state with inotify, writes it out to a file upon request,
and changes most of the calls to
Robert Zeh robert.allan@gmail.com writes:
On Thu, Apr 25, 2013 at 3:18 AM, Thomas Rast tr...@inf.ethz.ch wrote:
I don't get this bit. The lstat() are run over all files listed in the
index. So shouldn't your daemon watch exactly those (or rather, all
dirnames of such files)?
I believe
Hi,
Previously known as git-cc-cmd, I've renamed it git-related (tentatively). I
removed support for aliases, as I don't think it's very useful, and I've added
support for mailmap, which I think covers similar use-cases.
This script allows you to get a list of relevant persons to Cc when sending
This script find people that might be interested in a patch, by going
back through the history for each single hunk modified, and finding
people that reviewed, acknowledge, signed, or authored the code the
patch is modifying.
It does this by running 'git blame' incrementally on each hunk, and
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 17 +
1 file changed, 17 insertions(+)
diff --git a/contrib/related/git-related b/contrib/related/git-related
index 2d47efa..702836a 100755
--- a/contrib/related/git-related
+++
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/contrib/related/git-related b/contrib/related/git-related
index 702836a..90ec3aa 100755
---
Instead of showing the authors and signers, show the commits themselves.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 18 ++
1 file changed, 18 insertions(+)
diff --git a/contrib/related/git-related b/contrib/related/git-related
For example master..feature-a.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 36 ++--
1 file changed, 34 insertions(+), 2 deletions(-)
diff --git a/contrib/related/git-related b/contrib/related/git-related
index
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 14 ++
1 file changed, 14 insertions(+)
diff --git a/contrib/related/git-related b/contrib/related/git-related
index 0015b3c..2f38ee1 100755
--- a/contrib/related/git-related
+++
For example '-1'.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/contrib/related/git-related b/contrib/related/git-related
index 2f38ee1..e8603be 100755
---
Currently only the roles of 'author' and 'signer' and handler, but now
there's also 'reviewer' and 'acker'.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/contrib/related/git-related b/contrib/related/git-related
index cf6818e..4e9b916 100755
--- a/contrib/related/git-related
+++
We still need the name of the person, so it might make sense to have a
Person object to simplify the code. Later.
Suggested-by: Duy Nguyen pclo...@gmail.com
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 11 +++
1 file changed, 7
This seems to be the way git tools do it.
Suggested-by: Duy Nguyen pclo...@gmail.com
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
contrib/related/git-related | 36
1 file changed, 36 insertions(+)
diff --git a/contrib/related/git-related
Felipe Contreras felipe.contre...@gmail.com writes:
On Thu, Apr 25, 2013 at 1:25 PM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
...
+ git for-each-ref --format='%(refname) %(objectname)' |
+ while read ref a
Thomas Rast tr...@inf.ethz.ch writes:
So we take a slightly different approach, and trade some memory for
better cache locality.
Interesting. It feels somewhat bait-and-switch to reveal that the
above some turns out to be double later, but the resulting code
does not look too bad, and the
Felipe Contreras felipe.contre...@gmail.com writes:
But I do not care that much really. The patch is good either way, if
you don't like it, you go ahead and fix it, because I won't. I have
174 remote-helper related patches in my queue, and nobody benefits
from rambling about a one liner that
On Thu, Apr 25, 2013 at 3:06 PM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
On Thu, Apr 25, 2013 at 1:25 PM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
...
+ git for-each-ref
Felipe Contreras felipe.contre...@gmail.com writes:
But I do not care that much really. The patch is good either way, if
you don't like it, you go ahead and fix it, because I won't. I have
174 remote-helper related patches in my queue, and nobody benefits
from rambling about a one liner that
Torsten Bögershausen tbo...@web.de writes:
The make test-lint could check for some common non portable
grep usage:
The + as a qualifier is not a basic regular expression.
Some grep understand \+, but in general egrep should be used.
The \t can not be used to find an ASCII TAB, neither
can
Torsten Bögershausen tbo...@web.de writes:
Spilt lines like export X=Y into 2 lines:
X=Y
export X
That can be read from the patch text.
If you are going to spend three lines, please describe why it has to
be split; that would help educate developers new to the codebase.
Thanks.
On Thu, Apr 25, 2013 at 3:30 PM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
But I do not care that much really. The patch is good either way, if
you don't like it, you go ahead and fix it, because I won't. I have
174 remote-helper related patches
Junio C Hamano gits...@pobox.com writes:
Thomas Rast tr...@inf.ethz.ch writes:
So we take a slightly different approach, and trade some memory for
better cache locality.
Interesting. It feels somewhat bait-and-switch to reveal that the
above some turns out to be double later, but the
Thomas Rast tr...@inf.ethz.ch writes:
Felipe Contreras felipe.contre...@gmail.com writes:
Not just randomly synchronize the revisions with no checks at all. This
is the way bazaar's UI does it.
Also, add a non-ff check.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
On Fri, Apr 26, 2013 at 1:04 AM, Thomas Rast tr...@inf.ethz.ch wrote:
So we take a slightly different approach, and trade some memory for
better cache locality. Namely, we change the hash table slots to
contain
struct object *obj;
unsigned long sha1prefix;
We use this new 'sha1prefix'
1 - 100 of 153 matches
Mail list logo
