On Jul 17, 2014, at 19:22, Jonathan Nieder wrote:
Thanks for these details. I'll file a bug and mull it over some more.
RFC 6762 makes it clear that what the package is currently doing is
wrong. Given that Debian's libc knows nothing about mdns on its own,
I think I'll need to parse resolv.co
I'm sorry, i've made mistake in this one. Please ingnore it. Correct
patch is on the way.
kind regards,
b.
On Fri, Jul 18, 2014 at 6:05 AM, Andrej Manduch wrote:
> * this fixes 'git svn info `pwd`' buggy behaviour
>
> Signed-off-by: Andrej Manduch
> ---
> git-svn.perl | 2 +-
> 1 file changed
* this fixes 'git svn info `pwd`' buggy behaviour
Signed-off-by: Andrej Manduch
---
git-svn.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-svn.perl b/git-svn.perl
index 0a32372..5bbfecf 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2029,7 +2029,7 @@ sub find_file
On Sun, Jul 13, 2014 at 12:50 AM, Nguyễn Thái Ngọc Duy
wrote:
> "git checkout --to" sets up a new working directory with a .git file
> pointing to $GIT_DIR/repos/. It then executes "git checkout" again
> on the new worktree with the same arguments except "--to" is taken
> out. The second checkout
* this fixes 'git svn info `pwd`' buggy behaviour
Signed-off-by: Andrej Manduch
---
git-svn.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-svn.perl b/git-svn.perl
index 0a32372..c3d893e 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2029,7 +2029,7 @@ sub find_file
Kyle J. McKay wrote:
> On Jul 17, 2014, at 15:10, Jonathan Nieder wrote:
>> It was added to respond to a feature request within Debian but it is
>> intended to eventually go upstream. I'm glad you found this issue
>> before that could happen. :)
>
> Is there some reason the patch is not opt-in at
I'm developing a project called [Plushu][], an ecosystem for creating
plugin-based dedicated user shells, patterned after [Dokku][] (and
similar to git-shell).
[Plushu]: https://github.com/plushu/plushu
[Dokku]: https://github.com/progrium/dokku
Plushu has its own hook system for plugins (so m
On Jul 17, 2014, at 15:10, Jonathan Nieder wrote:
Hi,
Kyle J. McKay wrote:
When I then try to fetch using a "git://host/..." URL where "host"
is an mDNS host name, the 0010 patch causes git to attempt to lookup
a DNS SRV record on the non-mDNS regular DNS service (a violation of
RFC 6762 [4] s
Use the existing argv_array member instead of providing our own. This
way the argv_array is cleared after use automatically for us; it was
leaking before.
Signed-off-by: Rene Scharfe
---
bundle.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/bundle.c b/bun
Am 17.07.2014 19:05, schrieb René Scharfe:
> Am 17.07.2014 14:45, schrieb Nguyễn Thái Ngọc Duy:
[...]
> "These routines have traditionally been used by programs to save the
> name of a working directory for the purpose of returning to it. A much
> faster and less error-prone method of accomplishing
Am 17.07.2014 20:03, schrieb Junio C Hamano:
> Nguyễn Thái Ngọc Duy writes:
>
>> This array 'cwd' is used to store the result from getcwd() and chdir()
>> back. PATH_MAX is the right constant for the job. On systems with
>> longer PATH_MAX (eg. 4096 on Linux), hard coding 1024 fails stuff,
>> e.
Am 17.07.2014 14:45, schrieb Nguyễn Thái Ngọc Duy:
> e.g. "git init". Make it static too to reduce stack usage.
But wouldn't this increase overall memory usage? Stack memory
will be reused by subsequent code, while static memory cannot
be reused (but still increases the process working set).
--
T
Hi,
Kyle J. McKay wrote:
> When I then try to fetch using a "git://host/..." URL where "host"
> is an mDNS host name, the 0010 patch causes git to attempt to lookup
> a DNS SRV record on the non-mDNS regular DNS service (a violation of
> RFC 6762 [4] section 22) and this is what has to time out b
On Wed, Jul 16, 2014 at 11:57:47PM +0200, René Scharfe wrote:
> Use the existing argv_array member instead of providing our own. This
> way we don't have to initialize or clean it up explicitly.
Yay. Thanks for this cleanup (and all of the other recent ones; they all
looked good to me).
-Peff
-
===
What is it?
===
I have created a script (POSIX sh compatible) that allows running git-
http-backend via inetd or similar service (it makes it like git-http-
backend had a --inet option just like git-daemon does).
This allows the Git smart HTTP protocol to be served without
Stepan Kasal writes:
> From: Pat Thoyts
>
> The path in a .git platform independent link file needs to be absolute
> and under mingw we need it to be a windows type path, not a unix style
> path so it should start with a drive letter and not a /.
OK. We seem to have uses of "pwd -P" in other
Karsten Blees writes:
> Yes. 0, 1 and 2 work (vie GetStdHandle), but anything else is handled
> by the C-runtime. And as MSYS.dll (bash) and MSVCRT.dll (git) do it in
> different ways, it doesn't work.
>
>> -echo copy 6 |
>> -test-line-buffer "&4" 4actual &&
>> +test-line-buffer "&0"
Am 17.07.2014 20:41, schrieb Junio C Hamano:
> Stepan Kasal writes:
>
>> From: Johannes Schindelin
>>
>> ... because that does not work in MinGW.
>>
>> Signed-off-by: Johannes Schindelin
>> Signed-off-by: Stepan Kasal
>> ---
>> t/t0081-line-buffer.sh | 2 +-
>> 1 file changed, 1 insertion(+),
On Thu, Jul 17, 2014 at 12:53 PM, Heiko Voigt wrote:
>
> On Tue, Jul 15, 2014 at 03:37:21PM -0700, Junio C Hamano wrote:
> > Any other thing that still needs fixing in the series, or is it now
> > ready for 'next'?
>
> All comments addressed. From my side it should be ready for next.
Thanks; I am
Hi Junio,
On Thu, 17 Jul 2014, Junio C Hamano wrote:
> Is what is broken on MinGW redirecting arbitrary file descrptors?
IIRC that was exactly the problem.
> diff --git a/t/t0081-line-buffer.sh b/t/t0081-line-buffer.sh
> index bd83ed3..881789a 100755
> --- a/t/t0081-line-buffer.sh
> +++ b/t/t00
On Tue, Jul 15, 2014 at 03:37:21PM -0700, Junio C Hamano wrote:
> Heiko Voigt writes:
>
> >> Can there be any caller that include and use submodule-config.h that
> >> does not need anythjing from submodule.h? Or vice versa?
> >>
> >> It just did not look like these two headers describe independ
"Kyle J. McKay" writes:
> There are two options to turn off this behavior, -i and -oi which
> are equivalent.
>
> The choice of which to use is based on the observation that -i
> appears to be the more commonly used option for this and that all
> current sendmail-compatible programs appear to acc
When sendmail is reading an incoming message, by default it will
terminate it if it reads a dot on a line by itself.
The post-receive-email script can generate such a line if the
message in a tag object contains a dot ('.') on a line by itself.
There are two options to turn off this behavior, -i
Am 17.07.2014 21:00, schrieb Stepan Kasal:
> Hi,
>
>> Karsten Blees writes:
>>> I believe we prefer moving code to the right place over forward
>>> declarations (IIRC I got bashed for the latter in one of the first rounds
>>> of this patch series). If only to justify 'git-blame -M' :-D
>
> indee
Stepan Kasal writes:
> If anyone thinks the resulting ordering is not OK, they can propose
> one re-order patch on top of this series.
I agree that that would be a good way to go.
> Junio wrote:
>> OK, so the series may need further re-polishing of the polishing
>> done by Stepan last-minute be
Hi,
> Karsten Blees writes:
> > I believe we prefer moving code to the right place over forward
> > declarations (IIRC I got bashed for the latter in one of the first rounds
> > of this patch series). If only to justify 'git-blame -M' :-D
indeed, my position is the same, generally.
But it turne
Stepan Kasal writes:
> From: Johannes Schindelin
>
> ... because that does not work in MinGW.
>
> Signed-off-by: Johannes Schindelin
> Signed-off-by: Stepan Kasal
> ---
> t/t0081-line-buffer.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0081-line-buffer.sh b/t
On 07/17/2014 10:23 AM, Junio C Hamano wrote:
Michael Barabanov writes:
Move the is_local logic to the place where origin remote has been setup and
check if the remote url can be used to do local cloning.
This saves a lot of space (and time) in some of the mirroring scenarios that
involve in
Karsten Blees writes:
> Am 17.07.2014 17:37, schrieb Stepan Kasal:
>
> I believe we prefer moving code to the right place over forward
> declarations (IIRC I got bashed for the latter in one of the first rounds
> of this patch series). If only to justify 'git-blame -M' :-D
>
>> One of the patches
Am 17.07.2014 17:37, schrieb Stepan Kasal:
> From: Johannes Schindelin
>
> The bash Git for Windows uses (i.e. the MSys bash) cannot pass
> command-line arguments with high bits set verbatim to non-MSys programs,
> but instead converts those characters with high bits set to their hex
> representa
René Scharfe writes:
> "These routines have traditionally been used by programs to save the
> name of a working directory for the purpose of returning to it. A much
> faster and less error-prone method of accomplishing this is to open the
> current directory (.) and use the fchdir(2) function to
Am 17.07.2014 17:37, schrieb Stepan Kasal:
> Hello,
>
> this is the remainder of Karsten's unicode branch, that is a time
> proven part of msysGit. (If this code is accepted, only one patch
> would only remain: gitk and git-gui fixes.)
>
Thank you so much!
I had to add '#include "../cache.h"'
Nguyễn Thái Ngọc Duy writes:
> This array 'cwd' is used to store the result from getcwd() and chdir()
> back. PATH_MAX is the right constant for the job. On systems with
> longer PATH_MAX (eg. 4096 on Linux), hard coding 1024 fails stuff,
> e.g. "git init". Make it static too to reduce stack usa
Stepan Kasal writes:
> ... only one patch
> would only remain: gitk and git-gui fixes.)
Nice.
Will queue.
> When rebasing Karsten's work, I have eliminated two commits:
> https://github.com/msysgit/git/commit/f967550
> https://github.com/msysgit/git/commit/290bf81
>
> These commits only moved
Michael Barabanov writes:
> Move the is_local logic to the place where origin remote has been setup and
> check if the remote url can be used to do local cloning.
>
> This saves a lot of space (and time) in some of the mirroring scenarios that
> involve insteadOf rewrites.
>
> Signed-off-by: Micha
Matthieu Moy writes:
> Matthieu Moy writes:
>
>> Tanay Abhra writes:
>>
>>> I have a question about renaming git_config() to git_config_raw().
>>> I was working on a patch and I am getting stuck here.
>>> It fails in t1001, t1020 & t4018. The reason for the last test failure
>>> is unknown righ
Am 17.07.2014 14:45, schrieb Nguyễn Thái Ngọc Duy:
> This array 'cwd' is used to store the result from getcwd() and chdir()
> back. PATH_MAX is the right constant for the job.
PATH_MAX may be better than 1024, but there can't really be a correct
constant. The actual limit depends on the file syst
Matthieu Moy writes:
> Sajan Parikh writes:
>
>> By syncing my code folder and git repositories in this way, do I risk
>> borking any repositories? I'm 99% confident I'm not, since everything
>> is in .git/, and there are not external databases or log files that
>> need to be updated. Just mak
From: Karsten Blees
The Windows environment is sorted, keep it that way for O(log n)
environment access.
Change compareenv to compare only the keys, so that it can be used to
find an entry irrespective of the value.
Change lookupenv to binary seach for an entry. Return one's complement of
the i
From: Karsten Blees
Convert environment from UTF-16 to UTF-8 on startup.
No changes to getenv() are necessary, as the MSVCRT version is implemented
on top of char **environ.
However, putenv / _wputenv from MSVCRT no longer work, for two reasons:
1. they try to keep environ, _wenviron and the Wi
From: Karsten Blees
All functions that modify the environment have memory leaks.
Disable gitunsetenv in the Makefile and use env_setenv (via mingw_putenv)
instead (this frees removed environment entries).
Move xstrdup from env_setenv to make_augmented_environ, so that
mingw_putenv no longer cop
From: Karsten Blees
Convert environment from UTF-8 to UTF-16 when creating other processes.
Signed-off-by: Karsten Blees
Signed-off-by: Stepan Kasal
---
compat/mingw.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.
From: Karsten Blees
Move environment array reallocation from do_putenv to the respective
callers. Keep track of the environment size in a global variable. Use
ALLOC_GROW in mingw_putenv to reduce reallocations. Allocate a
sufficiently sized environment array in make_environment_block to prevent
r
From: Karsten Blees
When spawning child processes via start_command(), the environment and all
environment entries are copied twice. First by make_augmented_environ /
copy_environ to merge with child_process.env. Then a second time by
make_environment_block to create a sorted environment block st
From: Karsten Blees
Git requires the TERM environment variable to be set for all color*
settings. Simulate the TERM variable if it is not set (default on Windows).
Signed-off-by: Karsten Blees
Signed-off-by: Johannes Schindelin
Signed-off-by: Stepan Kasal
---
compat/mingw.c | 4
1 file
From: Karsten Blees
Environment helper functions use random naming ('env' prefix or suffix or
both, with or without '_'). Change to POSIX naming scheme ('env' suffix,
no '_').
Env_setenv has more in common with putenv than setenv. Change to do_putenv.
Signed-off-by: Karsten Blees
Signed-off-by
From: Karsten Blees
As of d41489a6 "Add more large blob test cases", git's high-level memory
allocation functions (xmalloc, xmemdupz etc.) access the environment to
simulate limited memory in tests (see 'getenv("GIT_ALLOC_LIMIT")' in
memory_limit_check()). These functions should not be used befor
From: Karsten Blees
The environment on Windows is case-insensitive. Some environment functions
(such as unsetenv and make_augmented_environ) have always used case-
sensitive comparisons instead, while others (getenv, putenv, sorting in
spawn*) were case-insensitive.
Prevent potential inconsisten
From: Karsten Blees
Signed-off-by: Karsten Blees
Signed-off-by: Stepan Kasal
---
compat/mingw.c | 55 ---
1 file changed, 32 insertions(+), 23 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index 89fe62b..3f81c90 100644
--- a/comp
Hello,
this is the remainder of Karsten's unicode branch, that is a time
proven part of msysGit. (If this code is accepted, only one patch
would only remain: gitk and git-gui fixes.)
When rebasing Karsten's work, I have eliminated two commits:
https://github.com/msysgit/git/commit/f967550
https:
From: Karsten Blees
This reverts commit df599e9612788b728ce43a03159b85f1fe624d6a.
As of 5e9637c6 "i18n: add infrastructure for translating Git with gettext",
eval_gettext uses MinGW envsubst.exe instead of git-sh-i18n--envsubst.exe
for variable substitution. This breaks git-submodule.sh messages
From: Karsten Blees
Fix Windows specific environment settings on startup rather than checking
for special values on every getenv call.
As a side effect, this makes the patched environment (i.e. with properly
initialized TMPDIR and TERM) available to child processes.
Signed-off-by: Karsten Blees
From: Johannes Schindelin
... because that does not work in MinGW.
Signed-off-by: Johannes Schindelin
Signed-off-by: Stepan Kasal
---
t/t0081-line-buffer.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0081-line-buffer.sh b/t/t0081-line-buffer.sh
index bd83ed3..25dba
From: Pat Thoyts
The path in a .git platform independent link file needs to be absolute
and under mingw we need it to be a windows type path, not a unix style
path so it should start with a drive letter and not a /.
Signed-off-by: Pat Thoyts
Signed-off-by: Stepan Kasal
---
t/t9902-completion.
From: Johannes Schindelin
The bash Git for Windows uses (i.e. the MSys bash) cannot pass
command-line arguments with high bits set verbatim to non-MSys programs,
but instead converts those characters with high bits set to their hex
representation.
For example, when running
strings "$(ec
From: Karsten Blees
MSys works very hard to convert Unix-style paths into DOS-style ones.
*Very* hard.
So hard, indeed, that
git blame -L/hello/,/green/
is translated into something like
git blame -LC:/msysgit/hello/,C:/msysgit/green/
As seen in msys_p2w in src\msys\msys\rt\s
From: Karsten Blees
On Windows, all native APIs are Unicode-based. It is impossible to pass
legacy encoded byte arrays to a process via command line or environment
variables. Disable the tests that try to do so.
In t3901, most tests still work if we don't mess up the repository encoding
in setup
Hello,
this is a collection of quality test suite fixes, hand picked with care,
following the expert advice by Karsten. :-)
Most of them just switch off the tests on MinGW, one uses `pwd -W' to get
the reeal windows path. All of these are time proven, they have been in
msysgit since Dec 2013, at
From: Pat Thoyts
On Windows the application command line is provided as unicode and in
mingw-git we convert that to utf-8. So these tests that require a iso-8859-1
input are being subverted by the encoding transformations we perform and
should be skipped.
Signed-off-by: Pat Thoyts
Signed-off-by
On 17.07.2014 16:29, Junio C Hamano wrote:
> If you received a private "no" to some entries, please advise;
> otherwise I would say the patch is ready to be picked up.
I have received neither a no nor a yes privately.
So please pick it up as you like.
--
To unsubscribe from this list: send the lin
Stefan Beller writes:
> Pretty much one year ago
> (94b410bba864, Jul 12 2013, .mailmap: Map email addresses to names)
> I cleaned up the output of `git shortlog -sne` of git.git by writing a
> .mailmap file fot the git.git project.
> Now I find some time again for another review.
> During the ye
This array 'cwd' is used to store the result from getcwd() and chdir()
back. PATH_MAX is the right constant for the job. On systems with
longer PATH_MAX (eg. 4096 on Linux), hard coding 1024 fails stuff,
e.g. "git init". Make it static too to reduce stack usage.
Signed-off-by: Nguyễn Thái Ngọc Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tanay Abhra writes:
> I am searching for a more elegant solution to this problem.
The "efficient" (not sure about elegant) solution would be to keep one
configset per file, and re-parse only the files needed.
I find the solution I posted in the other thread relatively "elegant":
invalidate the
Matthieu Moy writes:
> Tanay Abhra writes:
>
>> I have a question about renaming git_config() to git_config_raw().
>> I was working on a patch and I am getting stuck here.
>> It fails in t1001, t1020 & t4018. The reason for the last test failure
>> is unknown right now. For the first two, it boi
On 7/17/2014 3:31 PM, Matthieu Moy wrote:
> Tanay Abhra writes:
>
>> I have a question about renaming git_config() to git_config_raw().
>> I was working on a patch and I am getting stuck here.
>> It fails in t1001, t1020 & t4018. The reason for the last test failure
>> is unknown right now. For t
On Thu, Jul 17, 2014 at 01:27:08AM -0700, Yue Lin Ho wrote:
> I see that refresh() of update_index.c calls setup_work_tree() to change dir
> to working tree.
> And the dir is not changed back to git dir before commit_lock_file() or
> rollback_lock_file() is called.
>
> So, commit_lock_file() renam
Tanay Abhra writes:
> I have a question about renaming git_config() to git_config_raw().
> I was working on a patch and I am getting stuck here.
> It fails in t1001, t1020 & t4018. The reason for the last test failure
> is unknown right now. For the first two, it boils down to this,
>
>
On Wed, Jul 16, 2014 at 05:36:03PM -0400, Ted Felix wrote:
> On 07/16/2014 03:23 PM, John Keeping wrote:
> > Change from v1:
> > - add a test case
>
> Test case is working fine for me. It passes with the patch and fails
> without. However, it does seem to cause all the rest of the test cas
Am 17.07.2014 00:16, schrieb Junio C Hamano:
> Karsten Blees writes:
>
>> There is no fchmod() on native Windows platforms (MinGW and MSVC), and the
>> equivalent Win32 API (SetFileInformationByHandle) requires Windows Vista.
>>
>> Use chmod() instead.
>>
>> Signed-off-by: Karsten Blees
>> ---
>
I see that refresh() of update_index.c calls setup_work_tree() to change dir
to working tree.
And the dir is not changed back to git dir before commit_lock_file() or
rollback_lock_file() is called.
So, commit_lock_file() rename file failed.
or rollback_lock_file() delete file failed.
--
View th
Move the is_local logic to the place where origin remote has been setup and
check if the remote url can be used to do local cloning.
This saves a lot of space (and time) in some of the mirroring scenarios that
involve insteadOf rewrites.
Signed-off-by: Michael Barabanov
---
builtin/clone.c | 25
72 matches
Mail list logo
