Hi,
back to the pipe-topic.
On Wednesday 01 August 2012 12:42:48 Jonathan Nieder wrote:
Hi again,
Florian Achleitner wrote:
When the first line arrives at the remote-helper, it starts importing one
line at a time, leaving the remaining lines in the pipe.
For importing it requires
On Sunday 12 August 2012 09:12:58 Jonathan Nieder wrote:
Hi again,
Florian Achleitner wrote:
back to the pipe-topic.
Ok, thanks.
[...]
The way it's supposed to work is that in a bidi-import, the remote
helper reads in the entire list of refs to be imported and only once
Hi.
Version 3 of this series adds the 'bidi-import' capability, as suggested
Jonathan.
Diff details are attached to the patches.
04 and 05 are completely new.
[PATCH/RFC v3 01/16] Implement a remote helper for svn in C.
[PATCH/RFC v3 02/16] Integrate remote-svn into svn-fe/Makefile.
[PATCH/RFC
stdin. It buffers a batch of 'import' command lines
in a string_list before starting to process them.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
diff:
- incorporate review
- remove redundant strbuf_init
- add 'bidi-import' to capabilities
- buffer all lines
The existing function only allows reading from a filename or
from stdin. Allow passing of a FD and an additional FD for
the back report pipe. This allows us to retrieve the name of
the pipe in the caller.
Fixes the filename could be NULL bug.
Signed-off-by: Florian Achleitner florian.achleitner
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b/Documentation/git-remote-helpers.txt
index f5836e4
to the 'capablilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
- fix hard-coded ref in test-svn-fe.c. Broke a testcase.
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c
to open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
contrib/svn-fe/remote-svn.c | 59 ++-
1 file changed, 36 insertions(+), 23 deletions(-)
diff --git a/contrib/svn-fe/remote-svn.c b/contrib
in the note. This can be refined on purpose, of course.
- Revision-number
- Node-path
- Node-kind
- Node-action
- Node-copyfrom-path
- Node-copyfrom-rev
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
vcs-svn/fast_export.c | 13 +
vcs-svn/fast_export.h |2 ++
vcs
.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
contrib/svn-fe/remote-svn.c | 66 +--
contrib/svn-fe/svn-fe.c |3 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.c | 16 ---
vcs-svn
Use svnrdump_sim.py to emulate svnrdump without an svn server.
Tests fetching, incremental fetching, fetching from file://,
and the regeneration of fast-import's marks file.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
t/t9020-remote-svn.sh | 69
On Tuesday 14 August 2012 13:14:12 Junio C Hamano wrote:
Florian Achleitner florian.achleitner.2.6...@gmail.com writes:
Requires some sha.h to be used and the libraries
to be linked, this is currently hardcoded.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
On Tuesday 14 August 2012 13:46:43 Junio C Hamano wrote:
Florian Achleitner florian.achleitner.2.6...@gmail.com writes:
Allow execution of git-remote-svn even if the binary
currently is located in contrib/svn-fe/.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Forget this patch! It contains some unwanted content. Something with rebasing
went wrong..
On Tuesday 14 August 2012 21:13:18 Florian Achleitner wrote:
Use svnrdump_sim.py to emulate svnrdump without an svn server.
Tests fetching, incremental fetching, fetching from file
On Tuesday 14 August 2012 13:40:20 Junio C Hamano wrote:
Florian Achleitner florian.achleitner.2.6...@gmail.com writes:
The fast-import commands 'cat-blob' and 'ls' can be used by remote-helpers
to retrieve information about blobs and trees that already exist in
fast-import's memory
On Wednesday 15 August 2012 12:49:04 Junio C Hamano wrote:
Florian Achleitner florian.achleitner.2.6...@gmail.com writes:
To provide metadata from svn dumps for further processing, e.g.
branch detection, attach a note to each imported commit that
stores additional information.
The notes
On Wednesday 15 August 2012 12:52:43 Junio C Hamano wrote:
Florian Achleitner florian.achleitner.2.6...@gmail.com writes:
fast-import internally uses marks that refer to an object via its sha1.
Those marks are created during import to find previously created objects.
At exit the accumulated
Hi!
Thanks for the reviews!
This series contains the follwing improvements.
I decided to summarize them here, sorted by topic instead of
attaching them to the patches.
all:
- remove all merge garbage and debugging legacy (hopefully).
- reviews: style
- reorder patches
remote-svn:
- review:
stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
contrib/svn-fe/remote-svn.c | 174 +++
1 file changed, 174 insertions(+)
create
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b/Documentation/git-remote-helpers.txt
index f5836e4
to the 'capablilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.c |4
to open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
contrib/svn-fe/remote-svn.c | 55 ---
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/contrib/svn-fe/remote-svn.c b/contrib
in the note. This can be refined on purpose, of course.
- Revision-number
- Node-path
- Node-kind
- Node-action
- Node-copyfrom-path
- Node-copyfrom-rev
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
vcs-svn/fast_export.c | 14 --
vcs-svn/fast_export.h |2 ++
vcs
.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
contrib/svn-fe/svnrdump_sim.py | 53
1 file changed, 53 insertions(+)
create mode 100755 contrib/svn-fe/svnrdump_sim.py
diff --git a/contrib/svn-fe/svnrdump_sim.py b/contrib/svn-fe
.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
contrib/svn-fe/remote-svn.c | 67 +--
contrib/svn-fe/svn-fe.c |3 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.c | 10 +--
vcs-svn/fast_export.h
to accumulate all Node data of a revision in memory
before processing it.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
vcs-svn/svndump.c | 207 +++--
vcs-svn/svndump.h |2 +
2 files changed, 124 insertions(+), 85 deletions
and change/add/delete files according to the node_ctx using the already
added blobs.
This can also be used to create commits if the node metadata does not
come from a svndump, but is stored in e.g. notes, for later branch
detection.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
On Friday 17 August 2012 21:16:59 Junio C Hamano wrote:
Comments from mentors and people interested in remote helpers?
I did minimum line wrapping, typofix and small compilation fixes
and queued these on 'pu'; I think I saw one commit whose message
I didn't quite get what it was trying to
On Sunday 19 August 2012 16:29:02 Ramsay Jones wrote:
In particular, gcc complains thus:
CC vcs-svn/fast_export.o
vcs-svn/fast_export.c: In function 'fast_export_begin_note':
vcs-svn/fast_export.c:77: warning: long long unsigned int format, \
different type arg (arg
On Saturday 18 August 2012 23:35:38 Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
[..]
Just to show how, here is what I did just now.
[..]
Thanks.
Thanks for you guidance!
I'll base a new version on your fixups.
Florian
--
To unsubscribe from this list: send the line
On Sunday 19 August 2012 23:57:23 Junio C Hamano wrote:
Florian Achleitner florian.achleitner.2.6...@gmail.com writes:
This change makes me uncomfortable.
We are doubling up on hashing with fast-import.
This introduces git-specific logic into vcs-svn.
IIUC, vcs-svn/fast-export is meant
On Saturday 18 August 2012 13:13:47 Junio C Hamano wrote:
That indicates that one necessary patch to add logic to Makefile to
go and build that subdirectory, at least before running the test,
but possibly as part of the all target, is missing, isn't it?
Or you can add, at the beginning of
On Monday 20 August 2012 09:45:30 Jonathan Nieder wrote:
Florian Achleitner wrote:
Currently, the mark number is equal to the svn revision number the commit
corresponds to. I didn't want to break that, but not mandatory. We could
also split the mark namespace by reserving one or more
On Monday 20 August 2012 22:56:35 Torsten Bögershausen wrote:
t9020 from pu doesn't work for me (neither linux nor Mac OS)
I haven't been able to find out more than this:
Initialized empty Git repository in /home/tb/projects/git/git.pu/t/trash
directory.t9020-remote-svn/.git/
expecting
New version with these changes:
- includes fixups and changes by Junio from fa/remote-svn
- move contrib/svn-fe/remote-svn.c to remote-testsvn.c (in toplevel)
- add it to the toplevel Makefile
(needed to copy the linker rule, is there a nicer way?)
- check for prerequisite in test script
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b
.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
contrib/svn-fe/svn-fe.c |3 ++-
remote-testsvn.c| 67 ---
test-svn-fe.c |2 +-
vcs-svn/fast_export.c
to the 'capabilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c
to
open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
remote-testsvn.c | 55 +++---
1 file changed, 36 insertions(+), 19 deletions
in the note. This can be refined as needed.
- Revision-number
- Node-path
- Node-kind
- Node-action
- Node-copyfrom-path
- Node-copyfrom-rev
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
vcs-svn/fast_export.c | 14
added blobs.
This can also be used to create commits if the node metadata does not
come from a svndump, but is stored in e.g. notes, for later branch
detection.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
vcs-svn/svndump.c
On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
I think you meant something like:
init_notes(NULL, notes_ref, NULL, 0);
marksfile = fopen(marksfilename, r);
if (!marksfile) {
On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
I think you meant something like:
init_notes(NULL, notes_ref, NULL, 0);
marksfile = fopen(marksfilename, r);
if (!marksfile) {
Another improved series with fixups by Junio, and a little by me.
Diff:
- fix inconsistend indent in Documentation/git-remote-helpers.txt
- remove trailing newline in Makefile
- fix argument list and usage of regenerate_marks(void) in remote-svn.c
[PATCH v6 01/16] Implement a remote helper for
on its stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
remote-testsvn.c | 174
to the 'capabilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c
to
open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
remote-testsvn.c | 55 +++---
1 file changed, 36 insertions(+), 19 deletions
in the note. This can be refined as needed.
- Revision-number
- Node-path
- Node-kind
- Node-action
- Node-copyfrom-path
- Node-copyfrom-rev
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
vcs-svn/fast_export.c | 14
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b
.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
contrib/svn-fe/svn-fe.c |3 ++-
remote-testsvn.c| 67 ---
test-svn-fe.c |2 +-
vcs-svn/fast_export.c
On Sunday 26 August 2012 21:32:58 Torsten Bögershausen wrote:
The reason is that contrib/svn-fe, where remote-svn is in, is not yet
built automatically by the toplevel makefile, so the remote helper can't
be found. If you build it manually it should work.
Working on it ..
Hi Florian,
Hi!
Thanks for your fixups. I'm currently integrating them in a new series.
On what platform did you find that problems?
Tried to reproduce them on 64bit Linux. Anyways the fixes look very reasonable.
Florian
On Thursday 23 August 2012 18:55:39 Ramsay Jones wrote:
Signed-off-by: Ramsay Jones
Reroll includes fixups by Ramsey. Thanks!
Diff:
- Add missing dependency to rule in Makefile.
- improve compatibility of integer types.
- t9020-*.sh: remove excess slash in urls that makes python on windows
interpret it as a network path.
- t9020-*.sh: skip if python isn't available.
- replace
on its stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
remote-testsvn.c | 174
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b
to
open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
remote-testsvn.c | 55 +++---
1 file changed, 36 insertions(+), 19 deletions
to the 'capabilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c
On Tuesday 28 August 2012 10:49:34 Florian Achleitner wrote:
Reroll includes fixups by Ramsey. Thanks!
Diff:
[..]
- improve compatibility of integer types.
[..]
This line is wrong in this series. Just delete it. Sorry.
--
To unsubscribe from this list: send the line unsubscribe git
added blobs.
This can also be used to create commits if the node metadata does not
come from a svndump, but is stored in e.g. notes, for later branch
detection.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
vcs-svn/svndump.c
on its stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
diff:
- style
- use seperate strbufs instead of sharing one in main
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
no diff
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
to the 'capabilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
diff:
- remove glitch in function declaration.
contrib/svn
in the note. This can be refined as needed.
- Revision-number
- Node-path
- Node-kind
- Node-action
- Node-copyfrom-path
- Node-copyfrom-rev
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
vcs-svn/fast_export.c | 14
.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
diff:
- style
- improve error detection while reading notes
- strtol instead of atol
- seperate strbufs in main
contrib/svn-fe/svn-fe.c |3 +-
remote-testsvn.c
Sorry for reacting so late, I didn't read the list carefully in the last weeks
and my gmail filter somehow didn't trigger on that.
On Tuesday 02 October 2012 16:20:22 Junio C Hamano wrote:
* fa/remote-svn (2012-09-19) 16 commits
- Add a test script for remote-svn
- remote-svn: add
On Friday 14 December 2012 17:11:44 Jeff King wrote:
[...]
We can fix it by returning -1 when no note is found (so on
a zero return, we always found a valid value).
Good fix. Parsing of the note now always fails if the note doesn't contain the
expected string, as it should.
[corrected David Barr's address]
On Monday 18 February 2013 12:42:39 Jeff King wrote:
And I do not want to blame the students here (some of whom are on the cc
list ). They are certainly under no obligation to stick around after
GSoC ends, and I know they have many demands on their time. But I
that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
contrib/svn-fe/remote-svn.c | 53 +--
1 file changed, 36 insertions(+), 17 deletions(-)
diff --git a/contrib/svn-fe/remote-svn.c b/contrib/svn
fast-import prints statistics that could be interesting to the
developer of remote helpers.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
transport-helper.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/transport-helper.c b/transport-helper.c
Hi!
This series adds creating notes to vcs-svn, plus some testing aids.
I picked one patch from Dmitry's existing work.
Next steps are storing the fetched revisions and notes in the right place
in refs/remote/ and adding incremental import using the notes.
Im currently stuck on some unexpected
redundant. But probably only in this special
case.(?)
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
transport-helper.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/transport-helper.c b/transport-helper.c
index d6daad5..a0f05ce 100644
On Sunday 15 July 2012 19:30:25 Jonathan Nieder wrote:
Hi Florian,
Florian Achleitner wrote:
After importing new commits on top of refs/remotes/* the
ref was overwritten with the local refs/heads/master, because the name
of the remote reference to fetch, i.e. refs/heads/master, was used
On Tuesday 17 July 2012 08:48:20 Jonathan Nieder wrote:
Florian Achleitner wrote:
On Monday 16 July 2012 22:27:25 Jonathan Nieder wrote:
Hm, that still doesn't look right. The RHS of the refspec is supposed to
be a _private_ namespace for the remote helper, and refs/remotes
blocking open calls on both ends.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
diff: Opening the pipe with O_RDWR prevents blocking open calls on both ends.
fast-import.c | 15
transport-helper.c | 64
On Saturday 21 July 2012 09:48:34 Jonathan Nieder wrote:
To sum up: I think we should just stick to pipes --- why all this fifo
complication?
People didn't like pipe variant (prexec_cb not being compatible to windows'
process creation model), so I learned about fifos and implemented a (basic)
Hi!
Refering to Jonathan's concerns in Saturday night's IRC log:
[22:59:34] jrnieder barrbrain, flyingflo: I'm worried about the remote
helper project
[23:00:05] jrnieder someone needs to review remote-svn.c to catch things
like that refspec issue which should be straightforward to an
To ease testing without depending on a reachable svn server, this
compact python script mimics parts of svnrdumps behaviour.
It requires the remote url to start with sim://.
Start and end revisions are evaluated.
If the requested revision doesn't exist, as it is the case with
incremental imports,
On Monday 23 July 2012 07:59:21 Jonathan Nieder wrote:
Florian Achleitner wrote:
To ease testing without depending on a reachable svn server, this
compact python script mimics parts of svnrdumps behaviour.
Thanks. Mind if I forge your sign-off?
Ups. No problem, anyways I've added
.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
I had to fix the missing sign-off anyways..
contrib/svn-fe/svnrdump_sim.py | 53
1 file changed, 53 insertions(+)
create mode 100755 contrib/svn-fe/svnrdump_sim.py
diff --git
On Monday 23 July 2012 18:24:40 Matthieu Moy wrote:
You also have whitespace damages (i.e. line wrapping introduced by your
mailer). Using git-send-email avoids this kind of problem (there are
also some advices for some mailers in Documentation/SubmittingPatches).
Damn. That's usually no
the same dump file for simulating multiple
incremental imports the highest visible revision can be limited by
setting the environment variable SVNRMAX to that value. This
effectively limits HEAD to simulate the situation where higher
revs don't exist yet.
Signed-off-by: Florian Achleitner
On Tuesday 24 July 2012 14:50:49 Jonathan Nieder wrote:
It is unclear how this is different from giving the ceiling by
specifying it as the END in -rSTART:END command line. Is this
feature really needed?
I think the idea is that you put this script (or a symlink to it) on
your $PATH
On Thursday 26 July 2012 02:46:07 Jonathan Nieder wrote:
Hi,
Florian Achleitner wrote:
--- /dev/null
+++ b/contrib/svn-fe/remote-svn.c
@@ -0,0 +1,219 @@
+
+#include cache.h
+#include remote.h
+#include strbuf.h
+#include url.h
+#include exec_cmd.h
+#include run-command.h
Hi!
Most of this review went into the new version..
For the remaining points, some comments follow.
On Monday 02 July 2012 06:07:41 Jonathan Nieder wrote:
Hi,
Florian Achleitner wrote:
--- /dev/null
+++ b/contrib/svn-fe/remote-svn.c
@@ -0,0 +1,207 @@
+
+#include stdlib.h
On Thursday 26 July 2012 03:14:43 Jonathan Nieder wrote:
Florian Achleitner wrote:
Yes, I incorporated your review in the new version, as far as applicable.
But I didn't send you an answer on the detailed points.
I will send an answer to the previous review ..
Thanks. Now that I check
On Thursday 26 July 2012 04:08:42 Jonathan Nieder wrote:
Florian Achleitner wrote:
On Monday 02 July 2012 06:07:41 Jonathan Nieder wrote:
[...]
+
+static inline void printd(const char* fmt, ...)
[...]
Why not use trace_printf and avoid the complication?
Hm.. I tried
On Thursday 26 July 2012 09:54:26 Jonathan Nieder wrote:
Since the svn remote helper relies on this, it seems worth working on,
yeah. As for how to spend your time (and whether to beg someone else
to work on it instead :)): I'm not sure what's on your plate or where
you are with respect to
On Saturday 28 July 2012 02:00:31 Jonathan Nieder wrote:
Thanks for explaining. Now we've discussed a few different approproaches,
none of which is perfect.
a. use --cat-blob-fd, no FIFO
Doing this unconditionally would break platforms that don't support
--cat-blob-fd=(descriptor
On Thursday 26 July 2012 10:29:51 Junio C Hamano wrote:
Of course, if the dispatch loop has to be rewritten so that a
central dispatcher decides what to call, individual input handlers
do not need to say NOT_HANDLED nor TERMINATE, as the central
dispatcher should keep track of the overall
On Monday 30 July 2012 03:29:52 Jonathan Nieder wrote:
Generally I like your prefered solution.
I think there's one problem:
The pipe needs to be created before the fork, so that the fd can be
inherited.
The relevant pipe already exists at that point: the remote helper's
stdin.
In
transport-helpers can advertise the 'refspec' capability,
if not a default refspec *:* is assumed. This explains
the post-processing of refs after fetching with fast-import.
Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com
---
transport-helper.c | 15 +++
1
On Monday 30 July 2012 14:15:53 Jonathan Nieder wrote:
Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
+ /*
+ * If the remote helper advertised the refspec capability,
+ * it will have the written result of the import to the refs
perhaps s/will have the written
On Monday 30 July 2012 09:28:27 Junio C Hamano wrote:
Florian Achleitner florian.achleitner.2.6...@gmail.com writes:
Enables basic fetching from subversion repositories. When processing
Remote URLs starting with svn::, git invokes this remote-helper.
It starts svnrdump to extract revisions
On Monday 30 July 2012 11:55:02 Jonathan Nieder wrote:
Florian Achleitner wrote:
Hm .. that would mean, that both fast-import and git (transport-helper)
would write to the remote-helper's stdin, right?
Yes, first git writes the list of refs to import, and then fast-import
writes feedback
On Tuesday 31 July 2012 15:43:57 Jonathan Nieder wrote:
Florian Achleitner wrote:
I haven't tried that yet, nor do I remember anything where I've already
seen two processes writing to the same pipe.
It's a perfectly normal and well supported thing to do.
I played around with a little
On Saturday 04 August 2012 23:53:58 Ramkumar Ramachandra wrote:
Hi,
Florian Achleitner wrote:
1. Import linearly and split later:
I think this approach will be a lot less messy if you can cleanly
separate the fetching component from the mapper. Currently, svndump
re-creates the layout
96 matches
Mail list logo
