[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with

[GitHub] [activemq-artemis] franz1981 commented on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 commented on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with very

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279259143 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279259143 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279259143 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476844 Just one example of classes that really really should be their own class is the codec algo

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279274791 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279275072 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476844 Just one example of classes that should be their own class is the algo implementations.

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476844 Just one example of classes that should be their own class is the codec algo implementations.

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2652: ARTEMIS-2320 Assorted small code fixes, mostly from IntelliJ autofixes

michaelandrepearce commented on a change in pull request #2652: ARTEMIS-2320 Assorted small code fixes, mostly from IntelliJ autofixes URL: https://github.com/apache/activemq-artemis/pull/2652#discussion_r279255818 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2650: ARTEMIS-2320 Multiple math-related fixes

michaelandrepearce commented on a change in pull request #2650: ARTEMIS-2320 Multiple math-related fixes URL: https://github.com/apache/activemq-artemis/pull/2650#discussion_r279261011 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279270065 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279272224 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279272224 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279267813 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279271513 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279272810 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279271513 ## File path:

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279269319 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279269319 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279272810 ## File path:

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] asfgit closed pull request #2652: ARTEMIS-2320 Assorted small code fixes, mostly from IntelliJ autofixes

asfgit closed pull request #2652: ARTEMIS-2320 Assorted small code fixes, mostly from IntelliJ autofixes URL: https://github.com/apache/activemq-artemis/pull/2652 This is an automated message from the Apache Git Service.

[GitHub] [activemq-artemis] asfgit closed pull request #2650: ARTEMIS-2320 Multiple math-related fixes

asfgit closed pull request #2650: ARTEMIS-2320 Multiple math-related fixes URL: https://github.com/apache/activemq-artemis/pull/2650 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279241585 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279241585 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279241585 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279268584 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279270065 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on issue #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#issuecomment-487530046 LGTM This is an automated message from the

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce edited a comment on issue #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#issuecomment-487530046 My comment was addresses/discussed, i have no further comments.

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476310 I agree about tone. And thats why i did not say MUST , and instead used SHOULD which means ideally but if not

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279275456 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279275496 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279275456 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2652: ARTEMIS-2320 Assorted small code fixes, mostly from IntelliJ autofixes

michaelandrepearce commented on a change in pull request #2652: ARTEMIS-2320 Assorted small code fixes, mostly from IntelliJ autofixes URL: https://github.com/apache/activemq-artemis/pull/2652#discussion_r279256136 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on issue #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#issuecomment-487478601 Added comment inline This is an automated

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279261506 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279261506 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279267813 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279267813 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279271513 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279275072 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279241585 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496 So then i suggest leave the warning and dont add statics to just make it silent, warnings are there to

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496 So then i suggest leave the warning, warnings are there to suggest reviewing and refactoring code, its

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496 So then i suggest leave the warning and dont add statics to just make it silent, warnings are there to

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496 So then i suggest leave the warning and dont add statics to just make it silent, warnings are there to

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496 So then i suggest leave the warning, warnings are there to suggest reviewing and refactoring code, its not

[GitHub] [activemq-artemis] jdanekrh commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

jdanekrh commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487593830 I'm not going to pull out any static nested classes into their own files. If this should get done, somebody more

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

clebertsuconic commented on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487599466 >   Msg size 4k Msg size 12kMsg size 50k > Without patch 15.0k 7.0k1.7k

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2639: ARTEMIS-2318 HornetQ Protocol Manager should copy the messages before…

franz1981 commented on a change in pull request #2639: ARTEMIS-2318 HornetQ Protocol Manager should copy the messages before… URL: https://github.com/apache/activemq-artemis/pull/2639#discussion_r279353144 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496 So then i suggest leave the warning and dont add statics to just make it silent, warnings are there to

[GitHub] [activemq-artemis] jbertram opened a new pull request #2653: ARTEMIS-2326 remove pwd params before creating protocol mgr

jbertram opened a new pull request #2653: ARTEMIS-2326 remove pwd params before creating protocol mgr URL: https://github.com/apache/activemq-artemis/pull/2653 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] jdanekrh commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

jdanekrh commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487690177 The purpose of the warning isn't really to point out style issues about class hierarchy, but a potential (tiny)

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2579: ARTEMIS-2273 Adding Audit Log

michaelandrepearce edited a comment on issue #2579: ARTEMIS-2273 Adding Audit Log URL: https://github.com/apache/activemq-artemis/pull/2579#issuecomment-487637644 @clebertsuconic @gaohoward since this change, i can still build from command line, but its causing a massive issue within my

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2579: ARTEMIS-2273 Adding Audit Log

michaelandrepearce commented on issue #2579: ARTEMIS-2273 Adding Audit Log URL: https://github.com/apache/activemq-artemis/pull/2579#issuecomment-487640396 fyi, i think its something to do with javadoc plugin causing it, other modules that declare logging have a profile for javadoc that

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487705548 As it stands, this pr which is a refactor needs a few iterations imo. Not everything should be inner classes.

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

wy96f commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279613543 ## File path:

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] asfgit closed pull request #2653: ARTEMIS-2326 remove pwd params before creating protocol mgr

asfgit closed pull request #2653: ARTEMIS-2326 remove pwd params before creating protocol mgr URL: https://github.com/apache/activemq-artemis/pull/2653 This is an automated message from the Apache Git Service. To respond to

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

michaelandrepearce edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487825286 I agree. It looks like perf is on par to me. That said performance never should be at the

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

michaelandrepearce commented on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487825286 I agree. It looks like perf is on par to me. That said performance never should be at the cost of

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

wy96f commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279589564 ## File path:

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487509450 @clebertsuconic @wy96f @qihongxu I'm aware that this patch introduce a (small) perf regression

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279617994 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279617994 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279617994 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279620489 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279620489 ## File path: