Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on code in PR #46566: URL: https://github.com/apache/arrow/pull/46566#discussion_r2115262361 ## python/pyarrow/tests/test_acero.py: ## @@ -300,6 +300,86 @@ def test_order_by(): _ = OrderByNodeOptions([("b", "ascending")], null_placement="start")

Re: [PR] GH-46080 [Python][Docs] Provide guidance for tzdata related issues if installing with pip [arrow]

2025-05-29 Thread via GitHub
AlenkaF commented on code in PR #46591: URL: https://github.com/apache/arrow/pull/46591#discussion_r2115254860 ## docs/source/python/install.rst: ## @@ -98,6 +98,21 @@ a custom path to the database from Python: >>> import pyarrow as pa >>> pa.set_timezone_db_path("custom

Re: [PR] GH-46080 [Python][Docs] Provide guidance for tzdata related issues if installing with pip [arrow]

2025-05-29 Thread via GitHub
AlenkaF commented on code in PR #46591: URL: https://github.com/apache/arrow/pull/46591#discussion_r2115254037 ## docs/source/python/install.rst: ## @@ -98,6 +98,21 @@ a custom path to the database from Python: >>> import pyarrow as pa >>> pa.set_timezone_db_path("custom

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
xingyu-long commented on PR #46566: URL: https://github.com/apache/arrow/pull/46566#issuecomment-2921391424 > If you want to write a similar test case, let's just workaround the constraint and use unique column names. Thanks for confirming it! The tests I added for test `always true`

Re: [PR] Foundation of API for reading Variant data and metadata [arrow-rs]

2025-05-29 Thread via GitHub
mkarbo commented on code in PR #7535: URL: https://github.com/apache/arrow-rs/pull/7535#discussion_r2115246754 ## parquet-variant/src/variant.rs: ## @@ -0,0 +1,714 @@ +use crate::decoder::{ +self, get_basic_type, get_primitive_type, VariantBasicType, VariantPrimitiveType, +

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on PR #46566: URL: https://github.com/apache/arrow/pull/46566#issuecomment-2921384026 > I see, so if I understand this correctly, ideally, we probably should assign distinct key for both columns before using filter expression since output_suffix_for_left would only wor

Re: [PR] MINOR: [C++] Fix OTel 1.19 compat after silent breaking change [arrow]

2025-05-29 Thread via GitHub
lidavidm commented on code in PR #45859: URL: https://github.com/apache/arrow/pull/45859#discussion_r2115239145 ## cpp/src/arrow/util/tracing_internal.cc: ## @@ -97,6 +97,10 @@ class OtlpOStreamExporter final : public sdktrace::SpanExporter { std::chrono::m

Re: [PR] GH-46508: [C++] Upgrade OpenTelemetry cpp to avoid build error on recent Clang [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on code in PR #46509: URL: https://github.com/apache/arrow/pull/46509#discussion_r2115238105 ## cpp/cmake_modules/ThirdpartyToolchain.cmake: ## @@ -4845,6 +4845,14 @@ macro(build_opentelemetry) version) set(OPENTELEMETRY_BUILD_BYPRODUCTS) set(O

Re: [PR] MINOR: [C++] Fix OTel 1.19 compat after silent breaking change [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on code in PR #45859: URL: https://github.com/apache/arrow/pull/45859#discussion_r2115236457 ## cpp/src/arrow/util/tracing_internal.cc: ## @@ -97,6 +97,10 @@ class OtlpOStreamExporter final : public sdktrace::SpanExporter { std::chrono

Re: [PR] GH-46508: [C++] Upgrade OpenTelemetry cpp to avoid build error on recent Clang [arrow]

2025-05-29 Thread via GitHub
lidavidm commented on code in PR #46509: URL: https://github.com/apache/arrow/pull/46509#discussion_r2115229961 ## cpp/cmake_modules/ThirdpartyToolchain.cmake: ## @@ -4845,6 +4845,14 @@ macro(build_opentelemetry) version) set(OPENTELEMETRY_BUILD_BYPRODUCTS) set(OPEN

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-05-29 Thread via GitHub
lidavidm commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2115226610 ## go/adbc/driver/internal/driverbase/connection.go: ## @@ -183,28 +188,34 @@ func (base *ConnectionImplBase) GetInfo(ctx context.Context, infoCodes []adbc.In

Re: [PR] GH-46633: [Docs][C++][Python] Update CombineChunks documentation to specify that binary columns can be combined into multiple chunks [arrow]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #46638: URL: https://github.com/apache/arrow/pull/46638#issuecomment-2921347261 Revision: 2189cd0868d98f89fb4933bd26e6ee1d149b0c2f Submitted crossbow builds: [ursacomputing/crossbow @ actions-a59b384503](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
xingyu-long commented on PR #46566: URL: https://github.com/apache/arrow/pull/46566#issuecomment-2921331804 > This is an independent problem. Because join is concatenating columns from both sides, so it is possible that the result table contains columns with the same name. If so, you won't

Re: [PR] GH-46633: [Docs][C++][Python] Update CombineChunks documentation to specify that binary columns can be combined into multiple chunks [arrow]

2025-05-29 Thread via GitHub
AlenkaF commented on PR #46638: URL: https://github.com/apache/arrow/pull/46638#issuecomment-2921343549 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] fix(c): Generate versioned DLLs and import LIBs when building with MSVC [arrow-adbc]

2025-05-29 Thread via GitHub
lidavidm commented on PR #2858: URL: https://github.com/apache/arrow-adbc/pull/2858#issuecomment-2921343385 Oh wait - is the `dll.a` sufficient? (That's being installed.) Does the `.def` file need to be installed? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] fix(c): Generate versioned DLLs and import LIBs when building with MSVC [arrow-adbc]

2025-05-29 Thread via GitHub
lidavidm commented on PR #2858: URL: https://github.com/apache/arrow-adbc/pull/2858#issuecomment-2921341518 Also I see `gendef` being invoked, but it's not installed by CMake - that probably also needs to be tweaked -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] GH-25025: [C++] Move non core compute kernels into separate shared library [arrow]

2025-05-29 Thread via GitHub
raulcd commented on code in PR #46261: URL: https://github.com/apache/arrow/pull/46261#discussion_r2115208708 ## c_glib/arrow-glib/compute.cpp: ## @@ -37,6 +37,9 @@ #include #include +// Initialize the compute library and register compute kernels. +auto compute_init_status

Re: [PR] GH-46080 [Python][Docs] Provide guidance for tzdata related issues if installing with pip [arrow]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #46591: URL: https://github.com/apache/arrow/pull/46591#issuecomment-2921327651 Revision: 4ac6fc38b63c395fc468ee6ddf81239f4084ab08 Submitted crossbow builds: [ursacomputing/crossbow @ actions-07de9c2772](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-46080 [Python][Docs] Provide guidance for tzdata related issues if installing with pip [arrow]

2025-05-29 Thread via GitHub
AlenkaF commented on PR #46591: URL: https://github.com/apache/arrow/pull/46591#issuecomment-2921324450 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
xingyu-long commented on code in PR #46566: URL: https://github.com/apache/arrow/pull/46566#discussion_r2115200396 ## python/pyarrow/tests/test_acero.py: ## @@ -300,6 +300,37 @@ def test_order_by(): _ = OrderByNodeOptions([("b", "ascending")], null_placement="start")

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
xingyu-long commented on code in PR #46566: URL: https://github.com/apache/arrow/pull/46566#discussion_r211516 ## python/pyarrow/_acero.pyx: ## @@ -273,14 +273,15 @@ cdef class _HashJoinNodeOptions(ExecNodeOptions): def _set_options( self, join_type, left_key

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
xingyu-long commented on code in PR #46566: URL: https://github.com/apache/arrow/pull/46566#discussion_r2115199593 ## python/pyarrow/acero.py: ## @@ -114,6 +114,8 @@ def _perform_join(join_type, left_operand, left_keys, in the join result. output_type: Table or InM

Re: [PR] fix(c): Generate versioned DLLs and import LIBs when building with MSVC [arrow-adbc]

2025-05-29 Thread via GitHub
lidavidm commented on PR #2858: URL: https://github.com/apache/arrow-adbc/pull/2858#issuecomment-2921296093 It looks like tests might not fully build: ``` C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: validation/Debug/libadbc_valida

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-05-29 Thread via GitHub
birschick-bq commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2115146439 ## go/adbc/utils/utils.go: ## @@ -73,3 +81,50 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field { Metadata: arrow.Metadata{},

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on code in PR #46566: URL: https://github.com/apache/arrow/pull/46566#discussion_r2115110646 ## python/pyarrow/_acero.pyx: ## @@ -273,14 +273,15 @@ cdef class _HashJoinNodeOptions(ExecNodeOptions): def _set_options( self, join_type, left_key

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on code in PR #46566: URL: https://github.com/apache/arrow/pull/46566#discussion_r2115109420 ## python/pyarrow/acero.py: ## @@ -114,6 +114,8 @@ def _perform_join(join_type, left_operand, left_keys, in the join result. output_type: Table or InM

Re: [I] [R] update docgen script to include arrow::one [arrow]

2025-05-29 Thread via GitHub
thisisnic commented on issue #46632: URL: https://github.com/apache/arrow/issues/46632#issuecomment-2921184363 > I might just cherry-pick that change into a minor PR on main @amoeba - sounds perfect and much simpler than messing around with the docgen script; thanks! -- This is an

Re: [PR] GH-46642: [Format] Add footnote clarifying REE layout has O(log n) random access [arrow]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #46643: URL: https://github.com/apache/arrow/pull/46643#issuecomment-2921163177 Revision: ed91acebc7e30a3c69116ef3638b1f56fd6ecc93 Submitted crossbow builds: [ursacomputing/crossbow @ actions-39b42b1501](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-46642: [Format] Add footnote clarifying REE layout has O(log n) random access [arrow]

2025-05-29 Thread via GitHub
kou commented on PR #46643: URL: https://github.com/apache/arrow/pull/46643#issuecomment-2921160903 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] GH-46642: [Format] Add footnote clarifying REE layout has O(log n) random access [arrow]

2025-05-29 Thread via GitHub
amoeba commented on PR #46643: URL: https://github.com/apache/arrow/pull/46643#issuecomment-2921108377 For reviewers: I tried to keep it short though I think there are other ways we might address this such as changing the bullet to something like "Generally O(1) (constant-time) random acces

[PR] GH-46642: [Format] Add footnote [arrow]

2025-05-29 Thread via GitHub
amoeba opened a new pull request, #46643: URL: https://github.com/apache/arrow/pull/46643 ### Rationale for this change Resolves https://github.com/apache/arrow/issues/46642. ### What changes are included in this PR? - Updated columnar format doc ### Are these chan

Re: [PR] GH-46546: [CI][Dev][Python] Use pre-commit for numpydoc [arrow]

2025-05-29 Thread via GitHub
kou commented on PR #46595: URL: https://github.com/apache/arrow/pull/46595#issuecomment-2921087484 OK. I've opened #46641 for it. I'll merge this if nobody objects it. Because we can remove Archery based lint from our lint CI job by merging this. It will solve https://github.com/apa

Re: [PR] GH-46593: [CI][Integration] Disable nested log grouping [arrow]

2025-05-29 Thread via GitHub
kou commented on PR #46594: URL: https://github.com/apache/arrow/pull/46594#issuecomment-2921075354 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [I] [CI][Integration] Integration test logs may not hide details by group [arrow]

2025-05-29 Thread via GitHub
kou commented on issue #46593: URL: https://github.com/apache/arrow/issues/46593#issuecomment-2921076253 Issue resolved by pull request 46594 https://github.com/apache/arrow/pull/46594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] [CI][Crossbow][C++] Use apache/arrow for Meson [arrow]

2025-05-29 Thread via GitHub
kou commented on issue #46499: URL: https://github.com/apache/arrow/issues/46499#issuecomment-2921077865 Issue resolved by pull request 46501 https://github.com/apache/arrow/pull/46501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-46499: [CI][Crossbow][C++] Use apache/arrow for Meson [arrow]

2025-05-29 Thread via GitHub
kou merged PR #46501: URL: https://github.com/apache/arrow/pull/46501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-46499: [CI][Crossbow][C++] Use apache/arrow for Meson [arrow]

2025-05-29 Thread via GitHub
kou commented on PR #46501: URL: https://github.com/apache/arrow/pull/46501#issuecomment-2921077340 No objection. I'll merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] GH-46593: [CI][Integration] Disable nested log grouping [arrow]

2025-05-29 Thread via GitHub
kou merged PR #46594: URL: https://github.com/apache/arrow/pull/46594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] [Java] Create a utility function for validity buffer based split and transfer usage in Vector module [arrow-java]

2025-05-29 Thread via GitHub
rtadepalli commented on issue #79: URL: https://github.com/apache/arrow-java/issues/79#issuecomment-2921051019 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] GH-79: Move `splitAndTransferValidityBuffer` to `BaseValueVector` [arrow-java]

2025-05-29 Thread via GitHub
rtadepalli commented on code in PR #777: URL: https://github.com/apache/arrow-java/pull/777#discussion_r2115033521 ## vector/src/main/java/org/apache/arrow/vector/BaseValueVector.java: ## @@ -248,4 +252,114 @@ public void copyFrom(int fromIndex, int thisIndex, ValueVector from)

Re: [PR] GH-79: Move `splitAndTransferValidityBuffer` to `BaseValueVector` [arrow-java]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #777: URL: https://github.com/apache/arrow-java/pull/777#issuecomment-2921054081 Thank you for opening a pull request! Please label the PR with one or more of: - bug-fix - chore - dependencies - documentation - enhancement

[PR] GH-79: Move `splitAndTransferValidityBuffer` to `BaseValueVector` [arrow-java]

2025-05-29 Thread via GitHub
rtadepalli opened a new pull request, #777: URL: https://github.com/apache/arrow-java/pull/777 ## What's Changed Move `splitAndTransferValidityBuffer` up to `BaseValueVector`. This PR is not touching the implementation of this function in `StructVector` -- that is not being derived

Re: [I] [C++][FlightSQL][ODBC] Build error with deprecated C++-17 feature [arrow]

2025-05-29 Thread via GitHub
kou commented on issue #46576: URL: https://github.com/apache/arrow/issues/46576#issuecomment-2920996193 Issue resolved by pull request 46622 https://github.com/apache/arrow/pull/46622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-05-29 Thread via GitHub
lidavidm commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2114999729 ## go/adbc/utils/utils.go: ## @@ -73,3 +81,50 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field { Metadata: arrow.Metadata{}, } }

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-05-29 Thread via GitHub
lidavidm commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2115001195 ## go/adbc/utils/utils.go: ## @@ -73,3 +81,50 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field { Metadata: arrow.Metadata{}, } }

Re: [I] [R] CRAN packaging checklist for version 20.0.0 [arrow]

2025-05-29 Thread via GitHub
amoeba commented on issue #46324: URL: https://github.com/apache/arrow/issues/46324#issuecomment-2920996722 Post-release tasks were done as part of https://github.com/apache/arrow/issues/46453. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] GH-46576: [C++] Suppress `codecvt_utf8` deprecation warning [arrow]

2025-05-29 Thread via GitHub
kou merged PR #46622: URL: https://github.com/apache/arrow/pull/46622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] [R] update docgen script to include arrow::one [arrow]

2025-05-29 Thread via GitHub
amoeba commented on issue #46632: URL: https://github.com/apache/arrow/issues/46632#issuecomment-2920992331 I am just getting around to post-release stuff and was going to look at this. On the maint branch, I fixed this by just manually documenting it, see https://github.com/apache/arrow/co

Re: [PR] GH-45723: [C++] FixedSizeListBuilder should have UnsafeAppend methods [arrow]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #46126: URL: https://github.com/apache/arrow/pull/46126#issuecomment-2920984163 :warning: GitHub issue #45723 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] MINOR: [R][Release] Backport news changes from maint-20.0.0.1-r [arrow]

2025-05-29 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46639: URL: https://github.com/apache/arrow/pull/46639#issuecomment-2920968215 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1d43680f56857b99805a2745a8bae40a48cf3f3d. There were no

Re: [I] [C++] FixedSizeListBuilder should have UnsafeAppend methods [arrow]

2025-05-29 Thread via GitHub
kou commented on issue #45723: URL: https://github.com/apache/arrow/issues/45723#issuecomment-2920976412 https://github.com/apache/arrow/pull/46126 ? Could you follow auto-generated comment https://github.com/apache/arrow/pull/46126#issuecomment-275164 to fix PR style? -- This is

Re: [I] "error decoding response body: request or response body error: operation timed out" even when response stream is making progress [arrow-rs-object-store]

2025-05-29 Thread via GitHub
arogozhnikov commented on issue #386: URL: https://github.com/apache/arrow-rs-object-store/issues/386#issuecomment-2920969577 > šŸ¤” so maybe cranking up the timeout is an adequate workaround for most users may I give a counter-example? I'm currently exploring different options for auto

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
xingyu-long commented on PR #46566: URL: https://github.com/apache/arrow/pull/46566#issuecomment-2920972318 > * inner join will kee Thanks @zanmato1984 for your explanation, it makes sense. probably I should mention more details in function docstring for this usage then. at same time,

[PR] MINOR: [R][Docs] Fix package title text not showing [arrow]

2025-05-29 Thread via GitHub
amoeba opened a new pull request, #46640: URL: https://github.com/apache/arrow/pull/46640 ### Rationale for this change On the current docs, the title of the package doesn't show up. It would be good if it did. I tried various sanctioned things but none worked. I am chalking it up as

Re: [PR] MINOR: [R][Docs] Fix package title text not showing [arrow]

2025-05-29 Thread via GitHub
amoeba commented on PR #46640: URL: https://github.com/apache/arrow/pull/46640#issuecomment-2920964401 With this change, when I rebuild the site with `pkgdown::build_home_index(); pkgdown::init_site()`, I see, ![image](https://github.com/user-attachments/assets/88362ed7-8d05-481e-982

[PR] Jason/databricks metadata [arrow-adbc]

2025-05-29 Thread via GitHub
jasonlin45 opened a new pull request, #2895: URL: https://github.com/apache/arrow-adbc/pull/2895 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Jason/databricks metadata [arrow-adbc]

2025-05-29 Thread via GitHub
jasonlin45 closed pull request #2895: Jason/databricks metadata URL: https://github.com/apache/arrow-adbc/pull/2895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-05-29 Thread via GitHub
birschick-bq commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2114943387 ## go/adbc/utils/utils.go: ## @@ -73,3 +81,50 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field { Metadata: arrow.Metadata{},

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-05-29 Thread via GitHub
birschick-bq commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2114943874 ## go/adbc/utils/utils.go: ## @@ -73,3 +81,50 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field { Metadata: arrow.Metadata{},

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-05-29 Thread via GitHub
birschick-bq commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2114942734 ## go/adbc/utils/utils.go: ## @@ -73,3 +81,50 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field { Metadata: arrow.Metadata{},

Re: [I] The real exception was swallowed by another exception in CompositeJdbcConsumer::consume [arrow-java]

2025-05-29 Thread via GitHub
Odin-BN commented on issue #734: URL: https://github.com/apache/arrow-java/issues/734#issuecomment-2920853773 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] The real exception was swallowed by another exception in CompositeJdbcConsumer::consume [arrow-java]

2025-05-29 Thread via GitHub
Odin-BN commented on issue #734: URL: https://github.com/apache/arrow-java/issues/734#issuecomment-2920854377 @lidavidm thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] GH-46576: [C++] Suppress `codecvt_utf8` deprecation warning [arrow]

2025-05-29 Thread via GitHub
alinaliBQ commented on PR #46622: URL: https://github.com/apache/arrow/pull/46622#issuecomment-2920834273 @kou Thanks, I have added the change in `resolve_option_dependencies` to disable ODBC build on non-windows platforms. I believe the workflows currently do not build the Flight SQL ODBC

Re: [I] The real exception was swallowed by another exception in CompositeJdbcConsumer::consume [arrow-java]

2025-05-29 Thread via GitHub
lidavidm commented on issue #734: URL: https://github.com/apache/arrow-java/issues/734#issuecomment-2920826092 @Odin-BN you can comment 'take' and a bot will assign it to you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] GH-46508: [C++] Upgrade OpenTelemetry cpp to avoid build error on recent Clang [arrow]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #46509: URL: https://github.com/apache/arrow/pull/46509#issuecomment-2920706266 Revision: aea53b008de9812eb75d76fca207e6de8f865be8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-0c4049b1ff](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-46508: [C++] Upgrade OpenTelemetry cpp to avoid build error on recent Clang [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on PR #46509: URL: https://github.com/apache/arrow/pull/46509#issuecomment-2920703003 @github-actions crossbow submit test-ubuntu-24.04-cpp-thread-sanitizer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Add support for GEOMETRY and GEOGRAPHY types in Parquet read and/or write [arrow-rs]

2025-05-29 Thread via GitHub
paleolimbot commented on issue #7240: URL: https://github.com/apache/arrow-rs/issues/7240#issuecomment-2920701998 Yes, apologies for being slow here (just a few things on the go!). Also happy to review if anybody beats me to it! -- This is an automated message from the Apache Git Service.

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on PR #46566: URL: https://github.com/apache/arrow/pull/46566#issuecomment-2920698129 If my above comment addresses your concern, I'll in turn review the code. Thank you @xingyu-long . -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): add OpenTelemetry compatible tracing support [arrow-adbc]

2025-05-29 Thread via GitHub
birschick-bq closed pull request #2559: feat(csharp/src/Apache.Arrow.Adbc): add OpenTelemetry compatible tracing support URL: https://github.com/apache/arrow-adbc/pull/2559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] GH-46572: [Python] expose filter option to python for join [arrow]

2025-05-29 Thread via GitHub
zanmato1984 commented on PR #46566: URL: https://github.com/apache/arrow/pull/46566#issuecomment-2920686680 Thank you @xingyu-long for contributing this! I'd first address your concern of: > it seems we didn't return empty, instead, we return the `right outer`? it seems the join ty

Re: [PR] MINOR: [R][Release] Backport news changes from maint-20.0.0.1-r [arrow]

2025-05-29 Thread via GitHub
amoeba merged PR #46639: URL: https://github.com/apache/arrow/pull/46639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

[PR] fix get cross reference in getcolumnsExtended [arrow-adbc]

2025-05-29 Thread via GitHub
eric-wang-1990 opened a new pull request, #2894: URL: https://github.com/apache/arrow-adbc/pull/2894 ## PR Description ### Description This PR fixes an issue with foreign key handling in the `GetColumnsExtended` method by refactoring the cross-reference lookup process. It extracts

Re: [I] Add native support to write out `UnionArray` in JSON writer [arrow-rs]

2025-05-29 Thread via GitHub
kumarlokesh commented on issue #7302: URL: https://github.com/apache/arrow-rs/issues/7302#issuecomment-2920541775 @alamb made an attempt to address this requirement here: https://github.com/apache/arrow-rs/pull/7566. Please have a look. -- This is an automated message from the Apache Git

Re: [I] [R] CRAN packaging checklist for version 20.0.0 [arrow]

2025-05-29 Thread via GitHub
amoeba commented on issue #46324: URL: https://github.com/apache/arrow/issues/46324#issuecomment-2920540474 News backport PR is https://github.com/apache/arrow/pull/46639. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] MINOR: [R] Backport news changes from maint-20.0.0.1-r [arrow]

2025-05-29 Thread via GitHub
amoeba opened a new pull request, #46639: URL: https://github.com/apache/arrow/pull/46639 ### Rationale for this change I edited NEWS.md for the 20.0.0.X release and we need to backport those changes. ### What changes are included in this PR? I cherry-picked: - 73

Re: [PR] Fix `OffsetArray` support and clean `CategoricalArray` support [arrow-julia]

2025-05-29 Thread via GitHub
codecov-commenter commented on PR #556: URL: https://github.com/apache/arrow-julia/pull/556#issuecomment-2920537595 ## [Codecov](https://app.codecov.io/gh/apache/arrow-julia/pull/556?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[PR] Fix `OffsetArray` support and clean `CategoricalArray` support [arrow-julia]

2025-05-29 Thread via GitHub
nalimilan opened a new pull request, #556: URL: https://github.com/apache/arrow-julia/pull/556 Invalid indices were used with `OffsetArray`s as 1-based indexing was assumed. Fix this, and always wrap them in a `ToArrow` objet so that they are consistently turned into 1-based arrays.

Re: [I] Update the parquet thrift definitions [arrow-rs]

2025-05-29 Thread via GitHub
etseidl commented on issue #7567: URL: https://github.com/apache/arrow-rs/issues/7567#issuecomment-2920523371 I would love to get the total order PR (https://github.com/apache/parquet-format/pull/221) merged into the format before the next major release, but that may be wishful thinking.

Re: [PR] Add references for defaults in `WriterProperties` [arrow-rs]

2025-05-29 Thread via GitHub
alamb commented on code in PR #7558: URL: https://github.com/apache/arrow-rs/pull/7558#discussion_r2114706862 ## parquet/src/file/properties.rs: ## @@ -614,6 +622,84 @@ impl WriterPropertiesBuilder { self } +/// Sets the max length of min/max value fields whe

Re: [PR] Add references for defaults in `WriterProperties` [arrow-rs]

2025-05-29 Thread via GitHub
alamb commented on code in PR #7558: URL: https://github.com/apache/arrow-rs/pull/7558#discussion_r2114705752 ## parquet/src/file/properties.rs: ## @@ -614,6 +622,84 @@ impl WriterPropertiesBuilder { self } +/// Sets the max length of min/max value fields whe

Re: [I] Add support for GEOMETRY and GEOGRAPHY types in Parquet read and/or write [arrow-rs]

2025-05-29 Thread via GitHub
alamb commented on issue #7240: URL: https://github.com/apache/arrow-rs/issues/7240#issuecomment-2920508617 Among other things, we will also need to update the parquet-format definitions: - https://github.com/apache/arrow-rs/issues/7567 -- This is an automated message from the Apache G

[I] Update the parquet thrift definitions [arrow-rs]

2025-05-29 Thread via GitHub
alamb opened a new issue, #7567: URL: https://github.com/apache/arrow-rs/issues/7567 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** The parquet format has been updates to include types such as Variant and Geometry The parq

Re: [I] `arrow-55.1.0` breaks `filter_record_batch` [arrow-rs]

2025-05-29 Thread via GitHub
alamb closed issue #7500: `arrow-55.1.0` breaks `filter_record_batch` URL: https://github.com/apache/arrow-rs/issues/7500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] Panic in `pretty_format` function when displaying DurationSecondsArray with `i64::MIN` / `i64::MAX` [arrow-rs]

2025-05-29 Thread via GitHub
alamb commented on issue #7533: URL: https://github.com/apache/arrow-rs/issues/7533#issuecomment-2920488417 Closed in https://github.com/apache/arrow-rs/pull/7534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] `arrow-55.1.0` breaks `filter_record_batch` [arrow-rs]

2025-05-29 Thread via GitHub
alamb commented on issue #7500: URL: https://github.com/apache/arrow-rs/issues/7500#issuecomment-2920491178 I think this was fixed in this PR: - https://github.com/apache/arrow-rs/pull/7539 from @thorfour -- This is an automated message from the Apache Git Service. To respond to th

Re: [I] Panic in `pretty_format` function when displaying DurationSecondsArray with `i64::MIN` / `i64::MAX` [arrow-rs]

2025-05-29 Thread via GitHub
alamb closed issue #7533: Panic in `pretty_format` function when displaying DurationSecondsArray with `i64::MIN` / `i64::MAX` URL: https://github.com/apache/arrow-rs/issues/7533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Use PR title and description for commit message [arrow-rs]

2025-05-29 Thread via GitHub
alamb commented on issue #7562: URL: https://github.com/apache/arrow-rs/issues/7562#issuecomment-2920486438 Sounds like a good thing to try to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] Add native support to write out UnionArray in JSON writer [arrow-rs]

2025-05-29 Thread via GitHub
kumarlokesh opened a new pull request, #7566: URL: https://github.com/apache/arrow-rs/pull/7566 # Which issue does this PR close? Closes #7302. # Rationale for this change # What changes are included in this PR? 1. Added native `UnionEncoder`

Re: [I] The real exception was swallowed by another exception in CompositeJdbcConsumer::consume [arrow-java]

2025-05-29 Thread via GitHub
Odin-BN commented on issue #734: URL: https://github.com/apache/arrow-java/issues/734#issuecomment-2920464638 Hi @hnwyllmm ! I’d like to work on this issue. Could you please assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Potential regression in FileReader v18.3.0 [arrow-go]

2025-05-29 Thread via GitHub
zeroshade commented on issue #392: URL: https://github.com/apache/arrow-go/issues/392#issuecomment-2920332652 Thanks! I'll take a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] GH-46633 Update CombineChunks documentation to specify that binary columns can be combined into multiple chunks [arrow]

2025-05-29 Thread via GitHub
kangakum36 commented on PR #46638: URL: https://github.com/apache/arrow/pull/46638#issuecomment-2920299858 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] GH-46633 Update CombineChunks documentation to specify that binary columns can be combined into multiple chunks [arrow]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #46638: URL: https://github.com/apache/arrow/pull/46638#issuecomment-2920301106 ``` Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in. The Archery job run can be found a

Re: [PR] GH-46633 Update CombineChunks documentation to specify that binary columns can be combined into multiple chunks [arrow]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #46638: URL: https://github.com/apache/arrow/pull/46638#issuecomment-2920292972 :warning: GitHub issue #46633 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-46633 Update CombineChunks documentation to specify that binary columns can be combined into multiple chunks [arrow]

2025-05-29 Thread via GitHub
kangakum36 opened a new pull request, #46638: URL: https://github.com/apache/arrow/pull/46638 ### Rationale for this change The documentation for [pyarrow.Table.combine_chunks](https://arrow.apache.org/docs/python/generated/pyarrow.Table.html#pyarrow.Table.combine_chunks) and [Table

Re: [PR] GH-41973: Expose new S3 option check_directory_existence_before_creation - manual rebase [arrow]

2025-05-29 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46619: URL: https://github.com/apache/arrow/pull/46619#issuecomment-2920252549 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit bd2c0703b86a294d9c874f97e40c9294b0bc1b57. There were no

Re: [I] Potential regression in FileReader v18.3.0 [arrow-go]

2025-05-29 Thread via GitHub
przste-go commented on issue #392: URL: https://github.com/apache/arrow-go/issues/392#issuecomment-2920220994 Hey @zeroshade I've uploaded masked file here https://github.com/przste-go/broken-parquet. I verified that it can be read fine using 18.2.0 and fails on 18.3.0 -- This is an aut

Re: [I] [C++] FixedSizeListBuilder should have UnsafeAppend methods [arrow]

2025-05-29 Thread via GitHub
geonove commented on issue #45723: URL: https://github.com/apache/arrow/issues/45723#issuecomment-2920192509 @cramosme I see, we came to a the same implementation šŸ‘ You should link this issue in the PR, might have better chances to get it reviewed :) -- This is an automated message fr

Re: [PR] support merging primitive dictionaries in interleave and concat [arrow-rs]

2025-05-29 Thread via GitHub
davidhewitt commented on PR #7468: URL: https://github.com/apache/arrow-rs/pull/7468#issuecomment-2920155207 This is not forgotten, just been spinning other plates. Hoping to dive deep into this early next week. -- This is an automated message from the Apache Git Service. To respond to th

Re: [I] "error decoding response body: request or response body error: operation timed out" even when response stream is making progress [arrow-rs-object-store]

2025-05-29 Thread via GitHub
alamb commented on issue #386: URL: https://github.com/apache/arrow-rs-object-store/issues/386#issuecomment-2920166729 šŸ¤” so maybe cranking up the timeout is an adequate workaround for most users -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] Compact ViewArrays on IPCWrite [arrow-rs]

2025-05-29 Thread via GitHub
davidhewitt commented on issue #7185: URL: https://github.com/apache/arrow-rs/issues/7185#issuecomment-2920151078 I was wondering, does this same problem also apply to dictionaries? From what I can tell from a quick look inside `write_array_data`, buffers are truncated to any sliced portion

  1   2   >