[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #493: [Python] Define the unittests using pytest

2021-06-07 Thread GitBox
codecov-commenter edited a comment on pull request #493: URL: https://github.com/apache/arrow-datafusion/pull/493#issuecomment-853922282 #

[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #501: Add `partition by` constructs in window functions and modify logical planning

2021-06-07 Thread GitBox
codecov-commenter edited a comment on pull request #501: URL: https://github.com/apache/arrow-datafusion/pull/501#issuecomment-854535739 #

[GitHub] [arrow] mbrobbel opened a new pull request #10463: MINOR: [Docs] Fix a typo in Python IPC ReadStats class

2021-06-07 Thread GitBox
mbrobbel opened a new pull request #10463: URL: https://github.com/apache/arrow/pull/10463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [arrow] anthonylouisbsb commented on pull request #10059: ARROW-12410: [C++][Gandiva] Implement regexp_replace function on Gandiva

2021-06-07 Thread GitBox
anthonylouisbsb commented on pull request #10059: URL: https://github.com/apache/arrow/pull/10059#issuecomment-855891824 @praveenbingo The rebase was applied in the Pull Request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-rs] alamb commented on pull request #388: window::shift to work for all array types

2021-06-07 Thread GitBox
alamb commented on pull request #388: URL: https://github.com/apache/arrow-rs/pull/388#issuecomment-856016212 Do you think this one is ready now @nevi-me ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] pitrou commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10255: URL: https://github.com/apache/arrow/pull/10255#discussion_r646677174 ## File path: cpp/src/arrow/csv/chunker.cc ## @@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder { return Status::OK(); }

[GitHub] [arrow-rs] alamb opened a new pull request #421: Reenable MIRI check on PRs

2021-06-07 Thread GitBox
alamb opened a new pull request #421: URL: https://github.com/apache/arrow-rs/pull/421 # Which issue does this PR close? Fixes: https://github.com/apache/arrow-rs/issues/345 Based on https://github.com/apache/arrow-rs/pull/416, so draft until that is done # Rationale:

[GitHub] [arrow] pitrou closed pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
pitrou closed pull request #10255: URL: https://github.com/apache/arrow/pull/10255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] kszucs commented on pull request #10411: ARROW-12801: [CI][Packaging][Java] Include all modules in script that generate Arrow jars

2021-06-07 Thread GitBox
kszucs commented on pull request #10411: URL: https://github.com/apache/arrow/pull/10411#issuecomment-855856812 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] jonkeane commented on a change in pull request #10462: ARROW-12985: [Python][Packaging] Unable to install pygit2 in the arm64 wheel builds

2021-06-07 Thread GitBox
jonkeane commented on a change in pull request #10462: URL: https://github.com/apache/arrow/pull/10462#discussion_r646594774 ## File path: dev/archery/archery/crossbow/core.py ## @@ -194,7 +194,8 @@ def credentials(self, url, username_from_url, allowed_types):

[GitHub] [arrow] n3world commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
n3world commented on a change in pull request #10255: URL: https://github.com/apache/arrow/pull/10255#discussion_r646629832 ## File path: cpp/src/arrow/csv/chunker.cc ## @@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder { return Status::OK(); }

[GitHub] [arrow-datafusion] jychen7 commented on a change in pull request #519: 110 support group by positions

2021-06-07 Thread GitBox
jychen7 commented on a change in pull request #519: URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646692308 ## File path: datafusion/src/sql/planner.rs ## @@ -2319,6 +2320,16 @@ mod tests { ); } +#[test] +fn

[GitHub] [arrow] kszucs commented on a change in pull request #10467: ARROW-12989: [CI] Avoid aggressive cancellation of the "Dev PR" workflow

2021-06-07 Thread GitBox
kszucs commented on a change in pull request #10467: URL: https://github.com/apache/arrow/pull/10467#discussion_r646721715 ## File path: .github/workflows/dev_pr.yml ## @@ -28,9 +28,8 @@ on: - edited - synchronize -concurrency: - group: ${{ github.repository

[GitHub] [arrow] pitrou commented on a change in pull request #10467: ARROW-12989: [CI] Avoid aggressive cancellation of the "Dev PR" workflow

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10467: URL: https://github.com/apache/arrow/pull/10467#discussion_r646725639 ## File path: .github/workflows/dev_pr.yml ## @@ -28,9 +28,8 @@ on: - edited - synchronize -concurrency: - group: ${{ github.repository

[GitHub] [arrow] jpedroantunes commented on a change in pull request #10385: ARROW-12858: [C++][Gandiva] Add isNull, isTrue, isFalse, isNotTrue, IsNotFalse and NVL functions on Gandiva

2021-06-07 Thread GitBox
jpedroantunes commented on a change in pull request #10385: URL: https://github.com/apache/arrow/pull/10385#discussion_r646536956 ## File path: cpp/src/gandiva/function_registry_math_ops.cc ## @@ -84,6 +84,17 @@ std::vector GetMathOpsFunctionRegistry() {

[GitHub] [arrow] jvictorhuguenin opened a new pull request #10464: ARROW-12943: [Gandiva][C++]Implement MD5 Hive function

2021-06-07 Thread GitBox
jvictorhuguenin opened a new pull request #10464: URL: https://github.com/apache/arrow/pull/10464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #501: Add `partition by` constructs in window functions and modify logical planning

2021-06-07 Thread GitBox
Jimexist commented on a change in pull request #501: URL: https://github.com/apache/arrow-datafusion/pull/501#discussion_r646554070 ## File path: datafusion/src/sql/planner.rs ## @@ -2761,15 +2765,24 @@ mod tests { quick_test(sql, expected); } +/// psql

[GitHub] [arrow] pitrou commented on pull request #10258: ARROW-12560: [C++] Add scheduling option for Future callbacks

2021-06-07 Thread GitBox
pitrou commented on pull request #10258: URL: https://github.com/apache/arrow/pull/10258#issuecomment-855931334 Thanks for the update @westonpace . I'll merge once CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-rs] medwards opened a new pull request #420: Sort by float lists

2021-06-07 Thread GitBox
medwards opened a new pull request #420: URL: https://github.com/apache/arrow-rs/pull/420 # Rationale for this change No particular reason float types shouldn't have the same support as integers in this case. Booleans are excluded due to not being primitive types. Note: We

[GitHub] [arrow] pitrou commented on pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
pitrou commented on pull request #10255: URL: https://github.com/apache/arrow/pull/10255#issuecomment-855945821 Thanks for the update @n3world ! I will merge this once CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs

2021-06-07 Thread GitBox
pitrou commented on pull request #10416: URL: https://github.com/apache/arrow/pull/10416#issuecomment-855957069 Perhaps that's because the `pull_request_target` event doesn't fill the `github.*` variables similarly as the `pull_request` event. -- This is an automated message from the

[GitHub] [arrow] bkietz commented on a change in pull request #8990: ARROW-10959: [C++] Add scalar string join kernel

2021-06-07 Thread GitBox
bkietz commented on a change in pull request #8990: URL: https://github.com/apache/arrow/pull/8990#discussion_r646632021 ## File path: cpp/src/arrow/array/builder_binary.h ## @@ -77,6 +77,23 @@ class BaseBinaryBuilder : public ArrayBuilder { return Append(value.data(),

[GitHub] [arrow] maartenbreddels commented on pull request #9000: ARROW-10557: [C++] Add scalar string slicing/substring extract kernel

2021-06-07 Thread GitBox
maartenbreddels commented on pull request #9000: URL: https://github.com/apache/arrow/pull/9000#issuecomment-855982307 Thanks for picking this up @pitrou, I could not find the time to update it! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-datafusion] alamb merged pull request #515: refactor sort exec stream and combine batches

2021-06-07 Thread GitBox
alamb merged pull request #515: URL: https://github.com/apache/arrow-datafusion/pull/515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #519: 110 support group by positions

2021-06-07 Thread GitBox
alamb commented on a change in pull request #519: URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646670864 ## File path: datafusion/src/sql/utils.rs ## @@ -390,6 +391,29 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) -> HashMap { .collect::>()

[GitHub] [arrow] kszucs commented on pull request #10411: ARROW-12801: [CI][Packaging][Java] Include all modules in script that generate Arrow jars

2021-06-07 Thread GitBox
kszucs commented on pull request #10411: URL: https://github.com/apache/arrow/pull/10411#issuecomment-856040293 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] bkietz commented on a change in pull request #10364: ARROW-12074: [C++][Compute] Add scalar arithmetic kernels for decimal

2021-06-07 Thread GitBox
bkietz commented on a change in pull request #10364: URL: https://github.com/apache/arrow/pull/10364#discussion_r646711505 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -428,12 +524,69 @@ ArrayKernelExec ArithmeticExecFromOp(detail::GetTypeId get_id)

[GitHub] [arrow] pitrou closed pull request #10258: ARROW-12560: [C++] Add scheduling option for Future callbacks

2021-06-07 Thread GitBox
pitrou closed pull request #10258: URL: https://github.com/apache/arrow/pull/10258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs

2021-06-07 Thread GitBox
pitrou commented on pull request #10416: URL: https://github.com/apache/arrow/pull/10416#issuecomment-855949193 Uh, it seems this may not be working as expected. Here is a unexpectedly cancelled job: https://github.com/apache/arrow/actions/runs/914966579 -- This is an automated

[GitHub] [arrow] bkietz commented on a change in pull request #10364: ARROW-12074: [C++][Compute] Add scalar arithmetic kernels for decimal

2021-06-07 Thread GitBox
bkietz commented on a change in pull request #10364: URL: https://github.com/apache/arrow/pull/10364#discussion_r646620882 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -451,8 +604,45 @@ struct ArithmeticFunction : ScalarFunction { if (auto kernel

[GitHub] [arrow] pitrou commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10255: URL: https://github.com/apache/arrow/pull/10255#discussion_r646631692 ## File path: cpp/src/arrow/csv/chunker.cc ## @@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder { return Status::OK(); }

[GitHub] [arrow] pitrou commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10255: URL: https://github.com/apache/arrow/pull/10255#discussion_r646676681 ## File path: cpp/src/arrow/csv/chunker.cc ## @@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder { return Status::OK(); }

[GitHub] [arrow] pitrou commented on pull request #9620: ARROW-11843: [C++] Provide async Parquet reader

2021-06-07 Thread GitBox
pitrou commented on pull request #9620: URL: https://github.com/apache/arrow/pull/9620#issuecomment-856015342 Rebased, will merge. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] github-actions[bot] commented on pull request #10411: ARROW-12801: [CI][Packaging][Java] Include all modules in script that generate Arrow jars

2021-06-07 Thread GitBox
github-actions[bot] commented on pull request #10411: URL: https://github.com/apache/arrow/pull/10411#issuecomment-855857382 Revision: 4234430f30a2b9e3b4bbb562e9cd11357466f66f Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] jorisvandenbossche commented on pull request #10466: ARROW-12988: [CI] Skip the failing test in kartothek nightly integration build

2021-06-07 Thread GitBox
jorisvandenbossche commented on pull request #10466: URL: https://github.com/apache/arrow/pull/10466#issuecomment-855946625 @github-actions crossbow submit test-conda-python-3.7-kartothek-master test-conda-python-3.7-kartothek-latest -- This is an automated message from the Apache Git

[GitHub] [arrow] jorisvandenbossche commented on pull request #10466: ARROW-12988: [CI] Skip the failing test in kartothek nightly integration build

2021-06-07 Thread GitBox
jorisvandenbossche commented on pull request #10466: URL: https://github.com/apache/arrow/pull/10466#issuecomment-855946422 @github-actions crossbow test-conda-python-3.7-kartothek-master test-conda-python-3.7-kartothek-latest -- This is an automated message from the Apache Git

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #521: Return errors properly from RepartitionExec

2021-06-07 Thread GitBox
codecov-commenter commented on pull request #521: URL: https://github.com/apache/arrow-datafusion/pull/521#issuecomment-855977564 #

[GitHub] [arrow-rs] alamb commented on a change in pull request #418: Fix bug with null buffer offset in boolean not kernel

2021-06-07 Thread GitBox
alamb commented on a change in pull request #418: URL: https://github.com/apache/arrow-rs/pull/418#discussion_r646683427 ## File path: arrow/src/compute/kernels/boolean.rs ## @@ -813,6 +813,19 @@ mod tests { assert_eq!(c, expected); } +#[test] +fn

[GitHub] [arrow] jorisvandenbossche closed pull request #10466: ARROW-12988: [CI] Skip the failing test in kartothek nightly integration build

2021-06-07 Thread GitBox
jorisvandenbossche closed pull request #10466: URL: https://github.com/apache/arrow/pull/10466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [arrow] jpedroantunes opened a new pull request #10465: ARROW-12986: [C++][Gandiva] Implement new cache eviction policy in Gandiva

2021-06-07 Thread GitBox
jpedroantunes opened a new pull request #10465: URL: https://github.com/apache/arrow/pull/10465 Actually, the eviction policy algorithm used by Gandiva's cache is based on LRU. I suggest to add a new option of eviction algorithm to use that considers the LLVM build time as a cost,

[GitHub] [arrow] pitrou commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10255: URL: https://github.com/apache/arrow/pull/10255#discussion_r646590868 ## File path: python/pyarrow/tests/test_csv.py ## @@ -319,6 +321,79 @@ def test_header_skip_rows(self): "kl": ["op"], } +def

[GitHub] [arrow] bkietz commented on a change in pull request #10412: ARROW-9430: [C++] Implement replace_with_mask kernel

2021-06-07 Thread GitBox
bkietz commented on a change in pull request #10412: URL: https://github.com/apache/arrow/pull/10412#discussion_r646627167 ## File path: cpp/src/arrow/compute/kernels/vector_replace.cc ## @@ -0,0 +1,495 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #521: Return errors properly from RepartitionExec

2021-06-07 Thread GitBox
alamb commented on a change in pull request #521: URL: https://github.com/apache/arrow-datafusion/pull/521#discussion_r646646671 ## File path: datafusion/src/physical_plan/repartition.rs ## @@ -308,6 +310,45 @@ impl RepartitionExec { send_time_nanos:

[GitHub] [arrow] cyb70289 commented on a change in pull request #10364: ARROW-12074: [C++][Compute] Add scalar arithmetic kernels for decimal

2021-06-07 Thread GitBox
cyb70289 commented on a change in pull request #10364: URL: https://github.com/apache/arrow/pull/10364#discussion_r646669503 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -451,8 +604,45 @@ struct ArithmeticFunction : ScalarFunction { if (auto

[GitHub] [arrow-datafusion] jychen7 commented on a change in pull request #519: 110 support group by positions

2021-06-07 Thread GitBox
jychen7 commented on a change in pull request #519: URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646695820 ## File path: datafusion/src/sql/utils.rs ## @@ -390,6 +391,29 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) -> HashMap {

[GitHub] [arrow] bkietz commented on a change in pull request #10364: ARROW-12074: [C++][Compute] Add scalar arithmetic kernels for decimal

2021-06-07 Thread GitBox
bkietz commented on a change in pull request #10364: URL: https://github.com/apache/arrow/pull/10364#discussion_r646714303 ## File path: docs/source/cpp/compute.rst ## @@ -286,11 +286,29 @@ an ``Invalid`` :class:`Status` when overflow is detected.

[GitHub] [arrow] pitrou commented on a change in pull request #10461: ARROW-12096: [C++]: Allows users to define arrow timestamp unit for Parquet INT96 timestamp

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10461: URL: https://github.com/apache/arrow/pull/10461#discussion_r646709078 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -1671,6 +1671,91 @@ TEST(TestArrowReadWrite, UseDeprecatedInt96) {

[GitHub] [arrow] pitrou commented on pull request #10461: ARROW-12096: [C++]: Allows users to define arrow timestamp unit for Parquet INT96 timestamp

2021-06-07 Thread GitBox
pitrou commented on pull request #10461: URL: https://github.com/apache/arrow/pull/10461#issuecomment-856054729 @wesm @emkornfield What do you think about the functionality that is added here? Is it a reasonable burden for us to take on? -- This is an automated message from the Apache

[GitHub] [arrow] jorisvandenbossche opened a new pull request #10466: ARROW-12988: [CI] Skip the failing test in kartothek nightly integration build

2021-06-07 Thread GitBox
jorisvandenbossche opened a new pull request #10466: URL: https://github.com/apache/arrow/pull/10466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [arrow] n3world commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
n3world commented on a change in pull request #10255: URL: https://github.com/apache/arrow/pull/10255#discussion_r646612914 ## File path: cpp/src/arrow/csv/chunker.cc ## @@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder { return Status::OK(); }

[GitHub] [arrow-datafusion] tustvold commented on a change in pull request #521: Return errors properly from RepartitionExec

2021-06-07 Thread GitBox
tustvold commented on a change in pull request #521: URL: https://github.com/apache/arrow-datafusion/pull/521#discussion_r646611109 ## File path: datafusion/src/physical_plan/repartition.rs ## @@ -308,6 +310,45 @@ impl RepartitionExec { send_time_nanos:

[GitHub] [arrow] pitrou opened a new pull request #10467: ARROW-12989: [CI] Avoid aggressive cancellation of the "Dev PR" workflow

2021-06-07 Thread GitBox
pitrou opened a new pull request #10467: URL: https://github.com/apache/arrow/pull/10467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs

2021-06-07 Thread GitBox
pitrou commented on pull request #10416: URL: https://github.com/apache/arrow/pull/10416#issuecomment-855964764 Fix filed in https://github.com/apache/arrow/pull/10467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] github-actions[bot] commented on pull request #10466: ARROW-12988: [CI] Skip the failing test in kartothek nightly integration build

2021-06-07 Thread GitBox
github-actions[bot] commented on pull request #10466: URL: https://github.com/apache/arrow/pull/10466#issuecomment-855971676 ``` No such command 'test-conda-python-3.7-kartothek-master'. ``` -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-datafusion] alamb merged pull request #518: Fix 517 - move `window_frames` module to `logical_plan`

2021-06-07 Thread GitBox
alamb merged pull request #518: URL: https://github.com/apache/arrow-datafusion/pull/518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] n3world commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
n3world commented on a change in pull request #10255: URL: https://github.com/apache/arrow/pull/10255#discussion_r64716 ## File path: cpp/src/arrow/csv/chunker.cc ## @@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder { return Status::OK(); }

[GitHub] [arrow-datafusion] alamb closed issue #517: move window frame module to be in `logical_plan`

2021-06-07 Thread GitBox
alamb closed issue #517: URL: https://github.com/apache/arrow-datafusion/issues/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] anthonylouisbsb opened a new pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure

2021-06-07 Thread GitBox
anthonylouisbsb opened a new pull request #10468: URL: https://github.com/apache/arrow/pull/10468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [arrow-datafusion] jychen7 commented on a change in pull request #519: 110 support group by positions

2021-06-07 Thread GitBox
jychen7 commented on a change in pull request #519: URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646693623 ## File path: datafusion/src/sql/utils.rs ## @@ -390,6 +391,29 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) -> HashMap {

[GitHub] [arrow] jorisvandenbossche commented on pull request #10466: ARROW-12988: [CI] Skip the failing test in kartothek nightly integration build

2021-06-07 Thread GitBox
jorisvandenbossche commented on pull request #10466: URL: https://github.com/apache/arrow/pull/10466#issuecomment-856062639 This is getting fixed in dask as well, but let's merge this for now (we can revert when the next dask release is available), so we get green builds for this one.

[GitHub] [arrow-datafusion] alamb opened a new pull request #521: Return errors properly from RepartitionExec

2021-06-07 Thread GitBox
alamb opened a new pull request #521: URL: https://github.com/apache/arrow-datafusion/pull/521 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/437 # Rationale for this change Errors should be returned rather than incorrect results

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #521: Return errors properly from RepartitionExec

2021-06-07 Thread GitBox
alamb commented on a change in pull request #521: URL: https://github.com/apache/arrow-datafusion/pull/521#discussion_r646597513 ## File path: datafusion/src/physical_plan/repartition.rs ## @@ -249,13 +252,12 @@ impl ExecutionPlan for RepartitionExec {

[GitHub] [arrow-datafusion] tustvold commented on a change in pull request #521: Return errors properly from RepartitionExec

2021-06-07 Thread GitBox
tustvold commented on a change in pull request #521: URL: https://github.com/apache/arrow-datafusion/pull/521#discussion_r646611109 ## File path: datafusion/src/physical_plan/repartition.rs ## @@ -308,6 +310,45 @@ impl RepartitionExec { send_time_nanos:

[GitHub] [arrow] pitrou commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10255: URL: https://github.com/apache/arrow/pull/10255#discussion_r646615349 ## File path: cpp/src/arrow/csv/chunker.cc ## @@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder { return Status::OK(); }

[GitHub] [arrow] jonkeane closed pull request #10389: ARROW-12824: [R][CI] Upgrade builds for R 4.1 release

2021-06-07 Thread GitBox
jonkeane closed pull request #10389: URL: https://github.com/apache/arrow/pull/10389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] bkietz commented on a change in pull request #10364: ARROW-12074: [C++][Compute] Add scalar arithmetic kernels for decimal

2021-06-07 Thread GitBox
bkietz commented on a change in pull request #10364: URL: https://github.com/apache/arrow/pull/10364#discussion_r646620882 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -451,8 +604,45 @@ struct ArithmeticFunction : ScalarFunction { if (auto kernel

[GitHub] [arrow] pitrou commented on a change in pull request #8990: ARROW-10959: [C++] Add scalar string join kernel

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #8990: URL: https://github.com/apache/arrow/pull/8990#discussion_r646630651 ## File path: cpp/src/arrow/array/builder_binary.h ## @@ -77,6 +77,23 @@ class BaseBinaryBuilder : public ArrayBuilder { return Append(value.data(),

[GitHub] [arrow-rs] codecov-commenter commented on pull request #420: Sort by float lists

2021-06-07 Thread GitBox
codecov-commenter commented on pull request #420: URL: https://github.com/apache/arrow-rs/pull/420#issuecomment-855975190 #

[GitHub] [arrow] pitrou closed pull request #10463: MINOR: [Docs] Fix a typo in Python IPC ReadStats class

2021-06-07 Thread GitBox
pitrou closed pull request #10463: URL: https://github.com/apache/arrow/pull/10463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] pitrou closed pull request #10458: ARROW-12982: [C++] Re-enable unused-variable warning

2021-06-07 Thread GitBox
pitrou closed pull request #10458: URL: https://github.com/apache/arrow/pull/10458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] pitrou commented on a change in pull request #10454: ARROW-12950: [C++] Add count_substring kernel

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10454: URL: https://github.com/apache/arrow/pull/10454#discussion_r646747304 ## File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc ## @@ -91,6 +91,25 @@ TYPED_TEST(TestBinaryKernels, FindSubstring) {

[GitHub] [arrow-datafusion] alamb merged pull request #516: Refactor window aggregation, simplify batch processing logic

2021-06-07 Thread GitBox
alamb merged pull request #516: URL: https://github.com/apache/arrow-datafusion/pull/516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow] lidavidm commented on a change in pull request #10448: ARROW-12949: [C++] Add starts_with and ends_with

2021-06-07 Thread GitBox
lidavidm commented on a change in pull request #10448: URL: https://github.com/apache/arrow/pull/10448#discussion_r646827535 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -636,13 +728,15 @@ std::string MakeLikeRegex(const MatchSubstringOptions& options) {

[GitHub] [arrow] lidavidm commented on a change in pull request #10448: ARROW-12949: [C++] Add starts_with and ends_with

2021-06-07 Thread GitBox
lidavidm commented on a change in pull request #10448: URL: https://github.com/apache/arrow/pull/10448#discussion_r646827535 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -636,13 +728,15 @@ std::string MakeLikeRegex(const MatchSubstringOptions& options) {

[GitHub] [arrow] isichei commented on a change in pull request #10461: ARROW-12096: [C++]: Allows users to define arrow timestamp unit for Parquet INT96 timestamp

2021-06-07 Thread GitBox
isichei commented on a change in pull request #10461: URL: https://github.com/apache/arrow/pull/10461#discussion_r646852666 ## File path: cpp/src/parquet/arrow/reader_internal.cc ## @@ -742,20 +752,20 @@ Status TransferColumnData(RecordReader* reader, std::shared_ptr value_

[GitHub] [arrow] github-actions[bot] commented on pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images

2021-06-07 Thread GitBox
github-actions[bot] commented on pull request #10468: URL: https://github.com/apache/arrow/pull/10468#issuecomment-856188250 https://issues.apache.org/jira/browse/ARROW-12987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kszucs closed pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images

2021-06-07 Thread GitBox
kszucs closed pull request #10468: URL: https://github.com/apache/arrow/pull/10468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] github-actions[bot] commented on pull request #10470: ARROW-12983: [C++][Python][R] Properly overflow to chunked array in Python-to-Arrow conversion

2021-06-07 Thread GitBox
github-actions[bot] commented on pull request #10470: URL: https://github.com/apache/arrow/pull/10470#issuecomment-856194721 https://issues.apache.org/jira/browse/ARROW-12983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] lidavidm opened a new pull request #10474: ARROW-12998: [C++] Add dataset->toolchain dependency

2021-06-07 Thread GitBox
lidavidm opened a new pull request #10474: URL: https://github.com/apache/arrow/pull/10474 This is rather coarse-grained, but in principle if datasets needs any headers that are built as part of the build process or depends on headers that do, then this is the right thing (and it saves us

[GitHub] [arrow] pitrou commented on pull request #10454: ARROW-12950: [C++] Add count_substring kernel

2021-06-07 Thread GitBox
pitrou commented on pull request #10454: URL: https://github.com/apache/arrow/pull/10454#issuecomment-856077939 Could you rebase now that the parent issue has been fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] bkietz commented on a change in pull request #10443: ARROW-12942: [C++][Compute] Fix incorrect result of Arrow compute hash_min_max with a chunked array

2021-06-07 Thread GitBox
bkietz commented on a change in pull request #10443: URL: https://github.com/apache/arrow/pull/10443#discussion_r646816751 ## File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc ## @@ -1000,16 +1010,16 @@ struct GroupedMinMaxImpl : public GroupedAggregator {

[GitHub] [arrow] lidavidm commented on a change in pull request #10323: ARROW-12779: [Python][FlightRPC] Guard against DoGet handler that never sends data

2021-06-07 Thread GitBox
lidavidm commented on a change in pull request #10323: URL: https://github.com/apache/arrow/pull/10323#discussion_r646836558 ## File path: python/pyarrow/_flight.pyx ## @@ -1655,70 +1655,83 @@ cdef CStatus _data_stream_next(void* self, CFlightPayload* payload) except *:

[GitHub] [arrow] lidavidm commented on a change in pull request #10323: ARROW-12779: [Python][FlightRPC] Guard against DoGet handler that never sends data

2021-06-07 Thread GitBox
lidavidm commented on a change in pull request #10323: URL: https://github.com/apache/arrow/pull/10323#discussion_r646837177 ## File path: python/pyarrow/_flight.pyx ## @@ -1655,70 +1655,83 @@ cdef CStatus _data_stream_next(void* self, CFlightPayload* payload) except *:

[GitHub] [arrow] bkietz commented on issue #10469: Official way of using parquet in modern cmake

2021-06-07 Thread GitBox
bkietz commented on issue #10469: URL: https://github.com/apache/arrow/issues/10469#issuecomment-856184215 @ghamarian could you please [open a JIRA](https://issues.apache.org/jira/secure/CreateIssue!default.jspa) describing what you're trying to accomplish? -- This is an automated

[GitHub] [arrow] kszucs closed pull request #10462: ARROW-12985: [Python][Packaging] Unable to install pygit2 in the arm64 wheel builds

2021-06-07 Thread GitBox
kszucs closed pull request #10462: URL: https://github.com/apache/arrow/pull/10462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] nealrichardson commented on pull request #10470: ARROW-12983: [C++][Python][R] Properly overflow to chunked array in Python-to-Arrow conversion

2021-06-07 Thread GitBox
nealrichardson commented on pull request #10470: URL: https://github.com/apache/arrow/pull/10470#issuecomment-856200878 > I've updated R but note that R never builds a chunked array hence there should be no effect. Not yet! But we hope to in ARROW-9293. cc @romainfrancois --

[GitHub] [arrow] lidavidm commented on a change in pull request #10470: ARROW-12983: [C++][Python][R] Properly overflow to chunked array in Python-to-Arrow conversion

2021-06-07 Thread GitBox
lidavidm commented on a change in pull request #10470: URL: https://github.com/apache/arrow/pull/10470#discussion_r646888427 ## File path: cpp/src/arrow/python/python_to_arrow.cc ## @@ -536,6 +539,41 @@ class PyPrimitiveConverter> return Status::OK(); } + Result

[GitHub] [arrow] github-actions[bot] commented on pull request #10474: ARROW-12998: [C++] Add dataset->toolchain dependency

2021-06-07 Thread GitBox
github-actions[bot] commented on pull request #10474: URL: https://github.com/apache/arrow/pull/10474#issuecomment-856209201 https://issues.apache.org/jira/browse/ARROW-12998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kszucs commented on a change in pull request #10467: ARROW-12989: [CI] Avoid aggressive cancellation of the "Dev PR" workflow

2021-06-07 Thread GitBox
kszucs commented on a change in pull request #10467: URL: https://github.com/apache/arrow/pull/10467#discussion_r646752765 ## File path: .github/workflows/dev_pr.yml ## @@ -28,9 +28,8 @@ on: - edited - synchronize -concurrency: - group: ${{ github.repository

[GitHub] [arrow] kszucs closed pull request #10467: ARROW-12989: [CI] Avoid aggressive cancellation of the "Dev PR" workflow

2021-06-07 Thread GitBox
kszucs closed pull request #10467: URL: https://github.com/apache/arrow/pull/10467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] alamb commented on pull request #421: Reenable MIRI check on PRs

2021-06-07 Thread GitBox
alamb commented on pull request #421: URL: https://github.com/apache/arrow-rs/pull/421#issuecomment-856092796 Successful run 1: https://github.com/apache/arrow-rs/pull/421/checks?check_run_id=2765560493 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] pitrou commented on a change in pull request #10395: ARROW-12861: [C++][Compute] Add sign function kernels

2021-06-07 Thread GitBox
pitrou commented on a change in pull request #10395: URL: https://github.com/apache/arrow/pull/10395#discussion_r646772641 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc ## @@ -1161,5 +1180,93 @@ TYPED_TEST(TestUnaryArithmeticFloating, AbsoluteValue) {

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #519: 110 support group by positions

2021-06-07 Thread GitBox
alamb commented on a change in pull request #519: URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646772473 ## File path: datafusion/src/sql/utils.rs ## @@ -390,6 +391,29 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) -> HashMap { .collect::>()

[GitHub] [arrow] anthonylouisbsb removed a comment on pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure

2021-06-07 Thread GitBox
anthonylouisbsb removed a comment on pull request #10468: URL: https://github.com/apache/arrow/pull/10468#issuecomment-856097519 @github-actions crossbow submit test-ubuntu-18.04-cpp-static test-ubuntu-18.04-cpp -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] pitrou closed pull request #8990: ARROW-10959: [C++] Add scalar string join kernel

2021-06-07 Thread GitBox
pitrou closed pull request #8990: URL: https://github.com/apache/arrow/pull/8990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #416: Fix out of bounds read in bit chunk iterator

2021-06-07 Thread GitBox
jorgecarleitao commented on a change in pull request #416: URL: https://github.com/apache/arrow-rs/pull/416#discussion_r646800597 ## File path: arrow/src/util/bit_chunk_iterator.rs ## @@ -137,14 +137,16 @@ impl Iterator for BitChunkIterator<'_> { // so when reading as

[GitHub] [arrow] pitrou closed pull request #10454: ARROW-12950: [C++] Add count_substring kernel

2021-06-07 Thread GitBox
pitrou closed pull request #10454: URL: https://github.com/apache/arrow/pull/10454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] isichei commented on a change in pull request #10461: ARROW-12096: [C++]: Allows users to define arrow timestamp unit for Parquet INT96 timestamp

2021-06-07 Thread GitBox
isichei commented on a change in pull request #10461: URL: https://github.com/apache/arrow/pull/10461#discussion_r646865384 ## File path: cpp/src/parquet/types.h ## @@ -602,6 +602,49 @@ static inline int64_t Int96GetNanoSeconds(const parquet::Int96& i96) { return

[GitHub] [arrow] github-actions[bot] commented on pull request #10472: ARROW-12975: [C++][Python] if_else kernel doesn't support upcasting

2021-06-07 Thread GitBox
github-actions[bot] commented on pull request #10472: URL: https://github.com/apache/arrow/pull/10472#issuecomment-856202122 https://issues.apache.org/jira/browse/ARROW-12975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] anthonylouisbsb commented on pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure

2021-06-07 Thread GitBox
anthonylouisbsb commented on pull request #10468: URL: https://github.com/apache/arrow/pull/10468#issuecomment-856069742 @kszucs I think I do not have permission to manually start the crossbow builds using the bot. So could you submit the `test-ubuntu-18.04-cpp-static` and the

  1   2   3   >