native JS Error and unwraps it on bubbling to JS, so that the
Chrome Devtools can show something sensible, and source map tools could
deobfuscate a combined JS/Java stack trace.
On Tue, Jul 9, 2013 at 4:25 PM, Goktug Gokdogan gok...@google.com wrote:
On Tue, Jul 9, 2013 at 2:30 PM, Ray
Ray Cromwell has uploaded a new change for review.
https://gwt-review.googlesource.com/3670
Change subject: Makes some private implementation classes of
StackTraceCreator public to enable custom implementations. Useful for other
Javascript VMs, as well as integration with non-GWT code
Ray Cromwell has posted comments on this change.
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Patch Set 3:
Is there a bug/issue somewhere for this? What is the overall goal it is
trying to accomplish
Ray Cromwell has posted comments on this change.
Change subject: Adding key codes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3480
To unsubscribe, visit https://gwt
I've been giving +2s for stuff I think is ready to commit, but I always
assumed that Googlers would have no superpowers here, and that Steering
Committee members and other designated people with specialized knowledge
could do so as well. Google doesn't automatically import changes without
Ray Cromwell has posted comments on this change.
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's various constructors.
..
Patch Set 2:
Is there a bug
Ray Cromwell has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 8: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt
I haven't look at the code, but I think it runs a precompile, and then
stops. So it constructs the whole program AST and runs generators, so it
runs all checking up to that point. I'm pretty sure it should be running
JSORestrictionsChecker which runs on JDT I believe.
On Wed, Jun 5, 2013 at
Ray Cromwell has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 5:
I hadn't thought of this, but the copyright message for new files should
probably be different. I will bring this up
Ray Cromwell has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(1 comment)
File user/super/com/google/gwt/emul/java/util
Ray Cromwell has posted comments on this change.
Change subject: Inliner produces incorrect code if a parameter is a new
array expression.
..
Patch Set 2: Code-Review+2
Is this overly conservative? If there is only one
One reason to have a permutation for blink is if we start doing VM specific
code gen (V8 vs Nitro vs *Monkey). Another is blink performance around
layout might require substantially different workarounds on Mobile Safari.
On Mon, May 27, 2013 at 11:42 AM, Matthew Dempsky
Ray Cromwell has posted comments on this change.
Change subject: Fix module unloading with multiple modules on a page
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/2941
To unsubscribe
Ray Cromwell has posted comments on this change.
Change subject: Fixes TypeError in keys() for JsMapFromStringTo in dev mode.
..
Patch Set 1:
(1 comment)
File elemental
Ray Cromwell has posted comments on this change.
Change subject: Unary plus in Jsni code was always discarded.
..
Patch Set 2: Code-Review+2
Likely there was a global submit failure somewhere and all of the CLs
between
Ray Cromwell has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 3: Code-Review+1
It would be nice to have a GWTTestCase (to be run in web-mode
Ray Cromwell has posted comments on this change.
Change subject: Adds part of Java 7 new language features.
..
Patch Set 10: Code-Review+2
(1 comment)
File
dev/core/src
Ray Cromwell has posted comments on this change.
Change subject: Adds the remaining (and more complex) Java 7 new language
features.
..
Patch Set 8: Code-Review+2
(1 comment
Ray Cromwell has uploaded a new change for review.
https://gwt-review.googlesource.com/2581
Change subject: Adds new configuration property to specify minimum fragment
size.
..
Adds new configuration property to specify
Ray Cromwell has uploaded a new patch set (#2).
Change subject: Adds new configuration property to specify minimum fragment
size.
..
Adds new configuration property to specify minimum fragment size.
set-configuration
Ray Cromwell has posted comments on this change.
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Patch Set 2: Code-Review+1
(1 comment)
I'm ok with the solution, but it leaves me wonder if we should opt
Good catch. The real solution IMHO to these issues is to do linker
processing on a JS AST, not on text. Most of the current linker API relies
on string operations which make designing a non-brittle sourcemap
difficult. If for example, we read the JS for the fragment via the
Closure/Rhino AST, then
Another downside of DevMode maintenance is all the hacks needed in the
codebase around isScript()/@GwtScriptOnly and other magic JVM stuff. There
are still lingering bugs in HostedModeClassRewriter around SingleJsoImpls
and generics. I agree that there is nothing that works as smoothly and JVM
Cool, I never imagined it'd be that easy, I thought you'd have to unzip the
source and hack it. Awesome work.
On Thu, Mar 21, 2013 at 8:09 PM, Brian Slesinsky skybr...@google.comwrote:
Brian Slesinsky has posted comments on this change.
Change subject: Implemented handling of
Chrome already has a protocol for most of this stuff, a wire-debugging
protocol and source-maps. IntelliJ/WebStorm have direct support for this.
WebStorm 6 for example + Chrome will do much of what the Firefox
announcement talks about. It even has Live Editing
On Mon, Mar 18, 2013 at 10:36 AM,
Ray Cromwell has uploaded a new patch set (#3).
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better integration with closure compiler
which has
-review.googlesource.com/2230
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0eb0535cd2c7693aae162e246332dc7bca87d241
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer
Ray Cromwell has uploaded a new change for review.
https://gwt-review.googlesource.com/2230
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better
Ray Cromwell has uploaded a new patch set (#2).
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better integration with closure compiler
which has
Ray Cromwell has posted comments on this change.
Change subject: Run JsInliner only on methods that are JSNI or that contain
JSNI calls (not on the whole AST).
..
Patch Set 4: Code-Review+1
(3 comments)
Any data on code
Ray Cromwell has posted comments on this change.
Change subject: Missing overrides in JNonNullType made signatures for same
types differ.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com
We added a pass to GWT before to work around a Safari Nitro bug with the
shift operator (), we could do something similar. See here:
http://code.google.com/p/google-web-toolkit/source/browse/trunk/dev/core/src/com/google/gwt/dev/js/JsCoerceIntShift.java
On Wed, Feb 6, 2013 at 4:03 AM, Jens
Ray Cromwell has posted comments on this change.
Change subject: Fixes internal compiler error caused by a null logger
parsing jsni code that was generated by a generator at test time.
..
Patch Set 2: Code-Review+1
Ray Cromwell has uploaded a new change for review.
https://gwt-review.googlesource.com/1810
Change subject: Currently the GWT compiler adds a var declaration for each
catch parameter in a try/catch statement, but this is unneeded according to
the spec, and the Closure compiler will issue
Ray Cromwell has posted comments on this change.
Change subject: Make AnimationScheduler configurable and change defaults.
..
Patch Set 3:
// TODO: register a Disposable when unloadModule patch lands
--
To view, visit https
Not using the most efficient implementation by default seems overly
harsh and likely to bias people against using GWT, so I tend to side
with making the efficient one the default. Javascript programmers
would usually react differently, by doing capability tests, and
selecting the appropriate
How would you deal with re-entrancy though, e.g.
Java - JS - Java - JS
If you simulate a synchronous call from JS to Java by breaking, what
happens when Java calls back into JS? Everytime I thought about doing
this, it basically boils down to emulating continuations with CPS
transform, and that
https://gwt-review.googlesource.com/#/c/1300/1
On Wed, Nov 28, 2012 at 11:02 AM, Stephen Haberman
step...@exigencecorp.com wrote:
Chrome 24 introduced a bug, I'm working on a fix.
Awesome, thanks for the quick reply--I updated the issue appropriately.
- Stephen
--
Chrome 24 introduced a bug, I'm working on a fix.
On Wed, Nov 28, 2012 at 10:40 AM, Stephen Haberman
step...@exigencecorp.com wrote:
Hey,
I'm (finally) playing with super dev mode and am not seeing source maps
working--I'm using Chrome 25 and saw this bug:
Usually in other part of the compiler, that is called 'ComponentType'
or 'ElementType'
On Wed, Nov 21, 2012 at 11:28 AM, skybr...@google.com wrote:
http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java
File
Awesome, I wondering if this effects the recurring bug we get with object ids.
On Thu, Oct 25, 2012 at 4:05 PM, skybr...@google.com wrote:
Reviewers: mdempsky,
Description:
Chrome plugin: don't use an iterator after the underlying entry has been
freed.
Rebuilt Windows DLL and created a
If you really want to do this, I'd advocate just shadowing the class
put super-sourcing your own implementation of java.lang.Class.
Probably adding an empty method that always returns null is safe,
because it'll just be promoted to a global static function and inlined
as 'null', e.g.
I don't think it's a matter of simple character replacement once
something has been serialized to JSON string. For example, these
encoders will typically escape '\' character, but if there are already
legal escape sequences in the string, it will end up double-escaping
the payload leading to
, October 13, 2012 12:30:24 PM UTC+2, Ray Cromwell wrote:
I don't think it's a matter of simple character replacement once
something has been serialized to JSON string. For example, these
encoders will typically escape '\' character, but if there are already
legal escape sequences in the string
I have .iprs/.imls/.iws's for it and a .idea directory. I'll see if I
can sanitize them and send them to you.
On Wed, Oct 10, 2012 at 6:08 AM, Konstantin Solomatov
konstantin.soloma...@gmail.com wrote:
Hello,
I want to contribute to GWT, however, I've got problems with setting a
project up.
I believe IntelliJ has the capability now for path variables. It was
added some time ago, but probably after you and Toby looked into it.
On Wed, Oct 10, 2012 at 2:50 PM, John A. Tamplin j...@jaet.org wrote:
On Wed, Oct 10, 2012 at 4:34 PM, Ray Cromwell cromwell...@google.com
wrote:
I have
LGTM. I mean, ideally it would be src/main/java :), but Maven can cope
with any directory name for this.
On Mon, Sep 17, 2012 at 11:36 AM, skybr...@google.com wrote:
Reviewers: cromwellian,
Description:
In the Chrome plugin, rename src to java for compatibility with
Google's internal build
Appreciate any further suggestions for cleaning up memory usage. The
additional of Disposable roughly parallels the same use in
JSCompiler's Closure Library. In theory. V8's GC should be good enough
to clean up everything if you just blow away the script tag and
iframe and remove the DOM elements,
and build every version between GWT 2.5rc1 and GWT 2.4 to get a better
feeling for what the actual commit is and if this is something we need to
look further?! What do you think?
-Daniel
Am 12.09.2012 um 00:03 schrieb Ray Cromwell cromwell...@google.com:
I finally tracked
that somehow the CSS for the blackberry permutation is
ending up in the iPhone permutation. That can't just be a Cell Widget issue.
On Mon, Jul 23, 2012 at 12:24 AM, Ray Cromwell cromwell...@google.com
wrote:
Are you using any Cell widgets by any chance?
I've seen that the Mail sample
Thomas, thanks for all of the work on this, but we will have to delay
this until after we get the open-source git/gerrit repo up and
running. A preliminary investigation of internal Google apps shows a
bunch of them still relying on EventListener, so we'll have to create
an uber-patch to fix all
In ordinary cases where there is no API change, I don't think the
problem is so severe. But removing APIs, even deprecated ones, is
always hard, just look at the Web and the debates over vendor
prefixes. At Google we do have tools that help with 'company wide
refactoring', the EventListener issue
We are discussing right now cherry picking it into 2.5
On Fri, Aug 17, 2012 at 1:18 AM, jens.nehlme...@gmail.com wrote:
Nice, any chance that it will make its way into 2.5 Final?
http://gwt-code-reviews.appspot.com/1811803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I don't understand why the dual flags, but I would not make it a proper
compiler flag because there are some static clinit inits in compiler
classes that need to know whether coverage is enabled when the classes are
loaded.
On Tue, Jul 24, 2012 at 4:13 PM, skybr...@google.com wrote:
Are you using any Cell widgets by any chance?
I've seen that the Mail sample and ShowCase sample both shrunk, but the
MobileWebApp sample increased in size. This leads me to believe it's not a
compilation issue, but something in the user library pulling in a lot of
extra code.
--
Sorry I've been at I/O all week, I will take a look at this as soon as I
can.
On Thu, Jun 28, 2012 at 5:30 PM, isbad...@google.com wrote:
http://gwt-code-reviews.**appspot.com/1764803/http://gwt-code-reviews.appspot.com/1764803/
--
Post 2.5 we can fix the no op build, the shell script needs to be axed
in favor of separate tasks, because
1) elemental_freemontcutbuilder only depends on third_party/WebCore,
elemental.idl, and the direct idl* and database.py files. It produces
a python pickle cache as output
2)
BTW, the internal genrule seems to work properly and not rebuild everytime
On Fri, Jun 15, 2012 at 12:24 PM, Ray Cromwell cromwell...@google.com wrote:
Post 2.5 we can fix the no op build, the shell script needs to be axed
in favor of separate tasks, because
1) elemental_freemontcutbuilder
I fixed those already but unfortunately it looks like the Google -
SVN mirror is stuck again. opps, no, my internal commit failed to
through) I'll accept your solution because it's better than copying
(doesn't pollute your SVN directories)
-Ray
On Thu, Jun 14, 2012 at 2:46 PM,
In particular, elemental will not build on a Windows box or an OSX box
that does not have XCode installed. The requirements for the code-gen
are Python 2.6 pre-installed and gcc pre-installed. So I don't think
we can add it to the default built, but rather, we will distribute the
jar in the 2.5
, the real problem now is that it is a
pain to use with gwt-rpc because I have to deal with generated *.gwt.rpc
files.
--
Inviato con Sparrow
Il giorno sabato 9 giugno 2012, alle ore 21:26, Ray Cromwell ha scritto:
BTW, can you send me the speedtracer.html file in your
/tmp/*codeserver
...@gmail.com wrote:
My app is 60 lines of code and compiles in 120 seconds: a lot of
uibinder, a lot of classes in rpc, gin… so a lots of generators.
--
Sent with Sparrow
Il giorno venerdì 8 giugno 2012, alle ore 22:38, Ray Cromwell ha scritto:
I just checked again, one of the internal
of generators.
--
Sent with Sparrow
Il giorno venerdì 8 giugno 2012, alle ore 22:38, Ray Cromwell ha scritto:
I just checked again, one of the internal apps we are trying
SuperDevMode against has about 400,000 lines of code and combines in
about 7-8 seconds. So maybe your app has 6x as much code
How big is your app? (KLOC) Internally, we'd had success with 10s
refresh on some fairly largish apps. I'm wondering if something else
isn't going on. Note that the first compile usually takes long, but
subsequent ones are faster. Are you using UiBinder? One issue could be
generators using too
.
-Ray
On Fri, Jun 8, 2012 at 12:09 PM, Ray Cromwell cromwell...@google.com wrote:
How big is your app? (KLOC) Internally, we'd had success with 10s
refresh on some fairly largish apps. I'm wondering if something else
isn't going on. Note that the first compile usually takes long, but
subsequent
for the first compile from the browser, and
then consistently 18-19 seconds thereafter.
Paul
On 08/06/12 21:38, Ray Cromwell wrote:
I just checked again, one of the internal apps we are trying
SuperDevMode against has about 400,000 lines of code and combines in
about 7-8 seconds. So maybe your app
compile was 62s
(instead of 3 minutes), then compiling from the browser took 18.4s, 16.8s,
17.0s, 17.4s, 15.4s, 16.8s, 16.0s
I did add a -Dgwt.speedtracerlog=/tmp/superdevmode.json argument, but no
file was produced.
HTH
Paul
On 08/06/12 22:12, Ray Cromwell wrote:
Hmm, that's still
Boy will this be a hard one to fix without a stable repro case. I hope
you keep around a repeatable broken build. The code responsible for
generating prototype assignments is here, you can see:
Over the past year, the GWT team did lose some people (Ray Ryan/Bob
Vawter), some moved to other projects, and some recently left for a startup
(Bruce/Joel/Kelly). One of our team members went for maternity leave, as a
result, we didn't have enough resources to simultaneously focus on the
If I told you the number of monthly active GWT developers, I think you
would be quite impressed. A hangout sounds like a good idea, I will look
into setting one up soon.
-Ray
On Friday, April 20, 2012 4:15:27 PM UTC-7, Joshua Kappon wrote:
Thanks for commenting Ray (and also for keeping us
Can you summarize the implementation differences?
On Tue, Apr 17, 2012 at 11:08 AM, Chris Ruffalo chris.ruff...@gmail.com wrote:
We've been over this before, I think, and several problems have gotten in
the way. It's not that we don't want to cooperate, we do, but I think that
it's too
I believe we are getting an intern to finish this soon.
-Ray
On Mon, Apr 2, 2012 at 6:55 AM, Jens jens.nehlme...@gmail.com wrote:
Hi,
what is the current status/future plans of GWT's bean validation (JSR303)?
Looking at the issue tracker (issues labeled jsr303) it seems like that its
half
I agree with most of this, but I just wanted to mention that I think
breaking up the dependency chain will be a little tricky for maven
when it comes to tests. Maven general practice is that a given module
contains its tests and runs them. The problem with gwt-dev and
gwt-user is that many of the
Greetings Contributors,
First an apology, I realize many of you have put a lot of work into
contributing to GWT, and we haven't exactly been speedy in picking
these up. There's been turnover and reorgs, and some of the original
code reviewers have left the team, or even left Google, and so some
Sorry to hear that. This is actually on our list of priorities for
GWT, so we will have to take this up internally.
On Wed, Feb 1, 2012 at 4:44 AM, Thomas Broyer t.bro...@gmail.com wrote:
On Wed, Feb 1, 2012 at 1:16 PM, Daniel Kurka
kurka.dan...@googlemail.com wrote:
Thomas are you doing
How could I refuse? :) SGTM. We will of course, still have to
maintain all of the GWT-isms. Actually, I've been wondering if we
shoudn't just adopt LESS or SASS extensions too.
-Ray
On Fri, Dec 9, 2011 at 6:40 AM, Thomas Broyer t.bro...@gmail.com wrote:
Hi all,
CssResource uses Flute to
Note also that sometimes we have to rollback or patch something in an
emergency that has broken important internal apps, so we will often
rollback or quickfix these without the regular delay of going through
the public issue tracker, but hopefully these are rare instances.
-Ray
On Wed, Dec 7,
Oops, ok, I'll update it this afternoon.
-Ray
On Sun, Nov 27, 2011 at 7:44 AM, Thomas Broyer t.bro...@gmail.com wrote:
r10760 uses com.google.gwt.thirdparty.debugging.sourcemap
but ${gwt.tools.lib}/jscomp/sourcemap-rebased.jar still contains
com.google.debugging.sourcemap.
Could someone
Awesome job Manuel, taking this project from a proof of concept to a
rock solid library!
-Ray
On Wed, Oct 26, 2011 at 10:38 AM, Manuel Carrasco Moñino
man...@apache.org wrote:
The GQuery team is proud to announce the version 1.1.0 of the library.
We have been working hard in order to fix
Maybe it is GC driven, if you have N threads each with a copy of all
of the Strings in the program, collections take longer?
-Ray
On Tue, Oct 25, 2011 at 8:11 PM, Toby Reyelts to...@google.com wrote:
This is a little too surprising. ThreadLocal accesses are very fast (think
1us).
On Tue,
You could try making a split point which contains other split points,
something like this:
I = Initial Fragment
W - Split point from which all Widget using splitpoints exist
W1 - Widget using split point 1
W2 - Widget using split point 2
G - Split point from which all GQuery
The problem of detecting common code and putting them into shared
fragments of certain size is related to the Graph Partitioning
Problem, like many compiler problems, which is NP-Complete. That
doesn't mean it can't be done, Alan Leung is working on this for the
next release, it just means it has
We've considered it, but all of the benefit of DevMode (avoiding recompile)
goes out the window. If you change code, you have to recompile, so the whole
edit-refresh cycle takes a lot longer.
If you really just want source-level debugging of compiled GWT apps, this
can be done with SourceMaps:
And doing continuation transformations for loop constructs is extra difficult.
One possibility is to just use Rhino/HtmlUnit for everything and proxy
all browser API calls, not to an emulated DOM, but do C++ DOM IDL
bindings. This is sort of like Python-WebKit/Pyjamas. So we don't
emulate the
Alan Leung of the GWT team is working on a partial fix for this, called
Automatic Fragment Merging, it merges together fragments automatically in
order to reduce the size of leftovers while increasing the size of the
exclusive fragments (which in many cases are too small and should be
bigger). If
On Mon, Aug 15, 2011 at 9:58 AM, stephen.haber...@gmail.com wrote:
If you mean the Roll seed-function optimization forward again commit
[1] (or others before it), yeah, I was hoping that would fix it, but it
did not.
It surprises me that CFA doesn't take care of this and that it needs
to be
Changed JsSeedIdOf to hold the seedId (assigned by
GenerateJavaScriptAST) instead of lazily retrieving the seedId via
JsName earlier (which will be null if it is a not-instantiated class
type) Also changed JsToSourceGenerationVisitorWithSizeBreakdown to
print the new JsSeedIdOf.
Everything else
You commented in the issue tracker that the JsInliner is not the
issue, the obfuscator is the problem, so why the patch to Inliner?
On Thu, Jul 7, 2011 at 5:09 PM, jbrosenb...@google.com wrote:
Reviewers: cromwellian, zundel, scottb,
Description:
Fix JsInliner, to properly handle name scope
Oops, there's a problem, I need one more cycle before I can commit.
Will send patch tonite. :(
On Fri, Jul 1, 2011 at 1:43 PM, cromwell...@google.com wrote:
I made the fixes and submitted it. Since most people are headed out of
the office for the holiday, I need to get it in early to see if
I think it should work, Consider how this would cause weird bugs.
Someone has code that works as a SingleJso, but then he imports a
module which provides a Java implementation, and now all of a sudden
he gets ASEs?
On Tue, Jun 28, 2011 at 11:31 AM, Jason Rosenberg
jbrosenb...@google.com wrote:
Looking at Array.setCheck() it seems this was never supported. What we
can do is create a Array.setCheckAllowJso() method, and then insert a
call to either setCheck or setCheckAllowJso depending on whether or
not the array element type is a single JSO impl. setCheckAllowJso
would be identical to
BTW Scott, I know you might have liked this as three separate CLs,
unfortunately, I did the refactoring work by iterating continuously on
the three separate items (seed funcs, class literals, and injection of
code), and there were interdependencies (when I changed seed func
code, I had to update
http://gxtvsgwt.appspot.com/
Most gxt widgets are 3x to 10x slower to render. GWT Cell Widgets,
while complex, ensure that they scale to large UIs.
-Ray
On Tue, May 17, 2011 at 2:57 PM, dmen dmenou...@gmail.com wrote:
Dear GWT team,
Once again I feel this unbearable need to complain about
Sorry for the delay, spent most of today catching up after I/O, I will
take care of these Friday.
On Tue, May 10, 2011 at 6:44 PM, sco...@google.com wrote:
This is ready for review now.
http://gwt-code-reviews.appspot.com/1436802/
--
As long as the JsInliner can still clean it up, I'm fine, otherwise, it
seems like it would introduce some bloat by having trivial delegations. I'm
actually wondering if we should detect the case when a static method ONLY is
referenced by the instance method it was created from via delegation, and
That sounds better, but is there a reason why JavaScriptObjectNormalizer was
doing this pre-optimization in the first place?
Anyway, in favor of keeping the 'null instanceof JSO' behavior is that the
following code currently will not do a null check either:
SomeJso foo = getNull();
So your proposal is something like this:
setupVtable(castableTypeMap, someSuperCtor, ctor1, ctor2);
function setupVtable(ctm, supCtor) {
var newProto = {};
copyProtoFields(someSuperCtor.prototype, newProto);
for(var i = 2; i arguments.length; i++) {
arguments[i].prototype =
On Thu, Feb 17, 2011 at 5:19 PM, Scott Blum sco...@google.com wrote:
Something like that, yep. Just need to figure out what to do if there
aren't any super ctors (maybe they got inlined?).
- Use ids after all?
- Make a synthetic super ctor just for this purpose?
- Just attach super symbols
Full change comment: Changes trampoline function to use instance of
JavaScriptObject. Modifies TypeTightener and CastNormalizer to cleanup dead
trampolines. Controversial change: jsoType instanceof JavaScriptObject is
allowed to be replaced with a literal true rather than jsoType != null,
since
LGTM
On Mon, Feb 7, 2011 at 12:15 PM, Eric Ayers zun...@google.com wrote:
I don't have anything else.
On Mon, Feb 7, 2011 at 2:24 PM, sco...@google.com wrote:
Did you guys want to re-review, or having fixed the things you
mentioned, is this LGTM?
101 - 200 of 418 matches
Mail list logo
