[gwt-contrib] Re: Issue 6834 Geolocation API Bug (issue1563803)

LGTM http://gwt-code-reviews.appspot.com/1563803/diff/1/user/src/com/google/gwt/geolocation/client/Geolocation.java File user/src/com/google/gwt/geolocation/client/Geolocation.java (right):

[gwt-contrib] Re: Use LinkedHashMap instead of HashMap so that the methods returned by getAllInterfaceMethods() ar... (issue1549803)

LGTM http://gwt-code-reviews.appspot.com/1549803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Geolocation support in GWT (issue1451811)

See also a previous attempt: http://gwt-code-reviews.appspot.com/1060801/ http://gwt-code-reviews.appspot.com/1451811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix various warnings. (issue1446804)

LGTM http://gwt-code-reviews.appspot.com/1446804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First example of a View that kicks off its own presenter as (issue1446806)

LGTM http://gwt-code-reviews.appspot.com/1446806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix checkstyle 'info' warnings (issue1446803)

Reviewers: rjrjr, Description: Fix checkstyle 'info' warnings Please review this at http://gwt-code-reviews.appspot.com/1446803/ Affected files: M dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java M

[gwt-contrib] Experimental attempt to add EventBus support to Widgets (issue1447804)

Reviewers: rjrjr, Description: Experimental attempt to add EventBus support to Widgets Modify the MobileWebApp sample to use the new feature Please review this at http://gwt-code-reviews.appspot.com/1447804/ Affected files: M

[gwt-contrib] Re: Adding drag and drop support to the mobile web app. The desktop TaskEditView now has a list of t... (issue1420811)

LGTM http://gwt-code-reviews.appspot.com/1420811/diff/2001/user/src/com/google/gwt/event/dom/client/DragEndEvent.java File user/src/com/google/gwt/event/dom/client/DragEndEvent.java (right):

[gwt-contrib] Add a convenience base class for value type locators (issue1428809)

Reviewers: rjrjr, robertvawter, Description: Add a convenience base class for value type locators Please review this at http://gwt-code-reviews.appspot.com/1428809/ Affected files: A user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java Index:

[gwt-contrib] Remove duplicate build target (issue1423812)

Reviewers: rjrjr, Description: Remove duplicate build target Please review this at http://gwt-code-reviews.appspot.com/1423812/ Affected files: M build.xml Index: build.xml === --- build.xml (revision 10116) +++ build.xml

[gwt-contrib] Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls (issue1425807)

Reviewers: jat, Description: Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls Please review this at http://gwt-code-reviews.appspot.com/1425807/ Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java M

[gwt-contrib] Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls (issue1426802)

Reviewers: jat, Description: Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls Use constants from TreeLogger rather than accessing TreeLogger.Type directly where possible Please review this at http://gwt-code-reviews.appspot.com/1426802/ Affected files: M

[gwt-contrib] Update package of RequestFactoryJreSuite (issue1416802)

Reviewers: rchandia, Description: Update package of RequestFactoryJreSuite Please review this at http://gwt-code-reviews.appspot.com/1416802/ Affected files: M user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java Index:

[gwt-contrib] Escape single characters in SafeHtmlBuilder/SafeHtmlUtils (external issue 6222) (issue1413802)

Reviewers: pdr, xtof, Description: Escape single characters in SafeHtmlBuilder/SafeHtmlUtils (external issue 6222) Please review this at http://gwt-code-reviews.appspot.com/1413802/ Affected files: M user/src/com/google/gwt/safehtml/shared/SafeHtmlBuilder.java M

[gwt-contrib] Change RequestFactoryMagic - RequestFactorySource in comment (issue1406801)

Reviewers: robertvawter, Description: Change RequestFactoryMagic - RequestFactorySource in comment Please review this at http://gwt-code-reviews.appspot.com/1406801/ Affected files: M user/src/com/google/web/bindery/requestfactory/server/testing/InProcessRequestTransport.java Index:

[gwt-contrib] Re: Reformat autobeans package to cut down on diff churn for lazy reification patch. (issue1407801)

LGTM http://gwt-code-reviews.appspot.com/1407801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Convert AutoBeans to use JSOs as their backing store with lazy reification of (issue1407802)

LGTM I think you probably meant codec rather than codex, but I can understand if this name change would be too much at this point. I hate the word reify, I don't really understand what it means and I doubt 99% of our users will either. Can you add a juicy comment somewhere that explains what

[gwt-contrib] Fix build break (issue1404802)

Reviewers: rchandia, Description: Fix build break Please review this at http://gwt-code-reviews.appspot.com/1404802/ Affected files: M requestfactory/build.xml M user/src/com/google/web/bindery/requestfactory/RequestFactory.gwt.xml Index: requestfactory/build.xml

[gwt-contrib] Move RequestFactory to com.google.web.bindery.requestfactory (issue1403802)

Reviewers: robertvawter, Description: Move RequestFactory to com.google.web.bindery.requestfactory Please review this at http://gwt-code-reviews.appspot.com/1403802/ Affected files: M build.xml A requestfactory/build.xml M

[gwt-contrib] Move com.google.gwt.requestfactory to com.google.requestfactory (issue1383808)

Reviewers: robertvawter, Description: Move com.google.gwt.requestfactory to com.google.requestfactory Keep a deprecated version in the old location Add targets for requestfactory client, server, and JRE test jars Please review this at http://gwt-code-reviews.appspot.com/1383808/ Affected

[gwt-contrib] Re: Small optimizations for hosted mode (issue1382801)

http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java File dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java (right):

[gwt-contrib] Re: Small optimizations for hosted mode (issue1382801)

http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java File dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java (right):

[gwt-contrib] Fix docs/warnings (issue1380805)

Reviewers: jat, Description: Fix docs/warnings Please review this at http://gwt-code-reviews.appspot.com/1380805/ Affected files: M dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java M dev/core/src/com/google/gwt/core/ext/Linker.java M

[gwt-contrib] Fix EZT formatting (issue1367803)

Reviewers: doog, Description: Fix EZT formatting Please review this at http://gwt-code-reviews.appspot.com/1367803/ Affected files: M build-tools/doctool/src/com/google/doctool/custom/EztDoclet.java Index: build-tools/doctool/src/com/google/doctool/custom/EztDoclet.java

[gwt-contrib] Fix compilation on JDK 1.5 (issue1369802)

Reviewers: jat, Description: Fix compilation on JDK 1.5 Please review this at http://gwt-code-reviews.appspot.com/1369802/ Affected files: M user/src/com/google/gwt/user/server/rpc/XsrfProtectedServiceServlet.java M user/src/com/google/gwt/user/server/rpc/XsrfTokenServiceServlet.java M

[gwt-contrib] Add fields to EZT doclet output (issue1372801)

Reviewers: fabbott, Description: Add fields to EZT doclet output Please review this at http://gwt-code-reviews.appspot.com/1372801/ Affected files: M build-tools/doctool/src/com/google/doctool/custom/EztDoclet.java Index: build-tools/doctool/src/com/google/doctool/custom/EztDoclet.java

[gwt-contrib] Re: Fix compilation on JDK 1.5 (issue1369802)

http://gwt-code-reviews.appspot.com/1369802/diff/1/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java File user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java (right):

[gwt-contrib] Add java.math and java.util.logging to list of packages to document (issue1358802)

Reviewers: jat, Description: Add java.math and java.util.logging to list of packages to document Please review this at http://gwt-code-reviews.appspot.com/1358802/show Affected files: M build-tools/doctool/src/com/google/doctool/custom/FindPackages.java Index:

[gwt-contrib] Re: Add java.math and java.util.logging to list of packages to document (issue1358802)

http://gwt-code-reviews.appspot.com/1358802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Optimize redundant 'switch' statements (issue1311801)

Reviewers: scottb, Description: Optimize redundant 'switch' statements Fix bug caused by using short idents when matching case bodies Please review this at http://gwt-code-reviews.appspot.com/1311801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java

[gwt-contrib] Re: Add optimizations for redundant and trivial 'switch' statements (issue1286801)

http://gwt-code-reviews.appspot.com/1286801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add optimizations for redundant and trivial 'switch' statements (issue1286801)

Reviewers: scottb, robertvawter, Description: Add optimizations for redundant and trivial 'switch' statements Please review this at http://gwt-code-reviews.appspot.com/1286801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java A

[gwt-contrib] Re: Initial version of HTML5 Audio and Video (issue1195801)

http://gwt-code-reviews.appspot.com/1195801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Dev mode resource loading speed up (issue1262802)

http://gwt-code-reviews.appspot.com/1262802/diff/1/2 File dev/core/src/com/google/gwt/dev/util/Util.java (right): http://gwt-code-reviews.appspot.com/1262802/diff/1/2#newcode982 dev/core/src/com/google/gwt/dev/util/Util.java:982: public static String[] split(String s, char separatorChar) { Have

[gwt-contrib] Re: Initial version of HTML5 Audio and Video (issue1195801)

http://gwt-code-reviews.appspot.com/1195801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes rebased guava library without using JarJar (issue1213801)

LGTM http://gwt-code-reviews.appspot.com/1213801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Expand self-closing div/ tag in SafeHtmlTemplate into separate open and close (issue1209801)

LGTM http://gwt-code-reviews.appspot.com/1209801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Initial version of HTML5 Audio and Video (issue1195801)

http://gwt-code-reviews.appspot.com/1195801/diff/1/10 File user/src/com/google/gwt/media/dom/client/MediaElement.java (right): http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode119 user/src/com/google/gwt/media/dom/client/MediaElement.java:119: * source have been buffered locally.

[gwt-contrib] Re: Initial version of HTML5 Audio and Video (issue1195801)

http://gwt-code-reviews.appspot.com/1195801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change floats to doubles and work around a firefox bug. (issue1192801)

LGTM http://gwt-code-reviews.appspot.com/1192801/diff/1/3 File user/src/com/google/gwt/canvas/dom/client/Context2d.java (right): http://gwt-code-reviews.appspot.com/1192801/diff/1/3#newcode240 user/src/com/google/gwt/canvas/dom/client/Context2d.java:240: this.arc(x, y, radius, startAngle,

[gwt-contrib] Initial version of HTML5 Audio and Video (issue1195801)

Reviewers: pdr, Description: Initial version of HTML5 Audio and Video Please review this at http://gwt-code-reviews.appspot.com/1195801/show Affected files: M user/src/com/google/gwt/canvas/client/package-info.java M user/src/com/google/gwt/canvas/dom/client/package-info.java A

[gwt-contrib] Fix external issues 5521, 5446, 5332, javadoc links (issue1186801)

Reviewers: rchandia, Description: Fix external issues 5521, 5446, 5332, javadoc links Please review this at http://gwt-code-reviews.appspot.com/1186801/show Affected files: M user/src/com/google/gwt/dom/client/OptionElement.java M user/src/com/google/gwt/dom/client/Touch.java M

[gwt-contrib] Remove a couple of JDK 1.6-isms (issue1178801)

Reviewers: rchandia, Description: Remove a couple of JDK 1.6-isms Please review this at http://gwt-code-reviews.appspot.com/1178801/show Affected files: M dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java M user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java Index:

[gwt-contrib] Re: Improve Canvas 2D documentation (issue1165801)

http://gwt-code-reviews.appspot.com/1165801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix double escaping of HTML characters in Javadoc (issue1173801)

Reviewers: pdr, Description: Fix double escaping of HTML characters in Javadoc Please review this at http://gwt-code-reviews.appspot.com/1173801/show Affected files: M user/src/com/google/gwt/safehtml/client/SafeHtmlTemplates.java M user/src/com/google/gwt/safehtml/shared/SafeHtml.java

[gwt-contrib] Improve Canvas 2D documentation (issue1165801)

Reviewers: pdr, Description: Improve Canvas 2D documentation Please review this at http://gwt-code-reviews.appspot.com/1165801/show Affected files: M user/src/com/google/gwt/canvas/client/Canvas.java A user/src/com/google/gwt/canvas/client/package-info.java M

[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)

http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)

http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)

http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Experimental version of GeoLocation API (issue1060801)

Reviewers: pdr, Description: Experimental version of GeoLocation API Please review this at http://gwt-code-reviews.appspot.com/1060801/show Affected files: A user/src/com/google/gwt/experimental/geolocation/GeoLocation.java A

[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)

http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)

http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Reimplement RequestFactory client vs. domain validation using classfile analysis to support bett... (issue1049801)

LGTM http://gwt-code-reviews.appspot.com/1049801/diff/2001/3007 File user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java (right): http://gwt-code-reviews.appspot.com/1049801/diff/2001/3007#newcode163

[gwt-contrib] Re: Add package.html files (issue1027801)

http://gwt-code-reviews.appspot.com/1027801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Perform basic HMTL escaping for @example tag code (issue1026801)

Reviewers: jlabanca, Description: Perform basic HMTL escaping for @example tag code Please review this at http://gwt-code-reviews.appspot.com/1026801/show Affected files: M build-tools/doctool/src/com/google/doctool/custom/ExampleTaglet.java Index:

[gwt-contrib] Add package.html files (issue1027801)

Reviewers: jlabanca, Description: Add package.html files Add missing Javadoc Please review this at http://gwt-code-reviews.appspot.com/1027801/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M

[gwt-contrib] Re: Fixing IE6 CellTree bugs. Child nodes disappear after the open animation completes, and images ... (issue997801)

LGTM with 2 comments http://gwt-code-reviews.appspot.com/997801/diff/1/3 File user/src/com/google/gwt/user/cellview/client/CellTree.java (right): http://gwt-code-reviews.appspot.com/997801/diff/1/3#newcode479 user/src/com/google/gwt/user/cellview/client/CellTree.java:479: if (isIe6()) { Aren't

[gwt-contrib] Add missing javadoc for Editor framework (issue1002801)

Reviewers: robertvawter, Description: Add missing javadoc for Editor framework Please review this at http://gwt-code-reviews.appspot.com/1002801/show Affected files: M user/src/com/google/gwt/editor/client/AutoBean.java M user/src/com/google/gwt/editor/client/AutoBeanFactory.java M

[gwt-contrib] Add missing Javadoc (issue1004801)

Reviewers: rchandia, Description: Add missing Javadoc Please review this at http://gwt-code-reviews.appspot.com/1004801/show Affected files: M user/src/com/google/gwt/benchmarks/BenchmarkReport.java M user/src/com/google/gwt/benchmarks/BenchmarkShell.java M

[gwt-contrib] Add missing Javadoc for Cell packages (issue1005801)

Reviewers: jlabanca, Description: Add missing Javadoc for Cell packages Please review this at http://gwt-code-reviews.appspot.com/1005801/show Affected files: M user/src/com/google/gwt/cell/client/AbstractEditableCell.java M user/src/com/google/gwt/cell/client/AbstractSafeHtmlCell.java

[gwt-contrib] Re: Add missing javadoc for Editor framework (issue1002801)

http://gwt-code-reviews.appspot.com/1002801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Document limitations of current SafeHtmlTemplates code generator. (issue1006801)

LGTM with comments http://gwt-code-reviews.appspot.com/1006801/diff/1/2 File user/src/com/google/gwt/safehtml/client/SafeHtmlTemplates.java (right): http://gwt-code-reviews.appspot.com/1006801/diff/1/2#newcode53 user/src/com/google/gwt/safehtml/client/SafeHtmlTemplates.java:53: * {...@code

[gwt-contrib] Clean up Place and RequestFactory javadoc (issue1009801)

Reviewers: rjrjr, Description: Clean up Place and RequestFactory javadoc Specify a charset in base64 encoding/decoding in JsonRequestProcessor Please review this at http://gwt-code-reviews.appspot.com/1009801/show Affected files: M user/src/com/google/gwt/app/rebind/package.html M

[gwt-contrib] Re: Minor tweaks for dynatablerd and showcase. (issue990801)

LGTM http://gwt-code-reviews.appspot.com/990801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing a few logic and usability bugs in Cell Widgets. CellTree items are now easier to click. ... (issue995801)

LGTM http://gwt-code-reviews.appspot.com/995801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Relaxing the data parameter of HasData#setRowData() from a ListT to a List? extends T. (issue994801)

LGTM http://gwt-code-reviews.appspot.com/994801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing a bug where headers are not redrawn when the data changes. I was trying to be crafty and... (issue971801)

LGTM http://gwt-code-reviews.appspot.com/971801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Remove 'experimental' javadoc warnings (issue986801)

Reviewers: rchandia, Description: Remove 'experimental' javadoc warnings Please review this at http://gwt-code-reviews.appspot.com/986801/show Affected files: M user/src/com/google/gwt/activity/shared/AbstractActivity.java M user/src/com/google/gwt/activity/shared/Activity.java M

[gwt-contrib] Use Java to generate the list of packages for javadoc (issue980803)

Reviewers: jat, Description: Use Java to generate the list of packages for javadoc Please review this at http://gwt-code-reviews.appspot.com/980803/show Affected files: A build-tools/doctool/src/com/google/doctool/custom/FindPackages.java M doc/build.xml D doc/find-packages.sh --

[gwt-contrib] Re: Replace I generics with T to prevent italics in javadoc. (issue982801)

LGTM with 2 comments http://gwt-code-reviews.appspot.com/982801/diff/1/13 File user/src/com/google/gwt/view/client/RangeChangeEvent.java (right): http://gwt-code-reviews.appspot.com/982801/diff/1/13#newcode51 user/src/com/google/gwt/view/client/RangeChangeEvent.java:51: public static T void

[gwt-contrib] Use a static packages.properties file on non-Unix OSes (issue983801)

Reviewers: jat, Description: Use a static packages.properties file on non-Unix OSes Please review this at http://gwt-code-reviews.appspot.com/983801/show Affected files: M doc/build.xml A doc/packages.properties.static -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Javadoc cleanup (issue985801)

Reviewers: pdr, Description: Javadoc cleanup Please review this at http://gwt-code-reviews.appspot.com/985801/show Affected files: M user/src/com/google/gwt/activity/shared/ActivityManager.java M user/src/com/google/gwt/activity/shared/ActivityMapper.java M

[gwt-contrib] Restore previously rolled-back doc build changes (issue970801)

Reviewers: conroy, Description: Restore previously rolled-back doc build changes Please review this at http://gwt-code-reviews.appspot.com/970801/show Affected files: M doc/build.xml A doc/find-packages.sh A doc/json-package-list/package-list D doc/packages.properties A

[gwt-contrib] Re: Fixing a bug where headers are not redrawn when the data changes. I was trying to be crafty and... (issue971801)

FYI http://gwt-code-reviews.appspot.com/971801/diff/1/2 File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/971801/diff/1/2#newcode1173 user/src/com/google/gwt/user/cellview/client/CellTable.java:1173: if (curColumn == 0) { You can't

[gwt-contrib] Re: Fixing a bug where headers are not redrawn when the data changes. I was trying to be crafty and... (issue971801)

http://gwt-code-reviews.appspot.com/971801/diff/1/3 File user/test/com/google/gwt/user/cellview/client/CellTableTest.java (left): http://gwt-code-reviews.appspot.com/971801/diff/1/3#oldcode23 user/test/com/google/gwt/user/cellview/client/CellTableTest.java:23: public class CellTableTest extends

[gwt-contrib] Create the list of packages to javadoc dynamically (issue944802)

Reviewers: jat, Description: Create the list of packages to javadoc dynamically Link out to JSON and JSR 303 javadoc on the Web Please review this at http://gwt-code-reviews.appspot.com/944802/show Affected files: M doc/build.xml A doc/find-packages.sh A

[gwt-contrib] Re: Create the list of packages to javadoc dynamically (issue944802)

http://gwt-code-reviews.appspot.com/944802/diff/1/3 File doc/find-packages.sh (right): http://gwt-code-reviews.appspot.com/944802/diff/1/3#newcode38 doc/find-packages.sh:38: LANG_PKGS=\\ We are generating a file that will have backslashes at the end of its lines. On 2010/10/06 20:19:10, jat

[gwt-contrib] Clean up Cell-related javadoc (issue966801)

Reviewers: jlabanca, Description: Clean up Cell-related javadoc Please review this at http://gwt-code-reviews.appspot.com/966801/show Affected files: M user/javadoc/com/google/gwt/examples/cellview/CellBrowserExample2.java M

[gwt-contrib] Miscellaneous Javadoc fixes: (issue967801)

Reviewers: rchandia, Description: Miscellaneous Javadoc fixes: Use 'Returns X.' instead of @return X by itself in order to have something appear in the summary field. Spelling Please review this at http://gwt-code-reviews.appspot.com/967801/show Affected files: M

[gwt-contrib] Re: Fix 'ant dist-dev' and 'ant-doc' builds: (issue953801)

http://gwt-code-reviews.appspot.com/953801/diff/1/5 File user/src/com/google/gwt/requestfactory/client/impl/messages/JsonResults.java (right): http://gwt-code-reviews.appspot.com/953801/diff/1/5#newcode28 user/src/com/google/gwt/requestfactory/client/impl/messages/JsonResults.java:28: // javac

[gwt-contrib] Re: Fix 'ant dist-dev' and 'ant-doc' builds: (issue953801)

http://gwt-code-reviews.appspot.com/953801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix Eclipse / Checkstyle / Javadoc warnings (issue954801)

http://gwt-code-reviews.appspot.com/954801/diff/1/6 File dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java (right): http://gwt-code-reviews.appspot.com/954801/diff/1/6#newcode91 dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java:91: * Return a human readable string

[gwt-contrib] Avoid an infinite loop in toString() for collections that directly include themselves (issue962801)

Reviewers: jat, Description: Avoid an infinite loop in toString() for collections that directly include themselves Please review this at http://gwt-code-reviews.appspot.com/962801/show Affected files: M user/super/com/google/gwt/emul/java/util/AbstractCollection.java Index:

[gwt-contrib] Fix 'ant dist-dev' and 'ant-doc' builds: (issue953801)

Reviewers: fabbott, Description: Fix 'ant dist-dev' and 'ant-doc' builds: 1) Add memory to java heap for 'gwt.javac' 2) Break up a line in JsonResults that caused javac to exit 3) Remove an annotation in SafeHtmlHostedModeUtils that caused javadoc to crash 4) Update the list of packages for

[gwt-contrib] Fix Eclipse / Checkstyle / Javadoc warnings (issue954801)

Reviewers: jat, Description: Fix Eclipse / Checkstyle / Javadoc warnings Please review this at http://gwt-code-reviews.appspot.com/954801/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java M dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java M

[gwt-contrib] Re: Changes the default row count of HasDataPresenter from Integer.MIN_VALUE to a more reasonable 0.... (issue950802)

LGTM http://gwt-code-reviews.appspot.com/950802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix nonstandard two method handler interface that probably would have (issue941801)

LGTM http://gwt-code-reviews.appspot.com/941801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converting MultiWordSuggestOracle to use SafeHtml to escape suggestions, and fixing fixing broke... (issue938801)

LGTM http://gwt-code-reviews.appspot.com/938801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes some bugs in CellBrowser. CellBrowser#setChildState() was exited early too aggressively, ... (issue942801)

LGTM http://gwt-code-reviews.appspot.com/942801/diff/1/3 File user/src/com/google/gwt/user/cellview/client/CellList.java (right): http://gwt-code-reviews.appspot.com/942801/diff/1/3#newcode472 user/src/com/google/gwt/user/cellview/client/CellList.java:472: * Called when the user selects a cell

[gwt-contrib] Re: Fix the hack in RequestFactoryGenerator. (issue935801)

LGTM http://gwt-code-reviews.appspot.com/935801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Use generics for EntityProxyId (issue888802)

Reviewers: rjrjr, cromwellian, amitmanjhi, Description: Use generics for EntityProxyId This affects the public API of FindRequest, which requires generator changes Clean up generics in general Remove some other warnings Please review this at http://gwt-code-reviews.appspot.com/02/show

[gwt-contrib] Re: Element.getTabIndex() returns undefined on Safari 3 for non-focusable elements, including divs, ... (issue905802)

LGTM http://gwt-code-reviews.appspot.com/905802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add base64 encoding to JsonRequestProcessor and change the delimiter to the '!' character. (issue908801)

http://gwt-code-reviews.appspot.com/908801/diff/1/5 File user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java (right): http://gwt-code-reviews.appspot.com/908801/diff/1/5#newcode192 user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java:192: String schemaAndId[] =

[gwt-contrib] Re: Adds additional keyboard support in Cell Widgets. CellList and CellTable now support page down/u... (issue906801)

LGTM http://gwt-code-reviews.appspot.com/906801/diff/1/12 File samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellValidation.java (right): http://gwt-code-reviews.appspot.com/906801/diff/1/12#newcode104

[gwt-contrib] Rename RequestObject-Request and pull the 'with' method into it (issue909801)

Reviewers: rjrjr, cromwellian, Description: Rename RequestObject-Request and pull the 'with' method into it Please review this at http://gwt-code-reviews.appspot.com/909801/show Affected files: M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java

[gwt-contrib] Rename PlaceChangeRequesteEvent to PlaceChangeRequestedEvent (issue894801)

Reviewers: rjrjr, Description: Rename PlaceChangeRequesteEvent to PlaceChangeRequestedEvent Please review this at http://gwt-code-reviews.appspot.com/894801/show Affected files: M user/src/com/google/gwt/app/place/ActivityManager.java D

[gwt-contrib] Fix warnings and checkstyle errors (issue882802)

Reviewers: amitmanjhi, Description: Fix warnings and checkstyle errors Please review this at http://gwt-code-reviews.appspot.com/882802/show Affected files: M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java M

[gwt-contrib] Make key provider a constructor argument to Cell widgets and selection models (issue885801)

Reviewers: rjrjr, Description: Make key provider a constructor argument to Cell widgets and selection models Attempt to fix an IndexOutOfBounds and ClassCast exception in ExpenseDetails.java Please review this at http://gwt-code-reviews.appspot.com/885801/show Affected files: M

[gwt-contrib] Re: Optimize server-side LinkedHashMap_CustomFieldSerializer. (issue829802)

LGTM http://gwt-code-reviews.appspot.com/829802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implement keyboard navigation for CellBrowser (issue843801)

http://gwt-code-reviews.appspot.com/843801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

  1   2   3   4   >