Quick LGTM. I'll take another detailed look tomorrow.
On Tue, Aug 17, 2010 at 11:18 PM, cromwell...@google.com wrote:
Reviewers: amitmanjhi, Ray Ryan,
Description:
Wrap primitive non-record types in same JSON wrapper used for Records
Please review this at
On 2010/08/17 23:23:39, xtof wrote:
On 2010/08/17 23:05:06, tbroyer wrote:
Looking at the code more closely it would merely fail by overly
rejecting tags that are whitelisted: i.e. b foo=ishould be
bold would be sanitized to lt;b foo=ishould be bold and the
end part would be italicized
On Wed, Aug 18, 2010 at 01:44, t.bro...@gmail.com wrote:
On 2010/08/17 23:23:39, xtof wrote:
On 2010/08/17 23:05:06, tbroyer wrote:
Looking at the code more closely it would merely fail by overly
rejecting tags that are whitelisted: i.e. b foo=ishould be
bold would be sanitized to lt;b
Revision: 8561
Author: amitman...@google.com
Date: Wed Aug 18 03:40:09 2010
Log: Re-organized the request factory server code and implemented its first
version
with lots of TODOs and hacks. The instance methods now pass. The
JsonRequestProcessorTest method and create/update/delete now pass.
+1 on backing out the templates.
On Aug 18, 2010 7:15 AM, Christoph Kern x...@google.com wrote:
On Wed, Aug 18, 2010 at 01:44, t.bro...@gmail.com wrote:
On 2010/08/17 23:23:39, xtof wrote:
On 2010/08/17 23:05:06, tbroyer wrote:
Looking at the code more closely it would merely fail by
This sound good!
Are there any plans to include Messages into the ClientBundle without
the GwtCreateResource bridge?
On Aug 17, 11:15 pm, John Tamplin j...@google.com wrote:
Here are several additions I am making to the GWT Messages functionality.
Before finalizing it for review, I would like
http://gwt-code-reviews.appspot.com/771801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/775802/diff/1/3
File user/src/com/google/gwt/cell/client/CheckboxCell.java (right):
http://gwt-code-reviews.appspot.com/775802/diff/1/3#newcode37
user/src/com/google/gwt/cell/client/CheckboxCell.java:37: input
type=\checkbox\ checked /;
Done.
Good catch. It
LGTM
http://gwt-code-reviews.appspot.com/752803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Aug 18, 2010 at 10:37 AM, dflorey daniel.flo...@gmail.com wrote:
This sound good!
Are there any plans to include Messages into the ClientBundle without
the GwtCreateResource bridge?
Not currently.
--
John A. Tamplin
Software Engineer (GWT), Google
--
http://gwt-code-reviews.appspot.com/771801/diff/13001/14007
File user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java
(right):
http://gwt-code-reviews.appspot.com/771801/diff/13001/14007#newcode28
user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java:28: class
SafeHtmlString
LGTM + nits
http://gwt-code-reviews.appspot.com/776801/diff/1/3
File dev/core/src/com/google/gwt/dev/Permutation.java (right):
http://gwt-code-reviews.appspot.com/776801/diff/1/3#newcode112
dev/core/src/com/google/gwt/dev/Permutation.java:112: for
(StaticPropertyOracle oracle :
Le 15 août 2010 10:40, Cristiano cristiano.costant...@gmail.com a écrit :
Hello all,
I need to work with new HTML5 elements: video and SVG's tags.
Now I'm doing some experiment and I'm working out this HTML5 support
by myself on a modified src of GWT: I'm adding some new Element
subclasses
As of yesterday, using dev mode in chrome no longer works.
when executing:
RecordRequestUserAccountHandle login(final String userName, final
String clearTextPassword);
I get the following exception. IE 8 and FF, windows and linux, still work.
I am unsure how to proceed on how to track this
Is there any specific reason for AbstractRecordEditActivity having
some kind of id in its constructor?
I'm asking because we're very heavy Gin users and Gin 1 doesn't
support assisted injections. The gin trunk does, but even then, I
still find it annoying to provide this variable in the
Revision: 8562
Author: jlaba...@google.com
Date: Wed Aug 18 06:22:52 2010
Log: Improving performance of CellTable. CellTable called
StringBuilder#length() before and after rendering each cell to determine if
we need to add a blank space to force the cell to render, but length() does
an
On Wed, Aug 18, 2010 at 12:15 PM, Patrick Julien pjul...@gmail.com wrote:
As of yesterday, using dev mode in chrome no longer works.
What exactly changed between when it was working and when it wasn't? Has
Chrome been updated? The version of GWT you are using, or your app? Can
you roll back
On Wed, Aug 18, 2010 at 12:40 PM, John Tamplin j...@google.com wrote:
On Wed, Aug 18, 2010 at 12:15 PM, Patrick Julien pjul...@gmail.com wrote:
As of yesterday, using dev mode in chrome no longer works.
What exactly changed between when it was working and when it wasn't? Has
Chrome been
http://gwt-code-reviews.appspot.com/776801/diff/1/3
File dev/core/src/com/google/gwt/dev/Permutation.java (right):
http://gwt-code-reviews.appspot.com/776801/diff/1/3#newcode112
dev/core/src/com/google/gwt/dev/Permutation.java:112: for
(StaticPropertyOracle oracle : orderedPropertyOracles) {
On
committed as r8562
http://gwt-code-reviews.appspot.com/775802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
Minor nits:
- handlePrimitiveResult(...) method can be made protected. Plus, it is
missing @Override in all classes but AbstractPrimitiveRequest
- the asString(..) method can be moved to AbstractPrimitiveRequest class
and made a private member.
You would need re-sorting after
http://gwt-code-reviews.appspot.com/776801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wednesday, August 18, 2010 12:55:04 Patrick Julien wrote:
On Wed, Aug 18, 2010 at 12:40 PM, John Tamplin j...@google.com wrote:
On Wed, Aug 18, 2010 at 12:15 PM, Patrick Julien pjul...@gmail.com wrote:
As of yesterday, using dev mode in chrome no longer works.
What exactly changed
On Wed, Aug 18, 2010 at 2:02 PM, Pascal Patry i...@invalidip.com wrote:
So, I know the issue is located between 8515:8553 but I'm still trying
to locate the offending patch.
Ok, so you know r8515 works fine with the same version of Chrome and the GWT
Developer plugin?
--
John A. Tamplin
This is nothing to do with Roo. And while we want to be Gin friendly, we
can't count on people using Gin.
It's a constructor argument because the activity is intended to be single
use, and it is not viable without something to edit. I'm really not inclined
to change the api around the current
On Wednesday, August 18, 2010 14:15:55 John Tamplin wrote:
On Wed, Aug 18, 2010 at 2:02 PM, Pascal Patry i...@invalidip.com wrote:
So, I know the issue is located between 8515:8553 but I'm still trying
to locate the offending patch.
Ok, so you know r8515 works fine with the same version of
Reviewers: jlabanca,
Description:
Fix a bug in keyboard navigation
Please review this at http://gwt-code-reviews.appspot.com/778801/show
Affected files:
M user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
Index:
LGTM
http://gwt-code-reviews.appspot.com/778801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
We need a version number for Chrome.
On Wed, Aug 18, 2010 at 11:28 AM, Pascal Patry i...@invalidip.com wrote:
On Wednesday, August 18, 2010 14:15:55 John Tamplin wrote:
On Wed, Aug 18, 2010 at 2:02 PM, Pascal Patry i...@invalidip.com
wrote:
So, I know the issue is located between
On Wed, Aug 18, 2010 at 2:36 PM, Ray Ryan rj...@google.com wrote:
We need a version number for Chrome.
If the same version works before the change, it seems unlikely to be related
to Chrome or the plugin.
--
John A. Tamplin
Software Engineer (GWT), Google
--
Revision: 8563
Author: cromwell...@google.com
Date: Wed Aug 18 08:38:13 2010
Log: Wrap primitive non-record types in same JSON wrapper used for Records
Review at http://gwt-code-reviews.appspot.com/777801
http://code.google.com/p/google-web-toolkit/source/detail?r=8563
Added:
On Wednesday, August 18, 2010 14:36:38 Ray Ryan wrote:
We need a version number for Chrome.
Chrome 5.0.375.126 on Windows 7
GWT Dev plugin 1.0.7263
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Aug 18, 2010 at 2:36 PM, Ray Ryan rj...@google.com wrote:
We need a version number for Chrome.
5.0.375.126
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Aug 18, 2010 at 2:24 PM, Ray Ryan rj...@google.com wrote:
This is nothing to do with Roo. And while we want to be Gin friendly, we
can't count on people using Gin.
It's a constructor argument because the activity is intended to be single
use, and it is not viable without something to
http://gwt-code-reviews.appspot.com/771801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/771801/diff/1/10
File user/src/com/google/gwt/safehtml/shared/EscapeUtils.java (right):
http://gwt-code-reviews.appspot.com/771801/diff/1/10#newcode21
user/src/com/google/gwt/safehtml/shared/EscapeUtils.java:21: public
final class EscapeUtils {
On 2010/08/16
Reviewers: Lex,
Description:
Add DevMode support for the xsiframe linker
Review by: sp...@google.com
Please review this at http://gwt-code-reviews.appspot.com/779801/show
Affected files:
M dev/core/src/com/google/gwt/core/ext/Linker.java
M
Reviewers: conroy, Keith,
Description:
This patch removes non-determinism in how errors are reported from
CompilationState. This makes it possible to meaningfully compare two
different error logs.
Please review this at http://gwt-code-reviews.appspot.com/773802/show
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/779801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8564
Author: r...@google.com
Date: Wed Aug 18 09:34:51 2010
Log: Fix a bug in keyboard navigation
Review at http://gwt-code-reviews.appspot.com/778801
Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8564
Modified:
LGTM.
Is this designed to fix the test broken by issue 756802 (Change to
CompilationStateBuilder to prevent recursive invalidation on changed
units)?
http://gwt-code-reviews.appspot.com/773802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I have a feeling this is actually working as its supposed to on Chrome, but
silently failing on the other browsers. The stack trace indicates that a
JSON payload that it thought was a JSO object turned out to be a JS Number,
so the JSNI callback failed. Why this would work on other browsers beats
On Wednesday, August 18, 2010 16:33:04 Ray Cromwell wrote:
I have a feeling this is actually working as its supposed to on Chrome, but
silently failing on the other browsers. The stack trace indicates that a
JSON payload that it thought was a JSO object turned out to be a JS Number,
so the
Reviewers: scottb, jat,
Description:
Fix memory leaks in DevMode
Along the way, I deprecated TypeOracle.getReloadCount() since it is a
relic of the past.
Please review this at http://gwt-code-reviews.appspot.com/766803/show
Affected files:
M
Not exactly. I was trying to figure out *why* my patch broke the test, and
the non-deterministic error reporting made it very difficult to compare the
logs. I have a fix for the other issue (review coming soon), but this
seemed like a useful partial.
On Wed, Aug 18, 2010 at 4:16 PM,
Revision: 8565
Author: unn...@google.com
Date: Wed Aug 18 11:12:36 2010
Log: Add DevMode support for the xsiframe linker
Review at http://gwt-code-reviews.appspot.com/779801
Review by: sp...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8565
Added:
LGTM
Does this fix the pinning of CCL as well?
http://gwt-code-reviews.appspot.com/766803/diff/1/7
File user/src/com/google/gwt/i18n/rebind/ResourceFactory.java (right):
http://gwt-code-reviews.appspot.com/766803/diff/1/7#newcode64
user/src/com/google/gwt/i18n/rebind/ResourceFactory.java:64:
No. Still tracking down the CCL JNI reference problem, but these leaks
are affecting basically all apps whereas that one is harder to repro.
On 2010/08/18 21:31:40, jat wrote:
LGTM
Does this fix the pinning of CCL as well?
http://gwt-code-reviews.appspot.com/766803/diff/1/7
File
On Wednesday, August 18, 2010 16:41:39 you wrote:
On Wednesday, August 18, 2010 16:33:04 Ray Cromwell wrote:
I have a feeling this is actually working as its supposed to on Chrome,
but silently failing on the other browsers. The stack trace indicates
that a JSON payload that it thought was
http://gwt-code-reviews.appspot.com/766803/diff/1/8
File
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java
(right):
http://gwt-code-reviews.appspot.com/766803/diff/1/8#newcode50
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:50:
new
Reviewers: Keith, conroy,
Description:
This is the fix to r8550, which was rolled back.
In the original change, any references to error units would result in
transitive removal from TypeOracle. This update makes it so that only
API references trigger invalidation.
Please review this at
Revision: 8566
Author: zun...@google.com
Date: Wed Aug 18 11:56:28 2010
Log: Adds a markTimeline() method to SpeedTracerLogger.
Adds a way to change the format of the log from HTML to
just raw JSON.
Adds a few more instrumentation points to the compiler.
Review at
http://gwt-code-reviews.appspot.com/775804/diff/1/5
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right):
http://gwt-code-reviews.appspot.com/775804/diff/1/5#newcode419
dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java:419:
TypeRefVisitor apiVisitor = new TypeRefVisitor(cud)
http://gwt-code-reviews.appspot.com/766803/diff/1/8
File
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java
(right):
http://gwt-code-reviews.appspot.com/766803/diff/1/8#newcode50
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:50:
new
Thanks, there will be a fix for this by COB today.
-Ray
On Wed, Aug 18, 2010 at 2:38 PM, Pascal Patry i...@invalidip.com wrote:
On Wednesday, August 18, 2010 16:41:39 you wrote:
On Wednesday, August 18, 2010 16:33:04 Ray Cromwell wrote:
I have a feeling this is actually working as its
Revision: 8567
Author: sco...@google.com
Date: Wed Aug 18 12:45:57 2010
Log: Report CompilationState errors deterministically.
This patch removes non-determinism in how errors are reported from
CompilationState. This makes it possible to meaningfully compare two
different error logs.
Reviewers: amitmanjhi,
Description:
Fix the one spot where we were accidentally relying on a cached record,
via an update event, and ensure that can't happen again.
Review by: amitman...@google.com
Please review this at http://gwt-code-reviews.appspot.com/751802/show
Affected files:
M
Revision: 8568
Author: amitman...@google.com
Date: Wed Aug 18 13:21:16 2010
Log: A disabled test, plus some changes to support the test.
Will be used later.
Patch by: amitmanjhi
Review by: cromwellian (tbr)
http://code.google.com/p/google-web-toolkit/source/detail?r=8568
Added:
LGTM
Nits only. Nice!
http://gwt-code-reviews.appspot.com/780801/diff/1/12
File
user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java
(right):
http://gwt-code-reviews.appspot.com/780801/diff/1/12#newcode53
http://gwt-code-reviews.appspot.com/775804/diff/1/5
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right):
http://gwt-code-reviews.appspot.com/775804/diff/1/5#newcode419
dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java:419:
TypeRefVisitor apiVisitor = new TypeRefVisitor(cud)
http://gwt-code-reviews.appspot.com/751802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/766803/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
(right):
http://gwt-code-reviews.appspot.com/766803/diff/1/2#newcode3
dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:3: *
Please tweak your Eclipse auto-format
http://gwt-code-reviews.appspot.com/776801/diff/8001/9002
File dev/core/src/com/google/gwt/dev/Permutation.java (right):
http://gwt-code-reviews.appspot.com/776801/diff/8001/9002#newcode3
dev/core/src/com/google/gwt/dev/Permutation.java:3: *
I see you caught the autoformat bug from conroy. :)
Revision: 8570
Author: amitman...@google.com
Date: Wed Aug 18 15:57:33 2010
Log: Implemented a smart diff algorithm on the server side to detect actual
UPDATES.
Each entity is serialized to a jsonObject, and their before and after states
are compared. Added tests that exercise this smart
LGTM still
On 2010/08/19 04:16:53, cromwellian wrote:
http://gwt-code-reviews.appspot.com/780801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8572
Author: cromwell...@google.com
Date: Wed Aug 18 19:31:21 2010
Log: Add partial support for Record types as method parameters
- Currently, Record has to already have been persisted on the server
Added missing support for String as a RF method return type
Fixed bugs with cast
66 matches
Mail list logo
