Translatable means the jsvacript translated equivalent. Your tests are running
inside a jvm using pure java. Even your native methods are emulated js.
On 01/10/2010, at 9:54 AM, Damon Lundin damon.lun...@gmail.com wrote:
We are trying to upgrade from 2.0.4 to 2.1.0.m3 because of some bugs
in
[+Scott and Kelly from Google]
On Thu, Sep 30, 2010 at 4:54 PM, Damon Lundin damon.lun...@gmail.comwrote:
We are trying to upgrade from 2.0.4 to 2.1.0.m3 because of some bugs
in 2.0.4 but in doing so our GWT test cases have begun failing and I
have determined it's because the next test is
On Sep 30, 6:56 pm, Patrick Julien pjul...@gmail.com wrote:
Is there a class that integrates the two? same for check boxes?
Hmm, CheckBox implements IsEditorLeafValueEditorBoolean so it
should work OK for a boolean value.
RadioButton extends CheckBox so it's a boolean editor, but radio
Sometimes my GWT test's fail (during nightly build) and give me the
following error.
-
[INFO] com.google.gwt.junit.client.TimeoutException: The browser did
not contact the server within 6ms.
[INFO] - NO RESPONSE: 192.168.1.65 / Mozilla/5.0 (Windows; U; Windows
NT 5.1; en-US; rv:1.9.0.1)
That timeout means that GWT has launched a browser pointed at itself, to run
the test, but the browser didn't actually connect to us within 60 seconds.
The constant isn't directly configurable, no, but it's not about the size
of your test, just getting that first useful access from the browser
Is this in dev mode or prod mode? Do the tests succeed if you run them
individually?
On Thu, Sep 30, 2010 at 7:54 PM, Damon Lundin damon.lun...@gmail.comwrote:
We are trying to upgrade from 2.0.4 to 2.1.0.m3 because of some bugs
in 2.0.4 but in doing so our GWT test cases have begun failing
LGTM
http://gwt-code-reviews.appspot.com/941801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/938801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Oct 1, 9:11 am, Scott Blum sco...@google.com wrote:
Is this in dev mode or prod mode? Do the tests succeed if you run them
individually?
This is in dev mode. If I disable all of the tests and run them
individually they all pass. I've never tried running tests in prod
mode but I think I
Ok, that's pretty strange, but there is a way to debug.
- Unzip gwt-user.jar somewhere.
- Inside where you extracted it, there should be a folder
com/google/gwt/junit/translatable/
- Go edit your launch config and add that folder to the Source Lookup Path,
under the Source tab, Add. a File System
Reviewers: cromwellian,
Description:
Fixes an NPE when setting an entity parameter to null. The NPE occurs in
generated code because we try to get the entity in wire format.
Please review this at http://gwt-code-reviews.appspot.com/944801/show
Affected files:
M
Revision: 8913
Author: gwt.mirror...@gmail.com
Date: Fri Oct 1 05:51:52 2010
Log: Clarifying the JavaDoc of CellPanel (the parent of DockPanel and
Horizontal/VerticalPanel) so that people do not mistake it for a Cell based
data presentation widget.
Review by: r...@google.com
yeah, CheckBox doesn't work out of the box either because it needs to
implement ValueBase
On Fri, Oct 1, 2010 at 8:36 AM, Patrick Julien pjul...@gmail.com wrote:
thanks for the info
On Fri, Oct 1, 2010 at 5:27 AM, Thomas Broyer t.bro...@gmail.com wrote:
On Sep 30, 6:56 pm, Patrick Julien
Thanks for the detailed explanation, that sure helps.
I have seen the timeout message happen due to a compile error in the GWT
code, but you'd see those errors in the log also.
Could it have something to do with issue 4700 ?:
http://code.google.com/p/google-web-toolkit/issues/detail?id=4700
Thanks for the help Scott. The problem is not with the
delayTestFinish. Apparently our tests are throwing uncaught
exceptions which causes the test to finish. The exception does appear
in our logs, but it's one of these:
Caused by: com.google.gwt.core.client.JavaScriptException: (Error):
Reviewers: rjrjr, cromwellian, amitmanjhi,
Message:
This patch is against r8884. My plan is to merge up to trunk today to
incorporate the new tests that have been going in, but at first glance,
that shouldn't significantly change the overall code.
Description:
Overhaul the client-side
On Fri, Oct 1, 2010 at 1:00 PM, Damon Lundin damon.lun...@gmail.com wrote:
Thanks for the help Scott. The problem is not with the
delayTestFinish. Apparently our tests are throwing uncaught
exceptions which causes the test to finish. The exception does appear
in our logs, but it's one of
It sounds like the problem really boils down to less-than-useful stack
traces when a native exception is thrown in Dev mode. Ironically, if you
ran this in Prod mode, you'd probably get a better stack trace, because we
emulate the stack over there.
We could probably implement the same sort of
On Fri, Oct 1, 2010 at 12:32 PM, Ed post2edb...@gmail.com wrote:
Thanks for the detailed explanation, that sure helps.
I have seen the timeout message happen due to a compile error in the GWT
code, but you'd see those errors in the log also.
Could it have something to do with issue 4700 ?:
On Oct 1, 12:12 pm, John Tamplin j...@google.com wrote:
If your test code ultimately involves callbacks from the browser event loop
from your own code, you need to wrap all such calls in $entry, which hooks
up the uncaught exception handler and the Scheduler hooks. All of the GWT
widgets/etc
On Fri, Oct 1, 2010 at 1:41 PM, Damon Lundin damon.lun...@gmail.com wrote:
I'm not sure I entirely understand. Are you suggesting that I need to
convert all of my DeferredCommand calls to ones that use some new
native method implementation so I can wrap my callbacks in $entry?
No, if you
On Oct 1, 12:51 pm, John Tamplin j...@google.com wrote:
If you are only using GWT-supplied APIs, I am not sure how you aren't
getting the uncaught exception handler called on those calls. Can you
create a small repro case that illustrates the problem?
John A. Tamplin
Software Engineer
On Fri, Oct 1, 2010 at 1:59 PM, Damon Lundin damon.lun...@gmail.com wrote:
On Oct 1, 12:51 pm, John Tamplin j...@google.com wrote:
If you are only using GWT-supplied APIs, I am not sure how you aren't
getting the uncaught exception handler called on those calls. Can you
create a small
On Oct 1, 12:32 pm, Scott Blum sco...@google.com wrote:
It sounds like the problem really boils down to less-than-useful stack
traces when a native exception is thrown in Dev mode. Ironically, if you
ran this in Prod mode, you'd probably get a better stack trace, because we
emulate the stack
LGTM
http://gwt-code-reviews.appspot.com/942801/diff/1/3
File user/src/com/google/gwt/user/cellview/client/CellList.java (right):
http://gwt-code-reviews.appspot.com/942801/diff/1/3#newcode472
user/src/com/google/gwt/user/cellview/client/CellList.java:472: * Called
when the user selects a cell
ReturnMessage.isException = true was returned. It would be nice to
have a stack trace for the code that created this ReturnMessage in
response to an exception.
I agree with Scott that the EmulateJsStack pass could be applied to
the native code fragments injected into the browser. The native
And one further minor suggestion: for all the places where you have a
comment like // implemented in the translatable version of this
class, may I suggest adding some additional information on where the
source might be located (such as Scott's instructions above). If I
had had those, I probably
Revision: 8915
Author: jlaba...@google.com
Date: Fri Oct 1 09:16:52 2010
Log: Fixes an NPE when setting an entity parameter to null. The NPE occurs
in generated code because we try to get the entity in wire format.
Review at http://gwt-code-reviews.appspot.com/944801
Revision: 8916
Author: rj...@google.com
Date: Fri Oct 1 09:39:58 2010
Log: Fix nonstandard two method handler interface that probably would have
broken UiBinder.
Review at http://gwt-code-reviews.appspot.com/941801
Review by: r...@google.com
committed as r8915
http://gwt-code-reviews.appspot.com/944801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8917
Author: jlaba...@google.com
Date: Fri Oct 1 09:41:26 2010
Log: Fixes some bugs in CellBrowser. CellBrowser#setChildState() was
exited early too aggressively, which could put CellBrowser in an invalid
state if you mix leaf and non-leaf nodes. CellBrowser was overriding
committed as r8917
http://gwt-code-reviews.appspot.com/942801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: robertvawter,
Description:
Fixing a ConcurrentModificationException in JsonRequestProcessor that
occurs when you use a setter that sets an Entity from null to a value.
Also fixes a bug in DeltaValueStoreJsonImpl#retainValue() where we only
retain the first element of a List instead of
I'm currently having 2 issues with JsonRequestProcessor.validateKeys().
These requests are coming from updates that we want to perform on entities
that are driven by EntityProxy.
The first issue is with inheritance. We have a base class for all our
entities on the server side in order to not have
Reviewers: jgw,
Description:
Add Support for server side script selection in linker
Please review this at http://gwt-code-reviews.appspot.com/941802/show
Affected files:
A dev/core/src/com/google/gwt/core/ext/linker/impl/PermutationsUtil.java
A
On 1 oct, 18:14, Patrick Julien pjul...@gmail.com wrote:
yeah, CheckBox doesn't work out of the box either because it needs to
implement ValueBase
Because you try to wrap it in a ValueBoxEditorDecorator?
Judging from the code (i.e. I haven't tested to confirm what I'm
saying here), CheckBox
On Fri, Oct 1, 2010 at 6:51 PM, Thomas Broyer t.bro...@gmail.com wrote:
On 1 oct, 18:14, Patrick Julien pjul...@gmail.com wrote:
yeah, CheckBox doesn't work out of the box either because it needs to
implement ValueBase
Because you try to wrap it in a ValueBoxEditorDecorator?
Yep, I have,
Ah, now I know what you're saying, I was trying to wrap this thing in
a decorator, you just need to use it directly since it's an editor
On Fri, Oct 1, 2010 at 7:03 PM, Patrick Julien pjul...@gmail.com wrote:
On Fri, Oct 1, 2010 at 6:51 PM, Thomas Broyer t.bro...@gmail.com wrote:
On 1 oct,
The problem is inside in JsonRequestProcessor in the method updatePropertyTypes
It's using entity.getDeclaredFields() which will omit all inherited fields.
On Fri, Oct 1, 2010 at 5:24 PM, Pascal Patry i...@invalidip.com wrote:
I'm currently having 2 issues with
On 2 oct, 01:17, Patrick Julien pjul...@gmail.com wrote:
Ah, now I know what you're saying, I was trying to wrap this thing in
a decorator, you just need to use it directly since it's an editor
AFAICT, the only thing you won't have is the display of validation
errors (which
On Fri, Oct 1, 2010 at 7:28 PM, Thomas Broyer t.bro...@gmail.com wrote:
On 2 oct, 01:17, Patrick Julien pjul...@gmail.com wrote:
Ah, now I know what you're saying, I was trying to wrap this thing in
a decorator, you just need to use it directly since it's an editor
AFAICT, the only thing
Is there a wave or doc somewhere about the editor framework? I'm
looking to see if this can be used to create child un-owned
relationships too
On Fri, Oct 1, 2010 at 7:32 PM, Patrick Julien pjul...@gmail.com wrote:
On Fri, Oct 1, 2010 at 7:28 PM, Thomas Broyer t.bro...@gmail.com wrote:
On 2
http://gwt-code-reviews.appspot.com/924801/diff/2001/3012
File user/src/com/google/gwt/editor/client/AutoBeanUtils.java (right):
http://gwt-code-reviews.appspot.com/924801/diff/2001/3012#newcode39
user/src/com/google/gwt/editor/client/AutoBeanUtils.java:39: public
static MapString, Object
Reviewers: scottb, zundel,
Description:
Intern strings in the compiler AST to reduce memory footprint.
Please review this at http://gwt-code-reviews.appspot.com/946801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java
M
On 2010/10/02 00:36:10, conroy wrote:
Turns out most of the things we need to intern get captured through
JType's constructor, so the changes here are pretty minimal.
http://gwt-code-reviews.appspot.com/946801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Fri, Oct 1, 2010 at 7:32 PM, Patrick Julien pjul...@gmail.com wrote:
True, but at the same time, it's a check box, validation shouldn't be
an issue anyway
Except if you have validators such as this shouldn't be checked if
you have value X in field Y
On 2 oct, 01:33, Patrick Julien
LGTM. Other than the comments on wave that you have already looked at, I
don't have anything new. I carefully looked at the EntityProxy and stableId
stuff, and it looks great. I also skimmed over the generator code.
On Fri, Oct 1, 2010 at 5:50 PM, cromwell...@google.com wrote:
Small nit.
Feedback implemented.
@RayC, I'll look at your patch before answering the question about the
@Service validation.
http://gwt-code-reviews.appspot.com/924801/diff/2001/3007
File user/src/com/google/gwt/app/place/AbstractProxyListActivity.java
(right):
48 matches
Mail list logo
