LGTM.
http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):
http://gwt-code-reviews.appspot.com/1264801/diff/1/2#newcode201
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:201: public void
clear() {
synchronized?
http://gwt-code-reviews.appspot.com/1195801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal, scottb, zundel,
Description:
Use more faster string split in critical places.
Please review this at http://gwt-code-reviews.appspot.com/1262802/show
Affected files:
dev/core/src/com/google/gwt/dev/resource/impl/PathPrefixSet.java
LGTM
http://gwt-code-reviews.appspot.com/1263801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1262802/diff/1/2
File dev/core/src/com/google/gwt/dev/util/Util.java (right):
http://gwt-code-reviews.appspot.com/1262802/diff/1/2#newcode982
dev/core/src/com/google/gwt/dev/util/Util.java:982: public static
String[] split(String s, char separatorChar) {
Have
http://gwt-code-reviews.appspot.com/1262802/diff/1/5
File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java
(right):
http://gwt-code-reviews.appspot.com/1262802/diff/1/5#newcode39
dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java:39:
this.pathParts =
http://gwt-code-reviews.appspot.com/1267801/diff/3001/4077
File user/build.xml (right):
http://gwt-code-reviews.appspot.com/1267801/diff/3001/4077#newcode128
user/build.xml:128: gwt.javac srcdir=test
excludes=com/google/gwt/langtest/**,**/super/**
Instead of excluding super move super source
LGTM
http://gwt-code-reviews.appspot.com/1195801/diff/19002/32018
File user/test/com/google/gwt/media/MediaTest.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1195801/diff/19002/32018#newcode24
user/test/com/google/gwt/media/MediaTest.gwt.xml:24: script
src=testh264.mp4/script
Does
Revision: 9508
Author: fmal...@google.com
Date: Fri Jan 7 05:51:44 2011
Log: Rolling back r9505 due to CellViewSuite test breakages.
Review at http://gwt-code-reviews.appspot.com/1262801
Review by: con...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9508
Modified:
http://gwt-code-reviews.appspot.com/1254801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1254801/diff/14001/15001
File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
(right):
http://gwt-code-reviews.appspot.com/1254801/diff/14001/15001#newcode792
dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:792: *
Note: OpenJDK
http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):
http://gwt-code-reviews.appspot.com/1264801/diff/1/2#newcode201
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:201: public void
clear() {
Sure. Thanks.
Agreed with the other comments, and a few more.
http://gwt-code-reviews.appspot.com/1262802/diff/1/5
File dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java
(right):
http://gwt-code-reviews.appspot.com/1262802/diff/1/5#newcode39
Revision: 9509
Author: gwt.mirror...@gmail.com
Date: Fri Jan 7 06:41:55 2011
Log: ModuleDef's resource oracles really should be lazy.
http://gwt-code-reviews.appspot.com/1264801/show
Tested: tap_presubmit -p gwt: 709 passed, 4 skipped at
2011-01-07T17:41:24.621Z
Review by: zun...@google.com
Overall, LGTM.
What kind of speedup does this give us for large targets?
http://gwt-code-reviews.appspot.com/1265801/diff/1/3
File
dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
(right):
http://gwt-code-reviews.appspot.com/1265801/diff/1/3#newcode175
I don't see any problem with the code.
Is this really something we want to happen by default? I'm concerned it
will be baffling to a user why a web.xml gets created only some of the
time. It seems to me that an external tool that could parse xml could
create such a file if it was needed
On Fri, Jan 7, 2011 at 1:11 PM, zun...@google.com wrote:
I don't see any problem with the code.
Is this really something we want to happen by default? I'm concerned it
will be baffling to a user why a web.xml gets created only some of the
time. It seems to me that an external tool that
It sounds to me as if we should be integrating with the facilities in
Servlet 3.0, since it has been final now for over a year. Specifically see:
Section 4.4: Configuration methods - An API to add and configure servlets,
filters, and listeners at runtime.
Chapter 8: Annotations and Pluggability -
That seems good to me as a mid-term goal. Wouldn't this still be a useful
stop-gap moving in that direction but with the current servlet spec?
On Fri, Jan 7, 2011 at 1:41 PM, Toby Reyelts to...@google.com wrote:
It sounds to me as if we should be integrating with the facilities in
Servlet
Revision: 9510
Author: rj...@google.com
Date: Fri Jan 7 08:26:38 2011
Log: Public (konstantin.scheg...@gmail.com):
Introduces HasTreeItems interface for Tree and TreeItem, and adds UiBinder
support for building trees. Makes it possible for GWT Designer to do the
same.
Reviewed:
Verified manually, submitting.
On 2010/12/17 20:34:14, unnurg wrote:
Unfortunately not
On 2010/12/17 20:33:56, unnurg wrote:
LGTM
On 2010/12/17 02:11:10, rjrjr wrote:
http://gwt-code-reviews.appspot.com/1223802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9511
Author: rj...@google.com
Date: Fri Jan 7 09:11:19 2011
Log: Make the logging framework provide a default uncaught exception
handler. Note that this only effects production code. Dev mode
already installs a default uncaught exception handler.
SGTM and code LGTM
On 2011/01/07 19:04:37, scottb wrote:
That seems good to me as a mid-term goal. Wouldn't this still be a
useful
stop-gap moving in that direction but with the current servlet spec?
On Fri, Jan 7, 2011 at 1:41 PM, Toby Reyelts mailto:to...@google.com
wrote:
It sounds
http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (left):
http://gwt-code-reviews.appspot.com/1264801/diff/1/2#oldcode418
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:418: public
synchronized void refresh(TreeLogger logger) {
http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (left):
http://gwt-code-reviews.appspot.com/1264801/diff/1/2#oldcode418
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:418: public
synchronized void refresh(TreeLogger logger) {
I
I was able to parallelize 25% of the work done by ResourceOracleImpl
refresh running DynaTable dev mode in eclipse. My eclipse environment,
however, is very heavy on file system folders, and very light on jars.
I expect that in jar-rich environments (such as a GWT distro) that
savings would be
Revision: 9512
Author: sco...@google.com
Date: Fri Jan 7 09:43:50 2011
Log: Pre-initialize ResourceOracleImpl's classpaths in parallel with other
startup
tasks.
http://gwt-code-reviews.appspot.com/1265801/show
Review by: con...@google.com
http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (left):
http://gwt-code-reviews.appspot.com/1264801/diff/1/2#oldcode418
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:418: public
synchronized void refresh(TreeLogger logger) {
On
Revision: 9513
Author: jlaba...@google.com
Date: Fri Jan 7 10:19:06 2011
Log: Adding support for setting column widths in CellTable, and for
allowing CellTable to use fixed table-layout for more precise control over
column widths. I also updated the CellTable example in Showcase and the
Reviewers: scottb, tobyr,
Description:
Adds some documentation on TypeOracle and JType
Please review this at http://gwt-code-reviews.appspot.com/1268801/show
Affected files:
M dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java
M
Also, bunch of space-erasure going on.
http://gwt-code-reviews.appspot.com/1268801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):
http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode24
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:24: *
r9511
On 2011/01/07 19:33:38, rjrjr wrote:
Verified manually, submitting.
On 2010/12/17 20:34:14, unnurg wrote:
Unfortunately not
On 2010/12/17 20:33:56, unnurg wrote:
LGTM
On 2010/12/17 02:11:10, rjrjr wrote:
http://gwt-code-reviews.appspot.com/1223802/show
--
Revision: 9515
Author: gwt.mirror...@gmail.com
Date: Fri Jan 7 14:12:54 2011
Log: Remove js-config.h (platform specific) from the generic include
directory
http://code.google.com/p/google-web-toolkit/source/detail?r=9515
Deleted:
/plugin-sdks/gecko-sdks/gecko-2.0.0/include/js-config.h
Revision: 9516
Author: sco...@google.com
Date: Fri Jan 7 11:13:03 2011
Log: Follow-up to tobyr feedback on r9509.
http://gwt-code-reviews.appspot.com/1264801/show
Review by: to...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9516
Modified:
LGTM
http://gwt-code-reviews.appspot.com/1268801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):
http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode29
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:29: * Returns
the equivalent of {...@link
Reviewers: jat, fabiomfv,
Description:
Update the xpcom plugin for Gecko 2.0 (FF4). Only tested on Linux so
far.
Please review this at http://gwt-code-reviews.appspot.com/1269801/show
Affected files:
M plugins/xpcom/ExternalWrapper.cpp
M plugins/xpcom/FFSessionHandler.cpp
M
http://gwt-code-reviews.appspot.com/1269801/diff/1/12
File plugins/xpcom/install-template.rdf (right):
http://gwt-code-reviews.appspot.com/1269801/diff/1/12#newcode10
plugins/xpcom/install-template.rdf:10: em:unpacktrue/em:unpack
this is needed to workaround a limitation of the current
Reviewers: conroy,
Description:
TreeItemTest got upset by Safari 3.
Review by: con...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1270801/show
Affected files:
M user/test/com/google/gwt/user/client/ui/TreeItemTest.java
Index:
LGTM
On Jan 7, 2011 7:12 PM, rj...@google.com wrote:
Reviewers: conroy,
Description:
TreeItemTest got upset by Safari 3.
Review by: con...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1270801/show
Affected files:
M
Revision: 9518
Author: rj...@google.com
Date: Fri Jan 7 13:48:26 2011
Log: TreeItemTest got upset by Safari 3.
Review at http://gwt-code-reviews.appspot.com/1270801
Review by: con...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9518
Modified:
Reviewers: conroy,
Description:
TreeTest got upset by Safari 3 too.
Please review this at http://gwt-code-reviews.appspot.com/1271801/show
Affected files:
M user/test/com/google/gwt/user/client/ui/TreeTest.java
Index: user/test/com/google/gwt/user/client/ui/TreeTest.java
Revision: 9519
Author: rj...@google.com
Date: Fri Jan 7 17:25:19 2011
Log: TreeTest got upset by Safari 3 too.
Review at http://gwt-code-reviews.appspot.com/1271801
Review by: con...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9519
Modified:
42 matches
Mail list logo
