Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3180
to look at the new patch set (#10).
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare
Daniel Kurka has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3180
to look at the new patch set (#11).
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare
Manuel Carrasco Moñino has posted comments on this change.
Change subject: Remove unused, package-private FastStringMap.
..
Patch Set 1: Code-Review+1
LGTM
--
To view, visit https://gwt-review.googlesource.com/3280
To
Hi,
as I wrote in the
issuehttps://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=3042,
I am able to do the necessary work for solving it. So, can you guide me
about the steps that I need
Adolfo,
To get the source checked out and compiling follow:
http://www.gwtproject.org/makinggwtbetter.html#workingoncode
To submit the patch use:
http://www.gwtproject.org/makinggwtbetter.html#submittingpatches
I recently had to move an old svn patch into gerrit and the following gave
a very
Thomas Broyer has posted comments on this change.
Change subject: Use correct return types for createFooInputBuilder()
methods in HtmlBuilderFactory. Also adjust the return types of affected
methods in HtmlBuilderImpl.
..
From the gwtproject Making GWT Better page section Gerrit Setup step 3:
Make a change and commit it locally using git (e.g., edit a file foo and
then run ?git commit -m ?my first change? foo?).
What does foo represent?
Thanks,
Pat
On Mon, May 20, 2013 at 3:18 PM, Thomas Broyer
Hi Patrick,
foo is often used as a place holder, so something like:
git add foo
should mean:
git add my_cool_edited_file
-Daniel
On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker tucker...@gmail.com wrote:
From the gwtproject Making GWT Better page section Gerrit Setup step 3:
Make a change
Thanks for the quick response, but that doesn't answer my question.
I realize foo is a place holder, I'm trying to figure out what it
represents. A file, a message to the reviewers, ... I'm trying to figure
out what I should replace it with.
Thanks again,
Pat
On Mon, Jun 10, 2013 at 9:54 AM,
Well I just wasted another few hours this morning trying to figure out how
to commit something to this new system.
Are these instructions complete??
Currently when I try to do a git push it tells me I have to provide a
Change-Id. I copied the hook file to the hooks folder and the message
On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker tucker...@gmail.com wrote:
From the gwtproject Making GWT Better page section Gerrit Setup step 3:
Make a change and commit it locally using git (e.g., edit a file foo and
then run ?git commit -m ?my first change? foo?).
What does foo
John A. Tamplin has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
On Monday, June 10, 2013 5:12:34 AM UTC+2, Stephen Haberman wrote:
Hey,
I wasn't quite sure, so figured I would ask: what's our policy on who
can give +2s? Is it any committer?
Technically, yes:
https://gwt-review.googlesource.com/#/admin/projects/gwt,access (if you can
see it;
Brian Slesinsky has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 9:
Hi, we had a performance regression reported to us so we rolled this CL
I've been giving +2s for stuff I think is ready to commit, but I always
assumed that Googlers would have no superpowers here, and that Steering
Committee members and other designated people with specialized knowledge
could do so as well. Google doesn't automatically import changes without
Goktug Gokdogan has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
+mdempsky
Hi, I think you're going to have more trouble than most because you're
using Windows and that's not so common for GWT development. The code to
automatically add the Change-Id line is specific to Unix but you can do it
manually by editing the changelist yourself. To fix your most recent
Brian Slesinsky has posted comments on this change.
Change subject: Remove unused, package-private FastStringMap.
..
Patch Set 1: Code-Review+2
Not used in Google code either.
--
To view, visit
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3300
to look at the new patch set (#3).
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's various constructors.
Roberto Lublinerman has posted comments on this change.
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's various constructors.
..
Patch Set 3:
Roberto Lublinerman has posted comments on this change.
Change subject: Adds a module to revert GWT.runAsync to do immediate
callbacks in consecutive calls.
..
Patch Set 1: Code-Review+2
I assume because the new method is
Roberto Lublinerman has posted comments on this change.
Change subject: Fixes UiHandler method matching in generic classes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3250
To
Roberto Lublinerman has posted comments on this change.
Change subject: Fixes a NPE in RF when returning a null entity while the
client used .with().
..
Patch Set 1: Code-Review+2
LGTM.
--
To view, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Adds a module to revert GWT.runAsync to do immediate
callbacks in consecutive calls.
..
Patch Set 1:
Yes, that's correct :)
--
To view, visit
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Adds a module to revert GWT.runAsync to do immediate
callbacks in consecutive calls.
..
Adds a module to revert GWT.runAsync to do immediate
Roberto Lublinerman has posted comments on this change.
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's various constructors.
..
Patch Set 2:
(2
Colin Alworth has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6: Code-Review+1
Nope, we can work with it - a wrapper isn't really an option, since
Hello Roberto Lublinerman, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3300
to look at the new patch set (#4).
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's
Roberto Lublinerman has posted comments on this change.
Change subject: The job of defineSeed is to mark the existence of a class
and associate its castMap with the class's various constructors.
..
Patch Set 4:
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6:
Unfortunately JSO's doesn't give us much choice on API management so that
make
Roberto Lublinerman has posted comments on this change.
Change subject: fixes a compiler crash when parsing illegal runAsync
definitions
..
Patch Set 1: Code-Review+2
--
To view, visit
Stephen Haberman has submitted this change and it was merged.
Change subject: Remove unused, package-private FastStringMap.
..
Remove unused, package-private FastStringMap.
Change-Id: I8dd9f897a044ba53be5fc74fabb40a382b9ef119
Stephen Haberman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 9:
Huh. I knew this correct way was slower but I'm surprised it actually
Colin Alworth has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6:
Thanks Goktug - one of the distinct advantages of extending Element is that
we
35 matches
Mail list logo
