Reviewers: rchandia,
Description:
Add test for builtin constraints
[JSR 303 TCK Result] 138 of 257 (53.70%) Pass with 11 Failures and 7
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1458801/
Affected files:
A
Just a look at the user/src classes so far.
http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/DefaultEventBusProvider.java
File user/src/com/google/gwt/user/client/ui/DefaultEventBusProvider.java
(right):
On 2011/06/14 06:34:54, Nick Chalko wrote:
LGTM
http://gwt-code-reviews.appspot.com/1458801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated per your advice.
http://gwt-code-reviews.appspot.com/1450816/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10330
Author: gwt.mirror...@gmail.com
Date: Tue Jun 14 07:47:25 2011
Log: Add test for builtin constraints
[JSR 303 TCK Result] 138 of 257 (53.70%) Pass with 11 Failures and 7 Errors.
Review at http://gwt-code-reviews.appspot.com/1458801
Review by: rchan...@google.com
See comments. I think we can give users more control over when drivers
are started/stopped and make the flow a little more obtainable in the
process.
http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/DefaultEventBusProvider.java
File
On 2011/06/14 14:14:05, scottb wrote:
Updated per your advice.
LGTM
http://gwt-code-reviews.appspot.com/1450816/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The POM files point to GWT 2.3 which means the code won't compile if
imported as a maven project as there are a bunch of new dependencies.
Since GWT 2.4 beta/m1 was released can we have a strategy of
maintaining a snapshot maven build to truly adhere to maven spirit?
On Jun 1, 3:57 pm,
Revision: 10331
Author: sco...@google.com
Date: Tue Jun 14 05:20:58 2011
Log: Crude AST versioning.
http://gwt-code-reviews.appspot.com/1450816/
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10331
Modified:
Reviewers: unnurg,
Description:
A general purpose script injection class for injecting a script directly
or adding a reference to a script by URL to the DOM
Please review this at http://gwt-code-reviews.appspot.com/1451818/
Affected files:
A
Reviewers: rjrjr,
Description:
Fixing login redirect in MobileWebApp sample. We now send a redirect
URL with every request, and use it if the user isn't logged in. We
calculate the redirect URL on the client because the client browser has
built in support for parsing the URL components.
Reviewers: zundel, jbrosenberg,
http://gwt-code-reviews.appspot.com/1450818/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java (right):
Reviewers: rjrjr, rchandia,
Description:
Remove RenderablaComposite. \o/
Please review this at http://gwt-code-reviews.appspot.com/1455804/
Affected files:
D user/src/com/google/gwt/user/client/ui/RenderableComposite.java
Index:
On 2011/06/14 16:54:43, rdcastro wrote:
LGTM
http://gwt-code-reviews.appspot.com/1455804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1450818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On Tue, Jun 14, 2011 at 10:09 AM, rchan...@google.com wrote:
On 2011/06/14 16:54:43, rdcastro wrote:
LGTM
http://gwt-code-reviews.**appspot.com/1455804/http://gwt-code-reviews.appspot.com/1455804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10332
Author: rdcas...@google.com
Date: Tue Jun 14 07:40:15 2011
Log: Remove RenderablaComposite. \o/
Review at http://gwt-code-reviews.appspot.com/1455804
http://code.google.com/p/google-web-toolkit/source/detail?r=10332
Deleted:
LGTM
http://gwt-code-reviews.appspot.com/1450818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10333
Author: jlaba...@google.com
Date: Tue Jun 14 07:50:16 2011
Log: Fixing login redirect in MobileWebApp sample. We now send a
redirect URL with every request, and use it if the user isn't logged in.
We calculate the redirect URL on the client because the client
Revision: 10334
Author: d...@google.com
Date: Tue Jun 14 08:28:02 2011
Log: Provide a more standard GWT linker for HTML5 worker threads based
on the ConfigurableLinker. Unlike the non-standard WorkerLinker and
SharedWorkerLinker, this change allows worker threads to do GWT RPCs. A
Responses below. No code changes yet.
http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/DefaultEventBusProvider.java
File user/src/com/google/gwt/user/client/ui/DefaultEventBusProvider.java
(right):
Revision: 10335
Author: gwt.mirror...@gmail.com
Date: Tue Jun 14 12:11:53 2011
Log: Resolve GWT.create() answers by source name.
http://gwt-code-reviews.appspot.com/1450818
http://code.google.com/p/google-web-toolkit/source/detail?r=10335
Modified:
http://gwt-code-reviews.appspot.com/1446818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
committed as r10333
http://gwt-code-reviews.appspot.com/1450817/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/IsEventSource.java
File user/src/com/google/gwt/user/client/ui/IsEventSource.java (right):
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1446818/diff/1/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
(right):
http://gwt-code-reviews.appspot.com/1446818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1446818/diff/1/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
(right):
Reviewers: zundel, jbrosenberg,
Message:
Turns out the target GWT field is not always fully baked, as it was in
GenerateJavaAST. Using JDT to get the compile-time constant is the
right appraoch.
Revision: 10336
Author: jbrosenb...@google.com
Date: Tue Jun 14 12:19:31 2011
Log: Updated generator result caching to use lastModifiedTime from
CompilationUnit.lastModified().
Removed GeneratorContextExt.getSourceLastModifiedTime().
Removed JRealClassType.getTypeStrongHash().
Added
Reviewers: robertvawter,
Description:
Reduce the use of old event bus classes. The only public api that
still mentions the gwt EventBus explicitly at this point is the
Activity interface. Not much to be done about that, and maybe
DrivesWidgets will grow to make the point moot.
Please review
Patch updated to fix GwtAstBuilderTest.
http://gwt-code-reviews.appspot.com/1449818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr, rchandia,
Description:
Add a compile-time check against provided UiFields for RenderablePanel.
I want to add the same check for HTMLPanel, but since that'll probably
break a lot of people, it'd be better to do it in a separate CL.
Please review this at
http://gwt-code-reviews.appspot.com/1446819/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1446819/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Can you briefly describe the reason for this change?
If I understand correctly, the change is to extend handling of compile
time constants to Strings as well as base types?
http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
File
http://gwt-code-reviews.appspot.com/1446819/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Yes, according to the JLS, Strings are considered compiled time
constants, but we've been doing this wrong up to now. (Not that it
mattered before now.)
http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
File
Ready for review.
On Tue, Jun 14, 2011 at 5:03 PM, rj...@google.com {subItem.from.uri}
wrote:
http://gwt-code-reviews.appspot.com/1446819/http://www.google.com/url?sa=Dq=http://gwt-code-reviews.appspot.com/1446819/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Okay, much nicer! :D
http://gwt-code-reviews.appspot.com/1449818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM w/a couple questions
http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):
Revision: 10337
Author: sco...@google.com
Date: Tue Jun 14 15:18:26 2011
Log: GwtAstBuilder better handling of JSNI refs to constants.
Turns out the target GWT field is not always fully baked, as it was in
GenerateJavaAST. Using JDT to get the compile-time constant is the right
lgtm
http://gwt-code-reviews.appspot.com/1449818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
45 matches
Mail list logo
