[gwt-contrib] Re: Fix typo (issue1497807)

2011-08-04 Thread Fred Sauer
reply-all from to (using new address re...@gwt-code-reviews-hr.appspotmail.com) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix typo (issue1497807)

2011-08-04 Thread Fred Sauer
reply-all from to (using old address re...@gwt-code-reviews.appspotmail.com) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-16 Thread Fred Sauer
John, Mind having a look at this one? On Thu, Jun 16, 2011 at 2:22 PM, fre...@google.com wrote: http://gwt-code-reviews.**appspot.com/1407803/http://gwt-code-reviews.appspot.com/1407803/ -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre

Re: [gwt-contrib] Re: Use glass panel isntead of alert() when displaying dev mode connection failures, (issue1449802)

2011-05-17 Thread Fred Sauer
-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing firefox permission error message when assesing nodeType of a restricted html element (suc... (issue1369804)

2011-03-01 Thread Fred Sauer
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)

2011-01-05 Thread Fred Sauer
The test completes successfully on Safari 5.0.2 on OSX in web mode, although it fails in HTMLUnit. I've marked the test @DoNotRunWith({Platform.HtmlUnitUnknown}) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)

2010-12-15 Thread Fred Sauer
I left some of the hosted mode references, particularly around the internal bits of GWT, which most developers will never look at. There's still some stuff there which legitimately, I think, references hosted mode, so I stayed clear of those changes (for now). Happy to add any you think we should

[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)

2010-12-15 Thread Fred Sauer
Sorry. You're right. Apparently I missed some instances in files I did modify. That was not intentional. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix style.setOpacity() in IE8 (issue1077801)

2010-11-04 Thread Fred Sauer
and avoid this method. http://gwt-code-reviews.appspot.com/1077801/show -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)

2010-10-27 Thread Fred Sauer
: http://code.google.com/p/google-web-toolkit/issues/detail?id=5148 SplitLayoutPanel is one problem child; another is the ability to drag dialog windows, because it also assumes the existence of mousemove. On Oct 26, 8:10 am, Fred Sauer fre...@google.com wrote: Philip, Do you think

Re: [gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)

2010-10-27 Thread Fred Sauer
-Contributors -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)

2010-10-26 Thread Fred Sauer
: On 2010/09/14 00:49:29, fredsa wrote: I don't think this supports multi-touch events (i.e., the touches array), which I think needs to be in this. http://gwt-code-reviews.appspot.com/867801/show -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043

[gwt-contrib] Re: Fix deobfuscation of throwables with a cause (issue987801)

2010-10-12 Thread Fred Sauer
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix the DevMode Swing UI to avoid clipping buttons when the URL (issue952802)

2010-10-07 Thread Fred Sauer
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: GWT Development shell no longer cuts off the Launch Default Browser and Copy to Clipboard (issue758801)

2010-09-25 Thread Fred Sauer
/758801/show -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

2010-09-13 Thread Fred Sauer
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-10 Thread Fred Sauer
. http://gwt-code-reviews.appspot.com/855801/show -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] HTML5 audio support added to gwt-voices-2.0.0.jar

2010-08-31 Thread Fred Sauer
is always welcome. Enjoy-- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Continuation of r8542 to actually properly enables double click for (issue774801)

2010-08-17 Thread Fred Sauer
that addClickHandler is deprecated on that class. http://gwt-code-reviews.appspot.com/774801/show -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-04 Thread Fred Sauer
/730802/show -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Put in a new fix for DevMode logging that uses bytecode rewriting rather than swapping out (issue725801)

2010-08-03 Thread Fred Sauer
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

2010-08-02 Thread Fred Sauer
How's this? http://gwt-code-reviews.appspot.com/674804 On Mon, Aug 2, 2010 at 5:46 PM, fre...@google.com wrote: http://gwt-code-reviews.appspot.com/674804/show -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http

[gwt-contrib] Re: Update sample to use the latest features (issue672801)

2010-07-01 Thread Fred Sauer
/logexample/shared/LoggingService.java D samples/logexample/src/com/google/gwt/sample/logexample/shared/LoggingServiceAsync.java D samples/logexample/src/com/google/gwt/sample/logexample/shared/SharedLoggingLibrary.java -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway

Re: [gwt-contrib] Re: GWT Incubator Status Update and Schedule

2010-02-01 Thread Fred Sauer
a Wave -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- Fred Sauer Developer Advocate Google Inc.1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- http://groups.google.com

[gwt-contrib] gwt-dnd, gwt-log, gwt-voices updated for GWT 2.0

2009-12-11 Thread Fred Sauer
* - No more guessing; focus on fixing 4. Upgrade your *gwt-dnd / gwt-log / gwt-voices* projects to their respective GWT 2.0 versions http://code.google.com/p/gwt-log/ http://code.google.com/p/gwt-dnd/ http://code.google.com/p/gwt-voices/ Go GWT. Go. -- Fred Sauer Developer Advocate Google

[gwt-contrib] Re: Adding ClientBundle to trunk

2009-10-03 Thread Fred Sauer
Toolkit Team -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode

2009-09-21 Thread Fred Sauer
: If Bob and Kelly haven't objected to this by, say, lunch time tomorrow, can we get it submitted? This issue continues to bite people, and it would be nice to see it fixed before MS1 freezes RSN. http://gwt-code-reviews.appspot.com/56807 -- Fred Sauer Developer Advocate Google Inc

[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode

2009-09-21 Thread Fred Sauer
21, 2009 at 5:25 PM, Fred Sauer fre...@gmail.com wrote: [+Miguel] On that note: what about adding some nice defaults to appengine-web.xml as discussed here: http://code.google.com/p/google-web-toolkit/issues/detail?id=3592 This would be for project with both App Engine and GWT support

[gwt-contrib] Re: DTO compiler optimization

2009-08-11 Thread Fred Sauer
, not the least of which is the possibility that it would require basically rebuilding the GWT compiler. I'm just hoping that this discussion might answer other n00b questions in the future :) -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043

[gwt-contrib] Re: How to enable web mode debugging in GWT

2009-08-11 Thread Fred Sauer
that i can see the java stack trace in eclipse console, while running the application in IE. Thanks in advance. -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com --~--~-~--~~~---~--~~ http

[gwt-contrib] Invalid version number 2.0 passed to external.gwtOnLoad()

2009-08-11 Thread Fred Sauer
this be an issue? It would be great if GWT checked the contents of hosted.html and replaced the file if needed. Thoughts? -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com --~--~-~--~~~---~--~~ http

[gwt-contrib] Re: Invalid version number 2.0 passed to external.gwtOnLoad()

2009-08-11 Thread Fred Sauer
On Tue, Aug 11, 2009 at 5:14 PM, John Tamplin j...@google.com wrote: On Tue, Aug 11, 2009 at 7:50 PM, Fred Sauer fre...@google.com wrote: When switching GWT versions on my project I get this error (when I'm lucky): *[ERROR] Invalid version number 2.0 passed to external.gwtOnLoad

[gwt-contrib] Re: Invalid version number 2.0 passed to external.gwtOnLoad()

2009-08-11 Thread Fred Sauer
On Tue, Aug 11, 2009 at 5:47 PM, John Tamplin j...@google.com wrote: On Tue, Aug 11, 2009 at 8:22 PM, Fred Sauer fre...@google.com wrote: I'm not sure I understand the issue. If you have different versions of hosted.html and GWT, things are likely to not work and that is why that check

[gwt-contrib] Re: NOTICE - removing all @deprecated code for GWT 2.0

2009-08-07 Thread Fred Sauer
...@google.com I haven't actually tried any of this stuff. I'll definitely have a look when I hunker down to do this refactoring. Of course, if anyone wants to look into it before I get to it, that would be even cooler... :) On Mon, Aug 3, 2009 at 12:13 PM, Fred Sauer fre...@google.com wrote: I

[gwt-contrib] Re: NOTICE - removing all @deprecated code for GWT 2.0

2009-08-03 Thread Fred Sauer
in the schedule. Do we have to remove internal references to it before marking it deprecated? Obviously, those would have to be cleaned up before we actually remove it, but it doesn't seem necessary to require it earlier. -- John A. Tamplin Software Engineer (GWT), Google -- Fred Sauer

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-08-01 Thread Fred Sauer
with minor transformations. Making the transformations uniquely reversible would solve this. On Fri, Jul 31, 2009 at 5:38 PM, Fred Sauer fre...@google.com wrote: Perhaps one of bobs tricks will involve taking the `-style DETAILED` information which looks like

[gwt-contrib] NOTICE - removing all @deprecated code for GWT 2.0

2009-07-31 Thread Fred Sauer
such as the @SuppressWarnings annotation and your IDE's or build environment's settings. So, in general, chances are you are probably not using any deprecated GWT APIs without knowing about it. Thanks-- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com

[gwt-contrib] Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Fred Sauer
() at JavaScript.onBrowserEvent() at JavaScript.dispatchEventImpl() at JavaScript.dispatchEventAndCatch() at JavaScript.anonymous() Anyone have strong opinions wither way? -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Fred Sauer
maps to reverse lookup the Java idents. On Fri, Jul 31, 2009 at 2:42 PM, Fred Sauer fre...@google.com wrote: Web mode stack traces are steadily improving. You can even get line numbers (by inheriting com.google.gwt.core.EmulateJsStack). Without the extra instrumentation you web mode stack traces

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Fred Sauer
at 4:33 PM, Fred Sauer fre...@google.com wrote: You get the following, which notably can be pasted into Eclipse's Stack Trace Console view so that the filename:lineNumber pairs become clickable hyperlinks: That's just awesome beyond belief. -- Fred Sauer Developer Advocate Google

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Fred Sauer
31, 2009 at 5:00 PM, Fred Sauer fre...@google.com wrote: I can't wait! On Fri, Jul 31, 2009 at 4:58 PM, Bruce Johnson br...@google.com wrote: 4 cheers for Bob! w00t, w00t, w00t and w00t. Also, note that this is phase 1 in a larger plan. For Bob's next feat of magic, he's going to provide

[gwt-contrib] Re: GWT emulation of HTML5/CSS3 features

2009-06-30 Thread Fred Sauer
far the concepts match. Would be very cool to have a native table implementation on WebKit browsers while other fallback to gwt impls. What do you think? -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com

[gwt-contrib] Re: HelpRequired : GWT-Incubator: GlassPanel changes

2009-06-30 Thread Fred Sauer
, etc.). Maybe it's time to rewrite it, and/or split it into more a set of widgets, each one specialized on one thing (lightbox+dialog, cover part of the page, etc.)- Hide quoted text - - Show quoted text - -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway

[gwt-contrib] Re: GlassPanelImpl throws compiletime errors

2009-06-30 Thread Fred Sauer
GlassPanel.java to refer this CustomGlassPanelImpl instead of GlassPanelImpl. But still i get this error. Any help is really helpful and appreciated. Thanks, Surya -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com

[gwt-contrib] GWTTestCase fails to run other module's onModuleLoad() methods

2009-06-29 Thread Fred Sauer
Scott, IIRC, you were most recently working on GWTTestCase changes. I just filed this issue which is throwing gwt-log users trying to use GWTTestCase: http://code.google.com/p/google-web-toolkit/issues/detail?id=3791 I hoping the described behavior is not as designed. Thanks -- Fred Sauer

[gwt-contrib] Re: Fix issue 3677: gwt-module.dtd does not reflect changes to configuration properties

2009-06-17 Thread Fred Sauer
Related issue: http://code.google.com/p/google-web-toolkit/issues/detail?id=3667 On Wed, Jun 17, 2009 at 12:28 PM, b...@google.com wrote: LGTM http://gwt-code-reviews.appspot.com/34819 -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre

[gwt-contrib] Re: possible ant changes

2009-05-27 Thread Fred Sauer
/test_underbar as java-root directories with the obvious subset of files from today's user/test, and an adjustment to the test target one or the other is on classpath, controlled I think by a system property. Thoughts on that? -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre

[gwt-contrib] Re: Quick code review: NativeEvent.getCurrentTarget() sometimes returns null on Safari 3

2009-03-17 Thread Fred Sauer
) || 0; }-*/; -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Quick code review: NativeEvent.getCurrentTarget() sometimes returns null on Safari 3

2009-03-17 Thread Fred Sauer
: This also fixes the scroll-relative coordinates issue. I just created a code review here: http://gwt-code-reviews.appspot.com/13803 On Tue, Mar 17, 2009 at 4:03 PM, Fred Sauer fre...@google.com wrote: Joel, The null problem is gone. However, with JOEL_PATCH = true, the event.getX/Y

[gwt-contrib] Re: Just what the heck is the document root, anyway?

2009-03-10 Thread Fred Sauer
to simply redefine it, which would make all these problems go away. @Fred: I seem to recall discussing some of the ins and outs of this with you in the past. Any opinions? Thanks, joel. -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre

[gwt-contrib] Re: Just what the heck is the document root, anyway?

2009-03-10 Thread Fred Sauer
/12802 Bruce has been reviewing most of the details, but would you mind having a look to see if these APIs are sufficient to deal with the problems you've run into in DragDrop and GlassPanel? Many thanks, joel. On Tue, Mar 10, 2009 at 12:25 PM, Fred Sauer fre...@google.com wrote: Joel, I

[gwt-contrib] Re: RR: Adding .project to gwt-incubator root directory

2008-11-17 Thread Fred Sauer
No objections :) Fred Sauer [EMAIL PROTECTED] On Mon, Nov 17, 2008 at 1:18 PM, Emily Crutcher [EMAIL PROTECTED] wrote: Several months ago we had the discussion of whether it was worth polluting the root directory of gwt-incubator with eclipse specific project files in order to make sub

[gwt-contrib] Re: Commits Code Reviews

2008-11-13 Thread Fred Sauer
Jay, You'll find a similar request among the comments of this (now closed/fixed) issue: http://code.google.com/p/support/issues/detail?id=190 Assuming you don't find an existing issue to star, you can add your request here: http://code.google.com/p/support/issues/list Fred Sauer [EMAIL

[gwt-contrib] Re: Request for smoke testers for 1.5.3

2008-10-17 Thread Fred Sauer
Thanks Amit, How about an issue for the getAbsoluteTop()/Left() change? That's a significant change and deserves and issue for future reference. Fred Sauer [EMAIL PROTECTED] On Fri, Oct 17, 2008 at 7:54 AM, Amit Manjhi [EMAIL PROTECTED] wrote: My mistake. I corrected it to r3751

[gwt-contrib] Re: Request for smoke testers for 1.5.3

2008-10-16 Thread Fred Sauer
=status%3AFixed%2CFixedNotReleased%20milestone%3A1_5_3num=1000 2. Comment #6 in issue 2950 (Time.valueOf fails with 08 and 09 numbers) refers to r3743 which is the wrong commit for this issue Fred Sauer [EMAIL PROTECTED] On Thu, Oct 16, 2008 at 7:39 PM, Ray Ryan [EMAIL PROTECTED] wrote

[gwt-contrib] coordinate cleanup in r3364 broke RootPanel.add(widget, 0, 0) for 1px BODY borders in IE quirks mode

2008-10-14 Thread Fred Sauer
Joel, I know you're just dying to revisit the coordinate system cleanups from r3364. That opportunity now exists as issue 2981 :) http://code.google.com/p/google-web-toolkit/issues/detail?id=2981 RootPanel.add(widget, 0, 0) with 1px border results in static positioning in IE quirks Fred

[gwt-contrib] Re: Code Review Request - Issue 2667 - Style should assert that property names do not contain hyphens

2008-09-18 Thread Fred Sauer
I think this is a very valuable assertion, which has the potential to save many new comers (and even veterans) a lot of grief. If somehow a couple of valid hyphen use cases came up, I'd probably try to special case them and keep the assertion if at all possible. Fred Sauer [EMAIL PROTECTED

[gwt-contrib] Re: RR : Allow define-property to redefine an existing property

2008-09-09 Thread Fred Sauer
+1 I think this would be very useful. Indeed it would allow me to simplify my .gwt.xml files in gwt-log a great deal. Thanks Fred Sauer [EMAIL PROTECTED] On Tue, Sep 9, 2008 at 5:33 PM, BobV [EMAIL PROTECTED] wrote: This patch against trunk allows multiple define-property tags for the same