Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2084
Add 2-3 test cases for time series feature also
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2084#discussion_r177429936
--- Diff:
core/src/main/java/org/apache/carbondata/events/OperationContext.java ---
@@ -41,4 +41,12 @@ public void setProperty(String key, Object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2107#discussion_r177410099
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
---
@@ -338,7 +339,23 @@ public static
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2107#discussion_r177409405
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/MeasureFieldConverterImpl.java
---
@@ -95,8 +95,9
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2102#discussion_r177395959
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
---
@@ -584,6 +589,98
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2102#discussion_r177395322
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
---
@@ -584,6 +589,98
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2102#discussion_r177395075
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
---
@@ -584,6 +589,98
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2067
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2083#discussion_r176992476
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
---
@@ -475,6 +603,25 @@ case class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2083#discussion_r176990583
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
@@ -143,11 +143,15 @@ protected CarbonTable
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2097#discussion_r176899943
--- Diff:
core/src/main/java/org/apache/carbondata/core/writer/CarbonDeleteDeltaWriterImpl.java
---
@@ -81,7 +80,9 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2097#discussion_r176899945
--- Diff:
core/src/main/java/org/apache/carbondata/core/writer/CarbonDeleteDeltaWriterImpl.java
---
@@ -110,7 +111,9 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2084#discussion_r176651976
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala
---
@@ -249,6 +251,91 @@ class
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2075
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2079
LGTM
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2086
[CARBONDATA-2181] Thread Leak during compaction processing on restructured
table
**Problem**
Thread leak in compaction operation
**Analysis**
Compaction uses both query
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2031
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2031#discussion_r175657383
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -151,10 +153,10 @@ private
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2031
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2063#discussion_r175361959
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/MergeIndexTestCase.scala
---
@@ -45,7
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1812
I agree with @gvramana
1. We should not use Major/Minor compaction type as they have a specific
meaning and both are controlled by the system for taking decisions whether
segment
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1936
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1936#discussion_r170418767
--- Diff: docs/data-management-on-carbondata.md ---
@@ -286,7 +286,40 @@ This tutorial is going to introduce all commands and
data operations
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1991#discussion_r170412687
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
@@ -117,22 +117,25 @@ public static
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1979
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1980
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1980#discussion_r169895776
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala
---
@@ -110,7 +111,8
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1979#discussion_r169886144
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala
---
@@ -271,7 +271,7 @@ class
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1934
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1978
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169858244
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeDecimalColumnPage.java
---
@@ -217,6 +217,6 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169544845
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -0,0 +1,690 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169544627
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -0,0 +1,690 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169544464
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -0,0 +1,690 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169543473
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -0,0 +1,690 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169543287
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -0,0 +1,690 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169542459
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ---
@@ -0,0 +1,690 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169518712
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169540773
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -79,6 +87,44 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169537887
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -660,22 +650,23 @@ public boolean
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169518845
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169540997
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -161,9 +212,13 @@ private
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169520945
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeDecimalColumnPage.java
---
@@ -217,6 +217,6 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1984#discussion_r169522942
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/TableBlockIndexUniqueIdentifier.java
---
@@ -17,91 +17,59
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168714751
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepForPartitionImpl.java
---
@@ -0,0 +1,251
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168705495
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -592,41 +666,12
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168700461
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -544,17 +547,76
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168677068
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -104,6 +104,38 @@ public static Object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168699514
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -676,6 +734,48
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168677700
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
---
@@ -122,7 +119,11 @@ public CarbonOutputCommitter
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168416054
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeDecimalColumnPage.java
---
@@ -217,6 +217,6 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168700095
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -676,6 +734,48
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1939#discussion_r168386909
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableAsSelect.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1939#discussion_r168123320
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableAsSelect.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1939#discussion_r168085698
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableAsSelect.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1939#discussion_r168085120
--- Diff: .gitignore ---
@@ -15,4 +15,5 @@ target/
.project
.classpath
metastore_db/
-derby.log
\ No newline at end of file
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1939#discussion_r168085211
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableAsSelect.scala
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1934
@anubhav100 ... In your PR description above no need to mention about the
code details...that will be reviewed as part of your PRkindly remove the
code details from PR description
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1934#discussion_r168083518
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
---
@@ -544,6 +546,13
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1934#discussion_r168083426
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -720,21 +721,22 @@ private static String
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1932
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1932#discussion_r165971754
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
---
@@ -128,6 +128,24
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1948#discussion_r166842293
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -586,16 +586,27 @@ private int
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1935
[CARBONDATA-2134] Prevent implicit column filter list from getting
serialized while submitting task to executor
**Problem**
In the current store blocklet pruning in driver
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1914#discussion_r165812799
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -1891,7 +1892,12 @@ public static boolean
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1914#discussion_r165809266
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/badrecordloger/BadRecordActionTest.scala
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1907
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1914#discussion_r165676157
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataLoadingUtil.scala
---
@@ -229,11 +229,11 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1914#discussion_r165674058
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -1891,7 +1892,8 @@ public static boolean validateValidIntType
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1914#discussion_r165675863
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/badrecordloger/BadRecordActionTest.scala
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1747
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1906
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1897
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1895
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1819
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1885#discussion_r164956772
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala
---
@@ -249,6 +249,27 @@ class DDLStrategy
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1879#discussion_r164953838
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataRefNodeWrapper.java
---
@@ -132,13 +132,48
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1875
@ravipesala ..handled review comments and fixed failing test case..kindly
review and merge
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1879
[WIP] Fix measure min/max value problem while reading from old store
Modified code to fix measure min/max problem in old store. Problem in query
comes when measure contains a negative
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1875
[CARBONDATA-2092] Fix compaction bug to prevent the compaction flow from
going through the restructure compaction flow
**Problem and analysis:**
During data load current schema
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1819
LGTM...will merge once SDV build passes
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1839
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1844
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1819#discussion_r164342705
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/DataLoadingTestCase.scala
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1817
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1839#discussion_r164339675
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/HorizontalCompactionTestCase.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1839#discussion_r164339708
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/HorizontalCompactionTestCase.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1844#discussion_r164338912
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -700,11 +708,30 @@ public static Boolean
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1838
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1833
retest this please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1833
retest sdv please
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1833#discussion_r162600231
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1822
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1832
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1833#discussion_r162419365
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -243,7 +243,7
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1796
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1830
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1818
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1810
LGTM
---
Github user manishgupta88 closed the pull request at:
https://github.com/apache/carbondata/pull/1032
---
501 - 600 of 771 matches
Mail list logo
