[GitHub] carbondata pull request #1806: modify default config: change the default of ...

2018-01-15 Thread qiuchenjian
GitHub user qiuchenjian opened a pull request: https://github.com/apache/carbondata/pull/1806 modify default config: change the default of tempCSV to false qiuchenjian tempCSV model generates file to hdfs and then generate sql "load data" ,it depends muc

[GitHub] carbondata issue #1806: modify default config: change the default of tempCSV...

2018-01-19 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/1806 retest this please ---

[GitHub] carbondata pull request #1899: [CARBONDATA-2109]make configs of dataframe lo...

2018-01-31 Thread qiuchenjian
GitHub user qiuchenjian opened a pull request: https://github.com/apache/carbondata/pull/1899 [CARBONDATA-2109]make configs of dataframe load with tempCSV valid ,such as QUOTECHAR Be sure to do all of the following checklist to help us incorporate your contribution quickly

[GitHub] carbondata issue #1899: [CARBONDATA-2109]make configs of dataframe load with...

2018-02-01 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/1899 retest this please ---

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

2018-02-02 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/1916 @jackylk ,fix bugs as mentioned ---

[GitHub] carbondata pull request #1916: [CARBONDATA-2110]deprecate 'tempCSV' option o...

2018-02-02 Thread qiuchenjian
GitHub user qiuchenjian opened a pull request: https://github.com/apache/carbondata/pull/1916 [CARBONDATA-2110]deprecate 'tempCSV' option of dataframe load deprecate 'tempCSV' option of dataframe load, it won't generate temp file on hdfs, no matter the value of tempCSV You

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

2018-02-02 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/1916 I think the tests with tempCSV need be kept, because the customer is still using the option @jackylk ---

[GitHub] carbondata pull request #1899: [CARBONDATA-2109]make configs of dataframe lo...

2018-02-03 Thread qiuchenjian
Github user qiuchenjian closed the pull request at: https://github.com/apache/carbondata/pull/1899 ---

[GitHub] carbondata issue #1899: [CARBONDATA-2109]make configs of dataframe load with...

2018-01-31 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/1899 retest this please ---

[GitHub] carbondata issue #1899: [CARBONDATA-2109]make configs of dataframe load with...

2018-01-31 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/1899 @xuchuanyin , I agree, this 'tempCSV' option has serveral bugs to fix ---

[GitHub] carbondata issue #2684: [CARBONDATA-2908]the option of sort_scope don't effe...

2018-09-05 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2684 @jackylk revert the change of thrift, only solve sortScope ---

[GitHub] carbondata issue #2684: [CARBONDATA-2908]the option of sort_scope don't effe...

2018-09-05 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2684 retest this please ---

[GitHub] carbondata issue #2684: [CARBONDATA-2908]the option of sort_scope don't effe...

2018-09-05 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2684 retest this please ---

[GitHub] carbondata issue #2684: [CARBONDATA-2908]the option of sort_scope don't effe...

2018-09-04 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2684 @jackylk properties of table can be add to TableProperty in schema.thrift ---

[GitHub] carbondata pull request #2684: [CARBONDATA-2908]the option of sort_scope don...

2018-09-02 Thread qiuchenjian
GitHub user qiuchenjian opened a pull request: https://github.com/apache/carbondata/pull/2684 [CARBONDATA-2908]the option of sort_scope don't effects while creatin… …g table by data frame Be sure to do all of the following checklist to help us incorporate your

[GitHub] carbondata pull request #2684: [CARBONDATA-2908]the option of sort_scope don...

2018-09-03 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2684#discussion_r214623582 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala --- @@ -81,6 +81,7 @@ class CarbonDataFrameWriter

[GitHub] carbondata issue #3029: [CARBONDATA-3200] No-Sort compaction

2018-12-27 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3029 Need it add a param to control whether to sort when no_sort? Maybe user only want to merge small segments to a big segment, slow data merging may be unaccepted ---

[GitHub] carbondata pull request #3029: [CARBONDATA-3200] No-Sort compaction

2018-12-27 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3029#discussion_r244252283 --- Diff: processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java --- @@ -105,10 +107,10 @@ public

[GitHub] carbondata pull request #3031: [CARBONDATA-3212] Fixed NegativeArraySizeExce...

2018-12-27 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3031#discussion_r244269580 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java --- @@ -140,6 +140,7 @@ public boolean

[GitHub] carbondata pull request #3039: [CARBONDATA-3217] Optimize implicit filter ex...

2019-01-01 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3039#discussion_r244654748 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java --- @@ -0,0 +1,109

[GitHub] carbondata pull request #3039: [CARBONDATA-3217] Optimize implicit filter ex...

2019-01-01 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3039#discussion_r244654723 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java --- @@ -0,0 +1,109

[GitHub] carbondata pull request #3041: [CARBONDATA-3218] Fix schema refresh and wron...

2019-01-01 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3041#discussion_r244655257 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -234,30 +219,26 @@ public TBase create

[GitHub] carbondata pull request #3044: [CARBONDATA-3202]Documentation for alter tabl...

2019-01-02 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r244677596 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,28 @@ Users can specify which columns to include and exclude for local dictionary gene

[GitHub] carbondata pull request #3044: [CARBONDATA-3202]Documentation for alter tabl...

2019-01-02 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r244676690 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,28 @@ Users can specify which columns to include and exclude for local dictionary gene

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244895354 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -101,14 +102,21 @@ object CarbonStore

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505699 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -697,9 +697,9 @@ abstract class

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505691 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -668,9 +668,9 @@ abstract class

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505788 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -837,9 +837,9 @@ abstract class

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505775 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -821,10 +821,10 @@ abstract class

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505760 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -796,10 +796,10 @@ abstract class

[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3052 add to whitelist ---

[GitHub] carbondata pull request #2985: [HOTFIX] Fixed Query performance issue

2018-12-12 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2985#discussion_r241285610 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java --- @@ -663,6 +663,12 @@ public boolean hasNext

[GitHub] carbondata pull request #2984: [CARBONDATA-3165]Protection of Bloom Null Exc...

2018-12-12 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2984#discussion_r241298414 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -227,6 +231,12 @@ private String

[GitHub] carbondata pull request #2713: [WIP][CARBONDATA-2931][BloomDataMap] Optimize...

2018-12-17 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2713#discussion_r242393730 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -178,15 +178,9 @@ private String

[GitHub] carbondata pull request #2713: [WIP][CARBONDATA-2931][BloomDataMap] Optimize...

2018-12-17 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2713#discussion_r242387613 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java --- @@ -218,56 +218,46 @@ public

[GitHub] carbondata pull request #2993: [CARBONDATA-3179] Map data load failure

2018-12-17 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2993#discussion_r242435030 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateDDLForComplexMapType.scala

[GitHub] carbondata pull request #2713: [WIP][CARBONDATA-2931][BloomDataMap] Optimize...

2018-12-17 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2713#discussion_r242430992 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java --- @@ -218,56 +218,46 @@ public

[GitHub] carbondata pull request #2993: [CARBONDATA-3179] Map data load failure

2018-12-18 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2993#discussion_r242436603 --- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/parser/FieldConverter.scala --- @@ -66,30 +65,57 @@ object FieldConverter

[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue

2018-12-20 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3010 Can you show up the error message when load and query failing ---

[GitHub] carbondata pull request #3017: [HOTFIX] remove this useless assignment

2018-12-23 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3017#discussion_r243780410 --- Diff: core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java --- @@ -112,7 +112,7 @@ public LocalFileLock(String

[GitHub] carbondata issue #3025: [CARBONDATA-3199]"show datamap" represents preaggreg...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3025 retest this please ---

[GitHub] carbondata pull request #3025: [CARBONDATA-3199]"show datamap" represents pr...

2018-12-26 Thread qiuchenjian
GitHub user qiuchenjian opened a pull request: https://github.com/apache/carbondata/pull/3025 [CARBONDATA-3199]"show datamap" represents preaggregate datamap [Problem] "show datamap" command doesn't represents preaggregate datamap, it only represents

[GitHub] carbondata pull request #3023: [CARBONDATA-3197][BloomDataMap] Merge bloom i...

2018-12-25 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3023#discussion_r243927801 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala --- @@ -24,59 +24,88 @@ import

[GitHub] carbondata pull request #2970: [CARBONDATA-3142]Add timestamp with thread na...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2970#discussion_r244013967 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java --- @@ -144,14 +144,14 @@ private

[GitHub] carbondata pull request #2970: [CARBONDATA-3142]Add timestamp with thread na...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2970#discussion_r244013978 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java --- @@ -144,14 +144,14 @@ private

[GitHub] carbondata pull request #2970: [CARBONDATA-3142]Add timestamp with thread na...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2970#discussion_r244013962 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java --- @@ -34,14 +34,26 @@ */ private String name

[GitHub] carbondata pull request #2970: [CARBONDATA-3142]Add timestamp with thread na...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2970#discussion_r244065663 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java --- @@ -34,14 +34,26 @@ */ private String name

[GitHub] carbondata issue #3026: [WIP] Added support to compile carbon CDH spark dist...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3026 Does carbon not support Cdh using -Pspark-2.2 ? Does CDH change the spark interface ,so that carbon can't run succesfully ? ---

[GitHub] carbondata pull request #3026: [WIP] Added support to compile carbon CDH spa...

2018-12-27 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3026#discussion_r244137998 --- Diff: integration/spark-datasource/src/main/spark2.1andspark2.2/org/apache/spark/sql/CarbonDictionaryReflectionUtil.java --- @@ -0,0 +1,118

[GitHub] carbondata pull request #3028: [CARBONDATA-3205]Fix Get Local Dictionary for...

2018-12-27 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3028#discussion_r244142318 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java --- @@ -197,6 +197,10 @@ public static

[GitHub] carbondata issue #3026: [WIP] Added support to compile carbon CDH spark dist...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3026 @ravipesala sorry,i didn't notice it, now i know the purpose ---

[GitHub] carbondata issue #3025: [WIP][CARBONDATA-3199]"show datamap" represents prea...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3025 > @qiuchenjian currently pre-aggregate datamap is not following the datamap interfaces as it was implemented before datamap framework. That is why not all datamap DDL works with

[GitHub] carbondata pull request #3025: [WIP][CARBONDATA-3199]"show datamap" represen...

2018-12-26 Thread qiuchenjian
Github user qiuchenjian closed the pull request at: https://github.com/apache/carbondata/pull/3025 ---

[GitHub] carbondata pull request #2970: [CARBONDATA-3142]Add timestamp with thread na...

2018-12-10 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2970#discussion_r240447425 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java --- @@ -34,14 +34,26 @@ */ private String name

[GitHub] carbondata issue #2970: [CARBONDATA-3142]Add timestamp with thread name whic...

2018-12-10 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2970 > @qiuchenjian the checklist should be select correctly, you can refer #2981 or other PR done ---

[GitHub] carbondata pull request #2984: [CARBONDATA-3165]Protection of Bloom Null Exc...

2018-12-12 Thread qiuchenjian
GitHub user qiuchenjian opened a pull request: https://github.com/apache/carbondata/pull/2984 [CARBONDATA-3165]Protection of Bloom Null Exception Problem: 24274.0 (TID 664711) | org.apache.spark.internal.Logging$class.logError(Logging.scala:91

[GitHub] carbondata pull request #2963: [CARBONDATA-3139] Fix bugs in MinMaxDataMap e...

2018-12-11 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2963#discussion_r240581131 --- Diff: datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/AbstractMinMaxDataMapWriter.java --- @@ -0,0 +1,248

[GitHub] carbondata pull request #2984: [CARBONDATA-3165]Protection of Bloom Null Exc...

2018-12-13 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2984#discussion_r241617708 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -227,6 +231,12 @@ private String

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-16 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242010744 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-16 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242007987 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-16 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242010398 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

2018-12-24 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3020 I think you need describe this validation in the ddl-of-carbondata.md of Inverted Index Configuration part ---

[GitHub] carbondata issue #3021: [CARBONDATA-3193] Cdh5.14.2 spark2.2.0 support

2018-12-24 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3021 Does carbon not support Cdh5.14.2 spark2.2.0 using -Pspark-2.2 ? Did CDH change the spark interface ,so that carbon can't run succesfully ? ---

[GitHub] carbondata pull request #3019: [CARBONDATA-3194] Integrating Carbon with Pre...

2018-12-24 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3019#discussion_r243822523 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java --- @@ -113,7 +132,7 @@ private

[GitHub] carbondata pull request #3019: [CARBONDATA-3194] Integrating Carbon with Pre...

2018-12-24 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3019#discussion_r243821704 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java --- @@ -43,63 +44,81

[GitHub] carbondata pull request #3023: [CARBONDATA-3197][BloomDataMap] Merge bloom i...

2018-12-25 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3023#discussion_r243904016 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala --- @@ -24,59 +24,88 @@ import

[GitHub] carbondata pull request #3023: [CARBONDATA-3197][BloomDataMap] Merge bloom i...

2018-12-25 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3023#discussion_r243901940 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala --- @@ -24,59 +24,88 @@ import

[GitHub] carbondata pull request #3023: [CARBONDATA-3197][BloomDataMap] Merge bloom i...

2018-12-25 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3023#discussion_r243902213 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala --- @@ -24,59 +24,88 @@ import

[GitHub] carbondata pull request #2988: [CARBONDATA-3174] Fix trailing space issue wi...

2018-12-14 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2988#discussion_r241934868 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-14 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r241935024 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -1464,31 +1464,46 @@ abstract

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-14 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r241935317 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala --- @@ -286,12 +286,16 @@ class

[GitHub] carbondata pull request #2984: [CARBONDATA-3165]Protection of Bloom Null Exc...

2018-12-15 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2984#discussion_r241950006 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -227,6 +231,12 @@ private String

[GitHub] carbondata issue #3008: Carbonfile

2018-12-20 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3008 i think your branch of carbonfile is confused ---

[GitHub] carbondata pull request #2987: [CARBONDATA-3167] Add a example for DataFrame...

2018-12-13 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2987#discussion_r241619313 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataFrameSDKS3Example.scala --- @@ -0,0 +1,184 @@ +/* + * Licensed

[GitHub] carbondata pull request #2987: [CARBONDATA-3167] Add a example for DataFrame...

2018-12-13 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2987#discussion_r241619136 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataFrameSDKS3Example.scala --- @@ -0,0 +1,184 @@ +/* + * Licensed

[GitHub] carbondata pull request #2966: [WIP] test and check no sort by default

2018-11-29 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2966#discussion_r237726222 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/DataMapWriterSuite.scala --- @@ -156,8 +156,7

[GitHub] carbondata pull request #2964: [HOTFIX] Fix ArrayOutOfBound exception when d...

2018-11-29 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2964#discussion_r237715058 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -575,7 +575,7 @@ public void testReadColumnTwice

[GitHub] carbondata pull request #2961: Fixing the getOrCreateCarbonSession method pa...

2018-11-28 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2961#discussion_r237335152 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala --- @@ -248,7 +248,7 @@ object CarbonSession

[GitHub] carbondata pull request #2975: [WIP][CARBONDATA-3145] Read improvement for c...

2018-12-05 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2975#discussion_r238989259 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/ComplexQueryType.java --- @@ -29,6 +32,8 @@ protected int

[GitHub] carbondata pull request #2975: [WIP][CARBONDATA-3145] Read improvement for c...

2018-12-05 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2975#discussion_r238971934 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/ComplexQueryType.java --- @@ -29,6 +32,8 @@ protected int

[GitHub] carbondata issue #2970: [CARBONDATA-3142]Add timestamp with thread name whic...

2018-12-03 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2970 > Please add more description , why we need this pr. thanks. Done ---

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-07 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r239991055 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/parser/impl/RowParserImpl.java --- @@ -34,8 +37,12 @@ private

[GitHub] carbondata issue #2975: [WIP][CARBONDATA-3145] Read improvement for complex ...

2018-12-07 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2975 @dhatchayani I read the DimensionRawColumnChunk, this class has cache the decoded DimensionColumnPage, is your Map added useful? public DimensionColumnPage decodeColumnPage

[GitHub] carbondata pull request #2971: [TEST] Test loading performance of range_sort

2018-12-03 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r238290309 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala --- @@ -156,4 +158,132

[GitHub] carbondata pull request #2971: [TEST] Test loading performance of range_sort

2018-12-03 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r238292207 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala --- @@ -156,4 +158,132

[GitHub] carbondata pull request #2971: [TEST] Test loading performance of range_sort

2018-12-03 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2971#discussion_r238297683 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java --- @@ -188,6 +188,8

[GitHub] carbondata pull request #2977: [WIP] [CARBONDATA-3147] Fixed concurrent load...

2018-12-05 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2977#discussion_r239299140 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala --- @@ -156,20

[GitHub] carbondata issue #2975: [WIP][CARBONDATA-3145] Read improvement for complex ...

2018-12-07 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2975 Are the decoded DimensionColumnPage are cached in DimensionRawColumnChunk, so the function of cache is used by other code. Such as, DimensionRawColumnChunk contains a Map cacheDimPages

[GitHub] carbondata pull request #2974: [CARBONDATA-2563][CATALYST] Explain query wit...

2018-12-09 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2974#discussion_r240065228 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonExplainCommand.scala --- @@ -51,8 +51,8 @@ case

[GitHub] carbondata issue #2970: [CARBONDATA-3142]Add timestamp with thread name whic...

2018-12-10 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/2970 @KanakaKumar @ravipesala @jackylk @kunal642 @ajantha-bhat @xubo245 @QiangCai CI pass, Please review it. ---

[GitHub] carbondata pull request #2982: [CARBONDATA-3158] support presto-carbon to re...

2018-12-10 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2982#discussion_r240233846 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -364,23 +355,38 @@ private CarbonTable

[GitHub] carbondata pull request #2982: [CARBONDATA-3158] support presto-carbon to re...

2018-12-10 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2982#discussion_r240229604 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -364,23 +355,38 @@ private CarbonTable

[GitHub] carbondata pull request #2966: [WIP] test and check no sort by default

2018-11-29 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2966#discussion_r237763480 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/DataMapWriterSuite.scala --- @@ -156,8 +156,7

[GitHub] carbondata pull request #2963: [CARBONDATA-3139] Fix bugs in MinMaxDataMap e...

2018-11-29 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2963#discussion_r237452138 --- Diff: datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/AbstractMinMaxDataMapWriter.java --- @@ -0,0 +1,248

[GitHub] carbondata pull request #2964: [HOTFIX] Fix ArrayOutOfBound exception when d...

2018-11-29 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2964#discussion_r237505549 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -575,7 +575,7 @@ public void testReadColumnTwice

[GitHub] carbondata pull request #2974: [CARBONDATA-2563][CATALYST] Explain query wit...

2018-12-04 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2974#discussion_r238906069 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonExplainCommand.scala --- @@ -51,8 +51,8 @@ case

[GitHub] carbondata pull request #2953: [CARBONDATA-3132]Correct the task disrtibutio...

2018-11-26 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2953#discussion_r236543235 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java --- @@ -536,7 +537,8 @@ public static Dictionary

[GitHub] carbondata pull request #2956: [CARBONDATA-3134] fixed null values when cach...

2018-11-27 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2956#discussion_r236685568 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java --- @@ -332,13 +334,42 @@ public

[GitHub] carbondata pull request #2956: [CARBONDATA-3134] fixed null values when cach...

2018-11-27 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2956#discussion_r236689465 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java --- @@ -332,13 +334,42 @@ public

[GitHub] carbondata pull request #2960: [WIP] Update the Project List

2018-11-28 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2960#discussion_r237099347 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -388,9 +388,15

  1   2   >