[jira] [Created] (MATH-1438) Git cleanup

2017-12-25 Thread Gilles (JIRA)
Gilles created MATH-1438: Summary: Git cleanup Key: MATH-1438 URL: https://issues.apache.org/jira/browse/MATH-1438 Project: Commons Math Issue Type: Task Reporter: Gilles Prio

[jira] [Commented] (MATH-1437) Add/extend unit tests for o.a.c.m.geometry.partitioning and related packages

2017-12-25 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303185#comment-16303185 ] Gilles commented on MATH-1437: -- Thanks for contributing to this package. Beware to not use ta

[jira] [Resolved] (MATH-1436) PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues

2017-12-25 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1436. -- Resolution: Fixed Merged in "master" (with tabs removed). > PolygonsSet Infinite Lines and SubOrientedPoint Tole

[jira] [Commented] (NUMBERS-50) Clean checkstyle for Complex

2017-12-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302635#comment-16302635 ] Gilles commented on NUMBERS-50: --- bq. option is to change the subject and extend the scope to

[jira] [Commented] (MATH-1436) PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues

2017-12-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301260#comment-16301260 ] Gilles commented on MATH-1436: -- bq. do you mean to close this issue and create two new ones wi

[jira] [Commented] (MATH-1436) PolygonsSet Infinite Lines and SubOrientedPoint Tolerance Issues

2017-12-21 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300149#comment-16300149 ] Gilles commented on MATH-1436: -- Hello. Thank you for the report and fixes. bq. These are two

[jira] [Updated] (RNG-37) Ziggurat algorithm

2017-12-20 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated RNG-37: -- Attachment: RNG-37.patch ziggurat.patch.png Attached patch to code currently in "master" (review welcome), a

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-12-18 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294801#comment-16294801 ] Gilles commented on RNG-37: --- bq. I can't help you with this, I've too many higher priority tasks on

[jira] [Updated] (RNG-37) Ziggurat algorithm

2017-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated RNG-37: -- Attachment: ziggurat.buggy.png The attached plot contains about 19 points: For each x-coordinate produced by {{nextDoub

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292375#comment-16292375 ] Gilles commented on RNG-37: --- bq. If you think it doesn't make a check for the wholes, It doesn't. A

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-12-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292288#comment-16292288 ] Gilles commented on RNG-37: --- bq. I didn't get your last message "Fix Version/s" ?? I guess that you

[jira] [Updated] (RNG-37) Ziggurat algorithm

2017-12-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated RNG-37: -- Fix Version/s: 1.1 > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-12-11 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285686#comment-16285686 ] Gilles commented on RNG-37: --- bq. All parameters values has been taken from the paper and are for 32

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-12-09 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284697#comment-16284697 ] Gilles commented on RNG-37: --- bq. keeps only 7 bits out of the 32 Sorry, this is incorrect: the valu

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-12-08 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283664#comment-16283664 ] Gilles commented on RNG-37: --- Hi [~cur4so]. I ran the benchmark; table is available in the [usergui

[jira] [Commented] (NUMBERS-50) Clean checkstyle for Complex

2017-12-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276173#comment-16276173 ] Gilles commented on NUMBERS-50: --- bq. I have changed two lines in pom.xml {{true}}{{true}}

[jira] [Commented] (NUMBERS-50) Clean checkstyle for Complex

2017-12-02 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275516#comment-16275516 ] Gilles commented on NUMBERS-50: --- bq. the only issues I found was in target of the complex

[jira] [Commented] (NUMBERS-50) Clean checkstyle for Complex

2017-12-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275202#comment-16275202 ] Gilles commented on NUMBERS-50: --- I don't understand the purpose of the patch (it seems that

[jira] [Commented] (MATH-1435) Implement cKMeans as a clustering algorithm

2017-11-10 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247395#comment-16247395 ] Gilles commented on MATH-1435: -- bq. Please assign the ticket to me The JIRA config does not a

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-10-11 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199972#comment-16199972 ] Gilles commented on RNG-37: --- Merged in "master" with minor changes. > Ziggurat algorithm >

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-10-10 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199505#comment-16199505 ] Gilles commented on RNG-37: --- {{git}} reports a conflict when I try to pull the latest set of changes

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-10-09 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196960#comment-16196960 ] Gilles commented on RNG-37: --- Sorry for the delay. Bruno, thanks a lot for the review and advice. :)

[jira] [Commented] (MATH-1433) BaseMultiStartMultivariateOptimizer.doOptimize() swallows exceptions

2017-10-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191496#comment-16191496 ] Gilles commented on MATH-1433: -- Could you provide a fully working code that illustrates the is

[jira] [Commented] (RNG-37) Ziggurat algorithm

2017-10-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189554#comment-16189554 ] Gilles commented on RNG-37: --- Hi Olga. I've just quickly read through the proposed code; here are a

[jira] [Created] (RNG-40) Ready for JDK 9 ?

2017-09-20 Thread Gilles (JIRA)
Gilles created RNG-40: - Summary: Ready for JDK 9 ? Key: RNG-40 URL: https://issues.apache.org/jira/browse/RNG-40 Project: Commons RNG Issue Type: Task Reporter: Gilles Fix For: 1

[jira] [Updated] (MATH-1430) Singularity check in QRDecomposition

2017-08-25 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated MATH-1430: - Attachment: MATH-1430.unit_test.diff Unit tests (see attached patch) suggest that * the default value of the thresh

[jira] [Created] (MATH-1430) Singularity check in QRDecomposition

2017-08-25 Thread Gilles (JIRA)
Gilles created MATH-1430: Summary: Singularity check in QRDecomposition Key: MATH-1430 URL: https://issues.apache.org/jira/browse/MATH-1430 Project: Commons Math Issue Type: Improvement Affects V

[jira] [Commented] (RNG-31) Missing signature and checksum files (release process)

2017-08-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128780#comment-16128780 ] Gilles commented on RNG-31: --- >From now on, SHA-512 should be generated (instead of SHA-1): http://ww

[jira] [Resolved] (MATH-1429) Delete "UnitSphereRandomVectorGenerator"

2017-08-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1429. -- Resolution: Done commit 2c6e3404bc72e76b2e9d308121368f09b723c8df > Delete "UnitSphereRandomVectorGenerator" > --

[jira] [Created] (MATH-1429) Delete "UnitSphereRandomVectorGenerator"

2017-08-16 Thread Gilles (JIRA)
Gilles created MATH-1429: Summary: Delete "UnitSphereRandomVectorGenerator" Key: MATH-1429 URL: https://issues.apache.org/jira/browse/MATH-1429 Project: Commons Math Issue Type: Task Repo

[jira] [Resolved] (RNG-39) Move "UnitSphereRandomVectorGenerator" from "Commons Math"

2017-08-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved RNG-39. --- Resolution: Done commit eba39aae3a3eee0a053a77b46b917d18bcc1f606 > Move "UnitSphereRandomVectorGenerator" from "Commons M

[jira] [Commented] (CSV-215) CSVRecord mutability

2017-08-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/CSV-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128073#comment-16128073 ] Gilles commented on CSV-215: Referring to code [here|https://github.com/apache/commons-csv/pull/2

[jira] [Assigned] (RNG-39) Move "UnitSphereRandomVectorGenerator" from "Commons Math"

2017-08-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles reassigned RNG-39: - Assignee: Gilles > Move "UnitSphereRandomVectorGenerator" from "Commons Math" > -

[jira] [Created] (RNG-39) Move "UnitSphereRandomVectorGenerator" from "Commons Math"

2017-08-15 Thread Gilles (JIRA)
Gilles created RNG-39: - Summary: Move "UnitSphereRandomVectorGenerator" from "Commons Math" Key: RNG-39 URL: https://issues.apache.org/jira/browse/RNG-39 Project: Commons RNG Issue Type: Wish

[jira] [Commented] (MATH-1428) OLSMultipleLinearRegression estimates different residuals with different order of input

2017-08-11 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123215#comment-16123215 ] Gilles commented on MATH-1428: -- What result did you expect? What do other libraries produce?

[jira] [Resolved] (MATH-1426) Add constructor with Double[] argument to DescriptiveStatistics

2017-08-09 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1426. -- Resolution: Implemented commit bd82fe9fc034e7921eb589420bb4b86dc767a11e > Add constructor with Double[] argument

[jira] [Commented] (MATH-1426) Add constructor with Double[] argument to DescriptiveStatistics

2017-08-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114534#comment-16114534 ] Gilles commented on MATH-1426: -- bq. I don't see the downside of using a different "fixed" \[..

[jira] [Commented] (MATH-1426) Add constructor with Double[] argument to DescriptiveStatistics

2017-08-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114362#comment-16114362 ] Gilles commented on MATH-1426: -- Thanks for your interest in contributing! We certainly look fo

[jira] [Commented] (MATH-1426) Add constructor with Double[] argument to DescriptiveStatistics

2017-08-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113715#comment-16113715 ] Gilles commented on MATH-1426: -- A unit test would be welcome. > Add constructor with Double[]

[jira] [Updated] (NUMBERS-48) Unreachable statements in Complex.abs()

2017-08-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-48: -- Affects Version/s: (was: 1.1) Fix Version/s: 1.0 > Unreachable statements in Complex.abs() > ---

[jira] [Commented] (NUMBERS-2) Potential performance issues in "ComplexUtils"

2017-08-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112594#comment-16112594 ] Gilles commented on NUMBERS-2: -- bq. it is hard to see a motivation to recode them as loops Wh

[jira] [Commented] (NUMBERS-30) Move "array" utilities from "Commons Math"

2017-08-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112592#comment-16112592 ] Gilles commented on NUMBERS-30: --- Sure. Since the target is "1.1", this is certainly low prio

[jira] [Commented] (MATH-1427) Unreachable statements in Complex.abs()

2017-08-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112569#comment-16112569 ] Gilles commented on MATH-1427: -- The "complex number" functionality is being refactored within

[jira] [Resolved] (MATH-1425) Use Arraycopy for Row Operations in Array2DRowRealMatrix

2017-07-21 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1425. -- Resolution: Implemented Fix Version/s: 4.0 Patch applied in commit e1f30a1c32eb292e51db274adbe2fd6ed09b555

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-07 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078079#comment-16078079 ] Gilles commented on TEXT-97: What if the wanted selection of characters is not represented by ran

[jira] [Commented] (MATH-1424) Wrong eigen values computed by EigenDecomposition when the input matrix has large values

2017-07-06 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076370#comment-16076370 ] Gilles commented on MATH-1424: -- Fine, since it's unlikely that we'll be in a position to consi

[jira] [Commented] (MATH-1424) Wrong eigen values computed by EigenDecomposition when the input matrix has large values

2017-07-06 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076328#comment-16076328 ] Gilles commented on MATH-1424: -- Thanks for the report. Could you prepare a patch, with unit te

[jira] [Resolved] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-07-05 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-38. --- Resolution: Done In commit 91090df9869177582c327c6c7159e981a90efd70, I've added the three trivial checks whic

[jira] [Commented] (NUMBERS-46) ContinuedFraction: "maxIterations" argument

2017-07-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072518#comment-16072518 ] Gilles commented on NUMBERS-46: --- Please review the modifications: commit 5a2f9d1492f0a9679c6

[jira] [Created] (NUMBERS-46) ContinuedFraction: "maxIterations" argument

2017-07-03 Thread Gilles (JIRA)
Gilles created NUMBERS-46: - Summary: ContinuedFraction: "maxIterations" argument Key: NUMBERS-46 URL: https://issues.apache.org/jira/browse/NUMBERS-46 Project: Commons Numbers Issue Type: Bug

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071427#comment-16071427 ] Gilles commented on TEXT-97: bq. those should call .withinRange(char[] ...) I don't think so, un

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071338#comment-16071338 ] Gilles commented on TEXT-97: bq. single API which will return random string with given multiple r

[jira] [Comment Edited] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071331#comment-16071331 ] Gilles edited comment on TEXT-97 at 7/1/17 5:26 PM: I'm contradicting mys

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071331#comment-16071331 ] Gilles commented on TEXT-97: I'm contradicting myself but I'm not so happy with {code} withinRang

[jira] [Commented] (TEXT-96) Convenience methods needed for RandomStringGenerator

2017-07-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071323#comment-16071323 ] Gilles commented on TEXT-96: bq. I want to keep both Sorry, I mixed {code} withinRange {code} wi

[jira] [Resolved] (RNG-33) Consider adding convenience methods to UniformRandomProvider

2017-06-30 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved RNG-33. --- Resolution: Not A Problem > Consider adding convenience methods to UniformRandomProvider > ---

[jira] [Resolved] (RNG-38) Wrong badge on Github

2017-06-30 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved RNG-38. --- Resolution: Workaround Badges were manually added. The "README.md" file should not be re-generated before there is a solu

[jira] [Reopened] (COMMONSSITE-90) Include badges in the README.md file

2017-06-30 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/COMMONSSITE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles reopened COMMONSSITE-90: --- For a component that defines modules, the current template will display a badge that links to a non-e

[jira] [Commented] (TEXT-96) Convenience methods needed for RandomStringGenerator

2017-06-30 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070632#comment-16070632 ] Gilles commented on TEXT-96: IIUC, you mean to remove {code} withinRange(char ...) {code} and hav

[jira] [Commented] (TEXT-96) Convenience methods needed for RandomStringGenerator

2017-06-30 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070439#comment-16070439 ] Gilles commented on TEXT-96: Would {code} withinRanges(char[] ...) {code} cover every such needs?

[jira] [Commented] (TEXT-96) Convenience methods needed for RandomStringGenerator

2017-06-29 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068285#comment-16068285 ] Gilles commented on TEXT-96: A [related discussion|http://markmail.org/message/oc36ltduek4ahn3t]

[jira] [Commented] (TEXT-93) RandomStringGenerator accepts a list of valid characters

2017-06-25 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062325#comment-16062325 ] Gilles commented on TEXT-93: It's fine to delay the addition of the overloaded method to when som

[jira] [Commented] (TEXT-93) RandomStringGenerator accepts a list of valid characters

2017-06-24 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061867#comment-16061867 ] Gilles commented on TEXT-93: It is not obvious to me that such a method is not useful (and even m

[jira] [Commented] (TEXT-93) RandomStringGenerator accepts a list of valid characters

2017-06-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061745#comment-16061745 ] Gilles commented on TEXT-93: Code [here|https://github.com/apache/commons-text/pull/54/commits/c

[jira] [Commented] (MATH-1422) How accurate is FastMath javadoc?

2017-06-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061738#comment-16061738 ] Gilles commented on MATH-1422: -- It was certainly the other main goal. See the Javadoc of the {

[jira] [Commented] (MATH-1422) How accurate is FastMath javadoc?

2017-06-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061430#comment-16061430 ] Gilles commented on MATH-1422: -- Generally speaking it has never been true; see those still ope

[jira] [Commented] (RNG-38) Wrong badge on Github

2017-06-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060941#comment-16060941 ] Gilles commented on RNG-38: --- bq. badge \[...\] has to refer to existing artifact within maven centra

[jira] [Commented] (RNG-38) Wrong badge on Github

2017-06-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060696#comment-16060696 ] Gilles commented on RNG-38: --- Do you mean that each module must have its own badge? It's not such a g

[jira] [Commented] (RNG-31) Missing signature and checksum files (release process)

2017-06-23 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/RNG-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060673#comment-16060673 ] Gilles commented on RNG-31: --- bq. Checksums are only needed for releases That's the context of this

[jira] [Commented] (TEXT-93) RandomStringGenerator accepts a list of valid characters

2017-06-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060069#comment-16060069 ] Gilles commented on TEXT-93: Amey, Referring to the PR; this code {code} public Builder selectFr

[jira] [Commented] (NUMBERS-45) Removal of isNaN() and isInfinite() methods from Complex class

2017-06-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059309#comment-16059309 ] Gilles commented on NUMBERS-45: --- Can't we keep them as syntactic sugar (with the Javadoc men

[jira] [Resolved] (MATH-1421) WilsonConfidenceInterval returning negative values

2017-06-21 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1421. -- Resolution: Fixed Fix Version/s: 4.0 Thanks for the report. As of commit 612a04d6b0ff8fa3060d5e943f4f7296

[jira] [Commented] (TEXT-93) RandomStringGenerator accepts a list of valid characters

2017-06-21 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058503#comment-16058503 ] Gilles commented on TEXT-93: We could have * {{selectFromList(char[])}} * {{selectFromList(List)}

[jira] [Commented] (MATH-1420) Symbolic differentiation pull request

2017-06-18 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053121#comment-16053121 ] Gilles commented on MATH-1420: -- You should post on the "dev" ML of the "Commons" project. Ther

[jira] [Commented] (TEXT-88) WordUtils.capitalizeFully behaves in a counterintuitive manner with empty delimiter array.

2017-06-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051802#comment-16051802 ] Gilles commented on TEXT-88: Referring the description of this issue, I think that {code} WordUti

[jira] [Resolved] (NUMBERS-44) IndexOutOfRangeException(int) not thrown in ComplexUtils

2017-06-16 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-44. --- Resolution: Fixed Thanks. > IndexOutOfRangeException(int) not thrown in ComplexUtils > --

[jira] [Commented] (MATH-1419) Invalid usage of exception in PolynomialSplineFunction

2017-06-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050480#comment-16050480 ] Gilles commented on MATH-1419: -- Merged in commit 777af155a678286614d261887790352b43fa7c2a >

[jira] [Resolved] (MATH-1419) Invalid usage of exception in PolynomialSplineFunction

2017-06-15 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved MATH-1419. -- Resolution: Fixed Fix Version/s: (was: 3.7) Changed in commit 1b53f09c3a9dcd64dd281c1955b062fc28999366

[jira] [Commented] (NUMBERS-43) Remove "round(float)" methods?

2017-06-14 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049050#comment-16049050 ] Gilles commented on NUMBERS-43: --- This issue came about because FindBugs signals a problem in

[jira] [Commented] (TEXT-88) WordUtils.capitalizeFully behaves in a counterintuitive manner with empty delimiter array.

2017-06-14 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048980#comment-16048980 ] Gilles commented on TEXT-88: bq. reply appropriately When a library method gets {{null}}, it can

[jira] [Commented] (TEXT-88) WordUtils.capitalizeFully behaves in a counterintuitive manner with empty delimiter array.

2017-06-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048416#comment-16048416 ] Gilles commented on TEXT-88: Sorry for dropping into that discussion, but IMHO those two {code} W

[jira] [Commented] (NUMBERS-43) Remove "round(float)" methods?

2017-06-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048390#comment-16048390 ] Gilles commented on NUMBERS-43: --- {{roundUnscaled}} is only used by the {{round(float)}} impl

[jira] [Commented] (NUMBERS-43) Remove "round(float)" methods?

2017-06-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048313#comment-16048313 ] Gilles commented on NUMBERS-43: --- bq. just saw the code and at some point its anyway calling

[jira] [Commented] (NUMBERS-43) Remove "round(float)" methods?

2017-06-13 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048291#comment-16048291 ] Gilles commented on NUMBERS-43: --- bq. we might want to round of numbers at certain lengths M

[jira] [Created] (NUMBERS-43) Remove "round(float)" methods?

2017-06-12 Thread Gilles (JIRA)
Gilles created NUMBERS-43: - Summary: Remove "round(float)" methods? Key: NUMBERS-43 URL: https://issues.apache.org/jira/browse/NUMBERS-43 Project: Commons Numbers Issue Type: Wish Reporte

[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

2017-06-07 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041712#comment-16041712 ] Gilles commented on NUMBERS-40: --- Hi "tharakadesilva". Thanks for your interest in this new

[jira] [Updated] (NUMBERS-30) Move "array" utilities from "Commons Math"

2017-06-05 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-30: -- Fix Version/s: 1.1 > Move "array" utilities from "Commons Math" > -- > >

[jira] [Updated] (NUMBERS-29) Move combinatorics utilities from "Commons Math"

2017-06-05 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-29: -- Fix Version/s: (was: 1.0) 1.1 > Move combinatorics utilities from "Commons Math" > --

[jira] [Updated] (NUMBERS-19) MATH-1400

2017-06-05 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-19: -- Fix Version/s: (was: 1.0) 1.1 > MATH-1400 > - > > Key: NUMBERS-19

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-05 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037637#comment-16037637 ] Gilles commented on NUMBERS-38: --- Thanks a lot for the clear description. {quote} Gamma gamm

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036412#comment-16036412 ] Gilles commented on NUMBERS-38: --- It is still not clear to me what is the benefit of moving t

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036266#comment-16036266 ] Gilles commented on NUMBERS-38: --- bq. I think all that you copied from commons math is correc

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036261#comment-16036261 ] Gilles commented on NUMBERS-38: --- Hi Amey, Great that you could dig deeper into the review.

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036053#comment-16036053 ] Gilles commented on NUMBERS-38: --- Amey, Thanks for taking this on. However, the main interes

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036028#comment-16036028 ] Gilles commented on NUMBERS-38: --- There are no tests for the [value(double x)|https://github

[jira] [Created] (NUMBERS-42) Factory methods

2017-06-03 Thread Gilles (JIRA)
Gilles created NUMBERS-42: - Summary: Factory methods Key: NUMBERS-42 URL: https://issues.apache.org/jira/browse/NUMBERS-42 Project: Commons Numbers Issue Type: New Feature Reporter: Gille

[jira] [Updated] (NUMBERS-2) Potential performance issues in "ComplexUtils"

2017-06-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-2: - Description: See http://markmail.org/message/qnzauv65nb3gmz2h To be checked with JMH benchmarking code. Most of t

[jira] [Resolved] (NUMBERS-41) Utility class for angles in radians

2017-06-03 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-41. --- Resolution: Done commit 40fd2b4eb86b2f29e8141e08bd4f6338c79a4743 > Utility class for angles in radians >

[jira] [Resolved] (NUMBERS-1) Testing fails due to poor null handling in newly created local equals() and equals-type methods

2017-05-30 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-1. -- Resolution: Fixed Fix Version/s: 1.0 > Testing fails due to poor null handling in newly created local equa

[jira] [Resolved] (NUMBERS-10) Revamp "Complex" representation ?

2017-05-30 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-10. --- Resolution: Won't Do > Revamp "Complex" representation ? > - > >

<    5   6   7   8   9   10   11   12   13   14   >