[
https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824641#comment-13824641
]
Matthew Pocock commented on CODEC-174:
--
These patches look OK to me. I chose maps/sets
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083179#comment-13083179
]
Matthew Pocock commented on CODEC-125:
--
The lucene/solr source seems not to reference
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083416#comment-13083416
]
Matthew Pocock commented on CODEC-125:
--
hashSet.toString isn't deterministic between
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13082617#comment-13082617
]
Matthew Pocock commented on CODEC-125:
--
Gary and I where talking about altering the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080943#comment-13080943
]
Matthew Pocock commented on CODEC-125:
--
Hi,
* Would not it make sense to add surnames
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: fightingMemoryChurn.patch
Patch for reducing memory churn attached.
Implement a
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081106#comment-13081106
]
Matthew Pocock commented on CODEC-125:
--
After turning off all the 'helpful' filters,
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081210#comment-13081210
]
Matthew Pocock commented on CODEC-125:
--
Gary and I have found that the last patch did
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: fightingMemoryChurn.patch
This seems to improve things. Apply in place of the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: comparator.patch
Moved compareTo into a comparator on Rule.Phoneme.
Implement a
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: fixmeInvariant.patch
This patch hoists the l-invariant code out of the loop over l.
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080405#comment-13080405
]
Matthew Pocock commented on CODEC-125:
--
The d'ortley test input string exercises this
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: handleH.patch
I've added a little extra code to make it easier to track rules back to
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: performanceAndBugs.patch
This patch addresses the following:
* Performance issues:
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: acz.patch
This should fix the problem with acz encoding. The bug was actually to do
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073383#comment-13073383
]
Matthew Pocock commented on CODEC-125:
--
Tamas,
We can add Ignácz, Ignátz and Ignác as
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072285#comment-13072285
]
Matthew Pocock commented on CODEC-125:
--
=The code coverage shows some code untouched,
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072608#comment-13072608
]
Matthew Pocock commented on CODEC-125:
--
Gary: I was following what the PHP returned.
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072609#comment-13072609
]
Matthew Pocock commented on CODEC-125:
--
Tamas: This looks like a bug in my
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: testEncodeGna.patch
I see:
Tests in error:
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: majorFix.patch
This is, as the name hints, a fairly major fix. I've re-written the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071030#comment-13071030
]
Matthew Pocock commented on CODEC-125:
--
Hi Sebb,
I could not see any way in a patch
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: bmpm.patch
Added documentation of resource file formats to Lang, Language and Rule.
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069969#comment-13069969
]
Matthew Pocock commented on CODEC-125:
--
* @author tags are discouraged in code
I
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: bmpm.patch
I've added licenses to all resource files. This meant modifying the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070068#comment-13070068
]
Matthew Pocock commented on CODEC-125:
--
No problem - it was probably about the same
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: bmpm.patch
Here is my latest patch file. When I patch against svn head, all unit
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: bmpm.patch
This time I hope I've granted the ASF license.
Implement a Beider-Morse
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069736#comment-13069736
]
Matthew Pocock commented on CODEC-125:
--
Sebb, good catch on String#isEmpty(). I've
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: bmpm.patch
Patch with license granted, isEmpty replaced with explicit length()==0
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058586#comment-13058586
]
Matthew Pocock commented on CODEC-125:
--
I have renamed the bmpm package to bm. Do you
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: bmpm.patch
Revised patch file with no empty files and the bmpm package renamed to bm.
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058596#comment-13058596
]
Matthew Pocock commented on CODEC-125:
--
As a data point, the patch applies correctly
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057382#comment-13057382
]
Matthew Pocock commented on CODEC-125:
--
Hi Gary,
This code is a port of some PHP
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057393#comment-13057393
]
Matthew Pocock commented on CODEC-125:
--
Re test failures, I have all tests passing on
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057439#comment-13057439
]
Matthew Pocock commented on CODEC-125:
--
Got it. On linux and in intellij, the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: bmpm.patch
Here is a new patch that passes tests on windows 7 for me and has the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Pocock updated CODEC-125:
-
Attachment: bmpm.patch
Here is a patch that provides an initial implementation of BMPM. It
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056596#comment-13056596
]
Matthew Pocock commented on CODEC-125:
--
This is frustrating - it builds cleanly and
beider morse phonetic matching codec
Key: CODEC-125
URL: https://issues.apache.org/jira/browse/CODEC-125
Project: Commons Codec
Issue Type: New Feature
Reporter: Matthew Pocock
40 matches
Mail list logo
