[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848086#comment-15848086
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user ramkrish86 commented on the issue:
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/3149
> Regarding the HBaseTableSchema, we could also use it only internally and
not expose it to the user. The HBaseTableSource would have a method addColumn()
and forward the calls to its internal
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848072#comment-15848072
]
Tzu-Li (Gordon) Tai edited comment on FLINK-5122 at 2/1/17 7:09 AM:
I
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848072#comment-15848072
]
Tzu-Li (Gordon) Tai edited comment on FLINK-5122 at 2/1/17 7:09 AM:
I
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848072#comment-15848072
]
Tzu-Li (Gordon) Tai edited comment on FLINK-5122 at 2/1/17 7:07 AM:
I
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848072#comment-15848072
]
Tzu-Li (Gordon) Tai edited comment on FLINK-5122 at 2/1/17 6:55 AM:
I
[
https://issues.apache.org/jira/browse/FLINK-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848072#comment-15848072
]
Tzu-Li (Gordon) Tai commented on FLINK-5122:
I would like to handle this issue together with
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848060#comment-15848060
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user ramkrish86 commented on the issue:
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/3149
Just a general question
`def projectFields(fields: Array[Int]): ProjectableTableSource[T]`
Is it mandatory to only have int[] here. Can we have String[] that allows
to specify
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848054#comment-15848054
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user ramkrish86 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848055#comment-15848055
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3149
The points I raised effect the API and different people tend to have
different opinions about APIs ;-).
I suggested to use a flat schema with that names columns
`columnFamily$qualifier`,
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/3149
Updated the PR fixing the comments. The comments were simple but the adding
AbstractTableInputFormat and moving the code back and forth makes this one a
bigger change. But internally they are
[
https://issues.apache.org/jira/browse/FLINK-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847946#comment-15847946
]
Tzu-Li (Gordon) Tai edited comment on FLINK-5353 at 2/1/17 6:04 AM:
Hi
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848046#comment-15848046
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user ramkrish86 commented on the issue:
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/3149
To understand better
> We could make flat schema an optional mode or implement it as a separate
TableSource as well.
and this one
> This could be solved if we use a flat
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848044#comment-15848044
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98832296
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSourceInputFormat.java
---
@@ -0,0 +1,144 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848010#comment-15848010
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user ramkrish86 commented on a diff in the pull
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98828506
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSourceInputFormat.java
---
@@ -0,0 +1,144 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848009#comment-15848009
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user ramkrish86 commented on a diff in the pull
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98828345
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSourceInputFormat.java
---
@@ -0,0 +1,144 @@
+/*
+ *
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98828283
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848008#comment-15848008
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user ramkrish86 commented on a diff in the pull
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
Hi @fpompermaier! Thanks for bringing it up. However, as Robert suggested,
lets not include that as this PR. But I'll like to discuss with you on the
matter on the corresponding JIRA concurrently
[
https://issues.apache.org/jira/browse/FLINK-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847946#comment-15847946
]
Tzu-Li (Gordon) Tai edited comment on FLINK-5353 at 2/1/17 4:02 AM:
Hi
[
https://issues.apache.org/jira/browse/FLINK-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847946#comment-15847946
]
Tzu-Li (Gordon) Tai commented on FLINK-5353:
Hi [~f.pompermaier], first some clarification
[
https://issues.apache.org/jira/browse/FLINK-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847924#comment-15847924
]
Andrew Efimov commented on FLINK-5679:
--
Described above idea accompanies current task, it is not main
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847808#comment-15847808
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847804#comment-15847804
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847806#comment-15847806
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847807#comment-15847807
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847809#comment-15847809
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847810#comment-15847810
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847805#comment-15847805
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98805341
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSourceInputFormat.java
---
@@ -0,0 +1,144 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847803#comment-15847803
]
ASF GitHub Bot commented on FLINK-2168:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98805386
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSourceInputFormat.java
---
@@ -0,0 +1,144 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98805834
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java
---
@@ -0,0 +1,196 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98805094
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSourceInputFormat.java
---
@@ -0,0 +1,144 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98805674
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -41,7 +41,7 @@
/**
* {@link
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98805799
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java
---
@@ -0,0 +1,196 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98804629
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r98805953
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java
---
@@ -0,0 +1,196 @@
+/*
+ *
Github user fpompermaier commented on the issue:
https://github.com/apache/flink/pull/3112
Hi @tzulitai, congrats for the great work! For my use case it is important
also to be resilient to malformed documents
(https://issues.apache.org/jira/browse/FLINK-5353). Do you think you could
[
https://issues.apache.org/jira/browse/FLINK-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847758#comment-15847758
]
ASF GitHub Bot commented on FLINK-4988:
---
Github user fpompermaier commented on the issue:
Github user GEOFBOT commented on the issue:
https://github.com/apache/flink/pull/3232
Thanks for the comments, I've addressed them with the latest commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847734#comment-15847734
]
ASF GitHub Bot commented on FLINK-5183:
---
Github user GEOFBOT commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847582#comment-15847582
]
ASF GitHub Bot commented on FLINK-5694:
---
GitHub user greghogan opened a pull request:
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3245
[FLINK-5694] [gelly] Collect DataSetAnalytic
Adds a DataSetAnalytic that accumulates elements and returns elements using
a List. This mirrors the implementation of DataSet.collect() but using the
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3244
[FLINK-5693] [gelly] ChecksumHashCode DataSetAnalytic
Adds a DataSetAnalytic that checksums and counts elements from a DataSet.
This allows DataSetUtils.checksumHashCode to be deprecated.
You
[
https://issues.apache.org/jira/browse/FLINK-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847557#comment-15847557
]
ASF GitHub Bot commented on FLINK-5693:
---
GitHub user greghogan opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847551#comment-15847551
]
Andrew Efimov commented on FLINK-5679:
--
I agree. Recently, I checked approach that allows to reuse
[
https://issues.apache.org/jira/browse/FLINK-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847434#comment-15847434
]
ASF GitHub Bot commented on FLINK-5631:
---
Github user haohui commented on the issue:
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3202
Thanks for the reviews.
It's more about readability of the code itself instead of testing and
visibility. The two functions are fairly long and basically identical.
Therefore I refactor the
[
https://issues.apache.org/jira/browse/FLINK-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847415#comment-15847415
]
ASF GitHub Bot commented on FLINK-5669:
---
Github user rick-cox commented on the issue:
Github user rick-cox commented on the issue:
https://github.com/apache/flink/pull/3223
Thanks for the detailed explanation. I confirmed that using the previous
patch with a standalone cluster failed, then applied the suggested alternative
approach and tested that works with both
[
https://issues.apache.org/jira/browse/FLINK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847347#comment-15847347
]
ASF GitHub Bot commented on FLINK-5502:
---
Github user kl0u commented on the issue:
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3130
Thanks @aljoscha . I checked the changes and they look good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847345#comment-15847345
]
Elias Levy commented on FLINK-4326:
---
Greg's proposal for {{flink-console.sh}} will do. The one thing I
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
I think the PR is in a stable state for a final review now. I'll keep the
PR as is until another review, sorry for jumping around as I was trying options
for more future change proof.
---
If your
[
https://issues.apache.org/jira/browse/FLINK-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847180#comment-15847180
]
ASF GitHub Bot commented on FLINK-4988:
---
Github user tzulitai commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847206#comment-15847206
]
ramkrishna.s.vasudevan commented on FLINK-4810:
---
bq.numUnsuccessfulCheckpointsTriggers
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
While rebasing #2861 on the restructured ES connectors in this PR, I jumped
around different options on whether or not the `BulkProcessor` build process
should be abstracted. In the end, I think it
[
https://issues.apache.org/jira/browse/FLINK-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847173#comment-15847173
]
ASF GitHub Bot commented on FLINK-4988:
---
Github user tzulitai commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847162#comment-15847162
]
Till Rohrmann edited comment on FLINK-5652 at 1/31/17 5:28 PM:
---
The problem
[
https://issues.apache.org/jira/browse/FLINK-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan updated FLINK-5693:
--
Issue Type: Sub-task (was: Improvement)
Parent: FLINK-4949
> ChecksumHashCode DataSetAnalytic
[
https://issues.apache.org/jira/browse/FLINK-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan updated FLINK-5694:
--
Issue Type: Sub-task (was: Improvement)
Parent: FLINK-4949
> Collect DataSetAnalytic
>
[
https://issues.apache.org/jira/browse/FLINK-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847162#comment-15847162
]
Till Rohrmann commented on FLINK-5652:
--
The problem is the following: When defining a timeout the
Greg Hogan created FLINK-5694:
-
Summary: Collect DataSetAnalytic
Key: FLINK-5694
URL: https://issues.apache.org/jira/browse/FLINK-5694
Project: Flink
Issue Type: Improvement
Greg Hogan created FLINK-5693:
-
Summary: ChecksumHashCode DataSetAnalytic
Key: FLINK-5693
URL: https://issues.apache.org/jira/browse/FLINK-5693
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847121#comment-15847121
]
Till Rohrmann commented on FLINK-5652:
--
No this is not known to me. Will investigate it. Thanks for
[
https://issues.apache.org/jira/browse/FLINK-5558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-5558.
-
Resolution: Implemented
Implemented in 087d191ff7ffaa33ebd719cba4aea08917c4618f
> Replace TriangleCount
[
https://issues.apache.org/jira/browse/FLINK-5558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847110#comment-15847110
]
ASF GitHub Bot commented on FLINK-5558:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3243#discussion_r98710331
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateDescriptor.java
---
@@ -20,34 +20,29 @@
import
[
https://issues.apache.org/jira/browse/FLINK-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847080#comment-15847080
]
ASF GitHub Bot commented on FLINK-5024:
---
Github user aljoscha commented on a diff in the pull
Title: Message Title
Aljoscha Krettek closed an issue as Won't Fix
Title: Message Title
Ufuk Celebi commented on FLINK-5672
Title: Message Title
Ufuk Celebi updated an issue
Title: Message Title
Ufuk Celebi commented on FLINK-5673
Title: Message Title
Fabian Hueske commented on FLINK-5455
Title: Message Title
ASF GitHub Bot commented on FLINK-5455
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Title: Message Title
ASF GitHub Bot commented on FLINK-5455
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3217
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Title: Message Title
ASF GitHub Bot commented on FLINK-5023
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/3243
[FLINK-5024] [core] Refactor the interface of State and StateDescriptor
This is a refactored version of #2768
This pull request splits the `StateDescriptor`:
- Basic
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2768
I posted a rebased version of the state descriptor refactoring here: #3243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Title: Message Title
Andrey commented on FLINK-5690
Title: Message Title
ASF GitHub Bot commented on FLINK-5024
Title: Message Title
ASF GitHub Bot commented on FLINK-5455
Title: Message Title
Andrey commented on FLINK-5685
Title: Message Title
Andrey edited a comment on FLINK-5685
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3217
Looks good to me, +1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Title: Message Title
Stephan Ewen resolved as Duplicate
Title: Message Title
Stephan Ewen closed an issue as Duplicate
Title: Message Title
Stephan Ewen commented on FLINK-5652
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3219#discussion_r98687559
--- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
@@ -148,14 +158,49 @@ public static void deleteDirectory(File directory)
Title: Message Title
ASF GitHub Bot commented on FLINK-5659
1 - 100 of 259 matches
Mail list logo
