[GitHub] flink pull request #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3471#discussion_r104606232 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala --- @@ -42,6 +41,14 @@ class

[jira] [Commented] (FLINK-5722) Implement DISTINCT as dedicated operator

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898901#comment-15898901 ] ASF GitHub Bot commented on FLINK-5722: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898889#comment-15898889 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on a diff in the pull

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-06 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r104605350 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -140,6 +138,26 @@ object

[GitHub] flink pull request #3482: Flink-5976

2017-03-06 Thread liuyuzhong7
GitHub user liuyuzhong7 opened a pull request: https://github.com/apache/flink/pull/3482 Flink-5976 There are some duplicate code like this in flink-test, I think refactor this will be better. ``` public final class Tokenizer implements FlatMapFunction

[jira] [Updated] (FLINK-5976) Refactoring duplicate Tokenizer in flink-test

2017-03-06 Thread liuyuzhong7 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuyuzhong7 updated FLINK-5976: --- Summary: Refactoring duplicate Tokenizer in flink-test (was: refactoring remove duplicate Tokenizer

[jira] [Created] (FLINK-5976) refactoring remove duplicate Tokenizer in flink-test

2017-03-06 Thread liuyuzhong7 (JIRA)
liuyuzhong7 created FLINK-5976: -- Summary: refactoring remove duplicate Tokenizer in flink-test Key: FLINK-5976 URL: https://issues.apache.org/jira/browse/FLINK-5976 Project: Flink Issue Type:

[jira] [Updated] (FLINK-5949) Flink on YARN checks for Kerberos credentials for non-Kerberos authentication methods

2017-03-06 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-5949: --- Fix Version/s: 1.3.0 > Flink on YARN checks for Kerberos credentials for non-Kerberos

[jira] [Commented] (FLINK-5949) Flink on YARN checks for Kerberos credentials for non-Kerberos authentication methods

2017-03-06 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898868#comment-15898868 ] Tzu-Li (Gordon) Tai commented on FLINK-5949: Yes, indeed! > Flink on YARN checks for Kerberos

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r104600115 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala --- @@ -44,14 +44,24 @@ class

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898850#comment-15898850 ] ASF GitHub Bot commented on FLINK-5881: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-5975) Mesos should support adding volumes to launched taskManagers

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898844#comment-15898844 ] ASF GitHub Bot commented on FLINK-5975: --- GitHub user addisonj opened a pull request:

[GitHub] flink pull request #3481: [FLINK-5975] Add volume support to flink-mesos

2017-03-06 Thread addisonj
GitHub user addisonj opened a pull request: https://github.com/apache/flink/pull/3481 [FLINK-5975] Add volume support to flink-mesos When using containerization, specifically, docker, it is useful to be able to attach additional volumes, such as an NFS share. This adds

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898837#comment-15898837 ] ASF GitHub Bot commented on FLINK-5881: --- Github user KurtYoung commented on the issue:

[GitHub] flink issue #3389: [FLINK-5881] [table] ScalarFunction(UDF) should support v...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3389 Hi @twalthr can you also take a look at this PR soon, since you are quite familiar with these language things. Would be great if you can offer some comments. --- If your project is set up for

[jira] [Commented] (FLINK-5882) TableFunction (UDTF) should support variable types and variable arguments

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898833#comment-15898833 ] ASF GitHub Bot commented on FLINK-5882: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3407: [FLINK-5882] [table] TableFunction (UDTF) should s...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3407#discussion_r104598155 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/TableFunctionCallGen.scala --- @@ -45,13 +45,23 @@ class

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r104597703 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala --- @@ -44,14 +44,24 @@ class

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898825#comment-15898825 ] ASF GitHub Bot commented on FLINK-5881: --- Github user KurtYoung commented on a diff in the pull

[jira] [Assigned] (FLINK-5655) Add event time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-06 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-5655: Assignee: sunjincheng (was: Shaoxuan Wang) > Add event time OVER RANGE BETWEEN x

[jira] [Commented] (FLINK-5655) Add event time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-06 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898814#comment-15898814 ] Shaoxuan Wang commented on FLINK-5655: -- [~sunjincheng121] and I want to start the implementation on

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r104595467 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala --- @@ -136,8 +143,18 @@ object

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898803#comment-15898803 ] ASF GitHub Bot commented on FLINK-5881: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-5803) Add [partitioned] processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898731#comment-15898731 ] ASF GitHub Bot commented on FLINK-5803: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104586950 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -0,0 +1,210

[jira] [Commented] (FLINK-5803) Add [partitioned] processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898724#comment-15898724 ] ASF GitHub Bot commented on FLINK-5803: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104586138 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -0,0 +1,210

[jira] [Commented] (FLINK-5918) port range support for config taskmanager.rpc.port

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898707#comment-15898707 ] ASF GitHub Bot commented on FLINK-5918: --- Github user barcahead commented on the issue:

[GitHub] flink issue #3416: [FLINK-5918] [runtime] port range support for config task...

2017-03-06 Thread barcahead
Github user barcahead commented on the issue: https://github.com/apache/flink/pull/3416 @zentol @tillrohrmann Thanks for your review, I have addressed your comments and updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-5918) port range support for config taskmanager.rpc.port

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898701#comment-15898701 ] ASF GitHub Bot commented on FLINK-5918: --- Github user barcahead commented on a diff in the pull

[GitHub] flink pull request #3416: [FLINK-5918] [runtime] port range support for conf...

2017-03-06 Thread barcahead
Github user barcahead commented on a diff in the pull request: https://github.com/apache/flink/pull/3416#discussion_r104584562 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala --- @@ -720,5 +722,55 @@ object AkkaUtils { if (sslEnabled)

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r104584170 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -140,6 +138,26 @@

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898697#comment-15898697 ] ASF GitHub Bot commented on FLINK-5881: --- Github user KurtYoung commented on a diff in the pull

[jira] [Created] (FLINK-5975) Mesos should support adding volumes to launched taskManagers

2017-03-06 Thread Addison Higham (JIRA)
Addison Higham created FLINK-5975: - Summary: Mesos should support adding volumes to launched taskManagers Key: FLINK-5975 URL: https://issues.apache.org/jira/browse/FLINK-5975 Project: Flink

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898676#comment-15898676 ] ASF GitHub Bot commented on FLINK-5881: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r104581688 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -140,6 +138,26 @@

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104572313 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedProcessingOverProcessFunction.scala --- @@

[jira] [Commented] (FLINK-5803) Add [partitioned] processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898586#comment-15898586 ] ASF GitHub Bot commented on FLINK-5803: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-06 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898438#comment-15898438 ] Jamie Grier commented on FLINK-3026: [~iemejia] [~plucas] I'm definitely also for the #2 option above.

[jira] [Assigned] (FLINK-5974) Support Mesos DNS

2017-03-06 Thread Vijay Srinivasaraghavan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay Srinivasaraghavan reassigned FLINK-5974: -- Assignee: Vijay Srinivasaraghavan (was: Eron Wright ) > Support Mesos

[jira] [Commented] (FLINK-2720) Add Storm-CountMetric in flink-stormcompatibility

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898269#comment-15898269 ] ASF GitHub Bot commented on FLINK-2720: --- Github user mjsax commented on the issue:

[GitHub] flink issue #1157: [FLINK-2720][storm-compatibility]Add Storm-CountMetric fo...

2017-03-06 Thread mjsax
Github user mjsax commented on the issue: https://github.com/apache/flink/pull/1157 @RalphSu We should wait for @HuangWHWHW to reply... If no response comes within 3 days you can take over. Also, the JIRA should get assigned to you for this case:

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898181#comment-15898181 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104523932 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggReduceGroupFunction.scala --- @@

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104515406 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala --- @@ -280,6 +285,138 @@ class

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104507420 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -153,6 +170,156 @@ object

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898187#comment-15898187 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898174#comment-15898174 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898176#comment-15898176 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898178#comment-15898178 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898177#comment-15898177 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898183#comment-15898183 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898180#comment-15898180 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898186#comment-15898186 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898185#comment-15898185 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898184#comment-15898184 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898188#comment-15898188 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898175#comment-15898175 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898182#comment-15898182 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5047) Add sliding group-windows for batch tables

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898179#comment-15898179 ] ASF GitHub Bot commented on FLINK-5047: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104518276 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideWindowAggReduceCombineFunction.scala --- @@ -0,0

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104522343 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala --- @@ -280,6 +285,138 @@ class

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104525345 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/GroupWindowTest.scala --- @@ -360,6 +360,19 @@ class

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104522529 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggFlatMapFunction.scala --- @@ -0,0

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104521151 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideCountWindowAggReduceGroupFunction.scala --- @@

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104527336 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetWindowAggregateITCase.scala --- @@ -169,4 +168,228 @@

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104523761 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggReduceCombineFunction.scala --- @@

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104514985 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideCountWindowAggReduceGroupFunction.scala --- @@

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104521729 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideCountWindowAggReduceGroupFunction.scala --- @@

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104524635 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideWindowAggReduceGroupFunction.scala --- @@ -0,0

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r104511932 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggFlatMapFunction.scala --- @@ -0,0

[GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3364#discussion_r10452 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/AggregationsITCase.scala --- @@ -146,42 +146,9 @@ class

[jira] [Updated] (FLINK-5974) Support Mesos DNS

2017-03-06 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-5974: Description: In certain Mesos/DCOS environments, the slave hostnames aren't resolvable. For this

[jira] [Updated] (FLINK-5974) Support Mesos DNS

2017-03-06 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-5974: Description: In certain Mesos/DCOS environments, the slave hostnames aren't resolvable. For this

[jira] [Created] (FLINK-5974) Support Mesos DNS

2017-03-06 Thread Eron Wright (JIRA)
Eron Wright created FLINK-5974: --- Summary: Support Mesos DNS Key: FLINK-5974 URL: https://issues.apache.org/jira/browse/FLINK-5974 Project: Flink Issue Type: Improvement Components:

[GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...

2017-03-06 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3479#discussion_r104504635 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalWindowFunction.java --- @@ -39,5

[jira] [Commented] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897915#comment-15897915 ] ASF GitHub Bot commented on FLINK-5929: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897829#comment-15897829 ] ASF GitHub Bot commented on FLINK-5929: --- Github user sjwiesman commented on a diff in the pull

[GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...

2017-03-06 Thread sjwiesman
Github user sjwiesman commented on a diff in the pull request: https://github.com/apache/flink/pull/3479#discussion_r104492162 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalWindowFunction.java --- @@ -39,5

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897795#comment-15897795 ] ASF GitHub Bot commented on FLINK-4545: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #3480: [FLINK-4545] use size-restricted LocalBufferPool i...

2017-03-06 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3480 [FLINK-4545] use size-restricted LocalBufferPool instances for network communication Note: this PR is based on #3467 and PR 2 of 3 in a series to get rid of the network buffer parameter.

[jira] [Created] (FLINK-5973) check whether the direct memory size is always correctly calculated

2017-03-06 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-5973: -- Summary: check whether the direct memory size is always correctly calculated Key: FLINK-5973 URL: https://issues.apache.org/jira/browse/FLINK-5973 Project: Flink

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104430248 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -93,6 +94,41 @@ object

[GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...

2017-03-06 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3479#discussion_r104470521 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalWindowFunction.java --- @@ -39,5

[jira] [Commented] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897683#comment-15897683 ] ASF GitHub Bot commented on FLINK-5929: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104431561 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -93,6 +94,41 @@ object

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104466819 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -93,6 +94,41 @@ object

[jira] [Commented] (FLINK-5803) Add [partitioned] processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897655#comment-15897655 ] ASF GitHub Bot commented on FLINK-5803: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104457495 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -32,6 +33,17 @@ import

[GitHub] flink issue #3442: [FLINK-5778] [savepoints] Add savepoint serializer with r...

2017-03-06 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3442 Thanks for your review Stefan! I addressed your comments, but only then realized that the restriction to relative file state handle is actually a problem for externalized checkpoints. :-( They possibly

[jira] [Commented] (FLINK-4714) Set task state to RUNNING after state has been restored

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897642#comment-15897642 ] ASF GitHub Bot commented on FLINK-4714: --- Github user tony810430 commented on the issue:

[GitHub] flink issue #3474: [FLINK-4714] [runtime] [streaming] Set task state to RUNN...

2017-03-06 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3474 Hi, @StephanEwen I mean although all subclasses will be forced to call the one-argument constructor, it doesn't force all subclasses need to have the one-argument constructor. It seems

[jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath

2017-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897639#comment-15897639 ] ASF GitHub Bot commented on FLINK-5778: --- Github user uce commented on the issue:

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104426925 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedProcessingOverProcessFunction.scala --- @@ -0,0

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104424978 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -0,0 +1,210 @@

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104424825 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -0,0 +1,210 @@

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104427571 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedProcessingOverProcessFunction.scala --- @@ -0,0

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104456748 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -0,0 +1,210 @@

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104422579 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -0,0 +1,210 @@

[GitHub] flink pull request #3397: [FLINK-5803][TableAPI] Add [partitioned] proce...

2017-03-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3397#discussion_r104449558 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -0,0 +1,210 @@

  1   2   3   4   5   >