Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159425958
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -274,19 +251,13 @@ protected int run(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159431758
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -598,189 +535,154 @@ protected int cancel(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159435504
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -292,20 +267,14 @@ protected int run(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159439656
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -99,6 +69,44 @@ public void testStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159422039
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -882,42 +784,28 @@ protected ClusterClient
retrieveClient
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159432084
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -598,189 +535,154 @@ protected int cancel(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159447901
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -1,170 +0,0 @@
-/*
- * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159449988
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java
---
@@ -42,70 +39,54 @@
/**
* Tests for the CANCEL
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159446300
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -99,6 +69,44 @@ public void testStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159461777
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -442,23 +458,15 @@ public int
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159462006
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -262,16 +277,17 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159464428
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -475,4 +483,38 @@ public int
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159465653
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -442,23 +458,15 @@ public int
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5236#discussion_r159465985
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java
---
@@ -442,23 +458,15 @@ public int
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159644962
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendPackageProgramTest.java
---
@@ -60,7 +62,10 @@ public static void init
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159640707
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -448,68 +397,31 @@ public static RunOptions parseRunCommand
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159451928
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -391,35 +353,22 @@ public static void printHelpForSavepoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159641680
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendAddressConfigurationTest.java
---
@@ -47,36 +49,29 @@ public static void init
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159643583
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java
---
@@ -133,19 +139,23 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159650780
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/CliFrontendYarnAddressConfigurationTest.java
---
@@ -191,27 +213,47 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159647064
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/MockedCliFrontend.java
---
@@ -20,40 +20,22 @@
import
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159702188
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159698673
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/Flip6DefaultCLI.java ---
@@ -56,43 +51,30 @@ public String getId() {
return
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159656514
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
@@ -59,31 +60,49 @@
void addGeneralOptions(Options
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159698245
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -51,45 +45,23 @@ public String getId
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159702950
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159707313
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyClusterDescriptor.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159707553
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyCustomCommandLine.java
---
@@ -62,12 +63,21 @@ public void addGeneralOptions
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159706464
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/DefaultCLITest.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159703483
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159706927
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyClusterDescriptor.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r159826471
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -936,17 +936,19 @@ private void jobStatusChanged
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5226
This PR is based on #5225
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5226#discussion_r159883585
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendPackageProgramTest.java
---
@@ -60,220 +59,178 @@ public static void init
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159885568
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/AbstractCustomCommandLine.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5226#discussion_r159883795
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendPackageProgramTest.java
---
@@ -60,220 +59,178 @@ public static void init
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5226#discussion_r159874411
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -183,93 +204,43 @@ public FlinkYarnSessionCli(String shortPrefix
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160108309
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160110442
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java ---
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5227#discussion_r160112134
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
@@ -253,16 +253,22 @@ object FlinkShell
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5227#discussion_r160113403
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
@@ -253,16 +253,22 @@ object FlinkShell
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5227#discussion_r160113517
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
@@ -281,16 +287,22 @@ object FlinkShell {
"-m&qu
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5227#discussion_r160113577
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
@@ -281,16 +287,22 @@ object FlinkShell {
"-m&qu
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5228#discussion_r160115439
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -99,7 +99,7 @@
/**
* The descriptor with
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160137013
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java
---
@@ -56,7 +57,15 @@
* @return Cluster client to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160139085
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -393,6 +395,23 @@ public YarnClusterClient
deployJobCluster
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160161554
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -534,215 +557,235 @@ private Configuration
applyYarnProperties
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160165694
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -534,215 +557,235 @@ private Configuration
applyYarnProperties
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5261#discussion_r160178046
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -52,6 +55,10 @@
/** Flag
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160166638
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -534,215 +557,235 @@ private Configuration
applyYarnProperties
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160166040
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -534,215 +557,235 @@ private Configuration
applyYarnProperties
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5232#discussion_r160208748
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -367,40 +366,31 @@ public ClusterClient retrieve(String
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160209100
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java
---
@@ -56,7 +57,15 @@
* @return Cluster client to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5232#discussion_r160209875
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
@@ -83,7 +83,7 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5232#discussion_r160216156
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -98,24 +103,26 @@ public void testUnknownJobId() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r160407686
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -956,23 +958,29 @@ private void jobStatusChanged
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r160408734
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobExecutionResult.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r160408755
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobExecutionResult.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r160431822
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java
---
@@ -0,0 +1,276
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r160453714
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -357,6 +360,31 @@ public void start() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5209#discussion_r160638625
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/JarWithProgramUtils.java
---
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5194#discussion_r160684947
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandlerTest.java
---
@@ -0,0 +1,160
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r160699235
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -660,7 +570,25 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r160699294
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -717,7 +645,26 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r160699710
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -128,13 +131,14 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5194#discussion_r160942627
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandlerTest.java
---
@@ -0,0 +1,160
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5207#discussion_r160976558
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/retry/ExponentialWaitStrategy.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5207#discussion_r160979808
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/retry/ExponentialWaitStrategy.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5207#discussion_r160980332
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -104,11 +122,26 @@ protected JobSubmissionResult
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160994352
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160995333
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -51,45 +45,23 @@ public String getId
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5207#discussion_r160997382
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -148,6 +181,39 @@ private void submitJob(JobGraph
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161163563
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/retry/ExponentialWaitStrategyTest.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161163558
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java
---
@@ -0,0 +1,276
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161163547
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java ---
@@ -27,11 +27,16 @@
import java.util.concurrent.TimeoutException
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161234791
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -185,37 +205,19 @@ private void submitJob(JobGraph
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161235482
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java
---
@@ -137,4 +138,21 @@
JobID jobId
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161236268
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -0,0 +1,337
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161238338
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -0,0 +1,337
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161242236
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -294,44 +306,108 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161242245
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -294,44 +306,108 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161242267
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -185,37 +205,19 @@ private void submitJob(JobGraph
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161242312
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/savepoints/SavepointInfoTest.java
---
@@ -0,0 +1,52
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161242316
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java
---
@@ -0,0 +1,277
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161242333
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java
---
@@ -0,0 +1,277
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161368455
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -0,0 +1,337
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5305
Thanks for your contribution, @nicktoker. Unfortunately with your pull
request you are trying to merge the `release-1.3` branch into the `master`. You
probably want to create a feature branch from a
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5312
[FLINK-8344][WIP] Add support for HA to RestClusterClient
WIP
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink rest-cluster-client-ha
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5312
cc: @tillrohrmann
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162412749
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java
---
@@ -132,4 +137,23 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162413303
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -251,6 +245,12 @@ protected void channelRead0(ChannelHandlerContext
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162412277
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -596,11 +596,11 @@ public int run(String[] args) throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162414419
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionService.java
---
@@ -412,4 +413,11 @@ protected void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162416324
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -327,13 +376,14 @@ public T getClusterId
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5315
[hotfix][docs] Put HADOOP_CONF_DIR in tag
See title.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink hotfix-hadoop-conf-dir
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162581631
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4979#discussion_r162632757
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
@@ -138,7 +138,9
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162714628
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162714906
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -61,46 +69,77 @@
import
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162715070
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
401 - 500 of 691 matches
Mail list logo
