[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r674801406 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -558,18 +559,19 @@ protected

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r674797181 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java ## @@ -1930,4 +1959,21 @@ public boolean add(T e) {

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r674791718 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestDefaultCompactor.java ## @@ -0,0 +1,123 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r674682958 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -533,4 +550,46 @@ protected

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r673471477 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -533,4 +550,46 @@ protected

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r673437645 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -533,4 +550,46 @@ protected

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r673229935 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestDefaultCompactor.java ## @@ -0,0 +1,123 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r673228785 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestDirectStoreCompactor.java ## @@ -0,0 +1,135 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r672923935 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r672308643 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -694,7 +700,7 @@ private void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r672308643 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -694,7 +700,7 @@ private void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r672932031 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -278,6 +280,21 @@ protected final

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r672923935 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r672308643 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -694,7 +700,7 @@ private void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663780661 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663979746 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectStoreCompactor.java ## @@ -0,0 +1,85 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663979457 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectStoreCompactor.java ## @@ -0,0 +1,85 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663974669 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -533,4 +550,46 @@ protected

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663966127 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -278,6 +280,21 @@ protected final

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663958206 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -278,6 +280,21 @@ protected final

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663957101 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -135,7 +135,7 @@ public

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663949806 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1192,7 +1195,7 @@ public StoreFileWriter

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663949806 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1192,7 +1195,7 @@ public StoreFileWriter

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663947613 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -694,7 +700,7 @@ private void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663837361 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -431,7 +437,7 @@ public static long

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663828425 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -1372,7 +1372,7 @@ public RegionInfo getRegionInfo() {

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663781091 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663822974 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1167,7 +1170,7 @@ public StoreFileWriter

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663822333 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1145,16 +1151,13 @@ public StoreFileWriter

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663781334 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectStoreFlushContext.java ## @@ -30,14 +30,14 @@ * directly in the

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663781091 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663780661 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r657484035 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r657483340 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r657483258 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -297,6 +297,30 @@ public void enableCacheOnWrite() {

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656009419 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectInStoreFlushContext.java ## @@ -33,11 +33,11 @@ * To be used only

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656100941 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectInStoreFlushContext.java ## @@ -33,11 +33,11 @@ * To be used only

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656098099 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656045500 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656019402 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656009419 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectInStoreFlushContext.java ## @@ -33,11 +33,11 @@ * To be used only

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656009419 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectInStoreFlushContext.java ## @@ -33,11 +33,11 @@ * To be used only

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655650248 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -266,6 +266,7 @@ public InternalScanner

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655657711 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestDefaultCompactor.java ## @@ -0,0 +1,123 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655657218 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -533,4 +549,46 @@ protected

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655650248 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -266,6 +266,7 @@ public InternalScanner

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655650248 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -266,6 +266,7 @@ public InternalScanner