[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390597#comment-15390597 ] Hudson commented on HBASE-15406: FAILURE: Integrated in HBase-Trunk_matrix #1279 (See

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-07-22 Thread Stephen Yuan Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390490#comment-15390490 ] Stephen Yuan Jiang commented on HBASE-15406: The {{TestMasterReplication}} test failures has

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-07-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390479#comment-15390479 ] Hudson commented on HBASE-15406: FAILURE: Integrated in HBase-1.4 #303 (See

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-07-22 Thread Stephen Yuan Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390230#comment-15390230 ] Stephen Yuan Jiang commented on HBASE-15406: Attached the revert patch for master branch.

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-07-22 Thread Stephen Yuan Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390062#comment-15390062 ] Stephen Yuan Jiang commented on HBASE-15406: [~chenheng], with HBASE-16008 change, there is

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-20 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340448#comment-15340448 ] Enis Soztutar commented on HBASE-15406: --- Problam with Runtime.getRuntime().addShutdownHook() is

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-20 Thread Stephen Yuan Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340191#comment-15340191 ] Stephen Yuan Jiang commented on HBASE-15406: When working on HBASE-16008 to add an ephemeral

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332979#comment-15332979 ] Hudson commented on HBASE-15406: SUCCESS: Integrated in HBase-1.3-IT #708 (See

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332738#comment-15332738 ] Hudson commented on HBASE-15406: FAILURE: Integrated in HBase-1.3 #739 (See

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331390#comment-15331390 ] Heng Chen commented on HBASE-15406: --- If want me to revert this from master and branch-1, please let me

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331137#comment-15331137 ] Heng Chen commented on HBASE-15406: --- OK. Let's go on with your proposal [~enis] > Split / merge

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331115#comment-15331115 ] stack commented on HBASE-15406: --- Sorry. Late to the reply. My -1 comment was against a system that had a

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-14 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330785#comment-15330785 ] Mikhail Antonov commented on HBASE-15406: - Linked separate jira to revert it form 1.3 as I can't

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-14 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330698#comment-15330698 ] Mikhail Antonov commented on HBASE-15406: - I'm going to revert this in branch-1.3 and if we don't

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328879#comment-15328879 ] Heng Chen commented on HBASE-15406: --- +1 for your proposal. > Split / merge switch left disabled after

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-13 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328276#comment-15328276 ] Mikhail Antonov commented on HBASE-15406: - Then it's easier - I assume repair mode is kicked in

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-13 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328262#comment-15328262 ] Enis Soztutar commented on HBASE-15406: --- bq. I don't really want this jira to hold off 1.3 release

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-13 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328011#comment-15328011 ] Mikhail Antonov commented on HBASE-15406: - [~enis] [~chenheng] [~stack] this patch is addressing

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326756#comment-15326756 ] Heng Chen commented on HBASE-15406: --- Ping [~stack]. wdyt? > Split / merge switch left disabled after

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-10 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15325666#comment-15325666 ] Enis Soztutar commented on HBASE-15406: --- The idea is for the master to revert the state because we

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-07 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319886#comment-15319886 ] Heng Chen commented on HBASE-15406: --- Agree. We should have one framework to do this things. In

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-07 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319552#comment-15319552 ] Enis Soztutar commented on HBASE-15406: --- [~syuanjiang] and I was discussing this offline. One idea

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-07 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319492#comment-15319492 ] Enis Soztutar commented on HBASE-15406: --- My main concern is that this will ONLY do this for the

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-05 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316143#comment-15316143 ] Heng Chen commented on HBASE-15406: --- {quote} When admin / HBCK puts the master in maintenance mode,

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-05 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316144#comment-15316144 ] Heng Chen commented on HBASE-15406: --- {quote} When admin / HBCK puts the master in maintenance mode,

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-03 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314821#comment-15314821 ] Enis Soztutar commented on HBASE-15406: --- Instead of ephemeral znode, we can also optionally use

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-06-03 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314814#comment-15314814 ] Enis Soztutar commented on HBASE-15406: --- I've looked at this again, especially related to disabling

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243071#comment-15243071 ] Hudson commented on HBASE-15406: SUCCESS: Integrated in HBase-1.3-IT #615 (See

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243015#comment-15243015 ] Hudson commented on HBASE-15406: FAILURE: Integrated in HBase-1.4 #91 (See

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242919#comment-15242919 ] Hudson commented on HBASE-15406: FAILURE: Integrated in HBase-Trunk_matrix #849 (See

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242786#comment-15242786 ] Hudson commented on HBASE-15406: SUCCESS: Integrated in HBase-1.3 #651 (See

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242593#comment-15242593 ] Heng Chen commented on HBASE-15406: --- commit to master, branch-1.3, branch-1 > Split / merge switch

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242430#comment-15242430 ] stack commented on HBASE-15406: --- bq. is it OK for change admin api on branches which are not released

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242425#comment-15242425 ] Heng Chen commented on HBASE-15406: --- [~stack] Relates Admin api changed was introduced in HBASE-15128,

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242415#comment-15242415 ] stack commented on HBASE-15406: --- Hey [~chenheng] Thanks for working on this one. You get the bit that our

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242390#comment-15242390 ] Heng Chen commented on HBASE-15406: --- If no other suggestions, i will commit it today > Split / merge

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241097#comment-15241097 ] Ted Yu commented on HBASE-15406: +1 > Split / merge switch left disabled after early termination of hbck

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240831#comment-15240831 ] Heng Chen commented on HBASE-15406: --- I test it on cluster with 3 RS, hadoop version is 2.5.0 1. run

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238539#comment-15238539 ] Heng Chen commented on HBASE-15406: --- OK, i will post the result this week later. > Split / merge

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237549#comment-15237549 ] Ted Yu commented on HBASE-15406: Heng: Can you test patch v2 on cluster and post the result ? Thanks >

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-12 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237510#comment-15237510 ] Mikhail Antonov commented on HBASE-15406: - [~te...@apache.org] [~chenheng] sorry guys, don't have

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235243#comment-15235243 ] Ted Yu commented on HBASE-15406: [~mantonov]: Can you take a look at the patch ? > Split / merge switch

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-07 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231550#comment-15231550 ] Heng Chen commented on HBASE-15406: --- Could you help me review the latest patch on review board, thanks!

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-06 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229644#comment-15229644 ] Heng Chen commented on HBASE-15406: --- {quote} 150 if (skipLock) { Move this as the first check

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-04-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223634#comment-15223634 ] Ted Yu commented on HBASE-15406: [~mantonov]: What do you think of the latest patch ? > Split / merge

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-29 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216953#comment-15216953 ] Heng Chen commented on HBASE-15406: --- OK, i will do it. > Split / merge switch left disabled after

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216949#comment-15216949 ] Ted Yu commented on HBASE-15406: Should be fine for now. Once you get +1, it would be better to test on

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-29 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216946#comment-15216946 ] Heng Chen commented on HBASE-15406: --- I test it on standalone mode, is it enough? [~tedyu] > Split /

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216941#comment-15216941 ] Ted Yu commented on HBASE-15406: Heng, thanks for your patience. Can you try out patch v2 on cluster and

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-29 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216908#comment-15216908 ] Heng Chen commented on HBASE-15406: --- Relate test case has passed. And javac warnings have no relates

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216708#comment-15216708 ] Hadoop QA commented on HBASE-15406: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-29 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215698#comment-15215698 ] Heng Chen commented on HBASE-15406: --- {quote} Can we avoid having a key, and have only a simple boolean

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-29 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215672#comment-15215672 ] Mikhail Antonov commented on HBASE-15406: - After re-reading comments here, it gets more and more

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214227#comment-15214227 ] Ted Yu commented on HBASE-15406: [~mantonov]: Mind spending 10 minutes on Heng's patch ? > Split / merge

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-22 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206444#comment-15206444 ] Heng Chen commented on HBASE-15406: --- Thank [~mantonov] for your help. > Split / merge switch left

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-22 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206016#comment-15206016 ] Mikhail Antonov commented on HBASE-15406: - [~te...@apache.org] I started looking at the one at

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205294#comment-15205294 ] Ted Yu commented on HBASE-15406: [~mantonov]: What do you think of Heng's latest patch ? > Split / merge

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201475#comment-15201475 ] Heng Chen commented on HBASE-15406: --- If we use ephemeral node, the lock will disappear after hbck

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201402#comment-15201402 ] Ted Yu commented on HBASE-15406: bq. it will cause conflicts when two hbck run at the same time. There

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201103#comment-15201103 ] Hadoop QA commented on HBASE-15406: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201230#comment-15201230 ] Hadoop QA commented on HBASE-15406: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201516#comment-15201516 ] Heng Chen commented on HBASE-15406: --- {quote} Can you identify the users in steps 1 and 3 above ? Are

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201458#comment-15201458 ] Heng Chen commented on HBASE-15406: --- {quote} Since the key can be ignored, it is not that useful. You

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201501#comment-15201501 ] Ted Yu commented on HBASE-15406: Can you identify the users in steps 1 and 3 above ? Are they different

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200824#comment-15200824 ] Ted Yu commented on HBASE-15406: Heng: I triggered new QA run. Can you outline how you tested latest

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201056#comment-15201056 ] Heng Chen commented on HBASE-15406: --- Currently there are two situations for switch changes * use

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201553#comment-15201553 ] Ted Yu commented on HBASE-15406: bq. Is there any difference whether they are the same user? There is

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201485#comment-15201485 ] Ted Yu commented on HBASE-15406: But shouldn't the admin rerun hbck if previous hbck run gets aborted ?

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201469#comment-15201469 ] Ted Yu commented on HBASE-15406: {code} 4283 ZKUtil.createSetData(zkw, splitOrMergeLock, 4284

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-18 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201495#comment-15201495 ] Heng Chen commented on HBASE-15406: --- Think about this situation: 1. before the first hbck run,

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192847#comment-15192847 ] Hadoop QA commented on HBASE-15406: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192682#comment-15192682 ] Heng Chen commented on HBASE-15406: --- Thanks [~stack] for your suggestion. Let me try to move the

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192680#comment-15192680 ] Heng Chen commented on HBASE-15406: --- I add "System.exit()" in HBCK to mock the situation hbck abort

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191477#comment-15191477 ] stack commented on HBASE-15406: --- To be more clear, -1 on a patch that has master doing a rollback of a

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191409#comment-15191409 ] Ted Yu commented on HBASE-15406: Heng: Can you describe how you tested the latest patch ? Thanks >

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190018#comment-15190018 ] Hadoop QA commented on HBASE-15406: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189443#comment-15189443 ] Ted Yu commented on HBASE-15406: Do you mind putting the patch on reviewboard ? {code} + boolean[]

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189087#comment-15189087 ] Hadoop QA commented on HBASE-15406: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-09 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188378#comment-15188378 ] Heng Chen commented on HBASE-15406: --- {quote} The exception message doesn't match the condition. Did you

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187668#comment-15187668 ] Ted Yu commented on HBASE-15406: {code} +if (ZKUtil.checkExists(watcher, splitOrMergeLease) < 0) { +

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-08 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186643#comment-15186643 ] Mikhail Antonov commented on HBASE-15406: - How many such tools we could have in mind, which might

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-08 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186567#comment-15186567 ] stack commented on HBASE-15406: --- This issue is 'critical'? bq. I really don't like one thread to do

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-08 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186565#comment-15186565 ] Heng Chen commented on HBASE-15406: --- Oh, sorry. Just see it. {quote} If so, changing the switch from

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186534#comment-15186534 ] Ted Yu commented on HBASE-15406: That was what I talked about earlier:

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-08 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186508#comment-15186508 ] Heng Chen commented on HBASE-15406: --- This is my plan. When some tool (for example, hbck) running, it

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186054#comment-15186054 ] Ted Yu commented on HBASE-15406: SwitchStateTracker (running in master JVM) creates the (ephemeral)

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-07 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184252#comment-15184252 ] Heng Chen commented on HBASE-15406: --- {quote} I was thinking of using Leases to keep track of the

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-07 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184159#comment-15184159 ] Mikhail Antonov commented on HBASE-15406: - ephemeral znodes sound good to me. > Split / merge

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-07 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184134#comment-15184134 ] Enis Soztutar commented on HBASE-15406: --- We had discussed this internally related to some other

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-07 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183585#comment-15183585 ] Mikhail Antonov commented on HBASE-15406: - cc [~enis] [~mbertozzi] > Split / merge switch left

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-07 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183579#comment-15183579 ] Mikhail Antonov commented on HBASE-15406: - [~te...@apache.org] now as I'm thinking about it, I

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183264#comment-15183264 ] Ted Yu commented on HBASE-15406: bq. when one presses ctrl-c in terminal, that should be interruptible

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-06 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182664#comment-15182664 ] Heng Chen commented on HBASE-15406: --- To be honest, i don't like the way master do clean up with a

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-06 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182622#comment-15182622 ] Mikhail Antonov commented on HBASE-15406: - Also..when one presses ctrl-c in terminal, that should

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-06 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182613#comment-15182613 ] Mikhail Antonov commented on HBASE-15406: - Right. The timeline is a question though. If we can

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-06 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182572#comment-15182572 ] Heng Chen commented on HBASE-15406: --- {quote} One of the solutions would be to have ephemeral znode for

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-06 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182568#comment-15182568 ] Mikhail Antonov commented on HBASE-15406: - I guess Ted is talking about the latter case, when you

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-06 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182560#comment-15182560 ] Heng Chen commented on HBASE-15406: --- IMO there are two situations of hbck abort. * hbck exit because

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182425#comment-15182425 ] Ted Yu commented on HBASE-15406: Heng: Before putting up a patch, can you let us know how you plan to

[jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck

2016-03-06 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182365#comment-15182365 ] Heng Chen commented on HBASE-15406: --- Oh, sorry, it has no dealing when hbck abort. Let me fix it. >

  1   2   >