[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708253#comment-15708253
]
Lei Chang commented on HBASE-15893:
---
This is a really good feature. and it will benefit a lot of c/c++
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645160#comment-15645160
]
Enis Soztutar commented on HBASE-15893:
---
Thanks Anoop. I think the one with the upper case is the
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644225#comment-15644225
]
Anoop Sam John commented on HBASE-15893:
[~enis] The commit went to a branch HBASE-14850. Seem
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634662#comment-15634662
]
Sudeep Sunthankar commented on HBASE-15893:
---
Thanks [~enis]. Sorry for mixing up the patches. I
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628979#comment-15628979
]
Sudeep Sunthankar commented on HBASE-15893:
---
I forgot to add that the tests will generate fatal
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628920#comment-15628920
]
Sudeep Sunthankar commented on HBASE-15893:
---
Thanks for the feedback [~enis].
We can use
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626760#comment-15626760
]
Enis Soztutar commented on HBASE-15893:
---
For negative tests, this is still not correct:
{code}
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566985#comment-15566985
]
Enis Soztutar commented on HBASE-15893:
---
It is fine to add test cases where the expectation is that
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566948#comment-15566948
]
Sudeep Sunthankar commented on HBASE-15893:
---
Hi [~enis],
I have added test cases which
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566855#comment-15566855
]
Enis Soztutar commented on HBASE-15893:
---
[~sudeeps] the new tests are failing with the patch:
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459970#comment-15459970
]
Sudeep Sunthankar commented on HBASE-15893:
---
Hi [~eclark], any thoughts on the last patch
>
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411668#comment-15411668
]
Sudeep Sunthankar commented on HBASE-15893:
---
Thanks for the feedback [~eclark].
We are
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409785#comment-15409785
]
Elliott Clark commented on HBASE-15893:
---
* None of this is hooked up to the client.
* No Get before
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408739#comment-15408739
]
Enis Soztutar commented on HBASE-15893:
---
bq. Instead of returning integer 0 for suceess and
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407895#comment-15407895
]
Sudeep Sunthankar commented on HBASE-15893:
---
Thanks [~enis]
Please find my comments below
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406910#comment-15406910
]
Enis Soztutar commented on HBASE-15893:
---
Thanks [~sudeeps] for the new patch.
- Why is this part
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311046#comment-15311046
]
Elliott Clark commented on HBASE-15893:
---
You don't need to abstract it out if you never make the
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311012#comment-15311012
]
Enis Soztutar commented on HBASE-15893:
---
bq. That's how bytes are passed back. If we want to have
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309195#comment-15309195
]
Elliott Clark commented on HBASE-15893:
---
bq.Our KV can be something like:
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308973#comment-15308973
]
Enis Soztutar commented on HBASE-15893:
---
bq. There's no need to have a byte comparable when string
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308920#comment-15308920
]
Enis Soztutar commented on HBASE-15893:
---
bq. Motivation for creating hconstants was same as above.
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307118#comment-15307118
]
Sudeep Sunthankar commented on HBASE-15893:
---
Hi Elliott,
I have some queries regarding your
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306156#comment-15306156
]
Sudeep Sunthankar commented on HBASE-15893:
---
Sure Stack, will use submit-patch.py for
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306151#comment-15306151
]
Sudeep Sunthankar commented on HBASE-15893:
---
Thanks for the suggestions Elliott, will work on
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305165#comment-15305165
]
stack commented on HBASE-15893:
---
Hey [~sudeeps] Mind putting the putting the next patch after addressing
[
https://issues.apache.org/jira/browse/HBASE-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304537#comment-15304537
]
Elliott Clark commented on HBASE-15893:
---
-1
* Auto generated everywhere. If code isn't needed and
26 matches
Mail list logo
