[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721157#comment-16721157
]
Hudson commented on HBASE-18309:
Results for branch branch-1.3
[build #576 on
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720768#comment-16720768
]
Hudson commented on HBASE-18309:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #509 (See
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434355#comment-16434355
]
Hudson commented on HBASE-18309:
Results for branch branch-1.4
[build #284 on
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433718#comment-16433718
]
Hudson commented on HBASE-18309:
Results for branch branch-1
[build #278 on
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433455#comment-16433455
]
Reid Chan commented on HBASE-18309:
---
Update release note, more clear description about
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426288#comment-16426288
]
Zach York commented on HBASE-18309:
---
+1 for opening a new JIRA.
> Support multi threads in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424976#comment-16424976
]
Reid Chan commented on HBASE-18309:
---
I'm ok with this.
> Support multi threads in CleanerChore
>
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424939#comment-16424939
]
Yu Li commented on HBASE-18309:
---
Again I'd suggest to open a new JIRA for the backport-to-branch-1 task.
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424938#comment-16424938
]
Reid Chan commented on HBASE-18309:
---
{quote}can you put the branch-1 part in review board as well?
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424812#comment-16424812
]
Andrew Purtell commented on HBASE-18309:
If the version in the POM of hbase-error-prone is not
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424719#comment-16424719
]
Mike Drob commented on HBASE-18309:
---
The error prone libs aren't getting built during the mvn install
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424694#comment-16424694
]
Zach York commented on HBASE-18309:
---
I'm not very familiar with the jenkins structure yet, but it looks
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424645#comment-16424645
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424471#comment-16424471
]
Zach York commented on HBASE-18309:
---
[~reidchan] can you put the branch-1 part in review board as well?
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424439#comment-16424439
]
Zach York commented on HBASE-18309:
---
Looks like the compilation was messed up. I reattached the patch
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420639#comment-16420639
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420429#comment-16420429
]
Reid Chan commented on HBASE-18309:
---
ping [~zyork]
would you mind taking a look at the QA results?
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420418#comment-16420418
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420277#comment-16420277
]
Reid Chan commented on HBASE-18309:
---
Remove lambda expression in UTs, and re-import package order
>
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420268#comment-16420268
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420217#comment-16420217
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420169#comment-16420169
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420153#comment-16420153
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420152#comment-16420152
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418041#comment-16418041
]
Yu Li commented on HBASE-18309:
---
Yes you are right [~reidchan]. Unfortunately HBASE-14247 introduces
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416754#comment-16416754
]
Reid Chan commented on HBASE-18309:
---
There's a huge gap...
multithreads HFileCleaner is not included in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416621#comment-16416621
]
Reid Chan commented on HBASE-18309:
---
Yes, i have. Feeling sorry for keeping you waiting.
> Support
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415969#comment-16415969
]
Zach York commented on HBASE-18309:
---
[~reidchan] I see that HBASE-20095 just made it in. Do you think
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387387#comment-16387387
]
Reid Chan commented on HBASE-18309:
---
Just in few days i suppose:)
> Support multi threads in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381075#comment-16381075
]
Zach York commented on HBASE-18309:
---
That would be awesome [~reidchan]! Please ping me for any
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379701#comment-16379701
]
Reid Chan commented on HBASE-18309:
---
Thanks [~zyork], [~apurtell].
I can provide a patch backporting
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379127#comment-16379127
]
Andrew Purtell commented on HBASE-18309:
[~zyork] I've done a fair bit of backporting. This
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379064#comment-16379064
]
Zach York commented on HBASE-18309:
---
[~reidchan] Just stumbled upon this. Awesome work! Do you have an
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377926#comment-16377926
]
Reid Chan commented on HBASE-18309:
---
FYI, [~stack], HBASE-20095
> Support multi threads in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377906#comment-16377906
]
Reid Chan commented on HBASE-18309:
---
Yes, sir, i got your point, a new issue is fine.
> Support multi
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377826#comment-16377826
]
stack commented on HBASE-18309:
---
[~reidchan] You up for taking a look again at how CleanerChore does its
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305642#comment-16305642
]
Peter Somogyi commented on HBASE-18309:
---
I can't take it because I will be away for 2 weeks.
>
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305632#comment-16305632
]
Reid Chan commented on HBASE-18309:
---
[~psomogyi] I can review, or take it only if you don't have that
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305629#comment-16305629
]
Reid Chan commented on HBASE-18309:
---
Those threads run only one *deletion* policy against a single
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305623#comment-16305623
]
Peter Somogyi commented on HBASE-18309:
---
Created HBASE-19654. [~reidchan], would you like to take
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305606#comment-16305606
]
stack commented on HBASE-18309:
---
[~psomogyi] I got the easy one, the log level (smile). Issue on
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305598#comment-16305598
]
Peter Somogyi commented on HBASE-18309:
---
bq. Please open new issue.
[~stack], new issue about
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305588#comment-16305588
]
Reid Chan commented on HBASE-18309:
---
bq. held the file there so CleanerChore received false meaning the
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1630#comment-1630
]
stack commented on HBASE-18309:
---
Thank you [~psomogyi] Please open new issue. This is a prob. What do you
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305317#comment-16305317
]
Peter Somogyi commented on HBASE-18309:
---
I ran into a couple of WARN messages last week. The
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305063#comment-16305063
]
stack commented on HBASE-18309:
---
No harm done sir.
> Support multi threads in CleanerChore
>
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305053#comment-16305053
]
Reid Chan commented on HBASE-18309:
---
Thank you sir, and please pardon me..
> Support multi threads in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305052#comment-16305052
]
stack commented on HBASE-18309:
---
That helps [~reidchan] Let me make use of your code snippet and only log
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305045#comment-16305045
]
Reid Chan commented on HBASE-18309:
---
bq. I'll suppress these lines too.
Just do it, no objection. I
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305038#comment-16305038
]
stack commented on HBASE-18309:
---
See above [~psomogyi] Maybe you have an opinion sir?
> Support multi
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305037#comment-16305037
]
stack commented on HBASE-18309:
---
Cleaner is also removing these:
2017-12-27 19:59:02,261 DEBUG
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305035#comment-16305035
]
stack commented on HBASE-18309:
---
[~reidchan] It runs too often and the spew in a big cluster is profuse. I
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305034#comment-16305034
]
Reid Chan commented on HBASE-18309:
---
Thank you sir, it is ok to cut those chatty {{DEBUG}}
To get more
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305002#comment-16305002
]
stack commented on HBASE-18309:
---
[~reidchan] Yes. Its chatty. I can cut it back. The "Couldn't delete..."
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304999#comment-16304999
]
Reid Chan commented on HBASE-18309:
---
[~stack] Because there are new files added under dir (not empty
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304885#comment-16304885
]
stack commented on HBASE-18309:
---
[~reidchan] this change spews logging into Master log. The 'undeletable'
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294213#comment-16294213
]
Hudson commented on HBASE-18309:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4242 (See
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294195#comment-16294195
]
Ted Yu commented on HBASE-18309:
Thanks for keeping an eye on the exception, Chia-ping.
Current fix is
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294097#comment-16294097
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294051#comment-16294051
]
Reid Chan commented on HBASE-18309:
---
Thank you [~chia7712], LGTM.
> Support multi threads in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294049#comment-16294049
]
Chia-Ping Tsai commented on HBASE-18309:
I observer the NEP in log.
{code}
2017-12-17
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265096#comment-16265096
]
Hudson commented on HBASE-18309:
SUCCESS: Integrated in Jenkins build HBase-2.0 #906 (See
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263943#comment-16263943
]
Hudson commented on HBASE-18309:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4102 (See
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263723#comment-16263723
]
Yu Li commented on HBASE-18309:
---
Ok, let me commit this one.
[~stack] I'm planning to commit this one into
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260738#comment-16260738
]
Chia-Ping Tsai commented on HBASE-18309:
+1
> Support multi threads in CleanerChore
>
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260634#comment-16260634
]
Hadoop QA commented on HBASE-18309:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260349#comment-16260349
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259257#comment-16259257
]
Reid Chan commented on HBASE-18309:
---
bq. As concerned, it's possible for thread flood happen and drag
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259198#comment-16259198
]
Hadoop QA commented on HBASE-18309:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258899#comment-16258899
]
Hadoop QA commented on HBASE-18309:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258814#comment-16258814
]
Reid Chan commented on HBASE-18309:
---
Sorry to keep you waiting[~carp84], i will file it later.
>
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258806#comment-16258806
]
Yu Li commented on HBASE-18309:
---
Patch v9 LGTM, +1
bq. As concerned, it's possible for thread flood happen
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258785#comment-16258785
]
Reid Chan commented on HBASE-18309:
---
Any other thoughts or comments?
> Support multi threads in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257959#comment-16257959
]
Hadoop QA commented on HBASE-18309:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257058#comment-16257058
]
Reid Chan commented on HBASE-18309:
---
Failed tests are not related.
> Support multi threads in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257047#comment-16257047
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257029#comment-16257029
]
Hadoop QA commented on HBASE-18309:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255656#comment-16255656
]
Hadoop QA commented on HBASE-18309:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255377#comment-16255377
]
Reid Chan commented on HBASE-18309:
---
Import orders makes me headache :(
> Support multi threads in
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254885#comment-16254885
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254363#comment-16254363
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253145#comment-16253145
]
Yu Li commented on HBASE-18309:
---
Left some review comments on rb, please check.
bq. please allow me to
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253086#comment-16253086
]
Hadoop QA commented on HBASE-18309:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247212#comment-16247212
]
Yu Li commented on HBASE-18309:
---
bq. New simulation first creates 10 dirs under oldWALs...
Thanks for the
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247086#comment-16247086
]
Reid Chan commented on HBASE-18309:
---
New simulation first creates 10 dirs under oldWALs (hbase.rootdir
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245467#comment-16245467
]
Yu Li commented on HBASE-18309:
---
bq. I may misunderstand binlijin's original intent, which is to focus on
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243622#comment-16243622
]
Reid Chan commented on HBASE-18309:
---
bq. Although both needs multiple threads, HFileCleaner separates
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243570#comment-16243570
]
Yu Li commented on HBASE-18309:
---
bq. I think both can be unified, since they have same chore() methods, the
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243365#comment-16243365
]
Sean Busbey commented on HBASE-18309:
-
{quote}
No need to use a real large scale, it can be simulated
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243332#comment-16243332
]
Reid Chan commented on HBASE-18309:
---
bq. for a reasonable test please use a larger scale and include
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243351#comment-16243351
]
Yu Li commented on HBASE-18309:
---
I think we should focus on {{LogCleaner}} instead of {{CleanerChore}} here
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243366#comment-16243366
]
Reid Chan commented on HBASE-18309:
---
I think both can be unified, since they have same chore() methods,
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242675#comment-16242675
]
Sean Busbey commented on HBASE-18309:
-
bq. In production, the number of directories would be greater
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242499#comment-16242499
]
Ted Yu commented on HBASE-18309:
In production, the number of directories would be greater than the
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242487#comment-16242487
]
Reid Chan commented on HBASE-18309:
---
bq. The sorting in current code base would clean large directory
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242419#comment-16242419
]
Hadoop QA commented on HBASE-18309:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242416#comment-16242416
]
Ted Yu commented on HBASE-18309:
bq. hbase.rootdir is /tmp/hbase
Please use directory outside of /tmp as
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242107#comment-16242107
]
Reid Chan commented on HBASE-18309:
---
Add a link to review board
> Support multi threads in
98 matches
Mail list logo
