[GitHub] [hbase] Apache-HBase commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853581429 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25960) Build includes unshaded netty .so; clashes w/ downstreamers who would use a different version of netty

2021-06-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356158#comment-17356158 ] Michael Stack commented on HBASE-25960: --- Building w/ thirdparty-3.5.0 RC0 seems to clean out all

[GitHub] [hbase] mymeiyi commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
mymeiyi commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644480714 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-853548279 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-06-02 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356091#comment-17356091 ] Zhuoyue Huang edited comment on HBASE-25914 at 6/3/21, 4:00 AM: [~stack] 

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
anoopsjohn commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644466713 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[jira] [Assigned] (HBASE-25954) When graceful_stop a regionserver, RegionMover always retry to move the regions to other rsgoup's regionservers

2021-06-02 Thread kangkang.guo (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo reassigned HBASE-25954: Assignee: kangkang.guo > When graceful_stop a regionserver, RegionMover always retry to

[GitHub] [hbase] mymeiyi commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
mymeiyi commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644458410 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-02 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-853535877 Those failed unit tests work fine locally. org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.(?) -- This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853535772 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] mymeiyi commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
mymeiyi commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644458410 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[GitHub] [hbase] mymeiyi commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
mymeiyi commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644458410 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[GitHub] [hbase] mymeiyi commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
mymeiyi commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644458410 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
anoopsjohn commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644451703 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
anoopsjohn commented on a change in pull request #3347: URL: https://github.com/apache/hbase/pull/3347#discussion_r644450797 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java ## @@ -69,13 +68,14 @@ public void

[GitHub] [hbase] mymeiyi commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-02 Thread GitBox
mymeiyi commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853523470 > So the latest version change is moving the check for possible shipped() called out of the for loop. The cons here is that when we have wide rows with so many cells in it, this

[jira] [Created] (HBASE-25967) The readRequestsCount does not calculate when the outResults is empty

2021-06-02 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-25967: -- Summary: The readRequestsCount does not calculate when the outResults is empty Key: HBASE-25967 URL: https://issues.apache.org/jira/browse/HBASE-25967 Project: HBase

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-06-02 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356091#comment-17356091 ] Zhuoyue Huang commented on HBASE-25914: --- [~stack]  [~vjasani]  Thanks for the comments. If there

[jira] [Commented] (HBASE-25954) When graceful_stop a regionserver, RegionMover always retry to move the regions to other rsgoup's regionservers

2021-06-02 Thread Zezhen Jia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356080#comment-17356080 ] Zezhen Jia commented on HBASE-25954: thanks very munch, yes have been solved,I'm use hbase

[GitHub] [hbase] Apache9 commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-02 Thread GitBox
Apache9 commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-853488121 > Perhaps one of you can suggest how to verify that the license content is being included in the appropriate places after this change -- what those places are and whether it

[jira] [Commented] (HBASE-25896) Implement a Region Visualization on Master WebUI

2021-06-02 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356046#comment-17356046 ] Nick Dimiduk commented on HBASE-25896: -- Thank you for these references. I have pushed a new commit

[GitHub] [hbase] Apache-HBase commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-853419373 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-853419089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] ndimiduk commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-02 Thread GitBox
ndimiduk commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-853416924 Trying to interpret this output. I think our build is configured such that the only module that bundles bootstrap is hbase-server. However, I think we also bundle it in

[GitHub] [hbase] ndimiduk commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-02 Thread GitBox
ndimiduk commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-853413908 Perhaps one of you can suggest how to verify that the license content is being included in the appropriate places after this change -- what those places are and whether it

[GitHub] [hbase] ndimiduk opened a new pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-02 Thread GitBox
ndimiduk opened a new pull request #3349: URL: https://github.com/apache/hbase/pull/3349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (HBASE-25966) Fix typo in NOTICE.vm

2021-06-02 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25966: Summary: Fix typo in NOTICE.vm Key: HBASE-25966 URL: https://issues.apache.org/jira/browse/HBASE-25966 Project: HBase Issue Type: Bug Components:

[jira] [Resolved] (HBASE-25965) Move delete of WAL directory out of LOG.info and avoid left over directory

2021-06-02 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-25965. -- Fix Version/s: 1.2.0 Hadoop Flags: Reviewed Resolution: Fixed >

[jira] [Commented] (HBASE-25965) Move delete of WAL directory out of LOG.info and avoid left over directory

2021-06-02 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355962#comment-17355962 ] Tak-Lon (Stephen) Wu commented on HBASE-25965: -- commit

[GitHub] [hbase-operator-tools] taklwu merged pull request #89: HBASE-25965 Move delete of WAL directory out of LOG.info and avoid le…

2021-06-02 Thread GitBox
taklwu merged pull request #89: URL: https://github.com/apache/hbase-operator-tools/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #89: HBASE-25965 Move delete of WAL directory out of LOG.info and avoid le…

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #89: URL: https://github.com/apache/hbase-operator-tools/pull/89#issuecomment-853288714 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase-operator-tools] taklwu opened a new pull request #89: HBASE-25965 Move delete of WAL directory out of LOG.info and avoid le…

2021-06-02 Thread GitBox
taklwu opened a new pull request #89: URL: https://github.com/apache/hbase-operator-tools/pull/89 …ftover directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355905#comment-17355905 ] Hudson commented on HBASE-25932: Results for branch branch-2 [build #267 on

[jira] [Updated] (HBASE-25965) Move delete of WAL directory out of LOG.info and avoid left over directory

2021-06-02 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-25965: - Description: Followup the comment by [~anoopsamjohn] on HBASE-25921 (in

[jira] [Assigned] (HBASE-25965) Move delete of WAL directory out of LOG.info and avoid left over directory

2021-06-02 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-25965: Assignee: Tak-Lon (Stephen) Wu > Move delete of WAL directory out of

[jira] [Commented] (HBASE-25911) Fix uses of System.currentTimeMillis (should be EnvironmentEdgeManager.currentTime)

2021-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355906#comment-17355906 ] Hudson commented on HBASE-25911: Results for branch branch-2 [build #267 on

[jira] [Created] (HBASE-25965) Move delete of WAL directory out of LOG.info and avoid left over directory

2021-06-02 Thread Tak-Lon (Stephen) Wu (Jira)
Tak-Lon (Stephen) Wu created HBASE-25965: Summary: Move delete of WAL directory out of LOG.info and avoid left over directory Key: HBASE-25965 URL: https://issues.apache.org/jira/browse/HBASE-25965

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

2021-06-02 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355899#comment-17355899 ] Sandeep Pal commented on HBASE-25596: - [~anoop.hbase] Thanks for catching agree that it's a miss.

[GitHub] [hbase] Apache-HBase commented on pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3347: URL: https://github.com/apache/hbase/pull/3347#issuecomment-853267795 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25921) Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-06-02 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355891#comment-17355891 ] Tak-Lon (Stephen) Wu commented on HBASE-25921: -- it has been committed to master branch as

[jira] [Resolved] (HBASE-25921) Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-06-02 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-25921. -- Fix Version/s: 1.2.0 Resolution: Fixed > Fix Wrong FileSystem when

[GitHub] [hbase-operator-tools] taklwu merged pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-06-02 Thread GitBox
taklwu merged pull request #88: URL: https://github.com/apache/hbase-operator-tools/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3348: HBASE-25963 HBaseCluster should be marked as IA.Public

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3348: URL: https://github.com/apache/hbase/pull/3348#issuecomment-853238957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25596) Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL

2021-06-02 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355881#comment-17355881 ] Anoop Sam John commented on HBASE-25596: [~sandeep.pal] Seems there is a one line issue/miss in

[GitHub] [hbase] Apache-HBase commented on pull request #3348: HBASE-25963 HBaseCluster should be marked as IA.Public

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3348: URL: https://github.com/apache/hbase/pull/3348#issuecomment-853233797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25960) Build includes unshaded netty .so; clashes w/ downstreamers who would use a different version of netty

2021-06-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355849#comment-17355849 ] Michael Stack commented on HBASE-25960: --- Yeah, we probably need to move those native-image items

[GitHub] [hbase] Apache-HBase commented on pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3347: URL: https://github.com/apache/hbase/pull/3347#issuecomment-853142737 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3347: URL: https://github.com/apache/hbase/pull/3347#issuecomment-853137129 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25964) [HBOSS] Introducing hbase metrics to Hboss

2021-06-02 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25964. -- Resolution: Fixed Merged into master. Thanks for the contribution

[jira] [Updated] (HBASE-25964) [HBOSS] Introducing hbase metrics to Hboss

2021-06-02 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25964: - Issue Type: New Feature (was: Improvement) > [HBOSS] Introducing hbase metrics

[jira] [Updated] (HBASE-25964) [HBOSS] Introducing hbase metrics to Hboss

2021-06-02 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25964: - Labels: hbase-filesystem (was: ) > [HBOSS] Introducing hbase metrics to Hboss

[GitHub] [hbase-filesystem] wchevreuil merged pull request #22: HBASE-25964 Add metrics for rename

2021-06-02 Thread GitBox
wchevreuil merged pull request #22: URL: https://github.com/apache/hbase-filesystem/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Created] (HBASE-25964) [HBOSS] Introducing hbase metrics to Hboss

2021-06-02 Thread Szabolcs Bukros (Jira)
Szabolcs Bukros created HBASE-25964: --- Summary: [HBOSS] Introducing hbase metrics to Hboss Key: HBASE-25964 URL: https://issues.apache.org/jira/browse/HBASE-25964 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3348: HBASE-25963 HBaseCluster should be marked as IA.Public

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3348: URL: https://github.com/apache/hbase/pull/3348#issuecomment-853123984 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25331) [HBOSS] TreeLockManager should log warnings about lock contention periodically

2021-06-02 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25331: - Labels: hbase-filesystem (was: ) > [HBOSS] TreeLockManager should log warnings

[GitHub] [hbase] wchevreuil commented on a change in pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
wchevreuil commented on a change in pull request #3347: URL: https://github.com/apache/hbase/pull/3347#discussion_r644061792 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java ## @@ -103,6 +103,12 @@ protected

[GitHub] [hbase] wchevreuil commented on a change in pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
wchevreuil commented on a change in pull request #3347: URL: https://github.com/apache/hbase/pull/3347#discussion_r644060948 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java ## @@ -296,6 +300,53 @@ public boolean

[GitHub] [hbase] wchevreuil commented on a change in pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
wchevreuil commented on a change in pull request #3347: URL: https://github.com/apache/hbase/pull/3347#discussion_r644059640 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestRemoveFromSerialReplicationPeer.java ## @@ -89,14 +93,18 @@ public

[jira] [Commented] (HBASE-13126) Provide alternate mini cluster classes other than HBTU for downstream users to write unit tests

2021-06-02 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355785#comment-17355785 ] Sean Busbey commented on HBASE-13126: - thinking about this more, that approach will force all

[GitHub] [hbase] wchevreuil commented on a change in pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
wchevreuil commented on a change in pull request #3347: URL: https://github.com/apache/hbase/pull/3347#discussion_r644048799 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java ## @@ -396,11 +447,11 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
wchevreuil commented on a change in pull request #3347: URL: https://github.com/apache/hbase/pull/3347#discussion_r644047371 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java ## @@ -69,13 +68,14 @@ public void

[jira] [Commented] (HBASE-25896) Implement a Region Visualization on Master WebUI

2021-06-02 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355780#comment-17355780 ] Sean Busbey commented on HBASE-25896: - g-d this is reminding me about how terribly complicated all

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-853087878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-853085664 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25896) Implement a Region Visualization on Master WebUI

2021-06-02 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355777#comment-17355777 ] Sean Busbey commented on HBASE-25896: - For the hbase-server module, we rely on a templating language

[jira] [Updated] (HBASE-13126) Provide alternate mini cluster classes other than HBTU for downstream users to write unit tests

2021-06-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-13126: -- Summary: Provide alternate mini cluster classes other than HBTU for downstream users to write unit

[jira] [Commented] (HBASE-25960) Build includes unshaded netty .so; clashes w/ downstreamers who would use a different version of netty

2021-06-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355776#comment-17355776 ] Duo Zhang commented on HBASE-25960: --- Do you see the native-image directory under META-INF? after

[jira] [Reopened] (HBASE-19515) Region server left in online servers list forever if it went down after registering to master and before creating ephemeral node

2021-06-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-19515: --- I do not think HBASE-25032 is for fixing this. The problem here is that, after the first registration

[jira] [Commented] (HBASE-25896) Implement a Region Visualization on Master WebUI

2021-06-02 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355769#comment-17355769 ] Sean Busbey commented on HBASE-25896: - BSD-3 clause is great because that means [we need to add a

[jira] [Updated] (HBASE-19515) Region server left in online servers list forever if it went down after registering to master and before creating ephemeral node

2021-06-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19515: -- Fix Version/s: (was: 3.0.0-alpha-2) > Region server left in online servers list forever if it

[GitHub] [hbase] Apache9 opened a new pull request #3348: HBASE-25963 HBaseCluster should be marked as IA.Public

2021-06-02 Thread GitBox
Apache9 opened a new pull request #3348: URL: https://github.com/apache/hbase/pull/3348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Updated] (HBASE-13126) Move HBaseTestingUtility and associated support classes into hbase-testing-utility module

2021-06-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-13126: -- Issue Type: Umbrella (was: Task) > Move HBaseTestingUtility and associated support classes into >

[jira] [Created] (HBASE-25963) HBaseCluster should be marked as IA.Public

2021-06-02 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25963: - Summary: HBaseCluster should be marked as IA.Public Key: HBASE-25963 URL: https://issues.apache.org/jira/browse/HBASE-25963 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-25911) Fix uses of System.currentTimeMillis (should be EnvironmentEdgeManager.currentTime)

2021-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355742#comment-17355742 ] Hudson commented on HBASE-25911: Results for branch master [build #312 on

[jira] [Commented] (HBASE-25956) Add 2.4.3 to download page

2021-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355741#comment-17355741 ] Hudson commented on HBASE-25956: Results for branch master [build #312 on

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355740#comment-17355740 ] Hudson commented on HBASE-25932: Results for branch master [build #312 on

[jira] [Commented] (HBASE-25960) Build includes unshaded netty .so; clashes w/ downstreamers who would use a different version of netty

2021-06-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355724#comment-17355724 ] Michael Stack commented on HBASE-25960: --- Thanks for taking a look. The 3.5.1RC0 looks good. Let

[jira] [Commented] (HBASE-25910) Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.

2021-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355716#comment-17355716 ] Hudson commented on HBASE-25910: Results for branch branch-1 [build #133 on

[GitHub] [hbase-thirdparty] saintstack commented on pull request #55: HBASE-25962 [hbase-thirdparty] Relocate mac jnilib for netty

2021-06-02 Thread GitBox
saintstack commented on pull request #55: URL: https://github.com/apache/hbase-thirdparty/pull/55#issuecomment-853026591 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (HBASE-19515) Region server left in online servers list forever if it went down after registering to master and before creating ephemeral node

2021-06-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-19515. --- Resolution: Not A Problem Resolving as 'Not a Problem', fixed by HBASE-25032. Thanks

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-852993818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

2021-06-02 Thread GitBox
anoopsjohn commented on a change in pull request #3347: URL: https://github.com/apache/hbase/pull/3347#discussion_r643887997 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java ## @@ -69,13 +68,14 @@ public void

[jira] [Commented] (HBASE-19515) Region server left in online servers list forever if it went down after registering to master and before creating ephemeral node

2021-06-02 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355649#comment-17355649 ] Anoop Sam John commented on HBASE-19515: I believe this is fixed now. HBASE-25032 - Do not

[jira] [Resolved] (HBASE-25962) [hbase-thirdparty] Relocate mac jnilib for netty

2021-06-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25962. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~pankajkumar] for

[GitHub] [hbase-thirdparty] Apache9 merged pull request #55: HBASE-25962 [hbase-thirdparty] Relocate mac jnilib for netty

2021-06-02 Thread GitBox
Apache9 merged pull request #55: URL: https://github.com/apache/hbase-thirdparty/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #55: HBASE-25962 [hbase-thirdparty] Relocate mac jnilib for netty

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #55: URL: https://github.com/apache/hbase-thirdparty/pull/55#issuecomment-852888342 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-852887344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-thirdparty] Apache9 opened a new pull request #55: HBASE-25962 [hbase-thirdparty] Relocate mac jnilib for netty

2021-06-02 Thread GitBox
Apache9 opened a new pull request #55: URL: https://github.com/apache/hbase-thirdparty/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-852872529 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

2021-06-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355601#comment-17355601 ] Hudson commented on HBASE-25938: Results for branch branch-2.3 [build #229 on

[jira] [Created] (HBASE-25962) [hbase-thirdparty] Relocate mac jnilib for netty

2021-06-02 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25962: - Summary: [hbase-thirdparty] Relocate mac jnilib for netty Key: HBASE-25962 URL: https://issues.apache.org/jira/browse/HBASE-25962 Project: HBase Issue Type: Task

[jira] [Commented] (HBASE-25960) Build includes unshaded netty .so; clashes w/ downstreamers who would use a different version of netty

2021-06-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355594#comment-17355594 ] Duo Zhang commented on HBASE-25960: --- I generated 3.5.1RC0 with the docker based create-release

[jira] [Resolved] (HBASE-25910) Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.

2021-06-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25910. -- Fix Version/s: 1.7.1 Resolution: Fixed Backported to branch-1 > Fix

[jira] [Reopened] (HBASE-25910) Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.

2021-06-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-25910: -- Reopening for branch-1 backport. > Fix TestClusterPortAssignment.testClusterPortAssignment test

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-02 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-852819067 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25961) Backport HBASE-25596 to branch-2.3

2021-06-02 Thread Anoop Sam John (Jira)
Anoop Sam John created HBASE-25961: -- Summary: Backport HBASE-25596 to branch-2.3 Key: HBASE-25961 URL: https://issues.apache.org/jira/browse/HBASE-25961 Project: HBase Issue Type: Sub-task

[jira] [Comment Edited] (HBASE-24975) HBASE shell update_config doesn't work for master node

2021-06-02 Thread tomscut (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355509#comment-17355509 ] tomscut edited comment on HBASE-24975 at 6/2/21, 6:25 AM: -- Hi [~clarax98007]

[jira] [Commented] (HBASE-24975) HBASE shell update_config doesn't work for master node

2021-06-02 Thread tomscut (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355509#comment-17355509 ] tomscut commented on HBASE-24975: - I had the same problem, but it has now been resolved, see 

[jira] [Commented] (HBASE-25954) When graceful_stop a regionserver, RegionMover always retry to move the regions to other rsgoup's regionservers

2021-06-02 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355507#comment-17355507 ] Baiqiang Zhao commented on HBASE-25954: --- HBASE-22740 was meant to solve this problem, but branch-2