[
https://issues.apache.org/jira/browse/HBASE-28254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799280#comment-17799280
]
Hudson commented on HBASE-28254:
Results for branch branch-2
[build #948 on
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1865552399
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1865542255
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 47s |
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1865536893
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
rahulLiving commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1865536827
@rvaleti @virajjasani I have updated the PR to keep backward compatibility
i.e default is `force=True` now. Please have a look
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HBASE-28254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799255#comment-17799255
]
Hudson commented on HBASE-28254:
Results for branch branch-2.4
[build #669 on
[
https://issues.apache.org/jira/browse/HBASE-28254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799253#comment-17799253
]
Hudson commented on HBASE-28254:
Results for branch branch-2.6
[build #15 on
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1865463652
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1865461008
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1865459813
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Becker Ewing reassigned HBASE-27730:
Assignee: Becker Ewing
> Optimize reference counting in off-heap ByteBuff
>
jbewing commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1865448798
Based on the most recent benchmarking results ([see JIRA
Apache-HBase commented on PR #5593:
URL: https://github.com/apache/hbase/pull/5593#issuecomment-1865446477
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache9 commented on code in PR #5588:
URL: https://github.com/apache/hbase/pull/5588#discussion_r1433450197
##
bin/get-active-master.rb:
##
@@ -24,9 +24,9 @@
java_import org.apache.hadoop.hbase.zookeeper.MasterAddressTracker
# disable debug/info logging on this script for
Apache-HBase commented on PR #5593:
URL: https://github.com/apache/hbase/pull/5593#issuecomment-1865443545
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
[
https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799241#comment-17799241
]
ruanhui commented on HBASE-28271:
-
Yes, you are right, in fact, setting 'hbase.snapshot.zk.coordinated'
Apache-HBase commented on PR #5593:
URL: https://github.com/apache/hbase/pull/5593#issuecomment-1865314075
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5593:
URL: https://github.com/apache/hbase/pull/5593#issuecomment-1865285529
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
NihalJain commented on PR #5594:
URL: https://github.com/apache/hbase/pull/5594#issuecomment-1865278046
FYI @bbeaudreault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799206#comment-17799206
]
Nihal Jain edited comment on HBASE-28216 at 12/20/23 11:34 PM:
---
Ah I
[
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799206#comment-17799206
]
Nihal Jain commented on HBASE-28216:
Ah I deleted the comment thinking I am mistaken and creating
Apache-HBase commented on PR #5593:
URL: https://github.com/apache/hbase/pull/5593#issuecomment-1865272112
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5594:
URL: https://github.com/apache/hbase/pull/5594#issuecomment-1865271533
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5594:
URL: https://github.com/apache/hbase/pull/5594#issuecomment-1865269707
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5594:
URL: https://github.com/apache/hbase/pull/5594#issuecomment-1865262586
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
NihalJain commented on PR #5594:
URL: https://github.com/apache/hbase/pull/5594#issuecomment-1865258878
Logs (with extra debug info) to demonstrate why the tests were failing. It
can be seen the count was not 1 as it was expected in test assertion.
Changed logic to do counting
[
https://issues.apache.org/jira/browse/HBASE-28275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28275:
---
Status: Patch Available (was: Open)
> [Flaky test] Fix 'test_list_decommissioned_regionservers' in
[
https://issues.apache.org/jira/browse/HBASE-28275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28275:
---
Issue Type: Test (was: Bug)
> [Flaky test] Fix 'test_list_decommissioned_regionservers' in
>
jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433255643
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433252640
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433252912
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
[
https://issues.apache.org/jira/browse/HBASE-28256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799200#comment-17799200
]
Becker Ewing commented on HBASE-28256:
--
I've run some updated benchmarks that factor in a few more
[
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799198#comment-17799198
]
Bryan Beaudreault commented on HBASE-28216:
---
I'm happy to take a look. Can you tell me what
bbeaudreault commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433242660
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
[
https://issues.apache.org/jira/browse/HBASE-28275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28275:
---
Description:
See flaky board:
[
https://issues.apache.org/jira/browse/HBASE-28275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28275:
---
Description: See flaky board:
[
https://issues.apache.org/jira/browse/HBASE-28275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28275:
---
Summary: [Flaky test] Fix 'test_list_decommissioned_regionservers' in
TestAdminShell2.java (was:
Nihal Jain created HBASE-28275:
--
Summary: Flaky test: Fix 'list decommissioned regionservers' in
admin2_test.rb
Key: HBASE-28275
URL: https://issues.apache.org/jira/browse/HBASE-28275
Project: HBase
jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433224938
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
[ https://issues.apache.org/jira/browse/HBASE-28216 ]
Nihal Jain deleted comment on HBASE-28216:
was (Author: nihaljain.cs):
Hey [~bbeaudreault] I think there are failures in hbase-shell after this
commit. I see tests failing locally due to
jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433196386
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
[
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799175#comment-17799175
]
Nihal Jain edited comment on HBASE-28216 at 12/20/23 9:18 PM:
--
Hey
[
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799175#comment-17799175
]
Nihal Jain commented on HBASE-28216:
Hey [~bbeaudreault] I think there are failures in hbase-shell
[
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799170#comment-17799170
]
Hudson commented on HBASE-28216:
Results for branch master
[build #968 on
[
https://issues.apache.org/jira/browse/HBASE-28254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799171#comment-17799171
]
Hudson commented on HBASE-28254:
Results for branch master
[build #968 on
[
https://issues.apache.org/jira/browse/HBASE-28270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799169#comment-17799169
]
Hudson commented on HBASE-28270:
Results for branch branch-3
[build #107 on
[
https://issues.apache.org/jira/browse/HBASE-28216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799168#comment-17799168
]
Hudson commented on HBASE-28216:
Results for branch branch-3
[build #107 on
bbeaudreault commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433154777
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
[
https://issues.apache.org/jira/browse/HBASE-28254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799165#comment-17799165
]
Hudson commented on HBASE-28254:
Results for branch branch-2.5
[build #453 on
Apache-HBase commented on PR #5593:
URL: https://github.com/apache/hbase/pull/5593#issuecomment-1865047541
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433097154
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433090992
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
[
https://issues.apache.org/jira/browse/HBASE-26268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Connell updated HBASE-26268:
Status: Patch Available (was: Open)
> AccessController is missing a couple AdminService
charlesconnell opened a new pull request, #5593:
URL: https://github.com/apache/hbase/pull/5593
Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache.
Also, use these new hooks in AccessController to gate access to these
operations. This closes a minor security hole.
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864978265
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864972846
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
bbeaudreault commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433067760
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
Apache-HBase commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864971776
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
bbeaudreault commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433063478
##
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final
jbewing commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864921833
I've done the `readVLong` -> `readVLongTimestamp` refactor in
https://github.com/apache/hbase/pull/5576/commits/9ad49c6623ce6f6d28609d72ac9010f3197e105c.
For the reasons listed above, this
[
https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799124#comment-17799124
]
Viraj Jasani commented on HBASE-28271:
--
Thank you [~frostruan]! I also wonder if setting
chrajeshbabu commented on PR #5568:
URL: https://github.com/apache/hbase/pull/5568#issuecomment-1864862381
+1 lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864859976
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864858088
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
bbeaudreault commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864802424
For branch-2 in that case, I'd probably just create a new readVLongTimestamp
method and annotate the old readVLong method as Deprecated. If a use-case comes
up down the line, we can
Apache-HBase commented on PR #5592:
URL: https://github.com/apache/hbase/pull/5592#issuecomment-1864801548
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
jbewing commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864799163
> I think rename it to readVLongTimestamp is good.
That sounds good—I'll go down that path.
@Apache9 & @bbeaudreault I have a question before proceeding with making
those
Apache-HBase commented on PR #5592:
URL: https://github.com/apache/hbase/pull/5592#issuecomment-1864781197
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5592:
URL: https://github.com/apache/hbase/pull/5592#issuecomment-1864782683
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
anmolnar opened a new pull request, #5592:
URL: https://github.com/apache/hbase/pull/5592
This is not included in Flaky Test reports, but happens quite frequently for
me locally. `testRecover()` passes the expected failure and throws error:
```
java.lang.AssertionError: flush
[
https://issues.apache.org/jira/browse/HBASE-28274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-28274 started by Andor Molnar.
> Flaky test: TestFanOutOneBlockAsyncDFSOutput (Part 2)
>
Andor Molnar created HBASE-28274:
Summary: Flaky test: TestFanOutOneBlockAsyncDFSOutput (Part 2)
Key: HBASE-28274
URL: https://issues.apache.org/jira/browse/HBASE-28274
Project: HBase
Issue
[
https://issues.apache.org/jira/browse/HBASE-28261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799071#comment-17799071
]
Istvan Toth commented on HBASE-28261:
-
Technically, and we could probably write a a meven enforcer
[
https://issues.apache.org/jira/browse/HBASE-28261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799071#comment-17799071
]
Istvan Toth edited comment on HBASE-28261 at 12/20/23 3:39 PM:
---
[
https://issues.apache.org/jira/browse/HBASE-28261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799069#comment-17799069
]
Istvan Toth commented on HBASE-28261:
-
Yes, I was thinking of adding comments in both places.
Any
GeorryHuang commented on code in PR #5559:
URL: https://github.com/apache/hbase/pull/5559#discussion_r1432815568
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNodeLock.java:
##
@@ -40,30 +50,40 @@ class RegionStateNodeLock {
private
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864532113
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache9 commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864505325
> It seems like some of the concern or confusion here is related to the
generic name readVLong. If that method was used to read a _good use case_ for
vlong, the performance at small byte
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864448444
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
bbeaudreault commented on PR #5576:
URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864420597
It seems like some of the concern or confusion here is related to the
generic name readVLong. If that method was used to read a _good use case_ for
vlong, the performance at small
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864402842
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5588:
URL: https://github.com/apache/hbase/pull/5588#issuecomment-1864197795
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864115146
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
zhaomoran commented on code in PR #5581:
URL: https://github.com/apache/hbase/pull/5581#discussion_r1432410587
##
bin/hbase:
##
@@ -496,7 +496,7 @@ add_jdk11_deps_to_classpath() {
}
add_jdk11_jvm_flags() {
- HBASE_OPTS="$HBASE_OPTS
[
https://issues.apache.org/jira/browse/HBASE-28270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-28270.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Merged to branch-3.
Thanks [~nihaljain.cs] for
Apache9 merged PR #5587:
URL: https://github.com/apache/hbase/pull/5587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
86 matches
Mail list logo
